Georges Basile Stavracas Neto
10338a5237
filechooserwidget: Rename callback
...
It's shared between both column and grid views now.
2022-12-13 14:45:15 -03:00
Georges Basile Stavracas Neto
1c5caf53b6
filechooserwidget: Implement 'keynav-failed' for grid view
...
It's exactly the same as of the column view. Since we're sharing
the callback now, rename it to browse_files_view_keynav_failed_cb.
2022-12-13 14:45:15 -03:00
Georges Basile Stavracas Neto
0bb6377a3a
filechooserwidget: Use correct view in various places
...
Most of the pointer comparisons against 'browse_files_column_view'
should actually be performed against the current view widget. As
it turns out, it weren't that many places after all.
2022-12-13 14:45:15 -03:00
Georges Basile Stavracas Neto
ce12ab8307
style: Improve filechooser grid view slightly
2022-12-13 14:45:15 -03:00
Georges Basile Stavracas Neto
27613e3bc5
filechooserwidget: Add a grid view
...
Add a grid view outside of the widgetry tree. The grid view mimics
the column view using bindings, so we only need to manage the column
view.
Also add a button in the path bar section to toggle the view. This
is handled as a new 'toggle-view' action in the file chooser.
The way switching between views currently work is by setting either
the column or grid view as the child of the GtkScrolledWindow. This
has the benefit of unmapping the unused view, which is nice and can
avoid some tricky situations with thumbnails.
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/233
2022-12-13 14:45:15 -03:00
Georges Basile Stavracas Neto
a9be0be32b
filethumbnail: Add 'icon-size' property
...
This will be used by future commits so that we can reuse this widget
in the file chooser grid view.
2022-12-13 14:45:15 -03:00
Matthias Clasen
6b83ded8f0
Merge branch 'harfbuzz-dep' into 'main'
...
build: Use a stable harfbuzz
See merge request GNOME/gtk!5327
2022-12-13 16:15:43 +00:00
Matthias Clasen
cc23ef6eae
build: Use a stable harfbuzz
...
We don't need the latest harfbuzz.
Stick to 4.0 for now.
2022-12-13 09:29:16 -05:00
Matthias Clasen
66b4f2a9dd
Merge branch 'docs/default-args' into 'main'
...
docs: Emphasize requirement to provide filenames as arguments
See merge request GNOME/gtk!5322
2022-12-13 12:17:07 +00:00
andy5995
99d6eb9cb4
docs: Emphasize requirement to give filenames as arguments
...
(related to #5430 )
2022-12-12 23:40:07 -06:00
Matthias Clasen
631b0fa9fd
Merge branch 'sunflowerskater-main-patch-64457' into 'main'
...
appchooser: Rename "application" to "app"
See merge request GNOME/gtk!5323
2022-12-12 16:48:56 +00:00
sunflowerskater
e319b14dc2
appchooserbutton: Rename "application" to "app"
...
This change is a part of an initiative to use the word "app" instead of "application" in the UI:
Teams/Design/initiatives#123
2022-12-11 19:20:12 -03:00
sunflowerskater
c96fefd7f5
appchooserwidget: Rename "application" to "app"
...
This change is a part of an initiative to use the word "app" instead of "application" in the UI:
https://gitlab.gnome.org/Teams/Design/initiatives/-/issues/123
2022-12-11 19:13:51 -03:00
sunflowerskater
b1a9afbdba
appchooser: Rename "application" to "app"
...
This change is a part of an initiative to use the word "app" instead of "application" in the UI: https://gitlab.gnome.org/Teams/Design/initiatives/-/issues/123
2022-12-11 20:05:54 +00:00
Matthias Clasen
6bed0cfb5a
Merge branch 'popover-present-docs' into 'main'
...
popover: Clarify docs
See merge request GNOME/gtk!5318
2022-12-11 04:03:10 +00:00
Matthias Clasen
973a8752ab
Merge branch 'ebassi/image-dispose' into 'main'
...
Do not change the notification queue inside finalization
Closes #5420
See merge request GNOME/gtk!5321
2022-12-11 04:02:49 +00:00
Matthias Clasen
db3b216ad1
Merge branch 'builder-scope-note' into 'main'
...
builderscope: Add a note for implementors
See merge request GNOME/gtk!5317
2022-12-11 01:07:21 +00:00
Emmanuele Bassi
b3b5a5064e
Do not change the notification queue inside finalization
...
Notifications are not going to be emitted during the finalization, and
GObject will warn if you try to acquire and release a reference to the
notification queue when the reference count of an object has reached
zero.
Fixes : #5420
2022-12-11 00:36:03 +00:00
Matthias Clasen
5c70f2ae9b
builderscope: Add a note for implementors
...
Recommend that scope implementations should fall
back to or derive from GtkBuilderCScope in order
to not lose GTK's type-guessing machinery.
Related: #5398
2022-12-10 17:12:02 -05:00
Matthias Clasen
5df9f4016e
popover: Clarify docs
...
gtk_popover_present() is a misleadingly named
function, so at least give it clear docs that
tell people to use gtk_popover_popup() instead.
2022-12-10 16:36:00 -05:00
Matthias Clasen
6f7a4b67c2
Merge branch 'docs/deprecated-G_APPLICATION_FLAGS_NONE' into 'main'
...
docs: Update deprecated G_APPLICATION_FLAGS_NONE in examples
See merge request GNOME/gtk!5315
2022-12-10 20:53:09 +00:00
andy5995
6e7ecb02f1
docs: Update deprecated G_APPLICATION_FLAGS_NONE
2022-12-10 01:12:13 -06:00
Matthias Clasen
146cf0bdd4
Merge branch 'deprecate-keys-changed' into 'main'
...
treeview: Drop a few unused variables
See merge request GNOME/gtk!5314
2022-12-09 19:03:01 +00:00
Matthias Clasen
40d54ad3eb
window: Deprecate the ::keys-changed signal
2022-12-09 13:14:27 -05:00
Matthias Clasen
a9b387b37b
tests: Silence a compiler warning
2022-12-09 13:13:24 -05:00
Matthias Clasen
12f9883599
treeview: Drop a few unused variables
...
Compilers get pickier every year...
2022-12-09 13:12:47 -05:00
Matthias Clasen
4e23fe896e
composetable: Drop an unused variable
2022-12-09 13:09:34 -05:00
Olga Smirnova
0effe1fd07
Add Interlingue translation
2022-12-09 17:24:41 +00:00
Matthias Clasen
a07bf1a047
Merge branch 'dialog-fixes' into 'main'
...
filechooserwidget: Fixes
See merge request GNOME/gtk!5311
2022-12-09 16:22:00 +00:00
Matthias Clasen
42cd230d44
openuriportal: Better error handling
...
Nested async calls are always a challenge.
Hopefully, things are straightened out now,
and we report GTK_DIALOG_ERROR errors for
the cases we care about.
2022-12-09 11:05:48 -05:00
Matthias Clasen
bc8e19fcd0
openuriportal: Add a check function
...
Add private API to check whether the portal
is available.
2022-12-09 11:05:48 -05:00
Matthias Clasen
ae29fee903
openuriportal: Support OpenDirectory
...
This required an extra argument. Update all callers.
2022-12-09 11:05:48 -05:00
Matthias Clasen
7ad0bae12f
openuriportal: Cosmetics
...
There were some copy-paste errors.
2022-12-09 11:05:48 -05:00
Matthias Clasen
3e11ea9ddf
fontdialog: Improve docs
...
Be more specific about possible errors.
2022-12-09 11:05:48 -05:00
Matthias Clasen
5b6c98d589
colordialog: Improve the docs
...
Be more specific about possible errors.
2022-12-09 11:05:48 -05:00
Matthias Clasen
57082e2e40
fontdialog: Don't forget to propagate errors
...
Oops.
2022-12-09 11:05:48 -05:00
Matthias Clasen
45e3e1594f
fontdialogbutton: Survive window closing
...
If the parent window of the button gets destroyed
while the dialog is open, we cancel the async op,
but we need to be a little more careful about not
stepping on glass.
2022-12-09 11:05:48 -05:00
Matthias Clasen
637ef84d04
colordialogbutton: Survive window closing
...
If the parent window of the button gets destroyed
while the dialog is open, we cancel the async op,
but we need to be a little more careful about not
stepping on glass.
2022-12-09 11:05:48 -05:00
Matthias Clasen
b297baed32
fontdialog: Unset check cancellable
2022-12-09 11:05:48 -05:00
Matthias Clasen
c45f172e79
colordialog: Unset check cancellable
2022-12-09 11:05:48 -05:00
Matthias Clasen
417382375b
filedialog: Report cancellation propertly
...
Unless we prevent it, GTask will always report
cancellation as G_IO_ERROR_CANCELLED. But we
want GTK_DIALOG_ERROR_ABORTED for this case.
2022-12-09 11:05:48 -05:00
Matthias Clasen
2e90a752eb
filechooserwidget: Fixes
...
Fix a memory leak in the file manager launch path.
2022-12-09 11:05:48 -05:00
Matthias Clasen
abe5181b10
Merge branch 'wip/corey/column-view-header' into 'main'
...
columnviewtitle: Prevent header clicks from propagating
Closes #5425
See merge request GNOME/gtk!5306
2022-12-09 15:28:58 +00:00
Matthias Clasen
585b6a3637
Merge branch 'matthiasc/node-editor-srcdir' into 'main'
...
node-editor: Redo saving location
Closes #5403
See merge request GNOME/gtk!5310
2022-12-09 15:22:00 +00:00
Matthias Clasen
3007b0fd7f
Remove leftover debug spew
2022-12-09 10:04:42 -05:00
Matthias Clasen
96b9ac84f8
node-editor: Redo saving location
...
Determine the location to save testcases in dynamically,
trying first a GTK_SOURCE_DIR environment variable
and then the current directory as the GTK source dir,
ultimatively falling back to just saving in the current
directory.
This avoids leaking details of the build environment
into the produced artifacts and should make GTK builds
more reproducible.
Fixes : #5403
2022-12-09 09:35:32 -05:00
Matthias Clasen
860c2f8ddd
Merge branch 'fix-file-dialog-title' into 'main'
...
filedialog: Use title if set
Closes #5415
See merge request GNOME/gtk!5308
2022-12-08 13:16:55 +00:00
Matthias Clasen
de83d57e14
filedialog: Use title if set
...
This broken when the code was reshuffled into
the switch.
Fixes : #5415
2022-12-08 07:57:16 -05:00
Matthias Clasen
9de963e8b4
Merge branch 'wip/carlosg/stale-timeout' into 'main'
...
gdk/x11: Clear all data in GdkSurfaceX11 finalization
See merge request GNOME/gtk!5303
2022-12-08 12:18:37 +00:00
Matthias Clasen
5e92c26b9a
Merge branch 'macos-unused-vars' into 'main'
...
macos: remove unused variables from macos code
See merge request GNOME/gtk!5290
2022-12-08 12:17:13 +00:00