Timm Bäder
10439aaefe
menu: Remove an unnecessary gtk_widget_destroy() call
...
The unref will already properly free the menu item's resources.
2018-08-18 20:54:29 +02:00
Matthias Clasen
099b967885
Don't fail the build if c++ isn't found
...
The intention of this check was to skip the keyword
test if no c++ compiler is found. But the meson
docs say that add_languages() will abort unless we
pass required: false.
2018-08-18 02:14:56 +00:00
Matthias Clasen
d13cd9cb67
Merge branch 'fix-shell-colorpicker' into 'master'
...
colorpickershell: Unpack the tuple returned from PickColor()
See merge request GNOME/gtk!296
2018-08-17 12:35:46 +00:00
Matthias Clasen
79b87cc543
print portal: don't leak window handles
...
Pointed out by Christian Persch.
Closes https://gitlab.gnome.org/GNOME/gtk/issues/1274
2018-08-15 23:21:15 +00:00
Matthias Clasen
3c2aceba63
print portal: Plug a memory leak
...
Pointed out by Christian Persch.
Closes https://gitlab.gnome.org/GNOME/gtk/issues/1271
2018-08-15 23:13:15 +00:00
Matthias Clasen
a01feae15b
Use defines for bus names
...
This helps eradicate typos (we had some here).
Closes https://gitlab.gnome.org/GNOME/gtk/issues/1267
2018-08-15 15:54:34 -07:00
Matthias Clasen
b4d4f73d9f
Merge branch 'sort' into 'master'
...
updateiconcache: Sort list of entries
See merge request GNOME/gtk!297
2018-08-15 22:00:13 +00:00
Matthias Clasen
c1de6219ed
font chooser: Remove an unneeded ifdef
...
We can just always create the axes hashtable.
2018-08-15 14:52:37 -07:00
Bernhard M. Wiedemann
b364827a5b
updateiconcache: Sort list of entries
...
because filesystem readdir order is indeterministic.
Without this patch, building openSUSE's balsa package
had variations between builds in /usr/share/balsa/icon-theme.cache
2018-08-15 03:15:14 +02:00
Matthias Clasen
bbe362d015
Merge branch 'master' into 'master'
...
window: Fix memory leak
See merge request GNOME/gtk!295
2018-08-13 19:33:56 +00:00
Iain Lane
08f32c6560
colorpickershell: Unpack the tuple returned from PickColor()
...
When calling PickColor on org.gnome.Shell, we get back an "a{sv}", which
GDBus provides to us as "(a{sv})".
At the minute we're not unpacking this tuple, and so picking fails with
messages like:
GLib-CRITICAL **: 13:38:19.439: g_variant_lookup_value: assertion 'g_variant_is_of_type (dictionary, G_VARIANT_TYPE ("a{s*}")) || g_variant_is_of_type (dictionary, G_VARIANT_TYPE ("a{o*}"))' failed
Gtk-WARNING **: 13:38:19.439: Picking color failed: No color received
Let's unpack it.
2018-08-13 13:52:41 +01:00
Yi-Soo An
b3c8c8e592
window: Fix memory leak
...
https://gitlab.gnome.org/GNOME/gtk/issues/1268
2018-08-13 17:21:42 +09:00
Emin Tufan Çetin
ed36933232
Update Turkish translation
2018-08-12 10:47:44 +00:00
Piotr Drąg
a90fc088f2
Update Polish translation
2018-08-12 00:01:28 +02:00
Matthias Clasen
ff6c4ed07e
Merge branch 'gtk-4-improve-error-message' into 'master'
...
gtkplacessidebar: Improve error message when unlocking volume fails
See merge request GNOME/gtk!267
2018-08-07 10:01:09 +00:00
Piotr Drąg
201f635559
Update Polish translation
2018-08-06 19:01:40 +02:00
Matthias Clasen
59077e4843
migration guide: Mention GtkEventBox
...
Its gone.
Closes: https://gitlab.gnome.org/GNOME/gtk/issues/1243
2018-08-05 19:53:02 -04:00
Carlos Soriano
3e6a473082
README: Fix Gdk doc website link
2018-08-05 21:59:27 +00:00
Carlos Soriano
580d96620e
README: Document nightly docs location
...
Useful for exposing the documentation early.
2018-08-05 20:41:29 +00:00
segfault
61f50f2410
gtkplacessidebar: Improve error message when unlocking volume fails
2018-08-05 18:59:40 +02:00
Aurimas Černius
61b2f3c996
Updated Lithuanian translation
2018-08-05 16:06:33 +03:00
Timm Bäder
ab30850aad
widget: Rename width and height member to {width,height}_request
...
Because that's much closer to the meaning of those values.
2018-08-05 10:22:11 +02:00
Timm Bäder
f5e04b59e9
main: Pass toplevel_widget directly to GtkWidget API
...
We already have the toplevel as GtkWidget: toplevel_widget.
2018-08-05 10:22:10 +02:00
Timm Bäder
c67bcf09b9
sizerequestcache: Inline out-var assignments
...
The additional assignment to the old result variable just adds an
indirection even though we know the point where we assign it in all
cases. Just pass the values out and return in those cases instead.
2018-08-05 10:22:10 +02:00
Timm Bäder
5eba0bc932
widgetprivate: Remove useless prototype
...
We implement that function lower down in that header file.
2018-08-05 10:22:10 +02:00
Timm Bäder
ff2ba52bc6
pathbar: Remove priv pointer
2018-08-05 10:22:10 +02:00
Timm Bäder
a822d6fce9
menuitem: Don't redraw unnecessarily
...
The gtk_widget_(un)set_state_flags calls before will do this if
necessary.
2018-08-05 10:22:10 +02:00
Timm Bäder
b749fe4270
menu: Use correct content height
2018-08-05 10:22:10 +02:00
Timm Bäder
933cb857cf
menu: Allocate children according to scroll_offset
...
This was done by simply moving the bin_window before but now we have to
do it ourselves.
2018-08-05 10:22:10 +02:00
Timm Bäder
dde535bbdf
levelbar: Don't return a double value from a gboolean function
2018-08-05 10:22:10 +02:00
Timm Bäder
71b36db88d
acitonbar: Remove snapshot implementation
2018-08-05 10:22:10 +02:00
Timm Bäder
b5576397f7
modelbutton: Remove snapshot implementation
...
Previously, GtkBin was only snapshot'ing its one and only child, but
nowadays it doesn't implement snapshot at all and the default
implementation in GtkWidget just snapshots all child widgets, which is
exactly what the implementation in gtkmodelbutton.c was doing.
2018-08-05 10:22:10 +02:00
Matthias Clasen
4e86858405
Make color picker circular
...
The need for center alignment was pointed out by Timm Baeder.
2018-08-04 21:42:28 -04:00
Mario Blättermann
35829a7272
Update German translation
2018-08-04 11:25:21 +00:00
Ernestas Kulik
0eb60fb03e
Merge branch 'sidebar-spinner-visibility' into 'master'
...
sidebarrow: Hide busy_spinner by default
See merge request GNOME/gtk!285
2018-08-03 10:45:04 +00:00
Ernestas Kulik
94162197a1
sidebarrow: Hide busy_spinner by default
...
Since the original implementation was likely based on GTK+ 3, the change
in default visibility might have not been considered, which results in
all rows suddenly sporting a visible spinner when opening a fresh file
chooser.
2018-08-03 13:29:07 +03:00
Matthias Clasen
877fffdd5e
Merge branch 'fix-app-id' into 'master'
...
Make xdg-shell's app_id match GApplication's application-id property
Closes #653
See merge request GNOME/gtk!284
2018-08-03 02:09:09 +00:00
Matthias Clasen
8669d31c30
color picker: Also try kwin
...
use a kwin color picker when we run under kwin.
2018-08-02 20:55:07 -04:00
Matthias Clasen
e76d17a786
Only use the portal color picker when appropriate
...
This is just moving this check around.
2018-08-02 20:54:21 -04:00
Matthias Clasen
5ab90f1a80
Add a kwin color picker
...
This uses the org.kde.kwin.ColorPicker interface.
2018-08-02 20:53:37 -04:00
Benjamin Otte
5b1fd111d1
Merge branch 'gbsneto/issue-1258' into 'master'
...
listbox: Unparent child after removing from sequence
Closes #1258
See merge request GNOME/gtk!283
2018-08-02 14:14:10 +00:00
Georges Basile Stavracas Neto
5596feae9b
listbox: Store child iter in a variable when removing
...
Unparenting a GtkListBoxRow can drop its last reference, which
will free its memory. Right after unparenting, though, we were
accessing the row's iter - which assumes that the row is still
alive. This causes a crash when, for example, binding two or
more models to the listbox.
Fix that by storing the iter in a variable, and not trying to
access it after unparenting. After unparenting, the variables
that are potentially garbage were explicitly assigned NULL for
clarity.
Fixes https://gitlab.gnome.org/GNOME/gtk/issues/1258
2018-08-02 10:24:12 -03:00
Guido Günther
8fb8303ba0
demos: Make desktop file names match the application id
2018-08-02 12:15:43 +02:00
Guido Günther
06e4c3c991
examples: Use appliction id as desktop file base name
2018-08-02 11:10:21 +02:00
Guido Günther
f25f3b3c47
docs: Explain desktop file id == application_id in migration guide
2018-08-02 11:10:21 +02:00
Guido Günther
72ec8963d7
gdk: Use application_id as xdg_shell's app_id if available
...
This (manually) reverts commit e1fd87728d
This makes sure xdg_shell's app_id matches the DBus name of the the
appliation when using GtkApplication. It also allows the compositor to
derive the desktop file ID from the app_id:
https://cgit.freedesktop.org/wayland/wayland-protocols/tree/stable/xdg-shell/xdg-shell.xml?id=298d888ac718eae57ff2245d373d4327074506ea#n598
Closes #653
2018-08-02 11:03:41 +02:00
Benjamin Otte
50d5666db0
container: Remove focus chains
...
They're prectically unused.
Widgets who want to influcence the focus chain behavior should implement
GtkWidgetClass::focus and deal with focus there.
2018-07-31 22:34:27 +02:00
Benjamin Otte
e06044530f
widgetfocus: Fix copy/paste error
...
This lead to erratic focus behavior with <Tab> in hboxes, where the
smallest child got focus first instead of the leftmost child.
2018-07-31 22:34:27 +02:00
Benjamin Otte
7ce7e5503f
colorpicker: Fix gcc warning
2018-07-31 22:34:27 +02:00
Matthias Clasen
0ba307995d
Mention gtk_widget_show_all in the migration guide
...
This function is gone.
Closes https://gitlab.gnome.org/GNOME/gtk/issues/1242
2018-07-31 13:38:10 -04:00