Commit Graph

2470 Commits

Author SHA1 Message Date
Owen Taylor
c860d735bd Oct 26 20:55:57 2001 Owen Taylor <otaylor@redhat.com>
* gtk/gtkbutton.c: Revert changes to GTK_RUN_LAST.
        Unfortunately, people apparently erroneously connect
        to ::clicked for GtkToggleButton and expect
        they know what happened in the default signal handler
        instead of appropriately connecting to notification
        signal ::toggled. When the revolution comes, such
        people will be first against the wall.

        We'll just have to go back to the old less-reliable
        set-it-back hacks for handling model-view toggle
        buttons and entries. :-(.
2001-10-27 00:59:51 +00:00
Hans Breuer
e2e6940366 to simplify parsing for exported functions: - made implementation
2001-10-27  Hans Breuer  <hans@breuer.org>

	* gtk/gtkbbox.c gtk/gtkctree.c gtk/gtkhbbox.c
	  gtk/gtkimmulticontext.c gtk/gtklabel.c gtk/gtkliststore.c
	  gtk/gtkmenu.c gtk/gtkpaned.c gtk/gtkrc.c gtk/gtkscale.c
	  gtk/gtkstyle.c gtk/gtktextbuffer.c gtk/gtktextlayout.c
	  gtk/gtktexttag.c gtk/gtktexttagtable.c gtk/gtktextview.c
	  gtk/gtktreestore.c gtk/gtkvbbox.c :
	to simplify parsing for exported functions:
	- made implementation signature static, when the local
	  prototype already was
	- put the functions return value on it's own line
	- added as space between the function name and the
	  opening bracket

	* gtk/gtk.def : added the remaining exported functions
2001-10-27 00:41:12 +00:00
Anders Carlsson
ed96ad827c Add note about width having to be greater than 0. This fixes #55574.
2001-10-27  Anders Carlsson  <andersca@gnu.org>

	* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_set_fixed_width):
	Add note about width having to be greater than 0. This fixes
	#55574.
2001-10-27 00:25:17 +00:00
Anders Carlsson
110970bfc6 Fix docs to say previous instead of next.
2001-10-27  Anders Carlsson  <andersca@gnu.org>

	* gtk/gtktextiter.c (gtk_text_iter_backward_sentence_start):
	Fix docs to say previous instead of next.
	(gtk_text_iter_backward_word_start): Likewise.
	This fixes bug #62980.
2001-10-27 00:18:23 +00:00
Anders Carlsson
bb8ea8c470 Mention that the valid width is in range 0-65535 pixels. Fixes bug #56754.
2001-10-27  Anders Carlsson  <andersca@gnu.org>

	* gtk/gtkcontainer.c (gtk_container_set_border_width): Mention
	that the valid width is in range 0-65535 pixels. Fixes bug
	#56754.
2001-10-27 00:03:13 +00:00
Anders Carlsson
16f42cbdc1 Remove a dot in the documentation. Fixes bug #62632.
2001-10-27  Anders Carlsson  <andersca@gnu.org>

	* gtk/gtksizegroup.c (gtk_size_group_set_mode): Remove
	a dot in the documentation. Fixes bug #62632.

This has got to be the most useful bug I have ever fixed :)
2001-10-26 23:47:38 +00:00
Anders Carlsson
dcb9a6e16e Replace int and guint with long and gulong in some places to make the code
2001-10-27  Anders Carlsson  <andersca@gnu.org>

	* gdk/x11/gdkmain-x11.c: Replace int and guint with
	long and gulong in some places to make the code 64-bit
	clean.
	(_gdk_windowing_init_check): Replace gint with gulong.
	This patch was made by George Lebl and fixes bug #62113.
2001-10-26 23:43:16 +00:00
Anders Carlsson
78fca9fd05 Set up destroy signals so that all windows will be destroyed when one is.
2001-10-27  Anders Carlsson  <andersca@gnu.org>

	* tests/testgtk.c
	(create_window_states): Set up destroy signals so that
	all windows will be destroyed when one is. This fixes
	bug #58133.
2001-10-26 23:37:21 +00:00
Anders Carlsson
dc0772a2b9 Don't set a fixed height on the hscale widget. This fixes "bug" #55840.
2001-10-27  Anders Carlsson  <andersca@gnu.org>

	* tests/testgtk.c (create_range_controls): Don't set a
	fixed height on the hscale widget. This fixes "bug"
	#55840.
2001-10-26 23:06:43 +00:00
Anders Carlsson
fdb66f1ab4 Create new "indent_expander" style property.
2001-10-26  Anders Carlsson  <andersca@gnu.org>

	* gtk/gtktreeview.c:
	(gtk_tree_view_class_init): Create new "indent_expander"
	style property.

	(gtk_tree_view_get_arrow_xrange): Add a tree argument
	to the function since the xrange can change depending
	on where in the tree we are.

	(coords_are_over_arrow): Update function call to
	gtk_tree_view_get_arrow_xrange.
	(gtk_tree_view_draw_arrow): Likewise.

	(gtk_tree_view_real_expand_collapse_cursor_row):
	Call real_{expand|collapse}_row, so that we'll have an
	animation.
2001-10-26 19:45:06 +00:00
Kristian Rietveld
ad29f522b5 fixed a small typo
Fri Oct 26 20:13:36 2001  Kristian Rietveld  <kristian@planet.nl>

        * tests/Makefile.am: fixed a small typo
2001-10-26 18:12:34 +00:00
Kristian Rietveld
d84a4acbb7 Anders Carlsson suggested to use G_N_ELEMENTS here
Fri Oct 26 18:27:11 2001  Kristian Rietveld  <kristian@planet.nl>

        * demos/gtk-demo/list_store.c (create_model): Anders
        Carlsson suggested to use G_N_ELEMENTS here
2001-10-26 16:31:01 +00:00
Sven Neumann
5a6d127d7b gtk/gtkbutton.[ch] fixed inline comments
2001-10-26  Sven Neumann  <sven@gimp.org>

	* gtk/gtkbutton.[ch]
	* gtk/gtkdnd.c: fixed inline comments

	* gtk/gtkgamma.c: gtk_entry_get_text() returns a const gchar.
2001-10-26 15:41:46 +00:00
Hans Breuer
11e6236bec updated externals
2001-10-26  Hans Breuer  <hans@breuer.org>

	* gdk-pixbuf/gdk_pixbuf.def :
	* gdk/gdk.def :
	* gtk/gtk.def : updated externals

	* gdk/win32/gdkpixmap-win32.c : removed duplicate of
	gdk_window_lookup implementation. It already was in
	gdk/win32/gdkwindow-win32.c

	* gdk/win32/gdkproperty-win32.c : made it compile again
	after GdkAtom API change

	* gtk/gtk/makefile.msc.in : updated
2001-10-26 14:38:12 +00:00
Owen Taylor
ec30380628 Version 1.3.10, require GLib 1.3.10.
Wed Oct 24 11:36:33 2001  Owen Taylor  <otaylor@redhat.com>

        * configure.in (GTK_MICRO_VERSION): Version 1.3.10,
        require GLib 1.3.10.

        * NEWS: updates.
2001-10-25 21:07:53 +00:00
Jonathan Blandford
889d64b46e Add support for invalid nodes. (_gtk_rbnode_rotate_right): Ditto.
Thu Oct 25 16:27:29 2001  Jonathan Blandford  <jrb@redhat.com>

	* gtk/gtkrbtree.c (_gtk_rbnode_rotate_left): Add support for
	invalid nodes.
	 (_gtk_rbnode_rotate_right): Ditto.
	 (_gtk_rbtree_node_mark_invalid): New function.
	 (_gtk_rbtree_node_mark_valid): New function.

	* gtk/gtktreemodelsort.c (gtk_tree_model_sort_class_init): We're a
	GObject, not a GtkObject.
	(gtk_tree_model_sort_row_has_child_toggled): Rewrote to be more
	correct.
	(gtk_tree_model_sort_row_deleted): ditto.
	(gtk_tree_model_sort_{un,}ref_node): Fix.

	* gtk/gtktreeview.c: Protean incremental reflow support (commented
	out)

	* gtk/gtktreeview.h (GtkTreeViewSearchEqualFunc): change char *key
	to const char *key.

	* gtk/gtktreemodel.c (gtk_tree_row_reference_unref_path_helper):
	Important 1 line fix to fix a lot of refcounting woes.
2001-10-25 20:32:40 +00:00
Matt Wilson
bbd503bc6c call gtk_text_view_destroy_layout after gtk_text_view_set_buffer (which
2001-10-25  Matt Wilson  <msw@redhat.com>

	* gtk/gtktextview.c (gtk_text_view_destroy): call
	gtk_text_view_destroy_layout after gtk_text_view_set_buffer (which
	now invalidates) so that we remove our idle functions.
	(gtk_text_view_destroy_layout): remove the first_validate_idle as
	well.
2001-10-25 17:05:35 +00:00
Matt Wilson
2a3d5739ed remove conflict mark 2001-10-25 15:17:57 +00:00
Matt Wilson
d8bd40f744 the valid range for the 'indent' property is G_MININT to G_MAXINT. Don't
2001-10-25  Matt Wilson  <msw@redhat.com>

	* gtk/gtktexttag.c (gtk_text_tag_class_init): the valid range for
	the 'indent' property is G_MININT to G_MAXINT.  Don't use
	-G_MAXINT for the minimum of the 'rise' property, use G_MININT
	instead.
2001-10-25 14:02:51 +00:00
Anders Carlsson
aa3a4f7e92 This ought to make msw happy since it fixes #62887.
2001-10-24  Anders Carlsson  <andersca@gnu.org>

	* gtk/gtktreeview.c:
	(gtk_tree_view_real_expand_row): add an animate argument
	(gtk_tree_view_real_collapse_row): likewise

	(gtk_tree_view_button_press), (gtk_tree_view_button_release),
	(gtk_tree_view_collapse_all), (gtk_tree_view_expand_row),
	(gtk_tree_view_collapse_row): update functions that call
	real_{expand|collapse}_row to set the animate argument
	accordingly.
2001-10-25 05:22:13 +00:00
Alex Larsson
b4187613f4 Update to new Pango APIs
2001-10-24  Alex Larsson  <alexl@redhat.com>

	* gdk/linux-fb/gdkfont-fb.c:
	Update to new Pango APIs

	* gdk/linux-fb/gdkproperty-fb.c:
	Update to new GdkAtom APIs

	* gdk/linux-fb/gdkwindow-fb.c:
	Remove warnings
2001-10-24 23:41:12 +00:00
Jonathan Blandford
74b4914191 Fix docs, #62808
Mon Oct 22 20:07:21 2001  Jonathan Blandford  <jrb@redhat.com>

	* gtk/gtktreestore.c (gtk_tree_store_prepend): Fix docs, #62808
2001-10-24 22:54:59 +00:00
Kristian Rietveld
c9e39b2a34 treat s_path as a child path
Wed Oct 24 22:54:07 2001  Kristian Rietveld  <kristian@planet.nl>

        * gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted): treat
        s_path as a child path
2001-10-24 20:54:32 +00:00
Kristian Rietveld
beaba6a43c more changes in an attempt to get it right. It's not yet ready for general
Wed Oct 24 20:29:47 2001  Kristian Rietveld  <kristian@planet.nl>

        * gtk/gtktreemodelsort.c: more changes in an attempt to get
        it right. It's not yet ready for general consumption.

        * tests/treestoretest.c: add a button and entry for the new
        iter_change function
        (iter_change): new function, to test
        the row_changed signal implementation of the GtkTreeModelSort

        * tests/testtreesort.c: cleanups, changes to test more features
        of the GtkTreeModelSort at once
2001-10-24 18:36:50 +00:00
Havoc Pennington
9b7d528ac2 remove hack to strip off the bogus newline, since we killed the bogus
2001-10-24  Havoc Pennington  <hp@redhat.com>

	* gtk/gtktextbuffer.c (clipboard_clipboard_buffer_received):
	remove hack to strip off the bogus newline, since we killed the
	bogus newline; fixes #61779
2001-10-24 17:51:56 +00:00
Havoc Pennington
87b1f40198 forgot to save ChangeLog after adding a phrase 2001-10-24 16:24:07 +00:00
Havoc Pennington
4e8cbdca6b don't create layout if we didn't have one (gtk_text_view_set_buffer):
2001-10-24  Havoc Pennington  <hp@redhat.com>

	* gtk/gtktextview.c (gtk_text_view_update_adjustments): don't
	create layout if we didn't have one
	(gtk_text_view_set_buffer): invalidate so we get the idle handlers
	as appropriate, avoids blanking the screen
	(gtk_text_view_invalidate): new function to do invalidation,
	containing old guts of invalidated_handler
2001-10-24 16:11:41 +00:00
Owen Taylor
679ca1ae86 Improve dreadful tooltips.
Wed Oct 24 10:29:47 2001  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtkalignment.c (gtk_alignment_class_init): Improve
	dreadful tooltips.
2001-10-24 14:30:39 +00:00
Owen Taylor
b7c639eafe Always set window->parent (except or the root window itself); if the
Tue Oct 23 17:31:42 2001  Owen Taylor  <otaylor@redhat.com>

	* gdk/x11/gdkwindow-x11.c gdk/win32/gdkwindow-win32.c: Always
	set window->parent (except or the root window itself); if
	the window's parent is not a GdkWindow, or is a window of
        type GDK_WINDOW_FOREIGN, set window->parent to the root parent.

	* gdk/gdkwindow.c (gdk_window_get_toplevels): Don't include
	windows of type GDK_WINDOW_FOREIGN.
2001-10-24 14:15:50 +00:00
Havoc Pennington
da4a311279 if we move to the front of a segment, use the "slow" technique for moving
2001-10-24  Havoc Pennington  <hp@pobox.com>

	* gtk/gtktextiter.c (gtk_text_iter_backward_chars): if we move to
	the front of a segment, use the "slow" technique for moving
	backward, so we don't mess up the any_segment field in the iter.
	Fixes #57707

	* tests/testtextbuffer.c: add code to detect #57707, to avoid
	regression
2001-10-24 04:48:21 +00:00
Havoc Pennington
fa4e7a31fd only sensitize Cut if selection contains some editable text, #60975
2001-10-23  Havoc Pennington  <hp@redhat.com>

	* gtk/gtktextview.c (popup_targets_received): only sensitize Cut
	if selection contains some editable text, #60975
	(gtk_text_view_scroll_to_iter): remove warning about scrolling
	prior to map; it should actually be OK to do so in many cases,
	it would be nice to warn about scrolling when many lines have
	height 0, but I don't know what to do about that. Perhaps
	move part of flush_scroll into this function? comment added
	to consider this.
2001-10-23 23:35:00 +00:00
Havoc Pennington
14cc0e8f77 Correctly keep the same text on the top of the screen, considering that
2001-10-23  Havoc Pennington  <hp@redhat.com>

	* gtk/gtktextview.c (changed_handler): Correctly keep the same
	text on the top of the screen, considering that the changed region
	may have overlapped the first paragraph. Should fix msw's "text
	widget scrolled to wrong place on map" bug, and probably some
	other scrolling cases as well.
	(gtk_text_view_set_scroll_adjustments): start adjustments at 0.0,
	instead of some random value

	* gtk/gtktextview.c (gtk_text_view_class_init): actually override
	grab_focus, so #59708 is really fixed
2001-10-23 23:06:14 +00:00
Anders Carlsson
fd3196d9ed Use an image menu item here (popup_targets_received): Call
2001-10-24  Anders Carlsson  <andersca@gnu.org>

	* gtk/gtkentry.c: (append_action_signal): Use an image menu item here
	(popup_targets_received): Call append_action_signal with stock items

	* gtk/gtklabel.c: (append_action_signal): Use an image menu item here
	(gtk_label_do_popup): Call append_action_signal with stock items

	* gtk/gtktextview.c: (append_action_signal): Use an image menu item here
	(popup_targets_received): Call append_action_signal with stock items
2001-10-23 22:43:01 +00:00
Havoc Pennington
b6ba7a5f04 queue a resize here; will temporarily slow down the widget a lot, until we
2001-10-23  Havoc Pennington  <hp@redhat.com>

	* gtk/gtktextview.c (changed_handler): queue a resize here; will
	temporarily slow down the widget a lot, until we figure out how to
	optimize to avoid full redraw everytime we queue a resize
2001-10-23 20:13:44 +00:00
Havoc Pennington
10f47690ea handle case where offset == 0 and char_len == 0, bug #61729
2001-10-23  Havoc Pennington  <hp@redhat.com>

	* gtk/gtktextiter.c (test_log_attrs): handle case where offset ==
	0 and char_len == 0, bug #61729
2001-10-23 19:31:56 +00:00
Havoc Pennington
85cdc1cec3 fix return value, #61714 (Vitaly Tishkov)
2001-10-23  Havoc Pennington  <hp@redhat.com>

	* gtk/gtktextiter.c (gtk_text_iter_forward_cursor_positions): fix
	return value, #61714 (Vitaly Tishkov)
	(gtk_text_iter_backward_sentence_starts): ditto
	(gtk_text_iter_backward_word_starts): ditto
	(gtk_text_iter_forward_word_ends): ditto
	(gtk_text_iter_forward_sentence_ends): ditto
	(gtk_text_iter_backward_cursor_positions): ditto
2001-10-23 19:19:10 +00:00
Havoc Pennington
9894b89bd9 Apply fix from Dov Grobgeld, #61858
2001-10-23  Havoc Pennington  <hp@redhat.com>

	* gtk/gtktextlayout.c (gtk_text_layout_get_iter_at_pixel): Apply
	fix from Dov Grobgeld, #61858
2001-10-23 17:45:33 +00:00
Havoc Pennington
bd3b53c4c7 credit Hidetoshi 2001-10-23 17:26:57 +00:00
Havoc Pennington
cfcf83664b Update IM spot location at appropriate times, #50626
2001-10-23  Havoc Pennington  <hp@redhat.com>

	* gtk/gtktextview.c (gtk_text_view_update_im_spot_location):
	Update IM spot location at appropriate times, #50626
2001-10-23 17:26:13 +00:00
Havoc Pennington
dceeec3521 remove conflict markers 2001-10-23 16:17:15 +00:00
Havoc Pennington
13a24b1b36 scroll to cursor on grab focus, unless it's caused by button click, #59708
2001-10-23  Havoc Pennington  <hp@redhat.com>

	* gtk/gtktextview.c (gtk_text_view_grab_focus): scroll to cursor
	on grab focus, unless it's caused by button click, #59708
2001-10-23 16:07:05 +00:00
Owen Taylor
4e32ede287 Remove G_DISABLE_CONST_RETURNS.
Tue Oct 23 11:53:00 2001  Owen Taylor  <otaylor@redhat.com>

	* gtk/Makefile.am (INCLUDES): Remove G_DISABLE_CONST_RETURNS.

	* gtk/gtkfontsel.[ch]: Make gtk_font_selection_get_font()
	G_CONST_RETURN. (Murray Cumming)

	* gtk/gtkfontsel.c (gtk_font_selection_dialog_get_preview_text):
	Make G_CONST_RETURN.

	* gtk/gtkfilesel.c (open_user_dir): Fix bug with freeing
	results of g_get_home_dir().

	* gtk/gtkfilesel.c: Make filesel->fileop_file a duplicated
	copy. Storing the return from gtk_entry_get_text() is evil.

	* gtk/gtkcombo.c gtk/gtkcellrenderertext.c gtk/gtkbindings.c
	gtk/gtkfilesel.c gtk/gtkfontsel.c gtk/gtkimmodule.c
	gtk/gtkobject.c gtk/gtkoldeditable.c gtk/gtktreedatalist.c
	gtk/gtksignal.c: Add const.

	* gdk/x11/gdkkeys-x11.c (get_direction): Add missing const.

	* gtk/gtktreeview.c: Namespace object data keys to be safe, even
	if we are setting them on private widgets.

	* gtk/gtktreeview.c (gtk_tree_view_real_start_interactive_search):
	Duplicate entry->text before setting it as object data.
2001-10-23 16:02:23 +00:00
Havoc Pennington
0d5635b366 don't back up a char from the end iterator, fixes #61859 ("can't put
2001-10-22  Havoc Pennington  <hp@redhat.com>

	* gtk/gtktextbuffer.c (gtk_text_buffer_place_cursor): don't back
	up a char from the end iterator, fixes #61859 ("can't put cursor
	at the end of the buffer")

	* gtk/gtktextiter.c (gtk_text_iter_forward_to_line_end): fix this
	to work with delimiters other than newline.

	* tests/testtextbuffer.c: add some tests for get_chars_in_line,
	get_bytes_in_line

	* gtk/gtktextiter.c (gtk_text_iter_get_chars_in_line): fix for the
	last line, since the newline is no longer counted.
	(gtk_text_iter_get_bytes_in_line): ditto
2001-10-22 23:35:03 +00:00
Havoc Pennington
f2bf563dbd add assertion that #58290 would trigger if it reappeared, I think
2001-10-22  Havoc Pennington  <hp@redhat.com>

	* gtk/gtktextbtree.c (_gtk_text_btree_insert): add assertion that
	#58290 would trigger if it reappeared, I think
2001-10-22 22:28:27 +00:00
Havoc Pennington
0a522533b0 add temporary code to dump btree contents on assertion failure described
2001-10-22  Havoc Pennington  <hp@redhat.com>

	* gtk/gtktextiter.c (_gtk_text_iter_forward_indexable_segment):
	add temporary code to dump btree contents on assertion failure
	described in #62656

	* gtk/gtktextbtree.c (ensure_end_iter_segment): add some
	assertions that we're getting the right end iter segment

	* gtk/gtktextiter.c (_gtk_text_iter_forward_indexable_segment):
	verify that we aren't on the end iterator after moving
	forward one segment - fixes return value in an obscure case.
	Also, some trivial code cleanup/rearranging.
2001-10-22 22:17:21 +00:00
Havoc Pennington
6446484667 add a #error unless you define GTK_TEXT_USE_INTERNAL_UNSUPPORTED_API, so
2001-10-22  Havoc Pennington  <hp@redhat.com>

	* gtk/gtktextlayout.h: add a #error unless you define
	GTK_TEXT_USE_INTERNAL_UNSUPPORTED_API, so people don't use this accidentally

        * gtk/gtktext*.c: #define GTK_TEXT_USE_INTERNAL_UNSUPPORTED_API as appropriate.
2001-10-22 21:52:47 +00:00
Havoc Pennington
a959d3daf8 fix #62365
2001-10-22  Havoc Pennington  <hp@redhat.com>

	* gtk/gtktextview.c (gtk_text_view_get_border_window_size): fix
	#62365
2001-10-22 21:28:08 +00:00
Havoc Pennington
347da0ea5f fix #62436
2001-10-22  Havoc Pennington  <hp@redhat.com>

	* gtk/gtktextview.c (gtk_text_view_get_window_type): fix
	#62436
2001-10-22 21:06:55 +00:00
Havoc Pennington
c33d17189f Fix #62366
2001-10-22  Havoc Pennington  <hp@redhat.com>

	* gtk/gtktextview.c (gtk_text_view_set_border_window_size): Fix
	#62366
2001-10-22 21:05:28 +00:00
Owen Taylor
c8b58228d6 Add cursor-position, selection-bound properties. (#62148, reported by
Mon Oct 22 11:47:47 2001  Owen Taylor  <otaylor@redhat.com>

	* gtk/gtklabel.c: Add cursor-position, selection-bound
	properties. (#62148, reported by Padraig O'Briain)

	* gtk/gtkentry.c (gtk_entry_class_init): Rename text_position
	to cursor_position. (1.3.x addition, text_position is an awful
	name.) Make cursor_position read-only to avoid sticky questions
	of interaction with selection_bound. (#62636, reported by
	Padraig O'Briain)
2001-10-22 21:01:47 +00:00