Benjamin Otte
4322b69528
cssprovider: Return void, not TRUE
...
Parsing a css file always succeeds as CSS can recover from parsing
errors.
2016-10-17 17:41:03 +02:00
Benjamin Otte
dbeeaf7de6
cssprovider: Remove GError out argument from load functions
...
People should use the GtkCssProvider::parsing-error signal instead.
2016-10-17 16:52:05 +02:00
Ben Iofel
55e599c561
textbufferserialize: declare set_error as G_GNUC_PRINTF
...
And fix a missing format argument
2016-10-17 10:36:26 -04:00
Ben Iofel
84739239ce
colorscale: modify loop variables in loop body
2016-10-17 15:17:28 +01:00
Emmanuele Bassi
7b73bc3572
build: Use correct compiler flag
...
The name is -Wformat-nonliteral.
2016-10-17 15:13:09 +01:00
Garrett Regier
7173df1dd1
gtk+: Fix GI warnings about missing parameters
...
These were removed for GTK+ 4.
2016-10-17 07:07:20 -07:00
Emmanuele Bassi
a0aa1d963a
broadway: Remove redundant declaration
2016-10-17 14:56:38 +01:00
Emmanuele Bassi
2332ac444c
gtk/utils: Include stdio.h
...
We need it because of the declaration using FILE*.
2016-10-17 14:51:16 +01:00
Ignacio Casal Quinteiro
a12b691b76
gtkicontheme: check if the context quark string is not null
...
On windows you might not have a theme installed by default which
means that when trying to create the context quark it will fail.
If then we try to replace a NULL key in the hash table it will crash.
https://bugzilla.gnome.org/show_bug.cgi?id=769859
2016-10-17 13:04:31 +02:00
Emmanuele Bassi
857d241e22
Remove redundant variable declaration
...
The inner `var` declaration is shadowing the outer one.
2016-10-17 11:52:00 +01:00
Emmanuele Bassi
20b2e479f8
build: Add various compiler warnings and errors
...
Just like GLib, GTK+ would benefit from getting warnings and errors from
the compilers.
We check various, common warnings, especially for a future use of C99;
additionally, we promote some warnings to errors, in order to ensure
that simple mistakes are caught during the development phase, before
they are submitted to the code repository.
2016-10-17 11:44:11 +01:00
Emmanuele Bassi
6a9be60a16
notebook: Remove redundant variable declarations
...
We're already declaring notebook and priv at the top of the function,
and assigning them to the same values.
2016-10-17 11:44:11 +01:00
Emmanuele Bassi
39e848c0eb
icontheme: Drop unnecessary allocation
...
Use a static array for the known icon sizes, now that we don't allow
registering custom icon sizes any more. This allows us to cut a one-off
allocation that makes Valgrind sad.
2016-10-17 11:44:11 +01:00
Emmanuele Bassi
5563ba96bc
Avoid variable shadowing in GtkShortcutsSection
2016-10-17 11:44:11 +01:00
Emmanuele Bassi
fc9826fb41
Remove declarations for getresuid()/getresgid()
...
Back in 2001, their prototypes were missing from system headers, but
since glibc 2.3.2 they are defined in unistd.h if _GNU_SOURCE is
defined.
2016-10-17 11:44:11 +01:00
Emmanuele Bassi
db6f9a8e45
gtk: Add missing function declarations
2016-10-17 11:44:11 +01:00
Emmanuele Bassi
b3adbbe5e7
text: Constify field of GtkTextLineSegmentClass
...
We only use it internally for statically allocated structures, with
static strings, so there's no reason for it to be a `char*`.
2016-10-17 11:44:11 +01:00
Emmanuele Bassi
1f132607f7
gtk: Use appropriate constness for variables
2016-10-17 11:44:11 +01:00
Emmanuele Bassi
590e7e68d8
filechooserwidget: Rename error variable
...
Avoid shadowing an existing error.
2016-10-17 11:44:10 +01:00
Emmanuele Bassi
e75bbafeac
filechooserbutton: Remove unnecessary declaration
2016-10-17 11:44:10 +01:00
Emmanuele Bassi
9557364216
gtk: Mark internal functions as static
...
These functions are only used within their compilation unit.
2016-10-17 11:44:10 +01:00
Emmanuele Bassi
fbf6aa1776
colorscale: Rename variables
...
Avoid shadowing existing variables.
2016-10-17 11:44:10 +01:00
Emmanuele Bassi
4ba169b82e
cellview: Constify argument
2016-10-17 11:44:10 +01:00
Emmanuele Bassi
5880d1b990
gtk: Cast static strings assigned to non-const variables
...
GtkTargetEntry.target is particularly egregious, and it should really be
constified.
2016-10-17 11:44:10 +01:00
Emmanuele Bassi
9bb816f8ee
gtk: Include the appropriate headers
2016-10-17 11:10:14 +01:00
Emmanuele Bassi
3fdbe2ea13
widget: Make gtk_widget_get_parent_muxer() as static
...
It's a private function, used only inside gtkwidget.c and not declared
in any private header.
2016-10-17 11:10:14 +01:00
Emmanuele Bassi
24d59f6c34
inspector: Mark internal function as static
2016-10-17 11:10:14 +01:00
Emmanuele Bassi
44885bcfed
Remove redundant declarations
2016-10-17 11:10:14 +01:00
Emmanuele Bassi
923b868400
gdk/x11: Constify argument
2016-10-17 11:10:14 +01:00
Emmanuele Bassi
175800f345
Add private header for GtkTextView
...
This allows us to declare the symbols that are currently used inside
gtktextdisplay.c without incurring in the wrath of the compiler.
2016-10-17 11:10:14 +01:00
Emmanuele Bassi
8b9153d109
Remove redundant declarations
2016-10-17 11:10:14 +01:00
Emmanuele Bassi
5e388fc3e4
Fix _gtk_get_slowdown()
...
We need to pass void as the argument type.
2016-10-17 11:10:14 +01:00
Emmanuele Bassi
1db5d7fd8d
Remove redundant declarations
2016-10-17 11:10:14 +01:00
Emmanuele Bassi
81e5996c91
Include the appropriate headers
...
The GtkStackAccessible implementation should include the private header,
and the private header should include the public one.
2016-10-17 11:10:14 +01:00
Emmanuele Bassi
d8892c0fdb
Remove redundant declarations
2016-10-17 11:10:14 +01:00
Emmanuele Bassi
137e1aa988
Use appropriate const declaration for static strings
2016-10-17 11:10:14 +01:00
Emmanuele Bassi
68cab95c5d
Remove re-declarations of public functions
2016-10-17 11:10:14 +01:00
Emmanuele Bassi
d64ca9560c
Remove redundant declaration
2016-10-17 11:10:13 +01:00
Emmanuele Bassi
a87bdc47c7
stylecontext: Remove gtk_gradient_resolve_for_context()
...
Just like we remove gtk_gradient_resolve().
2016-10-17 11:10:13 +01:00
Emmanuele Bassi
dae97c3027
textview: Remove commented block
...
It's referencing gdk_cairo_create(), which does not exist any more.
2016-10-17 10:44:27 +01:00
Emmanuele Bassi
cf9b9a034b
gdk: Comment out gdk_cairo_create()
2016-10-17 10:44:27 +01:00
Emmanuele Bassi
07cd87eb9c
gdk: Remove mentions of gdk_cairo_create()
...
This function does not exist any more.
2016-10-17 10:44:27 +01:00
Matthias Clasen
95b9981a87
Fix the doc build
...
Remove no-longer-existing types.
2016-10-16 14:10:52 -04:00
Piotr Drąg
12dad0c234
Update POTFILES.in
2016-10-16 19:49:54 +02:00
Benjamin Otte
a65a4de38d
gdk: Remove old code to create drawing context
...
You now have to use a GdkDrawingContext
2016-10-16 18:18:58 +02:00
Benjamin Otte
17895e746c
tests: Remove custom preview from print-editor
...
It's using gdk_cairo_create() to do the drawing, which is unsupported.
2016-10-16 18:18:58 +02:00
Benjamin Otte
b4a7fc7d75
tests: Remove code from testinput that does nothing
2016-10-16 18:18:58 +02:00
Benjamin Otte
e76ba9a3c3
gdk: Remove gdk_window_set_debug_updates()
...
The update tracking code was ugly and using deprecated drawing APIs. It
was also in the wrong place.
So instead of trying to keep it working, I'll remove it. We need to find
a better way to put it and make it work there.
2016-10-16 18:18:58 +02:00
Benjamin Otte
4a95f8802c
widget: Remove gtk_widget_set_double_buffered()
...
Everything is always double-buffered.
2016-10-16 18:18:58 +02:00
Benjamin Otte
36b7ad0cd2
shortcutswindow: Modernize some code
...
No functional changes, just don't call valist functions anymore.
2016-10-16 18:18:58 +02:00