Matthias Clasen
58fd969b2d
printeroptionwidget: Avoid a critical
...
The new_location can be NULL, as we clearly
knew earlier in the function. We've forgotten
about that by the time we unref it :(
2020-05-11 14:26:31 -04:00
Matthias Clasen
495b9caf63
headerbar: Don't clean up other widget children
...
The parent of the title_widget is the center box,
it needs to call gtk_widget_unparent on it.
2020-05-11 14:25:57 -04:00
Matthias Clasen
ea53b445a8
filechooserdialog: Be more careful with widgets
...
We were stepping on our own toes, by first setting
up a save entry and telling the filechooserwidget
about it, and then nuking it by setting a title
on the headerbar. The filechooserwidget wasn't
ready for the entry to die without anybody telling
it.
This fixes a crash when using the filechooser for
print-to-file in the print dialog.
2020-05-11 14:23:58 -04:00
Matthias Clasen
c8a96d08a0
print-editor: Bring back the menubar
...
This was the one place where we relied on
the menubar fallback in GtkApplicationWindow.
So turn it on explicitly.
2020-05-11 12:55:15 -04:00
Matthias Clasen
9ce7b16dd8
Merge branch 'wip/exalm/test' into 'master'
...
Fix (most of the) tests
See merge request GNOME/gtk!1873
2020-05-11 15:52:24 +00:00
Matthias Clasen
597665517c
Merge branch 'teardown-cleanup-2' into 'master'
...
Treeview teardown cleanup
See merge request GNOME/gtk!1872
2020-05-11 15:23:40 +00:00
Alexander Mikhaylenko
228b3fc622
tests: Stop explicitly showing widgets
2020-05-11 20:15:57 +05:00
Alexander Mikhaylenko
ea9cea9be7
tests: Remove redundant image from testdialog
2020-05-11 20:04:23 +05:00
Alexander Mikhaylenko
56f56e6352
tests: Connect signal properly for testvolumebutton
2020-05-11 19:54:32 +05:00
Alexander Mikhaylenko
2323e8d77d
tests: Remove orientation from testvolumebutton
...
GtkVolumeButton isn't orientable anymore.
2020-05-11 19:53:31 +05:00
Alexander Mikhaylenko
531468cab6
test: Stop using stock-size for teestverticalcells
2020-05-11 19:51:18 +05:00
Alexander Mikhaylenko
58fcd09cff
tests: Fix testtreeelistmodel
...
Stop using GtkContainer API for GtkListBoxRow and GtkToggleButton.
2020-05-11 19:47:58 +05:00
Alexander Mikhaylenko
2940b17a8e
tests: Fix teststackedheader
...
Connect to signals programmatically.
2020-05-11 19:33:05 +05:00
Matthias Clasen
b8c5bf8af8
testsuite: Enable the remaining template tests
...
These are no longer failing.
2020-05-11 10:30:03 -04:00
Matthias Clasen
d061bcad52
treeview: Break reference cycles on unroot
...
It is a bad idea to have such cycles in the first place,
and there is no need to let them linger past unroot.
This stop the treeview depending on run_dispose to get
freed, a simple unparent will work now.
2020-05-11 10:30:03 -04:00
Alexander Mikhaylenko
1d2af907fc
tests: Fix teststack "add icon" button
2020-05-11 19:27:41 +05:00
Matthias Clasen
329994291a
Merge branch 'wip/baedert/for-master' into 'master'
...
Wip/baedert/for master
See merge request GNOME/gtk!1867
2020-05-11 14:24:45 +00:00
Alexander Mikhaylenko
b2da99fd4e
tests: Fix testselectionmode
...
Stop using <packing/> and GtkContainer API for random widgets.
2020-05-11 19:21:03 +05:00
Yuri Chornoivan
2d97357136
Update Ukrainian translation
2020-05-11 14:20:13 +00:00
Alexander Mikhaylenko
4361a884bf
tests: Fix testoverlay
...
Stop using child properties and margin property.
2020-05-11 19:13:04 +05:00
Alexander Mikhaylenko
14dc92c747
tests: Simplify testorientable
...
Since GtkButtonBox is gone, remove the separator and change grid to box.
2020-05-11 19:08:56 +05:00
Alexander Mikhaylenko
c9760ed456
tests: Remove testmodelbutton
...
GtkModelButton is private now, so it can't work anymore.
2020-05-11 19:03:53 +05:00
Alexander Mikhaylenko
7c148bebef
tests: Remove use-popover from testmenubutton
...
The corresponding property doesn't exist anymore.
2020-05-11 18:55:15 +05:00
Alexander Mikhaylenko
7aeb504652
tests: Fix testlogout
...
Stop using GtkApplication::quit signal.
2020-05-11 18:54:53 +05:00
Alexander Mikhaylenko
e0d36d1f2d
tests: Fix testiconview
...
Stop using GtkContainer API for GtkPopover.
2020-05-11 18:54:23 +05:00
Alexander Mikhaylenko
68fb643a7e
tests: Fix testheightforwidth layout
...
Stop using child properties and setting visible=true everywhere.
2020-05-11 18:39:32 +05:00
Alexander Mikhaylenko
fb0dcaf066
tests: Expand content for testheaderbar
2020-05-11 18:31:59 +05:00
Alexander Mikhaylenko
4277eeee1b
tests: Fix testgtk
...
An assorted collection of fixes.
2020-05-11 18:12:18 +05:00
Matthias Clasen
9f3fb69dce
Merge branch 'matthiasc/for-master' into 'master'
...
Matthiasc/for master
Closes #2729 and #2730
See merge request GNOME/gtk!1870
2020-05-11 12:51:08 +00:00
Matthias Clasen
0e18e52f00
menubutton: Cosmetics
...
Fix a few typos in the docs.
2020-05-11 08:15:56 -04:00
Matthias Clasen
d2430c70bd
Refresh the tutorial examples
...
Redo this series of examples from 2013, and adapt it to modern
way of doing things. The biggest differences are that we use
a headerbar right from the start, and don't mention the app
menu.
Fixes : #2730
2020-05-11 08:15:56 -04:00
Matthias Clasen
4de4957aa3
applicationswindow: Make show-menubar FALSE by default
...
The fallback to the menubar is not a good sight,
we should not do that by default.
2020-05-11 08:15:56 -04:00
Matthias Clasen
0fc1a290e2
docs: Cosmetic updates to the tutorial
...
Since the meson conversion, we are no longer expanding
gtk-doc references in this file, so take them out. And
touch up the wording in various places.
2020-05-11 08:15:55 -04:00
Matthias Clasen
1b8a025a5f
Clean up a leak in a test
...
One of the treeview tests was calling gtk_widget_destroy
on a child instead of the toplevel, which leaks the toplevel
unnecessarily. Plus, we're moving towards allowing destroy
only on toplevels.
2020-05-11 08:15:55 -04:00
Matthias Clasen
d798527290
treeviewcolumn: Another case of box <> frame confusion
...
Don't call your boxes frames, folks!
2020-05-11 08:15:55 -04:00
Matthias Clasen
6140dafecf
builderscope: Fix finalize <> dispose confusion
...
Don't chain up to dispose if you implement finalize.
This fix s courtesy of GOBJECT_DEBUG=objects.
2020-05-11 08:15:55 -04:00
Matthias Clasen
3a5cf61a4d
print dialog: Fix frame <> box confusion
...
It is a bad idea to have a GtkBox called frame, event
if it started out its existence as a GtkFrame.
2020-05-11 08:15:55 -04:00
Matthias Clasen
a11119d317
treeview: Ensure search popover is properly inserted
...
The css tree and the widget tree are not in sync, so we need
to explicitly set the parent of the css node before inserting
the widget, or else we end up with critical warnings and a
non-working popover.
This can be seen in the print dialog, when moving the focus
to the printer list.
2020-05-11 08:15:55 -04:00
Matthias Clasen
756720fde4
print-editor: Cosmetics
...
Make the about dialog a bit less barren.
2020-05-11 08:15:55 -04:00
Matthias Clasen
2b920b22c1
print-editor: Fix a critical
...
GtkWindow is no longer a container, so don't call
gtk_container_add on it.
2020-05-11 08:15:55 -04:00
Matthias Clasen
bb8fa045c2
Merge branch 'focusable-property' into 'master'
...
Focusable property
See merge request GNOME/gtk!1834
2020-05-11 11:23:15 +00:00
Emmanuele Bassi
4cc21f1fa1
Merge branch 'aperezdc/vk-result-range-size' into 'master'
...
Fix build issue due to missing VK_RESULT_RANGE_SIZE
See merge request GNOME/gtk!1871
2020-05-11 10:02:53 +00:00
Adrian Perez de Castro
5c4ca1424d
Fix build issue due to missing VK_RESULT_RANGE_SIZE
...
Conditionally check whether the Vulkan headers version defines
VK_RESULT_RANGE_SIZE, and avoid using it for version >=140. The
following comming in Vulkan-Headers has removed the enum value:
0c5351f5e9 (diff-4febd94c0666d59030d8b1dd20c72403)
2020-05-11 10:07:41 +03:00
Matthias Clasen
6372a33838
Clarify docs around focus.
2020-05-11 00:29:41 -04:00
Matthias Clasen
b93631164f
Remove lots of focus vfuncs
...
In many cases, the default widget vfuncs work just fine,
combined with setting focusable.
2020-05-11 00:11:37 -04:00
Matthias Clasen
46bad5d513
widget: Fix gtk_widget_focus_all for !focusable
...
This was a case that wasn't handle properly when
the focus is entering from the outside, in forward
direction.
2020-05-11 00:11:04 -04:00
Matthias Clasen
edc31a264c
widget: Add a :focusable property
...
Add back a property that determines whether an individual
widget will accept focus or not. :can-focus prevents the
focus from ever entering the entire widget hierarchy
below a widget, and :focusable just determines if grabbing
the focus to the widget itself will succeed.
See #2686
2020-05-10 23:24:48 -04:00
Alexander Mikhaylenko
99704248b7
tests: Fix testgmenu
...
GtkMenuButton isn't a GtkButton anymore.
2020-05-11 04:58:36 +05:00
Alexander Mikhaylenko
7a09143519
tests: Add missing margin for testglarea
2020-05-11 04:57:01 +05:00
Alexander Mikhaylenko
25295d1e17
tests: Fix testgiconpixbuf test
...
Don't use GtkContainer API on GtkWindow.
2020-05-11 04:55:22 +05:00