AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity
52,997 Commits 969 Branches 749 Tags 504 MiB
6ab72b2653
Commit Graph

947 Commits

Author SHA1 Message Date
Timm Bäder
348871d9fc Fix a few testsuite failures 
Adjust default property values, skip GtkRange:adjustment.
 2017-07-19 21:27:16 -04:00
Timm Bäder
36ab70ddf5 widget: Add baseline and out_clip parameters to size-allocate 
Since setting a clip is mandatory for almost all widgets, we can as well
change the size-allocate signature to include a out_clip parameter, just
like GtkCssGadget did. And since we now always propagate baselines, we
might as well pass that one on to size-allocate.

This way we can also make sure to transform the clip returned from
size-allocate to parent-coordinates, i.e. the same coordinate space
priv->allocation is in.
 2017-07-19 21:27:16 -04:00
Timm Bäder
55389cd97c entry: Fix baseline alignment 
Since we only look at priv->text_baseline later on, it would be useful
to actually set it to a useful value.
 2017-07-19 21:27:15 -04:00
Timm Bäder
2c2867d45d entry: Fix undershoot position 2017-07-19 21:27:15 -04:00
Timm Bäder
84c00d18bb entry: Simplify progress size allocation 2017-07-19 21:27:15 -04:00
Timm Bäder
3fc49ce8a1 entry: Fix text position 
We need to adjust the layout coordinates depending on priv->text_x,
sinec that one accounts for the width of the left icon.
 2017-07-19 21:27:15 -04:00
Timm Bäder
fb1d2719d9 entry: Fix node ordering 
Fix the icon order
 2017-07-19 21:27:14 -04:00
Timm Bäder
c2abb698be Replace a few get_content_allocation calls with get_content_size 
The position of the content allocation is almost never relevant since
it's 0/0 for measure, size_allocate and snapshot.
 2017-07-19 21:27:14 -04:00
Timm Bäder
078e599ac5 entry: Replace progress gadget with a progressbar 2017-07-19 21:27:14 -04:00
Timm Bäder
4d74129c61 entry: Use images for icons 2017-07-19 21:27:14 -04:00
Timm Bäder
3f429eb197 entry: get_layout_location coords are already content relative 2017-07-19 21:27:14 -04:00
Timm Bäder
2687a9d132 entry: Fix text position 2017-07-19 21:27:13 -04:00
Timm Bäder
37d6fd1ffa Entry: Remove gadget 2017-07-19 21:27:11 -04:00
Timm Bäder
3a2ca91eae spinbutton: Remove call to GtkSpinButton API 
The condition will never be true since spinbuttons aren't entries
anymore.
 2017-07-19 21:27:11 -04:00
Timm Bäder
3c2d2545b2 spinbutton: Inherit from GtkWidget 
Use a box, an entry and the current 2 buttons.
Remaining problems: Entry sizing and activation.
 2017-07-19 21:27:11 -04:00
Carlos Garnacho
a72404dd5a gtk: Mass delete all GtkWidget event mask API 
We now rely on toplevels receiving and forwarding all the events
the windowing should be able to handle. Event masks are no longer a
way to determine whether an event is deliverable ot a widget.

Events will always be delivered in the three captured/target/bubbled
phases, widgets can now just attach GtkEventControllers and let those
handle the events.
 2017-05-25 16:25:58 +02:00
Carlos Garnacho
322ee63e0c gtkentry: Remove text_area window 
And refurbish cursor management to be set on the GtkWidget. The
input window is not needed anymore to receive events either.

This is no longer set through the GdkWindow, so use the private
GtkWidget API.
 2017-05-25 16:25:58 +02:00
Carlos Garnacho
d39afa6011 imcontext: Remove API dependency on GdkWindow 
There is now a set_client_widget() to hint the IM about positioning
and whatnot.
 2017-05-25 16:25:58 +02:00
Timm Bäder
9047a5dc52 entry: make sure priv->current_pos is valid 
We can e.g. get the entry dispose()d and a focus_out event after that
(because the toplevel unsets the focus which previously was the entry).
We then later use priv->current_pos in a call to pango API which makes
sure the given index is valid for the given layout. Since we lazily
create a GtkEntryBuffer in get_buffer() and a PangoLayout lazily in
gtk_entry_create_layout, these 2 are always valid but don't match
priv->current_pos in this situation.

Fix this by resetting priv->current-pos in dispose().
 2017-03-13 12:08:58 +01:00
Timm Bäder
fca6bef697 entry: Remove cursor type parameter from get_cursor_locations 
We are only ever passing CURSOR_STANDARD anyway.
 2017-03-13 12:08:58 +01:00
Daniel Boles
c4fbce52ce Entry: Add newlines to ease reading huge switches 
These are monstrosities!
 2017-02-19 12:39:05 +00:00
Daniel Boles
4bea7b0ae8 Entry—Fix inverted movements by arrow keys in RTL 
Using Ctrl + left/right to skip between words, or left/right to cancel a
selection, were causing movement on the screen in the opposite direction
of the glyph on the key. This was surprising and awful UX for RTL users.

This is based on a patch covering the former case by:
Author:    Ori Avtalion <ori@avtalion.name>
Date:      Tue Apr 20 08:06:23 2010 +0000

https://bugzilla.gnome.org/show_bug.cgi?id=136059
 2017-02-19 12:39:05 +00:00
Timm Bäder
f4afa000a1 entry: Remove unused struct member 2017-01-16 17:22:29 +01:00
Benjamin Otte
6055028c96 snapshot: Rename append APIs 
Instead of having gtk_snapshot_append_foo_node(), just have
gtk_snapshot_append_foo(). Nobody needs to know that this internally
uses nodes.
 2017-01-13 04:46:09 +01:00
Sébastien Wilmet
88699f588d docs: improve the documentation of GtkEntry:attributes 
See the implementation of gtk_entry_create_layout():
pango_attr_list_splice() is used to add the PangoAttrList of the preedit
string. And that is done *after* applying the PangoAttrList of the
"attributes" property.

https://bugzilla.gnome.org/show_bug.cgi?id=776868
 2017-01-04 19:56:30 +01:00
Benjamin Otte
0dbdf0c428 gadget: Remove gtk_css_gadget_draw() 
And with it, remove the draw func from custom gadgets, that has been
NULL everywhere.

All gadgets are snapshot now.
 2016-12-20 18:01:12 +01:00
Piotr Drąg
a2da4ddceb Use Unicode in translatable strings 
See https://developer.gnome.org/hig/stable/typography.html

https://bugzilla.gnome.org/show_bug.cgi?id=772371
 2016-12-19 15:08:10 -05:00
Timm Bäder
3dac21f20b entry: Refactor get_icon_pixbuf 
This way it will only return a pixbuf if the icon helper has a pixbuf.
 2016-12-03 13:19:26 +01:00
Sébastien Wilmet
82b2bf2184 docs: fix a parameter name of GtkEntry::populate-popup 
Trivial commit.

The documentation block refers to @widget, not @popup. @widget is a
better name since the type is GtkWidget.
 2016-11-26 12:31:34 +01:00
Sébastien Wilmet
e2881d1e4f docs: fix docs of functions to convert layout_index <-> text_index 
Trivial commit.

The documentation was swapped. The documentation for the parameters and
the return values is good.
 2016-11-26 12:31:34 +01:00
Emmanuele Bassi
4cbe079767 Use Graphene init macros for compound literals 
The Graphene init macros can now be used for compound literals, which
means we need to update our mixed uses.
 2016-11-21 16:21:38 +00:00
Matthias Clasen
0cec768b54 entry: Fix input window position for icons 
This makes the icon in the placesview address entry and
in widget-factory's progress entry work again.
 2016-11-17 12:04:35 -05:00
Benjamin Otte
64e802c441 snapshot: Convert entry and spinbutton 2016-11-15 17:48:45 +01:00
Benjamin Otte
da207c9fdd snapshot: Add a snapshot function to GtkCssCustomGadget 2016-11-15 17:48:45 +01:00
Matthias Clasen
d462c31233 entry: Avoid recursion in gtk_entry_ensure_layout 
This was unintentional, and lead to a memory leak.
 2016-11-14 15:17:41 -05:00
Timm Bäder
fdc24c7505 entry: Fix coordinates after rendernode conversion 
Ease the transition by removing the text_area and frame vfuncs which are
unused inside GTK+.
 2016-11-05 11:56:37 +01:00
Timm Bäder
932b9acb39 Revert "Revert "Convert GtkEntry to indirect rendering"" 
This reverts commit f4fa111e32.
 2016-11-05 11:56:36 +01:00
Matthias Clasen
f4fa111e32 Revert "Convert GtkEntry to indirect rendering" 
This reverts commit 3656c9f94c.

Still causes to many unresolved drawing issues.
 2016-11-04 13:22:48 -04:00
Matthias Clasen
3656c9f94c Convert GtkEntry to indirect rendering 
Warning! This unveils some positioning issue with the secondary icon.
 2016-11-01 14:29:25 -04:00
Matthias Clasen
775b42ef92 Revert "Convert GtkEntry to indirect rendering" 
This reverts commit 8e29222d95.

This needs more work - spin buttons need to be converted at
the same time, and we should make sure that text still appears.
 2016-10-28 06:47:26 -04:00
Matthias Clasen
8e29222d95 Convert GtkEntry to indirect rendering 
Warning! This unveils some positioning issue with the secondary icon.
 2016-10-27 20:46:08 -04:00
Timm Bäder
9992a616ef widget: Use ::measure vfunc to measure size 
Add a new ::measure vfunc similar to GtkCssGadget's that widget
implementations have to override instead of the old get_preferred_width,
get_preferred_height, get_preferred_width_for_height,
get_preferred_height_for_width and
get_preferred_height_and_baseline_for_width.
 2016-10-22 19:05:47 +02:00
Benjamin Otte
c61e669e56 entry: Use gdk_window_new_input() 2016-10-18 00:22:35 +02:00
Benjamin Otte
4df6ddad54 API: container: Remove gtk_container_set_border_width() 2016-10-16 18:18:58 +02:00
Benjamin Otte
1518fe0a8f API: stylecontext: Remove state argument from getters 
The argument must always be the current state.
 2016-10-16 18:18:58 +02:00
Timm Bäder
f360a69f4c entry: Remove invisible-char style property 2016-10-16 18:17:21 +02:00
Timm Bäder
86dbe591d2 entry: Remove deprecated style properties 2016-10-16 18:17:21 +02:00
Timm Bäder
1add02879e entry: Remove inner-border (style) property 2016-10-16 18:17:21 +02:00
Timm Bäder
ad155fb26c Remove GtkStock API from GtkImage 2016-10-16 18:17:21 +02:00
Benjamin Otte
fcbd480c76 API: Remove GDK_WA_CURSOR 
The cursor was set using gdk_window_set_cursor() even in
gdk_window_new().

So instead of having yet another flag, just make the users of that flag
call gdk_window_set_cursor() directly after the window was created.
 2016-10-16 18:17:21 +02:00
Matthias Clasen
ddd1ac0934 entry: Fix a corner case of overwrite mode 
We currently beep when a character is appended at the end in
overwrite mode. That is obviously not right. Patch based on
a patch by Ian MacDonald.

https://bugzilla.gnome.org/show_bug.cgi?id=772389
 2016-10-05 12:22:21 -04:00
Christian Hergert
b684b23c74 entry: handle NULL cursor when updating cursors 
If we got a NULL cursor from gdk_cursor_new_from_name(), we need
to handle that when unreffing.
 2016-09-27 14:12:43 -07:00
Christian Hergert
7ecd337877 entry: handle NULL cursor when releasing reference 
If we happen to have gotten NULL back for a cursor, then we
need to check before unreffing it.
 2016-09-27 14:09:02 -07:00
Benjamin Otte
e1a03ead7a Use NULL for generic marshallers in g_signal_new() 
glib will use the correct marshaller automatically. And as a side
effect, we also get all glib optimizations, like a va marshaller.
 2016-08-29 16:20:54 +02:00
Timm Bäder
a985e62b25 Use gtk_popover_popdown/popup where appropriate 
https://bugzilla.gnome.org/show_bug.cgi?id=769706
 2016-08-16 11:49:26 -04:00
William Hua
8701e34f74 port to new gtk_menu_popup_at_* () functions 
https://bugzilla.gnome.org/show_bug.cgi?id=756579
 2016-07-19 09:38:54 -04:00
Timm Bäder
4dbe7c99c2 entry: Fix undershoot position wrt entry icons 
Draw them inside of the icons, which is where the text scrolls.
 2016-05-31 09:41:08 +02:00
Timm Bäder
301652de1f Remove useless casts from gdk_event_triggers_context_menu calls 2016-05-12 20:39:51 +02:00
Matthias Clasen
b5fb9ae3b7 gtk: Port to new monitor api 
Use the GdkDisplay monitor api instead of the GdkScreen one.
 2016-04-27 23:18:16 -04:00
Matt Watson
511f138328 entry: port to progress tracker 2016-04-08 16:09:30 -07:00
Matthias Clasen
2fee5fbda7 entry: Fix drag highlight problems 
We don't want drag highlights around icons or progress, so don't
propagate the :drop(active) state to them.
 2016-03-11 08:02:10 -05:00
Matthias Clasen
6b2cde94b4 entry: Make progress node invisible when appropriate 
We were failing to do that, leading to progress not disappearing
anymore after it was initially shown, in the gtk3-widget-factory
entry progress example.
 2016-03-04 08:04:45 -05:00
Benjamin Otte
cf71d98b05 entry: Make the get_text_area() vfunc relative to top left of entry 
This fixes GdTaggedEntry. I hope.
 2016-02-23 04:22:19 +01:00
Matthias Clasen
966dd56e45 entry: Fix baseline allocation 
Position the text on the baseline again.
 2016-02-20 18:55:17 -05:00
Benjamin Otte
d2fb069426 entry: Make get_text_area_size() vfunc work again 
GdTaggedEntry needs that. Though there's probably a bunch of work left
inside GdTaggedEntry to make it look cute again (like storing the area
it reserves for itself to allocate tags in).
 2016-02-20 03:25:39 +01:00
Chun-wei Fan
0e9f24b5a4 gtk/gtkentry.c: Fix build on pre-C99 
This file now uses nearbyint(), so include fallback-c89.c so that
compilers that don't provide the function will not get upset.
 2016-02-15 17:22:00 +08:00
Benjamin Otte
c95087c70a entry: queue an allocate when pulsing 
We need to reposition the progress gadget and that's done during
allocation.
 2016-02-04 12:25:13 +01:00
Benjamin Otte
429bec54e5 entry: Turn progress node into a gadget 2016-02-03 22:53:22 +01:00
Benjamin Otte
3316d69abb entry: Simplify drawing code 2016-02-03 22:53:22 +01:00
Benjamin Otte
bfb727d37e entry: Draw progress in the right place 2016-02-02 15:26:01 +01:00
Timm Bäder
6e2c551896 entry: Fix icon areas 
Do the same thing we already do in gtk_entry_get_text_area.
 2016-01-31 20:05:52 +01:00
Krzesimir Nowak
09677f7331 entry: Fix a typo 2016-01-27 14:29:40 +01:00
Benjamin Otte
c4f7fbecfa entry: Fix a case of disagreeing coordinate systems 
gesture_get_current_point() returned x/y in layout coordiantes, but
callers assumed it in textarea coordinates.
 2016-01-27 14:04:21 +01:00
Matthias Clasen
a9222146d3 entry: give a visual clue that content is scrolled 
This has been requested long ago, and we now have the
machinery to implement it easily.
 2016-01-26 23:36:18 -05:00
Benjamin Otte
a222aa66d5 entry: Compute selection range correctly 
gtk_editable_get_selection_bounds() returns UTF-8 character offsets,
but gdk_pango_layout_get_clip_region() wants byte ranges, so convert
from one to the other.
With English, this is especially visible for passwords, which use ●
as the invisible character.

https://bugzilla.gnome.org/show_bug.cgi?id=761128
 2016-01-27 02:11:06 +01:00
Benjamin Otte
fefc370f6c entry: Chain up in realize() 
... instead of copy/pasting what gtk_widget_real_realize() does.
 2016-01-26 15:53:56 +01:00
Benjamin Otte
ad7bbbf9d8 entry: Use cleverer method to get the entry node 2016-01-25 15:49:17 +01:00
Benjamin Otte
3982f05be4 entry: Move spinbutton size hack 
If we want to do special sizing for the text, we need to do it for the
text. Otherwise paddings, borders and entyr icons will screw up
everything.
 2016-01-25 15:49:17 +01:00
Benjamin Otte
02fab14b3b entry: Move code 
This movement is necessary for future gadgetization of GtkSpinButton.
 2016-01-25 15:49:17 +01:00
Benjamin Otte
b52b4068af entry: Redo textarea handling 
(1) Keep priv->text_allocation for the area used by the text
(2) Compute all text coordinates with the help of priv->text_allocation

As a side effect the get_text_area_size and get_frame_size vfuncs are
now unused. If we wanted them back, they should get a single use durig
size_allocate() and then their results should be stored for further
processing.
 2016-01-25 15:49:17 +01:00
Benjamin Otte
c709072567 entry: Use gtk_render_layout() 
It's funny that nobody has yet noticed that we don't draw the text using
the theme.

We had no text-shadow in entries!!!!!
 2016-01-25 15:49:17 +01:00
Benjamin Otte
a363fd5fd3 entry: Draw selection the same way as GtkLabel 2016-01-25 15:49:17 +01:00
Benjamin Otte
ca690162af entry: Fold function into only caller 2016-01-25 15:49:17 +01:00
Benjamin Otte
0ae8b30210 entry: Don't allow different text over progress 
This complicates refactorings, so remove that feature. It's not used
anywhere and doesn't play well with nodes the way it's implemented.
If we want it back, we can add it back later.
 2016-01-25 15:49:17 +01:00
Benjamin Otte
a6845091f9 spinbutton: Make the entry gadget be the entry's gadget 
This is a big and somewhat evil hack: We replace the entry's gadget's
node with the spinbutton's entry node.
 2016-01-22 13:46:01 +01:00
Matthias Clasen
b08fe985cc entry: Expand the css node docs 
Mention the context menu.
 2016-01-18 10:52:26 -05:00
Timm Bäder
d73f6b8c50 entry: Deprecate shadow-type 
Things like that should be handled using css. Also, the property value
is unused inside GtkEntry.
 2016-01-18 12:53:53 +01:00
Timm Bäder
a5fabee202 entry: Don't draw icons twice 2016-01-14 16:02:12 +01:00
Timm Bäder
49d251a330 entry: Remove unused code 2016-01-14 16:02:12 +01:00
Matthias Clasen
ea4cff1ea4 Use convenience API that was introduced recently 
Use gtk_css_gadget_set_state in all the places where we previously
were getting a node from a gadget, just to call gtk_css_node_set_state.
 2016-01-13 00:19:31 -05:00
Timm Bäder
19fa893067 entry: typo 2016-01-12 21:54:45 +01:00
Michael Catanzaro
c3d611fcf2 entry: Fix typo 2015-12-20 11:52:30 -06:00
Matthias Clasen
18e8842a7e entry: Don't clear when setting icons 
Clearing the icon doesn't appear to be necessary with
todays code, and it has the unfortunate side-effect of
temoorarily hiding the icon's window, which breaks grabs
and makes us miss the button release event when the icon
is changed from a button press handler.
 2015-12-18 19:38:07 -05:00
Matthias Clasen
51ba8421c3 entry: Remove some dead code 
These defines are no longer used.
 2015-12-18 10:55:26 -05:00
Matthias Clasen
2e25407638 Fix a problem with entry gadgets 
place_windows is accessing the gadgets allocation, so make sure
to allocate the gadget before calling it.
 2015-12-17 15:17:23 -05:00
Matthias Clasen
35c243b26f entry: use a gadget 
Use a gadget for the entry. Selection and progress still
just use a CSS node. Most things seem to work correctly
with non-zero margin or padding.
 2015-12-17 00:01:58 -05:00
Benjamin Otte
3a77da9df2 entry: Turn icons into gadgets 2015-12-15 08:41:16 -05:00
Benjamin Otte
b79a187d47 iconhelper: Handle invalidation 
When CSS, direction or scale factor change, handle the invalidation
inside the iconhelper.
This way the widgets using them don't have to.
 2015-12-15 08:41:16 -05:00
Benjamin Otte
ad22612ab2 iconhelper: Require passing a cssnode to the constructor 
Note that we don't use it yet.
 2015-12-15 08:41:16 -05:00
Benjamin Otte
ccfc4d3f12 iconhelper: Remove the context argument 
Instead, use the widget's context.
 2015-12-09 13:30:40 +01:00