Kristian Rietveld
449c4bc362
Unit test a corner case of gtk_tree_model_filter_rows_reordered()
2011-09-11 12:13:54 +02:00
Benjamin Otte
3d0a2d50f0
filechooser: Fix compile warning
2011-09-10 16:11:27 +02:00
Matthias Clasen
f9379adca2
GtkAppChooserButton: Add a way to include the default app
...
This is necessary to use an app chooser button for selecting
default apps in the control center. Also, beef up the docs
for this widget family.
https://bugzilla.gnome.org/show_bug.cgi?id=642706
2011-09-10 01:42:07 -04:00
Cosimo Cecchi
e97ed4374f
combobox: implement get_path_for_child() for GtkComboBox
...
This way we can adjust borders and rounded corners from the theme when
displaying the widget children flipped for RTL locales.
https://bugzilla.gnome.org/show_bug.cgi?id=658507
2011-09-09 11:46:00 -04:00
Dan Winship
e028a5c090
gtkcssprovider: fix a crash in gtk_css_provider_parsing_error
...
"info" was being declared in two different scopes, and the one that
was freed wasn't the one that was set.
2011-09-09 09:37:44 -04:00
Dan Winship
228f30e055
gtkmodules: don't append NULL to module list for blacklisted module
...
fixes a crash when removing "gail" from gtksettings-specified modules
2011-09-08 16:52:00 -04:00
Kristian Rietveld
b53a66b7e2
Add unit tests to check hierarchies of deleted nodes are unreffed properly
2011-09-07 22:25:29 +02:00
Kristian Rietveld
d116261e1f
Update filter model ref count tests to reflect changes in rules
2011-09-07 22:25:29 +02:00
Kristian Rietveld
022327c408
gtktreemodelfilter: child levels of the root level must remain cached
...
This is due to the special handling for filter functions that depend
on child level state. If the parent level of a level is the root level,
the level cannot be removed from the cache. Any change in this level
can cause its parent in the root level to become visible again.
2011-09-07 22:25:29 +02:00
Kristian Rietveld
ae2b2e7cfc
gtktreemodelfilter: rework gtk_tree_model_filter_remove_elt_from_level
...
The most important change is that the function now properly releases
any external ref count and propagates these changes to the child model.
If a node is removed due to a filtering action, we now properly release
all external reference counts for its hierarchy of child nodes.
Apart from that, the function has been restructured to remove code
duplication.
Finally, there is still some doubt whether there are more calls to
gtk_tree_model_filter_free_level() which need unref_external set to TRUE.
2011-09-07 22:25:29 +02:00
Kristian Rietveld
767b2e2604
gtktreemodelfilter: add a debug define and more assertions
...
Should be helpful when debugging this thing. Perhaps this needs to
be properly integrated in G_DEBUG/GTK_DEBUG, but currently I do not see
the need to.
2011-09-07 22:25:29 +02:00
Kristian Rietveld
f317dd3831
gtktreemodelfilter: make rule used for level caching consistent
...
There was still a discrepancy between the comments and the code about when
exactly a level was to be removed. The rule is now set on that for a level
to be removed its zero_ref_count as well as the zero_ref_count of its
parent has to be zero.
2011-09-07 22:25:29 +02:00
Kristian Rietveld
0bedb51b33
Add unit test for ref tranfer in rows-reordered with filtered rows
2011-09-07 22:25:29 +02:00
Behdad Esfahbod
057a50d58e
Bug 658398 - Use of uninitialized variable reported by Valgrind
...
Fix it.
2011-09-07 16:19:44 -04:00
Cosimo Cecchi
8b9f0402b0
iconview: fix a typo while removing the a11y adjustment weak ref
...
The code sets old_adj_ptr to the location containing the old weak ref,
but then wants to remove a weak ref from &view->old_hadj, causing warnings
when disposing the widget.
2011-09-06 19:09:19 -04:00
Cosimo Cecchi
39f0a60792
themingengine: remove unused variable
2011-09-06 15:01:09 -04:00
Federico Mena Quintero
c6aca6bb60
Merge branch 'bgo593793-filechooser-recent-folders-master'
2011-09-05 14:36:23 -05:00
Federico Mena Quintero
2476d35142
Menu item to visit the selected files in recent-files mode
...
This will take you to the file's folder and select the file in question.
The menu item is only available in Recently-used and Search modes, so that
you can go from files in them to the 'normal' browsing mode.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2011-09-05 13:31:57 -05:00
Federico Mena Quintero
668287b940
Factor out functions to create contextual menu items for the file list
...
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2011-09-05 13:22:01 -05:00
Benjamin Otte
d717a2dcfc
grid: Swap wrong spacing properties
...
row-spacing behaved like column-spacing should have and vice versa.
Also update tests that erroneously checked this behavior.
Thanks to Joanmarie Diggs for finding this.
2011-09-05 18:56:23 +02:00
Benjamin Otte
b314f03bf4
radiobutton: Remove redundant call
...
The call is done by GtkButton already, no need to override it.
2011-09-05 18:56:23 +02:00
Benjamin Otte
7edf79de26
checkbutton: Remove redundant call
...
The call is done by GtkButton already, no need to override it.
2011-09-05 18:56:23 +02:00
Cosimo Cecchi
4ea01b2cf3
GtkPathBar: Implement get_path_for_child
...
This will allow nice theming of the path bar.
https://bugzilla.gnome.org/show_bug.cgi?id=658077
2011-09-05 12:14:09 -04:00
Matthias Clasen
f1476f31fe
a11y: Fix up listener registration minimally
...
For god-knows-what reason, at-spi is trying various formats
of strings when registering listeners, triggering g_warnings()
from gailutil code. Stop doing that.
Also, don't leak temporary string arrays that are a side-effect
of passing parameters around as formatted strings.
https://bugzilla.gnome.org/show_bug.cgi?id=658168
2011-09-05 11:56:54 -04:00
Matthias Clasen
a51a31466d
Make the gail blacklisting more quiet
...
Don't mention blacklisted modules at all if they are not found.
2011-09-05 11:44:47 -04:00
Matthias Clasen
1bede5c3fb
GtkFontChooser: mark 'no matches' string for translation
2011-09-05 11:19:30 -04:00
Matthias Clasen
5445b3d7ec
GtkToolbar: Move child removal to dispose
...
Doing it in finalize is too late and can cause various problems
in ::parent-set signal handlers.
https://bugzilla.gnome.org/show_bug.cgi?id=658200
2011-09-05 11:09:16 -04:00
Matthias Clasen
6faba61db1
Some GtkAboutDialog doc additions
2011-09-05 00:00:24 -04:00
Matthias Clasen
3a1ce87c7e
Fix typos in gtk_tree_view_set_reorderable docs
...
As pointed out in bug 530253.
2011-09-04 23:52:36 -04:00
Matthias Clasen
2e39400e18
Clean up the docs of GTK_SELECTION_MULTIPLE
...
As requested in bug 566202.
2011-09-04 23:46:51 -04:00
Matthias Clasen
eaed6d1912
Improve gtk_tree_view_set_drag_dest_row docs
...
As requested in bug 581435.
2011-09-04 23:42:42 -04:00
Matthias Clasen
21275a1636
Correct the documentation of gtk_render_arrow() x,y arguments
...
As pointed out in bug 655631, these are the origin, not
the center of the area.
2011-09-04 23:09:57 -04:00
Matthias Clasen
f601994eff
GtkFontChooser: escape markup where required
...
Since we use markup in the list, we need to escape the font name
and preview text pieces that we embed there.
2011-09-04 17:17:07 -04:00
Matthias Clasen
41dbd20d56
GtkAssistant: Fix label alignment
...
Make page titles left-aligned again. Changing from misc alignment
to GtkWidget::halign here was a mistake. We can't do that for labels
in a size group, as long as labels still pay attention to misc
alignment.
https://bugzilla.gnome.org/show_bug.cgi?id=658008
2011-09-04 00:42:31 -04:00
Matthias Clasen
dc898e3f84
GtkLabel: make patterns work a little better
...
When a pattern has been set, we must not throw away
the attributes that contain it.
https://bugzilla.gnome.org/show_bug.cgi?id=658111
2011-09-04 00:01:37 -04:00
Matthias Clasen
be152f9b61
GtkPlug: preserve map/unmap invariants
2011-09-02 21:40:42 -04:00
Matthias Clasen
ef4690d511
GtkGrid: make attaching more flexible
...
Allow to attach children at either end of row/column 0.
Proposed by Alex Larsson.
https://bugzilla.gnome.org/show_bug.cgi?id=657793
2011-09-02 20:07:19 -04:00
Cosimo Cecchi
f5e758bd60
themingengine: remove xthickness FIXME from gtk_render_line() code
...
The gtk_render_line() code has a FIXME (coming from the 2.x migration I
suppose) about using xthickness, and it actually hardcodes two lines of
different color instead of drawing a single one.
Since we don't support xthickness anymore, make gtk_render_line() do
what it says, i.e. just draw an 1px line colored with the current
color.
https://bugzilla.gnome.org/show_bug.cgi?id=657963
2011-09-02 15:11:53 -04:00
Cosimo Cecchi
640f06928f
treeview: add GTK_STYLE_CLASS_SEPARATOR for tree view separators
...
https://bugzilla.gnome.org/show_bug.cgi?id=657985
2011-09-02 15:11:15 -04:00
Eitan Isaacson
6eb777a8af
Change gtk_css_provider_propagate_error's signature.
...
Update to new parsing-error signal.
https://bugzilla.gnome.org/show_bug.cgi?id=657882
2011-09-02 09:19:18 -07:00
Matthias Clasen
22d046d7fe
Add a note about placeholder text use
...
Explain how this is really not such a great feature...
2011-09-02 00:35:38 -04:00
Javier Jardón
d780dde9e1
gtk/Makefile.am: Remove duplicate AM_CPPFLAGS
2011-08-30 22:47:33 +01:00
Matthias Clasen
3ff5a82e46
Clean up stock-icons
...
We copy them all in srcdir != builddir builds, so just
nuke the entire directory in that case.
2011-08-30 11:28:53 -04:00
Matthias Clasen
a233022934
Disable underallocation warnings in non-debug builds
...
It doesn't look like we have much traction of actually fixing
these, and there is very real cost to not being able to distcheck.
2011-08-30 11:28:52 -04:00
Murray Cumming
342c64c2f2
GtkToolShell: Move vfunc default results to default implementations.
...
Otherwise the default values are only used if no vfunc is set,
making that default unavailable to vfunc implementations as a fallback,
and unavailable to language bindings (such as gtkmm) that always
have a vfunc implementation, even if that often only tries to call
the base vfunc implemntation.
This was making gtkmm's ToolPalette's (and probably ToolBar's)
items look like buttons instead of being flat.
https://bugzilla.gnome.org/show_bug.cgi?id=656223
2011-08-30 15:28:06 +02:00
Matthias Clasen
9379a48e22
Add headers to treemodel test sources
...
...otherwise they don't make it into the release tarballs.
https://bugzilla.gnome.org/show_bug.cgi?id=657653
2011-08-29 20:34:46 -04:00
Matthias Clasen
925ed7c70f
Don't unref floating menuitems
...
With recent fixes, GTK+ no longer sinks menu items automatically,
so we have to do it explicitly here.
2011-08-29 11:57:39 -04:00
Alejandro Piñeiro
4244349600
a11y: Don't manage window events as a exception
...
https://bugzilla.gnome.org/show_bug.cgi?id=657260
2011-08-29 10:57:21 -04:00
Alejandro Piñeiro
08bf2e0463
a11y: Use AtkWindow on GtkWindowAccessible
...
GtkWindowAccessible doesn't require to define window related
signals. They are included on AtkWindow
2011-08-29 10:57:14 -04:00
Matthias Clasen
1090eba9a8
a11y: don't return random numbers
...
Return 0 for the image size if we don't have a pixbuf to measure.
2011-08-29 10:50:01 -04:00
Matthias Clasen
84504014aa
Fix exported symbols
2011-08-29 10:24:17 -04:00
Matthias Clasen
18dba17f0b
GtkAppChooserDialog: handle sensitivity of 'Select' better
...
When the dialog comes up without a selected item, make 'Select'
insensitive. Also, don't allow to unselect an item without
selecting a different one.
2011-08-28 23:49:41 -04:00
Matthias Clasen
6d797d5356
GtkAppChooser: Deal with 'no app found' gracefully
...
Several functions inside GtkAppChooserDialog were not handling
the situation that app_info might be NULL after the user clicked
'Select'.
https://bugzilla.gnome.org/show_bug.cgi?id=651827
2011-08-28 22:46:46 -04:00
Matthias Clasen
676316bbd3
Avoid warnings when widgets are not created yet
...
This widget is created on-demand, so we can not unconditionally
set its sensitivity in some other place.
2011-08-28 22:30:24 -04:00
Matthias Clasen
f64647077f
Add an accessor for grid children
...
This addresses concerns in bug 634136.
2011-08-28 21:20:53 -04:00
Matthias Clasen
b2188f5dc1
Trivial: include cleanups
2011-08-28 20:46:11 -04:00
Diego Celix
372a907e97
gtkappchooserdialog: gtk_misc_set_alignment
...
Replacing the function gtk_misc_set_alignment () with
gtk_widget_set_halign () and gtk_widget_set_valign () in
gtk/gtkappchooserdialog.c
https://bugzilla.gnome.org/show_bug.cgi?id=650762
2011-08-28 20:16:56 -04:00
Diego Celix
9dfff27c42
gtkaboutdialog: gtk_misc_set_alignment replacing
...
Replacing the function gtk_misc_set_alignment () with
gtk_widget_set_halign () and gtk_widget_set_valign () in
gtk/gtkaboutdialog.c
https://bugzilla.gnome.org/show_bug.cgi?id=650762
2011-08-28 20:16:54 -04:00
Matthias Clasen
5cc1318279
GtkTrayIconX11: Some more refactoring
...
I like my refactoring better...
2011-08-28 14:54:14 -04:00
Benjamin Otte
dca3ea896e
trayicon-x11: Refactor code a bit
...
Should make it more obvious what the code actually does.
2011-08-28 20:20:35 +02:00
Vincent Bernat
6754614ac1
trayicon-x11: Fix warnings when visual is not available.
...
This fixes a regression introduced in commit
b1a1685a33eca16979e63d79915395af0b36. gdk_visual_get_*_pixel_details()
should not be called with a NULL visual.
https://bugzilla.gnome.org/show_bug.cgi?id=649588
2011-08-28 20:20:35 +02:00
Matthias Clasen
6f39855c08
More include cleanups
2011-08-28 01:54:55 -04:00
Matthias Clasen
fd92e7150d
More include cleanups
2011-08-28 01:42:10 -04:00
Matthias Clasen
383127cd0b
Clean up unneeded includes
2011-08-28 01:40:10 -04:00
Matthias Clasen
227fafb93f
GtkPrintUnixDialog: Replace GtkTable by GtkGrid
2011-08-28 01:34:17 -04:00
Matthias Clasen
5b97a58230
GtkFileChooserDefault: Replace GtkTable by GtkGrid
2011-08-28 00:47:24 -04:00
Matthias Clasen
b043a0a610
GtkMountOperation: Replace GtkTable by GtkGrid
2011-08-28 00:39:44 -04:00
Matthias Clasen
280f34ec61
GtkPageSetupUnixDialog: replace GtkTable by GtkGrid
2011-08-28 00:35:51 -04:00
Matthias Clasen
1ca773c2d7
GtkColorSel: replace GtkTable by GtkGrid
2011-08-28 00:20:21 -04:00
Matthias Clasen
4b394fc847
Fix the build
2011-08-27 17:22:37 -04:00
Matthias Clasen
0039418001
GtkToolbar: partial fix for toolbar editing
...
When using an editable toolbar in evince, we can end up
in gtk_toolbar_get_visible() position with item being the
highlight_tool_item, but not one of the regular children.
So, handle that.
2011-08-27 11:45:01 -04:00
Matthias Clasen
c8e8cdaaf4
Make gtk_status_icon_set_name() work reliably
2011-08-27 01:26:48 -04:00
Matthias Clasen
8f3e43326b
Silence a compiler warning
2011-08-27 01:25:39 -04:00
Matthias Clasen
f7dbdba267
Revert "GtkColorButton: Don't forget to close a cairo context"
...
This reverts commit 144e4af8bc
.
2011-08-27 01:01:21 -04:00
Benjamin Otte
e11e51c252
notebook: Fix child property setters causing underallocations
...
Don't randomly allocate around, queue resizes instead.
2011-08-27 02:47:51 +02:00
Federico Mena Quintero
52711beba5
Merge branch 'bgo593793-filechooser-recent-folders-master'
2011-08-26 12:44:40 -05:00
Federico Mena Quintero
a265fb763b
bgo#657186 - Sort the recent-files list in newest-to-oldest order
...
Otherwise it's not very useful... :)
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2011-08-26 12:44:24 -05:00
Federico Mena Quintero
3bd037b7d9
Load and populate the recent-items in a single pass
...
There's no real asynchronicity going on, anyway, so let's do both within
a single iteration of the idle handler.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2011-08-26 12:44:22 -05:00
Federico Mena Quintero
e9c0faba42
Don't sort the recent-items by hand
...
The mtime from GtkRecentManager may not the same as the file's actual
mtime, so the final result could appear unsorted to the user. Instead,
we will let the view do the sorting.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
2011-08-26 12:44:21 -05:00
Tristan Van Berkom
d7696bd25f
Avoid dereferencing NULL pointer in gtk_label_drag_data_get()
...
It's possible the GtkLabel receives drag'n'drop related signals
if it was setup to receive them by a container or other external
code, just avoid dereferencing priv->select_info in this case.
2011-08-26 19:02:36 +02:00
Benjamin Otte
71c3f7e93d
styleproperty: Improve error message
...
We do dsupport that feature still and don't want to scare people into
thinking everything broke.
2011-08-26 16:26:28 +02:00
Benjamin Otte
26e9d07718
API: cssprovider: Change parsing-error signal
...
Instead of path, line and position, emit the section the error happened
in. This has a lot more information to consume.
2011-08-26 16:26:28 +02:00
Benjamin Otte
8d6b560ff3
cssparser: Fix cases where we could overrun the terminating 0
2011-08-26 16:26:28 +02:00
Benjamin Otte
62d231aeff
cssparser: Make lines and positions 0-indexed
2011-08-26 16:26:28 +02:00
Benjamin Otte
0d1b73f857
cssprovider: Store sections with parsed values
...
Also create a separate section for values to associate the values with.
Finally, use this section information when delayed-parsing a widget
style property.
2011-08-26 16:26:27 +02:00
Benjamin Otte
ebf0b6ee4d
cssprovider: Handle non-NULL-terminated data
...
Do a dumb copy if that happens.
2011-08-26 16:26:27 +02:00
Benjamin Otte
d985b95ef9
cssprovider: Keep only the curent section while parsing
...
We don't need a list of sections, the section can give us the parent
when we need it (d'oh).
2011-08-26 16:26:27 +02:00
Benjamin Otte
19c44967cb
cssprovider: Remove dead code
...
The code isn't used anymore since the introduction of rulesets.
2011-08-26 16:26:27 +02:00
Benjamin Otte
00d14e3515
API: css: Add GtkCssSection
...
This struct keeps track of an area of text in a CSS file and uses it
when specifying information. Also, the cssprovider keeps track of
sections when parsing a file.
2011-08-26 16:26:27 +02:00
Colin Walters
c8fdd5e847
Squash two compilation warnings about possibly-uninitialzed
2011-08-25 14:47:21 -04:00
Ryan Lortie
05aeaeef9e
Signalify (already existing) GtkMenuShell.insert()
...
gtk_menu_shell_insert() is a virtual function that was being directly
invoked from the class vtable.
Turn it into a proper signal and emit it in the usual way.
https://bugzilla.gnome.org/show_bug.cgi?id=656565
2011-08-25 09:48:12 -04:00
Chun-wei Fan
7cf479135d
Update gtk/Makefile.am
...
Distribute fallback implementation source file for rint()/round()
2011-08-24 23:55:44 +08:00
Matthias Clasen
4a857ac023
Use a weak ref in GtkAccelLabel
...
GtkAccelLabel was holding a strong reference on its parent,
which could, depending on the circumstances, lead to leaks.
https://bugzilla.gnome.org/show_bug.cgi?id=344858
2011-08-24 08:16:03 -04:00
Matthias Clasen
144e4af8bc
GtkColorButton: Don't forget to close a cairo context
...
Patch by Jerome Lambourg, bug 655392.
2011-08-24 07:46:35 -04:00
Matthias Clasen
5c09061e0f
GtkFontChooserDialog: Select when a list item is activated
...
This is the expected behavior.
2011-08-24 00:49:59 -04:00
Matthias Clasen
f7bf35052e
GtkFontChooser: Add a ::font-activated signal
...
This signal gets emitted when a font in the list is activated.
2011-08-24 00:49:16 -04:00
Matthias Clasen
ca0c7c1649
GtkAppChooserDialog: remove an unused variable
2011-08-24 00:32:20 -04:00
Matthias Clasen
80b94156ed
GtkAppChooserDialog: Simplify the construction
...
We do the same in other places.
2011-08-24 00:11:32 -04:00
Matthias Clasen
14dc863da5
GtkAppChooserButton: Make activating rows work as expected
...
When a row is activated in the 'Other...' dialog, we have
to make sure the dialog goes away.
2011-08-24 00:10:34 -04:00
Matthias Clasen
c83db6cdf0
GtkSwitch: Return FALSE from the button press handler
...
This makes the behavior identical to other widgets which
handle button presses, and it avoids problems when placing
switches into a windows main toolbar.
https://bugzilla.gnome.org/show_bug.cgi?id=656986
2011-08-23 23:29:19 -04:00