Carlos Garnacho
7fa3183d7f
gtkfilechoooserentry: Handle tab completion through key controller
2018-06-21 12:54:03 +02:00
Carlos Garnacho
176fd2fab3
gtkemojicompletion: Use GtkEntry key controller to handle key presses
2018-06-21 12:54:03 +02:00
Carlos Garnacho
419ee6a451
gtkentrycompletion: Properly remove controller from entry
...
When disconnecting the GtkEntry from the GtkEntryCompletion, we
must remove the controller in order to avoid dangling callbacks.
2018-06-21 12:54:03 +02:00
Carlos Garnacho
2c0d2d332f
gtkentrycompletion: Move focus out handling to key controller
...
We can use the already present key controller to handle focus out.
2018-06-21 12:54:03 +02:00
Carlos Garnacho
5f8fea08ff
gtkentrycompletion: Perform event handling on popup through controllers
...
Instead of a ::event signal handler.
2018-06-21 12:54:03 +02:00
Carlos Garnacho
f92ec7ce41
gtkplacessidebar: Replace ::event signal handlers with gestures
...
Set up a gesture on the sidebar rows to detect pointer clicks on
it. The row DnD management has been moved to the row widget itself,
it makes more sense even if the drag is began from the sidebar widget.
2018-06-21 12:54:03 +02:00
Carlos Garnacho
ca08cf94d3
gtkwindow: Move map/delete/configure event management to gtkmain
...
Toplevels are about the only widgets interested in these events,
just handle those without going through the capture/bubble handling
code.
2018-06-21 12:54:03 +02:00
Carlos Garnacho
3d5dc16d63
gtkwindow: Simplify WM drag/resize handling
...
We still need a drag gesture both on front (capture) and back (bubble)
to handle dragging from both the GtkWindow widget and chrome in the
headerbar. But we can do it through 2 drag gestures, instead of special
event handling code.
2018-06-21 12:52:59 +02:00
Carlos Garnacho
7bfc3a5c74
gtkmenushell: Port to GtkGesture
...
We still need to poke the current event at places, but this is
better than the ::event vfunc.
2018-06-21 12:50:58 +02:00
Carlos Garnacho
a5414bc404
gtkpopover: Fix key navigation
...
This has been broken since we switched key event delivery to follow
the same semantics than pointer/touch. There, GTK+ grabs will influence
the topmost widget during event delivery, rendering the toplevel
unable to handle key navigation. The toplevel must handle those key
events in an explicit manner then.
We don't render the keyboard focus rectangle yet, but I assume that's
something else.
2018-06-21 12:50:57 +02:00
Carlos Garnacho
1d97b5fd3c
gtkpopover: Port to GtkEventController/GtkGesture
...
Use GtkEventControllerKey and GtkGestureMultiPress to replace key/button
event handling.
2018-06-21 12:50:57 +02:00
Carlos Garnacho
aa09b0742e
gtkwindow: Handle focus in/out through key controller
...
One less use of ::event in this widget, now mostly left to
map/delete/configure, those puny events.
2018-06-21 12:50:57 +02:00
Carlos Garnacho
c5586f85fb
gtkspinbutton: Use GtkEventControllerKey
...
And drop the ::event vfunc implementation with it.
2018-06-21 12:50:57 +02:00
Carlos Garnacho
3eb1b22651
gtkfontchooser: Use GtkEventControllerKey
...
Use an event controller on GtkFontChooserDialog, a nice side effect
is that we can use gtk_event_controller_key_forward() and
gtk_search_entry_set_key_capture_widget() instead of passing events
around for dialog search.
2018-06-21 12:50:57 +02:00
Carlos Garnacho
4186a85359
gtkfilechooserwidget: Drop usage of ::event vmethod
...
Use a key controller set up in the UI file instead.
2018-06-21 12:50:57 +02:00
Carlos Garnacho
aaf1e4995c
gtkfilechooserentry: Use GtkEntry key controller for focus-out handling
...
Expose the GtkEntry key controller in private API, so we don't have to
create yet another one just to handle focus-out.
2018-06-21 12:50:57 +02:00
Carlos Garnacho
e08e15ba51
gtkentry: Use gestures for entry icons
...
Instead of doing all handling manually in the ::event vfunc,
set up drag/multipress gestures on icon images, and implement
emission of ::icon-press/release and DnD there.
As a side effect, the GdkEvent field in ::icon-press/release
signals has been dropped. Callers that might be interested on it
may still use gtk_get_current_event*().
2018-06-21 12:50:57 +02:00
Carlos Garnacho
7048362e6e
gtkbutton: remove keyboard device GTK+ grab
...
This isn't really necessary, if keyboard focus forcibly goes somewhere
else we will get ::grab-notify, which is sufficient to deactivate the
button again.
2018-06-21 12:50:57 +02:00
Carlos Garnacho
5f0ed088e4
gtkbutton: Use key controller for button (de)activation through keybindings
...
And stop using GtkWidget::event for good.
2018-06-21 12:50:57 +02:00
Matthias Clasen
5c46c81067
x11: Fix dnd action handling
...
We were mistakenly assigning an Atom to a flags value.
2018-06-20 18:10:50 -04:00
Daniel Boles
c6fa3c446c
EmojiCompletion: Avoid another un/signed warning
...
The cherry-pick missed this, I guess.
2018-06-20 20:51:50 +01:00
Daniel Boles
f7ebff6aea
EmojiCompletion: Avoid un/signed compare warnings
...
(A) Use gsize to match the result of g_variant_n_children
(B) Use guint for n_matches, like the struct (and all other n_matches)
2018-06-20 20:38:27 +01:00
Daniel Boles
8aeced2c91
themes: Remove leftover bit of .linked workaround
...
Now that .linked acts like the .path-bar already did, there is no point
in applying the same styles again (with higher specificity).
2018-06-20 20:11:26 +01:00
Timm Bäder
e8fefd92c5
container: Remove SPECIAL_CONTAINER hack
...
As discussed in !129
Closes !129
2018-06-20 20:47:18 +02:00
Timm Bäder
22390adf11
stackswitcher: Remove icon-size property
...
This ought to be controlled via css these days.
2018-06-20 20:47:18 +02:00
Timm Bäder
cf9121977f
infobar: Remove priv pointer
2018-06-20 20:47:18 +02:00
Timm Bäder
99099a1053
Remove some unnecessary snapshot implementations
2018-06-20 20:47:18 +02:00
Timm Bäder
daba1a7eff
fixed: Remove priv pointer
2018-06-20 20:47:17 +02:00
Timm Bäder
f26359db13
listbox: Use widget insert API instead of fiddling with CSS nodes
2018-06-20 20:47:17 +02:00
Timm Bäder
945b844b7c
button: Remove ICON_SIZE_BUTTON mention in docs
...
The icon will have the size given by css, not whatever
GTK_ICON_SIZE_BUTTON was.
2018-06-20 20:47:17 +02:00
Timm Bäder
f33655fa4e
adjustment: Only emit ::changed from dispatch_properties_changed
2018-06-20 20:47:17 +02:00
Timm Bäder
ee8ee313c8
adjustment: Remove adjustment_changed_stamp
2018-06-20 20:47:17 +02:00
Timm Bäder
33e113d607
testsuite: Print tested property name in notify test
2018-06-20 20:47:17 +02:00
Timm Bäder
a12d26155f
adjustment: Use public setters in set_property
2018-06-20 20:47:17 +02:00
Daniel Boles
cae382c829
themes: Regenerate CSS for recent commits
...
e.g. the box.linked one, which didn't update the compiled CSS.
2018-06-20 19:26:46 +01:00
Daniel Boles
0a5086d94f
HC: Avoid excessive selectors from prev commit
...
The new rule does not need to affect all those other pseudoclasses. I
just put it in the wrong scope.
2018-06-20 19:26:41 +01:00
Daniel Boles
b103650cb0
HC: Avoid same BG/FG colors in flat treeview entry
...
Selected rows in tree views in HighContrast have a background colour the
same or nearly as the normal text colour, so we cannot let entries in
such rows have transparent backgrounds, or the text inside the entry
becomes nearly or totally impossible to see.
Dodge this by giving entry.flat inside treeview and with :focus the
$base_color, which is different from the text & so lets that be seen.
https://gitlab.gnome.org/GNOME/gtk/merge_requests/125
2018-06-20 19:13:26 +01:00
Daniel Boles
337e602143
searchenginetracker: Don't leak the hits' GFiles
...
https://gitlab.gnome.org/GNOME/gtk/merge_requests/206
2018-06-20 17:20:31 +01:00
Matthias Clasen
7ce25293b1
Merge branch 'issue1084' into 'master'
...
application: Complete the startup sequence before quitting remote instances
Closes #979
See merge request GNOME/gtk!156
2018-06-20 15:34:51 +00:00
Matthias Clasen
cd99f82e0c
Merge branch 'master' into 'issue1084'
...
# Conflicts:
# gdk/gdk.c
2018-06-20 14:21:24 +00:00
Timm Bäder
29fee2e808
window: Remove priv pointer
2018-06-20 07:49:04 +02:00
Timm Bäder
417b1d8335
pathbar: Remove unused define
2018-06-20 07:48:54 +02:00
Matthias Clasen
443a64a38e
docs: Remove a duplicate line in gdk4-sections.txt
...
This was causing another docs build break.
2018-06-19 17:16:31 -04:00
Matthias Clasen
74455ae75c
docs: fix a typo
...
Invalid syntax in gdk4-sections.txt was causing docs builds to fail.
2018-06-19 17:16:31 -04:00
Daniel Boles
ec096b417c
Merge branch '1160-crash-clearing-gtkentry-icon-tooltip-master' into 'master'
...
Resolve "Crash clearing GtkEntry icon tooltip"
Closes #1160
See merge request GNOME/gtk!205
2018-06-19 20:22:38 +00:00
Benjamin Otte
06bba15f62
win32: Fix typo
...
This should fix gtk-doc erroring out.
2018-06-19 21:45:44 +02:00
Benjamin Otte
c48be6ef96
Revert "Add aligned allocator functions to GSK"
...
This reverts commit 8e74eb382f
.
This code is not necessary. It worked around a bug in graphene where
graphene was requiring stricter alignment than glib allocators could
guarantee.
2018-06-19 20:00:53 +02:00
Benjamin Otte
0b1f0984f5
Revert "Use aligned allocators for GtkSnapshot"
...
This reverts commit c02bc22cc5
.
This code is not necessary.
The bug causing this problem ws prsent in the graphene library.
2018-06-19 19:52:52 +02:00
Benjamin Otte
6918fb2e4e
rendernodepaintable: Fix rendering position
...
When the given size had an offset, we were moving that offset in the
wrong direction.
2018-06-19 19:44:17 +02:00
Benjamin Otte
3caf8c86c9
dnd: Use a GtkPicture in gtk_dnd_set_icon_paintable()
...
We don't want to get the paintable scaled down to icon size.
Also set can-shrink = FALSE to replicate GTK3 behavior with size
requests.
2018-06-19 19:44:17 +02:00