Matthias Clasen
9f008e3477
GtkStyleContext: Avoid over-eager animation cancellation
...
When validating the style context, we are copying the animations
from one StyleValues instance to another, and cancel the old ones.
It turns out that sometimes the old and the new StyleValues are
the same, and in this case, we end up cancelling the animations
for good.
One case where breakage from this was observed is that the spinners
in gtk3-widget-factory stop spinning when you open and close a modal
dialog on page 2. This depends a bit on the window manager; the problem
can only be seen if opening the dialog causes a transition to backdrop.
2014-06-29 19:41:11 -04:00
Jasper St. Pierre
3d53e5d9c7
gtkmain: One more combine
2014-06-29 19:10:42 -04:00
Jasper St. Pierre
e95efbfc42
gtkmain: Combine two switch cases that are the same
2014-06-29 19:10:42 -04:00
Jasper St. Pierre
fc75f459b0
gtkswitch: Fix docs
2014-06-29 19:10:42 -04:00
Jasper St. Pierre
c84b49e332
gtkcellarea: Fix docs
2014-06-29 19:10:42 -04:00
Jasper St. Pierre
8fb2bdb2fb
gdkdevicemanager-xi2: Add debug output for key events
2014-06-29 19:10:42 -04:00
Jasper St. Pierre
de5cba4fc9
gdkdevicemanager-xi2: Fix debug outputs for button events
...
We had the arguments in the wrong order here.
2014-06-29 19:10:41 -04:00
Benjamin Otte
62c6ef5a29
tests: Remove tests for icontheme properties
...
These properties have been removed and always return %NULL, so no need
to keep them.
2014-06-30 01:08:02 +02:00
Matthias Clasen
297abd6e54
testdialog: Add a spinner
...
Trying to track down a problem where animation stops when a modal
dialog is opened and closed.
2014-06-29 14:03:52 -04:00
Matthias Clasen
b3b861c9d6
widget-factory: Plug a memory leak
2014-06-28 23:27:36 -04:00
Matthias Clasen
c304a84f2c
GtkBuilder: Fix more GMenu leaks in the parser
2014-06-28 23:19:09 -04:00
Matthias Clasen
6f0951845f
GtkMenuTrackerItem: Plug a memory leak
...
gtk_menu_tracker_get_[verb_]icon both return a reference,
so don't use g_value_set_object, which adds another one.
2014-06-28 22:39:43 -04:00
Matthias Clasen
d143919527
GtkCssImageIconName: Plug a memory leak
...
valgrind was complaining that we're not freeing the icon_name.
2014-06-28 22:39:02 -04:00
Matthias Clasen
8e0ba5bb3e
GtkColorEditor: Initialize the allocation x/y
2014-06-28 22:38:13 -04:00
Matthias Clasen
0b88b869e6
GtkActionMuxer: Plug a memory leak
...
valgrind complained that we leak the primary_accels table.
2014-06-28 22:37:14 -04:00
Matthias Clasen
4067d0623f
Revert "scrolledwindow: fix scrolling with shared adjustment"
...
This reverts commit f0478c3dfd
.
Didn't mean to push this.
2014-06-28 22:29:57 -04:00
Matthias Clasen
31e4ec4632
GtkFileChooserWidget: Remove an errant line
...
This was leaking a schema object, and looks like a bad merge.
2014-06-28 21:38:47 -04:00
Matthias Clasen
7d67206734
GtkBuilder: Don't leak a reference to constructed GMenus
...
_gtk_builder_add_object adds a reference, so we need to drop
our initial one.
2014-06-28 20:21:32 -04:00
Matthias Clasen
70bfb02fde
GtkGesture: Don't leak the group link
...
Found in a valgrind log.
2014-06-28 20:15:12 -04:00
Matthias Clasen
18126121a4
widget-factory: Small cleanup
...
Use gtk_builder_new_from_resource and get rid of an unneeded GError.
2014-06-28 16:22:43 -04:00
Matthias Clasen
7074776a04
widget-factory: Make the entry progress stop as well
2014-06-28 16:19:33 -04:00
Matthias Clasen
ef0e164a4c
GtkEntry: Make progress pulsing smooth
...
This changes the calculation of activity mode progress in the
same way as was done in GtkProgressBar a while ago, and make it
smooth, using a tick callback.
2014-06-28 15:51:33 -04:00
Matthias Clasen
3c40082316
widget-factory: Make the entry progress variable too
...
Make the scale that currently controls the speed of the progressbar
control the progress speed in the entry as well.
2014-06-28 15:23:29 -04:00
Stefan Sauer
f0478c3dfd
scrolledwindow: fix scrolling with shared adjustment
...
The GtkPolicyType set on the scrollbar is just about the presentation. What
matters for scrolling is the adjustment.
https://bugzilla.gnome.org/show_bug.cgi?id=730730
2014-06-28 11:49:54 -04:00
Matthias Clasen
c389fc64f7
widget-factory: Add an icon view
...
We didn't have one before, and this gives us a chance to show off
rubberbanding and symbolic icon rendering.
2014-06-28 11:37:29 -04:00
Matthias Clasen
3da76c1e14
Disable deprecation warnings for installed reftests
...
Otherwise, these fail in continuous.
2014-06-28 11:13:17 -04:00
Matthias Clasen
76eed98b36
widget-factory: Enable alpha in the color button
...
This lets us verify that the theme treats the alpha scale fairly.
2014-06-28 11:12:23 -04:00
Matthias Clasen
6119f66401
notification test: Always disable runtime deprecation warnings
...
These are just not useful in a test that generically deals with
all properties.
2014-06-28 10:59:41 -04:00
Matthias Clasen
f1c1192e71
Exclude GtkToggleButton::draw-indicator from the notification test
...
We reverted to emitting redundant notifications for this, so
don't assert that we don't.
2014-06-28 10:58:24 -04:00
Matthias Clasen
733a590fbe
GtkButton: warn slightly less
...
Use gtk_misc_set_alignment when setting x/align on button children
where possible, to avoid the runtime warning that g_object_set
incurs nowadays.
2014-06-28 10:56:54 -04:00
Lapo Calamandrei
4287e44a9a
Adwaita: minor code refactoring
2014-06-28 15:22:23 +02:00
Lapo Calamandrei
0fd3ec80db
Adwaita: button work
...
- finally fixed +|- buttons on inline toolbars
- commented out :focus and :selected for normal buttons since it makes
flat buttons background blue...
2014-06-28 15:05:06 +02:00
Bastien Nocera
d454d986d9
docs: Sort GDK_DEBUG values alphabetically
...
https://bugzilla.gnome.org/show_bug.cgi?id=732330
2014-06-28 12:17:04 +02:00
Bastien Nocera
7c88f19c74
docs: Sort GDK_DEBUG values alphabetically
...
https://bugzilla.gnome.org/show_bug.cgi?id=732330
2014-06-28 12:17:04 +02:00
Matthias Clasen
cc8ee01ff6
Avoid a redundant strlen
...
The GString knows perfectly well how long it is. Pointed out in
https://bugzilla.gnome.org/show_bug.cgi?id=731158
2014-06-28 01:51:24 -04:00
Matthias Clasen
fda53e5529
Adwaita: Neuter frames in statusbars
...
Too much.
2014-06-28 01:34:25 -04:00
Matthias Clasen
c4e533ecd6
Fight deprecation warnings in test
...
This time, in installed tests.
2014-06-28 00:41:26 -04:00
Saurabh
931958f9f4
Adding 'no-matches' signal support to gtkentrycompletion
...
Add a new 'no-matches' signal and add a function pointer to gtkentrycompletionclass
and remove one from the padding at the end.
https://bugzilla.gnome.org/show_bug.cgi?id=726566
2014-06-28 00:41:09 -04:00
William Jon McCann
aa30278e6b
Allow activating an item after single click on a different item
...
We were ignoring double click events when a different item was
previously selected.
https://bugzilla.gnome.org/show_bug.cgi?id=484640
2014-06-28 00:23:02 -04:00
Matthias Clasen
3f7318432c
GtkPrintUnixDialog: Set a higher limit for the number of copies
...
As requested in bug 672676.
2014-06-28 00:20:19 -04:00
Emilio Pozuelo Monfort
6de2c7fa0e
wayland: don't change the cursor if there is no pointer
...
https://bugzilla.gnome.org/show_bug.cgi?id=732206
2014-06-28 00:12:20 -04:00
Jasper St. Pierre
2651b99a13
colorplane: Don't connect to the configure-event signal
...
We want to stop people from using configure events
entirely. GtkDrawingArea synthesizes a configure event, but we can just
make the only user of this functionality stop it, and correct the
documentation to not mention it.
2014-06-28 00:10:42 -04:00
Matthias Clasen
691dd83580
Improve popover menu spacing
...
Make iconic buttons have a more reasonable height, and add some
space above an iconic row.
https://bugzilla.gnome.org/show_bug.cgi?id=732229
2014-06-28 00:00:16 -04:00
Matthias Clasen
b9941d0dde
Fix a documentation copy-paste error
...
The color chooser doesn't deal with fonts.
2014-06-27 23:53:03 -04:00
Matthias Clasen
38e4fbc90c
Revert "colorplane: Don't connect to the configure-event signal"
...
This reverts commit 886f58e1cf
.
This made the color plane go missing.
2014-06-27 22:03:59 -04:00
Matthias Clasen
96b6b44e4e
GtkMessageDialog: Don't set x/yalign explicitly
...
The h/valign work fine to give us what we need here, so we
can avoid the runtime deprecation warnings for deprecated
properties.
2014-06-27 21:57:25 -04:00
Matthias Clasen
ad09fbbac0
widget-factory: Stop using GtkImageMenuItem
...
A plain GtkMenuItem works just fine here.
2014-06-27 21:45:33 -04:00
Matthias Clasen
d7bccbe53b
widget-factory: Stop using the deprecated GtkAlignment::left-padding
...
These alignments can just be dropped without loss.
2014-06-27 21:45:23 -04:00
Matthias Clasen
e73aa234e9
widget-factory: Don't use deprecated GtkColorButton::color
...
Instead, simply set the rgba property, which accepts the
same value.
2014-06-27 21:45:18 -04:00
Matthias Clasen
cac4050240
widget-factory: Drop redundant defaults from the .ui file
...
In particular, we drop xalign, since it is deprecated.
2014-06-27 21:40:08 -04:00