AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity
68,548 Commits 969 Branches 749 Tags 504 MiB
9f10f9a595
Commit Graph

37901 Commits

Author SHA1 Message Date
Matthias Clasen
9f10f9a595 Merge branch 'fix-network-places' into 'master' 
placesview: Avoid use-after-free

See merge request GNOME/gtk!3186
 2021-02-11 19:41:10 +00:00
Matthias Clasen
560e27a3f4 Merge branch 'wip/jimmac/tiled-shadow-fix-fix-gtk4' into 'master' 
Adwaita: bring borders for tiled

Closes #3661

See merge request GNOME/gtk!3184
 2021-02-11 17:04:47 +00:00
Emmanuele Bassi
a63a2b26cf Ensure we don't overflow when using g_memdup2() 
When we turn integers into size_t we should check we're not going to
make a mess.
 2021-02-11 14:22:23 +00:00
Emmanuele Bassi
78e3908a00 gtk: Move from g_memdup() to g_memdup2() 
The g_memdup() function is replaced by a safer version in newer versions
of GLib.
 2021-02-11 14:22:22 +00:00
Jakub Steiner
f953dfef11 Adwaita: bring borders for tiled 
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3661
 2021-02-11 15:16:57 +01:00
Matthias Clasen
95d48ac2e8 placesview: Avoid use-after-free 
The places view has questionable code for handling
'destroy', which seems to trigger use-after-free in
some cases. Clean this up a bit by acknowledging the
cancellation fully, rather than relying on the
destroyed flag.
 2021-02-11 09:14:34 -05:00
Matthias Clasen
e823fa6665 Merge branch 'fix-filter-value' into 'master' 
css: Avoid an invalid read

See merge request GNOME/gtk!3181
 2021-02-11 00:51:40 +00:00
Christian Hergert
c90ffc7363 snapshot: fix warning when asserts are disabled 2021-02-10 16:13:38 -08:00
Matthias Clasen
3eb4ec89f3 css: Avoid an invalid read 
This was broken in ea7185bdb1.

Pointed out by Christian Hergert.
 2021-02-10 19:13:36 -05:00
Jakub Steiner
da64856f37 Adwaita: don't cast shadows for halt-tiled windows 
- while the case of a single half tiled window casting shadow is valid,
  the main use case for half tiled windows is when they have a neighbor.
  The :backdrop should be enough of a focus indicator and we avoid shadow
  casting on neighbors that are on the same Z level.
 2021-02-09 18:57:31 +01:00
Christian Hergert
461fe36707 adwaita: disable shadows when window is maximized or fullscreen 
These shadows cause a significant draw performance drop for maximized
windows. Disabling them increases the chances we can have faster scroll
performance of text.

There is some risk here for systems where they have a dock and you expect
the shadow to draw beneath that dock for transparency reasons.
 2021-02-09 09:27:22 -08:00
Alexander Mikhaylenko
cf61d96188 headerbar: Null-check boxes when removing window controls 
Prevent a crash when show-title-buttons value changes to FALSE during
destruction.
 2021-02-08 18:46:35 +05:00
Alexander Mikhaylenko
319755662f headerbar: Don't use gtk_widget_unparent() with GtkBox 
gtk_widget_unparent() is for widget implementations, it's not supposed to
be used from outside.
 2021-02-08 18:46:27 +05:00
Matthias Clasen
15697d5c0c Merge branch 'focus' into 'master' 
listbox: Fix handling of non-focusable rows

Closes #3633

See merge request GNOME/gtk!3152
 2021-02-07 15:57:11 +00:00
Matthias Clasen
5f48764ac8 cssfiltervalue: Reject invalid filters 
The Filter Effects Spec doesn't allow negative values
for most of the filter parameters.
 2021-02-06 16:16:44 -05:00
Matthias Clasen
cc6fcbfc09 cssfiltervalue: Fix blur filter interpretation 
According to https://www.w3.org/TR/filter-effects-1/,
the length passed to blur() is the standard deviation,
and according to https://www.w3.org/TR/css-backgrounds-3/#shadow-blur
the blur radius is twice the standard deviation.
 2021-02-06 16:16:44 -05:00
Matthias Clasen
ea7185bdb1 cssfiltervalue: Implement drop-shadows 
We have all the pieces, so this is surprisingly easy.
 2021-02-06 16:16:43 -05:00
Matthias Clasen
429dfcf483 cssshadowvalue: Add a 'filter mode' 
Shadow values created by gtk_css_shadow_value_new_filter or
gtk_css_shadow_value_parse_filter interpret their radius value
as standard deviation. Add a flag for this mode, and use it
where necessary.
 2021-02-06 16:10:34 -05:00
Matthias Clasen
be3f352b59 cssshadowvalue: Add a parsing function 
Add a variant of the parse function that parses
just a single (non-box) shadow, as required for
the drop-shadow filter.
 2021-02-06 16:10:32 -05:00
Matthias Clasen
5b8896f1db cssshadowvalue: Add gtk_css_shadow_value_pop_snapshot 
This is the counterpart ot gtk_css_shadow_value_push_snapshot.

To make this easy, move the determination whether we need a
shadow out of the push function and save it.
 2021-02-06 16:09:21 -05:00
Matthias Clasen
4e27de7df9 cssshadowvalue: Drop the underscore 
Rename _gtk_css_shadow_value_parse to drop the underscore.
It was the only underscore-prefixed function in this file.
 2021-02-06 16:08:19 -05:00
Matthias Clasen
9770872d12 css: Implement the drop-shadow filter 
We have all the pieces, so this is surprisingly easy.
 2021-02-05 21:37:14 -05:00
Matthias Clasen
de24b4f91b cssshadowvalue: Add a parsing function 
Add a variant of the parse function that parses
just a single (non-box) shadow, as required for
the drop-shadow filter.
 2021-02-05 21:36:22 -05:00
Emmanuele Bassi
958005317b Merge branch 'master' into 'master' 
Improve the docs of GtkWidget and GtkGrid

See merge request GNOME/gtk!2946
 2021-02-05 12:14:26 +00:00
Matthias Clasen
482b73c376 Merge branch 'matthiasc/for-master' into 'master' 
docs: Rewrite the long description for GtkDialog

Closes #3646

See merge request GNOME/gtk!3156
 2021-02-05 00:10:47 +00:00
Maximiliano Sandoval R
3e2e6633b0
gtkshow: Fix doc typo 2021-02-04 21:02:22 +01:00
Matthias Clasen
4724f9907c docs: Rewrite the long description for GtkDialog 
As was pointed out in #3646, some of the content here
was a bit outdated.

Fixes: #3646
 2021-02-04 13:05:28 -05:00
Matthias Clasen
26e84a7b8c Merge branch 'matthiasc/for-master' into 'master' 
More work on css transition tests

See merge request GNOME/gtk!3154
 2021-02-04 13:28:59 +00:00
Matthias Clasen
2f42e1fb89 treemodelfilter: Drop unreachable code 
We never get here. The compiler says so.

Pointed out in https://www.viva64.com/en/b/0793/
 2021-02-04 00:40:14 -05:00
Matthias Clasen
b5200bd076 css: Drop a bit of unreachable code 
We never get here. The compiler says so.

Pointed out in https://www.viva64.com/en/b/0793/
 2021-02-04 00:39:34 -05:00
Matthias Clasen
aa5bd38137 a11y: Avoid out-of-bounds access 
Don't use the index before we've checked its good.

Pointed out in https://www.viva64.com/en/b/0793/
 2021-02-04 00:34:05 -05:00
Matthias Clasen
1e0ea21297 messagedialog: Don't initialize twice 
We don't need to set these fields more than once.

Pointed out in https://www.viva64.com/en/b/0793/
 2021-02-04 00:25:36 -05:00
Matthias Clasen
e91e75173d composetable: Remove a redundant check 
We already know seq_index is not NULL here.

Pointed out in https://www.viva64.com/en/b/0793/
 2021-02-04 00:22:52 -05:00
Matthias Clasen
041f410838 textbtree: Avoid line vs char count confusion 
The post_insert_fixup helper function was confused about
its argument order.

Pointed out in https://www.viva64.com/en/b/0793/
 2021-02-04 00:17:55 -05:00
Matthias Clasen
c71c8919fe listbase: Don't specify the same thing twice 
We only need to set EXPLICIT_NOTIFY once.

Pointed out in https://www.viva64.com/en/b/0793/
 2021-02-04 00:13:53 -05:00
Matthias Clasen
3f28399f7d css: Fix border value parsing 
This function was not resetting computed as it meant
to because the last loop was never executed.

Pointed out in https://www.viva64.com/en/b/0793/
 2021-02-04 00:12:51 -05:00
Matthias Clasen
1af72eac21 cssvalue: Cosmetic change 
Don't return FALSE from pointer-returning functions.
 2021-02-03 22:10:13 -05:00
Matthias Clasen
a14a0c6315 css: Fix shadow value equal 
This function was not doing the right thing.

Once we are doing the right thing and not compare
shadows as unequal, some reftests that inhibit
snapshots for a few frames now hang forever, since
we are no more redrawing unnecessarily. Fix that
with an explicit queue_draw.
 2021-02-03 22:10:13 -05:00
Matthias Clasen
38481680e1 Merge branch 'wip/jimmac/colored-list-image-buttons' into 'master' 
Adwaita: allow suggested and destructive action buttons in lists

Closes #3643

See merge request GNOME/gtk!3153
 2021-02-04 01:38:47 +00:00
Jakub Steiner
289bf078bf Adwaita: allow suggested and destructive action buttons in lists 
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3643
 2021-02-03 23:15:30 +01:00
Elias Projahn
a7ae94c06e listbox: Fix handling of non-focusable rows 
This commit modifies the gtk_list_box_row_grab_focus() implementation to
correctly return FALSE in case the row couldn't be focused. This behavior will
also be honored by gtk_list_box_row_focus() to properly handle focus in that
case. To achieve that, the method has been restructured slightly.

Closes #3633
 2021-02-03 21:22:55 +01:00
Emmanuele Bassi
592b33cb48 Graphene is a dependency of Gsk, not Gdk 
So let's put it in the right place when building the introspection data.
 2021-02-03 14:05:27 +00:00
Matthias Clasen
919c08d4fd css: Allow transitioning different-size shadows 
The code handles it just fine. The length check was
an erronous addition.
 2021-02-02 15:27:42 -05:00
Matthias Clasen
949c783187 composetable: Parse hex escapes too 
This was a small omission from the Compose file
syntax that doesn't cost us much to support.

Add a test for this syntax too.

Fixes: #1004
 2021-02-02 12:05:19 -05:00
Matthias Clasen
676f875bf6 composetable: Support string values in the cache 
Change the cache format to include the character
data that we need to hold string values in the table.
 2021-02-02 11:55:00 -05:00
Matthias Clasen
140c5c5333 composetable: Don't use GSlice for big blobs 
This just doesn't make sense. This will use malloc
anyway, so just call malloc directly.
 2021-02-02 11:55:00 -05:00
Matthias Clasen
cebf2b2009 composetable: Keep multi-char values 
Keep string values in the table, and return them
from the check function. This commit temporarily
disables the table caching, since the cache format
does not handle string values yet.

Fixes: #186
 2021-02-02 11:54:53 -05:00
Matthias Clasen
773ae0cd0f composetable: Parse multi-char values 
Rewrite the value parsing function to accept strings
that hold more than a single Unicode character.
 2021-02-02 09:03:53 -05:00
Matthias Clasen
564793d5b5 composetable: Another step towards multi-char values 
Change the parser data structures to hold a string, rather
than a gunichar. We still only put a single Unicode character
into it, currently.
 2021-02-02 09:02:46 -05:00
Matthias Clasen
9142aa0f51 composetable: Prepare for multi character values 
Make it possible for gtk_compose_table_check to return
a string instead of just a single Unicode character.
Currently, we only ever return strings holding a single
character, still.
 2021-02-02 09:02:00 -05:00