AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity
68,775 Commits 969 Branches 749 Tags 504 MiB
b9f0cf1c8b
Commit Graph

37977 Commits

Author SHA1 Message Date
Matthias Clasen
da71a37945 imwayland: Return limited preedit attributes 
It should not matter, but it is the right thing to
do to limit the preedit attributes to the length
of the preedit text.
 2021-02-17 22:57:41 -05:00
Matthias Clasen
05fe2441a7 imcontext: Enable font fallback for preedit 
Not doing so only invites hexboxes.

Fixes: #3678
 2021-02-17 22:11:57 -05:00
Matthias Clasen
35488959b4 paned: Add a paned handle class 
Instead of bending GtkGizmo to the breaking point,
split off a GtkPanedHandle class that just does
what is needed here. Its simpler, and lets us keep
GtkGizmo simpler too. Everybody wins.
 2021-02-17 21:45:33 -05:00
Matthias Clasen
af1981eda2 popovercontent: Few small fixes 
Forgot to include config.h. Oops, and we make things
a bit shorter still.
 2021-02-17 21:44:53 -05:00
Matthias Clasen
41abda9f03 Make gtk_im_modules_init properly private 
Putting non-exported symbols in public headers can
only lead to confusion and day drinking. Don't do it.

Fixes: #3676
 2021-02-17 15:25:42 -05:00
Matthias Clasen
04daa236ad Revert "gizmo: Add a css_changed function" 
This reverts commit 39f72b3834.
 2021-02-16 23:51:14 -05:00
Matthias Clasen
31ceb4ddfb Revert "gizmo: Chain up in css_changed" 
This reverts commit bb0a1b0cfe.
 2021-02-16 23:51:14 -05:00
Matthias Clasen
c2f811dd29 popover: Add a popover content class 
Instead of bending GtkGizmo to the breaking point,
split off a GtkPopoverContent class that just does
what is needed here. Its simpler, and lets us keep
GtkGizmo simpler too.
 2021-02-16 23:51:14 -05:00
Jakub Steiner
edcd4c6207 Adwaita: control surface for resize tiled windows 
- window resizing control area is implemented as where the shadows are drawn
- create a 'fake' shadow for the tiled case to allow easier resizing of
  the tiled window ratio even if it's offset to the side of the border

Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3670
 2021-02-16 14:10:14 +01:00
Jakub Steiner
67b5a34bad Adwaita: Avoid fine-tune scrollbars jumping 
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3672
 2021-02-16 11:59:45 +01:00
Matthias Clasen
bb0a1b0cfe gizmo: Chain up in css_changed 
css_changed is a vfunc that *must* chain up.
Failure to do so broke the resizing of overlay scrollbars,
amongst other things.

This bug was introduced in 39f72b3834.
 2021-02-15 14:26:52 -05:00
Matthias Clasen
2ac5c3282f Merge branch 'lenient-compose-parsing' into 'master' 
imcontext: Be more lenient in parsing Compose

See merge request GNOME/gtk!3201
 2021-02-15 18:08:45 +00:00
Matthias Clasen
6b3c356eb7 Merge branch 'wip/jimmac/larger-smaller-scrollbar-gtk4' into 'master' 
Adwaita: Scrollbar transitions and size

Closes #1886

See merge request GNOME/gtk!3204
 2021-02-15 18:06:00 +00:00
Jakub Steiner
5c5cd34c2f Adwaita: Scrollbar transitions and size 
- tone down the size of the controller again
- transition between the indicator and control fluidly

Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/1886
 2021-02-15 12:25:09 +01:00
Matthias Clasen
2f43b8dc49 imcontext: Improve compose table parsing 
Avoid leaking value in error cases, and actually
emit a warning for a missing quote. Pointed out
by Peter Bloomfield.
 2021-02-15 01:46:00 -05:00
Matthias Clasen
d2e074e36b imcontext: Be more lenient in parsing Compose 
X11 allows keysyms to be specified in addition to strings.
We only support the strings. In the past, we ignored everything
after the string. Go back to doing that, but issue a warning
that we've ignored the keysym.
 2021-02-14 12:56:00 -05:00
Matthias Clasen
2623932886 Merge branch 'fix-compose-comments' into 'master' 
Fix compose comments

Closes #3664

See merge request GNOME/gtk!3199
 2021-02-14 17:25:58 +00:00
Matthias Clasen
f15aa2f3e5 imcontext: Fix a regression in Compose file parsing 
We accidentally dropped the handing of # comments.
Bring it back. Test included.

Fixes: #3664
 2021-02-14 11:56:24 -05:00
Matthias Clasen
52a2891933 window: Add some more details to css docs 
Mention more of the supported style classes.
 2021-02-14 11:22:44 -05:00
Matthias Clasen
7ebc3a9489 Update popover css docs 
Mention that shadows are now possible.
 2021-02-14 11:14:23 -05:00
Matthias Clasen
aa1d08687d popover: Handle shadow changes 
When the box-shadow css property of the contents
widget changes, queue a resize on the popover.
 2021-02-14 10:12:10 -05:00
Matthias Clasen
39f72b3834 gizmo: Add a css_changed function 
In a break from the current gizmo api, add a separate
setter, since the calls with long argument lists full
of NULL are getting out of hand.
 2021-02-14 10:12:10 -05:00
Matthias Clasen
b948799778 popover: Support shadows 
Use gdk_popup_layout_set_shadow_width to take shadows into
account when positioning popovers, and set the input region
to exclude the shadow, since we aren't doing interactive
resizing and the like.

When the popover has a beak, we make the surface size be
content size + shadow + tail, and then position the content
according to the final position inside this slightly too large
surface. The surface being too large doesn't matter, since we
set up an input region.
 2021-02-14 10:11:17 -05:00
Matthias Clasen
b3a055a9b7 popover: Queue a resize when position changes 
At least with an arrow, changing the position
requires a resize
 2021-02-13 20:27:01 -05:00
Matthias Clasen
bd877ccf06 popover: Cosmetics 2021-02-13 20:26:54 -05:00
Timm Bäder
0d5957b97a nativedialog: Remove unused run state 2021-02-12 08:39:40 +01:00
Matthias Clasen
9f10f9a595 Merge branch 'fix-network-places' into 'master' 
placesview: Avoid use-after-free

See merge request GNOME/gtk!3186
 2021-02-11 19:41:10 +00:00
Matthias Clasen
560e27a3f4 Merge branch 'wip/jimmac/tiled-shadow-fix-fix-gtk4' into 'master' 
Adwaita: bring borders for tiled

Closes #3661

See merge request GNOME/gtk!3184
 2021-02-11 17:04:47 +00:00
Emmanuele Bassi
a63a2b26cf Ensure we don't overflow when using g_memdup2() 
When we turn integers into size_t we should check we're not going to
make a mess.
 2021-02-11 14:22:23 +00:00
Emmanuele Bassi
78e3908a00 gtk: Move from g_memdup() to g_memdup2() 
The g_memdup() function is replaced by a safer version in newer versions
of GLib.
 2021-02-11 14:22:22 +00:00
Jakub Steiner
f953dfef11 Adwaita: bring borders for tiled 
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3661
 2021-02-11 15:16:57 +01:00
Matthias Clasen
95d48ac2e8 placesview: Avoid use-after-free 
The places view has questionable code for handling
'destroy', which seems to trigger use-after-free in
some cases. Clean this up a bit by acknowledging the
cancellation fully, rather than relying on the
destroyed flag.
 2021-02-11 09:14:34 -05:00
Matthias Clasen
e823fa6665 Merge branch 'fix-filter-value' into 'master' 
css: Avoid an invalid read

See merge request GNOME/gtk!3181
 2021-02-11 00:51:40 +00:00
Christian Hergert
c90ffc7363 snapshot: fix warning when asserts are disabled 2021-02-10 16:13:38 -08:00
Matthias Clasen
3eb4ec89f3 css: Avoid an invalid read 
This was broken in ea7185bdb1.

Pointed out by Christian Hergert.
 2021-02-10 19:13:36 -05:00
Jakub Steiner
da64856f37 Adwaita: don't cast shadows for halt-tiled windows 
- while the case of a single half tiled window casting shadow is valid,
  the main use case for half tiled windows is when they have a neighbor.
  The :backdrop should be enough of a focus indicator and we avoid shadow
  casting on neighbors that are on the same Z level.
 2021-02-09 18:57:31 +01:00
Christian Hergert
461fe36707 adwaita: disable shadows when window is maximized or fullscreen 
These shadows cause a significant draw performance drop for maximized
windows. Disabling them increases the chances we can have faster scroll
performance of text.

There is some risk here for systems where they have a dock and you expect
the shadow to draw beneath that dock for transparency reasons.
 2021-02-09 09:27:22 -08:00
Alexander Mikhaylenko
cf61d96188 headerbar: Null-check boxes when removing window controls 
Prevent a crash when show-title-buttons value changes to FALSE during
destruction.
 2021-02-08 18:46:35 +05:00
Alexander Mikhaylenko
319755662f headerbar: Don't use gtk_widget_unparent() with GtkBox 
gtk_widget_unparent() is for widget implementations, it's not supposed to
be used from outside.
 2021-02-08 18:46:27 +05:00
Matthias Clasen
15697d5c0c Merge branch 'focus' into 'master' 
listbox: Fix handling of non-focusable rows

Closes #3633

See merge request GNOME/gtk!3152
 2021-02-07 15:57:11 +00:00
Matthias Clasen
5f48764ac8 cssfiltervalue: Reject invalid filters 
The Filter Effects Spec doesn't allow negative values
for most of the filter parameters.
 2021-02-06 16:16:44 -05:00
Matthias Clasen
cc6fcbfc09 cssfiltervalue: Fix blur filter interpretation 
According to https://www.w3.org/TR/filter-effects-1/,
the length passed to blur() is the standard deviation,
and according to https://www.w3.org/TR/css-backgrounds-3/#shadow-blur
the blur radius is twice the standard deviation.
 2021-02-06 16:16:44 -05:00
Matthias Clasen
ea7185bdb1 cssfiltervalue: Implement drop-shadows 
We have all the pieces, so this is surprisingly easy.
 2021-02-06 16:16:43 -05:00
Matthias Clasen
429dfcf483 cssshadowvalue: Add a 'filter mode' 
Shadow values created by gtk_css_shadow_value_new_filter or
gtk_css_shadow_value_parse_filter interpret their radius value
as standard deviation. Add a flag for this mode, and use it
where necessary.
 2021-02-06 16:10:34 -05:00
Matthias Clasen
be3f352b59 cssshadowvalue: Add a parsing function 
Add a variant of the parse function that parses
just a single (non-box) shadow, as required for
the drop-shadow filter.
 2021-02-06 16:10:32 -05:00
Matthias Clasen
5b8896f1db cssshadowvalue: Add gtk_css_shadow_value_pop_snapshot 
This is the counterpart ot gtk_css_shadow_value_push_snapshot.

To make this easy, move the determination whether we need a
shadow out of the push function and save it.
 2021-02-06 16:09:21 -05:00
Matthias Clasen
4e27de7df9 cssshadowvalue: Drop the underscore 
Rename _gtk_css_shadow_value_parse to drop the underscore.
It was the only underscore-prefixed function in this file.
 2021-02-06 16:08:19 -05:00
Matthias Clasen
9770872d12 css: Implement the drop-shadow filter 
We have all the pieces, so this is surprisingly easy.
 2021-02-05 21:37:14 -05:00
Matthias Clasen
de24b4f91b cssshadowvalue: Add a parsing function 
Add a variant of the parse function that parses
just a single (non-box) shadow, as required for
the drop-shadow filter.
 2021-02-05 21:36:22 -05:00
Emmanuele Bassi
958005317b Merge branch 'master' into 'master' 
Improve the docs of GtkWidget and GtkGrid

See merge request GNOME/gtk!2946
 2021-02-05 12:14:26 +00:00
Matthias Clasen
482b73c376 Merge branch 'matthiasc/for-master' into 'master' 
docs: Rewrite the long description for GtkDialog

Closes #3646

See merge request GNOME/gtk!3156
 2021-02-05 00:10:47 +00:00
Maximiliano Sandoval R
3e2e6633b0
gtkshow: Fix doc typo 2021-02-04 21:02:22 +01:00
Matthias Clasen
4724f9907c docs: Rewrite the long description for GtkDialog 
As was pointed out in #3646, some of the content here
was a bit outdated.

Fixes: #3646
 2021-02-04 13:05:28 -05:00
Matthias Clasen
26e84a7b8c Merge branch 'matthiasc/for-master' into 'master' 
More work on css transition tests

See merge request GNOME/gtk!3154
 2021-02-04 13:28:59 +00:00
Matthias Clasen
2f42e1fb89 treemodelfilter: Drop unreachable code 
We never get here. The compiler says so.

Pointed out in https://www.viva64.com/en/b/0793/
 2021-02-04 00:40:14 -05:00
Matthias Clasen
b5200bd076 css: Drop a bit of unreachable code 
We never get here. The compiler says so.

Pointed out in https://www.viva64.com/en/b/0793/
 2021-02-04 00:39:34 -05:00
Matthias Clasen
aa5bd38137 a11y: Avoid out-of-bounds access 
Don't use the index before we've checked its good.

Pointed out in https://www.viva64.com/en/b/0793/
 2021-02-04 00:34:05 -05:00
Matthias Clasen
1e0ea21297 messagedialog: Don't initialize twice 
We don't need to set these fields more than once.

Pointed out in https://www.viva64.com/en/b/0793/
 2021-02-04 00:25:36 -05:00
Matthias Clasen
e91e75173d composetable: Remove a redundant check 
We already know seq_index is not NULL here.

Pointed out in https://www.viva64.com/en/b/0793/
 2021-02-04 00:22:52 -05:00
Matthias Clasen
041f410838 textbtree: Avoid line vs char count confusion 
The post_insert_fixup helper function was confused about
its argument order.

Pointed out in https://www.viva64.com/en/b/0793/
 2021-02-04 00:17:55 -05:00
Matthias Clasen
c71c8919fe listbase: Don't specify the same thing twice 
We only need to set EXPLICIT_NOTIFY once.

Pointed out in https://www.viva64.com/en/b/0793/
 2021-02-04 00:13:53 -05:00
Matthias Clasen
3f28399f7d css: Fix border value parsing 
This function was not resetting computed as it meant
to because the last loop was never executed.

Pointed out in https://www.viva64.com/en/b/0793/
 2021-02-04 00:12:51 -05:00
Matthias Clasen
1af72eac21 cssvalue: Cosmetic change 
Don't return FALSE from pointer-returning functions.
 2021-02-03 22:10:13 -05:00
Matthias Clasen
a14a0c6315 css: Fix shadow value equal 
This function was not doing the right thing.

Once we are doing the right thing and not compare
shadows as unequal, some reftests that inhibit
snapshots for a few frames now hang forever, since
we are no more redrawing unnecessarily. Fix that
with an explicit queue_draw.
 2021-02-03 22:10:13 -05:00
Matthias Clasen
38481680e1 Merge branch 'wip/jimmac/colored-list-image-buttons' into 'master' 
Adwaita: allow suggested and destructive action buttons in lists

Closes #3643

See merge request GNOME/gtk!3153
 2021-02-04 01:38:47 +00:00
Jakub Steiner
289bf078bf Adwaita: allow suggested and destructive action buttons in lists 
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3643
 2021-02-03 23:15:30 +01:00
Elias Projahn
a7ae94c06e listbox: Fix handling of non-focusable rows 
This commit modifies the gtk_list_box_row_grab_focus() implementation to
correctly return FALSE in case the row couldn't be focused. This behavior will
also be honored by gtk_list_box_row_focus() to properly handle focus in that
case. To achieve that, the method has been restructured slightly.

Closes #3633
 2021-02-03 21:22:55 +01:00
Emmanuele Bassi
592b33cb48 Graphene is a dependency of Gsk, not Gdk 
So let's put it in the right place when building the introspection data.
 2021-02-03 14:05:27 +00:00
Matthias Clasen
919c08d4fd css: Allow transitioning different-size shadows 
The code handles it just fine. The length check was
an erronous addition.
 2021-02-02 15:27:42 -05:00
Matthias Clasen
949c783187 composetable: Parse hex escapes too 
This was a small omission from the Compose file
syntax that doesn't cost us much to support.

Add a test for this syntax too.

Fixes: #1004
 2021-02-02 12:05:19 -05:00
Matthias Clasen
676f875bf6 composetable: Support string values in the cache 
Change the cache format to include the character
data that we need to hold string values in the table.
 2021-02-02 11:55:00 -05:00
Matthias Clasen
140c5c5333 composetable: Don't use GSlice for big blobs 
This just doesn't make sense. This will use malloc
anyway, so just call malloc directly.
 2021-02-02 11:55:00 -05:00
Matthias Clasen
cebf2b2009 composetable: Keep multi-char values 
Keep string values in the table, and return them
from the check function. This commit temporarily
disables the table caching, since the cache format
does not handle string values yet.

Fixes: #186
 2021-02-02 11:54:53 -05:00
Matthias Clasen
773ae0cd0f composetable: Parse multi-char values 
Rewrite the value parsing function to accept strings
that hold more than a single Unicode character.
 2021-02-02 09:03:53 -05:00
Matthias Clasen
564793d5b5 composetable: Another step towards multi-char values 
Change the parser data structures to hold a string, rather
than a gunichar. We still only put a single Unicode character
into it, currently.
 2021-02-02 09:02:46 -05:00
Matthias Clasen
9142aa0f51 composetable: Prepare for multi character values 
Make it possible for gtk_compose_table_check to return
a string instead of just a single Unicode character.
Currently, we only ever return strings holding a single
character, still.
 2021-02-02 09:02:00 -05:00
Matthias Clasen
af9a578d68 imcontext: Prepare for multi-char values 
Reshuffle things so we can easily handle values
that are strings instead of just single Unicode
characters.
 2021-02-01 23:43:59 -05:00
Matthias Clasen
ef053ebb4a composetable: Fix algorithmic matching 
The code wasn't paying attention to (lack of) nul-termination
in one place, causing it to not match when it should.
 2021-02-01 21:51:51 -05:00
Matthias Clasen
10fcdd88e3 imcontext: Code cleanup 
Get rid of auxiliary check_table function.
 2021-02-01 20:41:45 -05:00
Matthias Clasen
5d9509c51b imcontext: Move code around 
Move all the checking code to gtkcomposetable.c, and
add api that we can use in tests.
 2021-02-01 20:27:38 -05:00
Matthias Clasen
aa9054a5f1 imcontext: Use gtk_compose_table_check 
Use the just-introduced api.
 2021-02-01 19:41:07 -05:00
Matthias Clasen
9ebf3fac73 composetable: Add api to check tables 
This copies the check_table code from gtkimcontextsimple.c,
in order to have an api for tests.
 2021-02-01 19:40:22 -05:00
Matthias Clasen
be35c46ce9 composetable: Drop table debug code 
This is better off in the tests that we are going to add.
 2021-02-01 19:02:21 -05:00
Matthias Clasen
dbbcb13721 composetable: Parser fixes 
We were not handling octal escapes right.
 2021-02-01 16:05:05 -05:00
Matthias Clasen
edeaf9c040 imcontext: Drop GTK_MAX_COMPOSE_LEN 
Drop GTK_MAX_COMPOSE_LEN from docs. It is no longer
used by GTK at all.  We leave the define in place
for now, to avoid breaking 3rd party code that might
use it.
 2021-02-01 12:31:23 -05:00
Matthias Clasen
61f709811c composetable: Warn when ignoring things 
We should at least give a hint that we've seen the line,
otherwise people will wonder why nothing happened.
 2021-02-01 12:27:41 -05:00
Matthias Clasen
f7c4375509 composetable: parse long sequences 
Allow compose sequences of up to 20 code points.

Fixes: #3521
 2021-02-01 12:27:35 -05:00
Matthias Clasen
52fb900ced composetable: Fix an off-by-one 
Fix an off-by-one in the code parsing octal escapes
in compose files.
 2021-02-01 12:10:05 -05:00
Matthias Clasen
031944ad30 imcontext: Stop using GTK_MAX_COMPOSE_LEN 
Allocate the compose_buffer, and resize it when needed
to match the tables we use.
 2021-02-01 12:10:05 -05:00
Matthias Clasen
bf8b974f68 imcontext: Code cleanup 
Use g_clear_pointer instead of opencoding it in
multiple places.
 2021-02-01 12:10:05 -05:00
Matthias Clasen
3d85d53e5d Merge branch 'matthiasc/for-master' into 'master' 
Matthiasc/for master

Closes #2319

See merge request GNOME/gtk!3140
 2021-02-01 06:20:40 +00:00
Matthias Clasen
094a346539 imcontext: Allow sequences of length GTK_MAX_COMPOSE_LEN 
There was an off-by-one error, making us reject sequences
of this length. But the rest of the code handles them
just fine.

Fixes: #2319
 2021-02-01 00:55:25 -05:00
Matthias Clasen
162814f969 imcontext: Improve an error message 
This error message was misleading, as pointed out
by Ralf Jung.
 2021-02-01 00:44:41 -05:00
Matthias Clasen
e39b5c99f1 imcontext: Add a precondition check 2021-02-01 00:43:44 -05:00
Matthias Clasen
8883243aaa imcontext: Show preedit for compose sequences 
Show the sequences as they are entered, using ⎄ for
the compose key, to match what IBus does nowadays.
Also handle backspace to allow corrections.
 2021-02-01 00:37:43 -05:00
Matthias Clasen
89511eecf1 imcontext: Update our check for dead keys 
A bunch of keysyms for dead keys have been added since this
code was last touched. Update the check to cover the full
range from dead_grave to dead_greek.
 2021-01-31 23:56:24 -05:00
Matthias Clasen
2c304ca80d Merge branch 'matthiasc/for-master' into 'master' 
Matthiasc/for master

See merge request GNOME/gtk!3139
 2021-02-01 01:48:47 +00:00
Matthias Clasen
bf4102e664 Merge branch 'wip/exalm/consumes-motion' into 'master' 
Drag fixes and cleanups

Closes #3513

See merge request GNOME/gtk!3001
 2021-02-01 01:34:45 +00:00
Matthias Clasen
7985d277b3 nativedialog: Add more docs 
Emphasize that native dialogs aren't widgets, and are not
kept alive by GTK.
 2021-01-31 20:25:44 -05:00
Matthias Clasen
de4b8d547b Merge branch 'wip/exalm/activate' into 'master' 
listitemwidget: Activate on release instead of press

Closes #3345

See merge request GNOME/gtk!3008
 2021-02-01 00:32:05 +00:00