Commit Graph

7974 Commits

Author SHA1 Message Date
Matthias Clasen
f393e85f59 2.13.2
svn path=/trunk/; revision=20309
2008-06-03 23:44:33 +00:00
Federico Mena Quintero
cf62c83b0e bnc355225 - File chooser crash in Tab completion
2008-06-03  Federico Mena Quintero  <federico@novell.com>

	* gtk/gtkfilechooserentry.c (install_completion_feedback_timer):
	If the user presses Tab while the completion feedback window is
	active, then we'll assert.  Remove the assertion and just re-set
	the timer.  Fixes https://bugzilla.novell.com/show_bug.cgi?id=355225

Signed-off-by: Federico Mena Quintero <federico@novell.com>

svn path=/trunk/; revision=20305
2008-06-03 18:08:48 +00:00
Colin Walters
8ade45013c Bug 535303 – add _get_implementation to GtkStatusIcon
2008-06-03  Colin Walters  <walters@redhat.com>
	
	Bug 535303 – add _get_implementation to GtkStatusIcon

	* gtk/gtkstatusicon.c (gtk_status_icon_get_x11_window_id): New
	function to retrieve internal X11 window ID, useful for libnotify.
	* gtk/gtkstatusicon.h: Prototype it.
	* docs/reference/gtk/gtk-sections.txt: Add to docs.
	* gtk/gtk.symbols: Export it.


svn path=/trunk/; revision=20304
2008-06-03 17:39:20 +00:00
Tor Lillqvist
727a9145f6 Use g_open().
2008-06-03  Tor Lillqvist  <tml@novell.com>

	* gtk/updateiconcache.c (build_cache): Use g_open().


svn path=/trunk/; revision=20303
2008-06-03 11:04:33 +00:00
Michael Natterer
54d9b40015 gtk/gtkclist.h revert includes to how they have been before the
2008-06-03  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkclist.h
	* gtk/gtkctree.h: revert includes to how they have been before the
	GTK_DISABLE_SINGLE_INCLUDES changes. Apparently I missed the fact
	that you can't include <gtk/gtk.h> from two headers where one is a
	parent class of the other and expect them both to be includable
	individually.


svn path=/trunk/; revision=20302
2008-06-03 08:38:59 +00:00
Michael Natterer
af55cea3ef remove newline at beginning of file.
2008-06-03  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkprinteroptionset.h: remove newline at beginning of file.


svn path=/trunk/; revision=20301
2008-06-03 08:17:06 +00:00
Matthias Clasen
16a43727fa Bug 536092 – GtkEntryCompletion's popup window should set type hint
* gtk/gtkentrycompletion.c (gtk_entry_completion_init): Set
        a type hint on the popup window to help compiz.
        Patch by Vaclav Slavik.


svn path=/trunk/; revision=20294
2008-06-03 02:48:37 +00:00
Claudio Saavedra
9d000c0fd8 Bug 535862 – gtk_action_create_icon can't create icons from the icon
2008-06-02  Claudio Saavedra  <csaavedra@igalia.com>

	Bug 535862 – gtk_action_create_icon can't create icons from the
	icon themes

	* gtk/gtkaction.c: (gtk_action_create_icon): Look for the icon in
	the default factories as it's supposed.


svn path=/trunk/; revision=20290
2008-06-03 00:31:10 +00:00
Yevgen Muntyan
cb823b805a Bug 535497 - Print preview doesn't work.
2008-06-02  Yevgen Muntyan  <muntyan@tamu.edu>

        Bug 535497 - Print preview doesn't work.

        * gtk/Makefile.am: GTK_PRINT_PREVIEW_COMMAND on quartz: use open
        instead of launching Preview.app directly.


svn path=/trunk/; revision=20289
2008-06-02 23:20:13 +00:00
Michael Natterer
570668f4cc put back #include <gtk/gtkmarshal.h>, it's not in <gtk/gtk.h>. Fixes stuff
2008-06-02  Michael Natterer  <mitch@imendio.com>

	* gtk/gtksignal.h: put back #include <gtk/gtkmarshal.h>, it's not
	in <gtk/gtk.h>. Fixes stuff that uses deprecated cruft.
	(bug #536126).


svn path=/trunk/; revision=20269
2008-06-02 15:07:35 +00:00
Emmanuele Bassi
c515ec92e8 Bug 535830 – wrong content type adding an item
2008-05-31  Emmanuele Bassi  <ebassi@gnome.org>

	Bug 535830 – wrong content type adding an item

	* gtk/gtkrecentmanager.c:
	(gtk_recent_manager_add_item_query_info): Use the correct API
	for retrieving the fast MIME type of a URI. (Carlos Garcia
	Campos)

svn path=/trunk/; revision=20262
2008-05-31 18:52:50 +00:00
Kristian Rietveld
f1405056f2 Bug 530146 - Setting non-string tooltip with
2008-05-31  Kristian Rietveld  <kris@imendio.com>

	Bug 530146 - Setting non-string tooltip with
	gtk_tree_view_set_tooltip_column() segfaults

	* gtk/gtktreeview.c (gtk_tree_view_set_tooltip_query_cb): use
	gtk_tree_model_get_value() and explicitly transform the value to a
	string before setting it as tooltip.


svn path=/trunk/; revision=20261
2008-05-30 22:59:13 +00:00
Michael Natterer
bd2b0d30a8 cast attach_info_free() to GDestroyNotify when using it in
2008-05-30  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkmenu.c (get_attach_info): cast attach_info_free() to
	GDestroyNotify when using it in g_object_set_data_full().


svn path=/trunk/; revision=20257
2008-05-30 12:12:19 +00:00
Michael Natterer
24d2f90ac3 gtk/gtkmountoperation.h gtk/gtkshow.h gtk/gtktestutils.h no need to allow
2008-05-30  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkmountoperation.h
	* gtk/gtkshow.h
	* gtk/gtktestutils.h
	* gtk/gtktoolshell.h: no need to allow disabling single includes
	conditionally in these new files. Simply forbid including them
	individually from the beginning.


svn path=/trunk/; revision=20255
2008-05-30 12:02:19 +00:00
Matthias Clasen
49a42ac0f0 2.13.1
svn path=/trunk/; revision=20246
2008-05-30 05:08:50 +00:00
Matthias Clasen
3a4ac605a8 Fix Since tags
svn path=/trunk/; revision=20244
2008-05-30 02:46:49 +00:00
Tor Lillqvist
776c50947e Bug 535526 - updateiconcache.c: using open/close without prototype
2008-05-29  Tor Lillqvist  <tml@novell.com>

	Bug 535526 - updateiconcache.c: using open/close without prototype

	* gtk/updateiconcache.c: Include <io.h> if _MSC_VER. Also, use
	g_utime() instead of utime() for UTF-8 pathname support on Windows
	when available.


svn path=/trunk/; revision=20238
2008-05-29 18:22:38 +00:00
Jan Arne Petersen
0fb31a06bb Bug 56355 – GtkLabel - Not all changes propagate correctly
2008-05-29  Jan Arne Petersen  <jpetersen@jpetersen.org>

	Bug 56355 – GtkLabel - Not all changes propagate correctly

	* gtk/gtklabel.c: (gtk_label_recalculate), (gtk_label_set_label),
	(gtk_label_set_markup_with_mnemonic), (gtk_label_parse_uline),
	(gtk_label_set_text_with_mnemonic), (gtk_label_set_use_underline):
	Call gtk_label_setup_mnemonic from gtk_label_recalculate. Add
	notifications of mnemonic-keyval changes.


svn path=/trunk/; revision=20237
2008-05-29 18:09:01 +00:00
Matthias Clasen
ee8253f908 Bug 522084 – GIcon support for GtkIconTheme & GtkImage
2008-05-27  Matthias Clasen  <mclasen@redhat.com>

        Bug 522084 – GIcon support for GtkIconTheme & GtkImage

        * gtk/gtkicontheme.[hc]: Add support for GIcon based lookups.
        * gtk/gtkimage.[hc]: Allow setting an image from a GIcon.
        * gtk/gtk.symbols: Additions
        * tests/testimage.c: Add a GIcon test


svn path=/trunk/; revision=20236
2008-05-29 14:33:49 +00:00
Michael Natterer
c8e67f3cc6 gtk/Makefile.am add a single-include header for the unix print stuff.
2008-05-29  Michael Natterer  <mitch@imendio.org>

	* gtk/Makefile.am
	* gtk/gtkunixprint.h: add a single-include header for the unix
	print stuff.

	* gtk/gtkpagesetupunixdialog.h
	* gtk/gtkprinter.h
	* gtk/gtkprintjob.h
	* gtk/gtkprintunixdialog.h: add single-include guards that #error
	out if GTK_DISABLE_SINGLE_INCLUDES is defined and any of these
	files is included individually.

	* gtk/gtkprintbackend.h
	* gtk/gtkprinter-private.h
	* modules/printbackends/cups/gtkprintbackendcups.c
	* modules/printbackends/cups/gtkprintercups.h
	* modules/printbackends/lpr/gtkprintbackendlpr.c
	* tests/buildertest.c
	* tests/defaultvaluetest.c
	* docs/tools/widgets.c: include <gtk/gtkunixprint.h> instead of
	individual files.


svn path=/trunk/; revision=20230
2008-05-29 09:34:53 +00:00
Michael Natterer
2c5f8a5c2b whitespace cleanup: remove trailing whitespace and excess newlines and
2008-05-28  Michael Natterer  <mitch@imendio.com>

	* gtk/gtk*.h: whitespace cleanup: remove trailing whitespace and
	excess newlines and sprinkled some newlines where needed. Zero
	code or formatting changes included.


svn path=/trunk/; revision=20225
2008-05-28 15:35:43 +00:00
Michael Natterer
0bf59ed22e fix formatting of details_acquired() signal.
2008-05-28  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkprinter.h: fix formatting of details_acquired() signal.


svn path=/trunk/; revision=20224
2008-05-28 15:25:36 +00:00
Michael Natterer
9172d33782 fix comment: the widget is called GtkColorButton, not
2008-05-28  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkcolorbutton.h: fix comment: the widget is called
	GtkColorButton, not GtkColorSelectButton. Remove trailing
	whitespace and excess newlines.


svn path=/trunk/; revision=20223
2008-05-28 15:20:05 +00:00
Michael Natterer
eff99c282c define __GTK_H_INSIDE__ around including all other headers.
2008-05-28  Michael Natterer  <mitch@imendio.com>

	* gtk/gtk.h: define __GTK_H_INSIDE__ around including all other
	headers.

	* gtk/gtktypebuiltins.h.template
	* gtk/gtkversion.h.in
	* gtk/gtk*.h: add single-include guards that #error out if
	GTK_DISABLE_SINGLE_INCLUDES is defined and any of these files is
	included individually.

	* gtk/gtkprintbackend.h
	* gtk/gtkprinter-private.h
	* gtk/gtktextlayout.h
	* gtk/gtktexttagprivate.h
	* gtk/gtktexttypes.h
	* gtk/gtktreedatalist.h: include <gtk/gtk.h> instead of individual
	headers in these private or semi-private headers.

	* gtk/gtkimmodule.h: also here because it's not in gtk.h.

	* gtk/gtkpagesetupunixdialog.h
	* gtk/gtkprinter.h
	* gtk/gtkprintjob.h
	* gtk/gtkprintunixdialog.h: likewise in the gtkunixprint headers.

	* gtk/gtkclist.h
	* gtk/gtkcombo.h
	* gtk/gtkctree.h
	* gtk/gtkfilesel.h
	* gtk/gtkitemfactory.h
	* gtk/gtklist.h
	* gtk/gtklistitem.h
	* gtk/gtkoldeditable.h
	* gtk/gtkoptionmenu.h
	* gtk/gtkpixmap.h
	* gtk/gtkpreview.h
	* gtk/gtksignal.h
	* gtk/gtktipsquery.h: whenever possible, include only <gtk/gtk.h>
	instead of individual headers in these deprecated headers. They
	don't get included at all when GTK_DISABLE_DEPRECATED is defined,
	so if an app needs them anyway, it must undef GTK_DISABLE_DEPRECATED
	and include them individually, which should continue to work.

	* gtk/gtkclist.c: include "gtkctree.h" because of the change
	above.


svn path=/trunk/; revision=20221
2008-05-28 15:07:04 +00:00
Kristian Rietveld
e7df0579c2 Bug 449625 - crash in gtk_tree_view_real_move_cursor at gtktreeview.c:9641
2008-05-28  Kristian Rietveld  <kris@imendio.com>

	Bug 449625 - crash in gtk_tree_view_real_move_cursor at
	gtktreeview.c:9641

	* gtk/gtktreeview.c (gtk_tree_view_move_cursor_page_up_down):
	cursor_offset *must* be larger than background height of the cursor
	node, not just equal otherwise there is no guarantee there is a next
	node.


svn path=/trunk/; revision=20219
2008-05-28 14:47:50 +00:00
Michael Natterer
53366c1c0e don't include <gdk/gdktestutils.h>.
2008-05-28  Michael Natterer  <mitch@imendio.com>

	* gtk/gtktestutils.c: don't include <gdk/gdktestutils.h>.


svn path=/trunk/; revision=20218
2008-05-28 14:47:06 +00:00
Kristian Rietveld
382ce2f138 Bug 504087 - make gtk_tooltip_set_custom a no-op for setting the current
2008-05-28  Kristian Rietveld  <kris@imendio.com>

	Bug 504087 - make gtk_tooltip_set_custom a no-op for setting the
	current widget again.

	* gtk/gtktooltip.c (gtk_tooltip_set_custom),
	(gtk_tooltip_reset), (gtk_tooltip_run_requery): use a
	custom_was_reset field to check if the custom widget is set again in
	the query-tooltip callback; if not, we set it to NULL.  Based on a
	patch by Xavier Claessens, insightful comments from Jean-Yves Lefort
	and Christian Persch.


svn path=/trunk/; revision=20215
2008-05-28 14:00:31 +00:00
Kristian Rietveld
45f0ad8cf5 Bug 498010 - gtk_tree_view_set_cursor fails if model!=NULL.
2008-05-28  Kristian Rietveld  <kris@imendio.com>

	Bug 498010 - gtk_tree_view_set_cursor fails if model!=NULL.

	* gtk/gtktreeview.c (gtk_tree_view_set_cursor_on_cell): return if fail
	->priv->tree != NULL.  Suggestion from Stefan Kost.


svn path=/trunk/; revision=20208
2008-05-28 12:20:38 +00:00
Kristian Rietveld
3ed120ebf8 Bug 324282 - add selected signal to cell renderer combo.
2006-05-28  Kristian Rietveld  <kris@imendio.com>

	Bug 324282 - add selected signal to cell renderer combo.

	* gtk/gtkcellrenderercombo.c (gtk_cell_renderer_combo_class_init),
	(gtk_cell_renderer_combo_changed),
	(gtk_cell_renderer_combo_start_editing): add a new "changed" signal
	that will be emitted as soon as the combo box emitted changed and has
	an active iterator.  (Modified patch based on work by James
	Pelletier).

	* gtk/gtkmarshalers.list: add marshaler.


svn path=/trunk/; revision=20206
2008-05-28 11:49:20 +00:00
Kristian Rietveld
1fa5cda0a9 Refactor expand/collapse timeout handling (amendment to bug 511217).
2008-05-28  Kristian Rietveld  <kris@imendio.com>

	Refactor expand/collapse timeout handling (amendment to bug 511217).

	* gtk/gtktreeview.c (add_expand_collapse_timeout),
	(remove_expand_collapse_timeout): new functions, the remove function
	also clears expanded_collapsed_node,
	(cancel_arrow_animation): moved to be next to the add/remove timeout
	functions,
	(gtk_tree_view_unrealize),
	(gtk_tree_view_row_deleted),
	(gtk_tree_view_set_model),
	(cancel_arrow_animation),
	(gtk_tree_view_real_expand_row),
	(gtk_tree_view_real_collapse_row): use the new add/remove functions.


svn path=/trunk/; revision=20205
2008-05-28 09:26:13 +00:00
Kristian Rietveld
e72827b2cd Amendment of bug 485218 - Strange warning encountered.
2008-05-28  Kristian Rietveld  <kris@imendio.com>

	Amendment of bug 485218 - Strange warning encountered.

	* gtk/gtktreemodelsort.[ch]
	(gtk_tree_model_sort_convert_child_iter_to_iter): return a boolean
	indication whether or not the conversion had succeeded.


svn path=/trunk/; revision=20204
2008-05-28 09:02:29 +00:00
Matthias Clasen
81320ba90b Bug 404571 – Scroll arrow backgrounds should be painted with different
detail

        * gtk/gtkmenu.c (gtk_menu_paint): Use "menu_scroll_arrow_up/down"
        as detail when drawing scroll arrow backgrounds. Proposed by
        Tommi Komulainen.


svn path=/trunk/; revision=20202
2008-05-28 01:30:37 +00:00
Matthias Clasen
6c993cf8d2 Bug 511217 - potential memory corruption after refreshing a tree_view
* gtk/gtktreeview.c (cancel_arrow_animation): Reset
        expanded_collapsed_node when canceling the animation.
        Patch by Nicholas Setton.


svn path=/trunk/; revision=20201
2008-05-28 00:33:49 +00:00
Matthias Clasen
ea9c6f301d Bug 485218 - Strange warning encountered
* gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_inserted):
        (gtk_tree_model_sort_convert_child_iter_to_iter):
        (gtk_tree_model_sort_build_level): Better warnings. Patch
        by Kristian Rietveld.


svn path=/trunk/; revision=20198
2008-05-27 23:16:06 +00:00
Matthias Clasen
2855f81636 Fixes
svn path=/trunk/; revision=20197
2008-05-27 23:02:02 +00:00
Matthias Clasen
8d5e58b632 106574 - Inconsistent increment behavior for gtkspinbutton
* gtk/gtkspinbutton.c (gtk_spin_button_real_value_change):
        Commit the entry text before doing an increment. Patch by
        Björn Lindqvist.


svn path=/trunk/; revision=20196
2008-05-27 22:50:49 +00:00
Federico Mena Quintero
4b1bba8af1 bgo533891 - disallow DnD from the file list into itself
2008-05-27  Federico Mena Quintero  <federico@novell.com>

	http://bugzilla.gnome.org/show_bug.cgi?id=533891 - Don't allow
	drag and drop from the file list into itself, as it doesn't make
	sense (it would just change the current folder).

	* gtk/gtkfilechooserdefault.c (file_list_dest_targets): Use
	GTK_TARGET_OTHER_WIDGET so we don't DnD from the file list into
	itself.

Signed-off-by: Federico Mena Quintero <federico@novell.com>

svn path=/trunk/; revision=20194
2008-05-27 20:33:23 +00:00
Michael Natterer
a4f8d6ccff move deprecated guards around everything, including includes and include
2008-05-27  Michael Natterer  <mitch@imendio.com>

	* gtk/gtksignal.h: move deprecated guards around everything,
	including includes and include guards (just as in all other
	deprecated files).


svn path=/trunk/; revision=20191
2008-05-27 15:07:26 +00:00
Tor Lillqvist
ff89f9050d Use simpler mode for open() on Windows. (No S_I?GRP and S_I?OTH bits are
2008-05-27  Tor Lillqvist  <tml@novell.com>

	* gtk/updateiconcache.c (build_cache): Use simpler mode for open()
	on Windows. (No S_I?GRP and S_I?OTH bits are defined in
	<sys/stat.h> on Windows, and the mode used in open() doesn't
	matter much as there are no rwxrwxrwx bits on Windows anyway.)
	Open file in binary mode. Passing "b" to fdopen() later isn't
	enough.


svn path=/trunk/; revision=20190
2008-05-27 13:03:49 +00:00
10:33:41 Tim Janik
727a7dbf46 guard gtk_widget_get_snapshot() against invalid or invisible widgets.
2008-05-27 10:33:41  Tim Janik  <timj@imendio.com>

        * gtk/gtkwidget.c: guard gtk_widget_get_snapshot() against
        invalid or invisible widgets.


svn path=/trunk/; revision=20187
2008-05-27 08:35:24 +00:00
Matthias Clasen
3f26314d0f Bug 531008 – Crash in gtkprintunixdialog.c
* gtk/gtkprintunixdialog.c: Disconnect signal handlers when
        the dialog closes. Patch by Yevgen Muntyan.


svn path=/trunk/; revision=20186
2008-05-27 04:48:31 +00:00
Carlos Garnacho
cdaca42be3 Enable rubberbanding when "select-multiple" is TRUE. Bug #446068.
2008-05-27  Carlos Garnacho  <carlos@imendio.com>

        * gtk/gtkfilechooserdefault.c (set_select_multiple): Enable
        rubberbanding when "select-multiple" is TRUE. Bug #446068.

svn path=/trunk/; revision=20184
2008-05-27 00:20:18 +00:00
Carlos Garnacho
5d224f01e6 Enable correctly dialog buttons sensitivity when the anonymous option is
2008-05-27  Carlos Garnacho  <carlos@imendio.com>

        * gtk/gtkmountoperation.c (gtk_mount_operation_ask_password): Enable
        correctly dialog buttons sensitivity when the anonymous option is
        enabled by default. Bug #531865.

svn path=/trunk/; revision=20183
2008-05-27 00:12:33 +00:00
Carlos Garnacho
416bda1204 Set password dialog modal and transient for the parent window also if it
2008-05-27  Carlos Garnacho  <carlos@imendio.com>

        * gtk/gtkmountoperation.c (gtk_mount_operation_ask_password): Set
        password dialog modal and transient for the parent window also if it
        was specified in the constructor. Bug #531864.

svn path=/trunk/; revision=20182
2008-05-27 00:08:00 +00:00
Michael Natterer
49bd7edac0 fix indentation.
2008-05-26  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkimmodule.h: fix indentation.


svn path=/trunk/; revision=20177
2008-05-26 13:07:38 +00:00
Michael Natterer
27dbd9a425 include "gdk/gdk.h" instead of "gdk/gdkscreen.h"
2008-05-26  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkshow.h: include "gdk/gdk.h" instead of "gdk/gdkscreen.h"

	* gtk/gtkshow.c: remove inclusion of single files from gdk/

	Removed trailing whitespace in both files.


svn path=/trunk/; revision=20176
2008-05-26 09:51:48 +00:00
Richard Hult
6fb474f223 Bug 530353 – Mac-like gtk_accelerator_get_label()
2008-05-26  Richard Hult  <richard@imendio.com>

	Bug 530353 – Mac-like gtk_accelerator_get_label()

	* gtk/gtkaccellabel.c: (gtk_accel_label_class_init),
	(append_keyval_symbol), (_gtk_accel_label_class_get_accelerator_label):
	On quartz, make gtk_accelerator_get_label() format a Mac-like
	string, using unicode characters for modifier keys, arrows, delete
	etc. Patch from Yevgen Muntyan.

svn path=/trunk/; revision=20175
2008-05-26 08:54:00 +00:00
Richard Hult
8ae8e8e307 Bug 534869 – Length miscalculation in
2008-05-26  Richard Hult  <richard@imendio.com>

	Bug 534869 – Length miscalculation in
	_gtk_quartz_get_selection_data_from_pasteboard

	* gtk/gtkquartz.c: (_gtk_quartz_get_selection_data_from_pasteboard):
	Get the number of bytes, not the number of characters, patch from
	Yevgen Muntyan.

svn path=/trunk/; revision=20174
2008-05-26 07:40:17 +00:00
Matthias Clasen
e19eee548f Some doc formatting fixes.
svn path=/trunk/; revision=20172
2008-05-26 05:38:20 +00:00
Matthias Clasen
f7f1dabdf9 Bug 511163 – Remove pango_extents_to_pixels() calls
* gtk/gtkcellrenderertext.c (get_size): Use
        pango_layout_get_pixel_extents.

        * configure.in: Bump Pango requirement to 1.20

        * INSTALL.in: Update required versions


svn path=/trunk/; revision=20171
2008-05-26 04:33:25 +00:00