AuroraMiddleware/gtk2
1
0
Fork 0
forked from AuroraMiddleware/gtk
Code Issues Pull Requests Projects Releases Wiki Activity
07167fdf22
gtk2/gdk
History
Carlos Garnacho 07167fdf22 surface: Always set PHASE_PAINT as pending when updates are scheduled 
At times (most often when closing subsurfaces that are scheduling
relayouts) the PHASE_PAINT handling gets broken with the following
sequence:

1. Surface receives wl_callback.done for the previous frame.
   Surface is thawed.
2. A new update on the surface is scheduled. PHASE_PAINT is
   requested directly on the frame clock. priv->pending_phase is
   left unset in the surface.
3. Surface gets frozen
4. Frame clock processes the update scheduled at 2. The surface
   is frozen, so paint is prevented. PHASE_PAINT is considered
   handled.
5. Compositor emits wl_callback.done again. Surface is thawed.
6. At this point the machinery is off
   - The surface didn't paint but has pending update regions
   - priv->draw_needed is set in the toplevel and other portions
     of the widget tree
   - So queueing redraws is ineffective at eventually calling
     gdk_surface_schedule_update() again on the toplevel surface.
   - We don't paint anymore, so this broken state is not flushed
     until other subsurface changes manage to schedule the missing
     update.

To fix this, always set PHASE_PAINT in priv->pending_phase when
doing gdk_surface_schedule_update(). If the frame clock turns
around before the surface is thawed, it will still be waiting to
be processed the next iteration.

Fixes: https://gitlab.gnome.org/GNOME/gtk/-/issues/3750
2021-04-07 23:06:06 +02:00
..
broadway broadway: Restore guint32 type for memory size 2021-02-27 23:43:12 +01:00
macos gdkmacosglcontext: fix compilation error 2021-03-24 10:08:11 +00:00
resources/glsl
wayland wayland: Improve font setting fallback 2021-04-07 08:50:14 -04:00
win32 GDK-Win32: Remove extraneous call to _gdk_win32_append_event() 2021-03-17 11:22:23 +08:00
x11 x11/dnd: Ignore XErrors from the COW 2021-03-22 15:38:58 +01:00
COPYING
default_cursor.png
filetransferportal.c
filetransferportalprivate.h
gdk-autocleanup.h
gdk-private.h Add compatibility shim for g_memdup2() 2021-02-11 12:57:38 +00:00
gdk.c docs: Move detached sections into their own content file 2021-03-11 16:37:30 +00:00
gdk.h gdk/toplevel: Negotiate surface size via a compute-size signal 2020-08-05 15:49:00 +02:00
gdkapplaunchcontext.c applaunchcontext: Add property annotations 2021-03-11 16:37:32 +00:00
gdkapplaunchcontext.h Replace "gint" with "int" 2020-07-25 00:47:36 +02:00
gdkapplaunchcontextprivate.h Replace "gint" with "int" 2020-07-25 00:47:36 +02:00
gdkarrayimpl.c gdkarray: Add a "stolen" boolean to splice() 2020-12-24 06:38:45 +01:00
gdkcairo.c gdk: Some more tweaks of the docs 2021-03-11 16:37:31 +00:00
gdkcairo.h Drop gdk_cairo_surface_upload_to_gl() helper 2020-09-25 15:00:07 +02:00
gdkcairocontext.c docs: Rework the gdk docs 2021-03-11 16:37:31 +00:00
gdkcairocontext.h
gdkcairocontextprivate.h
gdkcairoprivate.h gdkcairoprivate: Fix header guard 2020-08-29 11:11:29 +02:00
gdkclipboard.c clipboard: Add property annotations 2021-03-11 16:37:32 +00:00
gdkclipboard.h
gdkclipboardprivate.h
gdkconfig.h.meson macos: prototype new GDK backend for macOS 2020-07-21 14:45:12 -07:00
gdkconfig.h.win32
gdkconfig.h.win32_vulkan
gdkconstructor.h
gdkcontentdeserializer.c docs: Rework the gdk docs 2021-03-11 16:37:31 +00:00
gdkcontentdeserializer.h docs: Rework the gdk docs 2021-03-11 16:37:31 +00:00
gdkcontentformats.c docs: Rework the gdk docs 2021-03-11 16:37:31 +00:00
gdkcontentformats.h
gdkcontentformatsprivate.h
gdkcontentprovider.c contentprovider: Add property annotations 2021-03-11 16:37:32 +00:00
gdkcontentprovider.h docs: Rework the gdk docs 2021-03-11 16:37:31 +00:00
gdkcontentproviderimpl.c clipboard: Fix a crash when GdkContentProviderUnion doesn't support the given data format 2021-03-25 15:10:00 +01:00
gdkcontentproviderimpl.h
gdkcontentproviderprivate.h
gdkcontentserializer.c Plug a small memory leak 2021-03-27 19:11:56 -04:00
gdkcontentserializer.h docs: Rework the gdk docs 2021-03-11 16:37:31 +00:00
gdkcursor.c cursor: Use a table for cursor names 2021-03-11 16:37:35 +00:00
gdkcursor.h Cosmetics 2020-10-29 07:40:30 -04:00
gdkcursorprivate.h
gdkdebug.h gdk: Slim down gdkinternals.h more 2020-08-14 07:45:53 -04:00
gdkdevice.c gdk: Add an arg check to gdk_device_get_timestamp 2021-03-26 11:09:50 -04:00
gdkdevice.h gdk: Add gdk_device_get_timestamp 2021-03-26 10:30:33 -04:00
gdkdevicepad.c gdk: Some more tweaks of the docs 2021-03-11 16:37:31 +00:00
gdkdevicepad.h Replace "gint" with "int" 2020-07-25 00:47:36 +02:00
gdkdevicepadprivate.h Replace "gint" with "int" 2020-07-25 00:47:36 +02:00
gdkdeviceprivate.h gdk: Add gdk_device_get_timestamp 2021-03-26 10:30:33 -04:00
gdkdevicetool.c devicetool: Add property annotations 2021-03-11 16:37:32 +00:00
gdkdevicetool.h docs: Rework the gdk docs 2021-03-11 16:37:31 +00:00
gdkdevicetoolprivate.h
gdkdisplay.c display: Add property annotations 2021-03-11 16:37:32 +00:00
gdkdisplay.h gdk: Move default group api to the X11 backend 2020-07-29 22:58:37 -04:00
gdkdisplaymanager.c displaymanager: Add property annotations 2021-03-11 16:37:32 +00:00
gdkdisplaymanager.h Replace "gchar" with "char" 2020-07-25 00:47:36 +02:00
gdkdisplaymanagerprivate.h
gdkdisplayprivate.h gdk: Drop some unused private api 2020-10-07 21:02:22 -04:00
gdkdrag.c drag: Add property annotations 2021-03-11 16:37:32 +00:00
gdkdrag.h docs: Rework the gdk docs 2021-03-11 16:37:31 +00:00
gdkdragprivate.h Replace "gint" with "int" 2020-07-25 00:47:36 +02:00
gdkdragsurface.c docs: Rework the gdk docs 2021-03-11 16:37:31 +00:00
gdkdragsurface.h
gdkdragsurfaceprivate.h
gdkdrawcontext.c drawcontext: Add property annotations 2021-03-11 16:37:32 +00:00
gdkdrawcontext.h
gdkdrawcontextprivate.h
gdkdrop.c dnd: Add some warnings to the docs 2021-03-16 14:48:44 -04:00
gdkdrop.h
gdkdropprivate.h
gdkenumtypes.c.template types: fix various use of volatile in type registration 2020-11-18 20:21:33 -08:00
gdkenumtypes.h.template
gdkevents.c gdk: Add gdk_device_get_timestamp 2021-03-26 11:09:05 -04:00
gdkevents.h docs: Fix value annotation 2021-03-11 16:37:31 +00:00
gdkeventsprivate.h main: Add & use gdk_event_dup_axes() 2020-12-21 10:26:02 +01:00
gdkframeclock.c docs: Rework the gdk docs 2021-03-11 16:37:31 +00:00
gdkframeclock.h docs: Rework the gdk docs 2021-03-11 16:37:31 +00:00
gdkframeclockidle.c gdk/frame-clock: Remove the newly added 'compute-size' phase 2020-12-07 09:46:39 +01:00
gdkframeclockidleprivate.h
gdkframeclockprivate.h gdk/frame-clock: Remove the newly added 'compute-size' phase 2020-12-07 09:46:39 +01:00
gdkframetimings.c docs: Rework the gdk docs 2021-03-11 16:37:31 +00:00
gdkframetimings.h
gdkgl.c gdk: Some more tweaks of the docs 2021-03-11 16:37:31 +00:00
gdkglcontext.c glcontext: Add property annotations 2021-03-11 16:37:32 +00:00
gdkglcontext.h
gdkglcontextprivate.h gl: remove unused texture_from_surface API 2020-10-29 08:26:27 -07:00
gdkglobals.c gdk: Remove an unused variable 2020-10-01 19:33:43 -04:00
gdkgltexture.c docs: Rework the gdk docs 2021-03-11 16:37:31 +00:00
gdkgltexture.h docs: Rework the gdk docs 2021-03-11 16:37:31 +00:00
gdkgltextureprivate.h
gdkinternals.h gdk: Slim down gdkinternals.h more 2020-08-14 07:45:53 -04:00
gdkintl.h
gdkkeynames.c Replace "gchar" with "char" 2020-07-25 00:47:36 +02:00
gdkkeys.c gdk: Some more tweaks of the docs 2021-03-11 16:37:31 +00:00
gdkkeys.h Replace "gchar" with "char" 2020-07-25 00:47:36 +02:00
gdkkeysprivate.h Replace "gint" with "int" 2020-07-25 00:47:36 +02:00
gdkkeysyms-update.pl
gdkkeysyms.h gdk: Update gdkkeysyms.h 2020-07-21 16:55:28 -04:00
gdkkeyuni.c gdk: Some more tweaks of the docs 2021-03-11 16:37:31 +00:00
gdkmarshalers.list
gdkmemorytexture.c docs: Rework the gdk docs 2021-03-11 16:37:31 +00:00
gdkmemorytexture.h docs: Rework the gdk docs 2021-03-11 16:37:31 +00:00
gdkmemorytextureprivate.h gl backend: Avoid roundtripping via surface when updloading 2020-09-25 10:04:48 +02:00
gdkmonitor.c monitor: Add property annotations 2021-03-11 16:37:32 +00:00
gdkmonitor.h gdk/monitor: Remove gdk_monitor_work_area and GdkMonitor::work-area 2020-07-29 17:57:30 +02:00
gdkmonitorprivate.h gdk/monitor: Remove gdk_monitor_work_area and GdkMonitor::work-area 2020-07-29 17:57:30 +02:00
gdkpaintable.c docs: Rework the gdk docs 2021-03-11 16:37:31 +00:00
gdkpaintable.h docs: Rework the gdk docs 2021-03-11 16:37:31 +00:00
gdkpango.c gdk: Some more tweaks of the docs 2021-03-11 16:37:31 +00:00
gdkpango.h Replace "gint" with "int" 2020-07-25 00:47:36 +02:00
gdkpipeiostream.c Replace "gint" with "int" 2020-07-25 00:47:36 +02:00
gdkpipeiostreamprivate.h
gdkpixbuf-drawable.c gdk: Some more tweaks of the docs 2021-03-11 16:37:31 +00:00
gdkpixbuf.h Replace "gint" with "int" 2020-07-25 00:47:36 +02:00
gdkpopup.c popup: Add property annotations 2021-03-11 16:37:32 +00:00
gdkpopup.h docs: Rework the gdk docs 2021-03-11 16:37:31 +00:00
gdkpopuplayout.c docs: Fix typos 2021-03-11 16:37:31 +00:00
gdkpopuplayout.h docs: Remove duplicate documentation stanzas 2021-03-11 16:37:31 +00:00
gdkpopupprivate.h
gdkprofiler.c Port tracing to the sysprof collector api 2020-08-21 10:55:01 -04:00
gdkprofilerprivate.h profiler: allow using gdk profiler functions without braces 2021-02-08 11:29:32 -08:00
gdkrectangle.c docs: Rework the gdk docs 2021-03-11 16:37:31 +00:00
gdkrectangle.h
gdkrgba.c docs: Rework the gdk docs 2021-03-11 16:37:31 +00:00
gdkrgba.h Replace "gchar" with "char" 2020-07-25 00:47:36 +02:00
gdkrgbaprivate.h
gdkseat.c seat: Add property annotations 2021-03-11 16:37:32 +00:00
gdkseat.h gdkseat: Make gdk_seat_get_tools() public 2020-10-08 16:22:05 +02:00
gdkseatdefault.c seatdefault: use g_clear_pointer to unref the tools 2021-01-08 13:11:56 +01:00
gdkseatdefaultprivate.h Rename master and slave device 2020-06-18 19:22:20 +01:00
gdkseatprivate.h seat: improve api to take into account the tool type 2021-01-07 12:50:48 +01:00
gdksnapshot.c docs: Rework the gdk docs 2021-03-11 16:37:31 +00:00
gdksnapshot.h docs: Rework the gdk docs 2021-03-11 16:37:31 +00:00
gdksnapshotprivate.h
gdksurface.c surface: Always set PHASE_PAINT as pending when updates are scheduled 2021-04-07 23:06:06 +02:00
gdksurface.h gdk: Always get shadow width via GdkToplevelSize 2020-12-07 09:46:39 +01:00
gdksurfaceprivate.h surface: Remove unused gdk_surface_get_unscaled_size() 2021-03-15 02:56:28 +01:00
gdktexture.c texture: Add property annotations 2021-03-11 16:37:32 +00:00
gdktexture.h
gdktextureprivate.h texture: Unvirtualize download_surface 2020-09-25 09:31:43 +02:00
gdktoplevel.c toplevel: Add property annotations 2021-03-11 16:37:32 +00:00
gdktoplevel.h docs: Rework the gdk docs 2021-03-11 16:37:31 +00:00
gdktoplevellayout.c docs: Fix typos 2021-03-11 16:37:31 +00:00
gdktoplevellayout.h docs: Remove duplicate documentation stanzas 2021-03-11 16:37:31 +00:00
gdktoplevelprivate.h gdk/toplevel: Make gdk_toplevel_present() async 2020-12-07 09:46:39 +01:00
gdktoplevelsize.c docs: Fix typos 2021-03-11 16:37:31 +00:00
gdktoplevelsize.h docs: Remove duplicate documentation stanzas 2021-03-11 16:37:31 +00:00
gdktoplevelsizeprivate.h gdk/toplevelsize: Rename 'margin' to 'shadow' and 'shadow_width' 2020-12-07 20:37:29 +01:00
gdktypes.h gdk: Some more tweaks of the docs 2021-03-11 16:37:31 +00:00
gdkversionmacros.h.in Add version macros for 4.2 2021-01-18 23:10:18 -05:00
gdkvulkancontext.c docs: Rework the gdk docs 2021-03-11 16:37:31 +00:00
gdkvulkancontext.h
gdkvulkancontextprivate.h
gen-gdk-gresources-xml.py
gen-keyname-table.pl
keyname-table.h
keynames-translate.txt
keynames.txt
meson.build build: Use a consistent style for Meson files 2020-12-15 12:46:59 +00:00