AuroraMiddleware/harfbuzz
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
11,652 Commits 1 Branch 0 Tags 55 MiB
be50779cda
Commit Graph

11652 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Garret Rieger
be50779cda [subset] correct ClassDef format determination. 
It was possible for glyph_min to be a glyph mapped to class zero which threw off the number of glyph calculation.
 2021-04-30 14:46:57 -06:00
Khaled Hosny
90713f270e [hb-ot-layout] Document some return values 2021-04-30 14:05:33 -06:00
Behdad Esfahbod
46362a954c
Merge pull request #2958 from googlefonts/layout_by_default_gr 
[subset] Enable layout subsetting by default.
 2021-04-30 11:39:47 -06:00
Behdad Esfahbod
42bf8e3d49 [util] Disable chafa's truecolor mode 
See https://github.com/harfbuzz/harfbuzz/pull/2959#issuecomment-827056111
 2021-04-26 12:31:44 -06:00
Khaled Hosny
c571a96eb0 [ci] Disable Chafa on jobs that enables all auto features 
No suitable versions are available on these setups.
 2021-04-26 12:13:10 -06:00
Hans Petter Jansson
8298c2f93b [hb-view] Use Chafa for terminal graphics if available 
This produces high-quality terminal graphics using symbols or sixels
according to the detected terminal capabilities.

Fixes #2430.
 2021-04-26 12:13:10 -06:00
Garret Rieger
e25efb31f2 [subset] consider all value formats when computing effective format. 2021-04-23 19:09:37 -07:00
Qunxin Liu
84dbfacfec [subset] fix collect_variation_idx in PairPosFormat2 2021-04-23 18:52:24 -07:00
Garret Rieger
d356d0f79c [subset] optimize ValueRecord's for PairPosFormat1. 2021-04-23 18:50:34 -07:00
Garret Rieger
f9fbe4817e [subset] implement value record optimization for PairPosFormat2. 2021-04-23 18:50:34 -07:00
Garret Rieger
badb8e409b [subset] use copy_values for PairPos serialize. 2021-04-23 18:50:33 -07:00
Garret Rieger
2f50283cd3 [subset] Begin implementing ValueRecord optimization: 
remove value records which have a zero value.
 2021-04-23 18:50:33 -07:00
Garret Rieger
5df7c668ba [subset] In SinglePosFormat1 serialize only 1 value record. 
Previously one record per glyph in the subset was serialized.
 2021-04-23 18:50:33 -07:00
Garret Rieger
92757f6809 [subset] Don't drop anchor device tables when dropping hints. These may contain variation data. 
Update subseting expected files to match latest version of fontTools.
 2021-04-23 18:50:33 -07:00
Garret Rieger
6fddc2bbf9 [subset] subset layout tables (G*) by default. 2021-04-22 15:08:49 -07:00
Garret Rieger
425ba1f4ab [subset] fixes infinite loop in hb_set_get_max(). 
Fixes https://oss-fuzz.com/testcase-detail/5363902507515904
 2021-04-20 13:18:07 -06:00
Garret Rieger
ec4321068b [subset] fix infinite loop caused by alloc failure in repacker. 
Fixes: https://oss-fuzz.com/testcase-detail/5609112151916544.
 2021-04-20 13:18:07 -06:00
Garret Rieger
0e845d973e [subset] fix memory leak in repacker caused by failed alloc. 
Fixes: https://oss-fuzz.com/testcase-detail/5616763250278400.
 2021-04-20 13:18:07 -06:00
Garret Rieger
3fb62cdc14 [subset] fail on offset overflow in tables that we don't repack. 
Fixes: https://oss-fuzz.com/testcase-detail/5229304507138048
 2021-04-19 17:01:05 -06:00
Behdad Esfahbod
19e096aa97
Merge pull request #2067 from harfbuzz/null-size 
Avoid undefined-behavior, another try
 2021-04-16 14:35:04 -06:00
Behdad Esfahbod
ed2ee8a8c2 Revert "Disable -Wunused-macros under GCC" 
This reverts commit 1b1413246b.

Err. It wasn't working. We already have that disabled in the files it
is warning about. Doesn't work.
 2021-04-16 13:53:43 -06:00
Behdad Esfahbod
47cbf8f2c4 [test] Silence more compiler warnings 2021-04-16 13:32:02 -06:00
Behdad Esfahbod
1b1413246b Disable -Wunused-macros under GCC 
Since the pragram in hb-ot-shape-complex-indic-table.cc didn't seem to
silence GCC, eg:

../../src/hb-ot-shape-complex-indic-table.cc:55: warning: macro "ISC_TL" is not used [-Wunused-macros]
   55 | #define ISC_TL   INDIC_SYLLABIC_CATEGORY_TONE_LETTER                 /*    7 chars; Tone_Letter */

disable it at compiler level.
 2021-04-16 13:32:02 -06:00
Behdad Esfahbod
23a28f5ad0 Avoid undefined-behavior 
If a struct had (because it's a union) sizeof that is larger than the null_size,
we were providing only null_size bytes for its Null object. We know we'd never
access beyond that, but is undefined-behavior nonetheless according to the
standard.

The alternative fix would have required use of flexible-arrays, which are not
standard and have their own issues in various compiler. We've discussed that
extensively in the follow Mozilla issue (currently locked; I've asked that it
be opened):

  https://bugzilla.mozilla.org/show_bug.cgi?id=1577584

Part of
https://github.com/harfbuzz/harfbuzz/pull/2067
 2021-04-16 13:23:25 -06:00
Behdad Esfahbod
499248c533 [blob] Use min_size, instead of null_size in .as<T>() 
Part of https://github.com/harfbuzz/harfbuzz/pull/2067
 2021-04-16 13:14:48 -06:00
Khaled Hosny
a4fb5da984 [ci] Enable DirectWrite in win32 tarballs 2021-04-16 09:38:44 -06:00
Khaled Hosny
f2240d12c2 [ci] Use -j2 for make and ninja in distcheck job 
Lets see if this makes it faster without crashing gcc.
 2021-04-15 18:47:51 -06:00
Khaled Hosny
f5c922b709 [ci] Try to stop distcheck job from crashing gcc 2021-04-15 18:47:51 -06:00
Khaled Hosny
e116058bba [directwrite] Use correct UTF-16 string length 
Fixes https://github.com/harfbuzz/harfbuzz/issues/2474
 2021-04-15 09:30:40 -06:00
Ben Denckla
668acff1f0 similarly improve comments on Hebrew ccc 18 & 19 
Should have committed this along with commit 9658435a25c2ba82 but forgot.
 2021-04-13 11:01:22 -06:00
Ben Denckla
43d955207b improve comments on Hebrew ccc 18 & 19 
improve comments to reflect that:
ccc 18 includes both "flavors" of qamats: qamats [gadol] and qamats qatan
ccc 19 includes both "flavors" of holam: holam [not haser for vav] and holam haser for vav
This code and its comments may have been written before these code points were added to Unicode.
I.e. originally, these comments may have been complete, but they may have become incomplete in the meantime.
 2021-04-13 11:01:22 -06:00
Ambient Lighter
4cc4cd3b24
[docs] Fix spelling typo (#2945) 2021-04-10 14:11:23 +03:00
Qunxin Liu
9dc9f0385d [subset] fix for fuzzer testcase: https://oss-fuzz.com/testcase-detail/5858518134554624 2021-04-09 11:07:28 -06:00
Qunxin Liu
430a67ceab [subset] COLRv1 struct definitions 2021-04-08 11:27:01 -06:00
Qunxin Liu
553ffaf682 [subset] fix for fuzzer testcase: https://oss-fuzz.com/testcase-detail/6382598554255360 
avoid writing to null pointer
 2021-04-08 09:54:48 -06:00
Qunxin Liu
4af5dacedc [subset] add fuzzer testcase 2021-04-07 13:02:04 -06:00
Garret Rieger
8b686afeb5 [subset] add unlikely(). 2021-04-06 12:34:44 -06:00
Garret Rieger
64122b5a44 [subset] don't visit lookup if covered glyph set has failed. 
If covered glyph set is in error then the same lookup can be recursed into repeatedly potentially causing a fuzzer timeout. Fixes: https://oss-fuzz.com/testcase-detail/5416421032067072.
 2021-04-06 12:34:44 -06:00
Garret Rieger
4ec18c85e6 [subset] add subsetting tests with drop hints and layout subsetting enabled. 2021-04-06 11:50:44 -06:00
Garret Rieger
6f98a8ed46 [subset] Anchor should only use format 1 when hints are dropped. 
Refactor Anchor to have a subset method instead of copy. This also allows
use to use serialize_subset in several places which simplifies calculating
offset bases.
 2021-04-06 11:50:44 -06:00
Garret Rieger
71d6d15600 [subset] clamp distance to prevent shifting outside of the limits of int64. 
Fixes https://oss-fuzz.com/testcase-detail/4961171477233664.
 2021-04-06 11:48:39 -06:00
Khaled Hosny
fcacd17748 [ot] Update _hb_glyph_info_is_default_ignorable_and_not_hidden() 
Used _hb_glyph_info_substituted() similar to the change made to
_hb_glyph_info_is_default_ignorable() in
7686ff854b.
 2021-04-06 11:47:06 -06:00
Garret Rieger
596f4258d0 [subset] copy Lookup::markFilteringSet when subseting. 2021-04-02 15:33:52 -06:00
Behdad Esfahbod
d3a2f999e4 Fix up build 
This was left out; oops.
 2021-04-02 08:33:03 -06:00
Garret Rieger
c35d786397 [subset] never drop the 'pref' feature. 
Never ever drop feature 'pref', even if it's empty. Harfbuzz uses it to choose the shaper for Khmer.
 2021-04-01 16:27:35 -06:00
Behdad Esfahbod
092094f705 Use as_array() and range loops in a few places 2021-04-01 16:02:54 -06:00
Garret Rieger
55e7f3fe32 [subset] Match FeatureVariationRecord dropping from fontTools. 
Only drop records with no matching features that are at the end of the list. See: cab7d13dc0
 2021-04-01 15:26:02 -06:00
Garret Rieger
f0c78e0282 [subset] don't drop features referenced in a feature variation substitution. 2021-04-01 15:26:02 -06:00
Garret Rieger
dae99b7769 [subset] don't keep FeatureVariationRecord's with no subsittutions. 2021-04-01 15:26:02 -06:00
Garret Rieger
85b0728783 Add full variable font subsetting test. 2021-04-01 15:26:02 -06:00