Commit Graph

3811 Commits

Author SHA1 Message Date
Thomas Van Lenten
17d601a2b6 More explicit tests for nil behaviors on fields.
Code already works, but make a bank of tests that call it out so things are
very clean in the future just to be safe.
2016-08-12 11:46:55 -04:00
Thomas Van Lenten
91b6d04e2d Merge pull request #1942 from thomasvl/objc_fix_oneof_zeros
Objc fix oneof zeros and more oneof zero conformance tests
2016-08-11 16:20:49 -04:00
Thomas Van Lenten
27c8962505 Add more types to the zero oneof cases.
Incase the different runtimes have different generation/implementations for
for the different primitive field types, cover a larger range of the proto
types in the oneof zero tests.
2016-08-11 13:15:01 -04:00
Thomas Van Lenten
ca5b7751e5 Record zero for "has" for proto3 if in a oneof.
If a message is proto3, then the zero values still count as being set one the
field is in a oneof.

Add tests to confirm oneofs work as expected in both syntaxes.
2016-08-11 13:14:15 -04:00
Thomas Van Lenten
ac3df39c22 Add conformance test for zero fields in oneofs. (#1939)
* Add conformance test for zero fields in oneofs.
* Add failures to the "expected" files.
2016-08-11 09:44:07 -04:00
Thomas Van Lenten
30bbbe99e2 Merge pull request #1934 from thomasvl/objc_strings_with_null
Never use strlen on utf8 runs so null characters work.
2016-08-09 12:32:56 -04:00
Thomas Van Lenten
1a6c1d092d Never use strlen on utf8 runs so null characters work.
Fixes https://github.com/google/protobuf/issues/1933

Add a new test that forces strings into two different implementations from the
NSString class cluster to help confirm we're exercising both paths by which
CodedOutputStream will extract data from an NSString.

Move the old +load test (that was flawed because the behavior really depends on
the type of string from the NSString class cluster); into a unittest that
targets the specific case we're adding a behavior confirmation on.

As a bonus, improve the TextFormat generation of string characters < 0x20.
2016-08-09 10:37:16 -04:00
Sergio Campamá
237f321e33 Adds support for appledoc in generated code. (#1928)
Convert mapping of proto comments to appledoc format so they show up in Xcode and cocoadocs.

Fixes https://github.com/google/protobuf/issues/1866
2016-08-09 08:26:24 -04:00
Feng Xiao
56b8f44eed Merge pull request #1842 from udnaan/master
fixed cmake config files install path
2016-08-08 13:43:45 -07:00
Sergio Campamá
32fadc0d49 Migrating documentation of the ObjectiveC runtime code to appledoc. (#1867)
Work for #1866 

Migrates all the public class docs over to appledoc format.  While Xcode is fine with blank lines in `///` comments, appledoc (used by cocoadocs) isn't and was leaving a bunch of info off the doc pages.

The generator still needs to be updated to do this also; that will be a follow up CL.
2016-08-08 10:15:02 -04:00
Feng Xiao
1102a8a767 Merge pull request #1923 from bryongloden/patch-1
close opened file descriptors properly
2016-08-05 15:28:42 -07:00
Bryon Gloden, CISSP®
a375e1acfd close opened file descriptors properly 2016-08-05 17:30:19 -04:00
Jisi Liu
e30b7b4461 Merge pull request #1924 from PiotrSikora/export_license
Bazel: export LICENSE file.
2016-08-05 14:02:42 -07:00
Feng Xiao
f1f30b53cc Merge pull request #1926 from hotpxl/master
[master] Add dependency cl. Fixes google/protobuf#295.
2016-08-05 10:45:28 -07:00
Yutian Li
ddf6d1eb75 [master] Add dependency cl. Fixes google/protobuf#295. 2016-08-05 15:13:12 +08:00
Piotr Sikora
faea19c359 Bazel: export LICENSE file.
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
2016-08-04 15:32:14 -07:00
Feng Xiao
c59473d53e Merge pull request #1044 from mark-whiting/master
Adding missing generic gcc 64-bit atomicops.
2016-08-04 11:21:40 -07:00
Thomas Van Lenten
6d134eac6f Merge pull request #1898 from sergiocampama/watchos
Adds watch os deployment target for protobuf
2016-08-04 10:06:47 -04:00
Feng Xiao
0dca3cc5d6 Merge pull request #1865 from podsvirov/topic-cmake-project
CMake: Improvements and Bugfixes
2016-08-03 11:03:15 -07:00
Feng Xiao
dedd8aec0d Merge pull request #1914 from adamatan/typo-fix
Typo: beffer -> buffer
2016-08-03 10:35:27 -07:00
Adam Matan
3886860aa4 Typo: beffer -> buffer 2016-08-03 14:59:18 +03:00
Konstantin Podsvirov
eefd1fdd48 CMake: Auto find ZLIB from package config if nedded 2016-08-02 22:37:36 +03:00
Joshua Haberman
8d8115bf52 Merge pull request #1878 from haberman/rubywkt
Ruby: added API support for well-known types.
2016-08-01 17:31:00 -07:00
Feng Xiao
e0779d5a64 Merge pull request #1903 from xfxyjwf/compatibility_tests
Use 64-bit protoc binaries in compatibility tests.
2016-08-01 15:16:16 -07:00
Josh Haberman
3cec2ea8d6 Ruby: added custom Struct exception type and fixed Makefile.am. 2016-08-01 14:34:54 -07:00
Feng Xiao
30647cae9f Use 64-bit protoc binaries in compatibility tests.
Turns out travis doesn't have the library dependencies to run a 32-bit
binary.

Change-Id: I5fadbcade2eb71c1e9ce21d90fa9459797df0e81
2016-08-01 13:49:15 -07:00
Feng Xiao
ff46627725 Merge pull request #1902 from podsvirov/topic-cmake-extract-includes
CMake: remove repeated_field_reflection.h from extract list
2016-08-01 11:03:10 -07:00
Konstantin Podsvirov
7d275ec168 CMake: remove repeated_field_reflection.h from extract list 2016-08-01 20:54:41 +03:00
Jon Skeet
00d5a7f099 Amend the conformance tests to only use Int64/Uint64 non-wrapped values which (#1164)
can reasonably be expected to be interoperable.

(The fact that not all Int64/Uint64 values *can* be exactly represented in
IEEE-754 and thus interoperably amongst JSON implementations is precisely the
reason for wrapping them when we serialize... it shouldn't be a surprise that
we can't round-trip in unwrapped form for all values.)
2016-07-31 11:40:51 +01:00
Sergio Campama
275db044b2 Adds watch os deployment target for protobuf 2016-07-29 20:08:27 -07:00
Joshua Haberman
6b3d120539 Merge pull request #1887 from sheffatguidance/fix-js-api-documentation
Fix Issue #1869: faulty js API documentation
2016-07-29 16:52:01 -07:00
Joshua Haberman
1112989a1b Merge pull request #1884 from hochhaus/valueWriterFn
Fix valueWriterFn_ variable name
2016-07-29 16:09:53 -07:00
Jisi Liu
915d79efa8 Merge pull request #1895 from google/3.0.0-GA
Merge GA branch for makedist fix.
2016-07-29 14:49:13 -07:00
Jisi Liu
3ef07568cd Merge pull request #1894 from pherl/fixdist
Add python/setup.cfg into dist files
2016-07-29 14:43:52 -07:00
Jisi Liu
e139117108 Add python/setup.cfg into dist files 2016-07-29 14:40:05 -07:00
Jisi Liu
169d0ca43c Merge pull request #1893 from google/3.0.0-GA
Merge 3.0.0-GA into master
2016-07-29 14:27:53 -07:00
Jisi Liu
c4790429fc Merge pull request #1892 from xfxyjwf/compatibility_tests
Run Java compatibility tests on Travis.
2016-07-29 14:24:42 -07:00
Feng Xiao
baa4023cd5 Run Java compatibility tests on Travis.
The test is testing the binary/source compatibility between 3.0.0-beta-4
and the current version (right now it's 3.0.0).

Change-Id: Ic410b535758b38cee7baa99a15a0433734df44e6
2016-07-29 14:11:21 -07:00
Jisi Liu
f3449e5f57 Merge pull request #1891 from pherl/python
add setup.cfg for building wheels
2016-07-29 14:04:26 -07:00
Jisi Liu
811674f479 add setup.cfg for building wheels 2016-07-29 14:02:07 -07:00
Feng Xiao
42e54876be Merge pull request #1882 from legrosbuffle/fix-check
Be consistent with the use of CHECK()/ GOOGLE_CHECK().
2016-07-29 12:26:24 -07:00
Jisi Liu
7e93458bb7 Merge pull request #1888 from pherl/fixbuildzip
Fix the build-zip.sh to add .exe for win packages.
2016-07-29 11:47:47 -07:00
Jisi Liu
6a59ac94e1 Fix the build-zip.sh to add .exe for win packages. 2016-07-29 11:44:05 -07:00
sheffatguidance
9a11ab4f4f Fix Issue #1869: faulty js API documentation 2016-07-29 12:53:59 -05:00
Andy Hochhaus
a2174089b2 Fix valueWriterFn variable name 2016-07-29 09:21:01 -07:00
Clement Courbet
c466f4b539 Be consistent with the use of CHECK()/ GOOGLE_CHECK(). 2016-07-29 16:59:42 +02:00
Josh Haberman
a207a2bd00 Fix for JRuby (assert_true is not present). 2016-07-28 17:54:16 -07:00
Josh Haberman
e3094a8d80 Ruby: added API support for well-known types. 2016-07-28 17:02:33 -07:00
Jisi Liu
de30c56391 Merge pull request #1874 from pherl/buildzip
Change the build.zip.sh to support lite
2016-07-28 14:48:46 -07:00
Jisi Liu
e3fac65add Change the build.zip.sh to support lite 2016-07-28 14:24:05 -07:00