Commit Graph

5166 Commits

Author SHA1 Message Date
Thomas Van Lenten
6700f41c4b Travis config cleanups and move ObjC to Xcode 9.1.
Stop having travis build the test matrix and make it explicit so extra
settings are only on the test that need the, this helps make the travis
UI a little cleaner (linux hosted stuff doesn't list an Xcode version),
as well as avoid unneeded requirements limiting the travis pool something
can run on.

Small improvements to objectivec/DevTools/full_mac_build.sh to avoid some
repeated scripting and hopefully make things more reliable work with Xcode
9.x.

Don't mark the iOS tests as able to fail, hopefully with the new settings
they are stable and won't give false signals.

Simplify the case for xcode versions and fixup xcode 9.[0-1].
2017-11-16 21:46:46 -05:00
dmaclach
2b3aa1c294 Add Setter/Getter type verification. (#3880)
Add runtime asserts (that can be disabled in release) that verify
that the types being get/set for messages using the C Api match
the type in the descriptor for the field being get/set.
2017-11-16 08:26:46 -05:00
dmaclach
8537f1e6d5 Fix up warnings from Xcode 9.1 (#3887)
Fix up warnings from Xcode 9.1
2017-11-16 08:24:17 -05:00
Issac Trotts
0d466884a2 Update README.md: C extension works on PHP 7 (#3888)
Here's the pull request that made it happen: https://github.com/google/protobuf/pull/2951
2017-11-15 11:08:15 -08:00
Thomas Van Lenten
696653d246
Merge pull request #3892 from sergiocampama/32bit
Fixes 32bit tests.
2017-11-15 13:42:33 -05:00
Feng Xiao
7daa320065
Merge pull request #3878 from Yangqing/master
Allow one to omit building libprotoc and protoc binaries
2017-11-15 10:37:58 -08:00
Sergio Campama
02129f0a87 Fixes 32bit tests. 2017-11-15 13:14:41 -05:00
Thomas Van Lenten
cf685313f1
Merge pull request #3891 from thomasvl/travis_cleanups
Travis cleanups
2017-11-15 12:46:42 -05:00
Thomas Van Lenten
7417755e40
Merge pull request #3883 from dmaclach/map_optimizations
Reduce size of GPBDictionary by getting rid of class creation methods
2017-11-15 11:52:57 -05:00
Dave MacLachlan
8ae6844cf4 codereview cleanup 2017-11-15 08:49:59 -08:00
Thomas Van Lenten
6552c5af3f
Merge pull request #3884 from dmaclach/unsafe
Simplify getter/setter method implementations
2017-11-15 11:45:32 -05:00
Dave MacLachlan
4ba30923fa code review cleanup 2017-11-15 08:41:29 -08:00
Thomas Van Lenten
af5ad24617
Merge pull request #3882 from dmaclach/removeclass2
Remove unreferenced 'GPBMessageSignatureProtocol' class.
2017-11-15 11:02:34 -05:00
Thomas Van Lenten
a839c67dfe Remove the allowed_failure for python_cpp as the bug was fixed. 2017-11-15 10:39:35 -05:00
Thomas Van Lenten
2e17639133 Remove the ruby tests from travis configs.
Looking at tarvis history for master, jruby doesn't look like it has passed
in a really long time.  The other two tests have been failing for a few weeks.
Since travis has limited osx hosts, seems better to just remove things we
aren't expecting to pass.
2017-11-15 10:36:49 -05:00
Thomas Van Lenten
c46571bc17 Update some comments about testing. 2017-11-15 10:31:16 -05:00
Thomas Van Lenten
73e8c8aab9 Instead of listing and then excluding osx builds, just don't list them. 2017-11-15 10:29:14 -05:00
Dave MacLachlan
949596ea32 Simplify getter/setter method implementations
Remove unnecessary retain/releases for GPBFieldDescriptors when
creating implementations with blocks. The descriptors do not need
to be memory managed because they are essentially global constructs
that are guaranteed to be around the lifetime of the app.
2017-11-14 15:58:22 -08:00
Dave MacLachlan
9d7f313372 Reduce size of GPBDictionary by getting rid of class creation methods 2017-11-14 15:37:28 -08:00
Dave MacLachlan
37a6672c31 Remove unreferenced 'GPBMessageSignatureProtocol' class.
Remove unreferenced 'GPBMessageSignatureProtocol' class that is just taking up
space in the Objective C runtime information by hanging the protocol it needs to
declare off of GPBRootObject instead.

Small binary size reduction, but more importantly a removal of a class that
appears to be unused when statically analyzed.
2017-11-14 15:16:04 -08:00
Jon Skeet
91ff83c024 Remove non-C# options from C#-only test protos 2017-11-14 07:31:59 +00:00
Yangqing Jia
cba18efe18 Allow one to omit building libprotoc and protoc binaries 2017-11-13 15:15:39 -08:00
Jisi Liu
d3537c24ff
Merge pull request #3834 from sviterok/patch-1
Fix a typo in WKT's test suite
2017-11-13 14:38:34 -08:00
Jisi Liu
2720cdc568
Update README.md 2017-11-13 12:23:58 -08:00
Feng Xiao
b9f891e3dd
Merge pull request #3875 from hchasestevens/add-hypothesis-protobuf-doc
Add hypothesis-protobuf library to the 3rd party doc.
2017-11-13 10:39:06 -08:00
H. Chase Stevens
3c331432b5 Add hypothesis-protobuf library to the 3rd party doc. 2017-11-13 11:42:41 -05:00
Jon Skeet
8cf53f8dfc MMinor fix-ups to C# tests from changes in earlier commits 2017-11-12 15:29:15 +00:00
Jon Skeet
b5cdf0eac6 Regenerated test code for C# 2017-11-12 15:29:15 +00:00
Jon Skeet
aa77eab622 Move C#-only test protos to csharp/protos
unittest_proto3 had been changed in a very backward-incompatible
way which was never going to work with C# as it imports proto2 messages.

This is now a copy of the old file, but with a package name change for
compatibility with the remaining files in src/google/protobuf.

The other moves are for files that are only used by C#.
2017-11-12 15:29:15 +00:00
Jon Skeet
9a9a66e715 Run C# codegen when testing it
This will cause failures if shared protos change in an incompatible
way.
2017-11-12 15:29:15 +00:00
Jan Tattermusch
ce0a53273a
Merge pull request #3858 from jtattermusch/parsing_from_slice
C#: Allow message parsing from an array slice
2017-11-10 08:57:40 +01:00
Jan Tattermusch
30b6e54327 ParseFrom<T> for array slice is missing 2017-11-09 18:33:15 +01:00
Jan Tattermusch
07542e78da check already performed by MergeFrom 2017-11-09 18:27:45 +01:00
Jan Tattermusch
0c874a6a19 allow message parsing from an array slice 2017-11-09 14:23:14 +01:00
Jisi Liu
c258fb303a
Merge pull request #3822 from mehrdada/update-benchmark-submodule
Update google/benchmark submodule to v1.2
2017-11-06 10:25:42 -08:00
Paul Yang
bcda919cee
Fix php well known type conformance tests (#3828)
* Fix php well known type conformance tests

* Properly generate code for test.proto

* Provide GPBMetadata files in c extensions for generated files to import.

* Remove unnecessary test

* Clean up code

* Add declaration for initOnce.

* Refactoring
2017-11-03 12:30:09 -07:00
Thomas Van Lenten
239dba535c
Merge pull request #3839 from thomasvl/message_equality
When comparing message, require them to have the same descriptor.
2017-11-03 12:54:28 -04:00
Thomas Van Lenten
1f57e540ac When comparing message, require them to have the same descriptor.
This will cover someone subclassing the message, and also handles
something crazy like someone comparing to a raw NSObject.
2017-11-03 12:49:28 -04:00
Roman Nekhoroshev
da3bfa693a
Fix a typo in WKT's test suite
Hi!
Sorry for bothering with such a minor thing, but I just noticed and fixed one annoying typo in WKT's test suite:
`"accpets" -> "accepts"`

Thanks!
2017-11-02 13:47:11 -07:00
Jon Skeet
cbe250591f Fix merging with message-valued oneof
If messages A and B have the same oneof case, which is a message
type, and we merge B into A, those sub-messages should be merged.

Fixes #3200.

Note that I haven't regenerated all the code, as some of the protos
have been changed, breaking generation.
2017-10-31 17:11:40 -07:00
Mehrdad Afshari
bb35f04fe6 Update google/benchmark submodule to v1.2
Fixed some build issues on ppc64le architecture
2017-10-30 12:30:00 -07:00
Feng Xiao
6dd8224393
Merge pull request #3817 from xuwei-k/joda-url
update joda-time javadoc url
2017-10-30 12:12:20 -07:00
xuwei-k
05b56d01c1 update joda-time javadoc url 2017-10-30 17:48:54 +09:00
Jon Skeet
e8c9ae1209 Add parser settings WithXyz methods 2017-10-28 07:47:43 +01:00
Jon Skeet
a985451253 Add JsonParser setting to ignore unknown field values
Note that the default behavior is still to throw an exception; you
need to opt into ignoring unknown fields.

Fixes #2838.
2017-10-28 07:47:43 +01:00
Jisi Liu
4526d8baa0
Merge pull request #3722 from timou/cmake-windows-clean
Suppress VS2017 compiler/linker warnings
2017-10-27 12:37:30 -07:00
Paul Yang
23adfeb003 Reserve unknown in Ruby (#3763)
* Reserve unknown in ruby

* Revert ruby tests. Wait for cpp impl for conformance test

* Add conformance test for preserving unknown

* Add unknown field conformance test to csharp failure list.

* Fix comments

* Fix comment

* Fix comments

* Fix typo

* Use stringsink_string directly

* Mark hd unused

* Remove unused encodeunknown_handlerfunc
2017-10-26 14:41:43 -07:00
Jisi Liu
a08b03d4c0 Add missing files 2017-10-26 13:48:53 -07:00
Jisi Liu
9aaa8e1e55 Merge pull request #3804 from pherl/merge
Merge 3.4.x into master before cutting 3.5.x
2017-10-26 12:20:56 -07:00
Adam Cozzette
2fc7aea360 Merge pull request #3791 from signalwerk/patch-1
To be clear that we set a new variable
2017-10-26 10:10:20 -07:00