AuroraMiddleware/qt5base-lts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

linuxfb: Remove QFbWindow::setVisible

Browse Source 
QFbWindow::setVisible doesn't call into the base class implementation
and thus suppresses the delivery of the expose event. It turns out we
don't need to track the visiblity at all since the base QPA code tracks
this already.

After this change, windows are now render on the framebuffer.

Change-Id: Ifcfc730456883eb423d79479bd0b04330b8c2d72
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
Reviewed-by: Thomas Senyk <thomas.senyk@nokia.com>
Reviewed-by: Girish Ramakrishnan <girish.1.ramakrishnan@nokia.com>
This commit is contained in:
Girish Ramakrishnan 2012-07-09 15:30:45 +05:30 committed by Qt by Nokia
parent 95aa6935a1
commit 27cefd85f3
3 changed files with 2 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/platformsupport/fbconvenience/qfbscreen.cpp
View File

@ -201,7 +201,7 @@ QRegion QFbScreen::doRedraw()
}
for (int layerIndex = layer; layerIndex != -1; layerIndex--) {
if (!mWindowStack[layerIndex]->isVisible())
if (!mWindowStack[layerIndex]->window()->isVisible())
continue;
// if (mWindowStack[layerIndex]->isMinimized())
// continue;

9
src/platformsupport/fbconvenience/qfbwindow.cpp
View File

@ -47,7 +47,7 @@
QT_BEGIN_NAMESPACE
QFbWindow::QFbWindow(QWindow *window)
: QPlatformWindow(window), mBackingStore(0), mVisible(false)
: QPlatformWindow(window), mBackingStore(0)
{
static QAtomicInt winIdGenerator(1);
mWindowId = winIdGenerator.fetchAndAddRelaxed(1);
@ -76,13 +76,6 @@ void QFbWindow::setGeometry(const QRect &rect)
QPlatformWindow::setGeometry(rect);
}
void QFbWindow::setVisible(bool visible)
{
mVisible = visible;
platformScreen()->invalidateRectCache();
platformScreen()->setDirty(geometry());
}
Qt::WindowFlags QFbWindow::setWindowFlags(Qt::WindowFlags flags)
{
mWindowFlags = flags;

4
src/platformsupport/fbconvenience/qfbwindow_p.h
View File

@ -55,9 +55,6 @@ public:
QFbWindow(QWindow *window);
~QFbWindow();
virtual void setVisible(bool visible);
virtual bool isVisible() { return mVisible; }
virtual void raise();
virtual void lower();
@ -80,7 +77,6 @@ protected:
QFbBackingStore *mBackingStore;
QRect mOldGeometry;
bool mVisible;
Qt::WindowFlags mWindowFlags;
WId mWindowId;