Commit Graph

51094 Commits

Author SHA1 Message Date
Edward Welbourne
964f91fd25 Make POSIX transition rule parser more robust
The POSIX rule parser used by QTzTimeZonePrivate recklessly assumed
that, if splitting the rule on a dot produced more than one part, it
necessarily produced at least three. That's true for well-formed POSIX
rules, but we should catch the case of malformed rules.

Likewise, when calculating the dates of transitions, splitting the
date rule on dots might produce too few fragments; and the fragments
might not parse as valid numbers, or might be out of range for their
respective fields in a date. Check all these cases, too.

Added a test that crashed previously. Changed
QTimeZone::offsetFromUtc() so that its "return zero on invalid"
applies also to the case where the backend returns invalid, in
support of this.

Fixes: QTBUG-92808
Pick-to: 6.1 6.1.0 6.0 5.15
Change-Id: Ica383a7a987465483341bdef8dcfd42edb6b43d6
Reviewed-by: Andrei Golubev <andrei.golubev@qt.io>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
2021-04-14 12:57:30 +02:00
Qt CI Bot
b7a3aa39e7 Merge integration refs/builds/qtci/dev/1618388786 2021-04-14 10:52:21 +00:00
Qt CI Bot
38abdd33f1 Merge integration refs/builds/qtci/dev/1618385170 2021-04-14 10:37:33 +00:00
Qt CI Bot
d61dc9a8cd Merge integration refs/builds/qtci/dev/1618381531 2021-04-14 08:43:26 +00:00
Juha Vuolle
ec3e90a9e4 Add CoreMotion to the list of looked-up frameworks (Mac/iOS)
The CoreMotion is required by the QtSensor module.

Task-number: QTBUG-92502
Change-Id: I7f1853131aa96b2cb052862d5bf492df5ec18150
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
2021-04-14 11:16:52 +03:00
Mårten Nordheim
7ddf834b86 QNetworkInformation(Win): cleanup dtor
I don't like how it looks, so make stop() work even if it's not
monitoring so that the dtor can call it unconditionally, and without
needing a CoUninitialize call of its own.

Change-Id: I06832d7e1d34317ff49ea2c425c79588719d7cd0
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2021-04-14 07:51:38 +00:00
Fabian Kosmale
d5b79e876e QBindable: Mark non-modifying methods as const
A few methods in QBindable which do not modify anything were not marked
as const so far. This adds the missing const, and a test to verify that
they work.

As all methods are fully inline, this does not cause any binary
compatibility issues.

Fixes: QTBUG-89508
Change-Id: If06d33bc405232887b8c371c268840ba34dbadf6
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
2021-04-14 09:24:33 +02:00
Tasuku Suzuki
865f3c2a11 Fix build without features.systemsemaphore
Change-Id: I73059f48d37253b5f962f96f693f26c7d55a31e1
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
2021-04-14 16:24:33 +09:00
Qt CI Bot
62efc8990d Merge integration refs/builds/qtci/dev/1618376490 2021-04-14 07:24:31 +00:00
Friedemann Kleint
0e69349f6f Brush up the mandelbrot example
The example refines the image by running a number of passes
with increasing number of iterations, which is not really
visible to the user. Set an informational text string on
the generated image which provides this information
along with the elapsed time.
The idea is to do the same to the corresponding
Qt for Python example to have some sort of speed comparison
for number crunching.

Add a command line option for the number of passes.

Make the window a bit larger to accommodate the
information.

Change-Id: I2afc1009ab53b580123d82a6aa645d9ffaa63ea2
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
2021-04-14 08:24:04 +02:00
Tasuku Suzuki
a63ceffa80 Fix build without features.im
invalid conversion from ‘int’ to ‘Qt::InputMethodHint’ [-fpermissive]

Change-Id: Icc67470ff6ef788b4f1b2eae46c6372b7f40c0d2
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2021-04-14 13:59:22 +09:00
Tasuku Suzuki
2df3d8ed41 Cleanup leftover QWS
QWS is replaced with QPA in Qt5

Change-Id: Iccec38e55ae23a27ebecd8010e1df7bba8aa5a33
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
2021-04-14 13:00:12 +09:00
Zhang Hao
94e03e506a Only scroll QMenu when there is a valid active action
When changing the active action via QMenu::setActiveAction
the menu will scroll to the active action, but we were
scrolling the menu also when the active action was null,
resulting in the menu scrolling back to the top.

We fix this by guarding the call to scrollMenu.

Fixes: QTBUG-92096
Pick-to: 5.15 6.0 6.1
Change-Id: I998f99ddacec32640834d59a907d569fdda458f0
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
2021-04-14 01:05:14 +00:00
Andreas Buhr
edcb5ed697 Document how bindable properties can be used in a multithreaded context
Add documentation which specifies that bindable properties cannot
be used in a multithreaded context.
Actually, they can be read when the owning thread is suspended
completely, but this should only be used by Qt internally.

Task-number: QTBUG-90511
Change-Id: I87effac3aea35205f05151cba3c95816da9a5c9d
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
2021-04-13 23:41:45 +02:00
Qt CI Bot
d197ad0e2a Merge integration refs/builds/qtci/dev/1618334477 2021-04-13 21:33:41 +00:00
Qt CI Bot
fb636832a1 Merge integration refs/builds/qtci/dev/1618328561 2021-04-13 19:35:34 +00:00
Tasuku Suzuki
f87a541e26 Fix build without features.highdpi
Add four template functions missing in stub.

Change-Id: I7ca126f866a76efc26167340ff2e35a60775078b
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2021-04-14 02:20:07 +09:00
Qt CI Bot
e8c1cd5d88 Merge integration refs/builds/qtci/dev/1618321030 2021-04-13 17:09:35 +00:00
Qt CI Bot
7ce274d95d Merge integration refs/builds/qtci/dev/1618317407 2021-04-13 16:09:24 +00:00
Allan Sandfeld Jensen
a7fabe2328 Light cleanup in QSemaphore Futex implementation
Gets rid of a goto, fixes overflow detection with wakeAll set,
and fixes 64-bit futex mode with futexHasWaiterCount = false.

Change-Id: I8bb98118013fc1dc2a8a405845bec0cb3350494f
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
2021-04-13 17:41:39 +02:00
Marianne Yrjänä
9c6721c106 Add QNX qpa to builds
Task-number: QTBUG-91234
Pick-to: 6.1 6.1.0
Change-Id: I978aff101ce29d2df74ced801911426ccd56e997
Reviewed-by: Rami Potinkara <rami.potinkara@qt.io>
Reviewed-by: James McDonnell <jmcdonnell@blackberry.com>
2021-04-13 16:18:53 +03:00
Tasuku Suzuki
d84bf703b5 Fix build without features.menu
Change-Id: If7947839b8da5abc8ee84aace60cc7de7a053e04
Pick-to: 6.0 6.1
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2021-04-13 12:51:02 +00:00
Qt CI Bot
385e242ba9 Merge integration refs/builds/qtci/dev/1618310175 2021-04-13 12:50:59 +00:00
Sona Kurazyan
726330c9c0 QAbstractAnimation: initialize the private members while declaring them
Change-Id: I5de0510d06b7d8e10c3cb0d4f23fb7991b8d6c51
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
Reviewed-by: Andreas Buhr <andreas.buhr@qt.io>
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
2021-04-13 13:47:46 +02:00
Qt CI Bot
2c5a35f6ed Merge integration refs/builds/qtci/dev/1618306545 2021-04-13 11:46:39 +00:00
Eskil Abrahamsen Blomfeldt
cd9bbcd97a Adapt to Harfbuzz 2.8.0 update
The Unicode 13 language tags are available since Harfbuzz
2.6.7.

For compilation with earlier versions, also update the
hardcoded tags to match the ones in Harfbuzz (and in
iso-15924):

https://unicode.org/iso15924/iso15924-codes.html

Task-number: QTBUG-90217
Change-Id: I4e2cfdf61a5c4189b8aac51644c9d80c816aeebc
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
(cherry picked from commit 910ac477f013f2af690b66f1ac41d65ab7527843)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
2021-04-13 10:02:02 +00:00
Qt CI Bot
7fe1114dc7 Merge integration refs/builds/qtci/dev/1618299310 2021-04-13 09:45:54 +00:00
Volker Hilsheimer
742ecf83e5 Silence qdoc warnings
These are internal APIs, so silence qdoc which seems to get confused
by the missing CALLBACK annotation in the implementation.

Change-Id: Iddd9f87257843cc3d43597fe7e6c103aa5e1a646
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
Reviewed-by: Nico Vertriest <nico.vertriest@qt.io>
2021-04-13 10:49:02 +02:00
Volker Hilsheimer
ae3d4b8f6b Fix qdoc warnings from new QLockFile members
Change-Id: I06210fe37a3d90a958064fff48331a34bced2a8b
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
Reviewed-by: Nico Vertriest <nico.vertriest@qt.io>
2021-04-13 10:48:50 +02:00
Volker Hilsheimer
f6651d54df Fix qdoc warning
QPixmap doesn't have a devicePixelSize() method, but
deviceIndependentSize is a relevant method here.

Change-Id: Ie71e6cc88534792a896ea17ec37b1b9737c2f986
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
Reviewed-by: Nico Vertriest <nico.vertriest@qt.io>
2021-04-13 10:48:45 +02:00
Volker Hilsheimer
3206840b0e Fix qdoc warning, \function is not a command
Document the size parameter while at it, and rephrase a bit.

This introduces a new qdoc warning since QtLiteral is a new
namespace without any documentation, but that's for a separate
commit.

Change-Id: I849d5cdde8b64dbbe7e6a526214d422930091cd4
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
Reviewed-by: Andrei Golubev <andrei.golubev@qt.io>
Reviewed-by: Nico Vertriest <nico.vertriest@qt.io>
2021-04-13 10:48:38 +02:00
Volker Hilsheimer
5b94f88747 Document parameter correctly, fix qdoc warning
Not needed in 6.1, the method is still (incorrectly) marked as \internal
there.

Change-Id: Idf1d924d8d320eca2388dbd28006eeaf9efedc3a
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
Reviewed-by: Nico Vertriest <nico.vertriest@qt.io>
2021-04-13 10:48:08 +02:00
Volker Hilsheimer
2cc458abfb Document QLocalSocket::socketOptions as a property
Change-Id: Ifda55ac7afb3fb30d973a01104b012959ae285ab
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
Reviewed-by: Nico Vertriest <nico.vertriest@qt.io>
2021-04-13 10:48:01 +02:00
Volker Hilsheimer
ace3d4f00e Document new InputMethodQuery enum value
This amends c80f262258.

Change-Id: Iec8a8f5ce50fdf0ba371a287f243186b2435e594
Reviewed-by: Liang Qi <liang.qi@qt.io>
Reviewed-by: Piotr Mikolajczyk <piotr.mikolajczyk@qt.io>
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
2021-04-13 07:33:41 +00:00
Heikki Halmet
409443a376 Extend blacklisting of tst_gestures including all RHEL's
These are also failing in RHEL 8.2

Task-number: QTBUG-52523
Change-Id: I1448124376a2b415351d1a755043431050808e38
Reviewed-by: Jani Heikkinen <jani.heikkinen@qt.io>
2021-04-13 08:20:48 +03:00
Volker Hilsheimer
aab6d336f7 Fix qdoc warning, it's QThread::Priority
Change-Id: If3df55ff95f8bdb510bdc3578ba3c7c03b9029a1
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
2021-04-12 23:53:01 +02:00
Volker Hilsheimer
2bdaf28034 Don't disable menu items that belong to the active modal window
A popup/context menu created via QQuickPlatformMenu doesn't belong to any
menubar, so by disabling items in a menu that doesn't belong to the currently
active menubar (5b9f6862b1), we disabled all menu items in a QQuickPlatformMenu
when a modal window was active.

For such unrooted menus, use the QCocoaMenuObject data structure to record
which window it is shown for, and only disable items if that window is not
also the current modal window.

Amends 5b9f6862b1.

Fixes: QTBUG-92040
Pick-to: 6.1 6.0 5.15
Change-Id: I56b6d579e5e94689b43ca84d4637e35dc2cbeb4c
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
2021-04-12 19:30:12 +00:00
Qt CI Bot
fc0255ddc9 Merge integration refs/builds/qtci/dev/1618248052 2021-04-12 19:28:28 +00:00
Qt CI Bot
a91728b4e8 Merge integration refs/builds/qtci/dev/1618240808 2021-04-12 18:06:39 +00:00
Robert Löhning
c62a193ca3 Fuzzing: Simplify figuring out the failing datetime format
Task-number: QTBUG-92275
Change-Id: I732e72e614163b536c3fa9187011c57fea639b92
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
2021-04-12 19:08:07 +02:00
Qt CI Bot
e5d8e2ae6e Merge integration refs/builds/qtci/dev/1618233601 2021-04-12 17:08:06 +00:00
Volker Hilsheimer
3fa778142a Silence qdoc warning from deprecated enum value
The mis-spelled value doesn't need documentation.

Pick-to: 6.1
Change-Id: I709abdca1d515902b3a12d3c5a5b62809d1f9a8b
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2021-04-12 15:19:41 +00:00
Alexey Edelev
fcb766f588 Add test of the static plugin with resources
The test follows up the discussion about tests related to the static
plugin resources:

https://codereview.qt-project.org/c/qt/qtbase/+/341203/6/tests/auto/other/init_resources_static_plugin/CMakeLists.txt#1

It emulates the static plugin that contains resource files. Since the
test already exposed few issues related to the resource object linking
it makes sense to have it in test set.

Change-Id: I62621c2db1eae6ae5842ba52035774a662d93423
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
2021-04-12 17:19:41 +02:00
Mårten Nordheim
b1fe3e3d80 QNetworkInformation: Private the destructor
It wasn't meant to be public.

Pick-to: 6.1 6.1.0
Change-Id: Ifa7fff48f82b96bdfa277677d3988dc8881b8c2a
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2021-04-12 17:19:41 +02:00
Qt CI Bot
6a17a8ba84 Merge integration refs/builds/qtci/dev/1618228407 2021-04-12 15:19:40 +00:00
Qt CI Bot
6d624ab01a Merge integration refs/builds/qtci/dev/1618224780 2021-04-12 13:55:09 +00:00
Mårten Nordheim
b67fe6dc7d QNetworkInformation: Remove the default argument
And the code for loading whatever backend is sorted first.
Though, looking at the code it would've never returned 'true' anyway.

Pick-to: 6.1 6.1.0
Change-Id: I7bc2c740e8cb5343e5843cb1d65715d236b92a25
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2021-04-12 15:18:45 +02:00
Qt CI Bot
ffd13e19a9 Merge integration refs/builds/qtci/dev/1618221163 2021-04-12 12:44:05 +00:00
Mårten Nordheim
5a60657363 QNetworkInformation: make supports(...) not virtual
Pick-to: 6.1 6.1.0
Change-Id: Ib8d27410e6baa495a7351a57c8c1c1b30a64eb26
Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2021-04-12 13:21:17 +02:00
Qt CI Bot
b690632323 Merge integration refs/builds/qtci/dev/1618217560 2021-04-12 11:21:16 +00:00