qt5base-lts/examples/widgets
Stephen Kelly 43325a23f3 Delete the QVariant ctors taking global Qt enum values.
They have unexpected results in Qt 5 (the Qt::GlobalColor one works
as expected in Qt 4, but was removed in Qt 5):

 QVariant v = QVariant(Qt::red);
 qDebug() << v; // QVariant(int, 7)
 v = Qt::red;
 qDebug() << v; // QVariant(int, 7)

The correct way is to use:

 QVariant v = QVariant::fromValue(QColor(Qt::red));

The deleted constructors are the ones for which there is a class
with an implicit constructor taking the enum, and that class is
a built-in metatype.

QLocale::Language and QKeySequence::StandardKey would also fit
the description, but I can't include the header for QKeySequence
as it is in QtGui, and I don't want to include the qlocale header
in qvariant.h. Putting a QLocale::Language is probably very
uncommon anyway.

The QTextFormat test is doing the wrong thing, but the result isn't
being tested. Added new tests which fail before the patch.

Change-Id: Ia38a0784990f4d40ff7457a86daf58aabd4964eb
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
2012-10-10 08:45:22 +02:00
..
animation Delete the QVariant ctors taking global Qt enum values. 2012-10-10 08:45:22 +02:00
desktop Change copyrights from Nokia to Digia 2012-09-22 19:20:11 +02:00
dialogs Change copyrights from Nokia to Digia 2012-09-22 19:20:11 +02:00
doc Remove CDE and Motif styles from qtbase 2012-09-27 15:16:16 +02:00
draganddrop Change copyrights from Nokia to Digia 2012-09-22 19:20:11 +02:00
effects Change copyrights from Nokia to Digia 2012-09-22 19:20:11 +02:00
graphicsview Change copyrights from Nokia to Digia 2012-09-22 19:20:11 +02:00
itemviews Use QStringList::join(QChar) overload where applicable [examples] 2012-09-23 23:30:03 +02:00
layouts Change copyrights from Nokia to Digia 2012-09-22 19:20:11 +02:00
mainwindows Change copyrights from Nokia to Digia 2012-09-22 19:20:11 +02:00
painting Delete the QVariant ctors taking global Qt enum values. 2012-10-10 08:45:22 +02:00
richtext Change copyrights from Nokia to Digia 2012-09-22 19:20:11 +02:00
scroller Change copyrights from Nokia to Digia 2012-09-22 19:20:11 +02:00
statemachine Change copyrights from Nokia to Digia 2012-09-22 19:20:11 +02:00
tutorials fix conflicting Visual Studio project names for Qt examples 2012-09-27 15:50:14 +02:00
widgets fix conflicting Visual Studio project names for Qt examples 2012-09-27 15:50:14 +02:00
widgets.pro Move tutorials to widgets. 2012-09-09 01:18:37 +02:00