qt5base-lts/tests/auto/corelib/tools/qstringapisymmetry
Thiago Macieira 0e0f656f50 Mark the previously public qstringalgorithms.h functions private
Discussed during Qt Contributor Summit 2017. We concluded that we don't
want to make these functions public, as they do not follow Qt coding
style API. Specifically,

   qStartsWith(a, b)

is not easily understood which argument is the needle and which argument
is the haystack (same problem memcpy() has). Compare that to

   a.startsWith(b)

which can clearly be read in English as a subject-verb-object sentence.

This commit removes the unit tests that called compare().

Discussed-on: http://lists.qt-project.org/pipermail/development/2017-October/031060.html
Change-Id: Icaa86fc7b54d4b368c0efffd14ee6205eb9043fb
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
2017-10-29 10:13:13 +00:00
..
.gitignore Add test for API symmetry of QString/Ref, QLatin1String, QChar 2016-03-15 08:11:35 +00:00
qstringapisymmetry.pro Enable c++17 in the QStringApiSymmetry test 2017-05-05 07:11:57 +00:00
tst_qstringapisymmetry.cpp Mark the previously public qstringalgorithms.h functions private 2017-10-29 10:13:13 +00:00