ICU-2836 update with review notes

X-SVN-Rev: 12101
This commit is contained in:
Ram Viswanadha 2003-05-24 01:47:30 +00:00
parent c6c30e6c09
commit 8c1c9bad81
4 changed files with 9 additions and 10 deletions

View File

@ -4,8 +4,8 @@
* others. All Rights Reserved. * * others. All Rights Reserved. *
******************************************************************************* *******************************************************************************
* $Source: /xsrl/Nsvn/icu/icu4j/src/com/ibm/icu/dev/test/format/IntlTestDateFormatAPIC.java,v $ * $Source: /xsrl/Nsvn/icu/icu4j/src/com/ibm/icu/dev/test/format/IntlTestDateFormatAPIC.java,v $
* $Date: 2003/05/14 19:03:16 $ * $Date: 2003/05/24 01:47:30 $
* $Revision: 1.3 $ * $Revision: 1.4 $
* *
***************************************************************************************** *****************************************************************************************
*/ */
@ -108,7 +108,7 @@ public class IntlTestDateFormatAPIC extends com.ibm.icu.dev.test.TestFmwk {
try { try {
obj = fmt.parse(str); obj = fmt.parse(str);
if(obj==null){ if(obj==null){
errln("FAIL: The format object could parse the string : "+str); errln("FAIL: The format object could not parse the string : "+str);
} }
} catch (java.text.ParseException pe) { } catch (java.text.ParseException pe) {
System.out.println(pe); System.out.println(pe);

View File

@ -5,8 +5,8 @@
******************************************************************************* *******************************************************************************
* *
* $Source: /xsrl/Nsvn/icu/icu4j/src/com/ibm/icu/dev/test/lang/Attic/UCharacterIteratorTest.java,v $ * $Source: /xsrl/Nsvn/icu/icu4j/src/com/ibm/icu/dev/test/lang/Attic/UCharacterIteratorTest.java,v $
* $Date: 2003/05/24 01:39:09 $ * $Date: 2003/05/24 01:47:30 $
* $Revision: 1.3 $ * $Revision: 1.4 $
* *
******************************************************************************* *******************************************************************************
*/ */
@ -15,7 +15,6 @@ package com.ibm.icu.dev.test.lang;
import com.ibm.icu.dev.test.TestFmwk; import com.ibm.icu.dev.test.TestFmwk;
import com.ibm.icu.text.UTF16;
/** /**
* Testing class for UCharacterIterator * Testing class for UCharacterIterator

View File

@ -156,7 +156,7 @@ class NormalizerBuilder {
//System.out.println("debug: " + line); //System.out.println("debug: " + line);
} }
end = line.indexOf(';',start=end+1); // name end = line.indexOf(';',start=end+1); // name
/*String name =*/ line.substring(start,end); /*String name = line.substring(start,end);*/
end = line.indexOf(';',start=end+1); // general category end = line.indexOf(';',start=end+1); // general category
end = line.indexOf(';',start=end+1); // canonical class end = line.indexOf(';',start=end+1); // canonical class

View File

@ -5,8 +5,8 @@
******************************************************************************* *******************************************************************************
* *
* $Source: /xsrl/Nsvn/icu/icu4j/src/com/ibm/icu/lang/UCharacter.java,v $ * $Source: /xsrl/Nsvn/icu/icu4j/src/com/ibm/icu/lang/UCharacter.java,v $
* $Date: 2003/05/24 00:48:08 $ * $Date: 2003/05/24 01:47:30 $
* $Revision: 1.74 $ * $Revision: 1.75 $
* *
******************************************************************************* *******************************************************************************
*/ */
@ -2472,7 +2472,7 @@ public final class UCharacter
*/ */
public static boolean isUnicodeIdentifierStart(int ch) public static boolean isUnicodeIdentifierStart(int ch)
{ {
/*int cat = */getType(ch); /*int cat = getType(ch);*/
// if props == 0, it will just fall through and return false // if props == 0, it will just fall through and return false
return ((1 << getType(ch)) return ((1 << getType(ch))
& ((1 << UCharacterCategory.UPPERCASE_LETTER) & ((1 << UCharacterCategory.UPPERCASE_LETTER)