AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
0c3dda058c
skia2/gn/utils.gni

117 lines
3.7 KiB
Plaintext
Raw Normal View History

Split SkSL and utils apart again into .gni files. Also extend GN format presubmit check to .gni files. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3976 Change-Id: I292f3136437101e3e2c3271e260536ab7a24b192 Reviewed-on: https://skia-review.googlesource.com/3976 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 18:17:04 +00:00
# Copyright 2016 Google Inc.
#
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
# Things are easiest for everyone if these source paths are absolute.
_src = get_path_info("../src", "abspath")
_include = get_path_info("../include", "abspath")
GN: split out skia_*_public from skia_*_sources `gn check` passes. We will work towards removing `check_includes = false`. Change-Id: I0ab396fadaf31a166921bdea334b2cfedca23dcd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/195363 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-02-26 16:54:25 +00:00
skia_utils_public = [
play with animated gif Bug: skia: Change-Id: If86314cda6aa84f4824958cca30cde88a78d4b59 Reviewed-on: https://skia-review.googlesource.com/c/158562 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
2018-10-03 14:16:55 +00:00
"$_include/utils/SkAnimCodecPlayer.h",
remove duplicate SkBase64.h There's already an identical header in include/utils/SkBase64.h. (And it's used by Flutter, so we need to keep the include/ one.) Change-Id: Ia86f5b18d4351ec871902d0fd0e9f076f5d62fc7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/209664 Commit-Queue: Mike Klein <mtklein@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: Mike Klein <mtklein@google.com>
2019-04-22 17:10:59 +00:00
"$_include/utils/SkBase64.h",
Revert "Move SkCamera.h to client_utils/android" This reverts commit 8a54d86c780a22796f8d535f74bf6af33a06c707. Reason for revert: Causing issues with Android CTS Original change's description: > Move SkCamera.h to client_utils/android > > Android still uses this > https://developer.android.com/reference/android/graphics/Camera > but no other client does. > > This adds a little adaption layer until Android is updated > to use the View3D version. > > Move SkCamera.h to View3D.h. Change names to android::skia::CLASS > instead of SkCLASS. (3DView is not a valid class name, so rename it to > View3D.) > > Forward-declare SkMatrix. Do not override SkNoncopyable - just delete > the copy constructor/operator=. Make fU and fV private in Patch3D. > > Make Sk3DView override View3D temporarily until Android can be switched > over to the new class. > > (View3D from http://review.skia.org/291371) > > I made Patch3D and Camera3D be private classes as they are > currently not used by Android and wanted to constrain the > exposed API as much as possible. > > Change-Id: Ibde45478421feeb610e045205c3f20c0e5b1567e > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/532456 > Reviewed-by: Brian Osman <brianosman@google.com> > Reviewed-by: Leon Scroggins <scroggo@google.com> > Commit-Queue: Kevin Lubick <kjlubick@google.com> Change-Id: If6e768524a0e13e14ef886a6f081a09ddc0dc2fd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/533396 Owners-Override: Kevin Lubick <kjlubick@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2022-04-25 11:54:10 +00:00
"$_include/utils/SkCamera.h",
Split SkSL and utils apart again into .gni files. Also extend GN format presubmit check to .gni files. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3976 Change-Id: I292f3136437101e3e2c3271e260536ab7a24b192 Reviewed-on: https://skia-review.googlesource.com/3976 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 18:17:04 +00:00
"$_include/utils/SkCanvasStateUtils.h",
Revert "Revert "custom typeface"" Fix: const auto [...] --> auto [...] This reverts commit 0066adefa97dccddf75a73d0cecf2cf7374cd146. Change-Id: I5d2df8bcc2bc681259a55b2b851d53fb18599287 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/288550 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
2020-05-07 20:58:40 +00:00
"$_include/utils/SkCustomTypeface.h",
Split SkSL and utils apart again into .gni files. Also extend GN format presubmit check to .gni files. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3976 Change-Id: I292f3136437101e3e2c3271e260536ab7a24b192 Reviewed-on: https://skia-review.googlesource.com/3976 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 18:17:04 +00:00
"$_include/utils/SkEventTracer.h",
"$_include/utils/SkNWayCanvas.h",
remove duplicate SkBase64.h There's already an identical header in include/utils/SkBase64.h. (And it's used by Flutter, so we need to keep the include/ one.) Change-Id: Ia86f5b18d4351ec871902d0fd0e9f076f5d62fc7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/209664 Commit-Queue: Mike Klein <mtklein@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: Mike Klein <mtklein@google.com>
2019-04-22 17:10:59 +00:00
"$_include/utils/SkNoDrawCanvas.h",
Split SkSL and utils apart again into .gni files. Also extend GN format presubmit check to .gni files. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3976 Change-Id: I292f3136437101e3e2c3271e260536ab7a24b192 Reviewed-on: https://skia-review.googlesource.com/3976 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 18:17:04 +00:00
"$_include/utils/SkNullCanvas.h",
OrderedFontMgr utility Only supports finding / matching, never Making Change-Id: I81b09e7f3563cab4ed4f0fbfc598781ff3a355aa Reviewed-on: https://skia-review.googlesource.com/c/skia/+/401576 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Julia Lavrova <jlavrova@google.com>
2021-04-27 17:21:05 +00:00
"$_include/utils/SkOrderedFontMgr.h",
Split SkSL and utils apart again into .gni files. Also extend GN format presubmit check to .gni files. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3976 Change-Id: I292f3136437101e3e2c3271e260536ab7a24b192 Reviewed-on: https://skia-review.googlesource.com/3976 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 18:17:04 +00:00
"$_include/utils/SkPaintFilterCanvas.h",
"$_include/utils/SkParse.h",
"$_include/utils/SkParsePath.h",
"$_include/utils/SkRandom.h",
Move Android shadow rendering interface to util library. BUG=skia:6119 Change-Id: I8318cf2758042ffd0c81c5fa74240acbf7bea61f Reviewed-on: https://skia-review.googlesource.com/6999 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2017-01-13 19:37:37 +00:00
"$_include/utils/SkShadowUtils.h",
add utility for caching char2glyph Try: out/release/nanobench --match _charToGlyph Pseudo plan to use this: - attach to whatever typeface backends need it (probably just freetype) - have a purge/limiting scheme (e.g. only cache N entries) - if we care, make the search fancier (e.g. binary, slope, etc.) Bug: 951647 Change-Id: Ib1042ca5891d2742499faf1314579c402121a855 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/207703 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Reed <reed@google.com>
2019-04-11 21:10:17 +00:00
GN: split out skia_*_public from skia_*_sources `gn check` passes. We will work towards removing `check_includes = false`. Change-Id: I0ab396fadaf31a166921bdea334b2cfedca23dcd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/195363 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-02-26 16:54:25 +00:00
#mac
"$_include/utils/mac/SkCGUtils.h",
]
Split SkSL and utils apart again into .gni files. Also extend GN format presubmit check to .gni files. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3976 Change-Id: I292f3136437101e3e2c3271e260536ab7a24b192 Reviewed-on: https://skia-review.googlesource.com/3976 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 18:17:04 +00:00
GN: split out skia_*_public from skia_*_sources `gn check` passes. We will work towards removing `check_includes = false`. Change-Id: I0ab396fadaf31a166921bdea334b2cfedca23dcd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/195363 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2019-02-26 16:54:25 +00:00
skia_utils_sources = [
play with animated gif Bug: skia: Change-Id: If86314cda6aa84f4824958cca30cde88a78d4b59 Reviewed-on: https://skia-review.googlesource.com/c/158562 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
2018-10-03 14:16:55 +00:00
"$_src/utils/SkAnimCodecPlayer.cpp",
Split SkSL and utils apart again into .gni files. Also extend GN format presubmit check to .gni files. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3976 Change-Id: I292f3136437101e3e2c3271e260536ab7a24b192 Reviewed-on: https://skia-review.googlesource.com/3976 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 18:17:04 +00:00
"$_src/utils/SkBase64.cpp",
"$_src/utils/SkBitSet.h",
Reland "Reland "Adding a trace to nanobench for RP/VM comparison"" This reverts commit 0e48516aae7e63dc50f16e9fb0080039f4f06d88. Reason for revert: Again trying to land this CL Original change's description: > Revert "Reland "Adding a trace to nanobench for RP/VM comparison"" > > This reverts commit 94b8dd67108d105f13d0fcd60e8c427e92355a64. > > Reason for revert: https://ci.chromium.org/p/chromium/builders/try/android-marshmallow-x86-rel appears to either not support this instruction or it is disabled. > > Original change's description: > > Reland "Adding a trace to nanobench for RP/VM comparison" > > > > This reverts commit 39728eb9804cced26933f38d6bcf5652dd8d24bc. > > > > Reason for revert: Need to reland after I figure out what happened > > > > Original change's description: > > > Revert "Adding a trace to nanobench for RP/VM comparison" > > > > > > This reverts commit e855b1273fee6a2b3505ea27aec56e8fc82749e3. > > > > > > Reason for revert: breaking the tree > > > > > > Original change's description: > > > > Adding a trace to nanobench for RP/VM comparison > > > > > > > > Run nanobench with --compare key and collect data for comparison: > > > > ./out/Release/nanobench --csv --config 8888 --skvm --compare --loops 100 --samples 1 --match $(ls skps | grep --invert-match svg ) 2>&1 | tee VM.data > > > > ./out/Release/nanobench --csv --config 8888 --forceRasterPipeline --compare --loops 100 --samples 1 --match $(ls skps | grep --invert-match svg ) 2>&1 | tee RP.data > > > > awk 'BEGIN {OFS=","; fileNum = 0} ($2 ~ /MB/) && fileNum == 0 {vmvmcycles[$3] = $6; vmvmscan[$3] = $8; vmvmpixels[$3] = $10; vmvminterp[$3] = $11; vmrpcycle[$3] = $14; vmrpscan[$3] = $16; vmrppixels[$3] = $18} ($2 ~ /MB/) && fileNum == 1 {print $3, vmvmcycles[$3], vmvmscan[$3], vmvmpixels[$3], vmvminterp[$3], $6, $8, $10, $11, $14, $16, $18} ENDFILE {fileNum += 1}' VM.data RP.data > compare.csv > > > > > > > > You can see an example of comparison table here: > > > > https://docs.google.com/spreadsheets/d/1Q57oz6Jn8JPQkPzUbtO0fcZh2VhwPhxwsLaHnSb9uR0/edit#gid=406063636 > > > > > > > > Change-Id: I8fa35e3fb087bce00ab19355a3bc021334aa7a80 > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/501337 > > > > Reviewed-by: Herb Derby <herb@google.com> > > > > Commit-Queue: Julia Lavrova <jlavrova@google.com> > > > > > > Change-Id: I6799b90ffd8bc05c65d1185bfc07a06af05e2038 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/507182 > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > Commit-Queue: Julia Lavrova <jlavrova@google.com> > > > > Change-Id: I3668b5a40f310598e23c922b1eb6f93db4dac13c > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/507183 > > Reviewed-by: Herb Derby <herb@google.com> > > Commit-Queue: Julia Lavrova <jlavrova@google.com> > > Change-Id: I5d0174fca1aeaa0f3e75a8e1f643265701068f42 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/508396 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Ben Wagner <bungeman@google.com> Change-Id: Ibf7c8957427dc8a1cdc133774608b48ab6715c7f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/508536 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Julia Lavrova <jlavrova@google.com>
2022-02-14 14:20:50 +00:00
"$_src/utils/SkBlitterTrace.h",
"$_src/utils/SkBlitterTraceCommon.h",
Work around FreeType type change. FreeType is moving their memory APIs from 'long' to 'size_t'. This generally uses the same number of bits, but these are usually different types (signed vs. unsigned). Detect the actual type in use where needed. Change-Id: Id85b9b874f7418fbe308739d23eb3d22ecd765a8 Reviewed-on: https://skia-review.googlesource.com/c/159840 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2018-10-01 18:54:01 +00:00
"$_src/utils/SkCallableTraits.h",
Revert "Move SkCamera.h to client_utils/android" This reverts commit 8a54d86c780a22796f8d535f74bf6af33a06c707. Reason for revert: Causing issues with Android CTS Original change's description: > Move SkCamera.h to client_utils/android > > Android still uses this > https://developer.android.com/reference/android/graphics/Camera > but no other client does. > > This adds a little adaption layer until Android is updated > to use the View3D version. > > Move SkCamera.h to View3D.h. Change names to android::skia::CLASS > instead of SkCLASS. (3DView is not a valid class name, so rename it to > View3D.) > > Forward-declare SkMatrix. Do not override SkNoncopyable - just delete > the copy constructor/operator=. Make fU and fV private in Patch3D. > > Make Sk3DView override View3D temporarily until Android can be switched > over to the new class. > > (View3D from http://review.skia.org/291371) > > I made Patch3D and Camera3D be private classes as they are > currently not used by Android and wanted to constrain the > exposed API as much as possible. > > Change-Id: Ibde45478421feeb610e045205c3f20c0e5b1567e > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/532456 > Reviewed-by: Brian Osman <brianosman@google.com> > Reviewed-by: Leon Scroggins <scroggo@google.com> > Commit-Queue: Kevin Lubick <kjlubick@google.com> Change-Id: If6e768524a0e13e14ef886a6f081a09ddc0dc2fd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/533396 Owners-Override: Kevin Lubick <kjlubick@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2022-04-25 11:54:10 +00:00
"$_src/utils/SkCamera.cpp",
Split SkSL and utils apart again into .gni files. Also extend GN format presubmit check to .gni files. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3976 Change-Id: I292f3136437101e3e2c3271e260536ab7a24b192 Reviewed-on: https://skia-review.googlesource.com/3976 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 18:17:04 +00:00
"$_src/utils/SkCanvasStack.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/utils/SkCanvasStack.h",
Split SkSL and utils apart again into .gni files. Also extend GN format presubmit check to .gni files. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3976 Change-Id: I292f3136437101e3e2c3271e260536ab7a24b192 Reviewed-on: https://skia-review.googlesource.com/3976 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 18:17:04 +00:00
"$_src/utils/SkCanvasStateUtils.cpp",
add utility for caching char2glyph Try: out/release/nanobench --match _charToGlyph Pseudo plan to use this: - attach to whatever typeface backends need it (probably just freetype) - have a purge/limiting scheme (e.g. only cache N entries) - if we care, make the search fancier (e.g. binary, slope, etc.) Bug: 951647 Change-Id: Ib1042ca5891d2742499faf1314579c402121a855 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/207703 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Reed <reed@google.com>
2019-04-11 21:10:17 +00:00
"$_src/utils/SkCharToGlyphCache.cpp",
"$_src/utils/SkCharToGlyphCache.h",
move SkClipStack::asPath into PDFUtils bug: skia:9734 Change-Id: I115c990c1532ab6852fe23956591878a04b3edc6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261282 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Hal Canary <halcanary@google.com>
2019-12-20 19:00:41 +00:00
"$_src/utils/SkClipStackUtils.cpp",
"$_src/utils/SkClipStackUtils.h",
Revert "Revert "custom typeface"" Fix: const auto [...] --> auto [...] This reverts commit 0066adefa97dccddf75a73d0cecf2cf7374cd146. Change-Id: I5d2df8bcc2bc681259a55b2b851d53fb18599287 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/288550 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
2020-05-07 20:58:40 +00:00
"$_src/utils/SkCustomTypeface.cpp",
Reland "Reland "Adding a trace to nanobench for RP/VM comparison"" This reverts commit 0e48516aae7e63dc50f16e9fb0080039f4f06d88. Reason for revert: Again trying to land this CL Original change's description: > Revert "Reland "Adding a trace to nanobench for RP/VM comparison"" > > This reverts commit 94b8dd67108d105f13d0fcd60e8c427e92355a64. > > Reason for revert: https://ci.chromium.org/p/chromium/builders/try/android-marshmallow-x86-rel appears to either not support this instruction or it is disabled. > > Original change's description: > > Reland "Adding a trace to nanobench for RP/VM comparison" > > > > This reverts commit 39728eb9804cced26933f38d6bcf5652dd8d24bc. > > > > Reason for revert: Need to reland after I figure out what happened > > > > Original change's description: > > > Revert "Adding a trace to nanobench for RP/VM comparison" > > > > > > This reverts commit e855b1273fee6a2b3505ea27aec56e8fc82749e3. > > > > > > Reason for revert: breaking the tree > > > > > > Original change's description: > > > > Adding a trace to nanobench for RP/VM comparison > > > > > > > > Run nanobench with --compare key and collect data for comparison: > > > > ./out/Release/nanobench --csv --config 8888 --skvm --compare --loops 100 --samples 1 --match $(ls skps | grep --invert-match svg ) 2>&1 | tee VM.data > > > > ./out/Release/nanobench --csv --config 8888 --forceRasterPipeline --compare --loops 100 --samples 1 --match $(ls skps | grep --invert-match svg ) 2>&1 | tee RP.data > > > > awk 'BEGIN {OFS=","; fileNum = 0} ($2 ~ /MB/) && fileNum == 0 {vmvmcycles[$3] = $6; vmvmscan[$3] = $8; vmvmpixels[$3] = $10; vmvminterp[$3] = $11; vmrpcycle[$3] = $14; vmrpscan[$3] = $16; vmrppixels[$3] = $18} ($2 ~ /MB/) && fileNum == 1 {print $3, vmvmcycles[$3], vmvmscan[$3], vmvmpixels[$3], vmvminterp[$3], $6, $8, $10, $11, $14, $16, $18} ENDFILE {fileNum += 1}' VM.data RP.data > compare.csv > > > > > > > > You can see an example of comparison table here: > > > > https://docs.google.com/spreadsheets/d/1Q57oz6Jn8JPQkPzUbtO0fcZh2VhwPhxwsLaHnSb9uR0/edit#gid=406063636 > > > > > > > > Change-Id: I8fa35e3fb087bce00ab19355a3bc021334aa7a80 > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/501337 > > > > Reviewed-by: Herb Derby <herb@google.com> > > > > Commit-Queue: Julia Lavrova <jlavrova@google.com> > > > > > > Change-Id: I6799b90ffd8bc05c65d1185bfc07a06af05e2038 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/507182 > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > Commit-Queue: Julia Lavrova <jlavrova@google.com> > > > > Change-Id: I3668b5a40f310598e23c922b1eb6f93db4dac13c > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/507183 > > Reviewed-by: Herb Derby <herb@google.com> > > Commit-Queue: Julia Lavrova <jlavrova@google.com> > > Change-Id: I5d0174fca1aeaa0f3e75a8e1f643265701068f42 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/508396 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Ben Wagner <bungeman@google.com> Change-Id: Ibf7c8957427dc8a1cdc133774608b48ab6715c7f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/508536 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Julia Lavrova <jlavrova@google.com>
2022-02-14 14:20:50 +00:00
"$_src/utils/SkCycles.h",
Split SkSL and utils apart again into .gni files. Also extend GN format presubmit check to .gni files. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3976 Change-Id: I292f3136437101e3e2c3271e260536ab7a24b192 Reviewed-on: https://skia-review.googlesource.com/3976 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 18:17:04 +00:00
"$_src/utils/SkDashPath.cpp",
"$_src/utils/SkDashPathPriv.h",
"$_src/utils/SkEventTracer.cpp",
SkFloatToDecimal moved to src/utils This change stages SkFloatToDecimal() for possible re-use by pdfium. Change-Id: Iedc0c78c8a633f0b0973365d2d8b540b5443590d Reviewed-on: https://skia-review.googlesource.com/90400 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Cary Clark <caryclark@google.com>
2018-01-02 21:25:53 +00:00
"$_src/utils/SkFloatToDecimal.cpp",
"$_src/utils/SkFloatToDecimal.h",
Split SkSL and utils apart again into .gni files. Also extend GN format presubmit check to .gni files. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3976 Change-Id: I292f3136437101e3e2c3271e260536ab7a24b192 Reviewed-on: https://skia-review.googlesource.com/3976 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 18:17:04 +00:00
"$_src/utils/SkFloatUtils.h",
Fold SkJSON into Skia/utils It's a tiny, core-ish component -- might as well treat as such to simplify dependencies. Change-Id: I6f31ce2d151f9a629d88bfc7f15d64891d5150c0 Reviewed-on: https://skia-review.googlesource.com/135780 Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-06-19 15:27:20 +00:00
"$_src/utils/SkJSON.cpp",
"$_src/utils/SkJSON.h",
Revert "Revert "GrContext::dump that produces JSON formatted output"" This reverts commit 0f450acd76fd58a2f7464f99869ed6afbfac303c. Bug: skia: Change-Id: I97428fbbc6d82bf8b186ec5fdbf1a939c00e4126 Reviewed-on: https://skia-review.googlesource.com/32726 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2017-08-10 14:23:25 +00:00
"$_src/utils/SkJSONWriter.cpp",
Added SkJSONWriter This is a stand-alone helper class for writing properly structured JSON to an SkWStream. It currently solves two problems (although this CL only uses it in one context): 1) Performance. Writing out JSON this way is about 10x faster than using JSONCPP. For the large amounts of data generated by the tracing system, that's a big win. 2) Makes it easy to emit structured JSON from code that's not fully centralized. We'd like to spit out JSON that describes a GrContext, GrGpu, GrCaps, etc... Doing that with simple string manipulation is complex, and spreads this logic over all those functions. Using JSONCPP adds yet another (large) third party library dependency (that we only build into our own tools right now). This went through several revisions. I originally planned it as a stateful SkString wrapper, so the user could just build their JSON as a string. That's O(N^2), though, because SkString grows by a (small) constant amount. Even using a better growth strategy still means needing RAM for all the resulting text, which is usually pointless. This version has a constant memory cost, so writing huge amounts of JSON to disk (tracing a long DM run can emit 100's of MBs) doesn't stress resources. Bug: skia: Change-Id: Ia716524b246db0f97d332da60d2ce9903069e748 Reviewed-on: https://skia-review.googlesource.com/31204 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-08-09 13:25:39 +00:00
"$_src/utils/SkJSONWriter.h",
Split SkSL and utils apart again into .gni files. Also extend GN format presubmit check to .gni files. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3976 Change-Id: I292f3136437101e3e2c3271e260536ab7a24b192 Reviewed-on: https://skia-review.googlesource.com/3976 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 18:17:04 +00:00
"$_src/utils/SkMatrix22.cpp",
"$_src/utils/SkMatrix22.h",
"$_src/utils/SkMultiPictureDocument.cpp",
"$_src/utils/SkNWayCanvas.cpp",
"$_src/utils/SkNullCanvas.cpp",
Move SkOSPath out of include/core. It is moved to src/utils. It is almost a tool, but has two uses in src/ports. The existing SkOSFile.cpp is left empty for the time being since it is mentioned in Chromium's BUILD.gn for Skia. Change-Id: I3bb7f7c4214359eb6ab906bfe76737d20bf1d6c7 Reviewed-on: https://skia-review.googlesource.com/4536 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <bungeman@google.com>
2016-11-07 23:05:29 +00:00
"$_src/utils/SkOSPath.cpp",
"$_src/utils/SkOSPath.h",
OrderedFontMgr utility Only supports finding / matching, never Making Change-Id: I81b09e7f3563cab4ed4f0fbfc598781ff3a355aa Reviewed-on: https://skia-review.googlesource.com/c/skia/+/401576 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Julia Lavrova <jlavrova@google.com>
2021-04-27 17:21:05 +00:00
"$_src/utils/SkOrderedFontMgr.cpp",
Split SkSL and utils apart again into .gni files. Also extend GN format presubmit check to .gni files. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3976 Change-Id: I292f3136437101e3e2c3271e260536ab7a24b192 Reviewed-on: https://skia-review.googlesource.com/3976 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 18:17:04 +00:00
"$_src/utils/SkPaintFilterCanvas.cpp",
"$_src/utils/SkParse.cpp",
"$_src/utils/SkParseColor.cpp",
"$_src/utils/SkParsePath.cpp",
"$_src/utils/SkPatchUtils.cpp",
"$_src/utils/SkPatchUtils.h",
Add ear-clipping code to triangulate simple polygons. Use this to fill concave shadows. Bug: skia:7971 Change-Id: I63dc1ed845f9fa3fcd86f1ad13b03da23cae0313 Reviewed-on: https://skia-review.googlesource.com/135200 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-06-28 20:26:50 +00:00
"$_src/utils/SkPolyUtils.cpp",
"$_src/utils/SkPolyUtils.h",
Move ShaderUtils out of Ganesh. This will allow us to use ShaderUtils in both Ganesh and Graphite. Change-Id: I78e34c4eb969a0d827c459d7fb945d17fdc22efa Reviewed-on: https://skia-review.googlesource.com/c/skia/+/482696 Reviewed-by: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
2021-12-10 22:27:10 +00:00
"$_src/utils/SkShaderUtils.cpp",
"$_src/utils/SkShaderUtils.h",
Change shadow tessellators to use SkColor and move to util. BUG=skia:6119 Change-Id: I4c4a8933c663ccc057596318a06c538175b9f16b Reviewed-on: https://skia-review.googlesource.com/7726 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
2017-01-30 18:11:45 +00:00
"$_src/utils/SkShadowTessellator.cpp",
"$_src/utils/SkShadowTessellator.h",
Move Android shadow rendering interface to util library. BUG=skia:6119 Change-Id: I8318cf2758042ffd0c81c5fa74240acbf7bea61f Reviewed-on: https://skia-review.googlesource.com/6999 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2017-01-13 19:37:37 +00:00
"$_src/utils/SkShadowUtils.cpp",
Reland "SkShaper JSON output with cluster visualization" This is a reland of 53610832a04157e4edf18347c3e69ddd9d799e3f Fixes conversion of size_t to int. Original change's description: > SkShaper JSON output with cluster visualization > > A simple JSON output for diagnostic purposes. > If the run is not 1:1 code points to glyphs, then > break the run into clusters. > > Change-Id: I06980e0bac2cdca8a69b5b5ba0759a021fd4eb3b > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/209740 > Commit-Queue: Herb Derby <herb@google.com> > Reviewed-by: Julia Lavrova <jlavrova@google.com> Change-Id: I712293c4820eb23234d64fa019d28bac8b105637 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211986 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
2019-04-22 21:18:50 +00:00
"$_src/utils/SkShaperJSONWriter.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/utils/SkShaperJSONWriter.h",
add a system for building SkCanvas wrappers for testing This adds a way to build a wrapping canvas for testing that is allowed to manipulate the internal state of the canvas. It provides a way to add friends to SkCanvas without having to change SkCanvas. Change-Id: I40de8b236ba5acff45b3a8f7e440dcf6fa196fcf Reviewed-on: https://skia-review.googlesource.com/c/skia/+/524316 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Herb Derby <herb@google.com>
2022-03-24 14:46:35 +00:00
"$_src/utils/SkTestCanvas.h",
add textutils These are meant to enable several things (eventually) - fission Align off of paint - fission TextEncoding off of paint - fission SkFont of of paint The first one is explicitly enabled here. The others will (I plan) follow later. The final state of the world (the goal) - paint has no font-ish parameters (no typeface or size) - font has no paint-ish parameters (no aa or lcd) - neither has alignment or encoding Bug: skia:8493, skia:8501 Change-Id: I5fcb945b6bcab30ef5e7019dfccb682661f56230 Reviewed-on: https://skia-review.googlesource.com/c/165061 Auto-Submit: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
2018-10-25 16:36:06 +00:00
"$_src/utils/SkTextUtils.cpp",
Split SkSL and utils apart again into .gni files. Also extend GN format presubmit check to .gni files. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3976 Change-Id: I292f3136437101e3e2c3271e260536ab7a24b192 Reviewed-on: https://skia-review.googlesource.com/3976 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 18:17:04 +00:00
"$_src/utils/SkThreadUtils_pthread.cpp",
"$_src/utils/SkThreadUtils_win.cpp",
SkUTF Create new header and namespace, `SkUTF` where we are putting all of our robust, well documented UTF-8, UTF-16, and UTF-32 functions: `SkUTF::{Count,Next,To}UTF{8,16,32}()`. SkUTF.h and SkUTF.cpp do not depend on the rest of Skia and are suitable for re-use in other modules. Some of the old UTF-{8,16} functions still live in SkUtils.h; their use will be phased out in future CLs. Also added more unit testing and cleaned up old tests. Removed functions that were unused outside of tests or used only once. Change-Id: Iaa59b8705abccf9c4ba082f855da368a0bad8380 Reviewed-on: https://skia-review.googlesource.com/143306 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2018-07-25 20:52:48 +00:00
"$_src/utils/SkUTF.cpp",
"$_src/utils/SkUTF.h",
Reland "SkVM visualizer, version 0.1" This reverts commit 372a36de757f033ae930dc43b73ed6aabb73cccd. Relanding the change Original change's description: > Revert "SkVM visualizer, version 0.1" > > This reverts commit bf57843b01899fd0ac8ebea02e07b6d94fba7b3c. > > Build break > > Original change's description: > > SkVM visualizer, version 0.1 > > > > Simplified - "no static instructions" > > Added to skslc with .cpp -> .html > > > > Change-Id: I0b56ea0480f868ca4182acb7a23c03acf7f57519 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/473659 > > Reviewed-by: John Stiles <johnstiles@google.com> > > Commit-Queue: Julia Lavrova <jlavrova@google.com> > > Change-Id: I938bbf7bb650d1636a0d9bd19e455b455a49ef27 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/487096 > Auto-Submit: Julia Lavrova <jlavrova@google.com> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Change-Id: I15b5f6630de43138da2dc72c4fe708499bed63c3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/487216 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Julia Lavrova <jlavrova@google.com>
2021-12-21 14:33:35 +00:00
"$_src/utils/SkVMVisualizer.cpp",
"$_src/utils/SkVMVisualizer.h",
Split SkSL and utils apart again into .gni files. Also extend GN format presubmit check to .gni files. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3976 Change-Id: I292f3136437101e3e2c3271e260536ab7a24b192 Reviewed-on: https://skia-review.googlesource.com/3976 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 18:17:04 +00:00
#mac
Split out coretext fontmgr factory. There can be only one SkFontMgr::Factory, so each should go in its own translation unit. In addition, the name SkFontHost_mac is now rather out of date and should now be SkFontMgr_mac_ct. Since the additional burden of additional build changes after the first is minimal, also split out SkTypeface_mac_ct and SkScalerContext_mac_ct. The original SkFontHost_mac.cpp is kept as a shell which #includes the cpp files which are replacing it. Once references to it are removed from all builds it can be removed. This is intended to be a reorganization without much code change. Most changes are simple renaming of functions which are now shared between translation units. However, there are a few behavior changes here. * Drop SkTypefaceCache global for SkTypeface_Mac 'local' global. * SkCTFontCTWidthForCSSWidth returns CGFloat instead of 'int'. * SkFontMgr_New_CoreText takes a CTFontCollectionRef. Change-Id: Iac548f9fd920c426ea5c6dcdefe8da0a9b89ec90 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/294456 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/294704 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/294714 Reviewed-by: Ben Wagner <bungeman@google.com>
2020-06-05 15:25:42 +00:00
"$_src/utils/mac/SkCGBase.h",
"$_src/utils/mac/SkCGGeometry.h",
Directly measure CoreText weight mapping. CoreText reports weight on a [-1.0, 1.0] scale with 0 being 'regular'. Unfortunately the mapping from the [1, 1000] scale more commonly used is not uniform and also varies between system fonts and fonts created from data. For system fonts the NSFontWeight values will be used if available, but there is no corresponding API for fonts created from data. Previously the values for fonts created from data were hardcoded, but the values have changed again recently. Directly read these values by varying the weight in the font data, creating a CTFontDescriptor from this data, and then using the value reported by CoreText. Bug: skia:11176 Change-Id: I071e2ff7ac3f676c8395b13aa82dde7a97fdf2ce Reviewed-on: https://skia-review.googlesource.com/c/skia/+/358535 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Herb Derby <herb@google.com>
2021-01-25 20:25:22 +00:00
"$_src/utils/mac/SkCTFont.cpp",
"$_src/utils/mac/SkCTFont.h",
Split SkSL and utils apart again into .gni files. Also extend GN format presubmit check to .gni files. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3976 Change-Id: I292f3136437101e3e2c3271e260536ab7a24b192 Reviewed-on: https://skia-review.googlesource.com/3976 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 18:17:04 +00:00
"$_src/utils/mac/SkCreateCGImageRef.cpp",
Use SkUniqueCFRef in SkImage*CG. This clarifies ownership and makes the code more readable. It is safe to use unique_ptr directly for UniqueCFRef, since unique_ptr does not call the deleter with nullptr. Change-Id: I4326a86059fb31488d1e163faca95a6c29960039 Reviewed-on: https://skia-review.googlesource.com/155612 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Hal Canary <halcanary@google.com>
2018-09-20 02:31:07 +00:00
"$_src/utils/mac/SkUniqueCFRef.h",
Split SkSL and utils apart again into .gni files. Also extend GN format presubmit check to .gni files. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3976 Change-Id: I292f3136437101e3e2c3271e260536ab7a24b192 Reviewed-on: https://skia-review.googlesource.com/3976 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 18:17:04 +00:00
#windows
"$_src/utils/win/SkAutoCoInitialize.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/utils/win/SkAutoCoInitialize.h",
Split SkSL and utils apart again into .gni files. Also extend GN format presubmit check to .gni files. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3976 Change-Id: I292f3136437101e3e2c3271e260536ab7a24b192 Reviewed-on: https://skia-review.googlesource.com/3976 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 18:17:04 +00:00
"$_src/utils/win/SkDWrite.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/utils/win/SkDWrite.h",
Split SkSL and utils apart again into .gni files. Also extend GN format presubmit check to .gni files. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3976 Change-Id: I292f3136437101e3e2c3271e260536ab7a24b192 Reviewed-on: https://skia-review.googlesource.com/3976 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 18:17:04 +00:00
"$_src/utils/win/SkDWriteFontFileStream.cpp",
"$_src/utils/win/SkDWriteFontFileStream.h",
"$_src/utils/win/SkDWriteGeometrySink.cpp",
"$_src/utils/win/SkDWriteGeometrySink.h",
Ignore NTDDI_VERSION with DirectWrite. Some builds set NTDDI_VERSION to a very old version of Windows to ensure they run on those older versions of Windows. The dwrite_3.h header uses NTDDI_VERSION in an odd manner, hiding immutable declarations of enums, structs, and interfaces. NTDDI_VERSION was indended to hide functions and extensions to structs. DWrite has one function (to create the factory) and no structs which will be extended. Skia is already tested to run on the oldest supported Windows platform (Windows 7), so an external build building Skia with NTDDI_VERSION as a build define should have no issues at runtime if Skia ignores it. If Skia doesn't ignore NTDDI_VERSION in this case the DWrite backend will be runtime limited to interfaces in very old versions of Windows, instead of using newer interfaces which become available at runtime. Change-Id: I3e9ac2c4116d75588bfff391928d3cd446d6363a Reviewed-on: https://skia-review.googlesource.com/142324 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Herb Derby <herb@google.com>
2018-07-19 12:55:10 +00:00
"$_src/utils/win/SkDWriteNTDDI_VERSION.h",
Split SkSL and utils apart again into .gni files. Also extend GN format presubmit check to .gni files. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3976 Change-Id: I292f3136437101e3e2c3271e260536ab7a24b192 Reviewed-on: https://skia-review.googlesource.com/3976 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 18:17:04 +00:00
"$_src/utils/win/SkHRESULT.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/utils/win/SkHRESULT.h",
Split SkSL and utils apart again into .gni files. Also extend GN format presubmit check to .gni files. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3976 Change-Id: I292f3136437101e3e2c3271e260536ab7a24b192 Reviewed-on: https://skia-review.googlesource.com/3976 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 18:17:04 +00:00
"$_src/utils/win/SkIStream.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_src/utils/win/SkIStream.h",
Use COM_DECLSPEC_NOTHROW STDMETHODIMP Use STDMETHODIMP because it's the right thing to do, use COM_DECLSPEC_NOTHROW because STDMETHOD uses it but STDMETHODIMP does not, leading to warnings from clang and maybe also from msvc, see https://developercommunity.visualstudio.com/content/problem/325764/msvc-1582-generates-warning-c4986-in-atl-header-fi.html This also removes SkBlockComRef, since even WRL has abandoned the similar RemoveIUnknown. These classes were helpful in the transition to using smart pointers, but are incompatible with final implementations. Change-Id: I53a618ee629af638d9d8625ccd5acb0db6529950 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/233988 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
2019-08-12 22:30:27 +00:00
"$_src/utils/win/SkObjBase.h",
Split SkSL and utils apart again into .gni files. Also extend GN format presubmit check to .gni files. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3976 Change-Id: I292f3136437101e3e2c3271e260536ab7a24b192 Reviewed-on: https://skia-review.googlesource.com/3976 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-26 18:17:04 +00:00
"$_src/utils/win/SkTScopedComPtr.h",
"$_src/utils/win/SkWGL.h",
"$_src/utils/win/SkWGL_win.cpp",
]
Reference in New Issue Copy Permalink