AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
0f46450775
skia2/tests/sksl/blend/golden/BlendDstInStandaloneSettings.glsl

18 lines
284 B
Plaintext
Raw Normal View History

Create golden outputs for SkSL blend functions. Several blend functions generate a surprisingly large amount of code, and appear to have opportunities for further optimization. At any rate, if we make compiler changes that would affect the output of a blend function, I think we would want to see the changes reflected in our golden outputs. Change-Id: Iff612dcd4bad8824b5e6e97413ffce19e5ea1c0e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/318336 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-21 21:01:22 +00:00
Add golden outputs for the Metal backend. This CL also updates the blend tests to use sk_FragColor instead of returning a half4, as the Metal backend assumes that a fragment processor's `main` will return void and always synthesizes a `return *_out;` at the end. (context link: https://osscs.corp.google.com/android/platform/superproject/+/master:external/skqp/src/sksl/SkSLMetalCodeGenerator.cpp;l=803;drc=842d31b14159626054e01dd32826563a8f4214bf ) BYPASS_INCLUSIVE_LANGUAGE_REASON=see http://b/168134166 Change-Id: I330a456bf25ee72d3a29c59cd624625378ae80a0 Bug: skia:10649, skia:10757, skia:10758, skia:10759, skia:10760, skia:10761, skia:10762 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/319409 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2020-09-25 17:35:58 +00:00
out vec4 sk_FragColor;
Only include one variable per declaration statement This removes VarDeclarationsStatement entirely. VarDeclaration instances appear directly as statements in Programs. SkSL that declares multiple variables in a single declaration is transformed to represent that as a series of VarDeclaration statements. Similarly, global variable declarations are represented by GlobalVarDeclaration program elements, one per variable. Bug: skia:10806 Change-Id: Idd8a2d971a8217733ed57f0dd2249d62f2f0e9c5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/323102 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: John Stiles <johnstiles@google.com>
2020-10-06 18:43:32 +00:00
in vec4 src;
in vec4 dst;
Add golden outputs for the Metal backend. This CL also updates the blend tests to use sk_FragColor instead of returning a half4, as the Metal backend assumes that a fragment processor's `main` will return void and always synthesizes a `return *_out;` at the end. (context link: https://osscs.corp.google.com/android/platform/superproject/+/master:external/skqp/src/sksl/SkSLMetalCodeGenerator.cpp;l=803;drc=842d31b14159626054e01dd32826563a8f4214bf ) BYPASS_INCLUSIVE_LANGUAGE_REASON=see http://b/168134166 Change-Id: I330a456bf25ee72d3a29c59cd624625378ae80a0 Bug: skia:10649, skia:10757, skia:10758, skia:10759, skia:10760, skia:10761, skia:10762 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/319409 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2020-09-25 17:35:58 +00:00
void main() {
Revert "Reland "Remove inliner from IR generation stage."" This reverts commit e497a080651c05678cf4760fa6e4daa53a10355b. Reason for revert: Pinpoint disagrees Original change's description: > Reland "Remove inliner from IR generation stage." > > This reverts commit 941fc7174fc20e8a8b707f1b636c85bbf2e1294f. > > Reason for revert: performance now seems to be roughly equal or better > (~1%) over several trials. > Nanobench: http://screen/A8e8sojaXBgbMgF > > Original change's description: > > Revert "Remove inliner from IR generation stage." > > > > This reverts commit 21d7778cb5c13e729b513eaa22dbf53f58a877c8. > > > > Reason for revert: Pinpoint absolutely hates this change > > > > Original change's description: > > > Remove inliner from IR generation stage. > > > > > > There is no need to inline code during IR generation, as the optimizer > > > can now handle this. > > > > > > Change-Id: If272bfb98e945a75ec91fb4aa026e5631ac51b5b > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315971 > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > Commit-Queue: Brian Osman <brianosman@google.com> > > > Reviewed-by: Brian Osman <brianosman@google.com> > > > Auto-Submit: John Stiles <johnstiles@google.com> > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > Change-Id: I62c235415bcdc92a088e2a7f9c3d7dbf7e1bf669 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317976 > > Reviewed-by: John Stiles <johnstiles@google.com> > > Commit-Queue: John Stiles <johnstiles@google.com> > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > Change-Id: I6189806c678283188f4b67ee61e5886f88c2d6fc > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/324891 > Reviewed-by: John Stiles <johnstiles@google.com> > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > Auto-Submit: John Stiles <johnstiles@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I79149467565f22f53b8c28868dd53b80f3421137 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/325626 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-10-13 15:19:41 +00:00
vec4 _0_blend_dst_in;
Create golden outputs for SkSL blend functions. Several blend functions generate a surprisingly large amount of code, and appear to have opportunities for further optimization. At any rate, if we make compiler changes that would affect the output of a blend function, I think we would want to see the changes reflected in our golden outputs. Change-Id: Iff612dcd4bad8824b5e6e97413ffce19e5ea1c0e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/318336 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-21 21:01:22 +00:00
{
Stop cloning builtin functions Previously, any builtin functions would be optimized as a side-effect of optimizing programs that used them. Now that shared elements aren't being optimized in that way, we explicitly optimize any shared modules when they are first created. We don't remove dead elements, but we we do substitute settings, simplify, and inline. Bug: skia:10905 Change-Id: I701b5e9f52fb880ef3e6f4c67694d08602f47e95 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/336440 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: John Stiles <johnstiles@google.com>
2020-11-18 20:38:39 +00:00
vec4 _1_0_blend_src_in;
Create golden outputs for SkSL blend functions. Several blend functions generate a surprisingly large amount of code, and appear to have opportunities for further optimization. At any rate, if we make compiler changes that would affect the output of a blend function, I think we would want to see the changes reflected in our golden outputs. Change-Id: Iff612dcd4bad8824b5e6e97413ffce19e5ea1c0e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/318336 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-21 21:01:22 +00:00
{
Stop cloning builtin functions Previously, any builtin functions would be optimized as a side-effect of optimizing programs that used them. Now that shared elements aren't being optimized in that way, we explicitly optimize any shared modules when they are first created. We don't remove dead elements, but we we do substitute settings, simplify, and inline. Bug: skia:10905 Change-Id: I701b5e9f52fb880ef3e6f4c67694d08602f47e95 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/336440 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: John Stiles <johnstiles@google.com>
2020-11-18 20:38:39 +00:00
_1_0_blend_src_in = dst * src.w;
Create golden outputs for SkSL blend functions. Several blend functions generate a surprisingly large amount of code, and appear to have opportunities for further optimization. At any rate, if we make compiler changes that would affect the output of a blend function, I think we would want to see the changes reflected in our golden outputs. Change-Id: Iff612dcd4bad8824b5e6e97413ffce19e5ea1c0e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/318336 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-21 21:01:22 +00:00
}
Stop cloning builtin functions Previously, any builtin functions would be optimized as a side-effect of optimizing programs that used them. Now that shared elements aren't being optimized in that way, we explicitly optimize any shared modules when they are first created. We don't remove dead elements, but we we do substitute settings, simplify, and inline. Bug: skia:10905 Change-Id: I701b5e9f52fb880ef3e6f4c67694d08602f47e95 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/336440 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: John Stiles <johnstiles@google.com>
2020-11-18 20:38:39 +00:00
_0_blend_dst_in = _1_0_blend_src_in;
Create golden outputs for SkSL blend functions. Several blend functions generate a surprisingly large amount of code, and appear to have opportunities for further optimization. At any rate, if we make compiler changes that would affect the output of a blend function, I think we would want to see the changes reflected in our golden outputs. Change-Id: Iff612dcd4bad8824b5e6e97413ffce19e5ea1c0e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/318336 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-21 21:01:22 +00:00
}
Revert "Reland "Remove inliner from IR generation stage."" This reverts commit e497a080651c05678cf4760fa6e4daa53a10355b. Reason for revert: Pinpoint disagrees Original change's description: > Reland "Remove inliner from IR generation stage." > > This reverts commit 941fc7174fc20e8a8b707f1b636c85bbf2e1294f. > > Reason for revert: performance now seems to be roughly equal or better > (~1%) over several trials. > Nanobench: http://screen/A8e8sojaXBgbMgF > > Original change's description: > > Revert "Remove inliner from IR generation stage." > > > > This reverts commit 21d7778cb5c13e729b513eaa22dbf53f58a877c8. > > > > Reason for revert: Pinpoint absolutely hates this change > > > > Original change's description: > > > Remove inliner from IR generation stage. > > > > > > There is no need to inline code during IR generation, as the optimizer > > > can now handle this. > > > > > > Change-Id: If272bfb98e945a75ec91fb4aa026e5631ac51b5b > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315971 > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > Commit-Queue: Brian Osman <brianosman@google.com> > > > Reviewed-by: Brian Osman <brianosman@google.com> > > > Auto-Submit: John Stiles <johnstiles@google.com> > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > Change-Id: I62c235415bcdc92a088e2a7f9c3d7dbf7e1bf669 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317976 > > Reviewed-by: John Stiles <johnstiles@google.com> > > Commit-Queue: John Stiles <johnstiles@google.com> > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > Change-Id: I6189806c678283188f4b67ee61e5886f88c2d6fc > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/324891 > Reviewed-by: John Stiles <johnstiles@google.com> > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > Auto-Submit: John Stiles <johnstiles@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I79149467565f22f53b8c28868dd53b80f3421137 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/325626 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-10-13 15:19:41 +00:00
sk_FragColor = _0_blend_dst_in;
Create golden outputs for SkSL blend functions. Several blend functions generate a surprisingly large amount of code, and appear to have opportunities for further optimization. At any rate, if we make compiler changes that would affect the output of a blend function, I think we would want to see the changes reflected in our golden outputs. Change-Id: Iff612dcd4bad8824b5e6e97413ffce19e5ea1c0e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/318336 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-21 21:01:22 +00:00
}
Reference in New Issue Copy Permalink