AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
2f13b32f79
skia2/tests/sksl/shared/InoutParamsAreDistinct.asm.frag

115 lines
3.8 KiB
GLSL
Raw Normal View History

Improve distinct-out-param test cases. Added new aliasing tests inspired by syoussefi@'s ANGLE changes at http://go/crrv/c/3561278. Change-Id: Ifa312faa9503b211b7c09edd2abd5087ead35e5f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/526018 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Arman Uguray <armansito@google.com> Commit-Queue: Arman Uguray <armansito@google.com>
2022-03-30 18:07:20 +00:00
OpCapability Shader
%1 = OpExtInstImport "GLSL.std.450"
OpMemoryModel Logical GLSL450
OpEntryPoint Fragment %_entrypoint_v "_entrypoint" %sk_FragColor %sk_Clockwise
OpExecutionMode %_entrypoint_v OriginUpperLeft
OpName %sk_FragColor "sk_FragColor"
OpName %sk_Clockwise "sk_Clockwise"
OpName %_UniformBuffer "_UniformBuffer"
OpMemberName %_UniformBuffer 0 "colorGreen"
OpMemberName %_UniformBuffer 1 "colorRed"
OpName %_entrypoint_v "_entrypoint_v"
OpName %inout_params_are_distinct_bhh "inout_params_are_distinct_bhh"
OpName %main "main"
OpName %x "x"
OpDecorate %sk_FragColor RelaxedPrecision
OpDecorate %sk_FragColor Location 0
OpDecorate %sk_FragColor Index 0
OpDecorate %sk_Clockwise BuiltIn FrontFacing
OpMemberDecorate %_UniformBuffer 0 Offset 0
OpMemberDecorate %_UniformBuffer 0 RelaxedPrecision
OpMemberDecorate %_UniformBuffer 1 Offset 16
OpMemberDecorate %_UniformBuffer 1 RelaxedPrecision
OpDecorate %_UniformBuffer Block
OpDecorate %11 Binding 0
OpDecorate %11 DescriptorSet 0
OpDecorate %x RelaxedPrecision
Optimize away self comparisons in SPIR-V. (This mirrors an optimization performed in the constant folder.) Expressions like `OpIEqual %20 %20` or `OpFUnordNotEqual %15 %15` can be replaced by `true` or `false` on sight. The GLSL spec makes it clear that checking for NaN is optional: 4.7.1 Range and Precision "... NaNs are not required to be generated. Support for signaling NaNs is not required and exceptions are never raised. Operations and built-in functions that operate on a NaN are not required to return a NaN as the result." Change-Id: I2e29b659a73582e9ade0eb61f70f7d362a007c50 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/531550 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2022-04-19 15:31:55 +00:00
OpDecorate %40 RelaxedPrecision
Eliminate redundant loads following stores. We now have two functions `writeOpLoad` and `writeOpStore` which are in charge of writing SpvOpLoad and SpvOpStore instructions. `writeOpStore` also keeps track of pointer stores in a "store cache." Subsequent loads from that same pointer will be found in the cache and will return the value stored in that pointer instead. Such a cache definitely cannot work in the face of control flow, so we make the following concessions: - `pruneReachableOps` is now `pruneConditionalOps`. Any pointers that are altered inside a potentially-unreachable block are cleared from the cache entirely. - The entire store cache is cleared at all OpLabels within a loop. The cache also cannot work in the presence of swizzled stores, so we make another significant concession: - The entire store cache is cleared whenever we store into a non-memory pointer (e.g., assigning into a swizzled LValue, such as `foo.xz`). Despite these significant limitations, this manages to dramatically shrink many real-world examples. Change-Id: I0981a0cf7b45b064e153e9ada271494c8e00cad5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/530054 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2022-04-18 14:57:14 +00:00
OpDecorate %41 RelaxedPrecision
Optimize away self comparisons in SPIR-V. (This mirrors an optimization performed in the constant folder.) Expressions like `OpIEqual %20 %20` or `OpFUnordNotEqual %15 %15` can be replaced by `true` or `false` on sight. The GLSL spec makes it clear that checking for NaN is optional: 4.7.1 Range and Precision "... NaNs are not required to be generated. Support for signaling NaNs is not required and exceptions are never raised. Operations and built-in functions that operate on a NaN are not required to return a NaN as the result." Change-Id: I2e29b659a73582e9ade0eb61f70f7d362a007c50 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/531550 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2022-04-19 15:31:55 +00:00
OpDecorate %43 RelaxedPrecision
Improve distinct-out-param test cases. Added new aliasing tests inspired by syoussefi@'s ANGLE changes at http://go/crrv/c/3561278. Change-Id: Ifa312faa9503b211b7c09edd2abd5087ead35e5f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/526018 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Arman Uguray <armansito@google.com> Commit-Queue: Arman Uguray <armansito@google.com>
2022-03-30 18:07:20 +00:00
OpDecorate %44 RelaxedPrecision
Optimize away self comparisons in SPIR-V. (This mirrors an optimization performed in the constant folder.) Expressions like `OpIEqual %20 %20` or `OpFUnordNotEqual %15 %15` can be replaced by `true` or `false` on sight. The GLSL spec makes it clear that checking for NaN is optional: 4.7.1 Range and Precision "... NaNs are not required to be generated. Support for signaling NaNs is not required and exceptions are never raised. Operations and built-in functions that operate on a NaN are not required to return a NaN as the result." Change-Id: I2e29b659a73582e9ade0eb61f70f7d362a007c50 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/531550 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2022-04-19 15:31:55 +00:00
OpDecorate %54 RelaxedPrecision
OpDecorate %57 RelaxedPrecision
Eliminate redundant loads following stores. We now have two functions `writeOpLoad` and `writeOpStore` which are in charge of writing SpvOpLoad and SpvOpStore instructions. `writeOpStore` also keeps track of pointer stores in a "store cache." Subsequent loads from that same pointer will be found in the cache and will return the value stored in that pointer instead. Such a cache definitely cannot work in the face of control flow, so we make the following concessions: - `pruneReachableOps` is now `pruneConditionalOps`. Any pointers that are altered inside a potentially-unreachable block are cleared from the cache entirely. - The entire store cache is cleared at all OpLabels within a loop. The cache also cannot work in the presence of swizzled stores, so we make another significant concession: - The entire store cache is cleared whenever we store into a non-memory pointer (e.g., assigning into a swizzled LValue, such as `foo.xz`). Despite these significant limitations, this manages to dramatically shrink many real-world examples. Change-Id: I0981a0cf7b45b064e153e9ada271494c8e00cad5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/530054 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2022-04-18 14:57:14 +00:00
OpDecorate %58 RelaxedPrecision
Improve distinct-out-param test cases. Added new aliasing tests inspired by syoussefi@'s ANGLE changes at http://go/crrv/c/3561278. Change-Id: Ifa312faa9503b211b7c09edd2abd5087ead35e5f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/526018 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Arman Uguray <armansito@google.com> Commit-Queue: Arman Uguray <armansito@google.com>
2022-03-30 18:07:20 +00:00
%float = OpTypeFloat 32
%v4float = OpTypeVector %float 4
%_ptr_Output_v4float = OpTypePointer Output %v4float
%sk_FragColor = OpVariable %_ptr_Output_v4float Output
%bool = OpTypeBool
%_ptr_Input_bool = OpTypePointer Input %bool
%sk_Clockwise = OpVariable %_ptr_Input_bool Input
%_UniformBuffer = OpTypeStruct %v4float %v4float
%_ptr_Uniform__UniformBuffer = OpTypePointer Uniform %_UniformBuffer
%11 = OpVariable %_ptr_Uniform__UniformBuffer Uniform
%void = OpTypeVoid
%16 = OpTypeFunction %void
%float_0 = OpConstant %float 0
Replace scalar/vector ID caches with op cache. The output changes here are almost entirely a wash, because we already had support for caching scalars and vectors. Almost all changes are just inconsequential reorderings of IDs, and the removal of RelaxedPrecision decorators on constants (which were not meaningful). Change-Id: I45340c4a240cb504b7c4a934b3db178d2f39ec99 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528709 Reviewed-by: Arman Uguray <armansito@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2022-04-12 21:02:43 +00:00
%v2float = OpTypeVector %float 2
Improve distinct-out-param test cases. Added new aliasing tests inspired by syoussefi@'s ANGLE changes at http://go/crrv/c/3561278. Change-Id: Ifa312faa9503b211b7c09edd2abd5087ead35e5f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/526018 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Arman Uguray <armansito@google.com> Commit-Queue: Arman Uguray <armansito@google.com>
2022-03-30 18:07:20 +00:00
%20 = OpConstantComposite %v2float %float_0 %float_0
%_ptr_Function_v2float = OpTypePointer Function %v2float
%_ptr_Function_float = OpTypePointer Function %float
Use op cache for pointer and function types. Previously, we stringized the types and put them into fTypeMap. Using the op cache is a simpler mechanism that should work equally well. Output diffs are almost all ID reorderings. In a few cases we managed to deduplicate function types that stringize differently but come out the same in SPIR-V (e.g. no float/half distinction). Change-Id: If7de5b2dafa12d05c3c2c497a243e9e3908dfee7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/529805 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2022-04-13 18:37:36 +00:00
%25 = OpTypeFunction %bool %_ptr_Function_float %_ptr_Function_float
Improve distinct-out-param test cases. Added new aliasing tests inspired by syoussefi@'s ANGLE changes at http://go/crrv/c/3561278. Change-Id: Ifa312faa9503b211b7c09edd2abd5087ead35e5f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/526018 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Arman Uguray <armansito@google.com> Commit-Queue: Arman Uguray <armansito@google.com>
2022-03-30 18:07:20 +00:00
%float_1 = OpConstant %float 1
%float_2 = OpConstant %float 2
%false = OpConstantFalse %bool
Optimize away self comparisons in SPIR-V. (This mirrors an optimization performed in the constant folder.) Expressions like `OpIEqual %20 %20` or `OpFUnordNotEqual %15 %15` can be replaced by `true` or `false` on sight. The GLSL spec makes it clear that checking for NaN is optional: 4.7.1 Range and Precision "... NaNs are not required to be generated. Support for signaling NaNs is not required and exceptions are never raised. Operations and built-in functions that operate on a NaN are not required to return a NaN as the result." Change-Id: I2e29b659a73582e9ade0eb61f70f7d362a007c50 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/531550 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2022-04-19 15:31:55 +00:00
%true = OpConstantTrue %bool
%36 = OpTypeFunction %v4float %_ptr_Function_v2float
Improve distinct-out-param test cases. Added new aliasing tests inspired by syoussefi@'s ANGLE changes at http://go/crrv/c/3561278. Change-Id: Ifa312faa9503b211b7c09edd2abd5087ead35e5f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/526018 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Arman Uguray <armansito@google.com> Commit-Queue: Arman Uguray <armansito@google.com>
2022-03-30 18:07:20 +00:00
%_ptr_Function_v4float = OpTypePointer Function %v4float
%_ptr_Uniform_v4float = OpTypePointer Uniform %v4float
%int = OpTypeInt 32 1
%int_0 = OpConstant %int 0
%int_1 = OpConstant %int 1
%_entrypoint_v = OpFunction %void None %16
%17 = OpLabel
%21 = OpVariable %_ptr_Function_v2float Function
OpStore %21 %20
%23 = OpFunctionCall %v4float %main %21
OpStore %sk_FragColor %23
OpReturn
OpFunctionEnd
Use op cache for pointer and function types. Previously, we stringized the types and put them into fTypeMap. Using the op cache is a simpler mechanism that should work equally well. Output diffs are almost all ID reorderings. In a few cases we managed to deduplicate function types that stringize differently but come out the same in SPIR-V (e.g. no float/half distinction). Change-Id: If7de5b2dafa12d05c3c2c497a243e9e3908dfee7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/529805 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2022-04-13 18:37:36 +00:00
%inout_params_are_distinct_bhh = OpFunction %bool None %25
Improve distinct-out-param test cases. Added new aliasing tests inspired by syoussefi@'s ANGLE changes at http://go/crrv/c/3561278. Change-Id: Ifa312faa9503b211b7c09edd2abd5087ead35e5f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/526018 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Arman Uguray <armansito@google.com> Commit-Queue: Arman Uguray <armansito@google.com>
2022-03-30 18:07:20 +00:00
%26 = OpFunctionParameter %_ptr_Function_float
%27 = OpFunctionParameter %_ptr_Function_float
%28 = OpLabel
OpStore %26 %float_1
OpStore %27 %float_2
Eliminate redundant loads following stores. We now have two functions `writeOpLoad` and `writeOpStore` which are in charge of writing SpvOpLoad and SpvOpStore instructions. `writeOpStore` also keeps track of pointer stores in a "store cache." Subsequent loads from that same pointer will be found in the cache and will return the value stored in that pointer instead. Such a cache definitely cannot work in the face of control flow, so we make the following concessions: - `pruneReachableOps` is now `pruneConditionalOps`. Any pointers that are altered inside a potentially-unreachable block are cleared from the cache entirely. - The entire store cache is cleared at all OpLabels within a loop. The cache also cannot work in the presence of swizzled stores, so we make another significant concession: - The entire store cache is cleared whenever we store into a non-memory pointer (e.g., assigning into a swizzled LValue, such as `foo.xz`). Despite these significant limitations, this manages to dramatically shrink many real-world examples. Change-Id: I0981a0cf7b45b064e153e9ada271494c8e00cad5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/530054 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2022-04-18 14:57:14 +00:00
OpSelectionMerge %34 None
Optimize away self comparisons in SPIR-V. (This mirrors an optimization performed in the constant folder.) Expressions like `OpIEqual %20 %20` or `OpFUnordNotEqual %15 %15` can be replaced by `true` or `false` on sight. The GLSL spec makes it clear that checking for NaN is optional: 4.7.1 Range and Precision "... NaNs are not required to be generated. Support for signaling NaNs is not required and exceptions are never raised. Operations and built-in functions that operate on a NaN are not required to return a NaN as the result." Change-Id: I2e29b659a73582e9ade0eb61f70f7d362a007c50 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/531550 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2022-04-19 15:31:55 +00:00
OpBranchConditional %true %33 %34
Eliminate redundant loads following stores. We now have two functions `writeOpLoad` and `writeOpStore` which are in charge of writing SpvOpLoad and SpvOpStore instructions. `writeOpStore` also keeps track of pointer stores in a "store cache." Subsequent loads from that same pointer will be found in the cache and will return the value stored in that pointer instead. Such a cache definitely cannot work in the face of control flow, so we make the following concessions: - `pruneReachableOps` is now `pruneConditionalOps`. Any pointers that are altered inside a potentially-unreachable block are cleared from the cache entirely. - The entire store cache is cleared at all OpLabels within a loop. The cache also cannot work in the presence of swizzled stores, so we make another significant concession: - The entire store cache is cleared whenever we store into a non-memory pointer (e.g., assigning into a swizzled LValue, such as `foo.xz`). Despite these significant limitations, this manages to dramatically shrink many real-world examples. Change-Id: I0981a0cf7b45b064e153e9ada271494c8e00cad5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/530054 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2022-04-18 14:57:14 +00:00
%33 = OpLabel
OpBranch %34
Improve distinct-out-param test cases. Added new aliasing tests inspired by syoussefi@'s ANGLE changes at http://go/crrv/c/3561278. Change-Id: Ifa312faa9503b211b7c09edd2abd5087ead35e5f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/526018 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Arman Uguray <armansito@google.com> Commit-Queue: Arman Uguray <armansito@google.com>
2022-03-30 18:07:20 +00:00
%34 = OpLabel
Optimize away self comparisons in SPIR-V. (This mirrors an optimization performed in the constant folder.) Expressions like `OpIEqual %20 %20` or `OpFUnordNotEqual %15 %15` can be replaced by `true` or `false` on sight. The GLSL spec makes it clear that checking for NaN is optional: 4.7.1 Range and Precision "... NaNs are not required to be generated. Support for signaling NaNs is not required and exceptions are never raised. Operations and built-in functions that operate on a NaN are not required to return a NaN as the result." Change-Id: I2e29b659a73582e9ade0eb61f70f7d362a007c50 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/531550 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2022-04-19 15:31:55 +00:00
%35 = OpPhi %bool %false %28 %true %33
OpReturnValue %35
Improve distinct-out-param test cases. Added new aliasing tests inspired by syoussefi@'s ANGLE changes at http://go/crrv/c/3561278. Change-Id: Ifa312faa9503b211b7c09edd2abd5087ead35e5f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/526018 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Arman Uguray <armansito@google.com> Commit-Queue: Arman Uguray <armansito@google.com>
2022-03-30 18:07:20 +00:00
OpFunctionEnd
Optimize away self comparisons in SPIR-V. (This mirrors an optimization performed in the constant folder.) Expressions like `OpIEqual %20 %20` or `OpFUnordNotEqual %15 %15` can be replaced by `true` or `false` on sight. The GLSL spec makes it clear that checking for NaN is optional: 4.7.1 Range and Precision "... NaNs are not required to be generated. Support for signaling NaNs is not required and exceptions are never raised. Operations and built-in functions that operate on a NaN are not required to return a NaN as the result." Change-Id: I2e29b659a73582e9ade0eb61f70f7d362a007c50 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/531550 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2022-04-19 15:31:55 +00:00
%main = OpFunction %v4float None %36
%37 = OpFunctionParameter %_ptr_Function_v2float
%38 = OpLabel
Improve distinct-out-param test cases. Added new aliasing tests inspired by syoussefi@'s ANGLE changes at http://go/crrv/c/3561278. Change-Id: Ifa312faa9503b211b7c09edd2abd5087ead35e5f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/526018 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Arman Uguray <armansito@google.com> Commit-Queue: Arman Uguray <armansito@google.com>
2022-03-30 18:07:20 +00:00
%x = OpVariable %_ptr_Function_float Function
Optimize away self comparisons in SPIR-V. (This mirrors an optimization performed in the constant folder.) Expressions like `OpIEqual %20 %20` or `OpFUnordNotEqual %15 %15` can be replaced by `true` or `false` on sight. The GLSL spec makes it clear that checking for NaN is optional: 4.7.1 Range and Precision "... NaNs are not required to be generated. Support for signaling NaNs is not required and exceptions are never raised. Operations and built-in functions that operate on a NaN are not required to return a NaN as the result." Change-Id: I2e29b659a73582e9ade0eb61f70f7d362a007c50 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/531550 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2022-04-19 15:31:55 +00:00
%40 = OpVariable %_ptr_Function_float Function
Eliminate redundant loads following stores. We now have two functions `writeOpLoad` and `writeOpStore` which are in charge of writing SpvOpLoad and SpvOpStore instructions. `writeOpStore` also keeps track of pointer stores in a "store cache." Subsequent loads from that same pointer will be found in the cache and will return the value stored in that pointer instead. Such a cache definitely cannot work in the face of control flow, so we make the following concessions: - `pruneReachableOps` is now `pruneConditionalOps`. Any pointers that are altered inside a potentially-unreachable block are cleared from the cache entirely. - The entire store cache is cleared at all OpLabels within a loop. The cache also cannot work in the presence of swizzled stores, so we make another significant concession: - The entire store cache is cleared whenever we store into a non-memory pointer (e.g., assigning into a swizzled LValue, such as `foo.xz`). Despite these significant limitations, this manages to dramatically shrink many real-world examples. Change-Id: I0981a0cf7b45b064e153e9ada271494c8e00cad5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/530054 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2022-04-18 14:57:14 +00:00
%41 = OpVariable %_ptr_Function_float Function
Optimize away self comparisons in SPIR-V. (This mirrors an optimization performed in the constant folder.) Expressions like `OpIEqual %20 %20` or `OpFUnordNotEqual %15 %15` can be replaced by `true` or `false` on sight. The GLSL spec makes it clear that checking for NaN is optional: 4.7.1 Range and Precision "... NaNs are not required to be generated. Support for signaling NaNs is not required and exceptions are never raised. Operations and built-in functions that operate on a NaN are not required to return a NaN as the result." Change-Id: I2e29b659a73582e9ade0eb61f70f7d362a007c50 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/531550 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2022-04-19 15:31:55 +00:00
%45 = OpVariable %_ptr_Function_v4float Function
Improve distinct-out-param test cases. Added new aliasing tests inspired by syoussefi@'s ANGLE changes at http://go/crrv/c/3561278. Change-Id: Ifa312faa9503b211b7c09edd2abd5087ead35e5f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/526018 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Arman Uguray <armansito@google.com> Commit-Queue: Arman Uguray <armansito@google.com>
2022-03-30 18:07:20 +00:00
OpStore %x %float_0
Optimize away self comparisons in SPIR-V. (This mirrors an optimization performed in the constant folder.) Expressions like `OpIEqual %20 %20` or `OpFUnordNotEqual %15 %15` can be replaced by `true` or `false` on sight. The GLSL spec makes it clear that checking for NaN is optional: 4.7.1 Range and Precision "... NaNs are not required to be generated. Support for signaling NaNs is not required and exceptions are never raised. Operations and built-in functions that operate on a NaN are not required to return a NaN as the result." Change-Id: I2e29b659a73582e9ade0eb61f70f7d362a007c50 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/531550 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2022-04-19 15:31:55 +00:00
OpStore %40 %float_0
Eliminate redundant loads following stores. We now have two functions `writeOpLoad` and `writeOpStore` which are in charge of writing SpvOpLoad and SpvOpStore instructions. `writeOpStore` also keeps track of pointer stores in a "store cache." Subsequent loads from that same pointer will be found in the cache and will return the value stored in that pointer instead. Such a cache definitely cannot work in the face of control flow, so we make the following concessions: - `pruneReachableOps` is now `pruneConditionalOps`. Any pointers that are altered inside a potentially-unreachable block are cleared from the cache entirely. - The entire store cache is cleared at all OpLabels within a loop. The cache also cannot work in the presence of swizzled stores, so we make another significant concession: - The entire store cache is cleared whenever we store into a non-memory pointer (e.g., assigning into a swizzled LValue, such as `foo.xz`). Despite these significant limitations, this manages to dramatically shrink many real-world examples. Change-Id: I0981a0cf7b45b064e153e9ada271494c8e00cad5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/530054 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2022-04-18 14:57:14 +00:00
OpStore %41 %float_0
Optimize away self comparisons in SPIR-V. (This mirrors an optimization performed in the constant folder.) Expressions like `OpIEqual %20 %20` or `OpFUnordNotEqual %15 %15` can be replaced by `true` or `false` on sight. The GLSL spec makes it clear that checking for NaN is optional: 4.7.1 Range and Precision "... NaNs are not required to be generated. Support for signaling NaNs is not required and exceptions are never raised. Operations and built-in functions that operate on a NaN are not required to return a NaN as the result." Change-Id: I2e29b659a73582e9ade0eb61f70f7d362a007c50 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/531550 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2022-04-19 15:31:55 +00:00
%42 = OpFunctionCall %bool %inout_params_are_distinct_bhh %40 %41
%43 = OpLoad %float %40
OpStore %x %43
Eliminate redundant loads following stores. We now have two functions `writeOpLoad` and `writeOpStore` which are in charge of writing SpvOpLoad and SpvOpStore instructions. `writeOpStore` also keeps track of pointer stores in a "store cache." Subsequent loads from that same pointer will be found in the cache and will return the value stored in that pointer instead. Such a cache definitely cannot work in the face of control flow, so we make the following concessions: - `pruneReachableOps` is now `pruneConditionalOps`. Any pointers that are altered inside a potentially-unreachable block are cleared from the cache entirely. - The entire store cache is cleared at all OpLabels within a loop. The cache also cannot work in the presence of swizzled stores, so we make another significant concession: - The entire store cache is cleared whenever we store into a non-memory pointer (e.g., assigning into a swizzled LValue, such as `foo.xz`). Despite these significant limitations, this manages to dramatically shrink many real-world examples. Change-Id: I0981a0cf7b45b064e153e9ada271494c8e00cad5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/530054 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2022-04-18 14:57:14 +00:00
%44 = OpLoad %float %41
OpStore %x %44
Optimize away self comparisons in SPIR-V. (This mirrors an optimization performed in the constant folder.) Expressions like `OpIEqual %20 %20` or `OpFUnordNotEqual %15 %15` can be replaced by `true` or `false` on sight. The GLSL spec makes it clear that checking for NaN is optional: 4.7.1 Range and Precision "... NaNs are not required to be generated. Support for signaling NaNs is not required and exceptions are never raised. Operations and built-in functions that operate on a NaN are not required to return a NaN as the result." Change-Id: I2e29b659a73582e9ade0eb61f70f7d362a007c50 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/531550 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2022-04-19 15:31:55 +00:00
OpSelectionMerge %49 None
OpBranchConditional %42 %47 %48
%47 = OpLabel
%50 = OpAccessChain %_ptr_Uniform_v4float %11 %int_0
%54 = OpLoad %v4float %50
OpStore %45 %54
OpBranch %49
Eliminate redundant loads following stores. We now have two functions `writeOpLoad` and `writeOpStore` which are in charge of writing SpvOpLoad and SpvOpStore instructions. `writeOpStore` also keeps track of pointer stores in a "store cache." Subsequent loads from that same pointer will be found in the cache and will return the value stored in that pointer instead. Such a cache definitely cannot work in the face of control flow, so we make the following concessions: - `pruneReachableOps` is now `pruneConditionalOps`. Any pointers that are altered inside a potentially-unreachable block are cleared from the cache entirely. - The entire store cache is cleared at all OpLabels within a loop. The cache also cannot work in the presence of swizzled stores, so we make another significant concession: - The entire store cache is cleared whenever we store into a non-memory pointer (e.g., assigning into a swizzled LValue, such as `foo.xz`). Despite these significant limitations, this manages to dramatically shrink many real-world examples. Change-Id: I0981a0cf7b45b064e153e9ada271494c8e00cad5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/530054 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2022-04-18 14:57:14 +00:00
%48 = OpLabel
Optimize away self comparisons in SPIR-V. (This mirrors an optimization performed in the constant folder.) Expressions like `OpIEqual %20 %20` or `OpFUnordNotEqual %15 %15` can be replaced by `true` or `false` on sight. The GLSL spec makes it clear that checking for NaN is optional: 4.7.1 Range and Precision "... NaNs are not required to be generated. Support for signaling NaNs is not required and exceptions are never raised. Operations and built-in functions that operate on a NaN are not required to return a NaN as the result." Change-Id: I2e29b659a73582e9ade0eb61f70f7d362a007c50 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/531550 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2022-04-19 15:31:55 +00:00
%55 = OpAccessChain %_ptr_Uniform_v4float %11 %int_1
%57 = OpLoad %v4float %55
OpStore %45 %57
OpBranch %49
Eliminate redundant loads following stores. We now have two functions `writeOpLoad` and `writeOpStore` which are in charge of writing SpvOpLoad and SpvOpStore instructions. `writeOpStore` also keeps track of pointer stores in a "store cache." Subsequent loads from that same pointer will be found in the cache and will return the value stored in that pointer instead. Such a cache definitely cannot work in the face of control flow, so we make the following concessions: - `pruneReachableOps` is now `pruneConditionalOps`. Any pointers that are altered inside a potentially-unreachable block are cleared from the cache entirely. - The entire store cache is cleared at all OpLabels within a loop. The cache also cannot work in the presence of swizzled stores, so we make another significant concession: - The entire store cache is cleared whenever we store into a non-memory pointer (e.g., assigning into a swizzled LValue, such as `foo.xz`). Despite these significant limitations, this manages to dramatically shrink many real-world examples. Change-Id: I0981a0cf7b45b064e153e9ada271494c8e00cad5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/530054 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2022-04-18 14:57:14 +00:00
%49 = OpLabel
Optimize away self comparisons in SPIR-V. (This mirrors an optimization performed in the constant folder.) Expressions like `OpIEqual %20 %20` or `OpFUnordNotEqual %15 %15` can be replaced by `true` or `false` on sight. The GLSL spec makes it clear that checking for NaN is optional: 4.7.1 Range and Precision "... NaNs are not required to be generated. Support for signaling NaNs is not required and exceptions are never raised. Operations and built-in functions that operate on a NaN are not required to return a NaN as the result." Change-Id: I2e29b659a73582e9ade0eb61f70f7d362a007c50 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/531550 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2022-04-19 15:31:55 +00:00
%58 = OpLoad %v4float %45
OpReturnValue %58
Improve distinct-out-param test cases. Added new aliasing tests inspired by syoussefi@'s ANGLE changes at http://go/crrv/c/3561278. Change-Id: Ifa312faa9503b211b7c09edd2abd5087ead35e5f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/526018 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Arman Uguray <armansito@google.com> Commit-Queue: Arman Uguray <armansito@google.com>
2022-03-30 18:07:20 +00:00
OpFunctionEnd
Reference in New Issue Copy Permalink