AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
3215385aeb
skia2/gm/skbug1719.cpp

74 lines
2.9 KiB
C++
Raw Normal View History

detach blur result texture when it is the same texture used to render path mask R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/26968006 git-svn-id: http://skia.googlecode.com/svn/trunk@11805 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-16 13:53:54 +00:00
/*
* Copyright 2013 Google Inc.
*
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file.
*/
rewrite includes to not need so much -Ifoo Current strategy: everything from the top Things to look at first are the manual changes: - added tools/rewrite_includes.py - removed -Idirectives from BUILD.gn - various compile.sh simplifications - tweak tools/embed_resources.py - update gn/find_headers.py to write paths from the top - update gn/gn_to_bp.py SkUserConfig.h layout so that #include "include/config/SkUserConfig.h" always gets the header we want. No-Presubmit: true Change-Id: I73a4b181654e0e38d229bc456c0d0854bae3363e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/209706 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Hal Canary <halcanary@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
2019-04-23 17:05:21 +00:00
#include "gm/gm.h"
IWYU for gms. This almost gets gms to be iwyu clean. The last bit is around gm.cpp and the tracing framework and its use of atomic. Will also need a way of keeping things from regressing, which is difficult due to needing to do this outside-in. Change-Id: I1393531e99da8b0f1a29f55c53c86d53f459af7d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211593 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
2019-05-01 21:28:53 +00:00
#include "include/core/SkBlendMode.h"
#include "include/core/SkBlurTypes.h"
#include "include/core/SkCanvas.h"
rewrite includes to not need so much -Ifoo Current strategy: everything from the top Things to look at first are the manual changes: - added tools/rewrite_includes.py - removed -Idirectives from BUILD.gn - various compile.sh simplifications - tweak tools/embed_resources.py - update gn/find_headers.py to write paths from the top - update gn/gn_to_bp.py SkUserConfig.h layout so that #include "include/config/SkUserConfig.h" always gets the header we want. No-Presubmit: true Change-Id: I73a4b181654e0e38d229bc456c0d0854bae3363e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/209706 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Hal Canary <halcanary@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
2019-04-23 17:05:21 +00:00
#include "include/core/SkColorFilter.h"
#include "include/core/SkMaskFilter.h"
IWYU for gms. This almost gets gms to be iwyu clean. The last bit is around gm.cpp and the tracing framework and its use of atomic. Will also need a way of keeping things from regressing, which is difficult due to needing to do this outside-in. Change-Id: I1393531e99da8b0f1a29f55c53c86d53f459af7d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211593 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
2019-05-01 21:28:53 +00:00
#include "include/core/SkPaint.h"
rewrite includes to not need so much -Ifoo Current strategy: everything from the top Things to look at first are the manual changes: - added tools/rewrite_includes.py - removed -Idirectives from BUILD.gn - various compile.sh simplifications - tweak tools/embed_resources.py - update gn/find_headers.py to write paths from the top - update gn/gn_to_bp.py SkUserConfig.h layout so that #include "include/config/SkUserConfig.h" always gets the header we want. No-Presubmit: true Change-Id: I73a4b181654e0e38d229bc456c0d0854bae3363e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/209706 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Hal Canary <halcanary@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
2019-04-23 17:05:21 +00:00
#include "include/core/SkPath.h"
IWYU for gms. This almost gets gms to be iwyu clean. The last bit is around gm.cpp and the tracing framework and its use of atomic. Will also need a way of keeping things from regressing, which is difficult due to needing to do this outside-in. Change-Id: I1393531e99da8b0f1a29f55c53c86d53f459af7d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211593 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
2019-05-01 21:28:53 +00:00
#include "include/core/SkScalar.h"
detach blur result texture when it is the same texture used to render path mask R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/26968006 git-svn-id: http://skia.googlecode.com/svn/trunk@11805 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-16 13:53:54 +00:00
/**
* This test exercises bug 1719. An anti-aliased blurred path is rendered through a soft clip. On
* the GPU a scratch texture was used to hold the original path mask as well as the blurred path
* result. The same texture is then incorrectly used to generate the soft clip mask for the draw.
* Thus the same texture is used for both the blur mask and soft mask in a single draw.
*
* The correct image should look like a thin stroked round rect.
*/
don't adapt any gray colors to 565 Adapting gray to 565 will add a noticeable purple/green tint. I'd rather only the 565 images in Gold were tainted with that. Change-Id: Ib09e92b2f78c6de086345124e9eefeb31bbb5fa8 Reviewed-on: https://skia-review.googlesource.com/147422 Commit-Queue: Mike Klein <mtklein@google.com> Auto-Submit: Mike Klein <mtklein@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2018-08-16 14:17:03 +00:00
DEF_SIMPLE_GM_BG(skbug1719, canvas, 300, 100, 0xFF303030) {
detach blur result texture when it is the same texture used to render path mask R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/26968006 git-svn-id: http://skia.googlecode.com/svn/trunk@11805 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-16 13:53:54 +00:00
canvas->translate(SkIntToScalar(-800), SkIntToScalar(-650));
// The data is lifted from an SKP that exhibited the bug.
// This is a round rect.
SkPath clipPath;
clipPath.moveTo(832.f, 654.f);
clipPath.lineTo(1034.f, 654.f);
clipPath.cubicTo(1038.4183f, 654.f, 1042.f, 657.58173f, 1042.f, 662.f);
clipPath.lineTo(1042.f, 724.f);
clipPath.cubicTo(1042.f, 728.41827f, 1038.4183f, 732.f, 1034.f, 732.f);
clipPath.lineTo(832.f, 732.f);
clipPath.cubicTo(827.58173f, 732.f, 824.f, 728.41827f, 824.f, 724.f);
clipPath.lineTo(824.f, 662.f);
clipPath.cubicTo(824.f, 657.58173f, 827.58173f, 654.f, 832.f, 654.f);
clipPath.close();
// This is a round rect nested inside a rect.
SkPath drawPath;
drawPath.moveTo(823.f, 653.f);
drawPath.lineTo(1043.f, 653.f);
drawPath.lineTo(1043.f, 733.f);
drawPath.lineTo(823.f, 733.f);
drawPath.lineTo(823.f, 653.f);
drawPath.close();
drawPath.moveTo(832.f, 654.f);
drawPath.lineTo(1034.f, 654.f);
drawPath.cubicTo(1038.4183f, 654.f, 1042.f, 657.58173f, 1042.f, 662.f);
drawPath.lineTo(1042.f, 724.f);
drawPath.cubicTo(1042.f, 728.41827f, 1038.4183f, 732.f, 1034.f, 732.f);
drawPath.lineTo(832.f, 732.f);
drawPath.cubicTo(827.58173f, 732.f, 824.f, 728.41827f, 824.f, 724.f);
drawPath.lineTo(824.f, 662.f);
drawPath.cubicTo(824.f, 657.58173f, 827.58173f, 654.f, 832.f, 654.f);
drawPath.close();
Revert "Revert "switch to new filltype for SkPath"" This reverts commit 3e7af41224eecf8393f3cdc08c4c9800b2321c20. Change-Id: Id4f66b3956f4bdbe690db20fc478b7365ee89717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/256676 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com> Auto-Submit: Mike Reed <reed@google.com>
2019-11-26 17:17:17 +00:00
drawPath.setFillType(SkPathFillType::kEvenOdd);
detach blur result texture when it is the same texture used to render path mask R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/26968006 git-svn-id: http://skia.googlecode.com/svn/trunk@11805 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-16 13:53:54 +00:00
SkPaint paint;
paint.setAntiAlias(true);
paint.setColor(0xFF000000);
paint.setMaskFilter(
hide SkBlurMaskFilter and SkBlurQuality SK_SUPPORT_LEGACY_BLURMASKFILTER Bug: skia: Change-Id: Ic3e27e08e6e3cd2ffc1cd13b044e197bebc96236 Reviewed-on: https://skia-review.googlesource.com/113940 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
2018-03-14 17:01:17 +00:00
SkMaskFilter::MakeBlur(kNormal_SkBlurStyle, 0.78867501f));
Introduce new factory for SkColorFilters Idea: transition callers to this, so we can later typedef SkColorFilter and SkShader to the same thing. Bug: skia:8937 Change-Id: I000c882e11622091aa44c141aa6ddd1216414f46 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/206685 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Reed <reed@google.com>
2019-04-08 20:23:20 +00:00
paint.setColorFilter(SkColorFilters::Blend(0xBFFFFFFF, SkBlendMode::kSrcIn));
detach blur result texture when it is the same texture used to render path mask R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/26968006 git-svn-id: http://skia.googlecode.com/svn/trunk@11805 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-16 13:53:54 +00:00
allow clip calls w/o op param, remove unnecessary kReplace ops BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357333002 Review-Url: https://codereview.chromium.org/2357333002
2016-09-21 18:15:07 +00:00
canvas->clipPath(clipPath, true);
detach blur result texture when it is the same texture used to render path mask R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/26968006 git-svn-id: http://skia.googlecode.com/svn/trunk@11805 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-10-16 13:53:54 +00:00
canvas->drawPath(drawPath, paint);
}
Reference in New Issue Copy Permalink