AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
60c5837632
skia2/gn/tests.gni

441 lines
14 KiB
Plaintext
Raw Normal View History

Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
# Copyright 2016 Google Inc.
#
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
# Things are easiest for everyone if these source paths are absolute.
_tests = get_path_info("../tests", "abspath")
tests_sources = [
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/AAClipTest.cpp",
Enforce non-overlap constraint from GrRenderTargetOpList Enforces this constraint from one central location, rather than relying on each Op to remember to check if overlap is allowed from its onCombineIfPossible method. Fixes an issue where we need to check the total bounds of both chains for overlap (not the bounds of individual Ops). Bug: skia:8671 Change-Id: I163651c868847884459acfc00d13ffdfca3a27c3 Reviewed-on: https://skia-review.googlesource.com/c/185815 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-01-23 16:10:36 +00:00
"$_tests/AdvancedBlendTest.cpp",
Add SkAndroidCodec::computeSampledSize Bug: b/63909536 Android's ImageDecoder API takes as input an arbitrary width and height to scale the image to. Internally, this uses SkAndroidCodec to sample, and then (if not a perfect match) scales to the desired size with drawing. computeSampledSize is a modified version of what ImageDecoder currently does to convert from arbitrary dimensions to a sampleSize. Moving it here allows it to be shared by SkAnimatedImage. The modified version also corrects two bugs: - a client using the dimensions returned by getSampledDimensions previously may have resulted in ImageDecoder decoding to a larger size and then scaling it. (example found in tests: dog.jpg is 180 x 180. getSampledDimensions(8) returns 23 x 23, but the old method resulted in using sampleSize of 7 and downscaling the resulting 25 x 25 image.) - recompute the sampleSize based on the size returned by getSampledDimensions. Change-Id: I022040e8bac31c20988903a0452257f7ae902bc7 Reviewed-on: https://skia-review.googlesource.com/94620 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
2018-01-16 20:01:17 +00:00
"$_tests/AndroidCodecTest.cpp",
Respect repetition count in SkAnimatedImage Bug: b/63908092 By default use the repetition count stored in the encoded data (if any). Allow setting the repetition count manually, so that the animation will stop after n+1 total cycles (unless -1 is used for infinite). If the animation is complete, make start reset it. When the animation is not running, make update return max double (i.e. no need to update any time soon). Fix a bug where the first call to update returned -1. Share write_bm with CodecAnimTest, for debugging. Update Sample to check isRunning rather than keeping its own record of whether the animation is running. Change-Id: I883e4d7325f7a7b23a422fa9d756f9ea3018f0f8 Reviewed-on: https://skia-review.googlesource.com/97082 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
2018-01-20 15:33:24 +00:00
"$_tests/AnimatedImageTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/AnnotationTest.cpp",
"$_tests/ApplyGammaTest.cpp",
Remove SkFallbackAlloc and SkFixedAlloc. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug-ASAN;skia.primary:Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug-MSAN TBR=reed@google.com Change-Id: I1000dc9ed8ad65b249798759d9af99f47fc237d2 Reviewed-on: https://skia-review.googlesource.com/6809 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
2017-01-13 22:34:33 +00:00
"$_tests/ArenaAllocTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/AsADashTest.cpp",
Move SkBitmapRegionCodec into client_utils/android Bug: skia:10154 This will make it clear that these files are for Android use and avoid compiling them for other clients. Update testing tools to use android::skia::BitmapRegionDecoder, but only if SK_ENABLE_ANDROID_UTILS is defined. Take this opportunity to clean up the class: - The base class, which was originally designed to allow switching amongst different implementations, is no longer needed. Rename SkBitmapRegionCodec to android::skia::BitmapRegionDecoder (following the new convention and matching the Java API name). Continue to inherit from SkBitmapRegionDecoder temporarily, to allow Android to switch to the new API. - Use std::unique_ptr instead of passing raw pointers. Add a test to verify that we only create a BitmapRegionDecoder if it is one of the supported types. Change-Id: Ied13fc8acb105fde042553331846d95ae15d6b57 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/287498 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com>
2020-05-04 14:02:45 +00:00
"$_tests/BRDTest.cpp",
Revert "Revert "Revert "Revert "Don't build GL on Metal, Vulkan, Dawn, Direct3D bots"""" Updated to use sentinel GL context even when GL backend is not built. This reverts commit 1171d314efc7e131b039c94126d26575cfb9e70c. Change-Id: Ia94bbe4865ddd4e898446c13886877c539f0eb0b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/277976 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-03-19 19:54:28 +00:00
"$_tests/BackendAllocationTest.cpp",
Add GrBackendMutableState object to handle shared texture state. This is will be the main struct used to synchronize changes of certain texture/image between clients and Skia. With this change we implement support for the Vulkan shared state as POC. Bug: skia:10254 Change-Id: I10543357635c347838b193874e4da4496a0dcf06 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/292311 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-05-29 16:11:05 +00:00
"$_tests/BackendSurfaceMutableStateTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/BadIcoTest.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/BitSetTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/BitmapCopyTest.cpp",
"$_tests/BitmapGetColorTest.cpp",
"$_tests/BitmapTest.cpp",
"$_tests/BlendTest.cpp",
"$_tests/BlitMaskClip.cpp",
"$_tests/BlurTest.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/CTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/CachedDataTest.cpp",
"$_tests/CachedDecodingPixelRefTest.cpp",
"$_tests/CanvasStateHelpers.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/CanvasStateHelpers.h",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/CanvasStateTest.cpp",
"$_tests/CanvasTest.cpp",
"$_tests/ChecksumTest.cpp",
"$_tests/ClipCubicTest.cpp",
"$_tests/ClipStackTest.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/ClipperTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/CodecAnimTest.cpp",
Reland "Make SkPngCodec only read as much of the stream as necessary" (Originally uploaded as 13900.) Previously, SkPngCodec assumed that the stream only contained one image, which ended at the end of the stream. It read the stream in arbitrarily-sized chunks, and then passed that data to libpng for processing. If a stream contains more than one image, this may result in reading beyond the end of the image, making future reads read the wrong data. Now, SkPngCodec starts by reading 8 bytes at a time. After the signature, 8 bytes is enough to know which chunk is next and how many bytes are in the chunk. When decoding the size, we stop when we reach IDAT, and when decoding the image, we stop when we reach IEND. This manual parsing is necessary to support APNG, which is planned in the future. It also allows us to remove the SK_GOOGLE3_PNG_HACK, which was a workaround for reading more than necessary at the beginning of the image. Add a test that simulates the issue, by decoding a special stream that reports an error if the codec attempts to read beyond the end. Temporarily disable the partial decoding tests for png. A larger change will be necessary to get those working again, and no clients are currently relying on incrementally decoding PNGs (i.e. decode part of an image, then decode further with more data). Include a workaround for older versions of libpng (e.g. 1.2 in Google3). In older versions, if the row callback is null when the IDAT header is processed, reading the image will fail. When we see the IDAT, we save the length and process a recreated IDAT header later, after the row callback has been set. Bug: skia:5368 Bug:b/34073812 Test: Existing tests, plus a new test in dm. Change-Id: I293a4ddc013b82669a8b735062228b26d0bce933 Reviewed-on: https://skia-review.googlesource.com/13984 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Matt Sarett <msarett@google.com>
2017-04-21 17:47:12 +00:00
"$_tests/CodecExactReadTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/CodecPartialTest.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/CodecPriv.h",
Reland "Hide SkEncodedInfo" This partially reverts commit 1793e7bb46c1f9d430c1a699a1c3d3168159b659. Hide SkEncodedInfo Bug: skia:7353 Bug: skia:6839 This contains information that is not necessary for clients to know. The Color enum tells the number of components in the input, but this is only interesting internally (to the SkSwizzler). Similarly, the Alpha enum differs from SkAlphaType in that it has kBinary instead of kPremul. This is useful information only internally for determining whether the SkColorSpaceXform needs to premultiply. The bitsPerComponent is potentially useful for a client; Android (in SkAndroidCodec) uses it to determine the SkColorType. Rather than exposing bitsPerComponent, make SkAndroidCodec a friend so it can access the SkEncodedInfo. A future change will change SkCodec to recommend F16 for bitsPerComponent > 8, but that will be more involved; it was the reason for the revert of this CL. Switch conversionSupported to use an SkColorType, which is enough info. Replace the SkEncodedInfo::Alpha field on SkCodec::FrameInfo with an SkAlphaType. SkCodec still needs an SkEncodedInfo, so move its header (which is already not SK_API) to include/private. TBR=mtklein@chromium.org,reed@google.com Change-Id: I928b1f55317602cb37d29da63b53026c8d139cee Reviewed-on: https://skia-review.googlesource.com/80860 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
2017-12-05 18:55:24 +00:00
"$_tests/CodecRecommendedTypeTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/CodecTest.cpp",
"$_tests/ColorFilterTest.cpp",
"$_tests/ColorMatrixTest.cpp",
"$_tests/ColorPrivTest.cpp",
"$_tests/ColorSpaceTest.cpp",
"$_tests/ColorTest.cpp",
Revert "Revert "Revert "Revert "Don't build GL on Metal, Vulkan, Dawn, Direct3D bots"""" Updated to use sentinel GL context even when GL backend is not built. This reverts commit 1171d314efc7e131b039c94126d26575cfb9e70c. Change-Id: Ia94bbe4865ddd4e898446c13886877c539f0eb0b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/277976 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-03-19 19:54:28 +00:00
"$_tests/CompressedBackendAllocationTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/CopySurfaceTest.cpp",
add tests for cubicmap check for some special cases: - degenerate or simple cubic - 0/0 Bug: skia: Change-Id: Ie978caf9d862755d9693768695bf84eff9ec80e4 Reviewed-on: https://skia-review.googlesource.com/147112 Commit-Queue: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Auto-Submit: Mike Reed <reed@google.com>
2018-08-14 21:21:23 +00:00
"$_tests/CubicMapTest.cpp",
Add a GrCullTest class GrCullTest quickly determines whether a set of points will be visible or not. It will be used to guard against exponential recursion when chopping paths at an extreme zoom level. Bug: skia:10419 Change-Id: I85183826d820bbca0349a1e794b0696f776b134b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/407297 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Herb Derby <herb@google.com>
2021-05-13 16:42:30 +00:00
"$_tests/CullTestTest.cpp",
Reland "Start on custom mesh API" This is a reland of e1e1c03229455a9e5b20eefa0ebbed645a216f51 Original change's description: > Start on custom mesh API > > Bug: skia:12720 > Change-Id: I8ed0555f1c5b8b0e97e73a657635dac2c0df0ccf > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/482457 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> Bug: skia:12720 Change-Id: I5c54f37949d8bd45ea606264c439912b65158b79 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/487220 Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2021-12-21 15:36:58 +00:00
"$_tests/CustomMeshTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/DashPathEffectTest.cpp",
"$_tests/DataRefTest.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_tests/DebugLayerManagerTest.cpp",
Add unit test for SkDeferredDisplayLists (take 2) Change-Id: I76a4c77d5b9418cb7fe677bd55ba32a2e336924d Reviewed-on: https://skia-review.googlesource.com/79820 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2017-12-04 17:52:46 +00:00
"$_tests/DeferredDisplayListTest.cpp",
"$_tests/DequeTest.cpp",
Add validation to reading kRec_SkDescriptorTags Bug: chromium:940284, chromium:940843 Change-Id: Id6ce237781c6515f52341d3e56614e13e8ba76d6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/200045 Commit-Queue: Mike Klein <mtklein@google.com> Auto-Submit: Adrienne Walker <enne@chromium.org> Reviewed-by: Khushal Sagar <khushalsagar@chromium.org> Reviewed-by: Mike Klein <mtklein@google.com>
2019-03-12 20:31:30 +00:00
"$_tests/DescriptorTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/DeviceTest.cpp",
"$_tests/DiscardableMemoryPoolTest.cpp",
"$_tests/DiscardableMemoryTest.cpp",
"$_tests/DrawBitmapRectTest.cpp",
"$_tests/DrawPathTest.cpp",
"$_tests/DrawTextTest.cpp",
"$_tests/EmptyPathTest.cpp",
Add support for row-by-row jpeg encoding Reland of: https://skia-review.googlesource.com/c/14641/ Bug: 713862 Change-Id: I9dca5ede4ebf569c5f80edcfb23a506b6cfa935e Reviewed-on: https://skia-review.googlesource.com/15144 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
2017-05-02 20:04:56 +00:00
"$_tests/EncodeTest.cpp",
Reland "Switch SkCodec to use skcms plus fixes"" This reverts commit 83988edfd3256dc822b961362aad7fbc3e0cdabc. The CTS failure was actually due to another CL. TBR=brianosman@google.com TBR=djsollen@google.com Bug: skia:6839 Bug: skia:8052 Bug: skia:8278 Change-Id: Id9f152ec2c66467d90f49df223cb9b7c168ac2ac Reviewed-on: https://skia-review.googlesource.com/149483 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
2018-08-27 15:55:46 +00:00
"$_tests/EncodedInfoTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/ExifTest.cpp",
Add kRG_88_SkColorType Bug: skia:9121 Change-Id: Id2a12a5d607b84ce393d2b58233bf8e23f646059 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/235797 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Mike Reed <reed@google.com>
2019-09-04 19:05:35 +00:00
"$_tests/ExtendedSkColorTypeTests.cpp",
test and fix f16<->f32 conversion stages This refactors from_half() and to_half() a bit, totally reimplementing the non-hardware cases to be more clearly correct. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Android-Clang-PixelC-CPU-TegraX1-arm64-Release-Android,Test-Android-Clang-Ci20-CPU-IngenicJZ4780-mipsel-Release-Android,Test-Android-Clang-Nexus10-CPU-Exynos5250-arm-Release-Android,Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug Change-Id: I439463cf90935c5e8fe2369cbcf45e07f3af62c7 Reviewed-on: https://skia-review.googlesource.com/13921 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Matt Sarett <msarett@google.com>
2017-04-19 21:19:30 +00:00
"$_tests/F16StagesTest.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/FakeStreams.h",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/FillPathTest.cpp",
Move tessellation-specific functions out of GrPathUtils Bug: skia:12524 Change-Id: I2664c8ea707a40724bcf916e907fe28d1fa276d6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/474357 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-11-19 22:44:48 +00:00
"$_tests/FindCubicConvex180ChopsTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/FitsInTest.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/FlattenDrawableTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/FlattenableFactoryToName.cpp",
Use equal_range for factory lookups This patch uses equal_range instead of linear search to look up a factory entry by name. This does require a sort, but the expected usage is that the sort happens once and look ups happen many times. This improves performance on Chromium's oop deserialization of flattenables by about 10% R=reed@chromium.org Change-Id: I907f457a2ffb7d5b6d8261343099d982260b8415 Reviewed-on: https://skia-review.googlesource.com/96820 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-01-18 20:35:11 +00:00
"$_tests/FlattenableNameToFactory.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/Float16Test.cpp",
"$_tests/FloatingPointTextureTest.cpp",
"$_tests/FontHostStreamTest.cpp",
"$_tests/FontHostTest.cpp",
"$_tests/FontMgrTest.cpp",
"$_tests/FontNamesTest.cpp",
add flatten test to SkFont Change-Id: I7e96e826fad9aa204c963ae671cce668a676378f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/253684 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
2019-11-08 18:20:08 +00:00
"$_tests/FontTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/FrontBufferedStreamTest.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_tests/GLBackendSurfaceTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/GeometryTest.cpp",
"$_tests/GifTest.cpp",
Reland "Have draw(Text|PosText|PosTextH) use a single entry on the device" This reverts commit 74b390d6b136a60f1df15ac5ecd19bd8ad5a394b. Reason for revert: reverting to add patch for valgrind Original change's description: > Revert "Have draw(Text|PosText|PosTextH) use a single entry on the device" > > This reverts commit 4225b3220ef4bf50f0d9403f812ea94d50c4ee59. > > Reason for revert: made valgrind unhappy. > > Original change's description: > > Have draw(Text|PosText|PosTextH) use a single entry on the device > > > > Handle the positioning of drawText at the canvas layer. Simplify > > the code by removing similar implementations. > > > > Change-Id: I8b711783435072f560e29fca1dd934fa2e345ed2 > > Reviewed-on: https://skia-review.googlesource.com/127131 > > Reviewed-by: Ben Wagner <bungeman@google.com> > > Commit-Queue: Herb Derby <herb@google.com> > > TBR=jvanverth@google.com,bungeman@google.com,herb@google.com > > Change-Id: I65c9d30ae6ecb1f87e8660e56d8f8ce5daab7551 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/132403 > Reviewed-by: Hal Canary <halcanary@google.com> > Commit-Queue: Hal Canary <halcanary@google.com> TBR=jvanverth@google.com,halcanary@google.com,bungeman@google.com,herb@google.com Change-Id: I9bbb73aac447b51eb8215ac42331759fa4c9fa45 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/132580 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
2018-06-06 17:45:53 +00:00
"$_tests/GlyphRunTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/GpuDrawPathTest.cpp",
"$_tests/GpuRectanizerTest.cpp",
Add unit test to test basic importing and drawing of AHardwareBuffers. Bug: skia: Change-Id: If601693109148a7d5c6e6855443a3401c36e5f01 Reviewed-on: https://skia-review.googlesource.com/153545 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-09-12 13:17:11 +00:00
"$_tests/GrAHardwareBufferTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/GrContextAbandonTest.cpp",
"$_tests/GrContextFactoryTest.cpp",
Add GrContext::oomed() and implement for GL and VK. Surfaces to client whether GrContext has seen a GL_OUT_MEMORY, VK_ERROR_OUT_OF_HOST_MEMORY, or VK_ERROR_OUT_OF_DEVICE_MEMORY error. Bug: chromium:1093997 Change-Id: I8e9799a0f7d8a74df056629d7d1d07c0d0a0fe30 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/298216 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-06-24 14:19:52 +00:00
"$_tests/GrContextOOM.cpp",
Add an arg to SkImage::makeSubset to take a direct context This is part of a larger effort to force users to provide a context when manipulating GPU images which may be shared, instead of having images themselves retain powerful context pointers. Chrome flag landed in Chrome CL 2292800 Bug: skia:10466 Change-Id: Ic530a2c5eb1f4399db899d243ea944760fdf2055 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/300707 Commit-Queue: Adlai Holler <adlai@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2020-07-10 18:33:22 +00:00
"$_tests/GrDDLImageTest.cpp",
Add callback to flush for knowing when gpu is finished work. Bug: skia:8802 Change-Id: I093c2a4e879b635b169a849d9af3e9f7a3d84a88 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/207870 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-04-12 18:24:55 +00:00
"$_tests/GrFinishedFlushTest.cpp",
add flatten and MakeFromBuffer for GrGlyphVector Serialize all the glyphID information for the different sub runs. Bug: chromium:1278340 Change-Id: I04387ffadcf5cb20fbaca17a02d7ca1faf883806 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/507318 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Herb Derby <herb@google.com>
2022-02-10 18:18:17 +00:00
"$_tests/GrGlyphVectorTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/GrMemoryPoolTest.cpp",
Add cap to number of oplists we execute before flushing to the gpu. This fixes a crash we saw when we switch vulkan copies as draws to creating their own secondary command buffer. The crash came from the perf blendmode tests when using an advanced blend mode. They would do 1000 draws which forced us into creating 2000 command buffers (since the dst copies and the normal draws each used them). I tested without the copies as draws change and just increasing the total number of draws we do and was able to repro the crash. Besides fixing the above OOM crash, I am also seeing a 5-10% perf gain on the blendmode micro benches which is nice Bug: skia: Change-Id: I9266ea0ba02a755f54dabd4ee804963ab0c9b684 Reviewed-on: https://skia-review.googlesource.com/c/175436 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-12-07 16:20:33 +00:00
"$_tests/GrOpListFlushTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/GrPorterDuffTest.cpp",
Reland "Replace GrQuadList with variable-length quad buffer" This reverts commit 19628ec144a6e480e56bbfff38ae07a3db1588d1. Reason for revert: fixed struct size on 32-bit iOS Original change's description: > Revert "Replace GrQuadList with variable-length quad buffer" > > This reverts commit f2816044292f0d405c3060572d65fb35cef7cc3a. > > Reason for revert: Breaking G3 and iOS Build > > Original change's description: > > Replace GrQuadList with variable-length quad buffer > > > > Change-Id: I5cc391e8d143032893511695961f5251f40e8291 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/223803 > > Reviewed-by: Brian Salomon <bsalomon@google.com> > > Commit-Queue: Michael Ludwig <michaelludwig@google.com> > > TBR=bsalomon@google.com,michaelludwig@google.com > > Change-Id: I55947c068c6472c301952e33cbc36d04505f9800 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/223993 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> TBR=bsalomon@google.com,michaelludwig@google.com Change-Id: I7522270d467faf0f4e777831e9186bad010409ab No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/224184 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2019-06-27 14:13:27 +00:00
"$_tests/GrQuadBufferTest.cpp",
Reland "Consolidate quad optimizations into single internal function." This reverts commit 7694b90eb000cd91813171cb9ad5a2b45d51dcf9. Reason for revert: suppression: https://chromium-review.googlesource.com/c/chromium/src/+/1666472 Original change's description: > Revert "Consolidate quad optimizations into single internal function." > > This reverts commit 646616a78fe0a003c94a27e79c7e55dcc9ae2d66. > > Reason for revert: Suspected as cause of layout test changes. > > Original change's description: > > Consolidate quad optimizations into single internal function. > > > > Routes all non-textured quad draws through single internal function > > > > Change-Id: Ief66864a0ad2d598982c5bf500c8a84ecbf84387 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/215455 > > Commit-Queue: Michael Ludwig <michaelludwig@google.com> > > Reviewed-by: Robert Phillips <robertphillips@google.com> > > TBR=robertphillips@google.com,michaelludwig@google.com > > Change-Id: I0dc6a0d948c0f5e9221ff6c9fbbbbbb9bc3d9bc0 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/221737 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> TBR=bsalomon@google.com,robertphillips@google.com,michaelludwig@google.com Change-Id: I4e5d39d603d32b18c48db291fb1650fe33e9ba11 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/222096 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2019-06-19 14:48:58 +00:00
"$_tests/GrQuadCropTest.cpp",
Detemplatize render task clustering This simplifies our world and opens the door for more optimization. Bug: skia:10877 Change-Id: I3c721f12a23bfa73dbdf1e02d9c77d7c6a889aa0 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/356309 Commit-Queue: Adlai Holler <adlai@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2021-01-20 22:44:15 +00:00
"$_tests/GrRenderTaskClusterTest.cpp",
don't produce empty slugs! The current system short circuits out when an SkTextBlob will draw anything based on its bounds, the bounds of the clip, and the state of the paint. A similar thing needs to happen, but the clip needs to be ignored. Return the nullptr if the SkTextBlob would never draw to signal that the Slug can be ignored. Bug: chromium:1277583 Change-Id: I2d6641e03c88ae5f160c479c9e715ad8dc9f65b3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/481592 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Herb Derby <herb@google.com>
2021-12-08 17:32:46 +00:00
"$_tests/GrSlugTest.cpp",
Reland "Rename GrShape to GrStyledShape" This reverts commit 73b86c1ade1c002cfa4da66c33c25514737e2416. Reason for revert: wasn't the problem, relanding Original change's description: > Revert "Rename GrShape to GrStyledShape" > > This reverts commit f3f08af010eebdb9c1501bdf1b3d8e715298b05f. > > Reason for revert: maybe this is breaking the ios perf bot; it is the first CL that caused the bot to fail, but I can't really say why this would break them. > > Original change's description: > > Rename GrShape to GrStyledShape > > > > Change-Id: Ic457e634b4b95356f5615cff3fce1ca7d7677c26 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284036 > > Reviewed-by: Robert Phillips <robertphillips@google.com> > > Commit-Queue: Michael Ludwig <michaelludwig@google.com> > > TBR=bsalomon@google.com,robertphillips@google.com,michaelludwig@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: I2e5adbfc820811fbbde9cb57af28f86a7ba40bd9 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284231 > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > Commit-Queue: Michael Ludwig <michaelludwig@google.com> TBR=bsalomon@google.com,robertphillips@google.com,michaelludwig@google.com Change-Id: Ifdd52f8bacb5d66a7bf58efd328675c4c443ac8a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/284376 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2020-04-17 20:21:37 +00:00
"$_tests/GrStyledShapeTest.cpp",
Add submittedProc to GrFlushInfo. Bug: skia:10118 Change-Id: Iad848310d0f2fb22f19e9890209548fda103bd27 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/291078 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2020-05-26 15:26:45 +00:00
"$_tests/GrSubmittedFlushTest.cpp",
Reland "Add SkSurface resolve function." This is a reland of d921f21fbcc59dbc1fd4e4831a3b3c2ba5b7d469 Original change's description: > Add SkSurface resolve function. > > This will insert a resolve msaa call into the stream of commands for > the SkSurface. This is mostly useful for cases when a client wraps the > resolve texture but has Skia draw with MSAA, and the client wants to > make sure Skia resolves to their wrapped texture. > > Bug: chromium:1292418 > Change-Id: I6eddae967136716b9215fcd96e7d77a2457efdf2 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/503340 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Greg Daniel <egdaniel@google.com> Bug: chromium:1292418 Change-Id: I810b5618092c560f5bba900024b3b8c0c88baea9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/503717 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2022-02-03 15:44:00 +00:00
"$_tests/GrSurfaceResolveTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/GrSurfaceTest.cpp",
error on the side of safety for empty blobs If the blob is empty, then try to regenerate it. Using this method caused a slowdown in Skia perf, so we added an extra check to allow some empty blobs through for perf performance. The perf problem was caused by SKPs generate empty blobs because of font mismatches. Flutter has shown that scaling from very small to normal size is not correctly handled by the existing check. This CL favors correctness over optimizing empty text blob and always regenerates empty blobs. https://github.com/flutter/flutter/issues/64936 Change-Id: Ib18ecb684b0af5cf6dce274b6dc09a9c61b17c77 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/319031 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Herb Derby <herb@google.com>
2020-09-23 16:00:53 +00:00
"$_tests/GrTextBlobTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/GrTextureMipMapInvalidationTest.cpp",
Add GrVx.h Adds grvx, Ganesh's addendum to skvx. Here we introduce familiar names and operations from GPU languages, as well as functions that are approximate and/or have LSB differences from platform to platform. The initial implementation has: fast_fma, fast_acos, and fast_angle_between_vectors. When a function is approximate, its error range is well documented and tested. Also establishes GrWangsFormula as the first user of grvx. Bug: skia:10419 Change-Id: Id0682599cf9c0303eff386095afc3ef9f3a7fa1b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/330119 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-11-02 17:52:26 +00:00
"$_tests/GrVxTest.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/GradientTest.cpp",
"$_tests/HSVRoundTripTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/HashTest.cpp",
Implement SkHighContrastFilter This is a color filter to apply several contrast adjustments for users with low vision, including inverting the colors (in either RGB or HSL space), applying gamma correction, converting to grayscale, and increasing the contrast. BUG=skia:6235 CQ_INCLUDE_TRYBOTS=skia.primary:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD Change-Id: Icb8f3e290932d8bcd9387fb1f39dd20767e15cf6 Reviewed-on: https://skia-review.googlesource.com/7460 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-02-14 19:15:31 +00:00
"$_tests/HighContrastFilterTest.cpp",
Revert "Revert "WIP: Skia support library for ICC tasks"" This reverts commit eb733fbf56538838a36814c75cd03f917462cb22. Reason for revert: Revert patch was automatically merged incorrectly? Original change's description: > Revert "WIP: Skia support library for ICC tasks" > > This reverts commit fc8dc3194acb959ee5980b41766660ca0644bcab. > > Reason for revert: Breaks Build-Mac-Clang-Arm7-{Debug,Release}-iOS builds. > Example tasks: > * https://chromium-swarm.appspot.com/task?id=3322f668620b9e10&refresh=10 > * https://chromium-swarm.appspot.com/task?id=332296146331e810&refresh=10 > > Original change's description: > > WIP: Skia support library for ICC tasks > > > > As a starting point, this would be mostly trivial to implement using > > SkColorSpace. > > > > This also would give us the flexibility to begin to move all of > > the ICC related code from SkColorSpace to SkICC. > > > > What are the advantages of moving this away from SkColorSpace? > > (1) A long term goal (once Chrome uses SkCodec), might be to > > move SkColorSpace::MakeICC() out of the public API. That way, > > we can guarantee that we can draw to/from *any* SkColorSpace. > > (2) Keeps SkColorSpace separate from ICC-specific representations > > like SkColorSpaceTransferFn etc. > > > > BUG=skia: > > > > Change-Id: Iddeb9903221fb57fbfc01218d8641c928b4a5165 > > Reviewed-on: https://skia-review.googlesource.com/5676 > > Commit-Queue: Matt Sarett <msarett@google.com> > > Reviewed-by: Brian Osman <brianosman@google.com> > > Reviewed-by: Mike Reed <reed@google.com> > > > > TBR=mtklein@google.com,msarett@google.com,brianosman@google.com,reed@google.com,reviews@skia.org > BUG=skia: > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Change-Id: Ibdf272fce25892402bd3e85595fb8814cdf59856 > Reviewed-on: https://skia-review.googlesource.com/6232 > Commit-Queue: Ravi Mistry <rmistry@google.com> > Reviewed-by: Ravi Mistry <rmistry@google.com> > TBR=mtklein@google.com,rmistry@google.com,msarett@google.com,reviews@skia.org,brianosman@google.com,reed@google.com BUG=skia: NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I68b1624cfab8adfe31b17e1193a7766507dec8b0 Reviewed-on: https://skia-review.googlesource.com/6233 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
2016-12-17 01:31:03 +00:00
"$_tests/ICCTest.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/ImageBitmapTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/ImageCacheTest.cpp",
"$_tests/ImageFilterCacheTest.cpp",
"$_tests/ImageFilterTest.cpp",
"$_tests/ImageFrom565Bitmap.cpp",
"$_tests/ImageGeneratorTest.cpp",
"$_tests/ImageIsOpaqueTest.cpp",
"$_tests/ImageNewShaderTest.cpp",
"$_tests/ImageTest.cpp",
First version of incremental topological sort In order to solve both the VRAM budget for explicit resource allocation and DDL incremental flush problems we will need to always have the opLists be sorted. This will also help partial flushes. Change-Id: I3ac2baf622415925ab5c403b7800f3fc49e59838 Reviewed-on: https://skia-review.googlesource.com/144000 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-08-07 19:16:54 +00:00
"$_tests/IncrTopoSortTest.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/IndexedPngOverflowTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/InfRectTest.cpp",
Revert "Revert "Create new inset algorithm for spot shadows"" This reverts commit e7c85c45c4c0a97adc6711bb12ecacc36af4ba11. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "Create new inset algorithm for spot shadows" > > This reverts commit e5f5bf5175e426ebb6aa234f4387831c898f20ad. > > Reason for revert: Breaking a bunch of bots. e.g: > > https://luci-milo.appspot.com/swarming/task/3519cae0a03c7b10/steps/dm/0/stdout > > Original change's description: > > Create new inset algorithm for spot shadows > > > > BUG=skia: > > > > Change-Id: If7c67c2a5b9beea28f86d13362a5156b46394d0e > > Reviewed-on: https://skia-review.googlesource.com/9875 > > Commit-Queue: Ravi Mistry <rmistry@google.com> > > Reviewed-by: Brian Salomon <bsalomon@google.com> > > Reviewed-by: Robert Phillips <robertphillips@google.com> > > > > TBR=jvanverth@google.com,bsalomon@google.com,rmistry@google.com,robertphillips@google.com,msarett@google.com,reviews@skia.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Change-Id: I3d119ff631dbb1a41f873b9c8753d542ec91254e > Reviewed-on: https://skia-review.googlesource.com/10112 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> > TBR=jvanverth@google.com,bsalomon@google.com,rmistry@google.com,msarett@google.com,robertphillips@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Change-Id: Ib3998300606d3a2e2fb3a14b2088cfad48363501 Reviewed-on: https://skia-review.googlesource.com/10113 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-03-24 16:07:20 +00:00
"$_tests/InsetConvexPolyTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/InvalidIndexedPngTest.cpp",
"$_tests/IsClosedSingleContourTest.cpp",
Fold SkJSON into Skia/utils It's a tiny, core-ish component -- might as well treat as such to simplify dependencies. Change-Id: I6f31ce2d151f9a629d88bfc7f15d64891d5150c0 Reviewed-on: https://skia-review.googlesource.com/135780 Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-06-19 15:27:20 +00:00
"$_tests/JSONTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/LListTest.cpp",
Added SkLRUCache.h and converted GPU program cache to use it. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4221 Change-Id: I7e4094c2f2a2ecc5909895a8a68b27047acdcbd0 Reviewed-on: https://skia-review.googlesource.com/4221 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
2016-12-15 20:28:42 +00:00
"$_tests/LRUCacheTest.cpp",
Rebind GrGLRenderTarget if there is a lazy stencil attachment change. Bug: chromium:1271431 Change-Id: Ie5bef1a8f18d4d1e2d9a92afdf5c5305d3d9bdb2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/475256 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
2021-11-22 22:30:22 +00:00
"$_tests/LazyStencilAttachmentTest.cpp",
separate m44 tests Change-Id: I33db5286538cd5721ad0cf6095eef82c42ff1e35 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/283916 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
2020-04-16 10:25:54 +00:00
"$_tests/M44Test.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/MD5Test.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/MallocPixelRefTest.cpp",
"$_tests/MaskCacheTest.cpp",
"$_tests/MathTest.cpp",
"$_tests/MatrixClipCollapseTest.cpp",
Fix GrColorMatrixFragmentProcessor handling of premul transparent black. Use the original alpha in the unpremul color. Bug: chromium:1024935 Change-Id: I6a721431781f0ef42a3f162d39f8bbac924a2c30 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261680 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-12-30 21:36:25 +00:00
"$_tests/MatrixColorFilterTest.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_tests/MatrixTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/MemoryTest.cpp",
"$_tests/MemsetTest.cpp",
"$_tests/MessageBusTest.cpp",
"$_tests/MetaDataTest.cpp",
"$_tests/MipMapTest.cpp",
Add a test that draws subpictures within an MSKP and make it pass. It would have been passing, note that he changes to SkRecorder are needed only to obtain the SkRecord used in asseting the correct commands were recorded. Bug: skia: 9462 Change-Id: Ic43ab400b5954cc4f6eb465168179c0204a66040 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/243818 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Nathaniel Nifong <nifong@google.com>
2019-09-25 18:52:44 +00:00
"$_tests/MultiPictureDocumentTest.cpp",
Reland "Add an SkImageGenerator that uses NDK APIs" This reverts commit 07438b0cdaa326d5e4b969e03bfb67e0c8066f13. Bug: skia:10369 Bug: skia:10371 This will allow Skia clients developing for Android 11+ to rely on Android's NDK APIs for decoding, which will allow them to decode without including their own decoding libraries (e.g. libjpeg-turbo). Using these APIs also provides support for static HEIF images. Run ImageGenSrc in kPlatform_Mode on Android to verify decoding visually. Add tests and a grayscale png. Update some test bots running Android R to specify ndk_api so they will run the new code. Change-Id: I4ca07d832dbd6a9d8cff0faea975fd70da00718f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/308185 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
2020-08-05 14:44:17 +00:00
"$_tests/NdkDecodeTest.cpp",
Add platform image encoder for using NDK APIs Bug: skia:10369 Add SkEncodeImageWithNDK, mirroring the CG and WIC versions, for encoding with the NDK APIs added to R. Rename SK_ENABLE_NDK_DECODING to SK_ENABLE_NDK_IMAGES and use it for both encoding and decoding. Move code for converting to/from NDK types into a common location. Update encode_platform.cpp to use NDK encoding APIs when available and to use both types of webp (lossy and lossless). Add tests specifically for the new implementation. Update NdkDecodeTest to use ToolUtils::equal_pixels for comparing pixels. Change-Id: Ic62f89af27372ccce90b8e028e01c388a135a68c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/308800 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-08-05 20:51:10 +00:00
"$_tests/NdkEncodeTest.cpp",
SkColorSpaceXformSteps improvements and tests Added some helper functions and put the booleans in a nested struct (this is motivated by upcoming changes). Added a unit test of steps against skcms, with round-tripping in both combinations. Change-Id: Iea3d60cd52edb5259b5576b1422ed6f856cde815 Reviewed-on: https://skia-review.googlesource.com/134660 Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2018-06-13 21:21:19 +00:00
"$_tests/NonlinearBlendingTest.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/OSPathTest.cpp",
"$_tests/OffsetSimplePolyTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/OnceTest.cpp",
"$_tests/OverAlignedTest.cpp",
"$_tests/PDFDeflateWStreamTest.cpp",
"$_tests/PDFDocumentTest.cpp",
"$_tests/PDFGlyphsToUnicodeTest.cpp",
"$_tests/PDFJpegEmbedTest.cpp",
"$_tests/PDFMetadataAttributeTest.cpp",
"$_tests/PDFOpaqueSrcModeToSrcOverTest.cpp",
"$_tests/PDFPrimitivesTest.cpp",
Add support for tagging link annotations in PDFs. Properly tagging links in PDFs just required a small change: at the time an annotation is drawn, we need to keep track of the bounding rect, the url and/or named destination, and now additionally the node ID. Instead of keeping track of separate maps of rects/urls and rects/dests, this patch combines them into a vector of SkPDFLinks. Then, at the time the annotation is written to the file, an object reference to that annotation can be saved and passed to the document structure tree, where it can be included as an additional child of the node with that node ID. That allows for properly tagging the link and optionally giving it alt text (like for an image link). Bug: chromium:1039816 Change-Id: I97e47d3c70949020c3e0a69b8c9fc743748f3a7b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/277426 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Ben Wagner <bungeman@google.com>
2020-03-24 15:27:54 +00:00
"$_tests/PDFTaggedLinkTest.cpp",
Allow passing multiple node IDs per PDF structure node. At the time Chromium is painting, we're passing node IDs along with painting commands to enable tagging. However, this assumes that all nodes will end up in the structure tree, which we might not want. Instead, allow the client to prune the structure tree later before telling Skia to generate the PDF, but keep all of the node IDs to be matched up with. As an example, suppose the doc looks like this: root id=1 paragraph id=2 div id=3 text1 id=4 link id=5 text2 id=6 The pruned tree passed to Skia would look like this: root id=1 paragraph id=2 extra_ids=3,4 link id=5 extra_ids=6 We need to pass the extra node IDs into Skia so that when content is tagged with id=4, we know to map that to the paragraph node with id=2 instead. Note that the resulting PDF document will *not* have any of these extra IDs, they're all remapped and consolidated. While it's not strictly necessary that this is done in Skia, it's easiest to implement it here. Doing the same upstream would require replaying an SkPicture and rewriting all of the node IDs. Bug: chromium:607777 Change-Id: I0ecb62651e60b84cc5b9d053d7f7d3b9efda1470 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272462 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
2020-02-24 16:45:39 +00:00
"$_tests/PDFTaggedPruningTest.cpp",
Re-land: Support adding attributes to PDF document structure nodes. Originally landed: https://skia-review.googlesource.com/c/skia/+/268878 Reverted: https://skia-review.googlesource.com/c/skia/+/271858 The issue was with compilation when PDF support is disabled. See the diff between patchsets 1 and 2. This is an important part of writing a tagged PDF. Many of the nodes in the document structure tree need additional attributes, just like in HTML. This change aims to add support for a few useful attributes, not to be comprehensive. Bug: chromium:1039816 Change-Id: I15f8b6c41d4fdaa4b6e21775ab6d26ec57eb0f5d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/271916 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Mike Reed <reed@google.com>
2020-02-19 18:59:29 +00:00
"$_tests/PDFTaggedTableTest.cpp",
Add initial support for generating tagged PDFs. Adds an interface for the document creator to pass in a tree of tags indicating the structure of the document, each with a type (from a predetermined enum of possible types) and a node ID. It also adds a setNodeId function to SkCanvas so that page content can be associated with a particular tag. If both the tag tree and marked content are present, Skia can now output a properly tagged PDF. An example program is included. When used properly, the PDF generated by this patch is valid and the tags are parsed properly by Adobe Acrobat. It handles many corner cases like content that spans more than one page, or tags that don't correspond to any marked content, or marked content that doesn't correspond to any tags. However, it doesn't implement all of the features of PDF accessibility yet, there are some additional attributes that can be associated with some tags that need to be supported, too, in order to properly tag things like figures and tables. Bug: skia:8148 Change-Id: I2e448eca8ded8e1b29ba685663b557ae7ad7e23e Reviewed-on: https://skia-review.googlesource.com/141138 Reviewed-by: Hal Canary <halcanary@google.com>
2018-09-26 03:29:15 +00:00
"$_tests/PDFTaggedTest.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/PaintTest.cpp",
"$_tests/ParametricStageTest.cpp",
Fix SkParse::FindNamedColor OOB Plus some minor cleanup and asserts. Bug: oss-fuzz:23395 Change-Id: I667bee2d7f21864defe2fd97df9eb4e99d69d9ca Reviewed-on: https://skia-review.googlesource.com/c/skia/+/296451 Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Tyler Denniston <tdenniston@google.com> Commit-Queue: Florin Malita <fmalita@google.com>
2020-06-16 16:58:08 +00:00
"$_tests/ParseColorTest.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/ParsePathTest.cpp",
add simple pathbuilder 88.26 ? makepath_arrays_reserve nonrendering 235.97 makepath_detach_reserve nonrendering 274.56 makepath_snapshot_reserve nonrendering 537.61 makepath_path_reserve nonrendering 472.98 makepath_detach_noreserve nonrendering 482.56 makepath_snapshot_noreserve nonrendering 750.83 ? makepath_path_noreserve nonrendering Bug: skia:9000 Change-Id: I346537e899b08946c5778042a021f464006b029c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/209403 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Chris Dalton <csmartdalton@google.com>
2020-06-24 01:06:28 +00:00
"$_tests/PathBuilderTest.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/PathCoverageTest.cpp",
"$_tests/PathMeasureTest.cpp",
"$_tests/PathTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/PictureBBHTest.cpp",
"$_tests/PictureShaderTest.cpp",
"$_tests/PictureTest.cpp",
Add unit test for pinned SkImages Change-Id: I2e14353bc865b5994cc90ad643a6a58604955957 Reviewed-on: https://skia-review.googlesource.com/53500 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2017-09-29 19:10:39 +00:00
"$_tests/PinnedImageTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/PixelRefTest.cpp",
"$_tests/Point3Test.cpp",
"$_tests/PointTest.cpp",
Add some new PolyUtils tests. Also: * clean up PolyUtils checks to be correct and consistent. * fix some bugs discovered by the unit tests. Bug: skia: Change-Id: I1a8e07d13cb44fecc67344154dc1002f3f910f5d Reviewed-on: https://skia-review.googlesource.com/138592 Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
2018-07-03 20:12:39 +00:00
"$_tests/PolyUtilsTest.cpp",
Make path pre-chopping more robust Exceptionally large control points might require us to chop the path very deeply. This CL converts the recursive chopping to loop with a stack of control points on the heap, in order to avoid the risk of stack overflow. It also adds a bail condition to avoid getting stuck in endless recursion due to fp32 precision issues. Bug: chromium:1266446 Change-Id: I005be4bc29de51d3c89f04b5d6c553a921a92aa3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/473197 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-11-18 08:04:04 +00:00
"$_tests/PreChopPathCurvesTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/PremulAlphaRoundTripTest.cpp",
Add promise images for deferred instantiation of wrapped gpu textures This will allow a client to make an SkImage that "wraps" a gpu texture, however the client does need to supply the actual gpu texture at Image creation time. Instead it is retrieve at flush time via a callback. Bug: skia: Change-Id: I6267a55ab7102101a7bd80a6f547b6a870d2df08 Reviewed-on: https://skia-review.googlesource.com/109021 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Cary Clark <caryclark@google.com>
2018-03-09 17:05:04 +00:00
"$_tests/PromiseImageTest.cpp",
Add GrTextureRenderTargetProxy and support switching between RT & Tex Proxies GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4427 Change-Id: Ie7662299953592f564bb27a4df4ea101f743403e Reviewed-on: https://skia-review.googlesource.com/4427 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2016-11-04 15:59:10 +00:00
"$_tests/ProxyConversionTest.cpp",
Add IORef capability to GrSurfaceProxy objects - take 2 Re-landing of https://skia-review.googlesource.com/c/4734/ (Add IORef capability to GrSurfaceProxy objects) with fixes for: platforms that don't support discards. memory leak due to copying over of GrSurfaceProxy's creation ref to instantiated GrSurface in instantiate() GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4827 BUG=skia: Change-Id: If0b695d5cafc5ef3fdd251c38262849d09e5d27f Review-Url: https://codereview.chromium.org/2502923003
2016-11-16 19:17:17 +00:00
"$_tests/ProxyRefTest.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_tests/ProxyTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/QuickRejectTest.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/RRectInPathTest.cpp",
"$_tests/RTreeTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/RandomTest.cpp",
"$_tests/ReadPixelsTest.cpp",
Move GPU read pixels tests to new file. To share code with forthcoming write pixels tests. Bug: skia:8862 Change-Id: I4953cc8b6358ff6514c645296a4baf60b65da905 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/348187 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-12-29 20:09:33 +00:00
"$_tests/ReadWritePixelsGpuTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/RecordDrawTest.cpp",
"$_tests/RecordOptsTest.cpp",
"$_tests/RecordPatternTest.cpp",
"$_tests/RecordTest.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/RecordTestUtils.h",
"$_tests/RecorderTest.cpp",
"$_tests/RecordingXfermodeTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/RectTest.cpp",
"$_tests/RefCntTest.cpp",
"$_tests/RegionTest.cpp",
Add unit test to prevent future memory regressions Bug: b/138674523 Change-Id: Ie4e37763ca68c7fcfa2f78cfa3c85a21bb863f77 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/233558 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-08-09 15:04:44 +00:00
"$_tests/RepeatedClippedBlurTest.cpp",
Add GrResourceAllocator class + unit test Change-Id: I2700e8cb4213479b680519ba67f078cc3fb71376 Reviewed-on: https://skia-review.googlesource.com/23661 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2017-07-18 18:49:38 +00:00
"$_tests/ResourceAllocatorTest.cpp",
Revert "Revert "Revert "Revert "Don't build GL on Metal, Vulkan, Dawn, Direct3D bots"""" Updated to use sentinel GL context even when GL backend is not built. This reverts commit 1171d314efc7e131b039c94126d26575cfb9e70c. Change-Id: Ia94bbe4865ddd4e898446c13886877c539f0eb0b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/277976 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-03-19 19:54:28 +00:00
"$_tests/ResourceCacheTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/RoundRectTest.cpp",
Reland "Add unit test confirming Runtime Blends match native blends." This is a reland of 0b62a05d9ae528fad7b18e842588b331ec032bcd Original change's description: > Add unit test confirming Runtime Blends match native blends. > > We perform the same draw operation twice--once with a `setBlendMode` > based blend, and then once more with `setBlender` and passing SkSL which > is equivalent to the native blend op. If this test fails, it would > indicate that Runtime Blends aren't being applied appropriately (or > perhaps that a GPU's built-in blending modes are cutting corners?). > > Change-Id: I4ca1f9ed600d9ec733687cc6de7d3e2eb6e765c9 > Bug: skia:12080 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428318 > Auto-Submit: John Stiles <johnstiles@google.com> > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> Bug: skia:12080 Change-Id: Idf4297314b133e5bce689a25d53063bff8469fac Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428676 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2021-07-15 15:18:37 +00:00
"$_tests/RuntimeBlendTest.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/SRGBReadWritePixelsTest.cpp",
"$_tests/SRGBTest.cpp",
"$_tests/SVGDeviceTest.cpp",
SkSafeMath for tracking size_t overflow Do multiply (mul) and add while tracking that the calculation does not overflow, which can be checked with ok(). The new unit test shows a couple examples. Author: Herb Derby <herb@google.com> Change-Id: I7e67671d2488d67f21d47d9618736a6bae8f23c3 Reviewed-on: https://skia-review.googlesource.com/33721 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Herb Derby <herb@google.com>
2017-08-11 18:00:50 +00:00
"$_tests/SafeMathTest.cpp",
Don't use sprite-blit if cubic sampling Need this to land first: https://chromium-review.googlesource.com/c/chromium/src/+/2597643 Bug: skia:7650 Change-Id: Idebecfc8a5922a937fd46ccff1eea4df53f6b0cd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/345170 Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Florin Malita <fmalita@google.com> Commit-Queue: Mike Reed <reed@google.com>
2020-12-21 14:33:59 +00:00
"$_tests/SamplingTest.cpp",
Reland "Preserve base device origin on saveLayer and image filters" This reverts commit 814652c373ac7f50bb3ae500800f00c5887d3b22. Reason for revert: missed suppression has landed in chrome Original change's description: > Revert "Preserve base device origin on saveLayer and image filters" > > This reverts commit f436cf2343f955c999626acace6fcabd59977815. > > Reason for revert: May need to be behind flag or more > suppressions. Breaking linux-rel vulkan_swiftshader_blink_web_tests > css3/filters/effect-blur-hw.html . > > Original change's description: > > Preserve base device origin on saveLayer and image filters > > > > SaveLayerOriginTest taken from https://skia-review.googlesource.com/c/skia/+/277977 > > > > Bug: skia:12732 > > Change-Id: I5ce75355bb16237043c229e1cbc7a106eb636d18 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/508919 > > Reviewed-by: Greg Daniel <egdaniel@google.com> > > Commit-Queue: Michael Ludwig <michaelludwig@google.com> > > Bug: skia:12732 > Change-Id: I74cc8dc279d22c4fbd313ae3caeb4d0748daf003 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/510196 > Auto-Submit: Ben Wagner <bungeman@google.com> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bug: skia:12732 Change-Id: Ifdc3ac96b1b695c208960915ca313fbacf4b7ed6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/510203 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
2022-02-17 17:02:48 +00:00
"$_tests/SaveLayerOriginTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/ScalarTest.cpp",
"$_tests/ScaleToSidesTest.cpp",
add serial procs to pictures Bug: skia:7380 Change-Id: Ic1b7e437316c7913711cf5cb119e3fe904cd2c05 Reviewed-on: https://skia-review.googlesource.com/76980 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-12-05 20:11:24 +00:00
"$_tests/SerialProcsTest.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/SerializationTest.cpp",
Add SkImageFilters::Shader in place of Paint factory SkImageFilters::Paint did not use every slot of the SkPaint, with only its color, alpha, color filter, and shader having a meaningful effect on the image filter result. It was always blended into a transparent dst, so blend mode wasn't very relevant, and it was always filled to whatever required geometry, so stroke style, path effect, and mask filters were ignored or not well specified. Color, alpha, and color filter can all be combined into an SkShader, so a more constrained SkImageFilters::Shader provides the same useful capabilities without as many surprises. SkImageFilters::Paint still exists, but is deprecated to be removed once I've confirmed clients aren't depending on it. Bug: skia:9310 Change-Id: I11a82bda1a5d440726cf4e2b5bfaae4929568679 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/323680 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2020-10-07 19:27:20 +00:00
"$_tests/ShaderImageFilterTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/ShaderOpacityTest.cpp",
"$_tests/ShaderTest.cpp",
Compute correct bounds for DrawShadowRec. Bug: skia:6880 Change-Id: Ia8b94e52eec3feb5104d2351bf7a7e6f99101deb Reviewed-on: https://skia-review.googlesource.com/26370 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2017-07-31 13:34:58 +00:00
"$_tests/ShadowTest.cpp",
Shaper : new unit test Bug: skia:9050 Change-Id: I4edc6528c4d625f95ce42b1f96fb0c419ce45134 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/211831 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Herb Derby <herb@google.com>
2019-05-02 21:00:22 +00:00
"$_tests/ShaperTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/SizeTest.cpp",
"$_tests/SkBase64Test.cpp",
Move GrBlockAllocator and GrTBlockList to src/core/ src/gpu/GrBlockAllocator -> src/core/SkBlockAllocator src/gpu/GrTBlockList -> src/core/SkTBlockList Tests and references also renamed. Bug: skia:12330 Change-Id: I5fad05faa3dcecd89a0a478dcf30c090ea7589f5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/441477 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2021-08-24 15:49:55 +00:00
"$_tests/SkBlockAllocatorTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/SkColor4fTest.cpp",
SkColorSpaceXformSteps Lots TODO. Change-Id: I95edb764b85a5140d432adb506c3b537869e6df4 Reviewed-on: https://skia-review.googlesource.com/129933 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: Mike Klein <mtklein@chromium.org>
2018-05-24 16:33:23 +00:00
"$_tests/SkColorSpaceXformStepsTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/SkDOMTest.cpp",
Added an API for creating RuntimeEffects using the SkSL DSL. Change-Id: I305016d305455e2b90fe904d8da93cf7735cc38e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/389316 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: John Stiles <johnstiles@google.com>
2021-04-16 18:54:43 +00:00
"$_tests/SkDSLRuntimeEffectTest.cpp",
Try 2 for Gauss filter calculation Originally reviewed at: https://skia-review.googlesource.com/c/skia/+/67723 Change-Id: Ie62d81f818899f3a79df888c1594d3fbccf6d414 Reviewed-on: https://skia-review.googlesource.com/69681 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
2017-11-03 17:36:55 +00:00
"$_tests/SkGaussFilterTest.cpp",
Introduce SkGlyphDrawableBuffer Used for efficient glyph id to glyph lookup. This is part of a larger change: https://skia-review.googlesource.com/c/skia/+/238196 Change-Id: Ifce43879685bf0d760a7e12dceb32f7a650be687 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/247340 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
2019-10-09 16:26:56 +00:00
"$_tests/SkGlyphBufferTest.cpp",
introduce SkGlyphRect specialized for union & intersect SkGlyphRect is a rectangle encoding specialized for union and intersect. It will be used for calculating the bounding boxes of glyph runs, and clipping glyphs for GPU. Change-Id: Icab826b51dc2254ee4006ada84f7fc09e112a933 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/319697 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Herb Derby <herb@google.com>
2020-09-23 20:14:45 +00:00
"$_tests/SkGlyphTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/SkImageTest.cpp",
"$_tests/SkNxTest.cpp",
Return the contour's final point from SkPath::RangeIter in kClose This point is located at fPoints[-1]. We might as well provide it since it's free, and the stroke iterators for indirect tessellation will be able to use it. Bug: skia:10419 Change-Id: If0161a18a9a5a0f3b118a99d7c090d79d424f9db Reviewed-on: https://skia-review.googlesource.com/c/skia/+/337637 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
2020-11-23 18:33:22 +00:00
"$_tests/SkPathRangeIterTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/SkRasterPipelineTest.cpp",
fonts: Reland push font remoting. This relands the following changes: 1) https://skia-review.googlesource.com/c/skia/+/120283 2) https://skia-review.googlesource.com/c/skia/+/125029 3) https://skia-review.googlesource.com/c/skia/+/125140 The original changes had to be reverted due to a memory leak in SkBaseDevice from SkTextBlobCacheDiffCanvas. This has been addressed by https://skia-review.googlesource.com/c/skia/+/125160 TBR=herb@google.com Bug: skia:7515, 831354 Change-Id: I73f4fcb1c397f31bf01553ff48c71ed2d6dd0770 Reviewed-on: https://skia-review.googlesource.com/125326 Commit-Queue: Khusal Sagar <khushalsagar@chromium.org> Reviewed-by: Khusal Sagar <khushalsagar@chromium.org>
2018-05-02 17:29:37 +00:00
"$_tests/SkRemoteGlyphCacheTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/SkResourceCacheTest.cpp",
Start adding unit tests of SkRuntimeEffect - Change SkRuntimeEffect::Make so *it* can fail, and returns [Effect, ErrorText]. - Initial tests just test for expected failure conditions. Next steps are to add tests for effects that should work, and to validate results on CPU and GPU. Change-Id: Ibac8c3046104577434034263e9e4a4b177e89129 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261095 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2019-12-19 20:44:56 +00:00
"$_tests/SkRuntimeEffectTest.cpp",
Revert "Revert "SkSL DSL now reports the C++ line numbers of errors"" This reverts commit 3a4e19da8e9656c1f82e29d70a2bb3b2f92c6c0b. TBR=brianosman@google.com, johnstiles@google.com Change-Id: I5ae97aba2df5b9c3b3dcca8e30da4e5ce9009109 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/376117 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2021-02-26 01:50:32 +00:00
"$_tests/SkSLDSLErrorLineNumbers.cpp",
Fixed an issue with DSL includes It turned out that everywhere we were using or testing DSL code either directly or indirectly imported big chunks of the SkSL library. These imports turned out to be necessary; code written using just DSL.h would fail with various template instantiation errors. Change-Id: Iae72d15b0d6ef14614ac1a4ff08c36bc1876cd4d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/381638 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: John Stiles <johnstiles@google.com>
2021-03-09 18:10:59 +00:00
"$_tests/SkSLDSLOnlyTest.cpp",
Beginnings of the SkSL DSL framework The code at this point doesn't do anything useful, but establishes some of the basic types and patterns. Change-Id: I580a9e75ffa3162879893450fb7d1f0905a10687 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/350697 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: John Stiles <johnstiles@google.com> Auto-Submit: Ethan Nicholas <ethannicholas@google.com>
2021-01-07 15:57:27 +00:00
"$_tests/SkSLDSLTest.cpp",
Add ES2 conformance test harness to dm. This CL adds a few more exceptions to our ES2 test import, and adds the dm code which actually runs the tests. Change-Id: If6691dd35931f4f10262d3a1eff020c2c347ca59 Bug: skia:12484 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/459124 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-10-13 22:02:21 +00:00
"$_tests/SkSLES2ConformanceTest.cpp",
Reland "Verify that tests in errors/ actually generate the expected errors." This reverts commit 43539c22a2963f5db8f790c32aed8bf3a992ed68. Reason for revert: UB fixed at http://review.skia.org/505678 Original change's description: > Revert "Verify that tests in errors/ actually generate the expected errors." > > This reverts commit 8d646c127a7bed796eed927c8b9cff3a1ccedb06. > > Reason for revert: triggering UBSAN > http://screen/887FeQtZWs2A6oo > > Original change's description: > > Verify that tests in errors/ actually generate the expected errors. > > > > Error expectations are embedded in the source with a special *%%* > > marker, like this: > > > > /*%%* > > expected 'foo', but found 'bar' > > 'baz' is not a valid identifier > > *%%*/ > > > > This unit test compiles every effect in errors/ and verifies that it > > makes an error. It also verifies that the errors returned include the > > expectations from the *%%* marker section, in the listed order, if any > > expectations have been listed. (Error expectations are not meant to be > > exhaustive; additional errors are allowed.) > > > > In this CL, I've manually attached error expectations to the first few > > error tests. A followup CL will (mechanically) add expectations to every > > error test, based on their current error reports. > > > > Change-Id: I4add30fef6419c4d3f8d2a221c5aeb53eee35ae7 > > Bug: skia:12665 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/505399 > > Auto-Submit: John Stiles <johnstiles@google.com> > > Reviewed-by: Brian Osman <brianosman@google.com> > > Commit-Queue: Brian Osman <brianosman@google.com> > > Bug: skia:12665 > Change-Id: I3bcdbe9fc1abab13656d6462b73f6439967fd96f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/505642 > Auto-Submit: John Stiles <johnstiles@google.com> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bug: skia:12665 Change-Id: I49e23869f4ef383a0b076006e319e0a6d7191cad Reviewed-on: https://skia-review.googlesource.com/c/skia/+/505643 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2022-02-08 17:17:28 +00:00
"$_tests/SkSLErrorTest.cpp",
Bring back the harness from SkSLGLSLTest as a testbed for debugging. The code here is resuscitated from the GLSL testing harness at http://review.skia.org/317771 . Testing and debugging in dm is simpler than debugging skslc when we encounter compiler issues. Change-Id: I492dd0bbd2f0ee0b3b6a1b5253da54d72dc1eb3b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/319032 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-23 18:08:40 +00:00
"$_tests/SkSLGLSLTestbed.cpp",
Initial checkin of new SkSL interpreter. Not quite feature complete yet, but at a point where it's worth checking in. Bug: skia: Change-Id: I21141d30e8582a79e94450d84e56bacc067249e0 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201685 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-03-21 15:05:37 +00:00
"$_tests/SkSLInterpreterTest.cpp",
added support for push_constant layout BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187433003 Committed: https://skia.googlesource.com/skia/+/fa5f65ac61fd525029aa9dab161ffe4896c10f6d Review-Url: https://codereview.chromium.org/2187433003
2016-11-22 16:39:36 +00:00
"$_tests/SkSLMemoryLayoutTest.cpp",
Convert remaining Metal tests to golden outputs. Metal-specific tests are pretty thin on the ground here, and some of the remaining tests no longer added value as they were already covered pretty well by existing tests in Shared. The majority of remaining tests were specific to Metal's lack of flexible matrix casting (and SkSL's ability to paper over this with helper functions). Change-Id: I7b3c445268b95320e7f46ec88d793c315d43ee8a Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/334956 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2020-11-13 23:14:11 +00:00
"$_tests/SkSLMetalTestbed.cpp",
Migrate dedicated SPIR-V tests to golden outputs. There were a surprisingly small number of dedicated SPIR-V tests. SkSLSPIRVBadOffset was the only test that didn't already exist in the golden outputs, although it actually contained two tests. The SPIRVTest.cpp file has been converted to SPIRVTestbed.cpp, which can be used for local debugging of SPIR-V issues via dm (like GLSLTestbed and MetalTestbed). Change-Id: I978d8a7cf5735af7f537113d2b9411ce42cfcf88 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/338756 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2020-11-25 21:55:37 +00:00
"$_tests/SkSLSPIRVTestbed.cpp",
Reland "Run unit tests to verify SkSL folding behavior." This is a reland of 4ecab92584557c1a08e6edced5b0fdd2496eb2f0 This reland folds in subsequent code cleanups and disables a test that failed on Android + Vulkan. Original change's description: > Run unit tests to verify SkSL folding behavior. > > The unit test loads SkSL source files from `resources/sksl`, compiles > the code, and uses SkRuntimeEffect to render a pixel using the effect. > If solid green is rendered, the test passes. > > Change-Id: I2ccb427a907975ae84aee19d8e68d774b2cb638c > Bug: skia:11009 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/355983 > Commit-Queue: John Stiles <johnstiles@google.com> > Auto-Submit: John Stiles <johnstiles@google.com> > Reviewed-by: Brian Osman <brianosman@google.com> Bug: skia:11009 Change-Id: I09196c8ca3041e8957324a0cbb7f7d6963c6e4e7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/358523 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-01-25 15:57:47 +00:00
"$_tests/SkSLTest.cpp",
Add unit test for Type::minimumValue and Type::maximumValue. This test confirms that our logic to derive the min and max value of a given integer type actually matches reality. Change-Id: I1cb5fba6bfb9ffdcf4972d8feed79cf71e11d0ca Bug: skia:10932 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/413376 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-05-27 19:53:13 +00:00
"$_tests/SkSLTypeTest.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_tests/SkScalerCacheTest.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/SkShaperJSONWriterTest.cpp",
Revert "replace SkSharedMutex" This reverts commit cfdc07aa0ee75dd6daf1bb9a0787ba6f72438375. Reason for revert: nope, flutter windows bots don't have it. we got caught. Original change's description: > replace SkSharedMutex > > I am debugging an issue with SkSharedMutex and noticed > how sparsely it is used. That got me curious to see if > we can replace it with a std::shared_mutex (from C++17). > > Bug: skia:10177 > Change-Id: I1ce4d2a5897af198d6ae5fb850548ff917a58f50 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285691 > Reviewed-by: Ben Wagner <bungeman@google.com> > Commit-Queue: Mike Klein <mtklein@google.com> TBR=mtklein@google.com,bungeman@google.com,herb@google.com Change-Id: Iab4e55d749e386233ff0e2ba2c1cd10d5e6f1615 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:10177 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286124 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-29 18:50:26 +00:00
"$_tests/SkSharedMutexTest.cpp",
Check fullness and purge on every strike lookup In the old code, the cache was checked and perged on every reattach of a strike. That was left out of the multi-threaded code. Add the check and purge back in to maintain cache size. * Removed minimum cache size from setCacheSizeLimit. Bug: skia:10046 Change-Id: I2438c83f04b6da8133c161a29604c3c3d7f58cd8 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/277066 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-03-15 16:55:16 +00:00
"$_tests/SkStrikeCacheTest.cpp",
Added skstd::string_view Change-Id: Id02ed33b4fe60663327cc50d79db2bf876ad6df7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/415458 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2021-06-07 20:09:59 +00:00
"$_tests/SkStringViewTest.cpp",
Move GrBlockAllocator and GrTBlockList to src/core/ src/gpu/GrBlockAllocator -> src/core/SkBlockAllocator src/gpu/GrTBlockList -> src/core/SkTBlockList Tests and references also renamed. Bug: skia:12330 Change-Id: I5fad05faa3dcecd89a0a478dcf30c090ea7589f5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/441477 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2021-08-24 15:49:55 +00:00
"$_tests/SkTBlockListTest.cpp",
tests: Move SkUTF tests to their own file. Change-Id: Ib4816cae8b4f2d4f11bb03ed043c677a17d89ead Reviewed-on: https://skia-review.googlesource.com/145147 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
2018-08-02 15:26:41 +00:00
"$_tests/SkUTFTest.cpp",
Create SkVMDebugTrace player class. This class is responsible for interpreting a debug trace and allowing it to be stepped through, like a debugger. It tracks the current line number, call stack, slot values, and associates slots with stack frames. It supports stepping forward or stepping over (i.e., stepping to the next line in the current function, hiding function calls). Change-Id: I2b7d90c3b38b0006bebdfbf65a7bf678d5227d56 Bug: skia:12666 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/482460 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2021-12-10 19:45:22 +00:00
"$_tests/SkVMDebugTracePlayerTest.cpp",
Create a public base class for debug traces. SkRuntimeEffect needs an API for generating debug traces. This means that we will need references to debug traces inside a public header. Rather than reference SkVMDebugInfo directly, we now have a simpler base class for debug traces. This is better suited to landing in include/. I've also renamed SkVMDebugInfo to SkVMDebugTrace for consistency, since it now contains all the trace data. (When it was first added, it only had the slot info.) Change-Id: Ibaa4dedf9a17b9462b4f233a28a7b875d0317892 Bug: skia:12708 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/480356 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2021-12-06 17:02:20 +00:00
"$_tests/SkVMDebugTraceTest.cpp",
sketch an skvm With all the thinking around a stack-based interpreter, I figured I'd sketch out some ideas for a register VM too. I kind of have the hunch that this is the direction that will actually let us replace large amounts of Skia's CPU backend with an efficient interpreter or JIT. Change-Id: Ia2b5ba4a3fc27556f5b6ba95cd1ace46d3217403 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216665 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2019-05-29 17:57:54 +00:00
"$_tests/SkVMTest.cpp",
sketch SkVx Change-Id: I1cb8113af243ed6327179d295835295834a752aa Reviewed-on: https://skia-review.googlesource.com/c/189581 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Mike Klein <mtklein@google.com>
2019-02-05 18:42:46 +00:00
"$_tests/SkVxTest.cpp",
Fix crash when drawing a GPU-backed surface onto raster. We now null-check the result of recordingContext() before using it. Thanks cqjjjzr2@gmail.com for the initial discovery and suggested fix. Change-Id: Iafcf306f8cd9deb7147ef9c5c71a21907eedc01f Bug: skia:12214 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/429098 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2021-07-16 14:12:24 +00:00
"$_tests/Skbug12214.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/Skbug5221.cpp",
"$_tests/Skbug6389.cpp",
"$_tests/Skbug6653.cpp",
Revert "Remove custom SkSort algorithms." This reverts commit 70474c1cb0bc19a025ee678161b633cf57b0a83e. Reason for revert: bot build failure Original change's description: > Remove custom SkSort algorithms. > > SortBench shows that SkTQSort and SkTHeapSort are inferior to std::sort. > The difference is small on randomized inputs, but quite significant for > semi-ordered inputs (forward/backward/repeated). There doesn't seem to > to be any compelling advantage to SkTQSort. > > Nanobench results: https://screenshot.googleplex.com/9JOLV1d6Z0u > > (These performance numbers are from an optimized build my local machine; > it's possible that we might see different results on the test bots.) > > Change-Id: Iaf19563041547eae7de2953be249129108f093b1 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/302295 > Commit-Queue: John Stiles <johnstiles@google.com> > Reviewed-by: Mike Klein <mtklein@google.com> TBR=mtklein@google.com,brianosman@google.com,johnstiles@google.com Change-Id: I1126dd4cda95716dac225ad32d5b0e5cf3f09421 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/302447 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-07-14 00:13:51 +00:00
"$_tests/SortTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/SpecialImageTest.cpp",
"$_tests/SpecialSurfaceTest.cpp",
"$_tests/SrcOverTest.cpp",
Fix CompatibleCoverageAsAlpha flag when reducing src-over to src. Change-Id: I087ff64e0f23aee15ac2bf7b9d3c450e28400cef Reviewed-on: https://skia-review.googlesource.com/c/skia/+/274036 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2020-02-28 18:06:02 +00:00
"$_tests/SrcSrcOverBatchTest.cpp",
GIF: Avoid copying/storing data when possible If the input SkStream has a length and position, do not copy and store LZW blocks or ColorMaps. Instead, mark the position and size, and read from the stream when necessary. This will save memory in Chromium's use case, which has already buffered all of its data. In the case where we *do* need to copy, store it on the SkStreamBuffer. This allows SkGifImageReader to have simpler code. Add tests. Change-Id: Ic65fa766328ae2e5974b2084bc2099e19aced731 Reviewed-on: https://skia-review.googlesource.com/6157 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
2016-12-16 16:39:51 +00:00
"$_tests/StreamBufferTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/StreamTest.cpp",
"$_tests/StringTest.cpp",
"$_tests/StrokeTest.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/StrokerTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/SubsetPath.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/SubsetPath.h",
Revert "Revert "Revert "Revert "Don't build GL on Metal, Vulkan, Dawn, Direct3D bots"""" Updated to use sentinel GL context even when GL backend is not built. This reverts commit 1171d314efc7e131b039c94126d26575cfb9e70c. Change-Id: Ia94bbe4865ddd4e898446c13886877c539f0eb0b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/277976 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-03-19 19:54:28 +00:00
"$_tests/SurfaceSemaphoreTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/SurfaceTest.cpp",
"$_tests/SwizzlerTest.cpp",
"$_tests/TArrayTest.cpp",
"$_tests/TDPQueueTest.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/TLazyTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/TemplatesTest.cpp",
"$_tests/TestTest.cpp",
"$_tests/TextBlobCacheTest.cpp",
"$_tests/TextBlobTest.cpp",
Add native caching of uniquely keyed GrTextureProxies (take 2) TBR=bsalomon@google.com Change-Id: I590dcdc85fb60706c7eb06277694791dc04c9141 Reviewed-on: https://skia-review.googlesource.com/49543 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2017-09-21 12:26:08 +00:00
"$_tests/TextureProxyTest.cpp",
Fix GrTextureStripAtlasManager cleanup order bug Bug: 820703 Change-Id: I6f1a895ceb213d38361bc03a472cf2a48e4720a5 Reviewed-on: https://skia-review.googlesource.com/115001 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-03-19 14:57:42 +00:00
"$_tests/TextureStripAtlasManagerTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/Time.cpp",
"$_tests/TopoSortTest.cpp",
Revert "Revert "Revert "Revert "Don't build GL on Metal, Vulkan, Dawn, Direct3D bots"""" Updated to use sentinel GL context even when GL backend is not built. This reverts commit 1171d314efc7e131b039c94126d26575cfb9e70c. Change-Id: Ia94bbe4865ddd4e898446c13886877c539f0eb0b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/277976 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
2020-03-19 19:54:28 +00:00
"$_tests/TraceMemoryDumpTest.cpp",
Add support for object creation/snapshot/deletion events - Bring back some previously deleted macros and helper types. - Automatically inject base_type information into snapshot events, to allow simpler tracking of polymorphic object types. - Fix JSON formatting of pointer values (they were serializing as bool). Bug: skia: Change-Id: Iac7803f72ce5396ffd2fbcb5a36d76745c5e3f3e Reviewed-on: https://skia-review.googlesource.com/28220 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com>
2017-08-01 14:23:38 +00:00
"$_tests/TracingTest.cpp",
Revert "Revert "Clean up onTransferPixels"" Bug: skia:5126 Change-Id: Ia1eaef56cca266ad4c413e711e63646e913222be Reviewed-on: https://skia-review.googlesource.com/20445 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
2017-06-21 19:55:46 +00:00
"$_tests/TransferPixelsTest.cpp",
harmonize rewrite-includes and gn-format checks The CheckGeneratedFiles bot only required rewriting .gn files, while the presubmit wants both .gn and .gni files. It also appears that the #includes rewrite script runs on both the presubmit and CheckGeneratedFiles bots. These presubmits run on the CQ before landing right? If so, no need for them in the CheckGeneratedFIles bot at all. And of course, format .gni files. Change-Id: Icd4526d62f85088862ad93566cc9ace11dc3e33f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281505 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
2020-04-03 15:59:37 +00:00
"$_tests/TriangulatingPathRendererTests.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/TypefaceTest.cpp",
"$_tests/UnicodeTest.cpp",
"$_tests/UtilsTest.cpp",
vertices to/from data precursor to enabling serialization in pictures BUG=skia:6366 Change-Id: Iba89aa98f389b3281e7705d041e3337e89071f03 Reviewed-on: https://skia-review.googlesource.com/9680 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Mike Reed <reed@google.com>
2017-03-14 18:10:54 +00:00
"$_tests/VerticesTest.cpp",
Update getBackendInfo calls on GrBackendTexture to support VkImageLayout better. The big api level change here is that the getBackendInfo calls now return by value instead of a pointer. These changes are being made in support of Vulkan so that the client can update the VkImageLayout on the GrBackendTexture and have that update get reflected in our internal tracking of the image. This is done by storing a ref counted GrVkImageLayout object on the GrBackendTexture and the GrVkImage. Bug: skia: Change-Id: I8c6158fd3a66eb61fef97ebf09ea5364bca3f1ae Reviewed-on: https://skia-review.googlesource.com/119101 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-04-10 13:34:07 +00:00
"$_tests/VkBackendSurfaceTest.cpp",
Add drawDrawable support to GrRenderTargetContext. This also includes adding drawable Op and plumbing it through to the GPU. BUG=skia: Change-Id: I0b2464c5a458c2fbf05b9528e47b9e6e3ac27d57 Reviewed-on: https://skia-review.googlesource.com/c/9645 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-10-19 17:54:56 +00:00
"$_tests/VkDrawableTest.cpp",
Add hardware buffer unit test from old skqp to skia. This copies the hardware buffer unit test from, which was cherry picked straight into skqp last year, into Skia proper. There are not functional changes, but a few of the APIs have been updated to work with newer Skia. Bug: skia: Change-Id: I2d7b2ed8b0b9314ca3e03e703a6a5ac53805275e Reviewed-on: https://skia-review.googlesource.com/c/188034 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2019-01-30 20:13:22 +00:00
"$_tests/VkHardwareBufferTest.cpp",
Add unit test to check if we can create a VkDevice using global priority extension. Bug: b/126595186 Change-Id: I0a23ca2a7cc47bd02bb535566aa37627899249ee Reviewed-on: https://skia-review.googlesource.com/c/skia/+/197201 Reviewed-by: Jim Van Verth <jvanverth@google.com> Reviewed-by: Stan Iliev <stani@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2019-03-04 20:35:23 +00:00
"$_tests/VkPriorityExtensionTest.cpp",
Enable creating protected vulkan backend This CL allows user to indicate that they have a protected content in GrVkBackendContext creation which results in protected CommandPool and Queue usage. Bug: skia:9016 Change-Id: I6a478d688b6988c2c5e5e98f18f58fb21f9d26ae Reviewed-on: https://skia-review.googlesource.com/c/skia/+/210067 Commit-Queue: Greg Daniel <egdaniel@google.com> Auto-Submit: Emircan Uysaler <emircan@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
2019-06-24 14:53:09 +00:00
"$_tests/VkProtectedContextTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/VkWrapTests.cpp",
Reland: Enable YCbCr sampler support on platforms other than Android Previously YCbCr Vulkan samplers were supported only on Android for external images, while Vulkan requires YCbCr sampler for I420 YUV image formats such as VK_FORMAT_G8_B8_R8_3PLANE_420_UNORM, VK_FORMAT_G8_B8R8_2PLANE_420_UNORM. This CL: - Adds VK_FORMAT_G8_B8_R8_3PLANE_420_UNORM and VK_FORMAT_G8_B8R8_2PLANE_420_UNORM as supported Vulkan formats - Updates GrVkYcbcrConversionInfo to add fFormat field and allow fExternalFormat=0. - Removes assertions format=VK_FORMAT_UNDEFINED for all images that have ycbcr info. Bug: chromium:981022 Change-Id: Id4d81b20d9fda4d9ad0831f77e6025eed3db2bfd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/233776 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
2019-08-12 05:46:33 +00:00
"$_tests/VkYcbcrSamplerTest.cpp",
Fix blending bug in animated webp decodes Bug: webp:490 Depending on the encoded image, SkWebpCodec may need to blend the the output from libwebp with the prior frame. It does so using the method blend_line, which expects the libwebp output to be unpremul. Prior to this commit, SkWebpCodec sometimes told libwebp to premultiply, and then passed that premultiplied data to blend_line, which premultiplied again. Use webpInfo's alphaType to decide whether to premultiply. Consolidate choosing its alphaType into one block. The functional difference is that if (blendWithPrevFrame), we no longer premul if the dst is kPremul. Move declaration of webDst to where it's used. Add a test. Change-Id: Ic0cfb4d918c2ab434c6787ed5a532c4d1e67fa17 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/342618 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Derek Sollenberger <djsollen@google.com> Auto-Submit: Leon Scroggins <scroggo@google.com>
2020-12-09 18:33:17 +00:00
"$_tests/WebpTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/WindowRectanglesTest.cpp",
Copy on write for wrapped backend texture surfaces. Makes SkImage_Gpu backed by two proxies, an original and a copy. The image uses the original until a new render task is bound to it at which point further uses of the image will use the copy. If the image is ever used off a GrDirectContext we fall over to the copy. If the copy is never used and never can be used by the next flush then the render task that populates it is marked "skipped" and we don't perform the copy. Bug: skia:11208 Change-Id: Id255f4a733acc608c8a53c1a5633207aeafc404b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/366282 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2021-03-05 19:00:07 +00:00
"$_tests/WrappedSurfaceCopyOnWriteTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/WritePixelsTest.cpp",
"$_tests/Writer32Test.cpp",
"$_tests/YUVCacheTest.cpp",
"$_tests/YUVTest.cpp",
]
SKQP Build for Fuchsia SDK Change-Id: I2619784eca0f7a4dd66f2db0104cb746d9266b4e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244369 Commit-Queue: John Rosasco <rosasco@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2019-09-25 21:14:35 +00:00
gl_tests_sources = [
"$_tests/EGLImageTest.cpp",
"$_tests/GrGLExtensionsTest.cpp",
"$_tests/RectangleTextureTest.cpp",
"$_tests/TextureBindingsResetTest.cpp",
]
Detect whether trying to blit a Metal swapchain texture, and fail if so. Metal swapchain textures (equivalent to GL's FBO 0) can't be used with MTLBlitCommandEncoder. For copySurface we need to detect this and fail. Future changes will handle GrSurfaceProxy. Change-Id: I9235d91cf31e96260c8d1da5938f5441d2e49d27 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/252045 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
2019-11-11 21:14:13 +00:00
metal_tests_sources = [
"$_tests/MtlBackendAllocationTest.mm",
"$_tests/MtlCopySurfaceTest.mm",
]
Direct backend object allocation API Change-Id: Ie8733a4db8061c67678a41cf239ce4407e967df7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212965 Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-05-16 16:43:11 +00:00
[graphite] Set up unit testing system Bug: skia:12466 Change-Id: I401a185d818a964327d323b9ebcd0850ec0b1c9b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/457318 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-10-11 15:28:21 +00:00
graphite_tests_sources = [
[graphite] Add Context create/deleteBackendTexture calls. Bug: skia:12633 Change-Id: Ida78c4145423376dc0267096a1d758b74144fd0c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/477139 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2021-11-30 17:02:30 +00:00
"$_tests/graphite/BackendTextureTest.cpp",
[graphite] Add command buffer test Adds test of command buffer submission with GPU recording (if enabled). Also adds programmatic GPU recording support. Bug: skia:12466 Change-Id: I85aba9f7e5e09f62f2ddc7040d1ff84bb9b4ae09 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/460337 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
2021-10-18 16:15:47 +00:00
"$_tests/graphite/CommandBufferTest.cpp",
[graphite] Add an IntersectionTree class Implements a BSP tree with NEON/SSE optimizations that tracks non-overlapping regions. This object can be used batch sets of paths into non-overlapping draws. Performance on AppleM1 with our existing benchmarks looks very promising: desk_motionmarkarcs.skp 1227 paths -> 69 draws 450us desk_motionmarksuits.skp 1417 paths -> 26 draws 201us desk_chalkboard.skp 1940 paths -> 11 draws 84us desk_ynevsvg.skp 859 paths -> 10 draws 31us desk_micrographygirl.skp 318 paths -> 29 draws 11us Bug: skia:12466 Change-Id: I847a93ed726dea10cb403cb76e578bd81eb920d2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/460298 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Herb Derby <herb@google.com>
2021-10-19 19:04:41 +00:00
"$_tests/graphite/IntersectionTreeTest.cpp",
[graphite] Switch PaintParamsKey over to a builder/result model This will leave the PaintParamsKeys more clearly immutable and manage more of the cruft of key creation (e.g., beginBlock/endBlock pairing). Bug: skia:12701 Change-Id: I1944397465f845e974e950f47cedb90c3f1895b1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/506881 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2022-02-16 14:56:32 +00:00
"$_tests/graphite/KeyTest.cpp",
[graphite] More testing infrastructure With this CL we can run as: dm --src gm skp tests --config grmtl -v --nocpu --nogpu and not get all the non-Graphite unit tests. Bug: skia:12466 Change-Id: Ib3f04f315fe4b5731a54e4c72979a0c1e00baf24 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/457898 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2021-10-13 14:37:36 +00:00
"$_tests/graphite/MaskTest.cpp",
[graphite] Store back pointers of Device and Recorder to each other. It is safe to store raw pointers to these objects since they are both always accessed on the same thread we can safely invalidate their back pointers when needed. This allows us to remove a ref of Recorder on Device. Bug: skia:12794 Change-Id: Icb5e079f7e820824520d52e48012b447e714a9ee Reviewed-on: https://skia-review.googlesource.com/c/skia/+/494239 Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2022-01-13 14:48:57 +00:00
"$_tests/graphite/RecorderTest.cpp",
[graphite] More testing infrastructure With this CL we can run as: dm --src gm skp tests --config grmtl -v --nocpu --nogpu and not get all the non-Graphite unit tests. Bug: skia:12466 Change-Id: Ib3f04f315fe4b5731a54e4c72979a0c1e00baf24 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/457898 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2021-10-13 14:37:36 +00:00
"$_tests/graphite/RectTest.cpp",
[graphite] Set up unit testing system Bug: skia:12466 Change-Id: I401a185d818a964327d323b9ebcd0850ec0b1c9b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/457318 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-10-11 15:28:21 +00:00
"$_tests/graphite/ShapeTest.cpp",
[graphite] Add Transform that wraps matrix, inverse, type and scale factors Transform.h is named Transform_graphite.h to avoid collision with Transform.h in skottie/src Bug: skia:12466 Change-Id: I017eee2bffe1a0aad605221e67540f732c2ee6b9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/459719 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2021-10-15 17:22:44 +00:00
"$_tests/graphite/TransformTest.cpp",
[graphite] Add caches for uniformdata and programs Bug: skia:12466 Change-Id: Id61b019b583357bb9474c58a81270b0b860c9c4f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/464120 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-10-28 13:58:10 +00:00
"$_tests/graphite/UniformCacheTest.cpp",
[graphite] Expand shader precompilation placeholder Bug: skia:12466 Change-Id: If633ce39c8f45b1ee3c042b5b72d7e0f95ca5c19 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/459597 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-10-26 18:47:58 +00:00
"$_tests/graphite/UniformTest.cpp",
[graphite] Set up unit testing system Bug: skia:12466 Change-Id: I401a185d818a964327d323b9ebcd0850ec0b1c9b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/457318 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-10-11 15:28:21 +00:00
]
[graphite] Add Context create/deleteBackendTexture calls. Bug: skia:12633 Change-Id: Ida78c4145423376dc0267096a1d758b74144fd0c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/477139 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2021-11-30 17:02:30 +00:00
graphite_metal_tests_sources = [ "$_tests/graphite/MtlBackendTextureTest.mm" ]
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
pathops_tests_sources = [
"$_tests/PathOpsAngleIdeas.cpp",
"$_tests/PathOpsAngleTest.cpp",
fixup winding contours Add AsWinding to convert SkPath with even odd fill to winding fill. This basic implementation works for simple non-intersecting paths. It may fail if contours in paths touch, specifically when the leftmost point in a contour is shared with another contour. The incomplete parts are marked with TODO in the code. If this interface and implementation look promising, I will continue to tackle the more difficult cases. R=reed@google.com,bungeman@google.com Bug: skia:7682 Change-Id: I479fba60072eb1391b451fcb819504245da2e2a9 Reviewed-on: https://skia-review.googlesource.com/147044 Commit-Queue: Cary Clark <caryclark@google.com> Reviewed-by: Mike Reed <reed@google.com>
2018-08-16 15:53:54 +00:00
"$_tests/PathOpsAsWindingTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/PathOpsBattles.cpp",
"$_tests/PathOpsBoundsTest.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/PathOpsBuildUseTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/PathOpsBuilderConicTest.cpp",
"$_tests/PathOpsBuilderTest.cpp",
"$_tests/PathOpsChalkboardTest.cpp",
"$_tests/PathOpsConicIntersectionTest.cpp",
"$_tests/PathOpsConicLineIntersectionTest.cpp",
"$_tests/PathOpsConicQuadIntersectionTest.cpp",
"$_tests/PathOpsCubicConicIntersectionTest.cpp",
"$_tests/PathOpsCubicIntersectionTest.cpp",
"$_tests/PathOpsCubicIntersectionTestData.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/PathOpsCubicIntersectionTestData.h",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/PathOpsCubicLineIntersectionIdeas.cpp",
"$_tests/PathOpsCubicLineIntersectionTest.cpp",
"$_tests/PathOpsCubicQuadIntersectionTest.cpp",
"$_tests/PathOpsCubicReduceOrderTest.cpp",
"$_tests/PathOpsDCubicTest.cpp",
"$_tests/PathOpsDLineTest.cpp",
"$_tests/PathOpsDPointTest.cpp",
"$_tests/PathOpsDRectTest.cpp",
"$_tests/PathOpsDVectorTest.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/PathOpsDebug.cpp",
"$_tests/PathOpsDebug.h",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/PathOpsExtendedTest.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/PathOpsExtendedTest.h",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/PathOpsFuzz763Test.cpp",
"$_tests/PathOpsInverseTest.cpp",
"$_tests/PathOpsIssue3651.cpp",
"$_tests/PathOpsLineIntersectionTest.cpp",
"$_tests/PathOpsLineParametetersTest.cpp",
"$_tests/PathOpsOpCircleThreadedTest.cpp",
"$_tests/PathOpsOpCubicThreadedTest.cpp",
"$_tests/PathOpsOpLoopThreadedTest.cpp",
"$_tests/PathOpsOpRectThreadedTest.cpp",
"$_tests/PathOpsOpTest.cpp",
"$_tests/PathOpsQuadIntersectionTest.cpp",
"$_tests/PathOpsQuadIntersectionTestData.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/PathOpsQuadIntersectionTestData.h",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/PathOpsQuadLineIntersectionTest.cpp",
"$_tests/PathOpsQuadLineIntersectionThreadedTest.cpp",
"$_tests/PathOpsQuadReduceOrderTest.cpp",
"$_tests/PathOpsSimplifyDegenerateThreadedTest.cpp",
"$_tests/PathOpsSimplifyFailTest.cpp",
"$_tests/PathOpsSimplifyQuadThreadedTest.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/PathOpsSimplifyQuadralateralsThreadedTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/PathOpsSimplifyRectThreadedTest.cpp",
"$_tests/PathOpsSimplifyTest.cpp",
"$_tests/PathOpsSimplifyTrianglesThreadedTest.cpp",
"$_tests/PathOpsSkpTest.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/PathOpsTSectDebug.h",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/PathOpsTestCommon.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/PathOpsTestCommon.h",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/PathOpsThreadedCommon.cpp",
Tests: re-sort gni, file name convention Change-Id: I47c4b91805770bd68101e1503a8630243ef16c21 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212022 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com> Auto-Submit: Hal Canary <halcanary@google.com>
2019-05-03 15:48:07 +00:00
"$_tests/PathOpsThreadedCommon.h",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
"$_tests/PathOpsThreeWayTest.cpp",
"$_tests/PathOpsTigerTest.cpp",
"$_tests/PathOpsTightBoundsTest.cpp",
"$_tests/PathOpsTypesTest.cpp",
Reland "Add an implementation and log2 variants for Wang's formula" This is a reland of e278e1c1c7438217891eb272ab1e63c95d636e5b Original change's description: > Add an implementation and log2 variants for Wang's formula > > Wang's formulas for cubics and quadratics (1985) tell us how many line > segments a curve must be chopped into when tessellating. This CL adds > an implementation along with optimized log2 variants, as well as tests > and a benchmark. > > Change-Id: I3f777b8d0312c57c3a1cc24307de5945c70be287 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/288321 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Chris Dalton <csmartdalton@google.com> TBR=bsalomon@google.com Change-Id: Ie3822c62439fc579a59ea8adb49583224de41aa5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289680 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
2020-05-14 01:18:46 +00:00
"$_tests/WangsFormulaTest.cpp",
Create .gni files for samples, tests, gms, and benches. Calling Python to find all these files is convenient, but error-prone. It's easy to forget to call GN again when adding a file. Each of these calls to Python also adds ~50ms to the run time of gn gen, which is small but adds up. On my desktop, gn gen drops from 600ms to 150ms, noticeably faster. This leaves one call to find.py for generating skia.h for fiddle. We're not quite sure how to automate that process to happen entirely inside the :skia.h action while maintaining correct dependencies, so I'm leaving it for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4036 Change-Id: Ib9d355b97900f29afebc65311ceef50537e46dda Reviewed-on: https://skia-review.googlesource.com/4036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2016-10-27 16:21:40 +00:00
]
Make GrClipStack, GrClipStackClip, and GrReducedClip OGA-only GrStencilClip and GrStencilMaskHelper just come along for the ride Bug: skia:11837 Change-Id: I7cfa2dd620b7457e6b6be4abf91b1ecd415d9b73 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/417680 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2021-06-14 19:27:19 +00:00
Rename gn options to skgpu_v1 and skgpu_v2 Bug: skia:11837 Change-Id: Ie9221d2cd8e42bebb6a8a9a8ef51ba4a488ce6ca Reviewed-on: https://skia-review.googlesource.com/c/skia/+/424036 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-07-01 16:12:52 +00:00
skgpu_v1_tests_sources = [
Feed all top-level GPU accessors through skgpu::BaseDevice (take 2) This pulls the GPU-specific accessors off of SkCanvas and SkDevice - moving them all to skgpu::BaseDevice and SkCanvasPriv. This will allow us to more easily change the gpu class hierarchy (esp. changing GrSurfaceDrawContext to skgpu::v1:SurfaceDrawContext) w/o churning the public API. TBR=brianosman@google.com Bug: skia:11837 Change-Id: Ib69a3ea27c840fa7758bc3318395a27228c7ae9d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431539 Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-07-22 19:11:03 +00:00
"$_tests/BulkRectTest.cpp",
Update tests for a V1-only skgpu::v1::SurfaceDrawContext Bug: skia:11837 Change-Id: If8dd864d6cd8bc5ab9569fbab40866e1810dbc27 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/434162 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-07-29 15:23:48 +00:00
"$_tests/ClearTest.cpp",
"$_tests/DMSAATest.cpp",
"$_tests/DefaultPathRendererTest.cpp",
Make remaining GrOp derived classes be skgpu::v1 only I will follow up with a CL actually moving the newly V1-only files to their final homes and adding namespaces. Bug: skia:11837 Change-Id: I0fed1a802ae93a4357c53cde2b665ad6ddb49a6f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/418996 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-08-13 19:21:42 +00:00
"$_tests/DrawOpAtlasTest.cpp",
Make GrPathRenderer and all derived class be OGA-only Bug: skia:11837 Change-Id: I92aacf8b412d0158036a5f27aa767590e426bd5c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/417657 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-06-16 16:05:54 +00:00
"$_tests/GrClipStackTest.cpp",
Move more gms and tests into the V1-only pile Making GrDrawRandomOp and test_ops V1-only drags several GMs and tests with them. All the other GMs/tests explicitly require Ops. Bug: skia:11837 Change-Id: I45c0a1054c3b1ec43f509595c6492581d10314cf Reviewed-on: https://skia-review.googlesource.com/c/skia/+/425016 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-07-06 17:43:56 +00:00
"$_tests/GrMeshTest.cpp",
Update tests for a V1-only skgpu::v1::SurfaceDrawContext Bug: skia:11837 Change-Id: If8dd864d6cd8bc5ab9569fbab40866e1810dbc27 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/434162 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-07-29 15:23:48 +00:00
"$_tests/GrMipMappedTest.cpp",
Move more gms and tests into the V1-only pile Making GrDrawRandomOp and test_ops V1-only drags several GMs and tests with them. All the other GMs/tests explicitly require Ops. Bug: skia:11837 Change-Id: I45c0a1054c3b1ec43f509595c6492581d10314cf Reviewed-on: https://skia-review.googlesource.com/c/skia/+/425016 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-07-06 17:43:56 +00:00
"$_tests/GrPipelineDynamicStateTest.cpp",
Feed all top-level GPU accessors through skgpu::BaseDevice (take 2) This pulls the GPU-specific accessors off of SkCanvas and SkDevice - moving them all to skgpu::BaseDevice and SkCanvasPriv. This will allow us to more easily change the gpu class hierarchy (esp. changing GrSurfaceDrawContext to skgpu::v1:SurfaceDrawContext) w/o churning the public API. TBR=brianosman@google.com Bug: skia:11837 Change-Id: Ib69a3ea27c840fa7758bc3318395a27228c7ae9d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/431539 Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-07-22 19:11:03 +00:00
"$_tests/GrThreadSafeCacheTest.cpp",
Update tests for a V1-only skgpu::v1::SurfaceDrawContext Bug: skia:11837 Change-Id: If8dd864d6cd8bc5ab9569fbab40866e1810dbc27 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/434162 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-07-29 15:23:48 +00:00
"$_tests/LazyProxyTest.cpp",
Move more gms and tests into the V1-only pile Making GrDrawRandomOp and test_ops V1-only drags several GMs and tests with them. All the other GMs/tests explicitly require Ops. Bug: skia:11837 Change-Id: I45c0a1054c3b1ec43f509595c6492581d10314cf Reviewed-on: https://skia-review.googlesource.com/c/skia/+/425016 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-07-06 17:43:56 +00:00
"$_tests/OpChainTest.cpp",
Make GrPathRenderer and all derived class be OGA-only Bug: skia:11837 Change-Id: I92aacf8b412d0158036a5f27aa767590e426bd5c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/417657 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-06-16 16:05:54 +00:00
"$_tests/PathRendererCacheTests.cpp",
Update tests for a V1-only skgpu::v1::SurfaceDrawContext Bug: skia:11837 Change-Id: If8dd864d6cd8bc5ab9569fbab40866e1810dbc27 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/434162 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-07-29 15:23:48 +00:00
"$_tests/PrimitiveProcessorTest.cpp",
"$_tests/ProcessorTest.cpp",
Move more gms and tests into the V1-only pile Making GrDrawRandomOp and test_ops V1-only drags several GMs and tests with them. All the other GMs/tests explicitly require Ops. Bug: skia:11837 Change-Id: I45c0a1054c3b1ec43f509595c6492581d10314cf Reviewed-on: https://skia-review.googlesource.com/c/skia/+/425016 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-07-06 17:43:56 +00:00
"$_tests/ProgramsTest.cpp",
Update tests for a V1-only skgpu::v1::SurfaceDrawContext Bug: skia:11837 Change-Id: If8dd864d6cd8bc5ab9569fbab40866e1810dbc27 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/434162 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-07-29 15:23:48 +00:00
"$_tests/SkSLCross.cpp",
Move more gms and tests into the V1-only pile Making GrDrawRandomOp and test_ops V1-only drags several GMs and tests with them. All the other GMs/tests explicitly require Ops. Bug: skia:11837 Change-Id: I45c0a1054c3b1ec43f509595c6492581d10314cf Reviewed-on: https://skia-review.googlesource.com/c/skia/+/425016 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-07-06 17:43:56 +00:00
"$_tests/SurfaceDrawContextTest.cpp",
"$_tests/TextureOpTest.cpp",
Make GrPathRenderer and all derived class be OGA-only Bug: skia:11837 Change-Id: I92aacf8b412d0158036a5f27aa767590e426bd5c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/417657 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-06-16 16:05:54 +00:00
]
Make GrClipStack, GrClipStackClip, and GrReducedClip OGA-only GrStencilClip and GrStencilMaskHelper just come along for the ride Bug: skia:11837 Change-Id: I7cfa2dd620b7457e6b6be4abf91b1ecd415d9b73 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/417680 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2021-06-14 19:27:19 +00:00
Rename gn options to skgpu_v1 and skgpu_v2 Bug: skia:11837 Change-Id: Ie9221d2cd8e42bebb6a8a9a8ef51ba4a488ce6ca Reviewed-on: https://skia-review.googlesource.com/c/skia/+/424036 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2021-07-01 16:12:52 +00:00
tests_sources += skgpu_v1_tests_sources
Reference in New Issue Copy Permalink