skia2/tests/sksl/inliner/golden/InlineWithModifiedArgument.glsl


out vec4 sk_FragColor;
void main() {
    float _0_parameterWrite;
    float _1_x = 1.0;
    _1_x *= 2.0;
    _0_parameterWrite = _1_x;
    sk_FragColor.x = _0_parameterWrite;

}
Migrate SkSL inliner tests to golden files. Our lack of proper caps-bits controls in skslc affects the outcome of one test: "InlinerWrapsEarlyReturnsWithDoWhileBlock" does not actually emit the do-while block because the standalone caps bits don't enable do-while support. This will be fixed in a followup CL that adds caps-bit support to our tests. A few tests were renamed for consistency, a few were simplified slightly and one test was removed because it was simply redundant (there was a second test that covered the exact same ground as `ForWithReturnInsideCannotBeInlined`). Change-Id: I2e3b97cb3aea331b6d806bdb865aa78c35c7a6b9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316997 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> 2020-09-15 14:10:43 +00:00
Align default values of GrShaderCaps with StandaloneShaderCaps. `fBuiltinFMASupport` is now true on both, and `fUsesPrecisionModifiers` is now false. Other mismatching flags exist, but they are non-trivial to synchronize as they are tied to extension strings. This will help our skslc-based unit tests generate the same results as our C++ unit tests did, but should not affect real-world results as these defaults will all be overwritten in a non-testing scenario. In practice, the `fUsesPrecisionModifiers` change is responsible for all of the diffs below. The other flags did not change the results of any of the currently-ported tests. Change-Id: Ieb056d852b027fa87c56fd89f971a77a10a8a124 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317204 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> 2020-09-15 20:09:11 +00:00			`out vec4 sk_FragColor;`
Migrate SkSL inliner tests to golden files. Our lack of proper caps-bits controls in skslc affects the outcome of one test: "InlinerWrapsEarlyReturnsWithDoWhileBlock" does not actually emit the do-while block because the standalone caps bits don't enable do-while support. This will be fixed in a followup CL that adds caps-bit support to our tests. A few tests were renamed for consistency, a few were simplified slightly and one test was removed because it was simply redundant (there was a second test that covered the exact same ground as `ForWithReturnInsideCannotBeInlined`). Change-Id: I2e3b97cb3aea331b6d806bdb865aa78c35c7a6b9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316997 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> 2020-09-15 14:10:43 +00:00			`void main() {`
Revert "Eliminate inliner temporary variables for functions with a single exit." This reverts commit 345d72124d35b7c434be7bd9b6b16a66fbd980e6. Reason for revert: can break ES2 for-loop rules Original change's description: > Eliminate inliner temporary variables for functions with a single exit. > > When we determine that a function only contains a single return > statement, there is no need to create a temporary variable and store the > result expression into a variable. Instead, we can directly replace the > function-call expression with the return-statement's expression. > > This dramatically simplifies the final optimized output from chains of > very simple inlined functions, which is a very common pattern for trees > of Skia fragment processors. > > Change-Id: I6789064a321daf43db2e1cef4915f25ed74d6131 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/344665 > Commit-Queue: John Stiles <johnstiles@google.com> > Reviewed-by: Brian Osman <brianosman@google.com> > Auto-Submit: John Stiles <johnstiles@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I60845f22159605a06047b030e2686a769121a35a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/345120 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> 2020-12-16 18:24:48 +00:00			`float _0_parameterWrite;`
Align default values of GrShaderCaps with StandaloneShaderCaps. `fBuiltinFMASupport` is now true on both, and `fUsesPrecisionModifiers` is now false. Other mismatching flags exist, but they are non-trivial to synchronize as they are tied to extension strings. This will help our skslc-based unit tests generate the same results as our C++ unit tests did, but should not affect real-world results as these defaults will all be overwritten in a non-testing scenario. In practice, the `fUsesPrecisionModifiers` change is responsible for all of the diffs below. The other flags did not change the results of any of the currently-ported tests. Change-Id: Ieb056d852b027fa87c56fd89f971a77a10a8a124 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317204 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> 2020-09-15 20:09:11 +00:00			`float _1_x = 1.0;`
Avoid creating unnecessary scopes during inlining. The additional scopes were harmless, but didn't really add any value. Originally they were used to tightly scope inlined variables, but we now mangle inlined variable names. Change-Id: I7b35e737598036c0b6d3d9f71cbcd4a53d609ce9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/344757 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> 2020-12-15 20:21:03 +00:00			`_1_x *= 2.0;`
Revert "Eliminate inliner temporary variables for functions with a single exit." This reverts commit 345d72124d35b7c434be7bd9b6b16a66fbd980e6. Reason for revert: can break ES2 for-loop rules Original change's description: > Eliminate inliner temporary variables for functions with a single exit. > > When we determine that a function only contains a single return > statement, there is no need to create a temporary variable and store the > result expression into a variable. Instead, we can directly replace the > function-call expression with the return-statement's expression. > > This dramatically simplifies the final optimized output from chains of > very simple inlined functions, which is a very common pattern for trees > of Skia fragment processors. > > Change-Id: I6789064a321daf43db2e1cef4915f25ed74d6131 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/344665 > Commit-Queue: John Stiles <johnstiles@google.com> > Reviewed-by: Brian Osman <brianosman@google.com> > Auto-Submit: John Stiles <johnstiles@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I60845f22159605a06047b030e2686a769121a35a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/345120 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> 2020-12-16 18:24:48 +00:00			`_0_parameterWrite = _1_x;`
			`sk_FragColor.x = _0_parameterWrite;`
Migrate SkSL inliner tests to golden files. Our lack of proper caps-bits controls in skslc affects the outcome of one test: "InlinerWrapsEarlyReturnsWithDoWhileBlock" does not actually emit the do-while block because the standalone caps bits don't enable do-while support. This will be fixed in a followup CL that adds caps-bit support to our tests. A few tests were renamed for consistency, a few were simplified slightly and one test was removed because it was simply redundant (there was a second test that covered the exact same ground as `ForWithReturnInsideCannotBeInlined`). Change-Id: I2e3b97cb3aea331b6d806bdb865aa78c35c7a6b9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316997 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> 2020-09-15 14:10:43 +00:00
			`}`