2021-01-14 19:18:10 +00:00
|
|
|
OpCapability Shader
|
|
|
|
%1 = OpExtInstImport "GLSL.std.450"
|
|
|
|
OpMemoryModel Logical GLSL450
|
2021-05-14 11:55:45 +00:00
|
|
|
OpEntryPoint Fragment %_entrypoint_v "_entrypoint" %sk_FragColor %sk_Clockwise
|
|
|
|
OpExecutionMode %_entrypoint_v OriginUpperLeft
|
2021-01-14 19:18:10 +00:00
|
|
|
OpName %sk_FragColor "sk_FragColor"
|
|
|
|
OpName %sk_Clockwise "sk_Clockwise"
|
|
|
|
OpName %test "test"
|
2021-05-14 11:55:45 +00:00
|
|
|
OpName %_entrypoint_v "_entrypoint_v"
|
2021-01-14 19:18:10 +00:00
|
|
|
OpName %main "main"
|
|
|
|
OpDecorate %sk_FragColor RelaxedPrecision
|
|
|
|
OpDecorate %sk_FragColor Location 0
|
|
|
|
OpDecorate %sk_FragColor Index 0
|
|
|
|
OpDecorate %sk_Clockwise BuiltIn FrontFacing
|
Revert "Refactored SPIR-V RelaxedPrecision handling"
This reverts commit 9e476b798f03930b6bc7fb6eacab574f197e172d.
Reason for revert: Angry Vulkan bots
Original change's description:
> Refactored SPIR-V RelaxedPrecision handling
>
> The RelaxedPrecision decoration is now handled by nextId(), to make it
> easier to see all spots where a RelaxedPrecision decoration might be
> necessary. The goal of this initial refactor is not to actually fix the
> issues with RelaxedPrecision decorations, but rather to lay the
> groundwork for doing so in followup CLs.
>
> The initial intent of this change was to not affect the SPIR-V at all,
> saving modifications for followups, but there ended up being three kinds
> of changes to the output:
>
> 1. Doing things at nextId() time rather than later means some
> decorations move to an earlier spot in the output. This results in
> diffs, but should not cause any behavioral changes.
> 2. We were incorrectly tagging bools as RelaxedPrecision in some
> situations. By funneling things through fewer code paths, the refactor
> would have caused this to happen in even more situations, and the code
> responsible for the bug was being rewritten in this CL anyway, so it
> seemed worth just fixing the issue as part of this change.
> 3. Funneling things through fewer code paths ended up adding
> (correct) RelaxedPrecision modifiers to binary operations that had
> previously been missing them. It seemed better to just let it happen
> than to try to maintain bug-for-bug compatibility with the previous
> approach.
>
> Change-Id: Ia9654d6b5754e2c797e02226660cb618c9189b36
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/384318
> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>
TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com
Change-Id: I9ada728e5fd5798bc1179640560c2e6045b7efd1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/385158
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2021-03-15 21:24:32 +00:00
|
|
|
OpDecorate %test RelaxedPrecision
|
2021-03-17 18:12:20 +00:00
|
|
|
OpDecorate %_arr_float_int_4 ArrayStride 16
|
2021-05-14 11:55:45 +00:00
|
|
|
OpDecorate %17 RelaxedPrecision
|
|
|
|
OpDecorate %33 RelaxedPrecision
|
2021-03-23 18:16:52 +00:00
|
|
|
OpDecorate %36 RelaxedPrecision
|
2021-05-14 11:55:45 +00:00
|
|
|
OpDecorate %39 RelaxedPrecision
|
|
|
|
OpDecorate %42 RelaxedPrecision
|
|
|
|
OpDecorate %43 RelaxedPrecision
|
2021-01-14 19:18:10 +00:00
|
|
|
%float = OpTypeFloat 32
|
|
|
|
%v4float = OpTypeVector %float 4
|
|
|
|
%_ptr_Output_v4float = OpTypePointer Output %v4float
|
|
|
|
%sk_FragColor = OpVariable %_ptr_Output_v4float Output
|
|
|
|
%bool = OpTypeBool
|
|
|
|
%_ptr_Input_bool = OpTypePointer Input %bool
|
|
|
|
%sk_Clockwise = OpVariable %_ptr_Input_bool Input
|
|
|
|
%int = OpTypeInt 32 1
|
|
|
|
%int_4 = OpConstant %int 4
|
|
|
|
%_arr_float_int_4 = OpTypeArray %float %int_4
|
|
|
|
%_ptr_Private__arr_float_int_4 = OpTypePointer Private %_arr_float_int_4
|
|
|
|
%test = OpVariable %_ptr_Private__arr_float_int_4 Private
|
2021-05-14 11:55:45 +00:00
|
|
|
%float_0 = OpConstant %float 0
|
2021-01-14 19:18:10 +00:00
|
|
|
%float_1 = OpConstant %float 1
|
|
|
|
%void = OpTypeVoid
|
2021-05-14 11:55:45 +00:00
|
|
|
%20 = OpTypeFunction %void
|
|
|
|
%v2float = OpTypeVector %float 2
|
|
|
|
%23 = OpConstantComposite %v2float %float_0 %float_0
|
|
|
|
%_ptr_Function_v2float = OpTypePointer Function %v2float
|
|
|
|
%27 = OpTypeFunction %v4float %_ptr_Function_v2float
|
2021-01-14 19:18:10 +00:00
|
|
|
%int_0 = OpConstant %int 0
|
|
|
|
%_ptr_Private_float = OpTypePointer Private %float
|
|
|
|
%int_1 = OpConstant %int 1
|
|
|
|
%int_2 = OpConstant %int 2
|
|
|
|
%int_3 = OpConstant %int 3
|
2021-05-14 11:55:45 +00:00
|
|
|
%_entrypoint_v = OpFunction %void None %20
|
|
|
|
%21 = OpLabel
|
|
|
|
%24 = OpVariable %_ptr_Function_v2float Function
|
|
|
|
OpStore %24 %23
|
|
|
|
%26 = OpFunctionCall %v4float %main %24
|
|
|
|
OpStore %sk_FragColor %26
|
2021-01-14 19:18:10 +00:00
|
|
|
OpReturn
|
|
|
|
OpFunctionEnd
|
2021-05-14 11:55:45 +00:00
|
|
|
%main = OpFunction %v4float None %27
|
|
|
|
%28 = OpFunctionParameter %_ptr_Function_v2float
|
|
|
|
%29 = OpLabel
|
|
|
|
%17 = OpCompositeConstruct %_arr_float_int_4 %float_0 %float_1 %float_0 %float_1
|
|
|
|
OpStore %test %17
|
|
|
|
%31 = OpAccessChain %_ptr_Private_float %test %int_0
|
|
|
|
%33 = OpLoad %float %31
|
|
|
|
%35 = OpAccessChain %_ptr_Private_float %test %int_1
|
|
|
|
%36 = OpLoad %float %35
|
|
|
|
%38 = OpAccessChain %_ptr_Private_float %test %int_2
|
|
|
|
%39 = OpLoad %float %38
|
|
|
|
%41 = OpAccessChain %_ptr_Private_float %test %int_3
|
|
|
|
%42 = OpLoad %float %41
|
|
|
|
%43 = OpCompositeConstruct %v4float %33 %36 %39 %42
|
|
|
|
OpReturnValue %43
|
|
|
|
OpFunctionEnd
|