AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
d97187cfed
skia2/third_party/dawn/BUILD.gn

691 lines
30 KiB
Plaintext
Raw Normal View History

Add first Dawn dependencies. Add Dawn repo to DEPS. Add skia_use_dawn flag to BUILD.gn (default false). Add Metal.framework for Mac when building for Dawn/Metal. Add d3d12, dxgi, d3dcompiler libs when building for Dawn/D3D12. Disable SPIRV validation when building for Dawn. Add BUILD.gn for dawn and dawn/third_party libraries. (Note that I had to split the declare_args() section of BUILD.gn into two, so that I could refer to skia_use_dawn in skia_enable_spirv_validation. If there's a better way to do this, I'm open to suggestions.) Change-Id: I9bdaf990694f6b8bcce6b77c1a8b1620a7396e34 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225137 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-07-10 19:51:30 +00:00
# Copyright 2018 The Dawn Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
Update Dawn backend to ToT. This is about 3 months of changes. Remove optional param to SetIndexBuffer(). Update SetVertexBuffers -> SetVertexBuffer. PipelineStageDescriptor -> ProgrammableStageDescriptor. Update past generator changes, ring buffer changes, etc. Add ErrorScopeTracker.cpp/.h to the build. Add Vulkan MemoryResourceAllocator files. Fix vertexShader ShaderStageDescriptor. Fix spirv-cross include path. TextureUsageBit -> TextureUsage, etc. DawnErrorCallback fixes. Removal of texture.CreateDefaultView. Fix GL supported_extesions mumbo jumbo. Update past ChromeOS change. Add PassResourceUsageTracker.cpp/.h to build. Add GLFormat.cpp/.h to build. Add Extensions and Toggles to the build. Add EncodingContext, AttachmentState to build. Add RenderEncoderBase to Dawn build. gn format dawn BUILD.gn, spirv-cross BUILD.gn. Change-Id: I26538d63c93668647048814aad6ad456ae323679 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248261 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-10-15 17:35:37 +00:00
import("../externals/dawn/generator/dawn_generator.gni")
import("../externals/dawn/scripts/dawn_features.gni")
Add first Dawn dependencies. Add Dawn repo to DEPS. Add skia_use_dawn flag to BUILD.gn (default false). Add Metal.framework for Mac when building for Dawn/Metal. Add d3d12, dxgi, d3dcompiler libs when building for Dawn/D3D12. Disable SPIRV validation when building for Dawn. Add BUILD.gn for dawn and dawn/third_party libraries. (Note that I had to split the declare_args() section of BUILD.gn into two, so that I could refer to skia_use_dawn in skia_enable_spirv_validation. If there's a better way to do this, I'm open to suggestions.) Change-Id: I9bdaf990694f6b8bcce6b77c1a8b1620a7396e34 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225137 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-07-10 19:51:30 +00:00
Update Dawn backend to ToT. This is about 3 months of changes. Remove optional param to SetIndexBuffer(). Update SetVertexBuffers -> SetVertexBuffer. PipelineStageDescriptor -> ProgrammableStageDescriptor. Update past generator changes, ring buffer changes, etc. Add ErrorScopeTracker.cpp/.h to the build. Add Vulkan MemoryResourceAllocator files. Fix vertexShader ShaderStageDescriptor. Fix spirv-cross include path. TextureUsageBit -> TextureUsage, etc. DawnErrorCallback fixes. Removal of texture.CreateDefaultView. Fix GL supported_extesions mumbo jumbo. Update past ChromeOS change. Add PassResourceUsageTracker.cpp/.h to build. Add GLFormat.cpp/.h to build. Add Extensions and Toggles to the build. Add EncodingContext, AttachmentState to build. Add RenderEncoderBase to Dawn build. gn format dawn BUILD.gn, spirv-cross BUILD.gn. Change-Id: I26538d63c93668647048814aad6ad456ae323679 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248261 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-10-15 17:35:37 +00:00
###############################################################################
# dawn_platform
###############################################################################
source_set("dawn_platform") {
configs += [ ":dawn_internal" ]
sources =
rebase_path([
"${dawn_root}/src/include/dawn_platform/DawnPlatform.h",
"src/dawn_platform/tracing/EventTracer.cpp",
"src/dawn_platform/tracing/EventTracer.h",
"src/dawn_platform/tracing/TraceEvent.h",
],
".",
"$dawn_root")
}
Add first Dawn dependencies. Add Dawn repo to DEPS. Add skia_use_dawn flag to BUILD.gn (default false). Add Metal.framework for Mac when building for Dawn/Metal. Add d3d12, dxgi, d3dcompiler libs when building for Dawn/D3D12. Disable SPIRV validation when building for Dawn. Add BUILD.gn for dawn and dawn/third_party libraries. (Note that I had to split the declare_args() section of BUILD.gn into two, so that I could refer to skia_use_dawn in skia_enable_spirv_validation. If there's a better way to do this, I'm open to suggestions.) Change-Id: I9bdaf990694f6b8bcce6b77c1a8b1620a7396e34 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225137 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-07-10 19:51:30 +00:00
###############################################################################
Update Dawn to ToT. Separate out generation of cpp headers. Change-Id: I4b3e14dcf7f31a4587fc2de48d79455e98bbf53c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248935 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-10-17 15:31:34 +00:00
# libdawn_native
Add first Dawn dependencies. Add Dawn repo to DEPS. Add skia_use_dawn flag to BUILD.gn (default false). Add Metal.framework for Mac when building for Dawn/Metal. Add d3d12, dxgi, d3dcompiler libs when building for Dawn/D3D12. Disable SPIRV validation when building for Dawn. Add BUILD.gn for dawn and dawn/third_party libraries. (Note that I had to split the declare_args() section of BUILD.gn into two, so that I could refer to skia_use_dawn in skia_enable_spirv_validation. If there's a better way to do this, I'm open to suggestions.) Change-Id: I9bdaf990694f6b8bcce6b77c1a8b1620a7396e34 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225137 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-07-10 19:51:30 +00:00
###############################################################################
config("libdawn_native_internal") {
configs = [ ":dawn_internal" ]
Update Dawn to ToT. Separate out generation of cpp headers. Change-Id: I4b3e14dcf7f31a4587fc2de48d79455e98bbf53c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248935 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-10-17 15:31:34 +00:00
# Suppress warnings that Metal isn't in the deployment target of Chrome:
# initialization of the Metal backend is behind a IsMetalSupported check so
# Dawn won't call Metal functions on macOS 10.10.
# TODO(cwallez@chromium.org): Consider using API_AVAILABLE annotations on all
# metal code in dawn once crbug.com/1004024 is sorted out.
Add first Dawn dependencies. Add Dawn repo to DEPS. Add skia_use_dawn flag to BUILD.gn (default false). Add Metal.framework for Mac when building for Dawn/Metal. Add d3d12, dxgi, d3dcompiler libs when building for Dawn/D3D12. Disable SPIRV validation when building for Dawn. Add BUILD.gn for dawn and dawn/third_party libraries. (Note that I had to split the declare_args() section of BUILD.gn into two, so that I could refer to skia_use_dawn in skia_enable_spirv_validation. If there's a better way to do this, I'm open to suggestions.) Change-Id: I9bdaf990694f6b8bcce6b77c1a8b1620a7396e34 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225137 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-07-10 19:51:30 +00:00
if (is_mac) {
cflags_objcc = [ "-Wno-unguarded-availability" ]
}
Add missing files to Dawn build This adds the RenderPassBuilderD3D12 files and ignores a narrowing error in them. Change-Id: Ie9ebc1608ad6bbbc48e0f1cd8d54a9213d9836a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/278777 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
2020-03-24 13:57:25 +00:00
cflags_cc = [
"-Wno-deprecated-declarations",
"-Wno-narrowing",
]
Add first Dawn dependencies. Add Dawn repo to DEPS. Add skia_use_dawn flag to BUILD.gn (default false). Add Metal.framework for Mac when building for Dawn/Metal. Add d3d12, dxgi, d3dcompiler libs when building for Dawn/D3D12. Disable SPIRV validation when building for Dawn. Add BUILD.gn for dawn and dawn/third_party libraries. (Note that I had to split the declare_args() section of BUILD.gn into two, so that I could refer to skia_use_dawn in skia_enable_spirv_validation. If there's a better way to do this, I'm open to suggestions.) Change-Id: I9bdaf990694f6b8bcce6b77c1a8b1620a7396e34 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225137 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-07-10 19:51:30 +00:00
}
Update to Dawn ToT. Switch to Dawn's version of dawn_generator.gni. This depends on having a file called build_overrides/dawn.gni. However, this will also enable us to use the upstream Dawn BUILD.gn files more easily in the future. This required adding it to compile.isolate, so the bots can pick it up. Keeping up with Dawn: Rename TextureFormat enums. Rename dawn::BufferUsageBit::TransferDst -> CopyDst. Removal of GLAD dependency. SPIRV-Tools update. Change-Id: Idcd5d1035ed106485dd2503b829e3c3b57a5688b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/228568 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-07-22 13:12:29 +00:00
dawn_json_generator("libdawn_native_utils_gen") {
Add first Dawn dependencies. Add Dawn repo to DEPS. Add skia_use_dawn flag to BUILD.gn (default false). Add Metal.framework for Mac when building for Dawn/Metal. Add d3d12, dxgi, d3dcompiler libs when building for Dawn/D3D12. Disable SPIRV validation when building for Dawn. Add BUILD.gn for dawn and dawn/third_party libraries. (Note that I had to split the declare_args() section of BUILD.gn into two, so that I could refer to skia_use_dawn in skia_enable_spirv_validation. If there's a better way to do this, I'm open to suggestions.) Change-Id: I9bdaf990694f6b8bcce6b77c1a8b1620a7396e34 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225137 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-07-10 19:51:30 +00:00
target = "dawn_native_utils"
outputs = [
Update Dawn backend to ToT. This is about 3 months of changes. Remove optional param to SetIndexBuffer(). Update SetVertexBuffers -> SetVertexBuffer. PipelineStageDescriptor -> ProgrammableStageDescriptor. Update past generator changes, ring buffer changes, etc. Add ErrorScopeTracker.cpp/.h to the build. Add Vulkan MemoryResourceAllocator files. Fix vertexShader ShaderStageDescriptor. Fix spirv-cross include path. TextureUsageBit -> TextureUsage, etc. DawnErrorCallback fixes. Removal of texture.CreateDefaultView. Fix GL supported_extesions mumbo jumbo. Update past ChromeOS change. Add PassResourceUsageTracker.cpp/.h to build. Add GLFormat.cpp/.h to build. Add Extensions and Toggles to the build. Add EncodingContext, AttachmentState to build. Add RenderEncoderBase to Dawn build. gn format dawn BUILD.gn, spirv-cross BUILD.gn. Change-Id: I26538d63c93668647048814aad6ad456ae323679 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248261 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-10-15 17:35:37 +00:00
"src/dawn_native/ProcTable.cpp",
Roll to ToT Dawn. Change-Id: Iff890f62f8ecae29ce7024f2bba206a2770c2600 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/251365 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-10-29 20:45:40 +00:00
"src/dawn_native/wgpu_structs_autogen.h",
"src/dawn_native/wgpu_structs_autogen.cpp",
Update Dawn backend to ToT. This is about 3 months of changes. Remove optional param to SetIndexBuffer(). Update SetVertexBuffers -> SetVertexBuffer. PipelineStageDescriptor -> ProgrammableStageDescriptor. Update past generator changes, ring buffer changes, etc. Add ErrorScopeTracker.cpp/.h to the build. Add Vulkan MemoryResourceAllocator files. Fix vertexShader ShaderStageDescriptor. Fix spirv-cross include path. TextureUsageBit -> TextureUsage, etc. DawnErrorCallback fixes. Removal of texture.CreateDefaultView. Fix GL supported_extesions mumbo jumbo. Update past ChromeOS change. Add PassResourceUsageTracker.cpp/.h to build. Add GLFormat.cpp/.h to build. Add Extensions and Toggles to the build. Add EncodingContext, AttachmentState to build. Add RenderEncoderBase to Dawn build. gn format dawn BUILD.gn, spirv-cross BUILD.gn. Change-Id: I26538d63c93668647048814aad6ad456ae323679 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248261 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-10-15 17:35:37 +00:00
"src/dawn_native/ValidationUtils_autogen.h",
"src/dawn_native/ValidationUtils_autogen.cpp",
Add first Dawn dependencies. Add Dawn repo to DEPS. Add skia_use_dawn flag to BUILD.gn (default false). Add Metal.framework for Mac when building for Dawn/Metal. Add d3d12, dxgi, d3dcompiler libs when building for Dawn/D3D12. Disable SPIRV validation when building for Dawn. Add BUILD.gn for dawn and dawn/third_party libraries. (Note that I had to split the declare_args() section of BUILD.gn into two, so that I could refer to skia_use_dawn in skia_enable_spirv_validation. If there's a better way to do this, I'm open to suggestions.) Change-Id: I9bdaf990694f6b8bcce6b77c1a8b1620a7396e34 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225137 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-07-10 19:51:30 +00:00
]
}
Update to Dawn ToT. Switch to Dawn's version of dawn_generator.gni. This depends on having a file called build_overrides/dawn.gni. However, this will also enable us to use the upstream Dawn BUILD.gn files more easily in the future. This required adding it to compile.isolate, so the bots can pick it up. Keeping up with Dawn: Rename TextureFormat enums. Rename dawn::BufferUsageBit::TransferDst -> CopyDst. Removal of GLAD dependency. SPIRV-Tools update. Change-Id: Idcd5d1035ed106485dd2503b829e3c3b57a5688b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/228568 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-07-22 13:12:29 +00:00
if (dawn_enable_opengl) {
dawn_generator("libdawn_native_opengl_loader_gen") {
script = "${dawn_root}/generator/opengl_loader_generator.py"
args = [
"--gl-xml",
Dawn: use Skia's copy of vulkan headers. Remove use of Dawn's third_party vulkan headers and the BUILD.gn file it rode in on. Change-Id: Ibfb6f063cae291445e19a15d42e96279be072376 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/237448 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-08-27 16:41:55 +00:00
rebase_path("../externals/opengl-registry/xml/gl.xml", root_build_dir),
Update Dawn backend to ToT. This is about 3 months of changes. Remove optional param to SetIndexBuffer(). Update SetVertexBuffers -> SetVertexBuffer. PipelineStageDescriptor -> ProgrammableStageDescriptor. Update past generator changes, ring buffer changes, etc. Add ErrorScopeTracker.cpp/.h to the build. Add Vulkan MemoryResourceAllocator files. Fix vertexShader ShaderStageDescriptor. Fix spirv-cross include path. TextureUsageBit -> TextureUsage, etc. DawnErrorCallback fixes. Removal of texture.CreateDefaultView. Fix GL supported_extesions mumbo jumbo. Update past ChromeOS change. Add PassResourceUsageTracker.cpp/.h to build. Add GLFormat.cpp/.h to build. Add Extensions and Toggles to the build. Add EncodingContext, AttachmentState to build. Add RenderEncoderBase to Dawn build. gn format dawn BUILD.gn, spirv-cross BUILD.gn. Change-Id: I26538d63c93668647048814aad6ad456ae323679 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248261 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-10-15 17:35:37 +00:00
"--supported-extensions",
rebase_path("$dawn_root/src/dawn_native/opengl/supported_extensions.json",
root_build_dir),
Update to Dawn ToT. Switch to Dawn's version of dawn_generator.gni. This depends on having a file called build_overrides/dawn.gni. However, this will also enable us to use the upstream Dawn BUILD.gn files more easily in the future. This required adding it to compile.isolate, so the bots can pick it up. Keeping up with Dawn: Rename TextureFormat enums. Rename dawn::BufferUsageBit::TransferDst -> CopyDst. Removal of GLAD dependency. SPIRV-Tools update. Change-Id: Idcd5d1035ed106485dd2503b829e3c3b57a5688b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/228568 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-07-22 13:12:29 +00:00
]
outputs = [
Update Dawn backend to ToT. This is about 3 months of changes. Remove optional param to SetIndexBuffer(). Update SetVertexBuffers -> SetVertexBuffer. PipelineStageDescriptor -> ProgrammableStageDescriptor. Update past generator changes, ring buffer changes, etc. Add ErrorScopeTracker.cpp/.h to the build. Add Vulkan MemoryResourceAllocator files. Fix vertexShader ShaderStageDescriptor. Fix spirv-cross include path. TextureUsageBit -> TextureUsage, etc. DawnErrorCallback fixes. Removal of texture.CreateDefaultView. Fix GL supported_extesions mumbo jumbo. Update past ChromeOS change. Add PassResourceUsageTracker.cpp/.h to build. Add GLFormat.cpp/.h to build. Add Extensions and Toggles to the build. Add EncodingContext, AttachmentState to build. Add RenderEncoderBase to Dawn build. gn format dawn BUILD.gn, spirv-cross BUILD.gn. Change-Id: I26538d63c93668647048814aad6ad456ae323679 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248261 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-10-15 17:35:37 +00:00
"src/dawn_native/opengl/OpenGLFunctionsBase_autogen.cpp",
"src/dawn_native/opengl/OpenGLFunctionsBase_autogen.h",
"src/dawn_native/opengl/opengl_platform_autogen.h",
Update to Dawn ToT. Switch to Dawn's version of dawn_generator.gni. This depends on having a file called build_overrides/dawn.gni. However, this will also enable us to use the upstream Dawn BUILD.gn files more easily in the future. This required adding it to compile.isolate, so the bots can pick it up. Keeping up with Dawn: Rename TextureFormat enums. Rename dawn::BufferUsageBit::TransferDst -> CopyDst. Removal of GLAD dependency. SPIRV-Tools update. Change-Id: Idcd5d1035ed106485dd2503b829e3c3b57a5688b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/228568 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-07-22 13:12:29 +00:00
]
}
}
Add first Dawn dependencies. Add Dawn repo to DEPS. Add skia_use_dawn flag to BUILD.gn (default false). Add Metal.framework for Mac when building for Dawn/Metal. Add d3d12, dxgi, d3dcompiler libs when building for Dawn/D3D12. Disable SPIRV validation when building for Dawn. Add BUILD.gn for dawn and dawn/third_party libraries. (Note that I had to split the declare_args() section of BUILD.gn into two, so that I could refer to skia_use_dawn in skia_enable_spirv_validation. If there's a better way to do this, I'm open to suggestions.) Change-Id: I9bdaf990694f6b8bcce6b77c1a8b1620a7396e34 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225137 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-07-10 19:51:30 +00:00
# Public libdawn_native headers so they can be publically visible for
# dependencies of libdawn_native
source_set("libdawn_native_headers") {
reformat GN files Change-Id: I2d19c4f0ff1439dcd923a3064eb3ba78432a5113 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281043 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
2020-04-01 18:47:34 +00:00
public_deps = [ ":dawncpp_headers" ]
Add first Dawn dependencies. Add Dawn repo to DEPS. Add skia_use_dawn flag to BUILD.gn (default false). Add Metal.framework for Mac when building for Dawn/Metal. Add d3d12, dxgi, d3dcompiler libs when building for Dawn/D3D12. Disable SPIRV validation when building for Dawn. Add BUILD.gn for dawn and dawn/third_party libraries. (Note that I had to split the declare_args() section of BUILD.gn into two, so that I could refer to skia_use_dawn in skia_enable_spirv_validation. If there's a better way to do this, I'm open to suggestions.) Change-Id: I9bdaf990694f6b8bcce6b77c1a8b1620a7396e34 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225137 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-07-10 19:51:30 +00:00
sources = rebase_path(
[
"src/include/dawn_native/DawnNative.h",
"src/include/dawn_native/dawn_native_export.h",
# Include all backend's public headers so that dependencies can include
# them even when the backends are disabled.
"src/include/dawn_native/D3D12Backend.h",
"src/include/dawn_native/MetalBackend.h",
"src/include/dawn_native/NullBackend.h",
"src/include/dawn_native/OpenGLBackend.h",
"src/include/dawn_native/VulkanBackend.h",
],
".",
"$dawn_root")
}
Dawn: build libdawn-native as a static lib, not shared. Also clean up the main BUILD.gn file to use deps instead of public_deps where possible. Change-Id: I2cc7719e42ae70be9181bdb02a1995cd2c780672 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249177 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-10-17 14:32:40 +00:00
static_library("libdawn_native") {
Add first Dawn dependencies. Add Dawn repo to DEPS. Add skia_use_dawn flag to BUILD.gn (default false). Add Metal.framework for Mac when building for Dawn/Metal. Add d3d12, dxgi, d3dcompiler libs when building for Dawn/D3D12. Disable SPIRV validation when building for Dawn. Add BUILD.gn for dawn and dawn/third_party libraries. (Note that I had to split the declare_args() section of BUILD.gn into two, so that I could refer to skia_use_dawn in skia_enable_spirv_validation. If there's a better way to do this, I'm open to suggestions.) Change-Id: I9bdaf990694f6b8bcce6b77c1a8b1620a7396e34 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225137 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-07-10 19:51:30 +00:00
deps = [
":dawn_common",
Update Dawn to ToT. Separate out generation of cpp headers. Change-Id: I4b3e14dcf7f31a4587fc2de48d79455e98bbf53c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248935 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-10-17 15:31:34 +00:00
":libdawn_native_headers",
Add first Dawn dependencies. Add Dawn repo to DEPS. Add skia_use_dawn flag to BUILD.gn (default false). Add Metal.framework for Mac when building for Dawn/Metal. Add d3d12, dxgi, d3dcompiler libs when building for Dawn/D3D12. Disable SPIRV validation when building for Dawn. Add BUILD.gn for dawn and dawn/third_party libraries. (Note that I had to split the declare_args() section of BUILD.gn into two, so that I could refer to skia_use_dawn in skia_enable_spirv_validation. If there's a better way to do this, I'm open to suggestions.) Change-Id: I9bdaf990694f6b8bcce6b77c1a8b1620a7396e34 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225137 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-07-10 19:51:30 +00:00
":libdawn_native_utils_gen",
Roll Dawn and add dependencies Add Dawn's dependencies shaderc and glslang, and roll SPIRV. Update the BUILD.gn files to match upstream changes. Bug: skia:9939, chromium:1064563 Change-Id: Ie9720806efe823312da10f7911688f12cad0713e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/278770 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Weston Tracey <westont@google.com>
2020-03-30 17:23:00 +00:00
"${dawn_spirv_cross_dir}:spirv_cross",
"${dawn_spirv_tools_dir}:spvtools_val",
Add first Dawn dependencies. Add Dawn repo to DEPS. Add skia_use_dawn flag to BUILD.gn (default false). Add Metal.framework for Mac when building for Dawn/Metal. Add d3d12, dxgi, d3dcompiler libs when building for Dawn/D3D12. Disable SPIRV validation when building for Dawn. Add BUILD.gn for dawn and dawn/third_party libraries. (Note that I had to split the declare_args() section of BUILD.gn into two, so that I could refer to skia_use_dawn in skia_enable_spirv_validation. If there's a better way to do this, I'm open to suggestions.) Change-Id: I9bdaf990694f6b8bcce6b77c1a8b1620a7396e34 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225137 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-07-10 19:51:30 +00:00
]
Update Dawn to ToT. Separate out generation of cpp headers. Change-Id: I4b3e14dcf7f31a4587fc2de48d79455e98bbf53c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248935 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-10-17 15:31:34 +00:00
configs += [ ":libdawn_native_internal" ]
libs = []
Add first Dawn dependencies. Add Dawn repo to DEPS. Add skia_use_dawn flag to BUILD.gn (default false). Add Metal.framework for Mac when building for Dawn/Metal. Add d3d12, dxgi, d3dcompiler libs when building for Dawn/D3D12. Disable SPIRV validation when building for Dawn. Add BUILD.gn for dawn and dawn/third_party libraries. (Note that I had to split the declare_args() section of BUILD.gn into two, so that I could refer to skia_use_dawn in skia_enable_spirv_validation. If there's a better way to do this, I'm open to suggestions.) Change-Id: I9bdaf990694f6b8bcce6b77c1a8b1620a7396e34 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225137 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-07-10 19:51:30 +00:00
Update Dawn to ToT. Separate out generation of cpp headers. Change-Id: I4b3e14dcf7f31a4587fc2de48d79455e98bbf53c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248935 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-10-17 15:31:34 +00:00
# Dependencies that are needed to compile libdawn_native entry points in
# FooBackend.cpp need to be public deps so they are propagated to the
# libdawn_native target
Add first Dawn dependencies. Add Dawn repo to DEPS. Add skia_use_dawn flag to BUILD.gn (default false). Add Metal.framework for Mac when building for Dawn/Metal. Add d3d12, dxgi, d3dcompiler libs when building for Dawn/D3D12. Disable SPIRV validation when building for Dawn. Add BUILD.gn for dawn and dawn/third_party libraries. (Note that I had to split the declare_args() section of BUILD.gn into two, so that I could refer to skia_use_dawn in skia_enable_spirv_validation. If there's a better way to do this, I'm open to suggestions.) Change-Id: I9bdaf990694f6b8bcce6b77c1a8b1620a7396e34 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225137 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-07-10 19:51:30 +00:00
public_deps = [
Update Dawn backend to ToT. This is about 3 months of changes. Remove optional param to SetIndexBuffer(). Update SetVertexBuffers -> SetVertexBuffer. PipelineStageDescriptor -> ProgrammableStageDescriptor. Update past generator changes, ring buffer changes, etc. Add ErrorScopeTracker.cpp/.h to the build. Add Vulkan MemoryResourceAllocator files. Fix vertexShader ShaderStageDescriptor. Fix spirv-cross include path. TextureUsageBit -> TextureUsage, etc. DawnErrorCallback fixes. Removal of texture.CreateDefaultView. Fix GL supported_extesions mumbo jumbo. Update past ChromeOS change. Add PassResourceUsageTracker.cpp/.h to build. Add GLFormat.cpp/.h to build. Add Extensions and Toggles to the build. Add EncodingContext, AttachmentState to build. Add RenderEncoderBase to Dawn build. gn format dawn BUILD.gn, spirv-cross BUILD.gn. Change-Id: I26538d63c93668647048814aad6ad456ae323679 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248261 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-10-15 17:35:37 +00:00
":dawn_platform",
Roll Dawn and add dependencies Add Dawn's dependencies shaderc and glslang, and roll SPIRV. Update the BUILD.gn files to match upstream changes. Bug: skia:9939, chromium:1064563 Change-Id: Ie9720806efe823312da10f7911688f12cad0713e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/278770 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Weston Tracey <westont@google.com>
2020-03-30 17:23:00 +00:00
"${dawn_shaderc_dir}:libshaderc_spvc_sources",
Add first Dawn dependencies. Add Dawn repo to DEPS. Add skia_use_dawn flag to BUILD.gn (default false). Add Metal.framework for Mac when building for Dawn/Metal. Add d3d12, dxgi, d3dcompiler libs when building for Dawn/D3D12. Disable SPIRV validation when building for Dawn. Add BUILD.gn for dawn and dawn/third_party libraries. (Note that I had to split the declare_args() section of BUILD.gn into two, so that I could refer to skia_use_dawn in skia_enable_spirv_validation. If there's a better way to do this, I'm open to suggestions.) Change-Id: I9bdaf990694f6b8bcce6b77c1a8b1620a7396e34 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225137 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-07-10 19:51:30 +00:00
]
sources = rebase_path(get_target_outputs(":libdawn_native_utils_gen"),
".",
"$dawn_root")
Roll Dawn and add dependencies Add Dawn's dependencies shaderc and glslang, and roll SPIRV. Update the BUILD.gn files to match upstream changes. Bug: skia:9939, chromium:1064563 Change-Id: Ie9720806efe823312da10f7911688f12cad0713e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/278770 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Weston Tracey <westont@google.com>
2020-03-30 17:23:00 +00:00
sources +=
rebase_path([
"src/dawn_native/Adapter.cpp",
"src/dawn_native/Adapter.h",
"src/dawn_native/AttachmentState.cpp",
"src/dawn_native/AttachmentState.h",
"src/dawn_native/BackendConnection.cpp",
"src/dawn_native/BackendConnection.h",
"src/dawn_native/BindGroup.cpp",
"src/dawn_native/BindGroup.h",
"src/dawn_native/BindGroupAndStorageBarrierTrackers.h",
"src/dawn_native/BindGroupLayout.cpp",
"src/dawn_native/BindGroupLayout.h",
"src/dawn_native/BuddyAllocator.cpp",
"src/dawn_native/BuddyAllocator.h",
"src/dawn_native/BuddyMemoryAllocator.cpp",
"src/dawn_native/BuddyMemoryAllocator.h",
"src/dawn_native/Buffer.cpp",
"src/dawn_native/Buffer.h",
"src/dawn_native/CachedObject.cpp",
"src/dawn_native/CommandAllocator.cpp",
"src/dawn_native/CommandAllocator.h",
"src/dawn_native/CommandBuffer.cpp",
"src/dawn_native/CommandBuffer.h",
"src/dawn_native/CommandBufferStateTracker.cpp",
"src/dawn_native/CommandBufferStateTracker.h",
"src/dawn_native/CommandEncoder.cpp",
"src/dawn_native/CommandEncoder.h",
"src/dawn_native/CommandValidation.cpp",
"src/dawn_native/CommandValidation.h",
"src/dawn_native/Commands.cpp",
"src/dawn_native/Commands.h",
"src/dawn_native/ComputePassEncoder.cpp",
"src/dawn_native/ComputePassEncoder.h",
"src/dawn_native/ComputePipeline.cpp",
"src/dawn_native/ComputePipeline.h",
"src/dawn_native/DawnNative.cpp",
"src/dawn_native/Device.cpp",
"src/dawn_native/Device.h",
"src/dawn_native/DynamicUploader.cpp",
"src/dawn_native/DynamicUploader.h",
"src/dawn_native/Device.h",
"src/dawn_native/EncodingContext.cpp",
"src/dawn_native/EncodingContext.h",
"src/dawn_native/Error.cpp",
"src/dawn_native/Error.h",
"src/dawn_native/ErrorData.cpp",
"src/dawn_native/ErrorData.h",
"src/dawn_native/ErrorInjector.cpp",
"src/dawn_native/ErrorInjector.h",
"src/dawn_native/ErrorScope.cpp",
"src/dawn_native/ErrorScope.h",
"src/dawn_native/ErrorScopeTracker.cpp",
"src/dawn_native/ErrorScopeTracker.h",
"src/dawn_native/Extensions.cpp",
"src/dawn_native/Extensions.h",
"src/dawn_native/Fence.cpp",
"src/dawn_native/Fence.h",
"src/dawn_native/FenceSignalTracker.cpp",
"src/dawn_native/FenceSignalTracker.h",
"src/dawn_native/Format.cpp",
"src/dawn_native/Format.h",
"src/dawn_native/Forward.h",
"src/dawn_native/Instance.cpp",
"src/dawn_native/Instance.h",
"src/dawn_native/ObjectBase.h",
"src/dawn_native/ObjectBase.cpp",
"src/dawn_native/PassResourceUsage.h",
"src/dawn_native/PassResourceUsageTracker.cpp",
"src/dawn_native/PassResourceUsageTracker.h",
"src/dawn_native/PerStage.cpp",
"src/dawn_native/PerStage.h",
"src/dawn_native/Pipeline.cpp",
"src/dawn_native/Pipeline.h",
"src/dawn_native/PipelineLayout.cpp",
"src/dawn_native/PipelineLayout.h",
"src/dawn_native/ProgrammablePassEncoder.cpp",
"src/dawn_native/ProgrammablePassEncoder.h",
"src/dawn_native/Queue.cpp",
"src/dawn_native/Queue.h",
"src/dawn_native/RefCounted.cpp",
"src/dawn_native/RefCounted.h",
"src/dawn_native/RenderBundle.cpp",
"src/dawn_native/RenderBundle.h",
"src/dawn_native/RenderBundleEncoder.cpp",
"src/dawn_native/RenderBundleEncoder.h",
"src/dawn_native/RenderEncoderBase.cpp",
"src/dawn_native/RenderEncoderBase.h",
"src/dawn_native/RenderPassEncoder.cpp",
"src/dawn_native/RenderPassEncoder.h",
"src/dawn_native/RenderPipeline.cpp",
"src/dawn_native/RenderPipeline.h",
"src/dawn_native/ResourceHeap.h",
"src/dawn_native/ResourceHeapAllocator.h",
"src/dawn_native/ResourceMemoryAllocation.cpp",
"src/dawn_native/ResourceMemoryAllocation.h",
"src/dawn_native/RingBufferAllocator.cpp",
"src/dawn_native/RingBufferAllocator.h",
"src/dawn_native/Sampler.cpp",
"src/dawn_native/Sampler.h",
"src/dawn_native/ShaderModule.cpp",
"src/dawn_native/ShaderModule.h",
"src/dawn_native/StagingBuffer.cpp",
"src/dawn_native/StagingBuffer.h",
"src/dawn_native/Surface.cpp",
"src/dawn_native/Surface.h",
"src/dawn_native/SwapChain.cpp",
"src/dawn_native/SwapChain.h",
"src/dawn_native/Texture.cpp",
"src/dawn_native/Texture.h",
"src/dawn_native/Toggles.cpp",
"src/dawn_native/Toggles.h",
"src/dawn_native/ToBackend.h",
"src/dawn_native/dawn_platform.h",
],
".",
"$dawn_root")
Add first Dawn dependencies. Add Dawn repo to DEPS. Add skia_use_dawn flag to BUILD.gn (default false). Add Metal.framework for Mac when building for Dawn/Metal. Add d3d12, dxgi, d3dcompiler libs when building for Dawn/D3D12. Disable SPIRV validation when building for Dawn. Add BUILD.gn for dawn and dawn/third_party libraries. (Note that I had to split the declare_args() section of BUILD.gn into two, so that I could refer to skia_use_dawn in skia_enable_spirv_validation. If there's a better way to do this, I'm open to suggestions.) Change-Id: I9bdaf990694f6b8bcce6b77c1a8b1620a7396e34 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225137 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-07-10 19:51:30 +00:00
if (dawn_enable_d3d12) {
libs += [ "dxguid.lib" ]
Roll Dawn and add dependencies Add Dawn's dependencies shaderc and glslang, and roll SPIRV. Update the BUILD.gn files to match upstream changes. Bug: skia:9939, chromium:1064563 Change-Id: Ie9720806efe823312da10f7911688f12cad0713e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/278770 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Weston Tracey <westont@google.com>
2020-03-30 17:23:00 +00:00
sources += rebase_path(
[
"src/dawn_native/d3d12/AdapterD3D12.cpp",
"src/dawn_native/d3d12/AdapterD3D12.h",
"src/dawn_native/d3d12/BackendD3D12.cpp",
"src/dawn_native/d3d12/BackendD3D12.h",
"src/dawn_native/d3d12/BindGroupD3D12.cpp",
"src/dawn_native/d3d12/BindGroupD3D12.h",
"src/dawn_native/d3d12/BindGroupLayoutD3D12.cpp",
"src/dawn_native/d3d12/BindGroupLayoutD3D12.h",
"src/dawn_native/d3d12/BufferD3D12.cpp",
"src/dawn_native/d3d12/BufferD3D12.h",
"src/dawn_native/d3d12/CommandAllocatorManager.cpp",
"src/dawn_native/d3d12/CommandAllocatorManager.h",
"src/dawn_native/d3d12/CommandBufferD3D12.cpp",
"src/dawn_native/d3d12/CommandBufferD3D12.h",
"src/dawn_native/d3d12/CommandRecordingContext.cpp",
"src/dawn_native/d3d12/CommandRecordingContext.h",
"src/dawn_native/d3d12/ComputePipelineD3D12.cpp",
"src/dawn_native/d3d12/ComputePipelineD3D12.h",
"src/dawn_native/d3d12/D3D12Backend.cpp",
"src/dawn_native/d3d12/D3D12Error.cpp",
"src/dawn_native/d3d12/D3D12Error.h",
"src/dawn_native/d3d12/D3D12Info.cpp",
"src/dawn_native/d3d12/D3D12Info.h",
"src/dawn_native/d3d12/DescriptorHeapAllocationD3D12.cpp",
"src/dawn_native/d3d12/DescriptorHeapAllocationD3D12.h",
"src/dawn_native/d3d12/DescriptorHeapAllocator.cpp",
"src/dawn_native/d3d12/DescriptorHeapAllocator.h",
"src/dawn_native/d3d12/DeviceD3D12.cpp",
"src/dawn_native/d3d12/DeviceD3D12.h",
"src/dawn_native/d3d12/Forward.h",
"src/dawn_native/d3d12/HeapD3D12.cpp",
"src/dawn_native/d3d12/HeapD3D12.h",
"src/dawn_native/d3d12/HeapAllocatorD3D12.cpp",
"src/dawn_native/d3d12/HeapAllocatorD3D12.h",
"src/dawn_native/d3d12/NativeSwapChainImplD3D12.cpp",
"src/dawn_native/d3d12/NativeSwapChainImplD3D12.h",
"src/dawn_native/d3d12/PipelineLayoutD3D12.cpp",
"src/dawn_native/d3d12/PipelineLayoutD3D12.h",
"src/dawn_native/d3d12/PlatformFunctions.cpp",
"src/dawn_native/d3d12/PlatformFunctions.h",
"src/dawn_native/d3d12/QueueD3D12.cpp",
"src/dawn_native/d3d12/QueueD3D12.h",
"src/dawn_native/d3d12/RenderPassBuilderD3D12.cpp",
"src/dawn_native/d3d12/RenderPassBuilderD3D12.h",
"src/dawn_native/d3d12/RenderPipelineD3D12.cpp",
"src/dawn_native/d3d12/RenderPipelineD3D12.h",
"src/dawn_native/d3d12/ResidencyManagerD3D12.cpp",
"src/dawn_native/d3d12/ResidencyManagerD3D12.h",
"src/dawn_native/d3d12/ResourceAllocatorManagerD3D12.cpp",
"src/dawn_native/d3d12/ResourceAllocatorManagerD3D12.h",
"src/dawn_native/d3d12/ResourceHeapAllocationD3D12.cpp",
"src/dawn_native/d3d12/ResourceHeapAllocationD3D12.h",
"src/dawn_native/d3d12/SamplerD3D12.cpp",
"src/dawn_native/d3d12/SamplerD3D12.h",
"src/dawn_native/d3d12/ShaderModuleD3D12.cpp",
"src/dawn_native/d3d12/ShaderModuleD3D12.h",
"src/dawn_native/d3d12/ShaderVisibleDescriptorAllocatorD3D12.cpp",
"src/dawn_native/d3d12/ShaderVisibleDescriptorAllocatorD3D12.h",
"src/dawn_native/d3d12/StagingBufferD3D12.cpp",
"src/dawn_native/d3d12/StagingBufferD3D12.h",
"src/dawn_native/d3d12/SwapChainD3D12.cpp",
"src/dawn_native/d3d12/SwapChainD3D12.h",
"src/dawn_native/d3d12/TextureCopySplitter.cpp",
"src/dawn_native/d3d12/TextureCopySplitter.h",
"src/dawn_native/d3d12/TextureD3D12.cpp",
"src/dawn_native/d3d12/TextureD3D12.h",
"src/dawn_native/d3d12/UtilsD3D12.cpp",
"src/dawn_native/d3d12/UtilsD3D12.h",
"src/dawn_native/d3d12/d3d12_platform.h",
],
".",
"$dawn_root")
Add first Dawn dependencies. Add Dawn repo to DEPS. Add skia_use_dawn flag to BUILD.gn (default false). Add Metal.framework for Mac when building for Dawn/Metal. Add d3d12, dxgi, d3dcompiler libs when building for Dawn/D3D12. Disable SPIRV validation when building for Dawn. Add BUILD.gn for dawn and dawn/third_party libraries. (Note that I had to split the declare_args() section of BUILD.gn into two, so that I could refer to skia_use_dawn in skia_enable_spirv_validation. If there's a better way to do this, I'm open to suggestions.) Change-Id: I9bdaf990694f6b8bcce6b77c1a8b1620a7396e34 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225137 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-07-10 19:51:30 +00:00
}
if (dawn_enable_metal) {
libs += [
"Metal.framework",
"Cocoa.framework",
"IOKit.framework",
"IOSurface.framework",
Roll Dawn and add dependencies Add Dawn's dependencies shaderc and glslang, and roll SPIRV. Update the BUILD.gn files to match upstream changes. Bug: skia:9939, chromium:1064563 Change-Id: Ie9720806efe823312da10f7911688f12cad0713e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/278770 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Weston Tracey <westont@google.com>
2020-03-30 17:23:00 +00:00
"QuartzCore.framework",
Add first Dawn dependencies. Add Dawn repo to DEPS. Add skia_use_dawn flag to BUILD.gn (default false). Add Metal.framework for Mac when building for Dawn/Metal. Add d3d12, dxgi, d3dcompiler libs when building for Dawn/D3D12. Disable SPIRV validation when building for Dawn. Add BUILD.gn for dawn and dawn/third_party libraries. (Note that I had to split the declare_args() section of BUILD.gn into two, so that I could refer to skia_use_dawn in skia_enable_spirv_validation. If there's a better way to do this, I'm open to suggestions.) Change-Id: I9bdaf990694f6b8bcce6b77c1a8b1620a7396e34 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225137 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-07-10 19:51:30 +00:00
]
sources += rebase_path([
Roll Dawn and add dependencies Add Dawn's dependencies shaderc and glslang, and roll SPIRV. Update the BUILD.gn files to match upstream changes. Bug: skia:9939, chromium:1064563 Change-Id: Ie9720806efe823312da10f7911688f12cad0713e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/278770 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Weston Tracey <westont@google.com>
2020-03-30 17:23:00 +00:00
"src/dawn_native/Surface_metal.mm",
Add first Dawn dependencies. Add Dawn repo to DEPS. Add skia_use_dawn flag to BUILD.gn (default false). Add Metal.framework for Mac when building for Dawn/Metal. Add d3d12, dxgi, d3dcompiler libs when building for Dawn/D3D12. Disable SPIRV validation when building for Dawn. Add BUILD.gn for dawn and dawn/third_party libraries. (Note that I had to split the declare_args() section of BUILD.gn into two, so that I could refer to skia_use_dawn in skia_enable_spirv_validation. If there's a better way to do this, I'm open to suggestions.) Change-Id: I9bdaf990694f6b8bcce6b77c1a8b1620a7396e34 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225137 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-07-10 19:51:30 +00:00
"src/dawn_native/metal/BackendMTL.h",
"src/dawn_native/metal/BackendMTL.mm",
Roll Dawn and add dependencies Add Dawn's dependencies shaderc and glslang, and roll SPIRV. Update the BUILD.gn files to match upstream changes. Bug: skia:9939, chromium:1064563 Change-Id: Ie9720806efe823312da10f7911688f12cad0713e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/278770 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Weston Tracey <westont@google.com>
2020-03-30 17:23:00 +00:00
"src/dawn_native/metal/BindGroupLayoutMTL.h",
"src/dawn_native/metal/BindGroupLayoutMTL.mm",
"src/dawn_native/metal/BindGroupMTL.h",
"src/dawn_native/metal/BindGroupMTL.mm",
Add first Dawn dependencies. Add Dawn repo to DEPS. Add skia_use_dawn flag to BUILD.gn (default false). Add Metal.framework for Mac when building for Dawn/Metal. Add d3d12, dxgi, d3dcompiler libs when building for Dawn/D3D12. Disable SPIRV validation when building for Dawn. Add BUILD.gn for dawn and dawn/third_party libraries. (Note that I had to split the declare_args() section of BUILD.gn into two, so that I could refer to skia_use_dawn in skia_enable_spirv_validation. If there's a better way to do this, I'm open to suggestions.) Change-Id: I9bdaf990694f6b8bcce6b77c1a8b1620a7396e34 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225137 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-07-10 19:51:30 +00:00
"src/dawn_native/metal/BufferMTL.h",
"src/dawn_native/metal/BufferMTL.mm",
"src/dawn_native/metal/CommandBufferMTL.h",
"src/dawn_native/metal/CommandBufferMTL.mm",
Roll Dawn and add dependencies Add Dawn's dependencies shaderc and glslang, and roll SPIRV. Update the BUILD.gn files to match upstream changes. Bug: skia:9939, chromium:1064563 Change-Id: Ie9720806efe823312da10f7911688f12cad0713e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/278770 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Weston Tracey <westont@google.com>
2020-03-30 17:23:00 +00:00
"src/dawn_native/metal/CommandRecordingContext.h",
"src/dawn_native/metal/CommandRecordingContext.mm",
Add first Dawn dependencies. Add Dawn repo to DEPS. Add skia_use_dawn flag to BUILD.gn (default false). Add Metal.framework for Mac when building for Dawn/Metal. Add d3d12, dxgi, d3dcompiler libs when building for Dawn/D3D12. Disable SPIRV validation when building for Dawn. Add BUILD.gn for dawn and dawn/third_party libraries. (Note that I had to split the declare_args() section of BUILD.gn into two, so that I could refer to skia_use_dawn in skia_enable_spirv_validation. If there's a better way to do this, I'm open to suggestions.) Change-Id: I9bdaf990694f6b8bcce6b77c1a8b1620a7396e34 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225137 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-07-10 19:51:30 +00:00
"src/dawn_native/metal/ComputePipelineMTL.h",
"src/dawn_native/metal/ComputePipelineMTL.mm",
"src/dawn_native/metal/DeviceMTL.h",
"src/dawn_native/metal/DeviceMTL.mm",
"src/dawn_native/metal/Forward.h",
"src/dawn_native/metal/MetalBackend.mm",
"src/dawn_native/metal/PipelineLayoutMTL.h",
"src/dawn_native/metal/PipelineLayoutMTL.mm",
"src/dawn_native/metal/QueueMTL.h",
"src/dawn_native/metal/QueueMTL.mm",
"src/dawn_native/metal/RenderPipelineMTL.h",
"src/dawn_native/metal/RenderPipelineMTL.mm",
"src/dawn_native/metal/SamplerMTL.h",
"src/dawn_native/metal/SamplerMTL.mm",
"src/dawn_native/metal/ShaderModuleMTL.h",
"src/dawn_native/metal/ShaderModuleMTL.mm",
"src/dawn_native/metal/StagingBufferMTL.h",
"src/dawn_native/metal/StagingBufferMTL.mm",
"src/dawn_native/metal/SwapChainMTL.h",
"src/dawn_native/metal/SwapChainMTL.mm",
"src/dawn_native/metal/TextureMTL.h",
"src/dawn_native/metal/TextureMTL.mm",
"src/dawn_native/metal/UtilsMetal.h",
"src/dawn_native/metal/UtilsMetal.mm",
],
".",
"$dawn_root")
}
if (dawn_enable_null) {
sources += rebase_path([
"src/dawn_native/null/DeviceNull.cpp",
"src/dawn_native/null/DeviceNull.h",
"src/dawn_native/null/NullBackend.cpp",
],
".",
"$dawn_root")
}
if (dawn_enable_opengl) {
gn format third_party/dawn/BUILD.gn. Change-Id: Idf163572eedac0b434fbe49ddb8bd8e5b4ca0adb Reviewed-on: https://skia-review.googlesource.com/c/skia/+/237519 Commit-Queue: Stephen White <senorblanco@chromium.org> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
2019-08-27 20:35:11 +00:00
deps += [ ":libdawn_native_opengl_loader_gen" ]
Update to Dawn ToT. Switch to Dawn's version of dawn_generator.gni. This depends on having a file called build_overrides/dawn.gni. However, this will also enable us to use the upstream Dawn BUILD.gn files more easily in the future. This required adding it to compile.isolate, so the bots can pick it up. Keeping up with Dawn: Rename TextureFormat enums. Rename dawn::BufferUsageBit::TransferDst -> CopyDst. Removal of GLAD dependency. SPIRV-Tools update. Change-Id: Idcd5d1035ed106485dd2503b829e3c3b57a5688b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/228568 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-07-22 13:12:29 +00:00
sources += get_target_outputs(":libdawn_native_opengl_loader_gen")
Add first Dawn dependencies. Add Dawn repo to DEPS. Add skia_use_dawn flag to BUILD.gn (default false). Add Metal.framework for Mac when building for Dawn/Metal. Add d3d12, dxgi, d3dcompiler libs when building for Dawn/D3D12. Disable SPIRV validation when building for Dawn. Add BUILD.gn for dawn and dawn/third_party libraries. (Note that I had to split the declare_args() section of BUILD.gn into two, so that I could refer to skia_use_dawn in skia_enable_spirv_validation. If there's a better way to do this, I'm open to suggestions.) Change-Id: I9bdaf990694f6b8bcce6b77c1a8b1620a7396e34 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225137 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-07-10 19:51:30 +00:00
sources +=
rebase_path([
"src/dawn_native/opengl/BackendGL.cpp",
"src/dawn_native/opengl/BackendGL.h",
Roll Dawn and add dependencies Add Dawn's dependencies shaderc and glslang, and roll SPIRV. Update the BUILD.gn files to match upstream changes. Bug: skia:9939, chromium:1064563 Change-Id: Ie9720806efe823312da10f7911688f12cad0713e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/278770 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Weston Tracey <westont@google.com>
2020-03-30 17:23:00 +00:00
"src/dawn_native/opengl/BindGroupGL.cpp",
"src/dawn_native/opengl/BindGroupGL.h",
"src/dawn_native/opengl/BindGroupLayoutGL.cpp",
"src/dawn_native/opengl/BindGroupLayoutGL.h",
Add first Dawn dependencies. Add Dawn repo to DEPS. Add skia_use_dawn flag to BUILD.gn (default false). Add Metal.framework for Mac when building for Dawn/Metal. Add d3d12, dxgi, d3dcompiler libs when building for Dawn/D3D12. Disable SPIRV validation when building for Dawn. Add BUILD.gn for dawn and dawn/third_party libraries. (Note that I had to split the declare_args() section of BUILD.gn into two, so that I could refer to skia_use_dawn in skia_enable_spirv_validation. If there's a better way to do this, I'm open to suggestions.) Change-Id: I9bdaf990694f6b8bcce6b77c1a8b1620a7396e34 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225137 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-07-10 19:51:30 +00:00
"src/dawn_native/opengl/BufferGL.cpp",
"src/dawn_native/opengl/BufferGL.h",
"src/dawn_native/opengl/CommandBufferGL.cpp",
"src/dawn_native/opengl/CommandBufferGL.h",
"src/dawn_native/opengl/ComputePipelineGL.cpp",
"src/dawn_native/opengl/ComputePipelineGL.h",
"src/dawn_native/opengl/DeviceGL.cpp",
"src/dawn_native/opengl/DeviceGL.h",
"src/dawn_native/opengl/Forward.h",
Update Dawn backend to ToT. This is about 3 months of changes. Remove optional param to SetIndexBuffer(). Update SetVertexBuffers -> SetVertexBuffer. PipelineStageDescriptor -> ProgrammableStageDescriptor. Update past generator changes, ring buffer changes, etc. Add ErrorScopeTracker.cpp/.h to the build. Add Vulkan MemoryResourceAllocator files. Fix vertexShader ShaderStageDescriptor. Fix spirv-cross include path. TextureUsageBit -> TextureUsage, etc. DawnErrorCallback fixes. Removal of texture.CreateDefaultView. Fix GL supported_extesions mumbo jumbo. Update past ChromeOS change. Add PassResourceUsageTracker.cpp/.h to build. Add GLFormat.cpp/.h to build. Add Extensions and Toggles to the build. Add EncodingContext, AttachmentState to build. Add RenderEncoderBase to Dawn build. gn format dawn BUILD.gn, spirv-cross BUILD.gn. Change-Id: I26538d63c93668647048814aad6ad456ae323679 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248261 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-10-15 17:35:37 +00:00
"src/dawn_native/opengl/GLFormat.h",
"src/dawn_native/opengl/GLFormat.cpp",
Update to Dawn ToT. Switch to Dawn's version of dawn_generator.gni. This depends on having a file called build_overrides/dawn.gni. However, this will also enable us to use the upstream Dawn BUILD.gn files more easily in the future. This required adding it to compile.isolate, so the bots can pick it up. Keeping up with Dawn: Rename TextureFormat enums. Rename dawn::BufferUsageBit::TransferDst -> CopyDst. Removal of GLAD dependency. SPIRV-Tools update. Change-Id: Idcd5d1035ed106485dd2503b829e3c3b57a5688b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/228568 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-07-22 13:12:29 +00:00
"src/dawn_native/opengl/NativeSwapChainImplGL.cpp",
"src/dawn_native/opengl/NativeSwapChainImplGL.h",
"src/dawn_native/opengl/OpenGLFunctions.cpp",
"src/dawn_native/opengl/OpenGLFunctions.h",
Add first Dawn dependencies. Add Dawn repo to DEPS. Add skia_use_dawn flag to BUILD.gn (default false). Add Metal.framework for Mac when building for Dawn/Metal. Add d3d12, dxgi, d3dcompiler libs when building for Dawn/D3D12. Disable SPIRV validation when building for Dawn. Add BUILD.gn for dawn and dawn/third_party libraries. (Note that I had to split the declare_args() section of BUILD.gn into two, so that I could refer to skia_use_dawn in skia_enable_spirv_validation. If there's a better way to do this, I'm open to suggestions.) Change-Id: I9bdaf990694f6b8bcce6b77c1a8b1620a7396e34 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225137 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-07-10 19:51:30 +00:00
"src/dawn_native/opengl/OpenGLBackend.cpp",
"src/dawn_native/opengl/PersistentPipelineStateGL.cpp",
"src/dawn_native/opengl/PersistentPipelineStateGL.h",
"src/dawn_native/opengl/PipelineGL.cpp",
"src/dawn_native/opengl/PipelineGL.h",
"src/dawn_native/opengl/PipelineLayoutGL.cpp",
"src/dawn_native/opengl/PipelineLayoutGL.h",
"src/dawn_native/opengl/QueueGL.cpp",
"src/dawn_native/opengl/QueueGL.h",
"src/dawn_native/opengl/RenderPipelineGL.cpp",
"src/dawn_native/opengl/RenderPipelineGL.h",
"src/dawn_native/opengl/SamplerGL.cpp",
"src/dawn_native/opengl/SamplerGL.h",
"src/dawn_native/opengl/ShaderModuleGL.cpp",
"src/dawn_native/opengl/ShaderModuleGL.h",
"src/dawn_native/opengl/SwapChainGL.cpp",
"src/dawn_native/opengl/SwapChainGL.h",
"src/dawn_native/opengl/TextureGL.cpp",
"src/dawn_native/opengl/TextureGL.h",
"src/dawn_native/opengl/UtilsGL.cpp",
"src/dawn_native/opengl/UtilsGL.h",
Update to Dawn ToT. Switch to Dawn's version of dawn_generator.gni. This depends on having a file called build_overrides/dawn.gni. However, this will also enable us to use the upstream Dawn BUILD.gn files more easily in the future. This required adding it to compile.isolate, so the bots can pick it up. Keeping up with Dawn: Rename TextureFormat enums. Rename dawn::BufferUsageBit::TransferDst -> CopyDst. Removal of GLAD dependency. SPIRV-Tools update. Change-Id: Idcd5d1035ed106485dd2503b829e3c3b57a5688b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/228568 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-07-22 13:12:29 +00:00
"src/dawn_native/opengl/opengl_platform.h",
Add first Dawn dependencies. Add Dawn repo to DEPS. Add skia_use_dawn flag to BUILD.gn (default false). Add Metal.framework for Mac when building for Dawn/Metal. Add d3d12, dxgi, d3dcompiler libs when building for Dawn/D3D12. Disable SPIRV validation when building for Dawn. Add BUILD.gn for dawn and dawn/third_party libraries. (Note that I had to split the declare_args() section of BUILD.gn into two, so that I could refer to skia_use_dawn in skia_enable_spirv_validation. If there's a better way to do this, I'm open to suggestions.) Change-Id: I9bdaf990694f6b8bcce6b77c1a8b1620a7396e34 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225137 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-07-10 19:51:30 +00:00
],
".",
"$dawn_root")
}
configs -= [ "//gn:warnings" ]
if (dawn_enable_vulkan) {
Dawn: use Skia's copy of vulkan headers. Remove use of Dawn's third_party vulkan headers and the BUILD.gn file it rode in on. Change-Id: Ibfb6f063cae291445e19a15d42e96279be072376 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/237448 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-08-27 16:41:55 +00:00
configs += [ "//:our_vulkan_headers" ]
reformat GN files Change-Id: I2d19c4f0ff1439dcd923a3064eb3ba78432a5113 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281043 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
2020-04-01 18:47:34 +00:00
include_dirs =
[ "../.." ] # for "include/third_party/vulkan/vulkan/vk_platform.h" in
# vulkan.h
Update Dawn backend to ToT. This is about 3 months of changes. Remove optional param to SetIndexBuffer(). Update SetVertexBuffers -> SetVertexBuffer. PipelineStageDescriptor -> ProgrammableStageDescriptor. Update past generator changes, ring buffer changes, etc. Add ErrorScopeTracker.cpp/.h to the build. Add Vulkan MemoryResourceAllocator files. Fix vertexShader ShaderStageDescriptor. Fix spirv-cross include path. TextureUsageBit -> TextureUsage, etc. DawnErrorCallback fixes. Removal of texture.CreateDefaultView. Fix GL supported_extesions mumbo jumbo. Update past ChromeOS change. Add PassResourceUsageTracker.cpp/.h to build. Add GLFormat.cpp/.h to build. Add Extensions and Toggles to the build. Add EncodingContext, AttachmentState to build. Add RenderEncoderBase to Dawn build. gn format dawn BUILD.gn, spirv-cross BUILD.gn. Change-Id: I26538d63c93668647048814aad6ad456ae323679 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248261 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-10-15 17:35:37 +00:00
sources += rebase_path(
[
"src/dawn_native/vulkan/AdapterVk.cpp",
"src/dawn_native/vulkan/AdapterVk.h",
"src/dawn_native/vulkan/BackendVk.cpp",
"src/dawn_native/vulkan/BackendVk.h",
"src/dawn_native/vulkan/BindGroupLayoutVk.cpp",
"src/dawn_native/vulkan/BindGroupLayoutVk.h",
"src/dawn_native/vulkan/BindGroupVk.cpp",
"src/dawn_native/vulkan/BindGroupVk.h",
"src/dawn_native/vulkan/BufferVk.cpp",
"src/dawn_native/vulkan/BufferVk.h",
"src/dawn_native/vulkan/CommandBufferVk.cpp",
"src/dawn_native/vulkan/CommandBufferVk.h",
"src/dawn_native/vulkan/ComputePipelineVk.cpp",
"src/dawn_native/vulkan/ComputePipelineVk.h",
Roll Dawn to ToT. Change-Id: I55568429061f4775979cac4cdd3af59a6af81b6f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/252924 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-11-05 20:17:05 +00:00
"src/dawn_native/vulkan/DescriptorSetService.cpp",
"src/dawn_native/vulkan/DescriptorSetService.h",
Update Dawn backend to ToT. This is about 3 months of changes. Remove optional param to SetIndexBuffer(). Update SetVertexBuffers -> SetVertexBuffer. PipelineStageDescriptor -> ProgrammableStageDescriptor. Update past generator changes, ring buffer changes, etc. Add ErrorScopeTracker.cpp/.h to the build. Add Vulkan MemoryResourceAllocator files. Fix vertexShader ShaderStageDescriptor. Fix spirv-cross include path. TextureUsageBit -> TextureUsage, etc. DawnErrorCallback fixes. Removal of texture.CreateDefaultView. Fix GL supported_extesions mumbo jumbo. Update past ChromeOS change. Add PassResourceUsageTracker.cpp/.h to build. Add GLFormat.cpp/.h to build. Add Extensions and Toggles to the build. Add EncodingContext, AttachmentState to build. Add RenderEncoderBase to Dawn build. gn format dawn BUILD.gn, spirv-cross BUILD.gn. Change-Id: I26538d63c93668647048814aad6ad456ae323679 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248261 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-10-15 17:35:37 +00:00
"src/dawn_native/vulkan/DeviceVk.cpp",
"src/dawn_native/vulkan/DeviceVk.h",
"src/dawn_native/vulkan/ExternalHandle.h",
"src/dawn_native/vulkan/FencedDeleter.cpp",
"src/dawn_native/vulkan/FencedDeleter.h",
"src/dawn_native/vulkan/Forward.h",
"src/dawn_native/vulkan/NativeSwapChainImplVk.cpp",
"src/dawn_native/vulkan/NativeSwapChainImplVk.h",
"src/dawn_native/vulkan/PipelineLayoutVk.cpp",
"src/dawn_native/vulkan/PipelineLayoutVk.h",
"src/dawn_native/vulkan/QueueVk.cpp",
"src/dawn_native/vulkan/QueueVk.h",
"src/dawn_native/vulkan/RenderPassCache.cpp",
"src/dawn_native/vulkan/RenderPassCache.h",
"src/dawn_native/vulkan/RenderPipelineVk.cpp",
"src/dawn_native/vulkan/RenderPipelineVk.h",
Roll to ToT Dawn. Change-Id: Iff890f62f8ecae29ce7024f2bba206a2770c2600 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/251365 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-10-29 20:45:40 +00:00
"src/dawn_native/vulkan/ResourceHeapVk.cpp",
"src/dawn_native/vulkan/ResourceHeapVk.h",
"src/dawn_native/vulkan/ResourceMemoryAllocatorVk.cpp",
"src/dawn_native/vulkan/ResourceMemoryAllocatorVk.h",
Update Dawn backend to ToT. This is about 3 months of changes. Remove optional param to SetIndexBuffer(). Update SetVertexBuffers -> SetVertexBuffer. PipelineStageDescriptor -> ProgrammableStageDescriptor. Update past generator changes, ring buffer changes, etc. Add ErrorScopeTracker.cpp/.h to the build. Add Vulkan MemoryResourceAllocator files. Fix vertexShader ShaderStageDescriptor. Fix spirv-cross include path. TextureUsageBit -> TextureUsage, etc. DawnErrorCallback fixes. Removal of texture.CreateDefaultView. Fix GL supported_extesions mumbo jumbo. Update past ChromeOS change. Add PassResourceUsageTracker.cpp/.h to build. Add GLFormat.cpp/.h to build. Add Extensions and Toggles to the build. Add EncodingContext, AttachmentState to build. Add RenderEncoderBase to Dawn build. gn format dawn BUILD.gn, spirv-cross BUILD.gn. Change-Id: I26538d63c93668647048814aad6ad456ae323679 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248261 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-10-15 17:35:37 +00:00
"src/dawn_native/vulkan/SamplerVk.cpp",
"src/dawn_native/vulkan/SamplerVk.h",
"src/dawn_native/vulkan/ShaderModuleVk.cpp",
"src/dawn_native/vulkan/ShaderModuleVk.h",
"src/dawn_native/vulkan/StagingBufferVk.cpp",
"src/dawn_native/vulkan/StagingBufferVk.h",
"src/dawn_native/vulkan/SwapChainVk.cpp",
"src/dawn_native/vulkan/SwapChainVk.h",
"src/dawn_native/vulkan/TextureVk.cpp",
"src/dawn_native/vulkan/TextureVk.h",
"src/dawn_native/vulkan/UtilsVulkan.cpp",
"src/dawn_native/vulkan/UtilsVulkan.h",
"src/dawn_native/vulkan/VulkanBackend.cpp",
"src/dawn_native/vulkan/VulkanError.cpp",
"src/dawn_native/vulkan/VulkanError.h",
"src/dawn_native/vulkan/VulkanFunctions.cpp",
"src/dawn_native/vulkan/VulkanFunctions.h",
"src/dawn_native/vulkan/VulkanInfo.cpp",
"src/dawn_native/vulkan/VulkanInfo.h",
"src/dawn_native/vulkan/external_memory/MemoryService.h",
"src/dawn_native/vulkan/external_semaphore/SemaphoreService.h",
],
".",
"$dawn_root")
Roll Dawn and add dependencies Add Dawn's dependencies shaderc and glslang, and roll SPIRV. Update the BUILD.gn files to match upstream changes. Bug: skia:9939, chromium:1064563 Change-Id: Ie9720806efe823312da10f7911688f12cad0713e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/278770 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Weston Tracey <westont@google.com>
2020-03-30 17:23:00 +00:00
if (is_chromeos) {
sources += rebase_path(
[
"src/dawn_native/vulkan/external_memory/MemoryServiceDmaBuf.cpp",
"src/dawn_native/vulkan/external_semaphore/SemaphoreServiceOpaqueFD.cpp",
],
".",
"$dawn_root")
} else if (is_linux) {
Update Dawn backend to ToT. This is about 3 months of changes. Remove optional param to SetIndexBuffer(). Update SetVertexBuffers -> SetVertexBuffer. PipelineStageDescriptor -> ProgrammableStageDescriptor. Update past generator changes, ring buffer changes, etc. Add ErrorScopeTracker.cpp/.h to the build. Add Vulkan MemoryResourceAllocator files. Fix vertexShader ShaderStageDescriptor. Fix spirv-cross include path. TextureUsageBit -> TextureUsage, etc. DawnErrorCallback fixes. Removal of texture.CreateDefaultView. Fix GL supported_extesions mumbo jumbo. Update past ChromeOS change. Add PassResourceUsageTracker.cpp/.h to build. Add GLFormat.cpp/.h to build. Add Extensions and Toggles to the build. Add EncodingContext, AttachmentState to build. Add RenderEncoderBase to Dawn build. gn format dawn BUILD.gn, spirv-cross BUILD.gn. Change-Id: I26538d63c93668647048814aad6ad456ae323679 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248261 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-10-15 17:35:37 +00:00
sources += rebase_path(
[
"src/dawn_native/vulkan/external_memory/MemoryServiceOpaqueFD.cpp",
"src/dawn_native/vulkan/external_semaphore/SemaphoreServiceOpaqueFD.cpp",
],
".",
"$dawn_root")
} else {
sources += rebase_path(
[
"src/dawn_native/vulkan/external_memory/MemoryServiceNull.cpp",
"src/dawn_native/vulkan/external_semaphore/SemaphoreServiceNull.cpp",
],
".",
"$dawn_root")
}
Add first Dawn dependencies. Add Dawn repo to DEPS. Add skia_use_dawn flag to BUILD.gn (default false). Add Metal.framework for Mac when building for Dawn/Metal. Add d3d12, dxgi, d3dcompiler libs when building for Dawn/D3D12. Disable SPIRV validation when building for Dawn. Add BUILD.gn for dawn and dawn/third_party libraries. (Note that I had to split the declare_args() section of BUILD.gn into two, so that I could refer to skia_use_dawn in skia_enable_spirv_validation. If there's a better way to do this, I'm open to suggestions.) Change-Id: I9bdaf990694f6b8bcce6b77c1a8b1620a7396e34 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/225137 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-07-10 19:51:30 +00:00
}
}
Update Dawn to ToT. Separate out generation of cpp headers. Change-Id: I4b3e14dcf7f31a4587fc2de48d79455e98bbf53c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248935 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-10-17 15:31:34 +00:00
Revert "Enable deprecated-copy-dtor warning." This reverts commit e990fcc4b0c7d2d7b7e5350970da538a8c7a6c20. Reason for revert: Build-Win-Clang-x86_64-Release-Shared Original change's description: > Enable deprecated-copy-dtor warning. > > In C++11 a user declared destructor still requires the compiler to > implicitly default the copy constructor and copy assignment operator, > but this is deprecated. Note that a user declared destructor suppresses > the move constructor and move assignment operator; a user declared > destructor exists if any '~Foo' method declaration appears inside > 'class Foo' (even if defaulted); if the copy and move operations are the > same then copy operations that take 'const Foo&' will do fine double > duty as move operations. > > Clang seems to have an issue with this warning, in that it does not > appear to distinguish between compiler defaulted and user defaulted > destructors. As a result, it does not always warn when it should. > There may yet be places in the code where a move operation is desired > but may be suppressed because the implicitly defaulted moves are not > declared because a destructor has been declared. > > This wraps dawn and shaderc configs in 'third_party' so that their > headers will be included through '-isystem' in order to avoid the > warnings generated by including their headers. > > Change-Id: I681524cd890d86305aa99b6b765a52113b4dfa4b > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/280406 > Reviewed-by: Mike Klein <mtklein@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Ben Wagner <bungeman@google.com> TBR=mtklein@google.com,bsalomon@google.com,bungeman@google.com Change-Id: Icd6a2487637d21fcf7c4c7ab7cba7a8adfda5afd No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/280836 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
2020-03-31 22:31:46 +00:00
config("libdawn_public") {
Update Dawn to ToT. Separate out generation of cpp headers. Change-Id: I4b3e14dcf7f31a4587fc2de48d79455e98bbf53c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248935 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-10-17 15:31:34 +00:00
include_dirs = [
"$dawn_gen_root/src/include",
"$dawn_gen_root/src",
"$dawn_root/src/include",
"$dawn_root/src",
]
}
config("dawn_internal") {
include_dirs = [ "$dawn_root/src" ]
defines = []
if (dawn_always_assert || is_debug) {
defines += [ "DAWN_ENABLE_ASSERTS" ]
}
if (dawn_enable_d3d12) {
defines += [ "DAWN_ENABLE_BACKEND_D3D12" ]
}
if (dawn_enable_metal) {
defines += [ "DAWN_ENABLE_BACKEND_METAL" ]
}
if (dawn_enable_null) {
defines += [ "DAWN_ENABLE_BACKEND_NULL" ]
}
if (dawn_enable_opengl) {
defines += [ "DAWN_ENABLE_BACKEND_OPENGL" ]
}
if (dawn_enable_vulkan) {
defines += [ "DAWN_ENABLE_BACKEND_VULKAN" ]
}
configs = [ ":libdawn_public" ]
# Only internal Dawn targets can use this config, this means only targets in
# this BUILD.gn file.
visibility = [ ":*" ]
}
static_library("dawn_common") {
sources = rebase_path([
"Assert.cpp",
"Assert.h",
"BitSetIterator.h",
"Compiler.h",
"DynamicLib.cpp",
"DynamicLib.h",
Roll Dawn and add dependencies Add Dawn's dependencies shaderc and glslang, and roll SPIRV. Update the BUILD.gn files to match upstream changes. Bug: skia:9939, chromium:1064563 Change-Id: Ie9720806efe823312da10f7911688f12cad0713e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/278770 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Weston Tracey <westont@google.com>
2020-03-30 17:23:00 +00:00
"GPUInfo.cpp",
"GPUInfo.h",
Update Dawn to ToT. Separate out generation of cpp headers. Change-Id: I4b3e14dcf7f31a4587fc2de48d79455e98bbf53c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248935 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-10-17 15:31:34 +00:00
"HashUtils.h",
Roll Dawn and add dependencies Add Dawn's dependencies shaderc and glslang, and roll SPIRV. Update the BUILD.gn files to match upstream changes. Bug: skia:9939, chromium:1064563 Change-Id: Ie9720806efe823312da10f7911688f12cad0713e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/278770 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Weston Tracey <westont@google.com>
2020-03-30 17:23:00 +00:00
"LinkedList.h",
"Log.cpp",
"Log.h",
Update Dawn to ToT. Separate out generation of cpp headers. Change-Id: I4b3e14dcf7f31a4587fc2de48d79455e98bbf53c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248935 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-10-17 15:31:34 +00:00
"Math.cpp",
"Math.h",
Roll Dawn and add dependencies Add Dawn's dependencies shaderc and glslang, and roll SPIRV. Update the BUILD.gn files to match upstream changes. Bug: skia:9939, chromium:1064563 Change-Id: Ie9720806efe823312da10f7911688f12cad0713e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/278770 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Weston Tracey <westont@google.com>
2020-03-30 17:23:00 +00:00
"PlacementAllocated.h",
Update Dawn to ToT. Separate out generation of cpp headers. Change-Id: I4b3e14dcf7f31a4587fc2de48d79455e98bbf53c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248935 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-10-17 15:31:34 +00:00
"Platform.h",
"Result.cpp",
"Result.h",
"Serial.h",
"SerialMap.h",
"SerialQueue.h",
"SerialStorage.h",
Roll Dawn and add dependencies Add Dawn's dependencies shaderc and glslang, and roll SPIRV. Update the BUILD.gn files to match upstream changes. Bug: skia:9939, chromium:1064563 Change-Id: Ie9720806efe823312da10f7911688f12cad0713e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/278770 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Weston Tracey <westont@google.com>
2020-03-30 17:23:00 +00:00
"SlabAllocator.cpp",
"SlabAllocator.h",
Update Dawn to ToT. Separate out generation of cpp headers. Change-Id: I4b3e14dcf7f31a4587fc2de48d79455e98bbf53c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248935 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-10-17 15:31:34 +00:00
"SwapChainUtils.h",
"vulkan_platform.h",
"windows_with_undefs.h",
],
".",
"$dawn_root/src/common")
configs += [ ":dawn_internal" ]
reformat GN files Change-Id: I2d19c4f0ff1439dcd923a3064eb3ba78432a5113 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281043 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
2020-04-01 18:47:34 +00:00
deps = [ ":dawn_headers" ]
Roll Dawn and add dependencies Add Dawn's dependencies shaderc and glslang, and roll SPIRV. Update the BUILD.gn files to match upstream changes. Bug: skia:9939, chromium:1064563 Change-Id: Ie9720806efe823312da10f7911688f12cad0713e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/278770 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Weston Tracey <westont@google.com>
2020-03-30 17:23:00 +00:00
if (dawn_enable_vulkan) {
configs += [ "//:our_vulkan_headers" ]
}
Update Dawn to ToT. Separate out generation of cpp headers. Change-Id: I4b3e14dcf7f31a4587fc2de48d79455e98bbf53c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248935 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-10-17 15:31:34 +00:00
}
###############################################################################
# Dawn headers and libdawn.so
###############################################################################
dawn_json_generator("dawn_headers_gen") {
target = "dawn_headers"
outputs = [
"src/include/dawn/dawn_proc_table.h",
Roll to ToT Dawn. Change-Id: Iff890f62f8ecae29ce7024f2bba206a2770c2600 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/251365 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-10-29 20:45:40 +00:00
"src/include/dawn/webgpu.h",
Update Dawn to ToT. Separate out generation of cpp headers. Change-Id: I4b3e14dcf7f31a4587fc2de48d79455e98bbf53c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248935 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-10-17 15:31:34 +00:00
]
}
source_set("dawn_headers") {
public_configs = [ ":libdawn_public" ]
reformat GN files Change-Id: I2d19c4f0ff1439dcd923a3064eb3ba78432a5113 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281043 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
2020-04-01 18:47:34 +00:00
public_deps = [ ":dawn_headers_gen" ]
Update Dawn to ToT. Separate out generation of cpp headers. Change-Id: I4b3e14dcf7f31a4587fc2de48d79455e98bbf53c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248935 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-10-17 15:31:34 +00:00
sources = get_target_outputs(":dawn_headers_gen")
sources += [
"${dawn_root}/src/include/dawn/dawn_export.h",
"${dawn_root}/src/include/dawn/dawn_wsi.h",
]
}
###############################################################################
# Dawn C++ headers
###############################################################################
dawn_json_generator("dawncpp_headers_gen") {
target = "dawncpp_headers"
reformat GN files Change-Id: I2d19c4f0ff1439dcd923a3064eb3ba78432a5113 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281043 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
2020-04-01 18:47:34 +00:00
outputs = [ "src/include/dawn/webgpu_cpp.h" ]
Update Dawn to ToT. Separate out generation of cpp headers. Change-Id: I4b3e14dcf7f31a4587fc2de48d79455e98bbf53c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248935 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-10-17 15:31:34 +00:00
}
source_set("dawncpp_headers") {
public_deps = [
":dawn_headers",
":dawncpp_headers_gen",
]
sources = get_target_outputs(":dawncpp_headers_gen")
sources += [ "${dawn_root}/src/include/dawn/EnumClassBitmasks.h" ]
}
###############################################################################
# Dawn C++ wrapper
###############################################################################
dawn_json_generator("dawncpp_gen") {
target = "dawncpp"
reformat GN files Change-Id: I2d19c4f0ff1439dcd923a3064eb3ba78432a5113 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281043 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
2020-04-01 18:47:34 +00:00
outputs = [ "src/dawn/webgpu_cpp.cpp" ]
Update Dawn to ToT. Separate out generation of cpp headers. Change-Id: I4b3e14dcf7f31a4587fc2de48d79455e98bbf53c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248935 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-10-17 15:31:34 +00:00
}
source_set("dawncpp") {
deps = [
":dawncpp_gen",
":dawncpp_headers",
]
sources = get_target_outputs(":dawncpp_gen")
}
###############################################################################
# libdawn_proc
###############################################################################
dawn_json_generator("libdawn_proc_gen") {
target = "dawn_proc"
reformat GN files Change-Id: I2d19c4f0ff1439dcd923a3064eb3ba78432a5113 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281043 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
2020-04-01 18:47:34 +00:00
outputs = [ "src/dawn/dawn_proc.c" ]
Update Dawn to ToT. Separate out generation of cpp headers. Change-Id: I4b3e14dcf7f31a4587fc2de48d79455e98bbf53c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248935 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-10-17 15:31:34 +00:00
}
static_library("libdawn_proc") {
reformat GN files Change-Id: I2d19c4f0ff1439dcd923a3064eb3ba78432a5113 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281043 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
2020-04-01 18:47:34 +00:00
public_deps = [ ":dawn_headers" ]
deps = [ ":libdawn_proc_gen" ]
Update Dawn to ToT. Separate out generation of cpp headers. Change-Id: I4b3e14dcf7f31a4587fc2de48d79455e98bbf53c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248935 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-10-17 15:31:34 +00:00
sources = get_target_outputs(":libdawn_proc_gen")
sources += [ "${dawn_root}/src/include/dawn/dawn_proc.h" ]
Format GN, isn't checked in third_party, so missed it the first time. Bug: skia:9939 Change-Id: Ia02803f93a8b90fd8d03465226379b028add7f5e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/274046 Auto-Submit: Weston Tracey <westont@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
2020-02-28 18:31:46 +00:00
cflags = [ "-Wno-strict-prototypes" ]
Update Dawn to ToT. Separate out generation of cpp headers. Change-Id: I4b3e14dcf7f31a4587fc2de48d79455e98bbf53c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/248935 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
2019-10-17 15:31:34 +00:00
}
Reference in New Issue Copy Permalink