AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
efe767da91
skia2/modules/canvaskit/externs.js

1130 lines
28 KiB
JavaScript
Raw Normal View History

[CanvasKit] Implement some basic Canvas/Surface things. drawText is having issues in a release build. Skottie sometimes asserts in debug mode. This possibly has something to do with memory alignment - like https://skia-review.googlesource.com/c/skia/+/155980 helped fix. Patchset 9 shows off integrating Skia drawing to an HTML canvas using Ganesh. To see it locally, set up https://kripken.github.io/emscripten-site/docs/getting_started/downloads.html and then set $EMSDK to be that directory. Then run make clean make local-example and navigate to http://localhost:8000/skia-wasm/example.html Patchset 20 shows off Skottie animating directly to a Canvas. Docs-Preview: https://skia.org/?cl=153882 Bug: skia: Change-Id: I2ad2f4ffac00925ee901982ccbaeb7aa63b1ea23 Reviewed-on: https://skia-review.googlesource.com/153882 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-09-20 21:39:31 +00:00
/*
* This externs file prevents the Closure JS compiler from minifying away
* names of objects created by Emscripten.
* Basically, by defining empty objects and functions here, Closure will
* know not to rename them. This is needed because of our pre-js files,
* that is, the JS we hand-write to bundle into the output. That JS will be
* hit by the closure compiler and thus needs to know about what functions
* have special names and should not be minified.
*
* Emscripten does not support automatically generating an externs file, so we
* do it by hand. The general process is to write some JS code, and then put any
* calls to CanvasKit or related things in here. Running ./compile.sh and then
* looking at the minified results or running the Release trybot should
* verify nothing was missed. Optionally, looking directly at the minified
* pathkit.js can be useful when developing locally.
*
* Docs:
* https://github.com/cljsjs/packages/wiki/Creating-Externs
* https://github.com/google/closure-compiler/wiki/Types-in-the-Closure-Type-System
*
* Example externs:
* https://github.com/google/closure-compiler/tree/master/externs
*/
var CanvasKit = {
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
// public API (i.e. things we declare in the pre-js file or in the cpp bindings)
Color: function() {},
Reland "Switch to using a Float32Array (bound as value array) for color." This is a reland of 4e79b6730dfce84f2d115ad3babf7b848d44a2b5 Original change's description: > Switch to using a Float32Array (bound as value array) for color. > > Change-Id: I1bcca931954b1399c79f4074a3d57a68847ac785 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/276757 > Commit-Queue: Nathaniel Nifong <nifong@google.com> > Reviewed-by: Kevin Lubick <kjlubick@google.com> Change-Id: If6b9097b2fcd6b9dbf75c6dd22138e0b2531e70d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/278780 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-26 13:27:48 +00:00
Color4f: function() {},
[canvaskit] Add flexibility to setColor API Change-Id: Ib0946bb05bc5cbf485a6687e46c7e61312bcd24c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/293344 Reviewed-by: Yegor Jbanov <yjbanov@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-06-02 20:15:23 +00:00
ColorAsInt: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
LTRBRect: function() {},
XYWHRect: function() {},
Reland "[canvaskit] Change SkRects to be arrays, not objects." This is a reland of bdc214a50e854fabb62bda126977b63e298dea9f The CPU version of SkottieWasm is timing out for reasons unknown, but the GPU version is happy. I think we can get rid of the CPU version of the job since it has been more or less superseded by the SkottieFrames one (and the latter is more stable). Original change's description: > [canvaskit] Change SkRects to be arrays, not objects. > > This changes several APIs, so there are lots of breaking > notes in the Changelog. > > This made the "draw 100 colored regions" benchmark about > 20% faster (1ms -> .8ms). > > In theory, rendering should stay the same. > > Change-Id: Ib80b15e2d980ad5d568fff4460d2b529766c1b36 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312491 > Reviewed-by: Nathaniel Nifong <nifong@google.com> Change-Id: I674aba85ecfb30b72e94cbaf89b2d97bfae3b7a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315142 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-09-03 14:02:10 +00:00
LTRBiRect: function() {},
XYWHiRect: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
RRectXY: function() {},
/** @return {ImageData} */
ImageData: function() {},
GetWebGLContext: function() {},
MakeBlurMaskFilter: function() {},
MakeCanvas: function() {},
MakeCanvasSurface: function() {},
MakeGrContext: function() {},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
/** @return {CanvasKit.AnimatedImage} */
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
MakeAnimatedImageFromEncoded: function() {},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
/** @return {CanvasKit.Image} */
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
MakeImage: function() {},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
/** @return {CanvasKit.Image} */
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
MakeImageFromEncoded: function() {},
Added CanvasKit.MakeImageFromCanvasImageSource which is useful as an alternative to CanvasKit.MakeImageFromEncoded, when used with Browser APIs for loading/decoding images. - `CanvasKit.MakeImageFromCanvasImageSource` takes either an HTMLImageElement, SVGImageElement, HTMLVideoElement, HTMLCanvasElement, ImageBitmap, or OffscreenCanvas and returns an SkImage. This function is an alternative to `CanvasKit.MakeImageFromEncoded` for creating SkImages when loading and decoding images. In the future, codesize of CanvasKit may be able to be reduced by removing image codecs in wasm, if browser APIs for decoding images are used along with `CanvasKit.MakeImageFromCanvasImageSource` instead of `CanvasKit.MakeImageFromEncoded`. - Three usage examples of `CanvasKit.MakeImageFromCanvasImageSource` in core.spec.ts. These examples use browser APIs to decode images including 2d canvas, bitmaprenderer canvas, HTMLImageElement and Blob. - Added support for asynchronous callbacks in perfs and tests. Here are notes on the image decoding approaches we tested and perfed in the process of finding ways to use Browser APIs to decode images: 1. pipeline: ArrayBuffer → ImageData → ctx.putImageData → context.getImageData → Uint8Array → CanvasKit.MakeImage ❌ Problem: ImageData constructor expects decoded bytes already. 2. interface.js - CanvasKit.ExperimentalCanvas2DMakeImageFromEncoded (async function) pipeline: ArrayBuffer → Blob -> HTMLImageElement -> draw on Canvas2d -> context.getImageData → Uint8Array → CanvasKit.MakeImage ✅ Works ⏱ Performance: 3rd place (in my testing locally) 3. interface.js - CanvasKit.ExperimentalCanvas2DMakeImageFromEncoded2 (async function) ArrayBuffer → Blob → ImageBitmap → draw on Canvas2d → context.getImageData → Uint8Array → CanvasKit.MakeImage ✅ Works ⏱ Performance: 2nd place (in my testing locally) 4. interface.js - CanvasKit.ExperimentalCanvas2DMakeImageFromEncoded3 (async function) ArrayBuffer → Blob → ImageBitmap → draw on canvas 1 using bitmaprenderer context → draw canvas 1 on canvas 2 using drawImage → context2d.getImageData → Uint8Array → CanvasKit.MakeImage ✅ Works ⏱ Performance: 1st place (in my testing locally) - quite surprising, this in some ways seems to be a more roundabout way of CanvasKit.ExperimentalCanvas2DMakeImageFromEncoded2, but it seems bitmaprenderer context is fairly fast. Bug: skia:10360 Change-Id: I6fe94b8196dfd1ad0d8929f04bb1697da537ca18 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295390 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-06-15 18:53:27 +00:00
MakeImageFromCanvasImageSource: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
MakeOnScreenGLSurface: function() {},
MakePathFromCmds: function() {},
MakePathFromOp: function() {},
MakePathFromSVGString: function() {},
MakeRenderTarget: function() {},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
MakePicture: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
MakeSWCanvasSurface: function() {},
MakeManagedAnimation: function() {},
MakeParticles: function() {},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
MakeVertices: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
MakeSurface: function() {},
MakeWebGLCanvasSurface: function() {},
Malloc: function() {},
[canvaskit] Expose Glyph ID APIs Note: I intend to make shaping.html live in demos.skia.org, but that is hard to verify it works until the APIs land. Change-Id: I3af1cf8ded316f616d05ee60198393ed9c9a284f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/319130 Reviewed-by: Nathaniel Nifong <nifong@google.com> Reviewed-by: Mike Reed <reed@google.com>
2020-09-25 14:52:16 +00:00
MallocGlyphIDs: function() {},
[canvaskit] Do not automatically free things provided by Malloc. If ever CanvasKit accepts an array as a parameter, if the array provided was produced by Malloc, CanvasKit will use the pointer of that array and not free it after. Change-Id: I4806a48e5e030edd787944f652984ea3516b3022 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/292561 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-05-28 18:43:38 +00:00
Free: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
computeTonalColors: function() {},
currentContext: function() {},
getColorComponents: function() {},
getDecodeCacheLimitBytes: function() {},
getDecodeCacheUsageBytes: function() {},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
getDataBytes: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
multiplyByAlpha: function() {},
parseColorString: function() {},
setCurrentContext: function() {},
setDecodeCacheLimitBytes: function() {},
[canvaskit] Properly fix Safari (detect if WebGL2 is not available) I believe we had incorrectly been using the wrong emscripten-provided helper to make our WebGL contexts. Thus, the parameter that was specifying webGL 1 vs 2 was not getting properly passed in (I believe because of a closure-induced problem in minification). I validated this build on my local Mac+Safari test harness. Bug: skia:10171 Change-Id: Ifd5e55a6b64407bf84168e118d8dda4738ef5487 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289885 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-05-14 18:50:54 +00:00
// Defined by emscripten.
createContext:function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
// private API (i.e. things declared in the bindings that we use
// in the pre-js file)
Pass 4f colors to private functions with float pointers Change-Id: I4534a246c37870750298d39edcbc869781dc1008 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286880 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-05-04 20:46:17 +00:00
_computeTonalColors: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
_MakeImage: function() {},
_MakeLinearGradientShader: function() {},
_MakeRadialGradientShader: function() {},
Sweep gradient support for CanvasKit Change-Id: I04af9ea7aa6c6f95de6ff1eaf5ee41d59df7f09e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/277059 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-16 16:17:30 +00:00
_MakeSweepGradientShader: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
_MakeManagedAnimation: function() {},
_MakeParticles: function() {},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
_MakePicture: function() {},
_MakeVertices: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
_MakeTwoPointConicalGradientShader: function() {},
_decodeAnimatedImage: function() {},
_decodeImage: function() {},
_drawShapedText: function() {},
_getRasterDirectSurface: function() {},
_getRasterN32PremulSurface: function() {},
// The testing object is meant to expose internal functions
// for more fine-grained testing, e.g. parseColor
_testing: {},
// Objects and properties on CanvasKit
Reland "[canvaskit] Change SkRects to be arrays, not objects." This is a reland of bdc214a50e854fabb62bda126977b63e298dea9f The CPU version of SkottieWasm is timing out for reasons unknown, but the GPU version is happy. I think we can get rid of the CPU version of the job since it has been more or less superseded by the SkottieFrames one (and the latter is more stable). Original change's description: > [canvaskit] Change SkRects to be arrays, not objects. > > This changes several APIs, so there are lots of breaking > notes in the Changelog. > > This made the "draw 100 colored regions" benchmark about > 20% faster (1ms -> .8ms). > > In theory, rendering should stay the same. > > Change-Id: Ib80b15e2d980ad5d568fff4460d2b529766c1b36 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312491 > Reviewed-by: Nathaniel Nifong <nifong@google.com> Change-Id: I674aba85ecfb30b72e94cbaf89b2d97bfae3b7a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315142 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-09-03 14:02:10 +00:00
Animation: {
prototype: {
render: function() {},
},
_render: function() {},
},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
GrContext: {
// public API (from C++ bindings)
getResourceCacheLimitBytes: function() {},
getResourceCacheUsageBytes: function() {},
releaseResourcesAndAbandonContext: function() {},
setResourceCacheLimitBytes: function() {},
},
Pass 4f colors to private functions with float pointers Change-Id: I4534a246c37870750298d39edcbc869781dc1008 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286880 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-05-04 20:46:17 +00:00
ManagedAnimation: {
prototype: {
Reland "[canvaskit] Change SkRects to be arrays, not objects." This is a reland of bdc214a50e854fabb62bda126977b63e298dea9f The CPU version of SkottieWasm is timing out for reasons unknown, but the GPU version is happy. I think we can get rid of the CPU version of the job since it has been more or less superseded by the SkottieFrames one (and the latter is more stable). Original change's description: > [canvaskit] Change SkRects to be arrays, not objects. > > This changes several APIs, so there are lots of breaking > notes in the Changelog. > > This made the "draw 100 colored regions" benchmark about > 20% faster (1ms -> .8ms). > > In theory, rendering should stay the same. > > Change-Id: Ib80b15e2d980ad5d568fff4460d2b529766c1b36 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312491 > Reviewed-by: Nathaniel Nifong <nifong@google.com> Change-Id: I674aba85ecfb30b72e94cbaf89b2d97bfae3b7a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315142 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-09-03 14:02:10 +00:00
render: function() {},
seek: function() {},
seekFrame: function() {},
Pass 4f colors to private functions with float pointers Change-Id: I4534a246c37870750298d39edcbc869781dc1008 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286880 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-05-04 20:46:17 +00:00
setColor: function() {},
},
Reland "[canvaskit] Change SkRects to be arrays, not objects." This is a reland of bdc214a50e854fabb62bda126977b63e298dea9f The CPU version of SkottieWasm is timing out for reasons unknown, but the GPU version is happy. I think we can get rid of the CPU version of the job since it has been more or less superseded by the SkottieFrames one (and the latter is more stable). Original change's description: > [canvaskit] Change SkRects to be arrays, not objects. > > This changes several APIs, so there are lots of breaking > notes in the Changelog. > > This made the "draw 100 colored regions" benchmark about > 20% faster (1ms -> .8ms). > > In theory, rendering should stay the same. > > Change-Id: Ib80b15e2d980ad5d568fff4460d2b529766c1b36 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312491 > Reviewed-by: Nathaniel Nifong <nifong@google.com> Change-Id: I674aba85ecfb30b72e94cbaf89b2d97bfae3b7a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315142 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-09-03 14:02:10 +00:00
_render: function() {},
_seek: function() {},
_seekFrame: function() {},
Pass 4f colors to private functions with float pointers Change-Id: I4534a246c37870750298d39edcbc869781dc1008 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286880 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-05-04 20:46:17 +00:00
},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
Paragraph: {
// public API (from C++ bindings)
didExceedMaxLines: function() {},
getAlphabeticBaseline: function() {},
getGlyphPositionAtCoordinate: function() {},
getHeight: function() {},
getIdeographicBaseline: function() {},
getLongestLine: function() {},
getMaxIntrinsicWidth: function() {},
getMaxWidth: function() {},
getMinIntrinsicWidth: function() {},
getWordBoundary: function() {},
layout: function() {},
// private API
/** @return {Float32Array} */
_getRectsForRange: function() {},
Add more paragraph bindings to CanvasKit Change-Id: Ib02b6504724e4d7cfa197a3508f8c0b84b4135bf Reviewed-on: https://skia-review.googlesource.com/c/skia/+/313146 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Yegor Jbanov <yjbanov@google.com> Auto-Submit: Harry Terkelsen <het@google.com>
2020-10-02 22:24:13 +00:00
_getRectsForPlaceholders: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
},
Pass 4f colors to private functions with float pointers Change-Id: I4534a246c37870750298d39edcbc869781dc1008 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286880 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-05-04 20:46:17 +00:00
ParagraphBuilder: {
Make: function() {},
[CanvasKit] Expose TypefaceFontProvider. Change-Id: I950a3a4f45b7b4a106299576bc918531054b23f6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/307873 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-08-04 20:21:09 +00:00
MakeFromFontProvider: function() {},
Pass 4f colors to private functions with float pointers Change-Id: I4534a246c37870750298d39edcbc869781dc1008 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286880 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-05-04 20:46:17 +00:00
addText: function() {},
build: function() {},
pop: function() {},
prototype: {
pushStyle: function() {},
Add ParagraphBuilder.pushPaintStyle to allow text to be colors with paints. Previously one could not color text with paints, even though TextStyle's foregroundColor and backgroundColor fields are SkPaints. Canvaskit only exposed these as colors in order to allow SimpleTextStyle to be a value object that would not have to be deleted by the user. CanvasKit.Paint is a bound SkPaint. I wanted to allow a user to pass a paint to be used in a text style without alterting SimpleTextStyle's status as a value-object. So I've added a new bound method, pushPaintStyle which acts just like pushStyle but allows a foreground and background paint to be supplied which are used to override the existing paints. The user is responsible for deleting these paints. Sorry for the kludgy design, if you have got a more elegant way, I'm open to suggestions. Change-Id: Ib78464171346fe9f717f6d5b9d9428b1d0278498 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/307596 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Julia Lavrova <jlavrova@google.com>
2020-08-04 13:06:54 +00:00
pushPaintStyle: function() {},
Add more paragraph bindings to CanvasKit Change-Id: Ib02b6504724e4d7cfa197a3508f8c0b84b4135bf Reviewed-on: https://skia-review.googlesource.com/c/skia/+/313146 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Yegor Jbanov <yjbanov@google.com> Auto-Submit: Harry Terkelsen <het@google.com>
2020-10-02 22:24:13 +00:00
addPlaceholder: function() {},
Pass 4f colors to private functions with float pointers Change-Id: I4534a246c37870750298d39edcbc869781dc1008 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286880 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-05-04 20:46:17 +00:00
},
// private API
_Make: function() {},
[CanvasKit] Expose TypefaceFontProvider. Change-Id: I950a3a4f45b7b4a106299576bc918531054b23f6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/307873 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-08-04 20:21:09 +00:00
_MakeFromFontProvider: function() {},
Pass 4f colors to private functions with float pointers Change-Id: I4534a246c37870750298d39edcbc869781dc1008 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286880 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-05-04 20:46:17 +00:00
_pushStyle: function() {},
Add ParagraphBuilder.pushPaintStyle to allow text to be colors with paints. Previously one could not color text with paints, even though TextStyle's foregroundColor and backgroundColor fields are SkPaints. Canvaskit only exposed these as colors in order to allow SimpleTextStyle to be a value object that would not have to be deleted by the user. CanvasKit.Paint is a bound SkPaint. I wanted to allow a user to pass a paint to be used in a text style without alterting SimpleTextStyle's status as a value-object. So I've added a new bound method, pushPaintStyle which acts just like pushStyle but allows a foreground and background paint to be supplied which are used to override the existing paints. The user is responsible for deleting these paints. Sorry for the kludgy design, if you have got a more elegant way, I'm open to suggestions. Change-Id: Ib78464171346fe9f717f6d5b9d9428b1d0278498 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/307596 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Julia Lavrova <jlavrova@google.com>
2020-08-04 13:06:54 +00:00
_pushPaintStyle: function() {},
Add more paragraph bindings to CanvasKit Change-Id: Ib02b6504724e4d7cfa197a3508f8c0b84b4135bf Reviewed-on: https://skia-review.googlesource.com/c/skia/+/313146 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Yegor Jbanov <yjbanov@google.com> Auto-Submit: Harry Terkelsen <het@google.com>
2020-10-02 22:24:13 +00:00
_addPlaceholder: function() {},
Pass 4f colors to private functions with float pointers Change-Id: I4534a246c37870750298d39edcbc869781dc1008 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286880 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-05-04 20:46:17 +00:00
},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
RuntimeEffect: {
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
// public API (from C++ bindings)
Make: function() {},
// private API
_makeShader: function() {},
_makeShaderWithChildren: function() {},
},
ParagraphStyle: function() {},
RSXFormBuilder: function() {},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
ColorBuilder: function() {},
RectBuilder: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
ShapedText: {
Reland "[canvaskit] Change SkRects to be arrays, not objects." This is a reland of bdc214a50e854fabb62bda126977b63e298dea9f The CPU version of SkottieWasm is timing out for reasons unknown, but the GPU version is happy. I think we can get rid of the CPU version of the job since it has been more or less superseded by the SkottieFrames one (and the latter is more stable). Original change's description: > [canvaskit] Change SkRects to be arrays, not objects. > > This changes several APIs, so there are lots of breaking > notes in the Changelog. > > This made the "draw 100 colored regions" benchmark about > 20% faster (1ms -> .8ms). > > In theory, rendering should stay the same. > > Change-Id: Ib80b15e2d980ad5d568fff4460d2b529766c1b36 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312491 > Reviewed-by: Nathaniel Nifong <nifong@google.com> Change-Id: I674aba85ecfb30b72e94cbaf89b2d97bfae3b7a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315142 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-09-03 14:02:10 +00:00
prototype: {
getBounds: function() {},
},
// private API (from C++ bindings)
_getBounds: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
AnimatedImage: {
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
// public API (from C++ bindings)
decodeNextFrame: function() {},
getFrameCount: function() {},
getRepetitionCount: function() {},
height: function() {},
reset: function() {},
width: function() {},
},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
Canvas: {
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
// public API (from C++ bindings)
clipPath: function() {},
drawCircle: function() {},
[canvaskit] Add flexibility to setColor API Change-Id: Ib0946bb05bc5cbf485a6687e46c7e61312bcd24c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/293344 Reviewed-by: Yegor Jbanov <yjbanov@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-06-02 20:15:23 +00:00
drawColorInt: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
drawImage: function() {},
[canvaskit] Replace drawAnimatedImage with drawFrameAtImage. This allows paint to be used (instead of the less-desirable drawDrawable impl). Bug: skia:10717 Change-Id: Id132e7b2bc189303e866f66d90f389bc29c02fb8 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316840 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-09-15 13:22:36 +00:00
drawImageAtCurrentFrame: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
drawLine: function() {},
drawPaint: function() {},
drawParagraph: function() {},
drawPath: function() {},
drawPicture: function() {},
[canvaskit] Add drawRect4f as example 'fast path' API I added 3 tests, one using the drawRect API naively, one using drawRect with a Malloc'd array, and one using the drawRect4f. rough local measurements: - [baseline with tip of tree code]: 50ms - naive drawRect: 40ms - drawRect with malloc: 28ms - drawRect4f: 27ms I also tried the benchmarks locally with taking in paint as a const reference. I did not see any changes, but that could just be small sample size. I plan to land the code as is for now, collect a bit of data in Perf and then try landing the const reference stuff and see if we get something measurable. To aid this, I added in a helper list of tests to only run some benchmarks easily. Change-Id: I2d8c5296e93f05be45fc12059955fb9d9e339d83 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315143 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-09-03 12:31:52 +00:00
drawRect4f: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
drawText: function() {},
drawTextBlob: function() {},
drawVertices: function() {},
flush: function() {},
getSaveCount: function() {},
makeSurface: function() {},
Add markCTM to canvaskit API, use in 3D cube example Change-Id: Id0eafdf0fd69f080e26e2bee5c7b38eb55b6a5c0 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/287897 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-05-06 20:22:33 +00:00
markCTM: function() {},
findMarkedCTM: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
restore: function() {},
restoreToCount: function() {},
rotate: function() {},
save: function() {},
scale: function() {},
skew: function() {},
translate: function() {},
Pass 4f colors to private functions with float pointers Change-Id: I4534a246c37870750298d39edcbc869781dc1008 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286880 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-05-04 20:46:17 +00:00
prototype: {
clear: function() {},
Reland "[canvaskit] Replace RRect objects with TypedArrays." This reverts commit 370de72763fffaed223f9226c454bd88d2dd1172. Reason for revert: Unrelated to breakage Original change's description: > Revert "[canvaskit] Replace RRect objects with TypedArrays." > > Revert submission 314622 > > Reason for revert: breaking wasm bots > Reverted Changes: > Ia1ba13814:[canvaskit] Replace RRect objects with TypedArrays... > Ib80b15e2d:[canvaskit] Change SkRects to be arrays, not objec... > I790b2d6fc:[canvaskit] Add drawRect4f as example 'fast path' ... > > Change-Id: I3912ffeb446b497e4e03a6260e51cae1e664bd83 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/314894 > Reviewed-by: Michael Ludwig <michaelludwig@google.com> TBR=kjlubick@google.com,michaelludwig@google.com,nifong@google.com # Not skipping CQ checks because this is a reland. Change-Id: I9b1e38fd36f635146b3b518142bbc4626007700f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315141 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-09-03 11:57:12 +00:00
clipRRect: function() {},
Reland "[canvaskit] Change SkRects to be arrays, not objects." This is a reland of bdc214a50e854fabb62bda126977b63e298dea9f The CPU version of SkottieWasm is timing out for reasons unknown, but the GPU version is happy. I think we can get rid of the CPU version of the job since it has been more or less superseded by the SkottieFrames one (and the latter is more stable). Original change's description: > [canvaskit] Change SkRects to be arrays, not objects. > > This changes several APIs, so there are lots of breaking > notes in the Changelog. > > This made the "draw 100 colored regions" benchmark about > 20% faster (1ms -> .8ms). > > In theory, rendering should stay the same. > > Change-Id: Ib80b15e2d980ad5d568fff4460d2b529766c1b36 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312491 > Reviewed-by: Nathaniel Nifong <nifong@google.com> Change-Id: I674aba85ecfb30b72e94cbaf89b2d97bfae3b7a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315142 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-09-03 14:02:10 +00:00
clipRect: function() {},
Reland "[canvaskit] Replace RRect objects with TypedArrays." This reverts commit 370de72763fffaed223f9226c454bd88d2dd1172. Reason for revert: Unrelated to breakage Original change's description: > Revert "[canvaskit] Replace RRect objects with TypedArrays." > > Revert submission 314622 > > Reason for revert: breaking wasm bots > Reverted Changes: > Ia1ba13814:[canvaskit] Replace RRect objects with TypedArrays... > Ib80b15e2d:[canvaskit] Change SkRects to be arrays, not objec... > I790b2d6fc:[canvaskit] Add drawRect4f as example 'fast path' ... > > Change-Id: I3912ffeb446b497e4e03a6260e51cae1e664bd83 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/314894 > Reviewed-by: Michael Ludwig <michaelludwig@google.com> TBR=kjlubick@google.com,michaelludwig@google.com,nifong@google.com # Not skipping CQ checks because this is a reland. Change-Id: I9b1e38fd36f635146b3b518142bbc4626007700f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315141 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-09-03 11:57:12 +00:00
concat44: function() {}, // deprecated
concat: function() {},
Reland "[canvaskit] Change SkRects to be arrays, not objects." This is a reland of bdc214a50e854fabb62bda126977b63e298dea9f The CPU version of SkottieWasm is timing out for reasons unknown, but the GPU version is happy. I think we can get rid of the CPU version of the job since it has been more or less superseded by the SkottieFrames one (and the latter is more stable). Original change's description: > [canvaskit] Change SkRects to be arrays, not objects. > > This changes several APIs, so there are lots of breaking > notes in the Changelog. > > This made the "draw 100 colored regions" benchmark about > 20% faster (1ms -> .8ms). > > In theory, rendering should stay the same. > > Change-Id: Ib80b15e2d980ad5d568fff4460d2b529766c1b36 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312491 > Reviewed-by: Nathaniel Nifong <nifong@google.com> Change-Id: I674aba85ecfb30b72e94cbaf89b2d97bfae3b7a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315142 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-09-03 14:02:10 +00:00
drawArc: function() {},
Reland "[canvaskit] Replace RRect objects with TypedArrays." This reverts commit 370de72763fffaed223f9226c454bd88d2dd1172. Reason for revert: Unrelated to breakage Original change's description: > Revert "[canvaskit] Replace RRect objects with TypedArrays." > > Revert submission 314622 > > Reason for revert: breaking wasm bots > Reverted Changes: > Ia1ba13814:[canvaskit] Replace RRect objects with TypedArrays... > Ib80b15e2d:[canvaskit] Change SkRects to be arrays, not objec... > I790b2d6fc:[canvaskit] Add drawRect4f as example 'fast path' ... > > Change-Id: I3912ffeb446b497e4e03a6260e51cae1e664bd83 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/314894 > Reviewed-by: Michael Ludwig <michaelludwig@google.com> TBR=kjlubick@google.com,michaelludwig@google.com,nifong@google.com # Not skipping CQ checks because this is a reland. Change-Id: I9b1e38fd36f635146b3b518142bbc4626007700f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315141 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-09-03 11:57:12 +00:00
drawAtlas: function() {},
Pass 4f colors to private functions with float pointers Change-Id: I4534a246c37870750298d39edcbc869781dc1008 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286880 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-05-04 20:46:17 +00:00
drawColor: function() {},
[canvaskit] Add flexibility to setColor API Change-Id: Ib0946bb05bc5cbf485a6687e46c7e61312bcd24c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/293344 Reviewed-by: Yegor Jbanov <yjbanov@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-06-02 20:15:23 +00:00
drawColorComponents: function() {},
Reland "[canvaskit] Replace RRect objects with TypedArrays." This reverts commit 370de72763fffaed223f9226c454bd88d2dd1172. Reason for revert: Unrelated to breakage Original change's description: > Revert "[canvaskit] Replace RRect objects with TypedArrays." > > Revert submission 314622 > > Reason for revert: breaking wasm bots > Reverted Changes: > Ia1ba13814:[canvaskit] Replace RRect objects with TypedArrays... > Ib80b15e2d:[canvaskit] Change SkRects to be arrays, not objec... > I790b2d6fc:[canvaskit] Add drawRect4f as example 'fast path' ... > > Change-Id: I3912ffeb446b497e4e03a6260e51cae1e664bd83 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/314894 > Reviewed-by: Michael Ludwig <michaelludwig@google.com> TBR=kjlubick@google.com,michaelludwig@google.com,nifong@google.com # Not skipping CQ checks because this is a reland. Change-Id: I9b1e38fd36f635146b3b518142bbc4626007700f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315141 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-09-03 11:57:12 +00:00
drawDRRect: function() {},
Reland "[canvaskit] Change SkRects to be arrays, not objects." This is a reland of bdc214a50e854fabb62bda126977b63e298dea9f The CPU version of SkottieWasm is timing out for reasons unknown, but the GPU version is happy. I think we can get rid of the CPU version of the job since it has been more or less superseded by the SkottieFrames one (and the latter is more stable). Original change's description: > [canvaskit] Change SkRects to be arrays, not objects. > > This changes several APIs, so there are lots of breaking > notes in the Changelog. > > This made the "draw 100 colored regions" benchmark about > 20% faster (1ms -> .8ms). > > In theory, rendering should stay the same. > > Change-Id: Ib80b15e2d980ad5d568fff4460d2b529766c1b36 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312491 > Reviewed-by: Nathaniel Nifong <nifong@google.com> Change-Id: I674aba85ecfb30b72e94cbaf89b2d97bfae3b7a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315142 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-09-03 14:02:10 +00:00
drawImageNine: function() {},
drawImageRect: function() {},
drawOval: function() {},
Reland "[canvaskit] Replace RRect objects with TypedArrays." This reverts commit 370de72763fffaed223f9226c454bd88d2dd1172. Reason for revert: Unrelated to breakage Original change's description: > Revert "[canvaskit] Replace RRect objects with TypedArrays." > > Revert submission 314622 > > Reason for revert: breaking wasm bots > Reverted Changes: > Ia1ba13814:[canvaskit] Replace RRect objects with TypedArrays... > Ib80b15e2d:[canvaskit] Change SkRects to be arrays, not objec... > I790b2d6fc:[canvaskit] Add drawRect4f as example 'fast path' ... > > Change-Id: I3912ffeb446b497e4e03a6260e51cae1e664bd83 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/314894 > Reviewed-by: Michael Ludwig <michaelludwig@google.com> TBR=kjlubick@google.com,michaelludwig@google.com,nifong@google.com # Not skipping CQ checks because this is a reland. Change-Id: I9b1e38fd36f635146b3b518142bbc4626007700f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315141 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-09-03 11:57:12 +00:00
drawPoints: function() {},
Reland "[canvaskit] Change SkRects to be arrays, not objects." This is a reland of bdc214a50e854fabb62bda126977b63e298dea9f The CPU version of SkottieWasm is timing out for reasons unknown, but the GPU version is happy. I think we can get rid of the CPU version of the job since it has been more or less superseded by the SkottieFrames one (and the latter is more stable). Original change's description: > [canvaskit] Change SkRects to be arrays, not objects. > > This changes several APIs, so there are lots of breaking > notes in the Changelog. > > This made the "draw 100 colored regions" benchmark about > 20% faster (1ms -> .8ms). > > In theory, rendering should stay the same. > > Change-Id: Ib80b15e2d980ad5d568fff4460d2b529766c1b36 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312491 > Reviewed-by: Nathaniel Nifong <nifong@google.com> Change-Id: I674aba85ecfb30b72e94cbaf89b2d97bfae3b7a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315142 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-09-03 14:02:10 +00:00
drawRect: function() {},
Reland "[canvaskit] Replace RRect objects with TypedArrays." This reverts commit 370de72763fffaed223f9226c454bd88d2dd1172. Reason for revert: Unrelated to breakage Original change's description: > Revert "[canvaskit] Replace RRect objects with TypedArrays." > > Revert submission 314622 > > Reason for revert: breaking wasm bots > Reverted Changes: > Ia1ba13814:[canvaskit] Replace RRect objects with TypedArrays... > Ib80b15e2d:[canvaskit] Change SkRects to be arrays, not objec... > I790b2d6fc:[canvaskit] Add drawRect4f as example 'fast path' ... > > Change-Id: I3912ffeb446b497e4e03a6260e51cae1e664bd83 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/314894 > Reviewed-by: Michael Ludwig <michaelludwig@google.com> TBR=kjlubick@google.com,michaelludwig@google.com,nifong@google.com # Not skipping CQ checks because this is a reland. Change-Id: I9b1e38fd36f635146b3b518142bbc4626007700f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315141 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-09-03 11:57:12 +00:00
drawRRect: function() {},
Pass 4f colors to private functions with float pointers Change-Id: I4534a246c37870750298d39edcbc869781dc1008 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286880 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-05-04 20:46:17 +00:00
drawShadow: function() {},
Reland "[canvaskit] Replace RRect objects with TypedArrays." This reverts commit 370de72763fffaed223f9226c454bd88d2dd1172. Reason for revert: Unrelated to breakage Original change's description: > Revert "[canvaskit] Replace RRect objects with TypedArrays." > > Revert submission 314622 > > Reason for revert: breaking wasm bots > Reverted Changes: > Ia1ba13814:[canvaskit] Replace RRect objects with TypedArrays... > Ib80b15e2d:[canvaskit] Change SkRects to be arrays, not objec... > I790b2d6fc:[canvaskit] Add drawRect4f as example 'fast path' ... > > Change-Id: I3912ffeb446b497e4e03a6260e51cae1e664bd83 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/314894 > Reviewed-by: Michael Ludwig <michaelludwig@google.com> TBR=kjlubick@google.com,michaelludwig@google.com,nifong@google.com # Not skipping CQ checks because this is a reland. Change-Id: I9b1e38fd36f635146b3b518142bbc4626007700f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315141 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-09-03 11:57:12 +00:00
drawText: function() {},
findMarkedCTM: function() {},
getLocalToDevice: function() {},
getTotalMatrix: function() {},
readPixels: function() {},
Reland "[canvaskit] Change SkRects to be arrays, not objects." This is a reland of bdc214a50e854fabb62bda126977b63e298dea9f The CPU version of SkottieWasm is timing out for reasons unknown, but the GPU version is happy. I think we can get rid of the CPU version of the job since it has been more or less superseded by the SkottieFrames one (and the latter is more stable). Original change's description: > [canvaskit] Change SkRects to be arrays, not objects. > > This changes several APIs, so there are lots of breaking > notes in the Changelog. > > This made the "draw 100 colored regions" benchmark about > 20% faster (1ms -> .8ms). > > In theory, rendering should stay the same. > > Change-Id: Ib80b15e2d980ad5d568fff4460d2b529766c1b36 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312491 > Reviewed-by: Nathaniel Nifong <nifong@google.com> Change-Id: I674aba85ecfb30b72e94cbaf89b2d97bfae3b7a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315142 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-09-03 14:02:10 +00:00
saveLayer: function() {},
Reland "[canvaskit] Replace RRect objects with TypedArrays." This reverts commit 370de72763fffaed223f9226c454bd88d2dd1172. Reason for revert: Unrelated to breakage Original change's description: > Revert "[canvaskit] Replace RRect objects with TypedArrays." > > Revert submission 314622 > > Reason for revert: breaking wasm bots > Reverted Changes: > Ia1ba13814:[canvaskit] Replace RRect objects with TypedArrays... > Ib80b15e2d:[canvaskit] Change SkRects to be arrays, not objec... > I790b2d6fc:[canvaskit] Add drawRect4f as example 'fast path' ... > > Change-Id: I3912ffeb446b497e4e03a6260e51cae1e664bd83 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/314894 > Reviewed-by: Michael Ludwig <michaelludwig@google.com> TBR=kjlubick@google.com,michaelludwig@google.com,nifong@google.com # Not skipping CQ checks because this is a reland. Change-Id: I9b1e38fd36f635146b3b518142bbc4626007700f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315141 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-09-03 11:57:12 +00:00
writePixels : function() {},
Pass 4f colors to private functions with float pointers Change-Id: I4534a246c37870750298d39edcbc869781dc1008 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286880 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-05-04 20:46:17 +00:00
},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
// private API
Pass 4f colors to private functions with float pointers Change-Id: I4534a246c37870750298d39edcbc869781dc1008 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286880 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-05-04 20:46:17 +00:00
_clear: function() {},
Reland "[canvaskit] Replace RRect objects with TypedArrays." This reverts commit 370de72763fffaed223f9226c454bd88d2dd1172. Reason for revert: Unrelated to breakage Original change's description: > Revert "[canvaskit] Replace RRect objects with TypedArrays." > > Revert submission 314622 > > Reason for revert: breaking wasm bots > Reverted Changes: > Ia1ba13814:[canvaskit] Replace RRect objects with TypedArrays... > Ib80b15e2d:[canvaskit] Change SkRects to be arrays, not objec... > I790b2d6fc:[canvaskit] Add drawRect4f as example 'fast path' ... > > Change-Id: I3912ffeb446b497e4e03a6260e51cae1e664bd83 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/314894 > Reviewed-by: Michael Ludwig <michaelludwig@google.com> TBR=kjlubick@google.com,michaelludwig@google.com,nifong@google.com # Not skipping CQ checks because this is a reland. Change-Id: I9b1e38fd36f635146b3b518142bbc4626007700f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315141 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-09-03 11:57:12 +00:00
_clipRRect: function() {},
Reland "[canvaskit] Change SkRects to be arrays, not objects." This is a reland of bdc214a50e854fabb62bda126977b63e298dea9f The CPU version of SkottieWasm is timing out for reasons unknown, but the GPU version is happy. I think we can get rid of the CPU version of the job since it has been more or less superseded by the SkottieFrames one (and the latter is more stable). Original change's description: > [canvaskit] Change SkRects to be arrays, not objects. > > This changes several APIs, so there are lots of breaking > notes in the Changelog. > > This made the "draw 100 colored regions" benchmark about > 20% faster (1ms -> .8ms). > > In theory, rendering should stay the same. > > Change-Id: Ib80b15e2d980ad5d568fff4460d2b529766c1b36 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312491 > Reviewed-by: Nathaniel Nifong <nifong@google.com> Change-Id: I674aba85ecfb30b72e94cbaf89b2d97bfae3b7a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315142 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-09-03 14:02:10 +00:00
_clipRect: function() {},
[canvaskit] Handle passing matrix values into CK ourselves. This means we take DOMMatrix everywhere now. This reduced the *_makeShader benchmark by ~25% (4 us -> 3 us) and cleaned up several callsites. Trimming this down saves ~3kb in uncompressed code size. Change-Id: Ie677c7ebb7bc97ed8cd4d4851a039b78b6f8079d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281018 Reviewed-by: Mike Reed <reed@google.com>
2020-04-02 19:24:15 +00:00
_concat: function() {},
Reland "[canvaskit] Change SkRects to be arrays, not objects." This is a reland of bdc214a50e854fabb62bda126977b63e298dea9f The CPU version of SkottieWasm is timing out for reasons unknown, but the GPU version is happy. I think we can get rid of the CPU version of the job since it has been more or less superseded by the SkottieFrames one (and the latter is more stable). Original change's description: > [canvaskit] Change SkRects to be arrays, not objects. > > This changes several APIs, so there are lots of breaking > notes in the Changelog. > > This made the "draw 100 colored regions" benchmark about > 20% faster (1ms -> .8ms). > > In theory, rendering should stay the same. > > Change-Id: Ib80b15e2d980ad5d568fff4460d2b529766c1b36 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312491 > Reviewed-by: Nathaniel Nifong <nifong@google.com> Change-Id: I674aba85ecfb30b72e94cbaf89b2d97bfae3b7a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315142 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-09-03 14:02:10 +00:00
_drawArc: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
_drawAtlas: function() {},
Pass 4f colors to private functions with float pointers Change-Id: I4534a246c37870750298d39edcbc869781dc1008 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286880 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-05-04 20:46:17 +00:00
_drawColor: function() {},
Reland "[canvaskit] Replace RRect objects with TypedArrays." This reverts commit 370de72763fffaed223f9226c454bd88d2dd1172. Reason for revert: Unrelated to breakage Original change's description: > Revert "[canvaskit] Replace RRect objects with TypedArrays." > > Revert submission 314622 > > Reason for revert: breaking wasm bots > Reverted Changes: > Ia1ba13814:[canvaskit] Replace RRect objects with TypedArrays... > Ib80b15e2d:[canvaskit] Change SkRects to be arrays, not objec... > I790b2d6fc:[canvaskit] Add drawRect4f as example 'fast path' ... > > Change-Id: I3912ffeb446b497e4e03a6260e51cae1e664bd83 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/314894 > Reviewed-by: Michael Ludwig <michaelludwig@google.com> TBR=kjlubick@google.com,michaelludwig@google.com,nifong@google.com # Not skipping CQ checks because this is a reland. Change-Id: I9b1e38fd36f635146b3b518142bbc4626007700f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315141 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-09-03 11:57:12 +00:00
_drawDRRect: function() {},
Reland "[canvaskit] Change SkRects to be arrays, not objects." This is a reland of bdc214a50e854fabb62bda126977b63e298dea9f The CPU version of SkottieWasm is timing out for reasons unknown, but the GPU version is happy. I think we can get rid of the CPU version of the job since it has been more or less superseded by the SkottieFrames one (and the latter is more stable). Original change's description: > [canvaskit] Change SkRects to be arrays, not objects. > > This changes several APIs, so there are lots of breaking > notes in the Changelog. > > This made the "draw 100 colored regions" benchmark about > 20% faster (1ms -> .8ms). > > In theory, rendering should stay the same. > > Change-Id: Ib80b15e2d980ad5d568fff4460d2b529766c1b36 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312491 > Reviewed-by: Nathaniel Nifong <nifong@google.com> Change-Id: I674aba85ecfb30b72e94cbaf89b2d97bfae3b7a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315142 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-09-03 14:02:10 +00:00
_drawImageNine: function() {},
_drawImageRect: function() {},
_drawOval: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
_drawPoints: function() {},
Reland "[canvaskit] Change SkRects to be arrays, not objects." This is a reland of bdc214a50e854fabb62bda126977b63e298dea9f The CPU version of SkottieWasm is timing out for reasons unknown, but the GPU version is happy. I think we can get rid of the CPU version of the job since it has been more or less superseded by the SkottieFrames one (and the latter is more stable). Original change's description: > [canvaskit] Change SkRects to be arrays, not objects. > > This changes several APIs, so there are lots of breaking > notes in the Changelog. > > This made the "draw 100 colored regions" benchmark about > 20% faster (1ms -> .8ms). > > In theory, rendering should stay the same. > > Change-Id: Ib80b15e2d980ad5d568fff4460d2b529766c1b36 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312491 > Reviewed-by: Nathaniel Nifong <nifong@google.com> Change-Id: I674aba85ecfb30b72e94cbaf89b2d97bfae3b7a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315142 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-09-03 14:02:10 +00:00
_drawRect: function() {},
Reland "[canvaskit] Replace RRect objects with TypedArrays." This reverts commit 370de72763fffaed223f9226c454bd88d2dd1172. Reason for revert: Unrelated to breakage Original change's description: > Revert "[canvaskit] Replace RRect objects with TypedArrays." > > Revert submission 314622 > > Reason for revert: breaking wasm bots > Reverted Changes: > Ia1ba13814:[canvaskit] Replace RRect objects with TypedArrays... > Ib80b15e2d:[canvaskit] Change SkRects to be arrays, not objec... > I790b2d6fc:[canvaskit] Add drawRect4f as example 'fast path' ... > > Change-Id: I3912ffeb446b497e4e03a6260e51cae1e664bd83 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/314894 > Reviewed-by: Michael Ludwig <michaelludwig@google.com> TBR=kjlubick@google.com,michaelludwig@google.com,nifong@google.com # Not skipping CQ checks because this is a reland. Change-Id: I9b1e38fd36f635146b3b518142bbc4626007700f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315141 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-09-03 11:57:12 +00:00
_drawRRect: function() {},
Pass 4f colors to private functions with float pointers Change-Id: I4534a246c37870750298d39edcbc869781dc1008 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286880 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-05-04 20:46:17 +00:00
_drawShadow: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
_drawSimpleText: function() {},
Reland "[canvaskit] Replace RRect objects with TypedArrays." This reverts commit 370de72763fffaed223f9226c454bd88d2dd1172. Reason for revert: Unrelated to breakage Original change's description: > Revert "[canvaskit] Replace RRect objects with TypedArrays." > > Revert submission 314622 > > Reason for revert: breaking wasm bots > Reverted Changes: > Ia1ba13814:[canvaskit] Replace RRect objects with TypedArrays... > Ib80b15e2d:[canvaskit] Change SkRects to be arrays, not objec... > I790b2d6fc:[canvaskit] Add drawRect4f as example 'fast path' ... > > Change-Id: I3912ffeb446b497e4e03a6260e51cae1e664bd83 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/314894 > Reviewed-by: Michael Ludwig <michaelludwig@google.com> TBR=kjlubick@google.com,michaelludwig@google.com,nifong@google.com # Not skipping CQ checks because this is a reland. Change-Id: I9b1e38fd36f635146b3b518142bbc4626007700f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315141 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-09-03 11:57:12 +00:00
_findMarkedCTM: function() {},
[canvaskit] Handle 4x4 matrix passing ourselves. This reduces the skm44_concat benchmark from 2us to .35us, a 5x speedup. SkCanvas.concat now takes a 3x2, 3x3, or 4x4 matrix and upscales them all to 4x4. This makes concat44 redundant. Removes redundant null checks for matrices, since freeing(0) in WASM is fine like it is in C++. Change-Id: I44a776ffd0babb81d8a34f9d94ae4d7831d02b55 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281721 Reviewed-by: Mike Reed <reed@google.com>
2020-04-06 17:52:15 +00:00
_getLocalToDevice: function() {},
[canvaskit] Handle passing matrix values into CK ourselves. This means we take DOMMatrix everywhere now. This reduced the *_makeShader benchmark by ~25% (4 us -> 3 us) and cleaned up several callsites. Trimming this down saves ~3kb in uncompressed code size. Change-Id: Ie677c7ebb7bc97ed8cd4d4851a039b78b6f8079d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281018 Reviewed-by: Mike Reed <reed@google.com>
2020-04-02 19:24:15 +00:00
_getTotalMatrix: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
_readPixels: function() {},
Reland "[canvaskit] Change SkRects to be arrays, not objects." This is a reland of bdc214a50e854fabb62bda126977b63e298dea9f The CPU version of SkottieWasm is timing out for reasons unknown, but the GPU version is happy. I think we can get rid of the CPU version of the job since it has been more or less superseded by the SkottieFrames one (and the latter is more stable). Original change's description: > [canvaskit] Change SkRects to be arrays, not objects. > > This changes several APIs, so there are lots of breaking > notes in the Changelog. > > This made the "draw 100 colored regions" benchmark about > 20% faster (1ms -> .8ms). > > In theory, rendering should stay the same. > > Change-Id: Ib80b15e2d980ad5d568fff4460d2b529766c1b36 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312491 > Reviewed-by: Nathaniel Nifong <nifong@google.com> Change-Id: I674aba85ecfb30b72e94cbaf89b2d97bfae3b7a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315142 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-09-03 14:02:10 +00:00
_saveLayer: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
_writePixels: function() {},
delete: function() {},
},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
ColorFilter: {
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
// public API (from C++ bindings and JS interface)
MakeBlend: function() {},
MakeCompose: function() {},
MakeLerp: function() {},
MakeLinearToSRGBGamma: function() {},
MakeMatrix: function() {},
MakeSRGBToLinearGamma: function() {},
// private API (from C++ bindings)
Pass 4f colors to private functions with float pointers Change-Id: I4534a246c37870750298d39edcbc869781dc1008 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286880 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-05-04 20:46:17 +00:00
_MakeBlend: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
_makeMatrix: function() {},
},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
ColorMatrix: {
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
concat: function() {},
identity: function() {},
postTranslate: function() {},
rotated: function() {},
scaled: function() {},
},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
ColorSpace: {
Wide color gamut support and working example. Fixes release-cpu build issue, un-revert cl 289733 Color space arguments accepted at surface creation, paint, gradient, and other call sites. Works correctly only when chrome happens to be rendering itself in the same color space the canvaskit user has chosen, there's not yet end to end color management of canvases supported in browsers. readPixels not yet working due to possible chrome bug. Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289733 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Change-Id: I65ce1c643dac57e14b8476f598c96b12b7e040ce Reviewed-on: https://skia-review.googlesource.com/c/skia/+/291896
2020-05-26 17:10:20 +00:00
Equals: function() {},
SRGB: {},
DISPLAY_P3: {},
ADOBE_RGB: {},
// private API (from C++ bindings)
_MakeSRGB: function() {},
_MakeDisplayP3: function() {},
_MakeAdobeRGB: function() {},
},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
ContourMeasureIter: {
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
next: function() {},
},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
ContourMeasure: {
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
getPosTan: function() {},
getSegment: function() {},
isClosed: function() {},
length: function() {},
},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
Font: {
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
// public API (from C++ bindings)
getScaleX: function() {},
getSize: function() {},
getSkewX: function() {},
getTypeface: function() {},
measureText: function() {},
setHinting: function() {},
setLinearMetrics: function() {},
setScaleX: function() {},
setSize: function() {},
setSkewX: function() {},
setSubpixel: function() {},
setTypeface: function() {},
[canvaskit] Expose Glyph ID APIs Note: I intend to make shaping.html live in demos.skia.org, but that is hard to verify it works until the APIs land. Change-Id: I3af1cf8ded316f616d05ee60198393ed9c9a284f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/319130 Reviewed-by: Nathaniel Nifong <nifong@google.com> Reviewed-by: Mike Reed <reed@google.com>
2020-09-25 14:52:16 +00:00
prototype: {
getGlyphBounds: function() {},
getGlyphIDs: function() {},
getGlyphWidths: function() {},
getWidths: function() {},
},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
// private API (from C++ bindings)
[canvaskit] Expose Glyph ID APIs Note: I intend to make shaping.html live in demos.skia.org, but that is hard to verify it works until the APIs land. Change-Id: I3af1cf8ded316f616d05ee60198393ed9c9a284f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/319130 Reviewed-by: Nathaniel Nifong <nifong@google.com> Reviewed-by: Mike Reed <reed@google.com>
2020-09-25 14:52:16 +00:00
_getGlyphIDs: function() {},
_getGlyphWidthBounds: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
_getWidths: function() {},
},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
FontMgr: {
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
// public API (from C++ and JS bindings)
FromData: function() {},
RefDefault: function() {},
countFamilies: function() {},
getFamilyName: function() {},
// private API
_makeTypefaceFromData: function() {},
_fromData: function() {},
},
[CanvasKit] Expose TypefaceFontProvider. Change-Id: I950a3a4f45b7b4a106299576bc918531054b23f6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/307873 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-08-04 20:21:09 +00:00
TypefaceFontProvider: {
// public API (from C++ and JS bindings)
Make: function() {},
registerFont: function() {},
// private API
_registerFont: function() {},
},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
Image: {
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
// public API (from C++ bindings)
height: function() {},
width: function() {},
// private API
_encodeToData: function() {},
_encodeToDataWithFormat: function() {},
_makeShader: function() {},
},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
ImageFilter: {
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
MakeBlur: function() {},
MakeColorFilter: function() {},
MakeCompose: function() {},
MakeMatrixTransform: function() {},
[canvaskit] Handle passing matrix values into CK ourselves. This means we take DOMMatrix everywhere now. This reduced the *_makeShader benchmark by ~25% (4 us -> 3 us) and cleaned up several callsites. Trimming this down saves ~3kb in uncompressed code size. Change-Id: Ie677c7ebb7bc97ed8cd4d4851a039b78b6f8079d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281018 Reviewed-by: Mike Reed <reed@google.com>
2020-04-02 19:24:15 +00:00
// private API
_MakeMatrixTransform: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
},
// These are defined in interface.js
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
M44: {
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
identity: function() {},
invert: function() {},
Helper function for camera setup Change-Id: I839fea29c2e56cfc2a4e4557da3197bf211513eb Reviewed-on: https://skia-review.googlesource.com/c/skia/+/299654 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-07-06 23:50:13 +00:00
mustInvert: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
multiply: function() {},
rotatedUnitSinCos: function() {},
rotated: function() {},
scaled: function() {},
translated: function() {},
lookat: function() {},
perspective: function() {},
rc: function() {},
transpose: function() {},
Helper function for camera setup Change-Id: I839fea29c2e56cfc2a4e4557da3197bf211513eb Reviewed-on: https://skia-review.googlesource.com/c/skia/+/299654 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-07-06 23:50:13 +00:00
setupCamera: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
Matrix: {
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
identity: function() {},
invert: function() {},
mapPoints: function() {},
multiply: function() {},
rotated: function() {},
scaled: function() {},
skewed: function() {},
translated: function() {},
},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
MaskFilter: {
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
MakeBlur: function() {},
},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
Paint: {
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
// public API (from C++ bindings)
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
/** @return {CanvasKit.Paint} */
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
copy: function() {},
getBlendMode: function() {},
getColor: function() {},
getFilterQuality: function() {},
getStrokeCap: function() {},
getStrokeJoin: function() {},
getStrokeMiter: function() {},
getStrokeWidth: function() {},
setAntiAlias: function() {},
setBlendMode: function() {},
[canvaskit] Add flexibility to setColor API Change-Id: Ib0946bb05bc5cbf485a6687e46c7e61312bcd24c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/293344 Reviewed-by: Yegor Jbanov <yjbanov@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-06-02 20:15:23 +00:00
setColorInt: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
setFilterQuality: function() {},
setImageFilter: function() {},
setMaskFilter: function() {},
setPathEffect: function() {},
setShader: function() {},
setStrokeCap: function() {},
setStrokeJoin: function() {},
setStrokeMiter: function() {},
setStrokeWidth: function() {},
setStyle: function() {},
Pass 4f colors to private functions with float pointers Change-Id: I4534a246c37870750298d39edcbc869781dc1008 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286880 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-05-04 20:46:17 +00:00
prototype: {
setColor: function() {},
[canvaskit] Add flexibility to setColor API Change-Id: Ib0946bb05bc5cbf485a6687e46c7e61312bcd24c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/293344 Reviewed-by: Yegor Jbanov <yjbanov@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-06-02 20:15:23 +00:00
setColorComponents: function() {},
setColorInt: function() {},
Pass 4f colors to private functions with float pointers Change-Id: I4534a246c37870750298d39edcbc869781dc1008 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286880 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-05-04 20:46:17 +00:00
},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
// Private API
delete: function() {},
Pass 4f colors to private functions with float pointers Change-Id: I4534a246c37870750298d39edcbc869781dc1008 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286880 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-05-04 20:46:17 +00:00
_getColor: function() {},
_setColor: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
PathEffect: {
[canvaskit] Add tests for patheffects Also move around internal Dash PathEffect api. Change-Id: I445626462f4e76523474b027555da45a58d54632 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/277599 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-03-18 13:53:55 +00:00
MakeCorner: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
MakeDash: function() {},
[canvaskit] Add tests for patheffects Also move around internal Dash PathEffect api. Change-Id: I445626462f4e76523474b027555da45a58d54632 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/277599 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-03-18 13:53:55 +00:00
MakeDiscrete: function() {},
// Private C++ API
_MakeDash: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
ParticleEffect: {
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
// public API (from C++ bindings)
draw: function() {},
getEffectUniform: function() {},
getEffectUniformCount: function() {},
getEffectUniformFloatCount: function() {},
getEffectUniformName: function() {},
getParticleUniformCount: function() {},
getParticleUniformFloatCount: function() {},
getParticleUniformName: function() {},
getParticleUniform: function() {},
setPosition: function() {},
setRate: function() {},
start: function() {},
update: function() {},
// private API (from C++ bindings)
_effectUniformPtr: function() {},
_particleUniformPtr: function() {},
},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
Path: {
[canvaskit] High performance Path APIs https://skia-review.googlesource.com/c/skia/+/297896 draws several paths with over 1000 points (one has ~250k) and was pretty slow. We already had a way to provide a flat(ish) array of all the verbs, points and weights mushed together (although that should be cleaned up to prefer taking a 1d array). This adds an additional way to provide multiple verbs, points, (and optionally weights, if conics are used) to CanvasKit. This makes things dramatically faster because of batch copying the values between JS and WASM (or using Malloc). Additionally, the above CL revealed a need to be able to use a subsection of a Malloc'd array efficiently. Thus, I added subarray as a method of the Malloc object, which can be used effectively as a pointer (i.e. no copying). Change-Id: I2c1d26b25118fb9949e878b1b519d93efcfa5019 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/297841 Reviewed-by: Nathaniel Nifong <nifong@google.com> Reviewed-by: Chris Dalton <csmartdalton@google.com>
2020-06-23 20:58:10 +00:00
// public API (from C++ and JS bindings)
MakeFromCmds: function() {},
MakeFromVerbsPointsWeights: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
contains: function() {},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
/** @return {CanvasKit.Path} */
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
copy: function() {},
countPoints: function() {},
equals: function() {},
getBounds: function() {},
getFillType: function() {},
getPoint: function() {},
isEmpty: function() {},
isVolatile: function() {},
reset: function() {},
rewind: function() {},
setFillType: function() {},
setIsVolatile: function() {},
[canvaskit] High performance Path APIs https://skia-review.googlesource.com/c/skia/+/297896 draws several paths with over 1000 points (one has ~250k) and was pretty slow. We already had a way to provide a flat(ish) array of all the verbs, points and weights mushed together (although that should be cleaned up to prefer taking a 1d array). This adds an additional way to provide multiple verbs, points, (and optionally weights, if conics are used) to CanvasKit. This makes things dramatically faster because of batch copying the values between JS and WASM (or using Malloc). Additionally, the above CL revealed a need to be able to use a subsection of a Malloc'd array efficiently. Thus, I added subarray as a method of the Malloc object, which can be used effectively as a pointer (i.e. no copying). Change-Id: I2c1d26b25118fb9949e878b1b519d93efcfa5019 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/297841 Reviewed-by: Nathaniel Nifong <nifong@google.com> Reviewed-by: Chris Dalton <csmartdalton@google.com>
2020-06-23 20:58:10 +00:00
toCmds: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
toSVGString: function() {},
Reland "[canvaskit] Change SkRects to be arrays, not objects." This is a reland of bdc214a50e854fabb62bda126977b63e298dea9f The CPU version of SkottieWasm is timing out for reasons unknown, but the GPU version is happy. I think we can get rid of the CPU version of the job since it has been more or less superseded by the SkottieFrames one (and the latter is more stable). Original change's description: > [canvaskit] Change SkRects to be arrays, not objects. > > This changes several APIs, so there are lots of breaking > notes in the Changelog. > > This made the "draw 100 colored regions" benchmark about > 20% faster (1ms -> .8ms). > > In theory, rendering should stay the same. > > Change-Id: Ib80b15e2d980ad5d568fff4460d2b529766c1b36 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312491 > Reviewed-by: Nathaniel Nifong <nifong@google.com> Change-Id: I674aba85ecfb30b72e94cbaf89b2d97bfae3b7a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315142 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-09-03 14:02:10 +00:00
prototype: {
addArc: function() {},
addOval: function() {},
addPath: function() {},
addPoly: function() {},
addRect: function() {},
addRRect: function() {},
addVerbsPointsWeights: function() {},
arc: function() {},
arcToOval: function() {},
arcToRotated: function() {},
arcToTangent: function() {},
close: function() {},
conicTo: function() {},
[canvaskit] Fix computeTightBounds I noticed it was broken and untested when writing docs. Change-Id: I5254b7bd50fde8a361c72ccbd7380809d31ccc08 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/321464 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-01 14:55:16 +00:00
computeTightBounds: function() {},
Reland "[canvaskit] Change SkRects to be arrays, not objects." This is a reland of bdc214a50e854fabb62bda126977b63e298dea9f The CPU version of SkottieWasm is timing out for reasons unknown, but the GPU version is happy. I think we can get rid of the CPU version of the job since it has been more or less superseded by the SkottieFrames one (and the latter is more stable). Original change's description: > [canvaskit] Change SkRects to be arrays, not objects. > > This changes several APIs, so there are lots of breaking > notes in the Changelog. > > This made the "draw 100 colored regions" benchmark about > 20% faster (1ms -> .8ms). > > In theory, rendering should stay the same. > > Change-Id: Ib80b15e2d980ad5d568fff4460d2b529766c1b36 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312491 > Reviewed-by: Nathaniel Nifong <nifong@google.com> Change-Id: I674aba85ecfb30b72e94cbaf89b2d97bfae3b7a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315142 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-09-03 14:02:10 +00:00
cubicTo: function() {},
dash: function() {},
lineTo: function() {},
moveTo: function() {},
offset: function() {},
op: function() {},
quadTo: function() {},
rArcTo: function() {},
rConicTo: function() {},
rCubicTo: function() {},
rect: function() {},
rLineTo: function() {},
rMoveTo: function() {},
rQuadTo: function() {},
simplify: function() {},
stroke: function() {},
transform: function() {},
trim: function() {},
},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
// private API
[canvaskit] High performance Path APIs https://skia-review.googlesource.com/c/skia/+/297896 draws several paths with over 1000 points (one has ~250k) and was pretty slow. We already had a way to provide a flat(ish) array of all the verbs, points and weights mushed together (although that should be cleaned up to prefer taking a 1d array). This adds an additional way to provide multiple verbs, points, (and optionally weights, if conics are used) to CanvasKit. This makes things dramatically faster because of batch copying the values between JS and WASM (or using Malloc). Additionally, the above CL revealed a need to be able to use a subsection of a Malloc'd array efficiently. Thus, I added subarray as a method of the Malloc object, which can be used effectively as a pointer (i.e. no copying). Change-Id: I2c1d26b25118fb9949e878b1b519d93efcfa5019 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/297841 Reviewed-by: Nathaniel Nifong <nifong@google.com> Reviewed-by: Chris Dalton <csmartdalton@google.com>
2020-06-23 20:58:10 +00:00
_MakeFromCmds: function() {},
_MakeFromVerbsPointsWeights: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
_addArc: function() {},
_addOval: function() {},
_addPath: function() {},
Revert "[canvaskit] Change SkRects to be arrays, not objects." Revert submission 314622 Reason for revert: breaking wasm bots Reverted Changes: Ia1ba13814:[canvaskit] Replace RRect objects with TypedArrays... Ib80b15e2d:[canvaskit] Change SkRects to be arrays, not objec... I790b2d6fc:[canvaskit] Add drawRect4f as example 'fast path' ... Change-Id: Ie6e4c57ba412ca9ff8e4446b06681b51029da2d6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/314893 Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2020-09-02 21:20:44 +00:00
_addPoly: function() {},
Reland "[canvaskit] Change SkRects to be arrays, not objects." This is a reland of bdc214a50e854fabb62bda126977b63e298dea9f The CPU version of SkottieWasm is timing out for reasons unknown, but the GPU version is happy. I think we can get rid of the CPU version of the job since it has been more or less superseded by the SkottieFrames one (and the latter is more stable). Original change's description: > [canvaskit] Change SkRects to be arrays, not objects. > > This changes several APIs, so there are lots of breaking > notes in the Changelog. > > This made the "draw 100 colored regions" benchmark about > 20% faster (1ms -> .8ms). > > In theory, rendering should stay the same. > > Change-Id: Ib80b15e2d980ad5d568fff4460d2b529766c1b36 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312491 > Reviewed-by: Nathaniel Nifong <nifong@google.com> Change-Id: I674aba85ecfb30b72e94cbaf89b2d97bfae3b7a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315142 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-09-03 14:02:10 +00:00
_addRect: function() {},
_addRRect: function() {},
[canvaskit] High performance Path APIs https://skia-review.googlesource.com/c/skia/+/297896 draws several paths with over 1000 points (one has ~250k) and was pretty slow. We already had a way to provide a flat(ish) array of all the verbs, points and weights mushed together (although that should be cleaned up to prefer taking a 1d array). This adds an additional way to provide multiple verbs, points, (and optionally weights, if conics are used) to CanvasKit. This makes things dramatically faster because of batch copying the values between JS and WASM (or using Malloc). Additionally, the above CL revealed a need to be able to use a subsection of a Malloc'd array efficiently. Thus, I added subarray as a method of the Malloc object, which can be used effectively as a pointer (i.e. no copying). Change-Id: I2c1d26b25118fb9949e878b1b519d93efcfa5019 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/297841 Reviewed-by: Nathaniel Nifong <nifong@google.com> Reviewed-by: Chris Dalton <csmartdalton@google.com>
2020-06-23 20:58:10 +00:00
_addVerbsPointsWeights: function() {},
Replace arcTo with three functions for it's overloads. I found this to be about 15% faster on a benchmark designed to stress these functions. https://github.com/flutter/flutter/issues/61305 Change-Id: I9dc2a8396e54c55464bb71562de0c07c853e829c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/303024 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Nathaniel Nifong <nifong@google.com>
2020-07-15 20:46:17 +00:00
_arcToOval: function() {},
Revert "[canvaskit] Change SkRects to be arrays, not objects." Revert submission 314622 Reason for revert: breaking wasm bots Reverted Changes: Ia1ba13814:[canvaskit] Replace RRect objects with TypedArrays... Ib80b15e2d:[canvaskit] Change SkRects to be arrays, not objec... I790b2d6fc:[canvaskit] Add drawRect4f as example 'fast path' ... Change-Id: Ie6e4c57ba412ca9ff8e4446b06681b51029da2d6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/314893 Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2020-09-02 21:20:44 +00:00
_arcToRotated: function() {},
Reland "[canvaskit] Change SkRects to be arrays, not objects." This is a reland of bdc214a50e854fabb62bda126977b63e298dea9f The CPU version of SkottieWasm is timing out for reasons unknown, but the GPU version is happy. I think we can get rid of the CPU version of the job since it has been more or less superseded by the SkottieFrames one (and the latter is more stable). Original change's description: > [canvaskit] Change SkRects to be arrays, not objects. > > This changes several APIs, so there are lots of breaking > notes in the Changelog. > > This made the "draw 100 colored regions" benchmark about > 20% faster (1ms -> .8ms). > > In theory, rendering should stay the same. > > Change-Id: Ib80b15e2d980ad5d568fff4460d2b529766c1b36 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312491 > Reviewed-by: Nathaniel Nifong <nifong@google.com> Change-Id: I674aba85ecfb30b72e94cbaf89b2d97bfae3b7a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315142 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-09-03 14:02:10 +00:00
_arcToTangent: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
_close: function() {},
_conicTo: function() {},
[canvaskit] Fix computeTightBounds I noticed it was broken and untested when writing docs. Change-Id: I5254b7bd50fde8a361c72ccbd7380809d31ccc08 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/321464 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-01 14:55:16 +00:00
_computeTightBounds: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
_cubicTo: function() {},
_dash: function() {},
_lineTo: function() {},
_moveTo: function() {},
_op: function() {},
_quadTo: function() {},
_rArcTo: function() {},
_rConicTo: function() {},
_rCubicTo: function() {},
Reland "[canvaskit] Change SkRects to be arrays, not objects." This is a reland of bdc214a50e854fabb62bda126977b63e298dea9f The CPU version of SkottieWasm is timing out for reasons unknown, but the GPU version is happy. I think we can get rid of the CPU version of the job since it has been more or less superseded by the SkottieFrames one (and the latter is more stable). Original change's description: > [canvaskit] Change SkRects to be arrays, not objects. > > This changes several APIs, so there are lots of breaking > notes in the Changelog. > > This made the "draw 100 colored regions" benchmark about > 20% faster (1ms -> .8ms). > > In theory, rendering should stay the same. > > Change-Id: Ib80b15e2d980ad5d568fff4460d2b529766c1b36 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312491 > Reviewed-by: Nathaniel Nifong <nifong@google.com> Change-Id: I674aba85ecfb30b72e94cbaf89b2d97bfae3b7a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315142 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-09-03 14:02:10 +00:00
_rect: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
_rLineTo: function() {},
_rMoveTo: function() {},
_rQuadTo: function() {},
_simplify: function() {},
_stroke: function() {},
_transform: function() {},
_trim: function() {},
delete: function() {},
dump: function() {},
dumpHex: function() {},
},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
PathMeasure: {
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
getLength: function() {},
getSegment: function() {},
getPosTan: function() {},
isClosed: function() {},
nextContour: function() {},
},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
Picture: {
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
serialize: function() {},
},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
PictureRecorder: {
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
finishRecordingAsPicture: function() {},
Reland "[canvaskit] Change SkRects to be arrays, not objects." This is a reland of bdc214a50e854fabb62bda126977b63e298dea9f The CPU version of SkottieWasm is timing out for reasons unknown, but the GPU version is happy. I think we can get rid of the CPU version of the job since it has been more or less superseded by the SkottieFrames one (and the latter is more stable). Original change's description: > [canvaskit] Change SkRects to be arrays, not objects. > > This changes several APIs, so there are lots of breaking > notes in the Changelog. > > This made the "draw 100 colored regions" benchmark about > 20% faster (1ms -> .8ms). > > In theory, rendering should stay the same. > > Change-Id: Ib80b15e2d980ad5d568fff4460d2b529766c1b36 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312491 > Reviewed-by: Nathaniel Nifong <nifong@google.com> Change-Id: I674aba85ecfb30b72e94cbaf89b2d97bfae3b7a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315142 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-09-03 14:02:10 +00:00
prototype: {
beginRecording: function() {},
},
_beginRecording: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
Shader: {
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
Blend: function() {},
Color: function() {},
Empty: function() {},
Lerp: function() {},
Add shader makers to SkShader externs Bug: skia:9843 Change-Id: I98ba2e41563b8b3dcec523ae7a2340b9aacfec2d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275963 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Nathaniel Nifong <nifong@google.com>
2020-03-09 14:50:43 +00:00
MakeLinearGradient: function() {},
MakeRadialGradient: function() {},
MakeTwoPointConicalGradient: function() {},
Sweep gradient support for CanvasKit Change-Id: I04af9ea7aa6c6f95de6ff1eaf5ee41d59df7f09e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/277059 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-16 16:17:30 +00:00
MakeSweepGradient: function() {},
Pass 4f colors to private functions with float pointers Change-Id: I4534a246c37870750298d39edcbc869781dc1008 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/286880 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-05-04 20:46:17 +00:00
// private API (from C++ bindings)
_Color: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
Surface: {
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
// public API (from C++ bindings)
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
/** @return {CanvasKit.Canvas} */
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
getCanvas: function() {},
Wide color gamut support and working example. Fixes release-cpu build issue, un-revert cl 289733 Color space arguments accepted at surface creation, paint, gradient, and other call sites. Works correctly only when chrome happens to be rendering itself in the same color space the canvaskit user has chosen, there's not yet end to end color management of canvases supported in browsers. readPixels not yet working due to possible chrome bug. Reviewed-on: https://skia-review.googlesource.com/c/skia/+/289733 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Change-Id: I65ce1c643dac57e14b8476f598c96b12b7e040ce Reviewed-on: https://skia-review.googlesource.com/c/skia/+/291896
2020-05-26 17:10:20 +00:00
imageInfo: function() {},
Reland "[canvaskit] Change SkRects to be arrays, not objects." This is a reland of bdc214a50e854fabb62bda126977b63e298dea9f The CPU version of SkottieWasm is timing out for reasons unknown, but the GPU version is happy. I think we can get rid of the CPU version of the job since it has been more or less superseded by the SkottieFrames one (and the latter is more stable). Original change's description: > [canvaskit] Change SkRects to be arrays, not objects. > > This changes several APIs, so there are lots of breaking > notes in the Changelog. > > This made the "draw 100 colored regions" benchmark about > 20% faster (1ms -> .8ms). > > In theory, rendering should stay the same. > > Change-Id: Ib80b15e2d980ad5d568fff4460d2b529766c1b36 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312491 > Reviewed-by: Nathaniel Nifong <nifong@google.com> Change-Id: I674aba85ecfb30b72e94cbaf89b2d97bfae3b7a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315142 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-09-03 14:02:10 +00:00
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
makeSurface: function() {},
Query GL_SAMPLES when creating an SkSurface from the WebGL canvas This allows users to create their context with {antialias: true} and *hope* for MSAA. This CL also updates viewer.html achieve MSAA with this method, and if the browser doesn't give an MSAA, we simply abort. Change-Id: Ia242d266123c4b08f15a357e1fedc449642d88d3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/297597 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
2020-06-19 15:45:57 +00:00
sampleCnt: function() {},
fix heap-buffer-overflow by not returning string from reportBackendType Change-Id: I2dbced29f9d43454e35e3ff9fbbb97d11fef29a2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/303623 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Nathaniel Nifong <nifong@google.com>
2020-07-17 14:28:36 +00:00
reportBackendTypeIsGPU: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
grContext: {},
Run both puppeteer tests in a WebGL 1 and 2 configuration. Change-Id: Iaaef7d1ac96eec1813d3b0340ecabcbec90e3923 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/300982 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-07-17 19:20:44 +00:00
openGLversion: {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
Reland "[canvaskit] Change SkRects to be arrays, not objects." This is a reland of bdc214a50e854fabb62bda126977b63e298dea9f The CPU version of SkottieWasm is timing out for reasons unknown, but the GPU version is happy. I think we can get rid of the CPU version of the job since it has been more or less superseded by the SkottieFrames one (and the latter is more stable). Original change's description: > [canvaskit] Change SkRects to be arrays, not objects. > > This changes several APIs, so there are lots of breaking > notes in the Changelog. > > This made the "draw 100 colored regions" benchmark about > 20% faster (1ms -> .8ms). > > In theory, rendering should stay the same. > > Change-Id: Ib80b15e2d980ad5d568fff4460d2b529766c1b36 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312491 > Reviewed-by: Nathaniel Nifong <nifong@google.com> Change-Id: I674aba85ecfb30b72e94cbaf89b2d97bfae3b7a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315142 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-09-03 14:02:10 +00:00
prototype: {
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
/** @return {CanvasKit.Image} */
Reland "[canvaskit] Change SkRects to be arrays, not objects." This is a reland of bdc214a50e854fabb62bda126977b63e298dea9f The CPU version of SkottieWasm is timing out for reasons unknown, but the GPU version is happy. I think we can get rid of the CPU version of the job since it has been more or less superseded by the SkottieFrames one (and the latter is more stable). Original change's description: > [canvaskit] Change SkRects to be arrays, not objects. > > This changes several APIs, so there are lots of breaking > notes in the Changelog. > > This made the "draw 100 colored regions" benchmark about > 20% faster (1ms -> .8ms). > > In theory, rendering should stay the same. > > Change-Id: Ib80b15e2d980ad5d568fff4460d2b529766c1b36 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312491 > Reviewed-by: Nathaniel Nifong <nifong@google.com> Change-Id: I674aba85ecfb30b72e94cbaf89b2d97bfae3b7a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315142 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-09-03 14:02:10 +00:00
makeImageSnapshot: function() {},
},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
// private API
_flush: function() {},
_getRasterN32PremulSurface: function() {},
Reland "[canvaskit] Change SkRects to be arrays, not objects." This is a reland of bdc214a50e854fabb62bda126977b63e298dea9f The CPU version of SkottieWasm is timing out for reasons unknown, but the GPU version is happy. I think we can get rid of the CPU version of the job since it has been more or less superseded by the SkottieFrames one (and the latter is more stable). Original change's description: > [canvaskit] Change SkRects to be arrays, not objects. > > This changes several APIs, so there are lots of breaking > notes in the Changelog. > > This made the "draw 100 colored regions" benchmark about > 20% faster (1ms -> .8ms). > > In theory, rendering should stay the same. > > Change-Id: Ib80b15e2d980ad5d568fff4460d2b529766c1b36 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312491 > Reviewed-by: Nathaniel Nifong <nifong@google.com> Change-Id: I674aba85ecfb30b72e94cbaf89b2d97bfae3b7a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315142 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-09-03 14:02:10 +00:00
_makeImageSnapshot: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
delete: function() {},
},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
TextBlob: {
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
// public API (both C++ and JS bindings)
[canvaskit] Expose Glyph ID APIs Note: I intend to make shaping.html live in demos.skia.org, but that is hard to verify it works until the APIs land. Change-Id: I3af1cf8ded316f616d05ee60198393ed9c9a284f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/319130 Reviewed-by: Nathaniel Nifong <nifong@google.com> Reviewed-by: Mike Reed <reed@google.com>
2020-09-25 14:52:16 +00:00
MakeFromGlyphs: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
MakeFromRSXform: function() {},
[canvaskit] Expose Glyph ID APIs Note: I intend to make shaping.html live in demos.skia.org, but that is hard to verify it works until the APIs land. Change-Id: I3af1cf8ded316f616d05ee60198393ed9c9a284f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/319130 Reviewed-by: Nathaniel Nifong <nifong@google.com> Reviewed-by: Mike Reed <reed@google.com>
2020-09-25 14:52:16 +00:00
MakeFromRSXformGlyphs: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
MakeFromText: function() {},
MakeOnPath: function() {},
// private API (from C++ bindings)
[canvaskit] Expose Glyph ID APIs Note: I intend to make shaping.html live in demos.skia.org, but that is hard to verify it works until the APIs land. Change-Id: I3af1cf8ded316f616d05ee60198393ed9c9a284f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/319130 Reviewed-by: Nathaniel Nifong <nifong@google.com> Reviewed-by: Mike Reed <reed@google.com>
2020-09-25 14:52:16 +00:00
_MakeFromGlyphs: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
_MakeFromRSXform: function() {},
[canvaskit] Expose Glyph ID APIs Note: I intend to make shaping.html live in demos.skia.org, but that is hard to verify it works until the APIs land. Change-Id: I3af1cf8ded316f616d05ee60198393ed9c9a284f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/319130 Reviewed-by: Nathaniel Nifong <nifong@google.com> Reviewed-by: Mike Reed <reed@google.com>
2020-09-25 14:52:16 +00:00
_MakeFromRSXformGlyphs: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
_MakeFromText: function() {},
},
// These are defined in interface.js
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
Vector: {
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
add: function() {},
sub: function() {},
dot: function() {},
cross: function() {},
normalize: function() {},
mulScalar: function() {},
length: function() {},
lengthSquared: function() {},
dist: function() {},
},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
Vertices: {
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
// public API (from C++ bindings)
uniqueID: function() {},
Reland "[canvaskit] Change SkRects to be arrays, not objects." This is a reland of bdc214a50e854fabb62bda126977b63e298dea9f The CPU version of SkottieWasm is timing out for reasons unknown, but the GPU version is happy. I think we can get rid of the CPU version of the job since it has been more or less superseded by the SkottieFrames one (and the latter is more stable). Original change's description: > [canvaskit] Change SkRects to be arrays, not objects. > > This changes several APIs, so there are lots of breaking > notes in the Changelog. > > This made the "draw 100 colored regions" benchmark about > 20% faster (1ms -> .8ms). > > In theory, rendering should stay the same. > > Change-Id: Ib80b15e2d980ad5d568fff4460d2b529766c1b36 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312491 > Reviewed-by: Nathaniel Nifong <nifong@google.com> Change-Id: I674aba85ecfb30b72e94cbaf89b2d97bfae3b7a4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315142 Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-09-03 14:02:10 +00:00
prototype: {
bounds: function() {},
},
// private API (from C++ bindings)
_bounds: function() {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
},
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
_VerticesBuilder: {
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
colors: function() {},
detach: function() {},
indices: function() {},
positions: function() {},
texCoords: function() {},
},
TextStyle: function() {},
// Constants and Enums
gpu: {},
skottie: {},
TRANSPARENT: {},
Reland "Switch to using a Float32Array (bound as value array) for color." This is a reland of 4e79b6730dfce84f2d115ad3babf7b848d44a2b5 Original change's description: > Switch to using a Float32Array (bound as value array) for color. > > Change-Id: I1bcca931954b1399c79f4074a3d57a68847ac785 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/276757 > Commit-Queue: Nathaniel Nifong <nifong@google.com> > Reviewed-by: Kevin Lubick <kjlubick@google.com> Change-Id: If6b9097b2fcd6b9dbf75c6dd22138e0b2531e70d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/278780 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-26 13:27:48 +00:00
BLACK: {},
WHITE: {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
RED: {},
Reland "Switch to using a Float32Array (bound as value array) for color." This is a reland of 4e79b6730dfce84f2d115ad3babf7b848d44a2b5 Original change's description: > Switch to using a Float32Array (bound as value array) for color. > > Change-Id: I1bcca931954b1399c79f4074a3d57a68847ac785 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/276757 > Commit-Queue: Nathaniel Nifong <nifong@google.com> > Reviewed-by: Kevin Lubick <kjlubick@google.com> Change-Id: If6b9097b2fcd6b9dbf75c6dd22138e0b2531e70d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/278780 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-26 13:27:48 +00:00
GREEN: {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
BLUE: {},
YELLOW: {},
CYAN: {},
Reland "Switch to using a Float32Array (bound as value array) for color." This is a reland of 4e79b6730dfce84f2d115ad3babf7b848d44a2b5 Original change's description: > Switch to using a Float32Array (bound as value array) for color. > > Change-Id: I1bcca931954b1399c79f4074a3d57a68847ac785 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/276757 > Commit-Queue: Nathaniel Nifong <nifong@google.com> > Reviewed-by: Kevin Lubick <kjlubick@google.com> Change-Id: If6b9097b2fcd6b9dbf75c6dd22138e0b2531e70d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/278780 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-26 13:27:48 +00:00
MAGENTA: {},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
MOVE_VERB: {},
LINE_VERB: {},
QUAD_VERB: {},
CONIC_VERB: {},
CUBIC_VERB: {},
CLOSE_VERB: {},
NoDecoration: {},
UnderlineDecoration: {},
OverlineDecoration: {},
LineThroughDecoration: {},
SaveLayerInitWithPrevious: {},
SaveLayerF16ColorType: {},
Affinity: {
Upstream: {},
Downstream: {},
},
AlphaType: {
Opaque: {},
Premul: {},
Unpremul: {},
},
BlendMode: {
Clear: {},
Src: {},
Dst: {},
SrcOver: {},
DstOver: {},
SrcIn: {},
DstIn: {},
SrcOut: {},
DstOut: {},
SrcATop: {},
DstATop: {},
Xor: {},
Plus: {},
Modulate: {},
Screen: {},
Overlay: {},
Darken: {},
Lighten: {},
ColorDodge: {},
ColorBurn: {},
HardLight: {},
SoftLight: {},
Difference: {},
Exclusion: {},
Multiply: {},
Hue: {},
Saturation: {},
Color: {},
Luminosity: {},
},
BlurStyle: {
Normal: {},
Solid: {},
Outer: {},
Inner: {},
},
ClipOp: {
Difference: {},
Intersect: {},
},
ColorType: {
Alpha_8: {},
RGB_565: {},
ARGB_4444: {},
RGBA_8888: {},
RGB_888x: {},
BGRA_8888: {},
RGBA_1010102: {},
RGB_101010x: {},
Gray_8: {},
RGBA_F16: {},
RGBA_F32: {},
},
FillType: {
Winding: {},
EvenOdd: {},
},
FilterQuality: {
None: {},
Low: {},
Medium: {},
High: {},
},
FontSlant: {
Upright: {},
Italic: {},
Oblique: {},
},
FontHinting: {
None: {},
Slight: {},
Normal: {},
Full: {},
},
FontWeight: {
Invisible: {},
Thin: {},
ExtraLight: {},
Light: {},
Normal: {},
Medium: {},
SemiBold: {},
Bold: {},
ExtraBold: {},
Black: {},
ExtraBlack: {},
},
FontWidth: {
UltraCondensed: {},
ExtraCondensed: {},
Condensed: {},
SemiCondensed: {},
Normal: {},
SemiExpanded: {},
Expanded: {},
ExtraExpanded: {},
UltraExpanded: {},
},
ImageFormat: {
PNG: {},
JPEG: {},
},
PaintStyle: {
Fill: {},
Stroke: {},
},
PathOp: {
Difference: {},
Intersect: {},
Union: {},
XOR: {},
ReverseDifference: {},
},
PointMode: {
Points: {},
Lines: {},
Polygon: {},
},
RectHeightStyle: {
Tight: {},
Max: {},
IncludeLineSpacingMiddle: {},
IncludeLineSpacingTop: {},
IncludeLineSpacingBottom: {},
},
RectWidthStyle: {
Tight: {},
Max: {},
},
StrokeCap: {
Butt: {},
Round: {},
Square: {},
},
StrokeJoin: {
Miter: {},
Round: {},
Bevel: {},
},
TextAlign: {
Left: {},
Right: {},
Center: {},
Justify: {},
Start: {},
End: {},
},
TextDirection: {
LTR: {},
RTL: {},
},
Add more paragraph bindings to CanvasKit Change-Id: Ib02b6504724e4d7cfa197a3508f8c0b84b4135bf Reviewed-on: https://skia-review.googlesource.com/c/skia/+/313146 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Yegor Jbanov <yjbanov@google.com> Auto-Submit: Harry Terkelsen <het@google.com>
2020-10-02 22:24:13 +00:00
DecorationStyle: {
Solid: {},
Double: {},
Dotted: {},
Dashed: {},
Wavy: {},
},
PlaceholderAlignment: {
Baseline: {},
AboveBaseline: {},
BelowBaseline: {},
Top: {},
Bottom: {},
Middle: {},
},
TextBaseline: {
Alphabetic: {},
Ideographic: {},
},
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
TileMode: {
Clamp: {},
Repeat: {},
Mirror: {},
Decal: {},
},
VertexMode: {
Triangles: {},
TrianglesStrip: {},
TriangleFan: {},
},
// Things Enscriptem adds for us
/**
* @type {Float32Array}
*/
HEAPF32: {},
/**
* @type {Float64Array}
*/
HEAPF64: {},
/**
* @type {Uint8Array}
*/
HEAPU8: {},
/**
* @type {Uint16Array}
*/
HEAPU16: {},
/**
* @type {Uint32Array}
*/
HEAPU32: {},
/**
* @type {Int8Array}
*/
HEAP8: {},
/**
* @type {Int16Array}
*/
HEAP16: {},
/**
* @type {Int32Array}
*/
HEAP32: {},
_malloc: function() {},
_free: function() {},
onRuntimeInitialized: function() {},
[canvaskit] Fleshing out the beginnings of a Canvas API I can probably write most, if not all, of a Canvas API in JS using the SkCanvas and SkPaint objects. This lets us expose the fancier API and optionally have a more familiar API. This is controlled at compile time, i.e. bring in the extra JS or not. There is still plenty of the API that needs working, but this is meant to outlay the plans of where this is going. Bug: skia: Change-Id: I2e36a33c24c2bacd52811dc85508dba170ab0dd7 Reviewed-on: https://skia-review.googlesource.com/c/163490 Reviewed-by: Mike Reed <reed@google.com>
2018-10-19 18:34:34 +00:00
};
[CanvasKit] Implement some basic Canvas/Surface things. drawText is having issues in a release build. Skottie sometimes asserts in debug mode. This possibly has something to do with memory alignment - like https://skia-review.googlesource.com/c/skia/+/155980 helped fix. Patchset 9 shows off integrating Skia drawing to an HTML canvas using Ganesh. To see it locally, set up https://kripken.github.io/emscripten-site/docs/getting_started/downloads.html and then set $EMSDK to be that directory. Then run make clean make local-example and navigate to http://localhost:8000/skia-wasm/example.html Patchset 20 shows off Skottie animating directly to a Canvas. Docs-Preview: https://skia.org/?cl=153882 Bug: skia: Change-Id: I2ad2f4ffac00925ee901982ccbaeb7aa63b1ea23 Reviewed-on: https://skia-review.googlesource.com/153882 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-09-20 21:39:31 +00:00
[canvaskit] Fleshing out the beginnings of a Canvas API I can probably write most, if not all, of a Canvas API in JS using the SkCanvas and SkPaint objects. This lets us expose the fancier API and optionally have a more familiar API. This is controlled at compile time, i.e. bring in the extra JS or not. There is still plenty of the API that needs working, but this is meant to outlay the plans of where this is going. Bug: skia: Change-Id: I2e36a33c24c2bacd52811dc85508dba170ab0dd7 Reviewed-on: https://skia-review.googlesource.com/c/163490 Reviewed-by: Mike Reed <reed@google.com>
2018-10-19 18:34:34 +00:00
// Public API things that are newly declared in the JS should go here.
// It's not enough to declare them above, because closure can still erase them
// unless they go on the prototype.
[canvaskit] Initial addition of SkParagraph There are more parts of ParagraphStyle and TextStyle, but this should be a bulk of the components. Bug: skia:9469 Change-Id: I87fff6700f41cff49ecbee3a1339e84c36699c93 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244837 Reviewed-by: Julia Lavrova <jlavrova@google.com>
2019-10-03 15:22:08 +00:00
CanvasKit.Paragraph.prototype.getRectsForRange = function() {};
Add more paragraph bindings to CanvasKit Change-Id: Ib02b6504724e4d7cfa197a3508f8c0b84b4135bf Reviewed-on: https://skia-review.googlesource.com/c/skia/+/313146 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Yegor Jbanov <yjbanov@google.com> Auto-Submit: Harry Terkelsen <het@google.com>
2020-10-02 22:24:13 +00:00
CanvasKit.Paragraph.prototype.getRectsForPlaceholders = function() {};
[canvaskit] Initial addition of SkParagraph There are more parts of ParagraphStyle and TextStyle, but this should be a bulk of the components. Bug: skia:9469 Change-Id: I87fff6700f41cff49ecbee3a1339e84c36699c93 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244837 Reviewed-by: Julia Lavrova <jlavrova@google.com>
2019-10-03 15:22:08 +00:00
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
CanvasKit.Picture.prototype.saveAsFile = function() {};
[CanvasKit] Add basic support for SkPicture Can dump SkPicture to an skp, but only for debugging purposes (no deserialization). Bug: skia: Change-Id: I37f3c4dcfdd70b665748773ee6b5135329c6240a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/206262 Reviewed-by: Florin Malita <fmalita@chromium.org>
2019-04-05 17:00:01 +00:00
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
CanvasKit.Surface.prototype.dispose = function() {};
CanvasKit.Surface.prototype.flush = function() {};
CanvasKit.Surface.prototype.requestAnimationFrame = function() {};
CanvasKit.Surface.prototype.drawOnce = function() {};
Add CPU backend for CanvasKit This also makes the GPU and Skottie portions optional at build time. Bug: skia: Change-Id: I34f494caf0e2ca35dc4767d57f79ba92b24e818f Reviewed-on: https://skia-review.googlesource.com/c/159146 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-10-11 12:51:55 +00:00
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
CanvasKit.Image.prototype.encodeToData = function() {};
CanvasKit.Image.prototype.makeShader = function() {};
[canvaskit] Exposed SkPath::arc. Exposed SkEncodedImageFormat enum. Exposed SkImage::encodeToData overload with arguments These changes expose the arc function for SkPath. The ApplyAddArc function is a copy from the PathKit bindings. Also exposed the PNG and JPEG formats from the SkEncodedImageFormat enum and the SkImage::encodeToData overload that accepts format and quality options. The direct binding of encodeToData was replaced with a pre-js wrapper that calls the appropriate private overload We are working on a PostCSS conic gradient polyfill plugin and want to use the CanvasKit to generate it. Problem is - it lacks the arc function that technically exists but isn't exposed. And it would be really great to have encodeToData with options since generated PNGs are quite large. More details on the issue can be found here: https://github.com/jonathantneal/postcss-conic-gradient/issues/10 R=kjlubick@google.com Bug: skia: Change-Id: I3f1dc88ad308369fe62004080bcc196c4fbbf742 Reviewed-on: https://skia-review.googlesource.com/c/171046 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-11-14 23:01:19 +00:00
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
CanvasKit.FontMgr.prototype.MakeTypefaceFromData = function() {};
[canvaskit] Allow users to load their own fonts Instead of using the test font(s), now ship with a small (100k) Monospace font. This can be disabled by: compile.sh no_font ... This saves about 350k (164k gzipped) in binary size. Bug: skia: Change-Id: I195e3b35bea86d0f096066c1c6a44a4b602571f3 Reviewed-on: https://skia-review.googlesource.com/c/176580 Reviewed-by: Ben Wagner <bungeman@google.com>
2018-12-12 15:35:13 +00:00
[canvaskit] Add TextOnPath helper to TextBlob This adds the pieces needed to accomplish this, and although clients could do it, I figured it would be nice to expose as a universal tool (on TextBlob). Bug: skia: Change-Id: Id5d61744973de2da75049d33d40e1dc442c2442c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201601 Reviewed-by: Ben Wagner <bungeman@google.com>
2019-03-15 19:36:29 +00:00
CanvasKit.RSXFormBuilder.prototype.build = function() {};
CanvasKit.RSXFormBuilder.prototype.delete = function() {};
CanvasKit.RSXFormBuilder.prototype.push = function() {};
[canvaskit] adding drawAtlas to canvas API Also re-works colors in the JS part to be unsigned, so there's less chance for oopsies when passing them to the C++ side. Change-Id: I3f56d22e873e1407c402606444c50b76dd34ffd4 Bug: skia: Reviewed-on: https://skia-review.googlesource.com/c/skia/+/204543 Reviewed-by: Mike Reed <reed@google.com>
2019-03-29 14:39:52 +00:00
CanvasKit.RSXFormBuilder.prototype.set = function() {};
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
CanvasKit.ColorBuilder.prototype.build = function() {};
CanvasKit.ColorBuilder.prototype.delete = function() {};
CanvasKit.ColorBuilder.prototype.push = function() {};
CanvasKit.ColorBuilder.prototype.set = function() {};
[canvaskit] Add TextOnPath helper to TextBlob This adds the pieces needed to accomplish this, and although clients could do it, I figured it would be nice to expose as a universal tool (on TextBlob). Bug: skia: Change-Id: Id5d61744973de2da75049d33d40e1dc442c2442c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/201601 Reviewed-by: Ben Wagner <bungeman@google.com>
2019-03-15 19:36:29 +00:00
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
CanvasKit.RuntimeEffect.prototype.makeShader = function() {};
CanvasKit.RuntimeEffect.prototype.makeShaderWithChildren = function() {};
[canvaskit] Add _RTShaderFactory for demos Change-Id: Ib6dc1ff861efe4040508fea09c8a66d8d06db597 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258568 Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-12-06 18:55:58 +00:00
[canvaskit] Remove Sk from nearly all function/type names. This is a massive breaking change for all existing users of CanvasKit. It will be (one of the only) changes in 0.19.0 to make the transition easier. Suggested reviewing order: - index.d.ts (to see type changes). Notice SkPicture still has Sk prefix, but no other types do (this felt "right" since Sk is part of the name of the type, but I can be swayed on this). - canvaskit-wasm-tests.ts - tests/*.spec.js - interface.js and helper.js - html examples - markdown files Change-Id: I3b3d3815df2078f986893df3c70101d6248c117d Docs-Preview: https://skia.org/?cl=322617 Bug: skia:10717 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322617 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Nathaniel Nifong <nifong@google.com>
2020-10-07 20:09:22 +00:00
CanvasKit.ParticleEffect.prototype.effectUniforms = function() {};
CanvasKit.ParticleEffect.prototype.particleUniforms = function() {};
[canvaskit] Expose bindings to particles uniforms. Uniforms in the general case can be multiple floats, so we expose a small struct to provide information about all uniforms (including the built in ones like "dt") as well as effectUniforms and particleUniforms which return Float32Arrays bound to the WASM memory containing those unifroms. Thus, by modifying the Float32Array, one can directly affect the particle/effect properties. This allows us to expose sliders on particles.skia.org (https://skia-review.googlesource.com/c/buildbot/+/272398) Change-Id: Ie390f3d2dc571ee4ebaab59a7fa1b7b2dc24d871 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/272377 Reviewed-by: Brian Osman <brianosman@google.com>
2020-02-21 13:26:59 +00:00
[canvaskit] Add drawVertices API This also does some clean up to how we name enums - the caps felt a bit obnoxious. CAPS are reserved now for constants (like colors). Small bug fix with leaking memory on discrete path effects This also adds a few more things from PathKit Bug: skia: Change-Id: Iad7e21ac36d35a36a8b255dc82b1dcc886344db1 Reviewed-on: https://skia-review.googlesource.com/c/166804 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Reed <reed@google.com>
2018-11-03 11:51:19 +00:00
// Define StrokeOpts object
var StrokeOpts = {};
StrokeOpts.prototype.width;
StrokeOpts.prototype.miter_limit;
StrokeOpts.prototype.cap;
StrokeOpts.prototype.join;
[canvaskit] Add isPointInPath / isPointInStroke While working on this, I realized some things I did caused winding to be inconsistent with what the Canvas spec said (and with what Chrome did). This CL includes 2 changes to remedy that: - removal of the subpath (which added needless complication). - re-write of ellipse() (to mirror Chrome's implementation). Bug: skia: Change-Id: Idd6c8a40b3c46598892e50a1e586f2ff66b801e3 Reviewed-on: https://skia-review.googlesource.com/c/175425 Reviewed-by: Florin Malita <fmalita@chromium.org>
2018-12-07 18:03:08 +00:00
StrokeOpts.prototype.precision;
[canvaskit] Add drawVertices API This also does some clean up to how we name enums - the caps felt a bit obnoxious. CAPS are reserved now for constants (like colors). Small bug fix with leaking memory on discrete path effects This also adds a few more things from PathKit Bug: skia: Change-Id: Iad7e21ac36d35a36a8b255dc82b1dcc886344db1 Reviewed-on: https://skia-review.googlesource.com/c/166804 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Reed <reed@google.com>
2018-11-03 11:51:19 +00:00
[canvaskit] Add gradients and clips Refactors things inside to support both color and gradient as _fillStyle/_strokeStyle. Bug: skia: Change-Id: I364ceb7d55c41e11161d5577dcd1611a592bbc29 Reviewed-on: https://skia-review.googlesource.com/c/173421 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-29 20:07:02 +00:00
// Define everything created in the canvas2d spec here
[canvaskit] Make transforms work properly This re-works the subpath model and does transforming of ports in JS rather than in C++; the latter was not easy to conform to the Canvas Spec, especially for changing transforms in the middle of a path. Additionally adds jpeg to the available images it can produce. Bug: skia: Change-Id: I5a52ec341d4060198c8680aa4d3b85a26f77b6b9 Reviewed-on: https://skia-review.googlesource.com/c/172500 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-26 16:47:54 +00:00
var HTMLCanvas = {};
[canvaskit] Add drawImage support Adds drawImageRect as well. Bug: skia: Change-Id: Ib74f92a3ee22664297d8ce7ff1d2cd2644b806b7 Reviewed-on: https://skia-review.googlesource.com/c/173990 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-12-03 17:31:04 +00:00
HTMLCanvas.prototype.decodeImage = function() {};
HTMLCanvas.prototype.dispose = function() {};
[canvaskit] Make transforms work properly This re-works the subpath model and does transforming of ports in JS rather than in C++; the latter was not easy to conform to the Canvas Spec, especially for changing transforms in the middle of a path. Additionally adds jpeg to the available images it can produce. Bug: skia: Change-Id: I5a52ec341d4060198c8680aa4d3b85a26f77b6b9 Reviewed-on: https://skia-review.googlesource.com/c/172500 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-26 16:47:54 +00:00
HTMLCanvas.prototype.getContext = function() {};
[canvaskit] Canvas API for loading fonts There's the barest hint of a "font manager" here. Basically, nothing smart to deal with bold or fallbacks. Maybe one day, we'll expose SkTypeface* matchStyleCSS3(const SkFontStyle& pattern); and do smart things for fallbacks, but for now that's not in the immediate future. Docs-Preview: https://skia.org/?cl=177067 Bug: skia: Change-Id: Iaeabcbf5ff4511a01b37c16c983e447c25b0e3e7 Reviewed-on: https://skia-review.googlesource.com/c/177067 Reviewed-by: Ben Wagner <bungeman@google.com>
2018-12-14 20:03:41 +00:00
HTMLCanvas.prototype.loadFont = function() {};
[canvaskit] Add Path2D to Canvas API This moves the shared logic into path2d.js from canvas2dcontext.js. Bug: skia: Change-Id: Id63bc52a190109f7cbc4e17ddb5603e6e87d5dc0 Reviewed-on: https://skia-review.googlesource.com/c/178268 Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2018-12-17 21:01:36 +00:00
HTMLCanvas.prototype.makePath2D = function() {};
[canvaskit] Make transforms work properly This re-works the subpath model and does transforming of ports in JS rather than in C++; the latter was not easy to conform to the Canvas Spec, especially for changing transforms in the middle of a path. Additionally adds jpeg to the available images it can produce. Bug: skia: Change-Id: I5a52ec341d4060198c8680aa4d3b85a26f77b6b9 Reviewed-on: https://skia-review.googlesource.com/c/172500 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-26 16:47:54 +00:00
HTMLCanvas.prototype.toDataURL = function() {};
Added CanvasKit.MakeImageFromCanvasImageSource which is useful as an alternative to CanvasKit.MakeImageFromEncoded, when used with Browser APIs for loading/decoding images. - `CanvasKit.MakeImageFromCanvasImageSource` takes either an HTMLImageElement, SVGImageElement, HTMLVideoElement, HTMLCanvasElement, ImageBitmap, or OffscreenCanvas and returns an SkImage. This function is an alternative to `CanvasKit.MakeImageFromEncoded` for creating SkImages when loading and decoding images. In the future, codesize of CanvasKit may be able to be reduced by removing image codecs in wasm, if browser APIs for decoding images are used along with `CanvasKit.MakeImageFromCanvasImageSource` instead of `CanvasKit.MakeImageFromEncoded`. - Three usage examples of `CanvasKit.MakeImageFromCanvasImageSource` in core.spec.ts. These examples use browser APIs to decode images including 2d canvas, bitmaprenderer canvas, HTMLImageElement and Blob. - Added support for asynchronous callbacks in perfs and tests. Here are notes on the image decoding approaches we tested and perfed in the process of finding ways to use Browser APIs to decode images: 1. pipeline: ArrayBuffer → ImageData → ctx.putImageData → context.getImageData → Uint8Array → CanvasKit.MakeImage ❌ Problem: ImageData constructor expects decoded bytes already. 2. interface.js - CanvasKit.ExperimentalCanvas2DMakeImageFromEncoded (async function) pipeline: ArrayBuffer → Blob -> HTMLImageElement -> draw on Canvas2d -> context.getImageData → Uint8Array → CanvasKit.MakeImage ✅ Works ⏱ Performance: 3rd place (in my testing locally) 3. interface.js - CanvasKit.ExperimentalCanvas2DMakeImageFromEncoded2 (async function) ArrayBuffer → Blob → ImageBitmap → draw on Canvas2d → context.getImageData → Uint8Array → CanvasKit.MakeImage ✅ Works ⏱ Performance: 2nd place (in my testing locally) 4. interface.js - CanvasKit.ExperimentalCanvas2DMakeImageFromEncoded3 (async function) ArrayBuffer → Blob → ImageBitmap → draw on canvas 1 using bitmaprenderer context → draw canvas 1 on canvas 2 using drawImage → context2d.getImageData → Uint8Array → CanvasKit.MakeImage ✅ Works ⏱ Performance: 1st place (in my testing locally) - quite surprising, this in some ways seems to be a more roundabout way of CanvasKit.ExperimentalCanvas2DMakeImageFromEncoded2, but it seems bitmaprenderer context is fairly fast. Bug: skia:10360 Change-Id: I6fe94b8196dfd1ad0d8929f04bb1697da537ca18 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/295390 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-06-15 18:53:27 +00:00
var ImageBitmapRenderingContext = {};
ImageBitmapRenderingContext.prototype.transferFromImageBitmap = function() {};
[canvaskit] Make transforms work properly This re-works the subpath model and does transforming of ports in JS rather than in C++; the latter was not easy to conform to the Canvas Spec, especially for changing transforms in the middle of a path. Additionally adds jpeg to the available images it can produce. Bug: skia: Change-Id: I5a52ec341d4060198c8680aa4d3b85a26f77b6b9 Reviewed-on: https://skia-review.googlesource.com/c/172500 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-26 16:47:54 +00:00
var CanvasRenderingContext2D = {};
CanvasRenderingContext2D.prototype.addHitRegion = function() {};
CanvasRenderingContext2D.prototype.arc = function() {};
CanvasRenderingContext2D.prototype.arcTo = function() {};
CanvasRenderingContext2D.prototype.beginPath = function() {};
CanvasRenderingContext2D.prototype.bezierCurveTo = function() {};
CanvasRenderingContext2D.prototype.clearHitRegions = function() {};
[canvaskit] support globalAlpha and dashed strokes This involves a refactor of how we deal with paint. Now, we have a source-of-truth paint that is copied and modified for each of fill/stroke/shadow. Adds preliminary support for blend modes. Most of what remains is text, images, and gradients. Bug: skia: Change-Id: I41806adeb7de4faa6c98a580c4f1de4e4a34a37d Reviewed-on: https://skia-review.googlesource.com/c/173223 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-28 17:51:56 +00:00
CanvasRenderingContext2D.prototype.clearRect = function() {};
[canvaskit] Add gradients and clips Refactors things inside to support both color and gradient as _fillStyle/_strokeStyle. Bug: skia: Change-Id: I364ceb7d55c41e11161d5577dcd1611a592bbc29 Reviewed-on: https://skia-review.googlesource.com/c/173421 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-29 20:07:02 +00:00
CanvasRenderingContext2D.prototype.clip = function() {};
[canvaskit] Make transforms work properly This re-works the subpath model and does transforming of ports in JS rather than in C++; the latter was not easy to conform to the Canvas Spec, especially for changing transforms in the middle of a path. Additionally adds jpeg to the available images it can produce. Bug: skia: Change-Id: I5a52ec341d4060198c8680aa4d3b85a26f77b6b9 Reviewed-on: https://skia-review.googlesource.com/c/172500 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-26 16:47:54 +00:00
CanvasRenderingContext2D.prototype.closePath = function() {};
[canvaskit] Support getImageData/putImageData setMatrix -> _setMatrix with the hope of removing it from the API (it breaks the save()/restore() model) and replacing it with concat (which I'll try in a follow on CL). Adds MakeImage for those times when a client has pixels and needs to clip them (e.g. putImageData with 7 args). This removes SkSurface._readPixels, which I might have been holding wrong. It might get re-surfaced eventually. Bug: skia: Change-Id: Iee9a494db720b22e23f9e674b20ba678fad91d25 Reviewed-on: https://skia-review.googlesource.com/c/174300 Reviewed-by: Mike Klein <mtklein@google.com>
2018-12-04 18:57:36 +00:00
CanvasRenderingContext2D.prototype.createImageData = function() {};
[canvaskit] Add gradients and clips Refactors things inside to support both color and gradient as _fillStyle/_strokeStyle. Bug: skia: Change-Id: I364ceb7d55c41e11161d5577dcd1611a592bbc29 Reviewed-on: https://skia-review.googlesource.com/c/173421 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-29 20:07:02 +00:00
CanvasRenderingContext2D.prototype.createLinearGradient = function() {};
[canvaskit] Add createPattern support to canvasAPI Add Changelog to start tracking API changes (in preparation for NPM) Simplify globalAlpha passing. API change: - Make ImageShader take an SkImage instead of encoded bytes. Bug: skia: Change-Id: I716f001b54ed58da3f40ae4e060b7098b550af9f Reviewed-on: https://skia-review.googlesource.com/c/175260 Reviewed-by: Florin Malita <fmalita@chromium.org>
2018-12-07 13:29:52 +00:00
CanvasRenderingContext2D.prototype.createPattern = function() {};
[canvaskit] Add gradients and clips Refactors things inside to support both color and gradient as _fillStyle/_strokeStyle. Bug: skia: Change-Id: I364ceb7d55c41e11161d5577dcd1611a592bbc29 Reviewed-on: https://skia-review.googlesource.com/c/173421 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-29 20:07:02 +00:00
CanvasRenderingContext2D.prototype.createRadialGradient = function() {};
[canvaskit] Make transforms work properly This re-works the subpath model and does transforming of ports in JS rather than in C++; the latter was not easy to conform to the Canvas Spec, especially for changing transforms in the middle of a path. Additionally adds jpeg to the available images it can produce. Bug: skia: Change-Id: I5a52ec341d4060198c8680aa4d3b85a26f77b6b9 Reviewed-on: https://skia-review.googlesource.com/c/172500 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-26 16:47:54 +00:00
CanvasRenderingContext2D.prototype.drawFocusIfNeeded = function() {};
[canvaskit] Add drawImage support Adds drawImageRect as well. Bug: skia: Change-Id: Ib74f92a3ee22664297d8ce7ff1d2cd2644b806b7 Reviewed-on: https://skia-review.googlesource.com/c/173990 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-12-03 17:31:04 +00:00
CanvasRenderingContext2D.prototype.drawImage = function() {};
[canvaskit] Make transforms work properly This re-works the subpath model and does transforming of ports in JS rather than in C++; the latter was not easy to conform to the Canvas Spec, especially for changing transforms in the middle of a path. Additionally adds jpeg to the available images it can produce. Bug: skia: Change-Id: I5a52ec341d4060198c8680aa4d3b85a26f77b6b9 Reviewed-on: https://skia-review.googlesource.com/c/172500 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-26 16:47:54 +00:00
CanvasRenderingContext2D.prototype.ellipse = function() {};
[canvaskit] Add shadow and save/restore support This also exposes the ShadowUtils::drawShadow on Canvas, even though it wasn't what was needed to duplicate the Canvas effect. Bug: skia: Change-Id: I12276ef106244218e4827b7fcd7949c83cf13e5f Reviewed-on: https://skia-review.googlesource.com/c/172967 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-27 18:26:59 +00:00
CanvasRenderingContext2D.prototype.fill = function() {};
[canvaskit] support globalAlpha and dashed strokes This involves a refactor of how we deal with paint. Now, we have a source-of-truth paint that is copied and modified for each of fill/stroke/shadow. Adds preliminary support for blend modes. Most of what remains is text, images, and gradients. Bug: skia: Change-Id: I41806adeb7de4faa6c98a580c4f1de4e4a34a37d Reviewed-on: https://skia-review.googlesource.com/c/173223 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-28 17:51:56 +00:00
CanvasRenderingContext2D.prototype.fillRect = function() {};
[canvaskit] Make transforms work properly This re-works the subpath model and does transforming of ports in JS rather than in C++; the latter was not easy to conform to the Canvas Spec, especially for changing transforms in the middle of a path. Additionally adds jpeg to the available images it can produce. Bug: skia: Change-Id: I5a52ec341d4060198c8680aa4d3b85a26f77b6b9 Reviewed-on: https://skia-review.googlesource.com/c/172500 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-26 16:47:54 +00:00
CanvasRenderingContext2D.prototype.fillText = function() {};
[canvaskit] Support getImageData/putImageData setMatrix -> _setMatrix with the hope of removing it from the API (it breaks the save()/restore() model) and replacing it with concat (which I'll try in a follow on CL). Adds MakeImage for those times when a client has pixels and needs to clip them (e.g. putImageData with 7 args). This removes SkSurface._readPixels, which I might have been holding wrong. It might get re-surfaced eventually. Bug: skia: Change-Id: Iee9a494db720b22e23f9e674b20ba678fad91d25 Reviewed-on: https://skia-review.googlesource.com/c/174300 Reviewed-by: Mike Klein <mtklein@google.com>
2018-12-04 18:57:36 +00:00
CanvasRenderingContext2D.prototype.getImageData = function() {};
[canvaskit] support globalAlpha and dashed strokes This involves a refactor of how we deal with paint. Now, we have a source-of-truth paint that is copied and modified for each of fill/stroke/shadow. Adds preliminary support for blend modes. Most of what remains is text, images, and gradients. Bug: skia: Change-Id: I41806adeb7de4faa6c98a580c4f1de4e4a34a37d Reviewed-on: https://skia-review.googlesource.com/c/173223 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-28 17:51:56 +00:00
CanvasRenderingContext2D.prototype.getLineDash = function() {};
[canvaskit] Add isPointInPath / isPointInStroke While working on this, I realized some things I did caused winding to be inconsistent with what the Canvas spec said (and with what Chrome did). This CL includes 2 changes to remedy that: - removal of the subpath (which added needless complication). - re-write of ellipse() (to mirror Chrome's implementation). Bug: skia: Change-Id: Idd6c8a40b3c46598892e50a1e586f2ff66b801e3 Reviewed-on: https://skia-review.googlesource.com/c/175425 Reviewed-by: Florin Malita <fmalita@chromium.org>
2018-12-07 18:03:08 +00:00
CanvasRenderingContext2D.prototype.isPointInPath = function() {};
CanvasRenderingContext2D.prototype.isPointInStroke = function() {};
[canvaskit] Make transforms work properly This re-works the subpath model and does transforming of ports in JS rather than in C++; the latter was not easy to conform to the Canvas Spec, especially for changing transforms in the middle of a path. Additionally adds jpeg to the available images it can produce. Bug: skia: Change-Id: I5a52ec341d4060198c8680aa4d3b85a26f77b6b9 Reviewed-on: https://skia-review.googlesource.com/c/172500 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-26 16:47:54 +00:00
CanvasRenderingContext2D.prototype.lineTo = function() {};
CanvasRenderingContext2D.prototype.measureText = function() {};
CanvasRenderingContext2D.prototype.moveTo = function() {};
[canvaskit] Support getImageData/putImageData setMatrix -> _setMatrix with the hope of removing it from the API (it breaks the save()/restore() model) and replacing it with concat (which I'll try in a follow on CL). Adds MakeImage for those times when a client has pixels and needs to clip them (e.g. putImageData with 7 args). This removes SkSurface._readPixels, which I might have been holding wrong. It might get re-surfaced eventually. Bug: skia: Change-Id: Iee9a494db720b22e23f9e674b20ba678fad91d25 Reviewed-on: https://skia-review.googlesource.com/c/174300 Reviewed-by: Mike Klein <mtklein@google.com>
2018-12-04 18:57:36 +00:00
CanvasRenderingContext2D.prototype.putImageData = function() {};
[canvaskit] Make transforms work properly This re-works the subpath model and does transforming of ports in JS rather than in C++; the latter was not easy to conform to the Canvas Spec, especially for changing transforms in the middle of a path. Additionally adds jpeg to the available images it can produce. Bug: skia: Change-Id: I5a52ec341d4060198c8680aa4d3b85a26f77b6b9 Reviewed-on: https://skia-review.googlesource.com/c/172500 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-26 16:47:54 +00:00
CanvasRenderingContext2D.prototype.quadraticCurveTo = function() {};
CanvasRenderingContext2D.prototype.rect = function() {};
CanvasRenderingContext2D.prototype.removeHitRegion = function() {};
CanvasRenderingContext2D.prototype.resetTransform = function() {};
[canvaskit] Add shadow and save/restore support This also exposes the ShadowUtils::drawShadow on Canvas, even though it wasn't what was needed to duplicate the Canvas effect. Bug: skia: Change-Id: I12276ef106244218e4827b7fcd7949c83cf13e5f Reviewed-on: https://skia-review.googlesource.com/c/172967 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-27 18:26:59 +00:00
CanvasRenderingContext2D.prototype.restore = function() {};
[canvaskit] Make transforms work properly This re-works the subpath model and does transforming of ports in JS rather than in C++; the latter was not easy to conform to the Canvas Spec, especially for changing transforms in the middle of a path. Additionally adds jpeg to the available images it can produce. Bug: skia: Change-Id: I5a52ec341d4060198c8680aa4d3b85a26f77b6b9 Reviewed-on: https://skia-review.googlesource.com/c/172500 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-26 16:47:54 +00:00
CanvasRenderingContext2D.prototype.rotate = function() {};
[canvaskit] Add shadow and save/restore support This also exposes the ShadowUtils::drawShadow on Canvas, even though it wasn't what was needed to duplicate the Canvas effect. Bug: skia: Change-Id: I12276ef106244218e4827b7fcd7949c83cf13e5f Reviewed-on: https://skia-review.googlesource.com/c/172967 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-27 18:26:59 +00:00
CanvasRenderingContext2D.prototype.save = function() {};
[canvaskit] Make transforms work properly This re-works the subpath model and does transforming of ports in JS rather than in C++; the latter was not easy to conform to the Canvas Spec, especially for changing transforms in the middle of a path. Additionally adds jpeg to the available images it can produce. Bug: skia: Change-Id: I5a52ec341d4060198c8680aa4d3b85a26f77b6b9 Reviewed-on: https://skia-review.googlesource.com/c/172500 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-26 16:47:54 +00:00
CanvasRenderingContext2D.prototype.scale = function() {};
CanvasRenderingContext2D.prototype.scrollPathIntoView = function() {};
[canvaskit] support globalAlpha and dashed strokes This involves a refactor of how we deal with paint. Now, we have a source-of-truth paint that is copied and modified for each of fill/stroke/shadow. Adds preliminary support for blend modes. Most of what remains is text, images, and gradients. Bug: skia: Change-Id: I41806adeb7de4faa6c98a580c4f1de4e4a34a37d Reviewed-on: https://skia-review.googlesource.com/c/173223 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-28 17:51:56 +00:00
CanvasRenderingContext2D.prototype.setLineDash = function() {};
[canvaskit] Make transforms work properly This re-works the subpath model and does transforming of ports in JS rather than in C++; the latter was not easy to conform to the Canvas Spec, especially for changing transforms in the middle of a path. Additionally adds jpeg to the available images it can produce. Bug: skia: Change-Id: I5a52ec341d4060198c8680aa4d3b85a26f77b6b9 Reviewed-on: https://skia-review.googlesource.com/c/172500 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-26 16:47:54 +00:00
CanvasRenderingContext2D.prototype.setTransform = function() {};
CanvasRenderingContext2D.prototype.stroke = function() {};
[canvaskit] support globalAlpha and dashed strokes This involves a refactor of how we deal with paint. Now, we have a source-of-truth paint that is copied and modified for each of fill/stroke/shadow. Adds preliminary support for blend modes. Most of what remains is text, images, and gradients. Bug: skia: Change-Id: I41806adeb7de4faa6c98a580c4f1de4e4a34a37d Reviewed-on: https://skia-review.googlesource.com/c/173223 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-28 17:51:56 +00:00
CanvasRenderingContext2D.prototype.strokeRect = function() {};
[canvaskit] Make transforms work properly This re-works the subpath model and does transforming of ports in JS rather than in C++; the latter was not easy to conform to the Canvas Spec, especially for changing transforms in the middle of a path. Additionally adds jpeg to the available images it can produce. Bug: skia: Change-Id: I5a52ec341d4060198c8680aa4d3b85a26f77b6b9 Reviewed-on: https://skia-review.googlesource.com/c/172500 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-26 16:47:54 +00:00
CanvasRenderingContext2D.prototype.strokeText = function() {};
CanvasRenderingContext2D.prototype.transform = function() {};
CanvasRenderingContext2D.prototype.translate = function() {};
[canvaskit] Add Path2D to Canvas API This moves the shared logic into path2d.js from canvas2dcontext.js. Bug: skia: Change-Id: Id63bc52a190109f7cbc4e17ddb5603e6e87d5dc0 Reviewed-on: https://skia-review.googlesource.com/c/178268 Reviewed-by: Joe Gregorio <jcgregorio@google.com>
2018-12-17 21:01:36 +00:00
var Path2D = {};
Path2D.prototype.addPath = function() {};
Path2D.prototype.arc = function() {};
Path2D.prototype.arcTo = function() {};
Path2D.prototype.bezierCurveTo = function() {};
Path2D.prototype.closePath = function() {};
Path2D.prototype.ellipse = function() {};
Path2D.prototype.lineTo = function() {};
Path2D.prototype.moveTo = function() {};
Path2D.prototype.quadraticCurveTo = function() {};
Path2D.prototype.rect = function() {};
[canvaskit] Add gradients and clips Refactors things inside to support both color and gradient as _fillStyle/_strokeStyle. Bug: skia: Change-Id: I364ceb7d55c41e11161d5577dcd1611a592bbc29 Reviewed-on: https://skia-review.googlesource.com/c/173421 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-29 20:07:02 +00:00
var LinearCanvasGradient = {};
LinearCanvasGradient.prototype.addColorStop = function() {};
var RadialCanvasGradient = {};
RadialCanvasGradient.prototype.addColorStop = function() {};
[canvaskit] Add createPattern support to canvasAPI Add Changelog to start tracking API changes (in preparation for NPM) Simplify globalAlpha passing. API change: - Make ImageShader take an SkImage instead of encoded bytes. Bug: skia: Change-Id: I716f001b54ed58da3f40ae4e060b7098b550af9f Reviewed-on: https://skia-review.googlesource.com/c/175260 Reviewed-by: Florin Malita <fmalita@chromium.org>
2018-12-07 13:29:52 +00:00
var CanvasPattern = {};
CanvasPattern.prototype.setTransform = function() {};
[canvaskit] Add gradients and clips Refactors things inside to support both color and gradient as _fillStyle/_strokeStyle. Bug: skia: Change-Id: I364ceb7d55c41e11161d5577dcd1611a592bbc29 Reviewed-on: https://skia-review.googlesource.com/c/173421 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-29 20:07:02 +00:00
[canvaskit] Support getImageData/putImageData setMatrix -> _setMatrix with the hope of removing it from the API (it breaks the save()/restore() model) and replacing it with concat (which I'll try in a follow on CL). Adds MakeImage for those times when a client has pixels and needs to clip them (e.g. putImageData with 7 args). This removes SkSurface._readPixels, which I might have been holding wrong. It might get re-surfaced eventually. Bug: skia: Change-Id: Iee9a494db720b22e23f9e674b20ba678fad91d25 Reviewed-on: https://skia-review.googlesource.com/c/174300 Reviewed-by: Mike Klein <mtklein@google.com>
2018-12-04 18:57:36 +00:00
var ImageData = {
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
/**
* @type {Uint8ClampedArray}
*/
data: {},
height: {},
width: {},
[canvaskit] Support getImageData/putImageData setMatrix -> _setMatrix with the hope of removing it from the API (it breaks the save()/restore() model) and replacing it with concat (which I'll try in a follow on CL). Adds MakeImage for those times when a client has pixels and needs to clip them (e.g. putImageData with 7 args). This removes SkSurface._readPixels, which I might have been holding wrong. It might get re-surfaced eventually. Bug: skia: Change-Id: Iee9a494db720b22e23f9e674b20ba678fad91d25 Reviewed-on: https://skia-review.googlesource.com/c/174300 Reviewed-by: Mike Klein <mtklein@google.com>
2018-12-04 18:57:36 +00:00
};
[canvaskit] Add createPattern support to canvasAPI Add Changelog to start tracking API changes (in preparation for NPM) Simplify globalAlpha passing. API change: - Make ImageShader take an SkImage instead of encoded bytes. Bug: skia: Change-Id: I716f001b54ed58da3f40ae4e060b7098b550af9f Reviewed-on: https://skia-review.googlesource.com/c/175260 Reviewed-by: Florin Malita <fmalita@chromium.org>
2018-12-07 13:29:52 +00:00
var DOMMatrix = {
Remove all uses of bones Change-Id: I302f43484c599a05e077545df5f053a89d63a6a6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/275079 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-03-05 15:27:14 +00:00
a: {},
b: {},
c: {},
d: {},
e: {},
f: {},
[canvaskit] Add createPattern support to canvasAPI Add Changelog to start tracking API changes (in preparation for NPM) Simplify globalAlpha passing. API change: - Make ImageShader take an SkImage instead of encoded bytes. Bug: skia: Change-Id: I716f001b54ed58da3f40ae4e060b7098b550af9f Reviewed-on: https://skia-review.googlesource.com/c/175260 Reviewed-by: Florin Malita <fmalita@chromium.org>
2018-12-07 13:29:52 +00:00
};
[CanvasKit] Implement some basic Canvas/Surface things. drawText is having issues in a release build. Skottie sometimes asserts in debug mode. This possibly has something to do with memory alignment - like https://skia-review.googlesource.com/c/skia/+/155980 helped fix. Patchset 9 shows off integrating Skia drawing to an HTML canvas using Ganesh. To see it locally, set up https://kripken.github.io/emscripten-site/docs/getting_started/downloads.html and then set $EMSDK to be that directory. Then run make clean make local-example and navigate to http://localhost:8000/skia-wasm/example.html Patchset 20 shows off Skottie animating directly to a Canvas. Docs-Preview: https://skia.org/?cl=153882 Bug: skia: Change-Id: I2ad2f4ffac00925ee901982ccbaeb7aa63b1ea23 Reviewed-on: https://skia-review.googlesource.com/153882 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-09-20 21:39:31 +00:00
// Not sure why this is needed - might be a bug in emsdk that this isn't properly declared.
[canvaskit] Add debug-mode only logs And a fix for node. Docs-Preview: https://skia.org/?cl=172143 Bug: skia: Change-Id: I519c2693b386aa68655f235281d932ee5fffbc61 Reviewed-on: https://skia-review.googlesource.com/c/172143 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2018-11-20 20:55:10 +00:00
function loadWebAssemblyModule() {};
Run both puppeteer tests in a WebGL 1 and 2 configuration. Change-Id: Iaaef7d1ac96eec1813d3b0340ecabcbec90e3923 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/300982 Commit-Queue: Nathaniel Nifong <nifong@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-07-17 19:20:44 +00:00
// This is a part of emscripten's webgl glue code. Preserving this attribute is necessary
// to override it in the puppeteer tests
var LibraryEGL = {
contextAttributes: {
majorVersion: {}
}
[CanvasKit] Expose TypefaceFontProvider. Change-Id: I950a3a4f45b7b4a106299576bc918531054b23f6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/307873 Reviewed-by: Kevin Lubick <kjlubick@google.com>
2020-08-04 20:21:09 +00:00
}
Reference in New Issue Copy Permalink