skia2/tests/sksl/inliner/StructsCanBeInlinedSafely.glsl


out vec4 sk_FragColor;
struct Color {
    float red;
    float green;
    float blue;
    float alpha;
};
vec4 main() {
    Color _0_c;
    _0_c.red = 0.0;
    _0_c.green = 1.0;
    _0_c.blue = 0.0;
    _0_c.alpha = 1.0;
    return vec4(_0_c.red, _0_c.green, _0_c.blue, _0_c.alpha);
}
Implement Type cloning for enums and structs. As far as I know, there shouldn't be a way to introduce a struct or enum other than at global scope; the keywords are not accepted inside a function body. In fact, I wasn't able to find a way to exercise these code paths in practice. But we now have concrete assurance that any possible type can be cloned into a symbol table safely; all Types are either built-in (available everywhere by design) or are clonable. Change-Id: I4b006b6cab995b3e598b683736ab9689828629c9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/354664 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> 2021-01-15 20:34:10 +00:00
			`out vec4 sk_FragColor;`
Reorder GLSL output so that functions are emitted last. The Inliner likes to move function bodies around; after inlining, code can inadvertently move upwards, above ProgramElements that the code relies on. We work around this by always emitting functions last. Change-Id: Ie5486cc3a79a478920342fb9f578d575486fb4cf Bug: skia:11186 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/354669 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> 2021-01-15 20:54:02 +00:00			`struct Color {`
			`float red;`
			`float green;`
			`float blue;`
			`float alpha;`
			`};`
Run SkSL inliner tests as part of dm. Previously, these tests were never actually executed, only read during code review. They are now properly tested for correctness whenever dm is run. Non-ES2 compliant statements (do/while/switch) are unfortunately excluded here, as they are not compatible with Runtime Effects yet. Change-Id: I965c782baad6f8dd3961a400ae791fb2c1f844d3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/389296 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> 2021-03-25 21:04:36 +00:00			`vec4 main() {`
Revert "Inline functions of the form 'return (expr)' only." This reverts commit 92748af1a5051e9fe329c8200f0fa3b47aadbdd7. Reason for revert: SkSLCommaSideEffects_GPU crashing on Android Original change's description: > Inline functions of the form 'return (expr)' only. > > This drastically reduces the number of functions which we allow to be > inlined. If this change does not hurt our performance, it will allow us > to trivially remove hundreds of LOC. All current data leads us to > believe that it may affect the Mali 400 but is highly unlikely to change > results on any other device in the tree. > > More info: http://go/optimization-in-sksl-inliner > > Change-Id: Ia6b706742ce5407453e0e697b6c1f9201084c0e8 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/384858 > Auto-Submit: John Stiles <johnstiles@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> > Reviewed-by: Brian Osman <brianosman@google.com> > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I6a670dacaa58fe3386ff50375ac6d1cac4fd7f2c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/385161 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> 2021-03-15 22:08:38 +00:00			`Color _0_c;`
Run SkSL inliner tests as part of dm. Previously, these tests were never actually executed, only read during code review. They are now properly tested for correctness whenever dm is run. Non-ES2 compliant statements (do/while/switch) are unfortunately excluded here, as they are not compatible with Runtime Effects yet. Change-Id: I965c782baad6f8dd3961a400ae791fb2c1f844d3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/389296 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> 2021-03-25 21:04:36 +00:00			`_0_c.red = 0.0;`
			`_0_c.green = 1.0;`
			`_0_c.blue = 0.0;`
Revert "Inline functions of the form 'return (expr)' only." This reverts commit 92748af1a5051e9fe329c8200f0fa3b47aadbdd7. Reason for revert: SkSLCommaSideEffects_GPU crashing on Android Original change's description: > Inline functions of the form 'return (expr)' only. > > This drastically reduces the number of functions which we allow to be > inlined. If this change does not hurt our performance, it will allow us > to trivially remove hundreds of LOC. All current data leads us to > believe that it may affect the Mali 400 but is highly unlikely to change > results on any other device in the tree. > > More info: http://go/optimization-in-sksl-inliner > > Change-Id: Ia6b706742ce5407453e0e697b6c1f9201084c0e8 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/384858 > Auto-Submit: John Stiles <johnstiles@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> > Reviewed-by: Brian Osman <brianosman@google.com> > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I6a670dacaa58fe3386ff50375ac6d1cac4fd7f2c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/385161 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> 2021-03-15 22:08:38 +00:00			`_0_c.alpha = 1.0;`
Run SkSL inliner tests as part of dm. Previously, these tests were never actually executed, only read during code review. They are now properly tested for correctness whenever dm is run. Non-ES2 compliant statements (do/while/switch) are unfortunately excluded here, as they are not compatible with Runtime Effects yet. Change-Id: I965c782baad6f8dd3961a400ae791fb2c1f844d3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/389296 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> 2021-03-25 21:04:36 +00:00			`return vec4(_0_c.red, _0_c.green, _0_c.blue, _0_c.alpha);`
Implement Type cloning for enums and structs. As far as I know, there shouldn't be a way to introduce a struct or enum other than at global scope; the keywords are not accepted inside a function body. In fact, I wasn't able to find a way to exercise these code paths in practice. But we now have concrete assurance that any possible type can be cloned into a symbol table safely; all Types are either built-in (available everywhere by design) or are clonable. Change-Id: I4b006b6cab995b3e598b683736ab9689828629c9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/354664 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> 2021-01-15 20:34:10 +00:00			`}`