Revert of Try TSAN blacklist for SkGLContextHelper::init. (https://codereview.chromium.org/309823004/)
Reason for revert: the bot's clang doesn't know -fsanitize-blacklist Original issue's description: > Try TSAN blacklist for SkGLContextHelper::init. > > Submitting to test this; this particular problem only happens on the bot. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/ab2ec19b975a898d4ee2278ddad7d4268f134478 R=mtklein@chromium.org TBR=mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Author: mtklein@google.com Review URL: https://codereview.chromium.org/314543002
This commit is contained in:
parent
ab2ec19b97
commit
59ef7704f1
@ -413,7 +413,7 @@
|
||||
'conditions' : [
|
||||
[ 'skia_sanitizer == "thread"', {
|
||||
'defines': [ 'DYNAMIC_ANNOTATIONS_ENABLED=1' ],
|
||||
'cflags': [ '-fPIC', '-fsanitize-blacklist=>!(pwd)/../tools/tsan.blacklist' ],
|
||||
'cflags': [ '-fPIC' ],
|
||||
'target_conditions': [
|
||||
[ '_type == "executable"', {
|
||||
'cflags': [ '-fPIE' ],
|
||||
|
@ -1,11 +0,0 @@
|
||||
# Blacklist (compile time suppressions) for TSAN.
|
||||
#
|
||||
# CAREFUL! Comments must go on their own line or your suppressions will silently fail.
|
||||
|
||||
# skia:2459 Seemingly misdiagnosed use-after-free, having something to do with software GL drivers.
|
||||
# Having trouble getting this suppression to match.
|
||||
# We've tried: race:swrast_dri.so
|
||||
# race:SkGLContextHelper::init
|
||||
# race:SkGLContextHelper
|
||||
# So now we'll try a compile time blacklist. We'll use a file blacklist to nuke it from orbit.
|
||||
file:SkGLContextHelper.cpp
|
@ -5,6 +5,13 @@
|
||||
# WebP races (harmlessly) choosing function pointers for SIMD versions of some of its functions.
|
||||
race:third_party/externals/libwebp
|
||||
|
||||
# skia:2459 Seemingly misdiagnosed use-after-free, having something to do with software GL drivers.
|
||||
# Having trouble getting this suppression to match.
|
||||
# We've tried: race:swrast_dri.so
|
||||
# race:SkGLContextHelper::init
|
||||
# Maybe because it's diagnosed as a use-after-free, not as a race?
|
||||
race:SkGLContextHelper
|
||||
|
||||
# Threadsafe, should be ported to SkLazyPtr.
|
||||
race:SkFontHost_FreeType
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user