Reland "Remove old references to SampleApp"

This reverts commit 3ff2b20057.

Reason for revert: Infra fires are out.

Original change's description:
> Revert "Remove old references to SampleApp"
> 
> This reverts commit 1c477fc263.
> 
> Reason for revert: Botpocalypse.
> Original change's description:
> > Remove old references to SampleApp
> > 
> > Docs-Preview: https://skia.org/?cl=135570
> > Change-Id: I330ffa964c2d90ca8d3cd844aabcd8616ccd0540
> > Reviewed-on: https://skia-review.googlesource.com/135570
> > Reviewed-by: Cary Clark <caryclark@google.com>
> > Commit-Queue: Brian Osman <brianosman@google.com>
> 
> TBR=halcanary@google.com,brianosman@google.com,caryclark@google.com
> 
> Change-Id: I514e2c7bca8a1ebd311593573a94e8a078695785
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/135600
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>

TBR=halcanary@google.com,brianosman@google.com,caryclark@google.com

Change-Id: I660482ef32acecf5b1bf24d2dec919bc68fde97e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/135660
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
This commit is contained in:
Brian Osman 2018-06-18 21:09:01 +00:00 committed by Skia Commit-Bot
parent aa037523e5
commit 63b3bfb711
7 changed files with 9 additions and 25 deletions

1
.gitignore vendored
View File

@ -29,7 +29,6 @@ platform_tools/android/apps/build
platform_tools/android/apps/*.properties
platform_tools/android/apps/*/build
platform_tools/android/apps/*/src/main/libs
sampleapp_prefs.txt
/skps
third_party/externals
tools/skp/page_sets/data/*.json

View File

@ -1,14 +0,0 @@
//
// image.h
// SampleApp
//
// Created by Mike Reed on 7/27/12.
//
//
#ifndef __SampleApp__image__
#define __SampleApp__image__
#include <iostream>
#endif /* defined(__SampleApp__image__) */

View File

@ -45,10 +45,9 @@ Test code is located under the 'tests' directory.
See [Writing Unit and Rendering Tests](../testing/tests) for details.
Unit tests are best, but if your change touches rendering and you can't think of
an automated way to verify the results, consider writing a GM test or a new page
of SampleApp. Also, if your change is the GPU code, you may not be able to write
it as part of the standard unit test suite, but there are GPU-specific testing
paths you can extend.
an automated way to verify the results, consider writing a GM test. Also, if your
change is in the GPU code, you may not be able to write it as part of the standard
unit test suite, but there are GPU-specific testing paths you can extend.
Submitting a patch
------------------

View File

@ -78,12 +78,12 @@ Writing a Rendering Test
ninja -C out/Debug dm
out/Debug/dm --match newgmtest
4. Run the GM inside SampleApp:
4. Run the GM inside Viewer:
<!--?prettify lang=sh?-->
ninja -C out/Debug SampleApp
out/Debug/SampleApp --slide GM:newgmtest
ninja -C out/Debug viewer
out/Debug/viewer --slide GM_newgmtest
<span id="bench"></span>

View File

@ -158,7 +158,7 @@ The SkPicture backend uses SkPictureRecorder instead of SkSurface.
draw(recordingCanvas);
sk_sp<SkPicture> picture = recorder.finishRecordingAsPicture();
SkFILEWStream skpStream(path);
// Open SKP files with `SampleApp --picture SKP_FILE`
// Open SKP files with `viewer --skps PATH_TO_SKP --slide SKP_FILE`
picture->serialize(&skpStream);
}

View File

@ -21,7 +21,7 @@ Try It Out
----------
The tools `lua_app` and `lua_pictures` should now be available when you compile,
and `SampleApp` should now have a `Lua` sample.
and `Viewer` should now have a `Lua` sample.
To-Do

View File

@ -97,7 +97,7 @@ void SkStrokeRec::setStrokeStyle(SkScalar width, bool strokeAndFill) {
#include "SkStroke.h"
#ifdef SK_DEBUG
// enables tweaking these values at runtime from SampleApp
// enables tweaking these values at runtime from Viewer
bool gDebugStrokerErrorSet = false;
SkScalar gDebugStrokerError;
#endif