AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

remove SkDebugCanvas clip query overrides

Browse Source 
We don't think these are important, and it's looking
like overriding these methods at all is a bad idea.

While here we can remove kVizImageHeight and width too, as they're
unused.  After all these deletions the comment about methods inherited
from SkCanvas no longer applies.

Change-Id: I036eb9ccca4821516a287daec9847addd529a28c
Reviewed-on: https://skia-review.googlesource.com/76480
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
This commit is contained in:
Mike Klein 2017-11-27 16:30:35 -05:00 committed by Skia Commit-Bot
parent 3b51df1211
commit 7b093b7742
1 changed files with 0 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
tools/debugger/SkDebugCanvas.h
View File

@ -165,25 +165,6 @@ public:
Json::Value toJSONOpList(int n, SkCanvas*);
////////////////////////////////////////////////////////////////////////////////
// Inherited from SkCanvas
////////////////////////////////////////////////////////////////////////////////
static const int kVizImageHeight = 256;
static const int kVizImageWidth = 256;
bool isClipEmpty() const override { return false; }
bool isClipRect() const override { return true; }
SkRect onGetLocalClipBounds() const override {
return SkRect::MakeIWH(this->imageInfo().width(), this->imageInfo().height());
}
SkIRect onGetDeviceClipBounds() const override {
return SkIRect::MakeWH(this->imageInfo().width(), this->imageInfo().height());
}
void detachCommands(SkTDArray<SkDrawCommand*>* dst) {
fCommandVector.swap(*dst);
}