Commit Graph

56153 Commits

Author SHA1 Message Date
John Stiles
0397ae4e15 Reland "Add unit test confirming Runtime Blends match native blends."
This is a reland of 0b62a05d9a

Original change's description:
> Add unit test confirming Runtime Blends match native blends.
>
> We perform the same draw operation twice--once with a `setBlendMode`
> based blend, and then once more with `setBlender` and passing SkSL which
> is equivalent to the native blend op. If this test fails, it would
> indicate that Runtime Blends aren't being applied appropriately (or
> perhaps that a GPU's built-in blending modes are cutting corners?).
>
> Change-Id: I4ca1f9ed600d9ec733687cc6de7d3e2eb6e765c9
> Bug: skia:12080
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428318
> Auto-Submit: John Stiles <johnstiles@google.com>
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: John Stiles <johnstiles@google.com>

Bug: skia:12080
Change-Id: Idf4297314b133e5bce689a25d53063bff8469fac
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428676
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2021-07-15 15:19:14 +00:00
Brian Osman
7cf34848da Update SkSL fiddles embedded in user documentation
https://skia.org/docs/user/sksl/?cl=428878

Bug: skia:12213
Change-Id: Id85edabd0977942bd7bbd0ab3f0d3ecd85340411
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428878
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2021-07-15 15:12:31 +00:00
John Stiles
0e99fbe5da Add RuntimeBlendUtils to bazel.
This should allow http://review.skia.org/428617 to reland.

Change-Id: I85a79951c687323b97784d3a606dba2eaa3fd420
Bug: skia:12080
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428619
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2021-07-15 15:01:32 +00:00
recipe-roller
dd561d0214 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools) into this repository.

depot_tools:
48c947534d
  48c9475 (sokcevic@google.com)
      Add presubmit notice if buganizer bug is malformed

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5aab6b08e015cebc4dd5777dba19f8379952bbf7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428816
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-15 12:21:34 +00:00
Ben Wagner
7dc26fadc9 Call hb_face_count before hb_face_create
As pointed out at https://github.com/harfbuzz/harfbuzz/issues/248 one
should call hb_face_count to do a sanitizer check before calling
hb_face_create.

Change-Id: I71795962a027188d702274f84e3bfa6c15fcd130
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428322
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2021-07-15 12:08:25 +00:00
Chris Dalton
2346aa0ee1 Stabilize the path bounds logic in tryAddPathToAtlas()
Accounts for empty, negative, NaN, and bounds that overflow an int
before attempting to add the path to an atlas.

Bug: chromium:1229463
Change-Id: I612b590e8102db359e06a7963c72e1958b82abc9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428699
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Justin Novosad <junov@google.com>
2021-07-15 07:16:05 +00:00
skia-autoroll
7d336c9557 Roll Chromium from 378115c18d5c to 17781a5cd82e (457 revisions)
378115c18d..17781a5cd8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC johnstiles@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: johnstiles@google.com
Change-Id: Iffe2b765824ab7ff5185658add00febd4644a9a5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428717
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-15 05:07:23 +00:00
skia-autoroll
dc2fa65671 Roll ANGLE from 2534ee4c5b9d to db54b8dd65ed (16 revisions)
2534ee4c5b..db54b8dd65

2021-07-14 m.maiya@samsung.com Add YUV format support to frontend
2021-07-14 m.maiya@samsung.com D3D: Update format table with new YUV formats
2021-07-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 015a6f8b338d to a03f2d365426 (30 revisions)
2021-07-14 m.maiya@samsung.com Vulkan: Add GL_ANGLE_yuv_internal_format extension
2021-07-14 cnorthrop@google.com Skip SourceAHBTarget2DExternalCycleThroughYuvTargetsNoData P4+VK
2021-07-14 syoussefi@chromium.org Vulkan: SPIR-V Gen: Add missing SampleRateShading capability
2021-07-14 m.maiya@samsung.com Vulkan: Handle incompatible immutable sampler formats
2021-07-14 jmadill@chromium.org Add environment variable args to trigger script.
2021-07-14 m.maiya@samsung.com Vulkan: Account for immutable samplers that need multiple descriptors
2021-07-14 cnorthrop@google.com Skip SimpleStateChangeTest.RedefineFramebufferTexture on NV+WIN
2021-07-14 jmadill@chromium.org Download rc binaries for win cross-compile.
2021-07-14 cheryl.wei@arm.com Vulkan: Translate border color's channel by image view format
2021-07-14 pkasting@chromium.org Roll third_party/glmark2/src/ 9e01aef1a..ca8de51fe (52 commits)
2021-07-14 syoussefi@chromium.org Vulkan: SPIR-V Gen: Enable GLSLTest*
2021-07-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 4716eec90fcb to ba18c78e4696 (1 revision)
2021-07-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 624f8c7a15ff to 47358b0400b8 (511 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC johnstiles@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: johnstiles@google.com
Test: Test: ImageTest.SourceAHBTarget2DExternalCycleThroughYuvTargetsNoData*Vulkan
Test: Test: SourceAHBTarget2DExternalCycleThroughYuvTargetsNoData
Change-Id: Id51376c6c2f50de468bb7492ef3008ac552fa121
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428718
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-15 04:57:23 +00:00
Chris Dalton
0196a72318 Fix AAStrokeRectOp viewport clipping for nested rects
The code analyzes the nested rects in order to surmise stroke sizes.
When we clipped the nested rects before deducing a stroke size, it
led to a stroke size of 0 which made coverage 0 all throughout.

This CL changes the code to figure a stroke size before clipping, and
to outset the clip for the outer rect by the stroke size.

TBR=bsalomon@google.com

Bug: skia:12211
Change-Id: I15dde092df9b0cbd56c6023b91cd2d3430fde10a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428656
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-07-15 03:32:26 +00:00
Mike Reed
0547b914f6 Revert "Add unit test confirming Runtime Blends match native blends."
This reverts commit 0b62a05d9a.

Reason for revert: GetRuntimeBlendForBlendMode not found in google3

Does the new file that contains that not appear in google3's build?

Original change's description:
> Add unit test confirming Runtime Blends match native blends.
>
> We perform the same draw operation twice--once with a `setBlendMode`
> based blend, and then once more with `setBlender` and passing SkSL which
> is equivalent to the native blend op. If this test fails, it would
> indicate that Runtime Blends aren't being applied appropriately (or
> perhaps that a GPU's built-in blending modes are cutting corners?).
>
> Change-Id: I4ca1f9ed600d9ec733687cc6de7d3e2eb6e765c9
> Bug: skia:12080
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428318
> Auto-Submit: John Stiles <johnstiles@google.com>
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: John Stiles <johnstiles@google.com>

TBR=brianosman@google.com,reed@google.com,johnstiles@google.com

Change-Id: Idd5ca97cfc4b642d3f97fdbd1fe9bd108b56e3a6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:12080
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428617
Reviewed-by: Mike Reed <reed@google.com>
2021-07-15 00:50:14 +00:00
recipe-roller
04beaa0041 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools, recipe_engine) into this repository.

depot_tools:
1c7ef58cba~..cfac2ea76b00620545717667305e78179a8fb390
  1c7ef58 (gbeaty@chromium.org)
      [lucicfg] Update v1.26.0 -> v1.27.0.
  cfac2ea (chinmaygarde@google.com)
      Add fetch recipe for the Flutter Engine repository.

recipe_engine:
352f1cce5e
  352f1cc (yiwzhang@google.com)
      py3: introduce log-level argument and set level to error for te...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifaf4dbbc273ff22081622a5941105503f3d4da8d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428479
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-15 00:37:53 +00:00
Chris Dalton
9081276b29 Fix an assert in attemptQuadOptimization
Change-Id: I076df1ee83e6be6cbb61c01e48d848fa25f179cd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428478
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-07-15 00:21:22 +00:00
John Stiles
0b62a05d9a Add unit test confirming Runtime Blends match native blends.
We perform the same draw operation twice--once with a `setBlendMode`
based blend, and then once more with `setBlender` and passing SkSL which
is equivalent to the native blend op. If this test fails, it would
indicate that Runtime Blends aren't being applied appropriately (or
perhaps that a GPU's built-in blending modes are cutting corners?).

Change-Id: I4ca1f9ed600d9ec733687cc6de7d3e2eb6e765c9
Bug: skia:12080
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428318
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2021-07-14 21:51:03 +00:00
Chris Dalton
97f8590a80 Make AAStrokeRectOp compatible with DMSAA
Extends the outsets and insets in order to guarantee a full sample
mask on pixels with partial coverage. Due to skia:12206, we only
render miter stroks this way when using DMSAA.

Bug: skia:11396
Bug: skia:12206
Change-Id: I2d429b59a781d59861cd2fd2ee008076ec6e1e27
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428016
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2021-07-14 21:20:24 +00:00
Chris Dalton
4f489100b4 Clip AAStrokeRectOp to viewport boundaries
This avoids interpolation precision issues with very large
coordinates.

Bug: skia:11396
Change-Id: I969a5c7dbd606db5fbbe8ddab775d058f243b9a7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428281
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2021-07-14 21:19:35 +00:00
Chris Dalton
f08520e697 Drop support for disabling multisample on Mac
We have historically supported non-AA draws to MSAA targets by disabling
GL_MUlTISAMPLE. This only worked on some platforms though, since
disabling multisample isn't generally supported on GLES, Vulkan, or
Metal. In addition to being inconsistent across platforms, toggling
multisample also appears to be a de-optimization at best, and a
spectacular regression at worst.

This CL lowers the set of platforms that support multisample disable and
quits supporting it on Mac. In the near future we can hopefully drop
support completely.

Bug: skia:12196
Change-Id: I8c005c92b408ceb9740d809a84ae79abb8c79ef7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427087
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-07-14 21:15:48 +00:00
Brian Salomon
f6c0d833c6 GrGLSLGeometryProcessor produces a map FP -> varying coords.
Removes the FPCoordTransformHandler that required code to iterate
FPs in the same order as GLSLGP when accessing varyings stored in
and array.

Bug: skia:12198
Change-Id: Ie906b56491bafd76778b241e5ec95b0b253364b6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428197
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2021-07-14 21:04:43 +00:00
Chris Dalton
947a2eb3c0 Don't disable multisample for rendering text
Bug: skia:12196
Change-Id: I9fe942074c53dd1e230fa4cd10cee841a90878e4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428477
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-07-14 21:00:13 +00:00
Chris Dalton
3febc61414 Revert "Add an isinf() polyfill for tessellation shaders"
This reverts commit 6904303a66.

Reason for revert: I don't trust it

Original change's description:
> Add an isinf() polyfill for tessellation shaders
>
> Tessellation uses infinity to flag conics, and also as a conic weight
> that converts them into triangles. The es2 shading language doesn't
> support infinity. This CL adds a "portable infinity" mode, where we
> pretend inputs >= 2^126 are infinity. The rationale for doing this is
> that those numbers are so large, they will overflow if we try to do any
> bezier math with then anyway.
>
> Bug: chromium:1220246
> Change-Id: I3ad29ebb6fbbad5d23cfdba7a2717605009f8180
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/423697
> Commit-Queue: Chris Dalton <csmartdalton@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:1220246
Change-Id: I1e8f555b766118a49987fd4c5ea150b59b07c1e9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427920
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-07-14 20:50:53 +00:00
Chris Dalton
52b6f0dc03 Restore attemptQuadOptimization() before GrFillRRectOp
It looks like there are still optimizations here that we can benefit
from, including, but not limited to draws as clears. We should figure
out how to incorporate them into the new clipToShape() approach before
we quit calling attemptQuadOptimization().

Change-Id: I1a6380593c383ad11f0c346ae44077ed0e6d6cd2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428376
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-07-14 20:48:17 +00:00
John Stiles
b5ac66c874 Add utility function GetRuntimeBlendForBlendMode for testing.
This will help us write tests confirming that runtime blends work the
same as the built-in blends.

Change-Id: I2f94aa7bbbc7124d09b490fc7509a4c281025307
Bug: skia:12080
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427618
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
2021-07-14 20:39:09 +00:00
recipe-roller
e7b316f150 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
325823c861
  325823c (yiwzhang@google.com)
      Revert "Support running different py version simulation recipe...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If2b8763d10690c8d1c5a4eacc6290d89aa97773e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428476
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-14 20:26:18 +00:00
recipe-roller
9ce3cfb8ce Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
6254729dfa
  6254729 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 4f6853eb883e to 5639b9acf1cf

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia34ba42ce1831cea15c1c08c3da523c7e531a5b7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428282
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-14 19:26:58 +00:00
skia-autoroll
e293d2cdaa Roll SK Tool from e2696256b252 to af23468c7173
https://skia.googlesource.com/buildbot.git/+log/e2696256b252..af23468c7173

2021-07-14 borenet@google.com [sk] Use LUCI_CONTEXT for auth with --ci

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/sk-tool-skia
Please CC rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: rmistry@google.com
Change-Id: I1f0443fe8a328a0a6222b87245df10e5e87c8955
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/428356
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-14 18:40:18 +00:00
Chris Dalton
36c1804e8f Don't disable multisample for GrDashLinePathRenderer
We've concluded that disabling multisample for coverage ops is too
slow. If we decide DashOp is triggering DMSAA too often we can update
the coverage version to be DMSAA compatible.

Bug: skia:11396
Change-Id: I7d23fb391ecd1695ab379ed7cf0b784d5491b7d0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427978
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-07-14 16:50:48 +00:00
Chris Dalton
773a0b8c7e Use stencil clips when DMSAA is supported
Never use SW masks if we can use DMSAA instead.

Bug: skia:11396
Change-Id: I44b09e352b62bd5979586fb6b9db033dd058034f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/421196
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-07-14 16:10:58 +00:00
Chris Dalton
bdc2cd0744 Don't let interior AAStrokeRectOp edges cross
Fixes an issue where the interior AA edges of AAStrokeRectOp could
cross over one another, leading to double blends and incorrect
coverage.

Bug: skia:11396
Change-Id: I063defdc9b0691bdd39bc8515fe8a40bac9d29f5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427977
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2021-07-14 16:10:08 +00:00
Chris Dalton
3ee0dc6366 Bail on AAStrokeRectOp if there are unequal, subpixel stroke widths
Unequal, subpixel stroke widths had a known rendering issue that we
just accepted. But with DMSAA compatibility coming up, these will
potentially pop visually when turning MSAA on and off. Fall back on
path rendering in this case.

A side effect of this change is that the insets and outsets are now
always equal in X and Y, so we also update the vertex generation code
to not distinguish between X and Y.

Bug: skia:11396
Change-Id: Iaf0ce73c228ad67e55aa5c004dbdf18bb2134594
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427976
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-07-14 16:08:38 +00:00
Ethan Nicholas
292a09da2b Added modifier support to DSLFunction
This also includes a couple of fixes to DSLFunction error reporting.

Change-Id: Iab813143511c408df2dba7a4dc8beddea1a8e8d0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427736
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
2021-07-14 14:46:01 +00:00
Brian Salomon
6b7ec00e6e Add GrGLSLVarying helpers to use a varying as a FS or VS GrShaderVar.
No functional change.

Bug: skia:12198
Change-Id: I1a740b2dd0cdf397e4f7d112d16babf76bb2bd04
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427156
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2021-07-14 13:54:31 +00:00
Brian Salomon
2422ca10c2 Limit PowerVRRougue shader derivative workaround by driver version
The shader optimization bug has been fixed in newer drivers.

Bug: b/187364475
Bug: chromium:1197152
Change-Id: I013d022cc0d8a4b4739160c3e651b3ce06ee5f19
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/425838
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2021-07-14 13:27:31 +00:00
recipe-roller
d421a286df Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
b19a7cff1f~..18422f74521de6b2e90662da4ead0ed7658804c1
  b19a7cf (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 85c67b7d0c82 to e752f86b547f
  49a75e4 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from e752f86b547f to 65be0057a340
  9f2785a (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 65be0057a340 to 3d789cb7015d
  18422f7 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 3d789cb7015d to f0a9c0d3581d

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idb7d1c163847b753a74ebcb1e1289457844d9d2a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427919
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-14 09:12:50 +00:00
recipe-roller
db9d72bf30 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
ba214b26f2~..9abd49c5d5da6c875b6248f2af550d4c7d75134a
  ba214b2 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 203cb395f544 to 6fc8fe004333
  9abd49c (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from aab2a427798e to 85c67b7d0c82

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If31cda210f5941bc5ab486c7a28557c5ab30c3e7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427918
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-14 08:13:30 +00:00
recipe-roller
a899d9a2ab Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
2a07fb5ef3~..12ff2c11d3cbfd3fe160c63c6724c03329eaff6e
  2a07fb5 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from c7e76900f921 to 454a270ae9a7
  12ff2c1 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 8c6653b7da21 to 203cb395f544

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5fc65234967f2f8d67bf979b1acd09f748a11173
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427917
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-14 07:06:31 +00:00
recipe-roller
be219ba963 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
1cbd70e0ea~..b616d06f76c67726539b060623700e8f8963ff4f
  1cbd70e (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from cac64efd7c7f to bb4ea977b407
  b616d06 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from bb4ea977b407 to 9202966ea7f8

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I008155d34829d159b44044acabce68753033c350
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427916
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-14 06:18:50 +00:00
skia-autoroll
b1df965996 Roll Chromium from 3572711a2c6a to 378115c18d5c (529 revisions)
3572711a2c..378115c18d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC johnstiles@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia/skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Tbr: johnstiles@google.com
Change-Id: I15d2ddaa0d121cc3afe6efb9f972fb9c72621cb9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427861
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-14 05:30:20 +00:00
recipe-roller
2648bc43e4 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
c404bde3fc~..42c04e369ba736465dff88b445b40988ba670742
  c404bde (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 6641f431901a to 2d0702d307af
  c93d7c7 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 41677fd6311e to bb07be0d431c
  42c04e3 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from e7d1c8fb870b to c520a6993f12

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I49d15f3b7cbfa739beec7144f79149f7df692ebb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427843
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-14 05:27:30 +00:00
skia-autoroll
5fd32ec71e Roll SwiftShader from 4716eec90fcb to ba18c78e4696 (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/4716eec90fcb..ba18c78e4696

2021-07-13 thakis@chromium.org Define NO_SANITIZE_FUNCTION on win/clang too

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC johnstiles@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
Tbr: johnstiles@google.com
Change-Id: I86440c7e323b2a6f1dcf25fb3e8ab936a0d4c7e2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427859
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-14 04:59:40 +00:00
skia-autoroll
71d90cf280 Roll ANGLE from a8e98a238521 to 2534ee4c5b9d (11 revisions)
a8e98a2385..2534ee4c5b

2021-07-14 kbr@chromium.org Limit the size of declared variables in WebGL shaders.
2021-07-14 kbr@chromium.org Fix iOS Simulator build after direct-to-Metal upstreaming.
2021-07-13 jiajia.qin@intel.com Fix the INVALID_ENUM error
2021-07-13 kbr@chromium.org Use "frameworks" rather than "libs" for iOS dependencies.
2021-07-13 cnorthrop@google.com Skip SourceYUVAHBTargetExternalRGBSampleInitData on Pixel4
2021-07-13 natsu@google.com Vulkan: update D/S state in ContextVk::onFramebufferChange
2021-07-13 jonahr@google.com Suppress BlitFramebufferTest.MultisampleDepth on Metal
2021-07-13 timvp@google.com Cleanup license data and remove Android.mk files
2021-07-13 cnorthrop@google.com TracePerfTests: Add ScreenShotFrame option
2021-07-13 jonahr@google.com GL: Widen scope of disable_sync_control_support workaround.
2021-07-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 7d1a6713a379 to 624f8c7a15ff (526 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC johnstiles@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Tbr: johnstiles@google.com
Test: Test: SourceYUVAHBTargetExternalRGBSampleInitData
Change-Id: I0858a0de1bf8612d07fb3fe8f526ef09e35d3ed1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427858
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2021-07-14 04:54:20 +00:00
recipe-roller
8ac703de8c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
e94ab775a0~..2d544e44a68492f5ad8502b60f065dc0eef2f417
  e94ab77 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 90ec6154778b to 647e189404be
  2d544e4 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 647e189404be to 6641f431901a

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I924daf2096d9b739f4e33a045626c7a9c5fa5364
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427840
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-14 04:26:00 +00:00
recipe-roller
662edc0343 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
779f420ee4~..fc1a279b59d11be93ec932dc82ff9f1a69a5e59e
  779f420 (yiwzhang@google.com)
      py3: write final build after encode to bytes
  fc1a279 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from cce17a1c9de7 to daf8d357b17b

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I21a96d20f83d826b12646aacc928bd0dd11fee6c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427837
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-14 03:20:50 +00:00
recipe-roller
97dba83632 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (depot_tools, recipe_engine) into this repository.

depot_tools:
d5c4633772
  d5c4633 (gbeaty@chromium.org)
      Switch to absolute refs in recipes.cfg.

recipe_engine:
da7f6914c0~..2442d397bc7f451a80affc8aef7554e364fe96a0
  da7f691 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 6d46e979bf82 to 7c0d27d44d43
  2442d39 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 7c0d27d44d43 to 973fb4ea919a

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I529250431f8afb36519df9ddd080ff049af24ad0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427777
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-14 00:32:30 +00:00
recipe-roller
9be70acd26 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
c442abe17a
  c442abe (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 5c22e8e1f3bb to 8b8a9a6040ca

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1882afed273320e0b6db7b7692b9eb623cdb42b5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427776
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-13 23:29:23 +00:00
recipe-roller
9847fe79d9 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
ab261a3f93~..4c0c173629f06ff56252aed5f9fdd39f2af3bfd3
  ab261a3 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from f39c1f9769da to f3add13b9377
  4c0c173 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from f3add13b9377 to 00de4eb9ddb1

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I38ed2be81b42f938987ea3b4d90624725d360702
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427552
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-13 22:24:00 +00:00
Chris Dalton
25da4062d5 Make elliptical ops in GrOvalOpFactory compatible with DMSAA
Detects MSAA and increases the AA bloat in order to guarantee every
pixel with nonzero coverage has a full sample mask. Starts using the
oval ops from GrSurfaceDrawContext when DMSAA is available.

Bug: skia:11396
Change-Id: I83c029e7a711da62cfec6f5a1c6df249c131fa22
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427637
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2021-07-13 22:11:35 +00:00
Chris Dalton
8cb159b504 Never disable multisample with DMSAA
DMSAA used to disable multisample in order to use coverage ops, but it
turns out that disabling multisample while rendering to an MSAA target
is very expensive. This CL updates DMSAA to always prefer the MSAA op
unless a coverage version exists that also knows how to render when
multisampling is enabled. We will follow it up with updates to
coverage ops that make them MSAA compatible.

Bug: skia:11396
Change-Id: I8e4ea763710d96593e08877b100eb7777268d7eb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427657
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2021-07-13 21:58:30 +00:00
recipe-roller
03a2d276ea Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
0b9ac35680~..acda420147fd87401ae5ee1d726ae066aff71167
  0b9ac35 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from f64317bee9e6 to ac9bf6631ffc
  acda420 (yiwzhang@google.com)
      py3: make a few modules py3 compatible

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2fc289e0291d1e375f52bdab0e151b54dcdb0bc0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427656
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2021-07-13 21:23:51 +00:00
Julia Lavrova
3cf050bba6 Fixing placeholder position
Bug: skia:12130
Change-Id: Iac2f4f1799f054694d33259f31d1216aa040c5e0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/426923
Commit-Queue: Julia Lavrova <jlavrova@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2021-07-13 20:47:50 +00:00
Jim Van Verth
054126580d Use attachment in GrMtlTexture rather than raw id<MTLTexture>.
Adds methods for creating GrMtlAttachment for textures and wrapped
textures.

Bug: skia:12186
Change-Id: Iaf89c4a57bdb4af25f4086581be190ae6faf0d31
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427199
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2021-07-13 20:47:40 +00:00
Michael Ludwig
8115997316 Check hairline after resolving edge flags
Change-Id: Ib0682649d298317b3bcd8c50ca473bb6351fd55b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/427616
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>
2021-07-13 20:33:30 +00:00