Commit Graph

42072 Commits

Author SHA1 Message Date
recipe-roller
063b5d7b9e Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/55b0c542ede5a3ed4e93c0c844559ea74790e5ea cq: expose api.cq.props_for_child_build property. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ied7ebcd8ac958f91d99593eaee2d6761dcf921dd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216685
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-05-29 21:00:03 +00:00
Greg Daniel
b3f82dddfc Reland "Remove call to copy in GrcontextPriv read/write pixel calls."
This reverts commit 1013ecfb34.

Reason for revert: relanding with fix

Original change's description:
> Revert "Remove call to copy in GrcontextPriv read/write pixel calls."
>
> This reverts commit d0d66fb8be.
>
> Reason for revert: crashing on readpixels on some android bots
>
> Original change's description:
> > Remove call to copy in GrcontextPriv read/write pixel calls.
> >
> > Instead we just directly do all those copies as draws.
> >
> > Change-Id: I0cd9dfc6f96e35fbbc9c153a28a08eebf1d7b77f
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216356
> > Commit-Queue: Greg Daniel <egdaniel@google.com>
> > Reviewed-by: Brian Salomon <bsalomon@google.com>
> > Reviewed-by: Robert Phillips <robertphillips@google.com>
>
> TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com
>
> Change-Id: I2b39564e0b20cf83e21744c91ee8ddb9d988ab22
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216608
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Greg Daniel <egdaniel@google.com>

TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com

Change-Id: Ic5a8d453efbfe38cd6cb1a95c504b10ef8a9cf22
No-Presubmit: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216615
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2019-05-29 20:32:32 +00:00
Brian Osman
909231c8de Interpreter: Matrix/Vector multiplication
Change-Id: I3dc5e5be1cf12c581cce3854d0db7e73db6e1fd9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216681
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2019-05-29 20:32:31 +00:00
Brian Osman
1e855b22b7 Interpreter: Support component-wise ops for matrices
The linear algebra cases are more complex, coming in separate CL.

Change-Id: I5bbc25a126b61eee6f5b9775ab142e103c00f837
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216612
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-05-29 20:24:02 +00:00
recipe-roller
21399d0407 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/edb73a793557dcbdfe6854f27d90d3d488fa04ec Make nested parent steps have strict scope. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6e3e6923511c17206e48dcf9689779b231e905e1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216678
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-05-29 20:21:51 +00:00
Mike Reed
210a28a8cf rm dead code
Change-Id: I2829d94451ce0278b44b98ca0195d04124b669fb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216682
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Auto-Submit: Mike Reed <reed@google.com>
2019-05-29 20:09:04 +00:00
recipe-roller
9f01b30841 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/96104d42dad1ff62acc4aa58540286690ea4a34a [cipd] Update lucicfg 1.7.7 => 1.7.8. (vadimsh@chromium.org)
recipe_engine:
  https://crrev.com/8b16a36e64065fb9a59237d9cbeb1b4123910e8f json: api.json.loads as test_api.json.loads. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia8588c328c3af183b091d7b2163c8b6cade11c8f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216617
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-05-29 19:50:31 +00:00
Herb Derby
405735228f Compare pixels for TypefaceWithNoPaths test
Change-Id: I786b741462ca2b68b43e5f3443671c4a7e2f801f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216614
Reviewed-by: Khushal Sagar <khushalsagar@chromium.org>
Commit-Queue: Herb Derby <herb@google.com>
2019-05-29 19:37:51 +00:00
Michael Ludwig
aa1b6b36a4 Make stencilRect() in GrRTCPriv more flexible.
All GrFillRectOps in core code go through a GrRTC call.

Also adds a utility constructor for non-AA rects since this simplifies clears
and tests/GMs that called GrFillRectOp directly. This helps preserve
readability without forcing them to go through the full rect drawing pipeline.

Change-Id: I6694c1aded3b89d773a897c483f7f2a51b06e6e8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/215089
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-05-29 19:30:31 +00:00
Brian Osman
7df8fff2a3 Avoid SkTMax in sksl
Change-Id: Id549b9a398b7fe52b08b89c0d50db79953434ba5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216616
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-05-29 19:02:21 +00:00
Robert Phillips
e3bd673fbf Use GrGLGpu::createTextureImpl from w/in GrGLGpu::createBackendTexture
In general we want to have one way to create textures which is shared by the two use cases (i.e., Skia proper and explicit allocation API).
This brings the two paths (i.e., createBackendTexture and onCreateTexture) into closer alignment.

Change-Id: I176a6ebdc6e8634d3aaa59d440b2099df2bd6eff
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216613
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-05-29 18:56:31 +00:00
Mike Reed
f97e8e961b simplify api to make encoder, use swscale for faster rgb->yuv
Change-Id: I19ea48667aa843e1166231fe8d2622af91cce972
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216611
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2019-05-29 17:59:18 +00:00
Brian Osman
16e6fd53a1 Interpreter: Fix vector/matrix equality and inequality
Need to compare all elements, then fold the result to a single bool.

Change-Id: I0ebfaa9d518f29a782701246ada247cb55c01c2e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216607
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-05-29 17:42:58 +00:00
Brian Salomon
a86fc7a63b Specialize GrBicubicEffet for 1d kernel.
This saves texture reads when we need to scale in x or y but not both
when doing an async rescale and read.

Change-Id: I9e3550585875a1b42db7a2a7bb8bfacf3e840a01
Bug: skia:8962
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216520
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-05-29 17:38:16 +00:00
Greg Daniel
1013ecfb34 Revert "Remove call to copy in GrcontextPriv read/write pixel calls."
This reverts commit d0d66fb8be.

Reason for revert: crashing on readpixels on some android bots

Original change's description:
> Remove call to copy in GrcontextPriv read/write pixel calls.
> 
> Instead we just directly do all those copies as draws.
> 
> Change-Id: I0cd9dfc6f96e35fbbc9c153a28a08eebf1d7b77f
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216356
> Commit-Queue: Greg Daniel <egdaniel@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Reviewed-by: Robert Phillips <robertphillips@google.com>

TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com

Change-Id: I2b39564e0b20cf83e21744c91ee8ddb9d988ab22
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216608
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2019-05-29 16:17:34 +00:00
Stephen White
8a3c059796 GrTessellator: fix event creation for dead boundary edges.
In some cases, an overlap boundary edge can be nulled out by the creation
of a skeleton edge. In that case, we should avoid trying to create
parallel edge events from that dead edge.

This required making the tessellator verb maximum verb count modifiable
at runtime for testing, since the test case has more than 10 vertices.

Also added more logging.

BUG: 966696
Change-Id: I429735999f6297655311485bc68d732b1c48bfce
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216284
Commit-Queue: Stephen White <senorblanco@chromium.org>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-05-29 15:51:25 +00:00
Greg Daniel
d0d66fb8be Remove call to copy in GrcontextPriv read/write pixel calls.
Instead we just directly do all those copies as draws.

Change-Id: I0cd9dfc6f96e35fbbc9c153a28a08eebf1d7b77f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216356
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-05-29 15:13:25 +00:00
Brian Osman
29e013deb4 Interpreter: Fix construction of Matrices
Per GLSL, constructing a matrix from a scalar produces a matrix
with the scalar value along the diagonal, and zero elsewhere.
Constructing a matrix from another matrix copies the overlapping
values, and fills in the remainder with the identity matrix.

Doing either of these with existing opcodes was going to be quite
verbose and tricky, so I just made new opcodes.

I've also got some (currently disabled) test cases for other
matrix behavior, all of which fail in various ways today.

Change-Id: Ia86a183395f1ac7e2f23ee1d6bb4af461f5ba93a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/215823
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-05-29 13:03:02 +00:00
Brian Salomon
c7e9f78d10 Change async rescale and read GM to test diff number of x/y bicubic steps
Change-Id: I18db9602aa7d158aebd9549f393740229057b92b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216500
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-05-29 12:37:31 +00:00
Herb Derby
bfa8767bb2 Move source space fallback strike calculations to SkStrikeSpecStorage
This will move the cache to source ration onto the SkStrikeSpecStorage
instead of passing it along as an extra parameter.

Change-Id: Ie19665c8cd8f02798f9ea75d421a4c9337eb1f37
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216358
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2019-05-29 12:36:02 +00:00
skia-autoroll
633db4db76 Roll third_party/externals/angle2 3fe06eb3aaaf..ded5f903261a (12 commits)
3fe06eb3aa..ded5f90326


git log 3fe06eb3aaaf..ded5f903261a --date=short --no-merges --format='%ad %ae %s'
2019-05-28 geofflang@chromium.org Vulkan: Make the Vulkan renderer thread safe.
2019-05-28 geofflang@chromium.org Vulkan: Use atomics in SerialFactory.
2019-05-28 jmadill@chromium.org D3D11: Suppress failing Texture test on AMD.
2019-05-28 geofflang@chromium.org Vulkan: Move command graph and garbage to ContextVk.
2019-05-28 jonahr@google.com Addition of dEQP "KHR" test variants to generate_stats
2019-05-28 geofflang@chromium.org GL: Allow BlitGL to copy from external textures.
2019-05-28 geofflang@chromium.org D3D: Use the ProgramD3D::GetExecutableTask context for loading program binaries
2019-05-28 syoussefi@chromium.org Vulkan: Have a cubemap as 2D-array view handy
2019-05-28 jonahr@google.com Cleanup Features headers.
2019-05-28 aleino@nvidia.com Use D3D11 GetDimensions driver workaround for 2D array textures
2019-05-28 aleino@nvidia.com Test D3D11 GetDimensions driver workaround for textureProjOffset
2019-05-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 42abaa099aab..6c7db9c63098 (3 commits)


Created with:
  gclient setdep -r third_party/externals/angle2@ded5f903261a

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=kjlubick@google.com

Change-Id: Ic6e1d6e41c7d87eeaa1c31ee560a544d7c0a3129
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216562
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-05-29 06:06:02 +00:00
recipe-roller
2b650797a9 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/2ee83757a109f65cd4e831b257385a258f99c9d5 [autoninja] use custom status in non-windows too (tikuta@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I671e6f5d709d3699fb05fca25c07d2f8e5d0b5cb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216569
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-05-29 05:39:21 +00:00
skia-autoroll
bdb2d67a91 Roll ../src a4545bae034e..b3e0873d64ad (467 commits)
a4545bae03..b3e0873d64


Created with:
  gclient setdep -r ../src@b3e0873d64

The AutoRoll server is located here: https://autoroll.skia.org/r/chromium-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
TBR=kjlubick@google.com

Change-Id: I901fad2d92f444842e104652f06c9e43a5789e20
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216563
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-05-29 05:17:31 +00:00
skia-autoroll
00365de163 Roll third_party/externals/swiftshader 710fcd517ea4..ca8e3d7c153e (23 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/710fcd517ea4..ca8e3d7c153e


git log 710fcd517ea4..ca8e3d7c153e --date=short --no-merges --format='%ad %ae %s'
2019-05-28 bclayton@google.com Reactor: Fix printing of small integer values.
2019-05-28 bclayton@google.com SpirvShader: Correctly handle phi values in the loop merge
2019-05-28 bclayton@google.com SpirvShader: Simplify the logic around the generation of the inner loop.
2019-05-28 bclayton@google.com LLVMReactor: Mutex calls to llvm::orc::IRCompileLayer.
2019-05-28 bclayton@google.com Reactor: Add UInt4 constructors taking UInt
2019-05-28 bclayton@google.com Reactor: Fix all memory leaks with rr::DebugInfo.
2019-05-28 chrisforbes@google.com Fix accidentally considering Workgroup to be explicit layout
2019-05-28 bclayton@google.com Reactor: Add swizzle op for UInt4.
2019-05-28 capn@google.com Support images with linear tiling for transfers
2019-05-28 capn@google.com Implement Y′CbCr conversion
2019-05-28 capn@google.com Fix single-plane views of YCbCr formats
2019-05-28 capn@google.com Refactor writing texture level descriptor info
2019-05-28 capn@google.com Take the plane/aspect into account when copying/blitting
2019-05-28 capn@google.com Implement VkSamplerYcbcrConversion object
2019-05-28 capn@google.com Claim support for YCbCr 3- and 2-plane 420 format
2019-05-28 capn@google.com Allow additional info to be passed to object's Create functions
2019-05-28 capn@google.com Add 8-bit YCbCr 420 format info
2019-05-28 capn@google.com Refactor obtaining format aspect info
2019-05-28 capn@google.com Implement OpImageGather
2019-05-28 capn@google.com Refactor texel names
2019-05-28 capn@google.com Fix taking the sampling instruction type into account
2019-05-28 capn@google.com Fix interpolating z when using FragCoord builtin
2019-05-28 swiftshader.regress@gmail.com Regres: Update test lists @ 710fcd51


Created with:
  gclient setdep -r third_party/externals/swiftshader@ca8e3d7c153e

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=kjlubick@google.com

Change-Id: I452dcc6f9eedb321519f7f0f3b5ebd6ed60eb96a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216561
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-05-29 04:56:51 +00:00
Herb Derby
25b63f91b3 Remove getGlyphIDAdvance() from SkStrike's API
Change-Id: Id9648dfc44ec7bc7f37a281236ff5fc756f6e646
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/215610
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-05-29 03:25:21 +00:00
recipe-roller
c573ec8ab2 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/d90d37f751848195850d2af1a300d9c95dd2a2b8 Remove unused name_prefix complexity. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I05692518a156e8b4110d650cd661cead3e83c4bb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216494
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-05-29 01:53:31 +00:00
recipe-roller
8f88b2da05 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/602401825b619e4adc75eed4eee2c38c952661ae cipd: Update lucicfg to 1.7.7. (maruel@chromium.org)
recipe_engine:
  https://crrev.com/295d478e0b3dc060e50fdba37edbf6552cc8796c Make recipe engine unit tests less flaky. (iannucci@chromium.org)
  https://crrev.com/29f83f0b60ed4debf5349aaa91019200a7a19357 cq: add .experimental and .top_level properties. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie37234e6b3aa4db7978d68261d5a014d284df155
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216489
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-05-29 01:05:49 +00:00
recipe-roller
66661df8e9 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/21625832430557848a1bb6336f10bd4a86e0ac78 [post_process] Make output_properties have decoded values. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I511bba6a950b88f245859bd99182ba1ef8a33758
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216481
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-05-28 22:42:49 +00:00
recipe-roller
03cab027d8 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/314e30187959f6a98d1f1498690c8537711cf0af cipd: remove windows-386 (maruel@chromium.org)
  https://crrev.com/374de57e57ae4e7151f62021f14247ad272cb808 Revert "cipd: remove windows-386" (iannucci@chromium.org)
recipe_engine:
  https://crrev.com/c4450432fa4f62e6ae7fd530d596dec6a43bd701 Automate copying cq.proto to recipe engine. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia412811bf0c951bc05310c642747ad2e0192a1ac
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216460
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-05-28 22:09:04 +00:00
Florin Malita
1f02e84885 [skottie] Add support for more font weights
Also shuffle the search order to better match use frequency.

Change-Id: I8ba7f5474f0937aecb75215a1129b439f89a7dbf
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216357
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-05-28 21:11:21 +00:00
recipe-roller
9bba7260a5 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/03e509d455281ec684552595e49b77e66bca6c70 Add --no-emoji flag to simulation tests. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7fcbdd4ccc835551b96cef22534aac1ec3dc60b3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216444
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-05-28 20:42:07 +00:00
Mike Reed
c0ee21feb8 skia helper for encoding video
Change-Id: I36aef5872fc8f5938854ab18b754f3800b9879ad
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/215165
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2019-05-28 20:39:21 +00:00
Herb Derby
f80ba79e25 Use bulk advances in SkPDFEmitType1Font
Change-Id: Ifdaba263365d00886d0fe019e727e6d78484c0a5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/215430
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Hal Canary <halcanary@google.com>
2019-05-28 20:37:01 +00:00
Herb Derby
e7efd08ded Replace SkStrikeSpec with SkStrikeSpecStorage
The SkGlyphRunPainterInterface passed a strike cache in,
but it was only ever needed to get Descriptor. Pass a narrower
object in that just handles strike specifications.

glyphCache -> strike in several places

Change-Id: I98dd9e527149177e61ea26eba64b7868765ac64e
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216349
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-05-28 20:02:55 +00:00
recipe-roller
51ab616bcf Roll recipe dependencies (nontrivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/c2ae1f8b058dc210e2f8b1753aa7184973da36a6 Remove stdout and stderr from expectation files. (gbeaty@chromium.org)


R=stephana@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idc32b8c2c426c0bc60b0c57476258b649d9620d1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216355
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Robbie Iannucci <iannucci@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2019-05-28 19:24:02 +00:00
Michael Ludwig
0cb2fdefc2 Use color analysis opts only if XP keeps the color FPs
This also simplifies the internalStencilClear() paint configuration
to use GrDisableColorXP instead of a transparent black paint.

Without the fix to finalize(), the use of GrDisableColorXP would cause
GLPrograms unit tests to assert when run on a device that needed to
draw for its stencil clears. What would happen is that an initial
stencil clear would add an op with no FPs and the disabled-color XP.
Then the unit test would generate a program with an FP that didn't
support coverage as alpha and used the disabled-color XP. The FP
would disable the coverage-as-alpha optimization, but then the XP
would remove all FPs. This lead to processor sets that were considered
equal (same XP, no FPs), but had different results from finalize().

Change-Id: I6387234a6834028b417a63b9045b9098f72bec75
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216354
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-05-28 18:54:42 +00:00
Florin Malita
a8d18191b5 [skottie] Support multiple text fragments
In preparation for text range selectors, update Shaper and the text
adapter logic to deal with multiple text "fragments".

 - Shaper::Result is now an array of (blob,pos) tuples

 - TextAdapter builds an arbitrary number of scene graph nodes, based on
   the Shaper fragments

Change-Id: I0f2ed86da77e9aaf22b9cb138c3a5f8f957393fe
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216403
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-05-28 18:31:32 +00:00
Hal Canary
d04aaa3a84 PDF example
Update https://skia.org/user/sample/pdf to use example.

https://fiddle.skia.org/c/0777df0419252e28d93c26fb5b789059

Change-Id: Ia828cd5d2ffd30d24a237ffaa3b007984d98a3ba
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216345
Auto-Submit: Hal Canary <halcanary@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-05-28 17:21:59 +00:00
Michael Ludwig
64b28a730e Reland "Update GrRTC to use GrFillRectOp::MakeGeneric"
This reverts commit dbddfff933.

Reason for revert: Fix CL by removing  use of GrDisableColorXP during
stencil clear, which confuses processor analysis. Will fix analysis
and restore GrDisableColorXP in later CL.

Original change's description:
> Revert "Update GrRTC to use GrFillRectOp::MakeGeneric"
>
> This reverts commit ffd4da3cd4.
>
> Reason for revert: Likely breaking Adreno 405 bot
>
> Original change's description:
> > Update GrRTC to use GrFillRectOp::MakeGeneric
> >
> > Change-Id: I4b137c545e726a49c7c5a64febdb83388f335e08
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/215082
> > Commit-Queue: Michael Ludwig <michaelludwig@google.com>
> > Reviewed-by: Brian Salomon <bsalomon@google.com>
>
> TBR=bsalomon@google.com,robertphillips@google.com,michaelludwig@google.com
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Change-Id: I495da5181e71b98a280c53787e8e3279a5d7b162
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216281
> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
> Commit-Queue: Michael Ludwig <michaelludwig@google.com>

TBR=bsalomon@google.com,robertphillips@google.com,michaelludwig@google.com

Change-Id: I367d3724d52bbbbc7d3758cd982798265c0155a2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216342
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Auto-Submit: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2019-05-28 17:06:00 +00:00
Hal Canary
308adbb418 experimental/editor: minor change
Change-Id: Ifd3963e6bb337832c287f2b0553315828a5d3889
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216350
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2019-05-28 16:26:19 +00:00
Herb Derby
53146121b8 Call bulk advances in SkPDFMakeCIDGlyphWidthsArray
Change-Id: Iebb38ea93439dc175f0d67cd30282ee5f13e7a6c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/215429
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2019-05-28 15:56:04 +00:00
Robert Phillips
b5e331aefa Use sk_memset* in GrFillBufferWithColor
Change-Id: I6ead74a61884967f9a60eba614414bc42079d28b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216343
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2019-05-28 15:30:02 +00:00
skia-autoroll
9f9504fe94 Roll skia/third_party/skcms feba95f66c08..ca5b4470be98 (1 commits)
https://skia.googlesource.com/skcms.git/+log/feba95f66c08..ca5b4470be98

2019-05-28 mtklein@google.com limit Android test tasks to first 4 cores


The AutoRoll server is located here: https://autoroll.skia.org/r/skcms-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
TBR=kjlubick@google.com,mtklein@google.com

Change-Id: Id57e534c6c43728441d81d0ec1d1fc2421d0026f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216373
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-05-28 15:20:02 +00:00
skia-autoroll
59bd8c257c Roll skia/third_party/skcms 5b8149aaf52b..feba95f66c08 (1 commits)
https://skia.googlesource.com/skcms.git/+log/5b8149aaf52b..feba95f66c08

2019-05-28 mtklein@google.com fix up 16-bit formats for fp16


The AutoRoll server is located here: https://autoroll.skia.org/r/skcms-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
TBR=kjlubick@google.com,mtklein@google.com

Change-Id: I9c9826fe1ff94131f4e53b5cdaaf3d88f51ffde9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216369
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-05-28 14:49:52 +00:00
recipe-roller
176b214f91 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/778c7f117aee162dece25d84e00504b2b828655e Make tryserver API only update the presentation of its own steps. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I50053de781960e097db4841202244aaa935d004c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216363
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-05-28 13:49:03 +00:00
Brian Salomon
cf49b64720 Define SK_GL in Flutter.
Change-Id: Ia4e035be40b712758821727add1fa730b95362c4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/215828
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-05-28 13:13:46 +00:00
skia-autoroll
213aa46af1 Roll third_party/externals/angle2 40757b28bdc8..3fe06eb3aaaf (4 commits)
40757b28bd..3fe06eb3aa


git log 40757b28bdc8..3fe06eb3aaaf --date=short --no-merges --format='%ad %ae %s'
2019-05-27 geofflang@chromium.org D3D: Make sure Lod0 functions are never referenced in non-fragment shaders.
2019-05-27 jmadill@chromium.org Vulkan: Handle dirty RTs with state messages.
2019-05-27 jmadill@chromium.org Fix KHR dEQP test data dir.
2019-05-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src b8fe7211c465..42abaa099aab (3 commits)


Created with:
  gclient setdep -r third_party/externals/angle2@3fe06eb3aaaf

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=kjlubick@google.com

Change-Id: Ifc636c23e351a83cc724edf83ca749c0e96cfbcb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216324
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-05-28 05:39:24 +00:00
skia-autoroll
3de379de97 Roll third_party/externals/swiftshader 5e9441a25484..710fcd517ea4 (3 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/5e9441a25484..710fcd517ea4


git log 5e9441a25484..710fcd517ea4 --date=short --no-merges --format='%ad %ae %s'
2019-05-27 sugoi@google.com Support for large textures
2019-05-27 sugoi@google.com Fix VkFence destruction crashing on Windows
2019-05-27 amaiorano@google.com Fix Cast(vkFence) crashing on Windows


Created with:
  gclient setdep -r third_party/externals/swiftshader@710fcd517ea4

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=kjlubick@google.com

Change-Id: I9c7c166bb91dc615de55bc8263fd8e1b3be87481
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216323
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-05-28 04:32:24 +00:00
skia-autoroll
38242128d6 Roll ../src 017b02e115dd..a4545bae034e (176 commits)
017b02e115..a4545bae03


Created with:
  gclient setdep -r ../src@a4545bae03

The AutoRoll server is located here: https://autoroll.skia.org/r/chromium-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
TBR=kjlubick@google.com

Change-Id: I8a44b1504fe852263faa36a33b7715f246dea06b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216325
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-05-28 04:28:05 +00:00
Jim Van Verth
7730d7cb8f Revert "Change Metal to not take ownership of objects"
This reverts commit 186a295111.

Reason for revert: Metal bots failing

Original change's description:
> Change Metal to not take ownership of objects
> 
> Prior to this change, Skia/Metal interfaces take ownership of the Metal
> objects passed in (that is, the caller should count passing the object
> to Skia as "freeing" the object).
> 
> Change this behavior so that Skia/Metal retains its own separate
> ownership of the Metal objects.
> 
> Make GrBackendTexture and GrBackendRenderTarget maintain their own
> references to the underlying MTLTexture by using the CFRetain/CFRelease
> interfaces. Do this by adding a private GrMtlBackendSurfaceInfo.
> 
> Move GrMtlBackendSurfaceInfo (formerly GrMtlTextureInfo) out of the
> union in GrBackendTexture and GrBackendRenderTarget because unions
> cannot have nontrivial constructors and destructors (how fVkInfo isn't
> causing a compile error is unclear).
> 
> Change-Id: Iae3719c0715825d86503d03c766e47f0f6015bdf
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/215685
> Commit-Queue: Jim Van Verth <jvanverth@google.com>
> Reviewed-by: Jim Van Verth <jvanverth@google.com>

TBR=egdaniel@google.com,jvanverth@google.com,bsalomon@google.com,ccameron@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ie569fe1938857706b5413876a9480ef1eb3314ea
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/216221
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2019-05-28 03:30:23 +00:00