reed
12ffdb31c9
remove flags that are now in chrome's SkUserConfig.h
...
R=reed@google.com
NOTRY=True
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/367483003
2014-07-01 02:51:26 -07:00
reed
52d9ac6c92
stop calling SkCanvas::getDevice
...
BUG=skia:
R=bsalomon@google.com , robertphillips@google.com , junov@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/355193006
2014-06-30 09:05:34 -07:00
mtklein
d3e474e20c
Deprecate SkPicture::clone().
...
Chrome will need -DSK_SUPPORT_LEGACY_PICTURE_CLONE.
This removes the modes from our tools that use clone(). No
bots run these. DM used clone() in a way that we can just
share the picture now.
I plan to bring back the ability to test multithreaded
picture rendering soon.
BUG=skia:2378
R=robertphillips@google.com , mtklein@google.com , bsalomon@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/338633011
2014-06-27 12:34:44 -07:00
reed
98e34ba892
remove SK_SUPPORT_LEGACY_DEVICE_VIRTUAL_ISOPAQUE for chrome
...
BUG=skia:
R=robertphillips@google.com , fmalita@google.com , fmalita@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/355083006
2014-06-26 18:47:09 -07:00
krajcevski
f461a8fdf6
Simple GPU based dithering:
...
If dithering is turned on, apply an effect that filters the pixel through
the following pipeline:
for each channel c:
1. Compute quantized colors [low, high] that c is between
2. Pick high by flipping a coin weighted by (c - low)
R=bsalomon@google.com , egdaniel@google.com , robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/321253002
2014-06-19 14:14:06 -07:00
reed
c3b3266b7d
hide SkBitmap::Config entirely (behind a flag)
...
patch from issue 339463002
TBR=
I think the NoGPU failure is unrelated, so ignoring
NOTRY=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/340533002
2014-06-17 08:38:31 -07:00
reed
f252f64f17
hide virtuals on device for width/height/isopaque
...
R=bsalomon@google.com
NOTREECHECKS=True
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/334993002
2014-06-14 04:24:57 -07:00
robertphillips
02830f0448
Remove SkPicture SK_SUPPORT_LEGACY_RECORDING_FLAG flag
...
Chromium/Blink should no longer need this flag after:
Chromium: Remove use of kUsePathBoundsForClip_RecordingFlag https://codereview.chromium.org/322123002/
Blink: Remove use of kUsePathBoundsForClip_RecordingFlag https://codereview.chromium.org/326953002/
R=mtklein@google.com , scroggo@google.com , reed@google.com , bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/328343002
2014-06-12 12:56:58 -07:00
reed
6c22573edb
hide SkBitmap::setConfig
...
patch from issue 325733002
TBR=scroggo
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/322963002
2014-06-09 19:52:07 -07:00
robertphillips
e2b78a7131
Fix Chrome build after 9f1c241e
( https://codereview.chromium.org/316143003/ )
...
Remove SkPicture::kUsePathBoundsForClip_RecordingFlag (https://codereview.chromium.org/316143003/ ) removed an SkPicture flag on which Chromium still relies.
R=scroggo@google.com
TBR=scroggo@google.com
NOTRY=true
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/325723002
2014-06-09 07:05:05 -07:00
robertphillips
5713352a64
Chromium should no longer need the legacy SkCanvas::drawPicture interface
...
With:
Switch Blink to using new Skia SkCanvas::drawPicture method - https://codereview.chromium.org/316863003/
Switch Chromium to new Skia SkCanvas::drawPicture method - https://codereview.chromium.org/315963003/
Chromium/Blink should no longer need this flag.
Note: this patch cannot be landed until the Blink change rolls into Chromium.
R=jvanverth@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/317193002
2014-06-08 13:17:54 -07:00
reed
d71be5d78b
remove SK_SUPPORT_LEGACY_SETCONFIG_INFO and SK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS from chrome
...
TBR=
NOTRY=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/320583003
2014-06-06 09:02:22 -07:00
fmalita
fe68617ec1
Relocate SK_IGNORE_CORRECT_HIGH_QUALITY_IMAGE_SCALE
...
Temporarily move the flag into Chromium's repo, to facilitate
atomic remove-and-suppress-failures changes.
BUG=380686
R=humper@google.com
TBR=humper@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/319533002
2014-06-04 10:27:36 -07:00
robertphillips
9b14f26d0f
Alter SkCanvas::drawPicture (devirtualize, take const SkPicture, take pointer)
...
R=reed@google.com , bsalomon@google.com , mtklein@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/313613004
2014-06-04 05:40:44 -07:00
reed
abc0733760
readd SK_SUPPORT_LEGACY_SETCONFIG_INFO -- missed a place in a blink test
...
R=jvanverth@google.com
TBR=jvanverth
NOTRY=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/316753002
2014-06-03 16:51:10 -07:00
reed
9307073a7e
remove unneeded flags SK_SUPPORT_LEGACY_SETCONFIG_INFO and SK_SUPPORT_LEGACY_DEVICE_CONFIG
...
TBR=scroggo
Author: reed@google.com
Review URL: https://codereview.chromium.org/315733002
2014-06-03 15:39:06 -07:00
scroggo
14052a0b5a
Allow chrome to use old version of installPixels.
...
R=jvanverth@google.com , reed@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/312703003
2014-06-03 07:57:51 -07:00
reed
9b4353c845
remove unneeded flags
...
TBR=
Author: reed@google.com
Review URL: https://codereview.chromium.org/316463002
2014-06-03 05:31:01 -07:00
krajcevski
8c111f783f
Change #def to be opt-out
...
R=jvanverth@google.com , robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/308143008
2014-06-02 13:51:34 -07:00
reed
a6a8f00a39
hide SkDevice::config()
...
TBR=robertphilips
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/302253002
2014-06-02 05:45:32 -07:00
commit-bot@chromium.org
b4587957f7
Revert of remove SK_SUPPORT_LEGACY_ASIMAGEINFO and SK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS ( https://codereview.chromium.org/308083010/ )
...
Reason for revert:
broke skia/ext/bitmap_platform_device_cairo.cc:44:56: error: no matching function for call to ‘SkBitmap::installPixels
Original issue's description:
> remove SK_SUPPORT_LEGACY_ASIMAGEINFO and SK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS
>
> TBR=
> NOTRY=
>
> Committed: http://code.google.com/p/skia/source/detail?r=15007
TBR=
NOTREECHECKS=true
NOTRY=true
Author: reed@google.com
Review URL: https://codereview.chromium.org/301353006
git-svn-id: http://skia.googlecode.com/svn/trunk@15010 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-30 21:03:38 +00:00
commit-bot@chromium.org
1fd263edb3
remove SK_SUPPORT_LEGACY_ASIMAGEINFO and SK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS
...
TBR=
NOTRY=
Author: reed@google.com
Review URL: https://codereview.chromium.org/308083010
git-svn-id: http://skia.googlecode.com/svn/trunk@15007 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-30 20:47:13 +00:00
commit-bot@chromium.org
a3264e53ee
Revert "Revert of setConfig -> setInfo ( https://codereview.chromium.org/308683005/ )"
...
This reverts commit eecaea4148805834f223681f70b6488ceba12d09.
R=robertphillips@google.com , scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/301283003
git-svn-id: http://skia.googlecode.com/svn/trunk@14989 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-30 13:26:10 +00:00
commit-bot@chromium.org
d0f824cfbd
Revert of setConfig -> setInfo ( https://codereview.chromium.org/308683005/ )
...
Reason for revert:
broke all Windows bots
Original issue's description:
> setConfig -> setInfo
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14978
R=robertphillips@google.com , reed@google.com
TBR=reed@google.com , robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: epoger@google.com
Review URL: https://codereview.chromium.org/302053002
git-svn-id: http://skia.googlecode.com/svn/trunk@14979 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 21:10:32 +00:00
commit-bot@chromium.org
986d681f3e
setConfig -> setInfo
...
BUG=skia:
R=robertphillips@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/308683005
git-svn-id: http://skia.googlecode.com/svn/trunk@14978 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 20:47:53 +00:00
commit-bot@chromium.org
ff33677ea4
add SK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS
...
TBR=
NOTRY=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/309543002
git-svn-id: http://skia.googlecode.com/svn/trunk@14968 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 17:28:11 +00:00
commit-bot@chromium.org
00f8d6c75d
Revert "Revert of add colortable support to imagegenerator ( https://codereview.chromium.org/304443003/ )"
...
Fix is to add colortable param to installPixels()
This reverts commit 924205aaf2
.
BUG=skia:
R=scroggo@google.com , reed@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/300263005
git-svn-id: http://skia.googlecode.com/svn/trunk@14958 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-29 15:57:20 +00:00
commit-bot@chromium.org
a32260db15
add flag to disable changes to image scaling to avoid breaking every single
...
layout test on blink all at once.
BUG=
R=epoger@google.com
TBR=epoger
NOTRY=True
NOTREECHECKS=True
Author: humper@google.com
Review URL: https://codereview.chromium.org/298133008
git-svn-id: http://skia.googlecode.com/svn/trunk@14931 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 19:52:54 +00:00
commit-bot@chromium.org
924205aaf2
Revert of add colortable support to imagegenerator ( https://codereview.chromium.org/304443003/ )
...
Reason for revert:
failing tests
Original issue's description:
> add colortable support to imagegenerator
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14916
R=halcanary@google.com , scroggo@google.com
TBR=halcanary@google.com , scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@google.com
Review URL: https://codereview.chromium.org/300873007
git-svn-id: http://skia.googlecode.com/svn/trunk@14917 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 16:16:08 +00:00
commit-bot@chromium.org
b263985850
add colortable support to imagegenerator
...
BUG=skia:
R=halcanary@google.com , scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/304443003
git-svn-id: http://skia.googlecode.com/svn/trunk@14916 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-28 16:01:55 +00:00
commit-bot@chromium.org
466f5f3e44
remove SkBitmap::asImageInfo
...
BUG=skia:
R=scroggo@google.com , halcanary@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/305483005
git-svn-id: http://skia.googlecode.com/svn/trunk@14909 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-27 21:30:37 +00:00
commit-bot@chromium.org
53c63a5136
remove SK_SUPPORT_LEGACY_BUILDMIPMAP
...
TBR=scroggo
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/293393007
git-svn-id: http://skia.googlecode.com/svn/trunk@14885 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-27 00:23:36 +00:00
commit-bot@chromium.org
83f23d87f1
Remove unused (by clients) SkUnitMapper
...
This reverts commit 874423a81b5bc2541c7397e6ab00d5e7c9fdaf98.
TBR=scroggo
Author: reed@google.com
Review URL: https://codereview.chromium.org/288313009
git-svn-id: http://skia.googlecode.com/svn/trunk@14842 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-22 12:27:41 +00:00
commit-bot@chromium.org
3339ac54a5
Revert of Remove unused (by clients) SkUnitMapper ( https://codereview.chromium.org/283273002/ ) ( https://codereview.chromium.org/288343009/ )
...
Reason for revert:
required blink change failed to land
Original issue's description:
> Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/ )
>
> This reverts commit dd50c83b5b34dab3a077741861b50ed1f2bc6b8f.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14830
R=scroggo@google.com , reed@google.com
TBR=reed@google.com , scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/296823008
git-svn-id: http://skia.googlecode.com/svn/trunk@14838 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-22 02:55:59 +00:00
commit-bot@chromium.org
4b8f802255
Remove unused (by clients) SkUnitMapper ( https://codereview.chromium.org/283273002/ )
...
This reverts commit dd50c83b5b34dab3a077741861b50ed1f2bc6b8f.
BUG=skia:
R=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/288343009
git-svn-id: http://skia.googlecode.com/svn/trunk@14830 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-21 19:56:46 +00:00
commit-bot@chromium.org
e2b193ca5c
Revert of remove unused (by clients) SkUnitMapper ( https://codereview.chromium.org/283273002/ )
...
Reason for revert:
does not address all legacy callsites in chrome.
e.g.
[13:45:32.091872] ../../ui/native_theme/native_theme_base.cc:608:76: error: no matching function for call to ‘SkGradientShader::CreateLinear(SkPoint [3], SkColor [3], NULL, int, SkShader::TileMode, NULL)’
[13:45:32.091919] gradient_bounds, colors, NULL, 3, SkShader::kClamp_TileMode, NULL));
Original issue's description:
> remove unused (by clients) SkUnitMapper
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14761
R=robertphillips@google.com , scroggo@google.com , george@mozilla.com
TBR=george@mozilla.com , robertphillips@google.com , scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@google.com
Review URL: https://codereview.chromium.org/287063009
git-svn-id: http://skia.googlecode.com/svn/trunk@14763 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-16 13:49:08 +00:00
commit-bot@chromium.org
ee0cac336c
remove unused (by clients) SkUnitMapper
...
BUG=skia:
R=robertphillips@google.com , scroggo@google.com , george@mozilla.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/283273002
git-svn-id: http://skia.googlecode.com/svn/trunk@14761 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-16 13:35:01 +00:00
commit-bot@chromium.org
b3c836b787
add SK_SUPPORT_LEGACY_SHADER_LOCALMATRIX for chrome
...
TBR=borenet@google.com
NOTRY=True
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/286563004
git-svn-id: http://skia.googlecode.com/svn/trunk@14704 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-13 00:43:44 +00:00
commit-bot@chromium.org
5b8d047252
Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag from chromium_defines.
...
Chrome/Blink doesn't use any of the legacy methods behind this flag any more.
BUG=skia:2187
Committed: http://code.google.com/p/skia/source/detail?r=14651
R=reed@google.com
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/265973002
git-svn-id: http://skia.googlecode.com/svn/trunk@14692 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-12 14:12:38 +00:00
reed@google.com
68867b3db2
Revert "remove SK_SUPPORT_LEGACY_BUILDMIPMAP"
...
This reverts commit 9acd04797101990af23f5c374b7dfcbaac12fd2b.
git-svn-id: http://skia.googlecode.com/svn/trunk@14685 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-09 20:06:57 +00:00
commit-bot@chromium.org
259ea9a073
remove SK_SUPPORT_LEGACY_BUILDMIPMAP
...
TBR=djsollen@google.com
NOTRY=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/271253002
git-svn-id: http://skia.googlecode.com/svn/trunk@14684 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-09 19:54:42 +00:00
commit-bot@chromium.org
5e674b2313
Revert of Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag from chromium_defines. ( https://codereview.chromium.org/265973002/ )
...
Reason for revert:
This is breaking compilation of cc_unittests in Chrome
Original issue's description:
> Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag from chromium_defines.
>
> Chrome/Blink doesn't use any of the legacy methods behind this flag any more.
>
> BUG=skia:2187
>
> Committed: http://code.google.com/p/skia/source/detail?r=14651
R=reed@google.com , dominikg@chromium.org
TBR=dominikg@chromium.org , reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2187
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/275713002
git-svn-id: http://skia.googlecode.com/svn/trunk@14660 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-09 00:05:52 +00:00
commit-bot@chromium.org
54f98fc215
Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag from chromium_defines.
...
Chrome/Blink doesn't use any of the legacy methods behind this flag any more.
BUG=skia:2187
R=reed@google.com
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/265973002
git-svn-id: http://skia.googlecode.com/svn/trunk@14651 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-08 18:13:15 +00:00
reed@google.com
a8e52df6f3
remove SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE
...
git-svn-id: http://skia.googlecode.com/svn/trunk@14629 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-07 20:54:58 +00:00
commit-bot@chromium.org
eaca36b657
remove dead mipmap code from SkBitmap
...
BUG=skia:
R=fmalita@google.com , fmalita@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/271693002
git-svn-id: http://skia.googlecode.com/svn/trunk@14611 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-07 15:05:34 +00:00
commit-bot@chromium.org
e9d8ef5cfd
Revert "remove unneeded SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE"
...
This reverts commit 95b03ce599
.
NOTRY=True
TBR=fmalita@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/274513002
git-svn-id: http://skia.googlecode.com/svn/trunk@14606 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-07 03:57:56 +00:00
reed@google.com
95b03ce599
remove unneeded SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE
...
git-svn-id: http://skia.googlecode.com/svn/trunk@14601 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-05-06 21:00:01 +00:00
commit-bot@chromium.org
725b0822be
remove unneeded SK_SUPPORT_LEGACY_PROCXFERMODE
...
BUG=skia:
R=fmalita@google.com , fmalita@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/267573003
git-svn-id: http://skia.googlecode.com/svn/trunk@14489 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-30 21:34:14 +00:00
commit-bot@chromium.org
6988588cde
Eliminate SkPicture-related flags Chromium no longer requires
...
This was originally reverted in r14349 (Restore SkPicture-related guard flags for Chrome - https://codereview.chromium.org/255543004/ ) due to Android WebView compile failures. These failures should be fixed in Chromium r267210 (Fixing Chromium Android build's reliance on old SkPicture recording API - https://codereview.chromium.org/251843005/ )
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/254333003
git-svn-id: http://skia.googlecode.com/svn/trunk@14471 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-30 15:55:14 +00:00
commit-bot@chromium.org
e396455d2d
move common blur types into central header
...
BUG=skia:
R=scroggo@google.com , djsollen@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/253833002
git-svn-id: http://skia.googlecode.com/svn/trunk@14411 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-28 16:25:35 +00:00
robertphillips@google.com
94e2872d48
Restore SkPicture-related guard flags for Chrome
...
https://codereview.chromium.org/255543004/
git-svn-id: http://skia.googlecode.com/svn/trunk@14349 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-24 13:59:18 +00:00
commit-bot@chromium.org
e107edb31a
Remove 2 SkPicture-related flags Chrome should be able to live without
...
R=bsalomon@google.com
TBR=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/252403003
git-svn-id: http://skia.googlecode.com/svn/trunk@14347 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-24 12:51:19 +00:00
commit-bot@chromium.org
40afe0e5f5
Remove guards Chromium no longer needs
...
Note: Android still needs these guards.
Committed: http://code.google.com/p/skia/source/detail?r=14299
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/246403004
git-svn-id: http://skia.googlecode.com/svn/trunk@14329 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-23 19:18:03 +00:00
commit-bot@chromium.org
945ec3a2be
Revert of make drawText calls non-virtual, to ease SkFont and TextBlob ( https://codereview.chromium.org/243853006/ )
...
Reason for revert:
need to test more the code-path where we don't opt into the new virtuals
Original issue's description:
> make drawText calls non-virtual, to ease SkFont and TextBlob
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14307
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@google.com
Review URL: https://codereview.chromium.org/247983003
git-svn-id: http://skia.googlecode.com/svn/trunk@14314 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 20:07:30 +00:00
robertphillips@google.com
6fa0e32705
Reverting Skia r14299 ( Remove guards Chromium no longer needs - https://codereview.chromium.org/246403004 )
...
git-svn-id: http://skia.googlecode.com/svn/trunk@14311 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 19:53:25 +00:00
commit-bot@chromium.org
4325d114a5
make drawText calls non-virtual, to ease SkFont and TextBlob
...
BUG=skia:
R=robertphillips@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/243853006
git-svn-id: http://skia.googlecode.com/svn/trunk@14307 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 19:03:02 +00:00
commit-bot@chromium.org
e221a7f5c7
Remove guards Chromium no longer needs
...
Note: Android still needs these guards.
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/246403004
git-svn-id: http://skia.googlecode.com/svn/trunk@14299 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-22 16:26:29 +00:00
robertphillips@google.com
770963f23f
Staging for cleanup of SkPicture-related headers
...
https://codereview.chromium.org/243173002
git-svn-id: http://skia.googlecode.com/svn/trunk@14258 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-18 18:04:41 +00:00
commit-bot@chromium.org
5fb2ce38b3
Staged removal of SkPicture-derived classes
...
This CL removes the SkPicture-derived classes (with a flag to keeps clients working). In the process it also lightens the recording factory function so it is no longer ref counted).
The only interesting bits are in SkPicture* and Sk*Picture.*
R=reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/238273012
git-svn-id: http://skia.googlecode.com/svn/trunk@14251 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-17 23:35:06 +00:00
commit-bot@chromium.org
d24a130c12
add SK_SUPPORT_LEGACY_PROCXFERMODE to skia_for_chromium_defines.gypi
...
R=reed@google.com
TBR=reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/242053002
git-svn-id: http://skia.googlecode.com/svn/trunk@14250 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-17 23:25:50 +00:00
commit-bot@chromium.org
d393b17cf3
Retract SkPicture::kOptimizeForClippedPlayback_RecordingFlag from public API
...
This CL sets the stage for retracting the SkPicture::kOptimizeForClippedPlayback_RecordingFlag flag
from the public API (more work needs to be done in Blink & Chrome). In the new world the only way
to set this flag (and thus instantiate an SkPicture-derived
class) is by passing a factory to the SkPictureRecorder class. This is to get all clients always using
factories so that we can then change the factory call used (i.e., so the factory just creates a BBH) and
do away with the SkPicture-derived classes.
BUG=skia:2315
R=reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/239703006
git-svn-id: http://skia.googlecode.com/svn/trunk@14221 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-16 16:02:10 +00:00
robertphillips@google.com
84b18c7e3e
split SkPictureRecorder out of SkPicture
...
https://codereview.chromium.org/214953003/
git-svn-id: http://skia.googlecode.com/svn/trunk@14171 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-13 19:09:42 +00:00
commit-bot@chromium.org
28fcae2ec7
Revert of Revert of Rename kPMColor_SkColorType to kN32_SkColorType. ( https://codereview.chromium.org/234243002/ )
...
Reason for revert:
Want to reland the original CL.
Original issue's description:
> Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/ )
>
> Reason for revert:
> breaking the Chrome deps roll.
> http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio
>
> Original issue's description:
> > Rename kPMColor_SkColorType to kN32_SkColorType.
> >
> > The new name better represents what this flag means.
> >
> > BUG=skia:2384
> >
> > Committed: http://code.google.com/p/skia/source/detail?r=14117
>
> TBR=reed@google.com ,scroggo@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:2384
>
> Committed: http://code.google.com/p/skia/source/detail?r=14144
R=reed@google.com , bensong@google.com
TBR=bensong@google.com , reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2384
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/235523003
git-svn-id: http://skia.googlecode.com/svn/trunk@14156 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-11 17:15:40 +00:00
commit-bot@chromium.org
0bd03cf38c
remove guard for getTotalClip
...
TBR=robertphilips@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/235093002
git-svn-id: http://skia.googlecode.com/svn/trunk@14153 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-11 15:54:06 +00:00
commit-bot@chromium.org
96edc24598
Revert of Rename kPMColor_SkColorType to kN32_SkColorType. ( https://codereview.chromium.org/227433009/ )
...
Reason for revert:
Chrome's side of define changes not easy to figure out quickly. Reverting this for DEPS roll for now.
Original issue's description:
> Rename kPMColor_SkColorType to kN32_SkColorType.
>
> The new name better represents what this flag means.
>
> BUG=skia:2384
>
> Committed: http://code.google.com/p/skia/source/detail?r=14117
R=reed@google.com , scroggo@google.com
TBR=reed@google.com , scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2384
Author: bensong@google.com
Review URL: https://codereview.chromium.org/234833003
git-svn-id: http://skia.googlecode.com/svn/trunk@14149 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-11 13:47:30 +00:00
commit-bot@chromium.org
d923288e50
Revert of Revert of Rename kPMColor_SkColorType to kN32_SkColorType. ( https://codereview.chromium.org/234243002/ )
...
Reason for revert:
fixes on the chrome side are landing (brettw), keep fingers crossed.
Original issue's description:
> Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/ )
>
> Reason for revert:
> breaking the Chrome deps roll.
> http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio
>
> Original issue's description:
> > Rename kPMColor_SkColorType to kN32_SkColorType.
> >
> > The new name better represents what this flag means.
> >
> > BUG=skia:2384
> >
> > Committed: http://code.google.com/p/skia/source/detail?r=14117
>
> TBR=reed@google.com ,scroggo@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:2384
>
> Committed: http://code.google.com/p/skia/source/detail?r=14144
R=reed@google.com , scroggo@google.com
TBR=reed@google.com , scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2384
Author: bensong@google.com
Review URL: https://codereview.chromium.org/233813004
git-svn-id: http://skia.googlecode.com/svn/trunk@14145 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-10 22:49:20 +00:00
commit-bot@chromium.org
757ebd20ef
Revert of Rename kPMColor_SkColorType to kN32_SkColorType. ( https://codereview.chromium.org/227433009/ )
...
Reason for revert:
breaking the Chrome deps roll.
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio
Original issue's description:
> Rename kPMColor_SkColorType to kN32_SkColorType.
>
> The new name better represents what this flag means.
>
> BUG=skia:2384
>
> Committed: http://code.google.com/p/skia/source/detail?r=14117
R=reed@google.com , scroggo@google.com
TBR=reed@google.com , scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2384
Author: bensong@google.com
Review URL: https://codereview.chromium.org/234243002
git-svn-id: http://skia.googlecode.com/svn/trunk@14144 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-10 22:36:34 +00:00
bensong@google.com
729296f7db
revert of 14111 to fix build
...
git-svn-id: http://skia.googlecode.com/svn/trunk@14128 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-10 12:46:36 +00:00
commit-bot@chromium.org
149e9a107c
Rename kPMColor_SkColorType to kN32_SkColorType.
...
The new name better represents what this flag means.
BUG=skia:2384
R=reed@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/227433009
git-svn-id: http://skia.googlecode.com/svn/trunk@14117 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-09 20:45:29 +00:00
reed@google.com
a2cbced5f7
no more callers of getTotalClip -- except in android
...
git-svn-id: http://skia.googlecode.com/svn/trunk@14111 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-09 18:47:28 +00:00
commit-bot@chromium.org
0d0d620bfd
remove SK_SUPPORT_LEGACY_GETCLIPTYPE
...
after this lands and sticks, we can remove the assocated code from skia
BUG=skia:
R=robertphillips@google.com , reed@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/216703004
git-svn-id: http://skia.googlecode.com/svn/trunk@14074 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-04-07 15:17:37 +00:00
commit-bot@chromium.org
3fcab54c7f
remove SK_SUPPORT_LEGACY_COMPATIBLEDEVICE_CONFIG
...
NOTRY=True
TBR=bsalomon
Author: reed@google.com
Review URL: https://codereview.chromium.org/212623003
git-svn-id: http://skia.googlecode.com/svn/trunk@13954 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-26 15:55:50 +00:00
reed@google.com
46ee398e3e
remove SK_SUPPORT_LEGACY_READPIXELSCONFIG
...
BUG=skia:
Review URL: https://codereview.chromium.org/209333011
git-svn-id: http://skia.googlecode.com/svn/trunk@13914 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-24 18:07:24 +00:00
commit-bot@chromium.org
a713f9c6f6
add new readPixels with direct memory parameters
...
BUG=skia:
R=scroggo@google.com , bsalomon@google.com , robertphillips@google.com , fmalita@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/199413013
git-svn-id: http://skia.googlecode.com/svn/trunk@13840 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-17 21:31:26 +00:00
reed@google.com
18d6753bd0
remove SK_SUPPORT_LEGACY_WRITEPIXELSCONFIG
...
BUG=skia:
Review URL: https://codereview.chromium.org/200533002
git-svn-id: http://skia.googlecode.com/svn/trunk@13808 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-14 17:26:15 +00:00
reed@google.com
b3890cbcdb
remove SK_SUPPORT_LEGACY_GETDEVICECAPABILITIES
...
BUG=skia:
Review URL: https://codereview.chromium.org/195763023
git-svn-id: http://skia.googlecode.com/svn/trunk@13807 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-14 17:24:05 +00:00
commit-bot@chromium.org
3da3b621c3
getDeviceCapabilities is no longer need, so remove it
...
BUG=skia:
R=bungeman@google.com , vandebo@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/198943003
git-svn-id: http://skia.googlecode.com/svn/trunk@13797 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-13 19:38:10 +00:00
reed@google.com
9c135db83d
support direct writing to top layer, and hide getTopLayer()
...
this should remove many of the chrome callers that today call
accessBitmap on the toplayer, so they can read/write those pixels.
The ultimate fix will be to support custom allocation of raster layers
(via GDI/cairo/mac) so we can remove PlatformDevice subclassing in
skia/ext
BUG=skia:
R=bsalomon@google.com , scroggo@google.com
Review URL: https://codereview.chromium.org/197433002
git-svn-id: http://skia.googlecode.com/svn/trunk@13774 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-12 18:28:35 +00:00
commit-bot@chromium.org
ab373bd459
remove SK_SUPPORT_LEGACY_COPYTO_CONFIG
...
R=halcanary@google.com
TBR=halcanary@google.com
NOTRY=True
NOTREECHECK=True
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/196003003
git-svn-id: http://skia.googlecode.com/svn/trunk@13753 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-11 22:58:24 +00:00
reed@google.com
e8ead8e510
Revert "remove flag for legacy copyTo -- call sites have been updated"
...
This reverts commit 85586a92f50942ede4422aca7308b9d8a88469db.
git-svn-id: http://skia.googlecode.com/svn/trunk@13719 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-10 12:17:06 +00:00
skia.committer@gmail.com
a5cb214132
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13716 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-09 03:02:09 +00:00
commit-bot@chromium.org
5c70cdca5e
hide getTotalClip, so we can eventually remove it
...
hide getClipType, so we can eventually remove it
patch from issue 189443007
TBR=robertphilips@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/189883010
git-svn-id: http://skia.googlecode.com/svn/trunk@13715 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-08 03:57:19 +00:00
reed@google.com
ce29b329e4
remove flag for legacy copyTo -- call sites have been updated
...
TBR=robertphilips@google.com
Review URL: https://codereview.chromium.org/189513005
git-svn-id: http://skia.googlecode.com/svn/trunk@13706 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-07 16:20:47 +00:00
commit-bot@chromium.org
4cd9e2169e
Add SkCanvas::writePixels that takes info+pixels directly
...
add corresponding methods to device (w/ diff name to avoid colliding with exising virtuals)
BUG=skia:
R=bsalomon@google.com , robertphillips@google.com , junov@google.com , junov@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/180113010
git-svn-id: http://skia.googlecode.com/svn/trunk@13697 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-03-07 03:25:16 +00:00
reed@google.com
6c50cd31ed
remove SK_SUPPORT_DEEPCOPYTO_CONFIG
...
git-svn-id: http://skia.googlecode.com/svn/trunk@13625 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-28 16:30:45 +00:00
reed@google.com
b4c5f06c03
allow skia flags to be specified in a skia file, but reference by chrome's skia_common.gypi
...
in support of https://codereview.chromium.org/180083002/ which will land after this CL is visible in Chrome
R=bungeman@google.com
Review URL: https://codereview.chromium.org/180063003
git-svn-id: http://skia.googlecode.com/svn/trunk@13582 2bbb7eff-a529-9590-31e7-b0007b416f81
2014-02-25 18:13:22 +00:00