Commit Graph

6606 Commits

Author SHA1 Message Date
robertphillips@google.com
152336f4ea Fix uninitialized memory access
https://codereview.appspot.com/7657044/



git-svn-id: http://skia.googlecode.com/svn/trunk@8142 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 21:47:56 +00:00
reed@google.com
2863f082f2 have reset() return its argument as a convenience
git-svn-id: http://skia.googlecode.com/svn/trunk@8141 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 21:28:44 +00:00
jvanverth@google.com
c3413d6f41 Increase bits for effect attribute key.
We can have an attribute index value up to 7, but only allow 2 bits for each
index in GrGLEffect::GenAttribKey. This change gives them 3 bits (and fixes an
assert when running tests in debug).

Review URL: https://codereview.chromium.org/12431018/


git-svn-id: http://skia.googlecode.com/svn/trunk@8140 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 21:05:14 +00:00
caryclark@google.com
1ab0aac672 shape ops -- fix errors
git-svn-id: http://skia.googlecode.com/svn/trunk@8138 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 20:41:48 +00:00
caryclark@google.com
1304bb25aa shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@8137 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 20:29:41 +00:00
vandebo@chromium.org
dcf9c19d38 [PDF] Always set the symbolic Flag for Fonts.
This should fix Chrome bug 124572

Review URL: https://codereview.appspot.com/7631045

git-svn-id: http://skia.googlecode.com/svn/trunk@8136 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 20:01:51 +00:00
junov@chromium.org
d34fda187c Build fix: accessing uninitialized class member (not)
TBR=sugoi

git-svn-id: http://skia.googlecode.com/svn/trunk@8135 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 19:03:26 +00:00
bensong@google.com
a9a1967bcb Cut data point upload batch size to 25.
Some bots have lower speed sending http data out, and this will make it less likely to timeout.
Did not try 50 because once we switch to using Chrome dashboard app, extra work needs to be done for each data point which will take longer. Since appengine has the fixed 30s timeout policy, there's not too much we can do unless we convince Chrome to switch to other solutions.
Current Skia data on our app instance: https://skiadash.appspot.com/report
Review URL: https://codereview.chromium.org/12703008

git-svn-id: http://skia.googlecode.com/svn/trunk@8133 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 18:31:03 +00:00
junov@chromium.org
e286e84a6a Modifying the behavior of render_pictures --validate to test the effect of bbh.
The new behavior consists in using the same renderer, with bbh disabled, as a reference
renderer when the current renderer has a bbh.
Review URL: https://codereview.chromium.org/12801002

git-svn-id: http://skia.googlecode.com/svn/trunk@8132 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 17:27:16 +00:00
bsalomon@google.com
306b2ce0e2 Use stream usage for dynamic vertex data.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/12799005

git-svn-id: http://skia.googlecode.com/svn/trunk@8129 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 15:31:11 +00:00
robertphillips@google.com
bb51fabc99 Update bench_expectations & add triggers for N7, Mac 10.8 and Ubuntu
git-svn-id: http://skia.googlecode.com/svn/trunk@8128 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 15:25:30 +00:00
reed@google.com
0b8a2fe2cd comment out debugging printfs
git-svn-id: http://skia.googlecode.com/svn/trunk@8127 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 14:58:41 +00:00
epoger@google.com
5efdd0cb9c gm: write all messages to stdout/stderr with "GM:" preamble to distinguish from various debug messages coming from elsewhere
Review URL: https://codereview.chromium.org/12691009

git-svn-id: http://skia.googlecode.com/svn/trunk@8126 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 14:18:40 +00:00
bsalomon@google.com
530efc8085 Remove extraneous paren.
Review URL: https://codereview.chromium.org/12750004

git-svn-id: http://skia.googlecode.com/svn/trunk@8125 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 13:38:30 +00:00
commit-bot@chromium.org
059a4c70d7 refactor android defines to implicitly assume NDK compliance unless it is explicitly marked as being specific to the android framework.
Author: djsollen@google.com

Reviewed By: reed@google.com,borenet@google.com

Review URL: https://chromiumcodereview.appspot.com/12739007

git-svn-id: http://skia.googlecode.com/svn/trunk@8124 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 12:48:26 +00:00
commit-bot@chromium.org
50485744e1 Whitespace change to test commit-queue
Author: rmistry@google.com

Reviewed By: borenet@google.com,epoger@google.com

Review URL: https://chromiumcodereview.appspot.com/12826004

git-svn-id: http://skia.googlecode.com/svn/trunk@8123 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 11:49:15 +00:00
skia.committer@gmail.com
91274b9972 Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8120 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-13 07:01:04 +00:00
junov@chromium.org
c19c19111c Fixing crash in render_pictures when failing to create referenceBitmap for --validate
Review URL: https://codereview.chromium.org/12800002

git-svn-id: http://skia.googlecode.com/svn/trunk@8119 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 19:56:49 +00:00
edisonn@google.com
8c020612ba Update flag to reflect actual meaning.
Review URL: https://codereview.chromium.org/12754004

git-svn-id: http://skia.googlecode.com/svn/trunk@8118 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 19:53:16 +00:00
robertphillips@google.com
632b9ccebf Disable all multi_*_threads triggers (see issue 1160)
git-svn-id: http://skia.googlecode.com/svn/trunk@8117 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 19:20:22 +00:00
robertphillips@google.com
c04987ff73 Fixed unitialized memory access bug in r8106
git-svn-id: http://skia.googlecode.com/svn/trunk@8115 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 17:53:53 +00:00
bungeman@google.com
f44957e769 Fix GDI device context leak.
https://codereview.appspot.com/7682044/



git-svn-id: http://skia.googlecode.com/svn/trunk@8113 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 17:27:10 +00:00
borenet@google.com
5dc06785ff Make graph output optional in bench_graphs_svg
Enables https://codereview.chromium.org/12785002/
Review URL: https://codereview.chromium.org/12543019

git-svn-id: http://skia.googlecode.com/svn/trunk@8112 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 17:16:07 +00:00
robertphillips@google.com
5ba0d9064d Fixed compiler error/warning
git-svn-id: http://skia.googlecode.com/svn/trunk@8110 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 16:05:14 +00:00
jvanverth@google.com
948787737b Add GL program cache tracking.
This may help us track down cases when we change how program keys are generated
and we get invalid misses.


git-svn-id: http://skia.googlecode.com/svn/trunk@8109 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 16:00:54 +00:00
reed@google.com
7ed1534416 fix warning: use size_t when comparing to SK_ARRAY_COUNT
git-svn-id: http://skia.googlecode.com/svn/trunk@8108 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 15:55:47 +00:00
reed@google.com
1a64a54b27 add (temp) SkFontLCDConfig class to hold LCD getters/setters. This will allow
us to make SkFontHost.h private (once webkit switches to the SkFontLCDConfig api)

Stage 2 is to either move this code into chrome/webkit, or change the callers to
perform their own globals management.
Review URL: https://codereview.chromium.org/12623011

git-svn-id: http://skia.googlecode.com/svn/trunk@8107 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 15:41:18 +00:00
robertphillips@google.com
b8f9610ac6 Refactor PictureRecord optimization & added saveLayer/save/clipR/DBM*/restore/restore optimization
https://codereview.appspot.com/7485043/



git-svn-id: http://skia.googlecode.com/svn/trunk@8106 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 15:39:44 +00:00
robertphillips@google.com
e428f9b113 Fix debugger build errors/warnings
https://codereview.appspot.com/7729045/



git-svn-id: http://skia.googlecode.com/svn/trunk@8105 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 15:33:40 +00:00
commit-bot@chromium.org
167876ea18 Whitespace change to test commit-queue reviewers list
(SkipBuildbotRuns)

Author: rmistry@google.com

Reviewed By: borenet@google.com,epoger@google.com

Review URL: https://chromiumcodereview.appspot.com/12570006

git-svn-id: http://skia.googlecode.com/svn/trunk@8104 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 14:58:49 +00:00
sugoi@google.com
93c7ee34dc Removed unused parameters
I removed unused parameters wherever it was trivial to do so.
Review URL: https://codereview.chromium.org/12772003

git-svn-id: http://skia.googlecode.com/svn/trunk@8103 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 14:36:57 +00:00
robertphillips@google.com
a041b954ff "Fix" case when bicubic filtering warps premultiplied color
https://codereview.appspot.com/7447048/



git-svn-id: http://skia.googlecode.com/svn/trunk@8096 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 13:13:07 +00:00
borenet@google.com
2d9dbd4f78 NaCl Debugger: Implement overview and filters, cleanup
(SkipBuildbotRuns) since no bots build the debugger.
Review URL: https://codereview.chromium.org/12449006

git-svn-id: http://skia.googlecode.com/svn/trunk@8095 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 13:07:40 +00:00
reed@google.com
5687a3e93b fix handling of stroked cubics when we exhaust our recursion limit.
Review URL: https://codereview.chromium.org/12567006

git-svn-id: http://skia.googlecode.com/svn/trunk@8093 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 12:57:04 +00:00
commit-bot@chromium.org
ff6ea2663f Add GrEllipseEdgeEffect.
Adds the effect that replaces the old oval rendering code. Also hooks in code to set attribute names and indices for effects.

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/12462008

git-svn-id: http://skia.googlecode.com/svn/trunk@8092 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 12:26:08 +00:00
skia.committer@gmail.com
2e71f1619d Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8090 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-12 07:12:32 +00:00
robertphillips@google.com
febc0ec41b Add misc. optimizations to filter tool
https://codereview.appspot.com/7705043/



git-svn-id: http://skia.googlecode.com/svn/trunk@8087 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-11 22:53:11 +00:00
humper@google.com
512977aead re-enable fast blur so I can rebaseline
git-svn-id: http://skia.googlecode.com/svn/trunk@8086 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-11 22:42:30 +00:00
humper@google.com
d4d573057e add proper support for solid style, and temporarily turn off my change so the bots can go green |
git-svn-id: http://skia.googlecode.com/svn/trunk@8085 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-11 22:18:54 +00:00
humper@google.com
e86af1f4ba fix preprocessor abuse on Windows
git-svn-id: http://skia.googlecode.com/svn/trunk@8084 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-11 21:23:36 +00:00
humper@google.com
68a690cb05 fix pad bug introduced during code cleanup
git-svn-id: http://skia.googlecode.com/svn/trunk@8083 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-11 21:16:20 +00:00
reed@google.com
8fff398043 fix missing ! typo when we switched to skip() helper function.
caught by linux unittests.



git-svn-id: http://skia.googlecode.com/svn/trunk@8081 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-11 20:38:59 +00:00
sugoi@google.com
7eb28aae70 Adding more warning in core
I figured out the reason for the lack of warnings on Linux that caused the Mac build break. Some warnings were explicitly disabled in "core" on Linux. I re-enabled them.
Review URL: https://codereview.chromium.org/12667012

git-svn-id: http://skia.googlecode.com/svn/trunk@8080 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-11 20:35:19 +00:00
bsalomon@google.com
e3613cefe2 Fix sign/unsigned warnings in benchmain.cpp and gmmain.cpp
git-svn-id: http://skia.googlecode.com/svn/trunk@8079 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-11 20:33:45 +00:00
humper@google.com
adef4fefd3 fix build warnings
git-svn-id: http://skia.googlecode.com/svn/trunk@8078 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-11 20:32:05 +00:00
bsalomon@google.com
7fa1bb4133 Simplify the GL interface validation test.
Review URL: https://codereview.chromium.org/12703003

git-svn-id: http://skia.googlecode.com/svn/trunk@8077 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-11 20:22:38 +00:00
bsalomon@google.com
8a8fcba5b6 Make GPU cache size cmd line configurable in GM.
Review URL: https://codereview.chromium.org/12717002

git-svn-id: http://skia.googlecode.com/svn/trunk@8076 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-11 20:22:31 +00:00
bsalomon@google.com
c732f259fa Add --gpucache size to bench.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/12635009

git-svn-id: http://skia.googlecode.com/svn/trunk@8075 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-11 20:22:15 +00:00
humper@google.com
7c5d7b7813 Plumb fast rectangle blur code into the skia mask filter
Review URL: https://codereview.chromium.org/12387099

git-svn-id: http://skia.googlecode.com/svn/trunk@8074 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-11 20:16:28 +00:00
reed@google.com
ed268bfed3 add (mac) test for ttcindex in SkFontStream
git-svn-id: http://skia.googlecode.com/svn/trunk@8073 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-03-11 20:13:36 +00:00