reed
3719886415
remove debugging printf
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1725173003
NOTRY=True
TBR=
Review URL: https://codereview.chromium.org/1725173003
2016-02-24 09:32:40 -08:00
halcanary
1abea462c8
SkPDF/Bench: add bench for SkPDFCreateBitmapObject
...
BUG=skia:5009
Review URL: https://codereview.chromium.org/1729943003
2016-02-24 09:25:58 -08:00
joshualitt
b8d864902b
fixup GLPrograms textblob todo
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1730253002
Review URL: https://codereview.chromium.org/1730253002
2016-02-24 09:23:03 -08:00
caryclark
d78c088b61
fix path ops fuzz bug
...
If one path is empty and the other has extreme values, the
intermediate coincident paths cannot be resolved, but triggers
an assert that a data structure unexpectedly has zero-length.
Tunnel this failure back up to the top and return that the
entire path op fails.
A future optimization could detect the empty path and avoid
this, allowing the op to succeed -- not sure that it's worth
the additional logic though.
TBR=reed@google.com
BUG=535151
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1730293002
Review URL: https://codereview.chromium.org/1730293002
2016-02-24 09:03:07 -08:00
mtklein
d9381acb0e
Turn off DM --pre_log on the bots. Too spammy.
...
BUG=skia:4978
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1734703002
Review URL: https://codereview.chromium.org/1734703002
2016-02-24 08:58:27 -08:00
jvanverth
970fd1fbea
Use ARM fixes for SDF encoding.
...
This pulls out the encoding fixes by Joel Liang from
https://codereview.chromium.org/1643143002/
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1726763002
Review URL: https://codereview.chromium.org/1726763002
2016-02-24 08:33:10 -08:00
benjaminwagner
c2d35d8513
Revert of Simple cleanups related to SkFixed. (patchset #4 id:120001 of https://codereview.chromium.org/1683743005/ )
...
Reason for revert:
New test is failing on Windows.
Original issue's description:
> Cleanups related to SkFixed.
>
> Remove SK_FixedNaN. It does not seem to be supported or used anywhere in Skia, Chromium, Android, or Google3, (except accidentally by TwoPtRadial::kDontDrawT). I think supporting it would erase any benefit of SkFixed over float.
>
> Remove SkBitmapFilter::lookup. It does not appear to be used anywhere in Skia, Chromium, Android, or Google3.
>
> Fix a bug in SkPaint::breakText that limited it to ~5kB of text. Now it can handle more than 1GB.
>
> BUG=skia:4632
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1683743005
>
> Committed: https://skia.googlesource.com/skia/+/7ea5cb18389db11a94175de95c9db2b44972630c
TBR=mtklein@google.com ,reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4632
Review URL: https://codereview.chromium.org/1724283003
2016-02-24 08:29:11 -08:00
ethannicholas
f15b07b75c
Revert of Include glGetMultisamplefv API (patchset #1 id:1 of https://codereview.chromium.org/1720963002/ )
...
Reason for revert:
This is in the blamelist for Visualbench failures:
https://build.chromium.org/p/client.skia/builders/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-VisualBench/builds/1035
and seems the most likely candidate for the failure, so I am tentatively reverting.
Original issue's description:
> Include glGetMultisamplefv API
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720963002
>
> Committed: https://skia.googlesource.com/skia/+/69c1b24bcaa7cffd59753a75a7f3d155696fcac4
TBR=bsalomon@google.com ,joshualitt@google.com,cdalton@nvidia.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1731333002
2016-02-24 08:19:04 -08:00
reed
8516dc1016
extend xfermodes gm to include 3 custom modes
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1736523002
Review URL: https://codereview.chromium.org/1736523002
2016-02-24 08:18:42 -08:00
benjaminwagner
9d24023c66
Ensure the Gaussian tail of circle blurs goes to zero.
...
Compare blurcircle GM masked so that values <255 are white and =255 are black:
https://x20web.corp.google.com/~benjaminwagner/review/1723383002/blurcircles-lt255-before.png
https://x20web.corp.google.com/~benjaminwagner/review/1723383002/blurcircles-lt255-after.png
This is a spinoff of https://codereview.chromium.org/1691403002 , which was previously causing more "rectangles" in this GM.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1723383002
Review URL: https://codereview.chromium.org/1723383002
2016-02-24 07:51:33 -08:00
benjaminwagner
7ea5cb1838
Cleanups related to SkFixed.
...
Remove SK_FixedNaN. It does not seem to be supported or used anywhere in Skia, Chromium, Android, or Google3, (except accidentally by TwoPtRadial::kDontDrawT). I think supporting it would erase any benefit of SkFixed over float.
Remove SkBitmapFilter::lookup. It does not appear to be used anywhere in Skia, Chromium, Android, or Google3.
Fix a bug in SkPaint::breakText that limited it to ~5kB of text. Now it can handle more than 1GB.
BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1683743005
Review URL: https://codereview.chromium.org/1683743005
2016-02-24 06:51:52 -08:00
reed
8f7b0b2d80
simplify/unify xferproc api
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1721223002
Review URL: https://codereview.chromium.org/1721223002
2016-02-24 06:21:36 -08:00
joshualitt
cbbc9df143
Create new GM to target translations problems in GrAtlasTextContext
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1721833005
Review URL: https://codereview.chromium.org/1721833005
2016-02-24 05:49:55 -08:00
fmalita
ca058f57a3
Retire SkShader::kSupports4f_Flag
...
No longer used except in one test.
Introduce kPrefers4f_Flag instead.
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1726983002
Review URL: https://codereview.chromium.org/1726983002
2016-02-23 19:02:20 -08:00
hcm
85a7a5fc6c
Skia schedule on skia.org
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1726253002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1726253002
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1726253002
2016-02-23 16:26:03 -08:00
cdalton
69c1b24bca
Include glGetMultisamplefv API
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720963002
Review URL: https://codereview.chromium.org/1720963002
2016-02-23 13:38:47 -08:00
fmalita
55430a6207
Update 4f linear gradient selection heuristic
...
Use the 4f context when
* dest type is 4f
* there's no perpective
Keeping the define and testing flag overrides for now.
R=reed@google.com ,herb@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1725793003
Review URL: https://codereview.chromium.org/1725793003
2016-02-23 13:26:28 -08:00
bungeman
ccb74b824a
Move SkPackBits to src/effects.
...
Prior to this change SkPackBits.h was in include/core and SkPackBits.cpp
in src/core. However, SkPackBits appears to have been written
specifically as an implementation detail of the SkTableColorFilter
effect. This change moves SkPackBits out of core and into effects, which
is the only current user.
Review URL: https://codereview.chromium.org/1722173003
2016-02-23 12:55:20 -08:00
benjaminwagner
d936f63c35
Simplify and combine SkDrawCacheProc and SkMeasureCacheProc to SkPaint::GlyphCacheProc.
...
All callers of (the result of) SkPaint::getDrawCacheProc were passing zero as the last two arguments. This is the same as (the result of) SkPaint::getMeasureCacheProc(true).
Per bungeman, make this typedef a member of SkPaint.
Although the typedef is technically public, the only uses are private, so this is not really an API change.
TBR=reed
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1718423002
Review URL: https://codereview.chromium.org/1718423002
2016-02-23 10:44:32 -08:00
mtklein
246ba3a8b4
Add a handler to DM to print out what was running when we crash.
...
This is an experiment to see if we can use something like this
rather than today's extremely verbose logging.
Now, hopefully something crashes.
BUG=skia:4978
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1725543002
Review URL: https://codereview.chromium.org/1725543002
2016-02-23 10:39:36 -08:00
caryclark
5a70bc7f3c
make transformed rrect radii fit rectangle
...
one more case caught by 1M skps
R=herb@google.com ,reed@google.com
BUG=skia:4413
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1722483003
Review URL: https://codereview.chromium.org/1722483003
2016-02-23 10:32:40 -08:00
msarett
9ca27f39dd
Remove unnecessary GOOGLE3 ifdefs from SkRawCodec
...
These should be fine now that SkJpegCodec is building in GOOGLE3.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1718343002
Review URL: https://codereview.chromium.org/1718343002
2016-02-23 08:21:21 -08:00
msarett
fda6cea7f8
Update SK_IMAGE_VERSION to 3
...
This includes two new test wbmps (that came from clients of BitmapFactory).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1722263002
Review URL: https://codereview.chromium.org/1722263002
2016-02-23 08:14:19 -08:00
bungeman
5d2cd6e074
Move SkUtils.h to src/core.
...
Review URL: https://codereview.chromium.org/1722703003
2016-02-23 07:34:25 -08:00
ethannicholas
807dcabe99
added 'visible' attribute to skiaserve JSON
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1726663002
Review URL: https://codereview.chromium.org/1726663002
2016-02-23 06:53:37 -08:00
yujieqin
2d172ebb29
Use new API instead of the deprecated ones.
...
This change will allow us to remove the old API in follow up clean up.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1728553002
Review URL: https://codereview.chromium.org/1728553002
2016-02-23 06:49:38 -08:00
yujieqin
cf16e67f84
Update PIEX: Prepares support for uncompressed thumbnails
...
The new version of PIEX added new API for adding support to thumbnails. It also marks some old API as deprecate.
BUG=b/26894354
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1723123002
Review URL: https://codereview.chromium.org/1723123002
2016-02-23 06:18:14 -08:00
msarett
285e7c62ed
Turn on TURBO_HAS_CROP for Android framework
...
https://buganizer.corp.google.com/u/0/issues/27290496
BUG=skia:4256
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1721953002
Review URL: https://codereview.chromium.org/1721953002
2016-02-23 05:48:01 -08:00
msarett
b65e604f10
Make DM failures fatal
...
We should now only be pushing Srcs for tests that we expect
to succeed. So any failures should be treated as errors.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1719293002
Review URL: https://codereview.chromium.org/1719293002
2016-02-23 05:37:25 -08:00
fmalita
d0c4e092d5
Add dest type hint to SkShader::ContextRec
...
Let SkBlitter decide which dst type is optimal (PMColor vs PM4f), and
pass that info to shaders.
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1724503002
Review URL: https://codereview.chromium.org/1724503002
2016-02-22 17:19:04 -08:00
mtklein
888934723d
remove unnecessary copies
...
these used to matter with pass-by-ref
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1721153002
Review URL: https://codereview.chromium.org/1721153002
2016-02-22 16:56:00 -08:00
mtklein
afe9facc9f
Run no CPU benches in Debug trybots.
...
They seem to just be wasting time on the CQ.
Hacking this into nanobench_flags.py makes it easy to back out.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720223002
Review URL: https://codereview.chromium.org/1720223002
2016-02-22 14:59:59 -08:00
herb
a856e25ba1
Better encapsulation and vector calling convention.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1723683002
Review URL: https://codereview.chromium.org/1723683002
2016-02-22 14:48:22 -08:00
benjaminwagner
bc9a9b4cdc
Fix DM_INCLUDES after https://codereview.chromium.org/1688543002
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1719253002
Review URL: https://codereview.chromium.org/1719253002
2016-02-22 13:30:39 -08:00
bungeman
f6d1e60531
Only use fake gamma with linear devices.
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1711223003
Review URL: https://codereview.chromium.org/1711223003
2016-02-22 13:20:29 -08:00
herb
933ad4389f
Add spans for matrix ops.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1722703002
Review URL: https://codereview.chromium.org/1722703002
2016-02-22 13:13:28 -08:00
bsalomon
bc2f4dfd41
fix unsigned/signed warning on linux for GrVkDescriptorPool::numPoolSizes()
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1724493002
Review URL: https://codereview.chromium.org/1724493002
2016-02-22 13:09:26 -08:00
jvanverth
f853594cc1
Fix unsigned short UVs for Vulkan.
...
Modifies the attribute type to match GL.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1723633003
Review URL: https://codereview.chromium.org/1723633003
2016-02-22 13:05:51 -08:00
bsalomon
3d7b02c728
Fix gyp-and-sync for windows
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1715423003
Review URL: https://codereview.chromium.org/1715423003
2016-02-22 12:59:53 -08:00
reed
ca726abe1e
fix misc asserts and checks found by fuzzer
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1719993002
Review URL: https://codereview.chromium.org/1719993002
2016-02-22 12:50:26 -08:00
caryclark
d49a86ade0
allow move/zero-line/close to draw caps
...
R=fmalita@chromium.org
BUG=skia:4784
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720953002
Review URL: https://codereview.chromium.org/1720953002
2016-02-22 12:44:54 -08:00
reed
e5257bd384
kill gm now that we can test srgb on all gms
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1719963004
TBR=
Review URL: https://codereview.chromium.org/1719963004
2016-02-22 12:29:04 -08:00
msarett
91c22b2ea6
Use new jpeg_crop_scanlines() API to optimize jpeg subset decodes
...
This was adapted from:
https://codereview.chromium.org/1530933003
Subset Decode Runtime (Original / Optimized) on Nexus 6P
TopLeft 0.51x
TopRight 0.56x
Middle 0.71x
BottomLeft 0.79x
BottomRight 0.79x
BUG=skia:4256
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1719073002
Review URL: https://codereview.chromium.org/1719073002
2016-02-22 12:27:46 -08:00
bsalomon
7499e69d99
Incorporate Vulkan files into main gpu.gyp/gpu.gypi
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1718273002
Review URL: https://codereview.chromium.org/1718273002
2016-02-22 12:13:19 -08:00
jvanverth
7023a00c35
Use unorm shorts for texture coordinates when rendering text.
...
There are a couple of reasons for this:
- Vulkan does not guarantee conversions from integral vertex attributes
to floating point shader variables
- This may be faster and more precise on some platforms, as it avoids
the aforementioned conversion and changes a multiply by a very small
value to a multiply by a medium-sized value.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1713693002
TBR=bsalomon@google.com
Committed: https://skia.googlesource.com/skia/+/e507ff0460f4f878214b9454fb5b9ab8d64d8063
Review URL: https://codereview.chromium.org/1713693002
2016-02-22 11:25:32 -08:00
benjaminwagner
01e5838076
Simplify calculations in AADistanceFieldPathBatch::writePathVertices.
...
No API changes.
BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1715063002
TBR=reed
Review URL: https://codereview.chromium.org/1715063002
2016-02-22 11:10:33 -08:00
bsalomon
f47b9a3b88
Allow client to force an SkImage snapshot to be unique (and uniquely own its backing store).
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1686163002
Review URL: https://codereview.chromium.org/1686163002
2016-02-22 11:02:58 -08:00
fmalita
8d9f2e474a
Add ContextRec param to SkShader::contextSize()
...
To facilitate upcoming context selection changes.
R=reed@google.com ,mtklein@google.com,herb@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720933002
Review URL: https://codereview.chromium.org/1720933002
2016-02-22 10:39:41 -08:00
reed
d778febae6
remove dead unpremul checks
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1715333004
Review URL: https://codereview.chromium.org/1715333004
2016-02-22 10:25:45 -08:00
egdaniel
32119f1ba0
Fix to bazel build file to exclude vulkan files
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1723593002
Review URL: https://codereview.chromium.org/1723593002
2016-02-22 10:07:54 -08:00