Commit Graph

38933 Commits

Author SHA1 Message Date
recipe-roller
15de6796d5 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/58649e3417cee816c9115e8c1ea55759ec534759 repo: update launcher to v1.13.1 (vapier@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifa520238e8b4ee5c366d2da68a6b45201aa3014b
Reviewed-on: https://skia-review.googlesource.com/c/179729
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-12-20 22:31:05 +00:00
Jim Van Verth
578b089986 Revert "Tweak Plot size to try to get better perf."
This reverts commit fdcbe206f5.

Reason for revert: Produced a further perf regression.

Original change's description:
> Tweak Plot size to try to get better perf.
> 
> Large plots allow tighter packing of large glyphs, but smaller plots
> take less time to update. Trying a size in between for the largest
> A8 size.
> 
> Bug: skia:8642
> Change-Id: Ib6d7651b70fe3a2101a3bfc5b367c433123cb914
> Reviewed-on: https://skia-review.googlesource.com/c/179242
> Commit-Queue: Jim Van Verth <jvanverth@google.com>
> Reviewed-by: Robert Phillips <robertphillips@google.com>

TBR=jvanverth@google.com,robertphillips@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: skia:8642
Change-Id: I9bc32abfae1fb4a6380b2fd5c0a1ea269447c534
Reviewed-on: https://skia-review.googlesource.com/c/179726
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2018-12-20 21:16:54 +00:00
Herb Derby
5a3fdeecdc Convert GrGlyph::PackedID to SkPackedGlyphID
This changes ripples through many areas of the code like the
hash map.

This will simplify making SkGlyphCache and GrTextStrike work
together in future CLs.

* Convert ctor to take an SkGlyph
* Remove many unused functions

Change-Id: I43ea414f03dfbb683ba7b46bf48a93c7a78895c6
Reviewed-on: https://skia-review.googlesource.com/c/179641
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2018-12-20 21:08:06 +00:00
Mike Reed
edce0aa152 add gm and fix origin for xform-based blobs
Bug: skia:
Change-Id: Id856f6db8afe4d0713ccb54a0a05765b272fe2e9
Reviewed-on: https://skia-review.googlesource.com/c/179723
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-12-20 20:50:54 +00:00
recipe-roller
7a53d0b6cb Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/354bb02e9c0b74eea43faa883ac1aa134c435e3c [swarming] Add support for environment variables. (joshuaseaton@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7eabbc37231694f788432e4ea7f0b75e876d8a8d
Reviewed-on: https://skia-review.googlesource.com/c/179722
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-12-20 20:49:05 +00:00
Greg Daniel
e4beab79cd Disable vulkan specific code in GrAHardwareBufferImageGenerator when not building vulkan.
Bug: skia:
Change-Id: I9584e7301292184441c9a2902b2277848b5e5cfc
Reviewed-on: https://skia-review.googlesource.com/c/179720
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-12-20 20:35:24 +00:00
recipe-roller
0c4ca3e19c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/0fad0863959ecf172fb460a7008eeabf8c8f078d [swarming] Minor clean-up and typo fixes. (joshuaseaton@google.com)
  https://crrev.com/1236ebd26cbcfae759c3857b26bd9bd1cf3547d2 [file] Introduce SymlinkTree (joshuaseaton@google.com)
  https://crrev.com/19c28875c9f1519cac7156e07dbb8e59ff40f7c1 [isolated] Add download method (joshuaseaton@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id20f65557f4d8a9155c0162708f4c11b2dabd95d
Reviewed-on: https://skia-review.googlesource.com/c/179660
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-12-20 20:18:59 +00:00
Herb Derby
4c35be021c Remove PackedID from the strike call chain
By removing the PackedID from the call chain, all the information
needed to lookup glyphs is gathered from the SkGlyph. I added some
code to allow this corrispondence between the SkGlyph and the PackedID.
But, in the next CL all that code will be removed as PackeID becomes
SkPackedGlyphID.

Remove unneeded inlines
Remove unused maskFormat parameter to getGlyph

Change-Id: Id6d876d7ad3f1b4303f8b9ecfc38f499fbedcf73
Reviewed-on: https://skia-review.googlesource.com/c/179640
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2018-12-20 20:17:57 +00:00
Brian Osman
2a4c4dfb81 Add wide color support to stroke rect op and default GP
Bug: skia:
Change-Id: Ie75985b9fd66352590901f78697f56554128b7d6
Reviewed-on: https://skia-review.googlesource.com/c/177620
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-12-20 20:08:59 +00:00
Mike Reed
42786e2892 remove some dead debugger command types
Bug: skia:
Change-Id: Ib629fdc688e7279510c616b871a0fb5e929cadc9
Reviewed-on: https://skia-review.googlesource.com/c/179562
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-12-20 20:00:00 +00:00
Herb Derby
b03e024a40 Make and use a ctor for GrGlyph
Make a ctor for GrGlyph. This allows some of the fields to be conts.
Rename fPool to fAlloc.

Change-Id: Ia828b219a9cb13b714fbfef96ae40157d68af368
Reviewed-on: https://skia-review.googlesource.com/c/179541
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-12-20 18:53:03 +00:00
skia-autoroll
9fbd2ad38c Roll third_party/externals/angle2 96c11cc79490..bcb7890895d2 (1 commits)
96c11cc794..bcb7890895


git log 96c11cc79490..bcb7890895d2 --date=short --no-merges --format='%ad %ae %s'
2018-12-20 ianelliott@google.com Implement eglSwapBuffersWithDamage on top of VK_KHR_incremental_present


Created with:
  gclient setdep -r third_party/externals/angle2@bcb7890895d2

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=halcanary@google.com

Change-Id: I5fd49f578e2c5f5aa206587c87297d3e62c28f1c
Reviewed-on: https://skia-review.googlesource.com/c/179586
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-12-20 18:10:53 +00:00
Herb Derby
37e21f6910 Move the maskStyle into the GrGlyph
Change-Id: I560e909a9d1882ae6777915e165c740b3751e544
Reviewed-on: https://skia-review.googlesource.com/c/179382
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-12-20 17:35:11 +00:00
Mike Reed
30cf62bf48 add rsxform runs to textblobs
Bug: skia:
Change-Id: I72a1921a0300dfdac567e25acbdf20cc168ac0be
Reviewed-on: https://skia-review.googlesource.com/c/175834
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2018-12-20 16:46:09 +00:00
Florin Malita
700ae55b22 Remove "EXPERIMENTAL" label from kDecal_TileMode
Should be fully supported now.

Change-Id: If269e57840343917353995af05d6044a9189bc99
Reviewed-on: https://skia-review.googlesource.com/c/179522
Auto-Submit: Florin Malita <fmalita@chromium.org>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
2018-12-20 16:22:39 +00:00
Daniel Bratell
7db91db6a0 Adding include guards to two headers that could be multiply included
SkFontConfigTypeface.h and SkOSFile_ios.h lacked include guards which
could trigger compilation issues in some Chromium build configurations.

Bug: skia:
Change-Id: I320f19af368333a132dc5b6859eb8ff365b4932a
Reviewed-on: https://skia-review.googlesource.com/c/179540
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-12-20 16:21:11 +00:00
Brian Salomon
f05e6d3a46 Remove superfluous budgeted params and member related to SkImage_GpuBase
The proxy/proxies in the SkImage_GpuBase subclasses already track
whether they're budgeted.

The parameters are sometimes redundantly stating the known budgeted
status of the proxy. Other times they are an illusion of control as
the value doesn't actually affected the budgeting of the proxy/proxies.

Change-Id: Ic2b12fbbed653fca1ec1910eeab686de69782834
Reviewed-on: https://skia-review.googlesource.com/c/179402
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-12-20 15:58:55 +00:00
Herb Derby
44539be30e Remove unused dtor from GrTextStrike
Change-Id: I65c95acba080cd4465f3343ab57beb19fcbb75f2
Reviewed-on: https://skia-review.googlesource.com/c/179381
Auto-Submit: Herb Derby <herb@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-12-20 13:38:07 +00:00
recipe-roller
428ec1e55c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/2cc6e25536698e4f87d516f5242dd9d30d3245ba [cpplint] Fix regexp for class decorators (clemensh@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0b968bbc6d2acd0ff2436f41c0dd088ccad60529
Reviewed-on: https://skia-review.googlesource.com/c/179403
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-12-20 09:14:41 +00:00
skia-autoroll
b41f58884a Roll third_party/externals/angle2 6f087e9e6020..96c11cc79490 (1 commits)
6f087e9e60..96c11cc794


git log 6f087e9e6020..96c11cc79490 --date=short --no-merges --format='%ad %ae %s'
2018-12-19 lethalantidote@chromium.org Revert "Compress symbols for libraries"


Created with:
  gclient setdep -r third_party/externals/angle2@96c11cc79490

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=halcanary@google.com

Change-Id: Idcb5e4a193fed01bb123027f387d6ee456c63819
Reviewed-on: https://skia-review.googlesource.com/c/179442
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-12-20 07:54:56 +00:00
skia-recreate-skps
2bcad71cc8 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I509ed3ed6c3023df16958acf1f8744e285039f34
Reviewed-on: https://skia-review.googlesource.com/c/179370
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-12-20 06:04:01 +00:00
recipe-roller
21ee517391 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/c3fbb33835795d43242ef673522148ade63a3cf0 [swarming,isolated] Add `on_path` methods. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8a6effcca9d39b73f361c94f147f54e4756df151
Reviewed-on: https://skia-review.googlesource.com/c/179401
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-12-20 02:34:02 +00:00
recipe-roller
7757bba636 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/540ba9dde07c16c0e91eea558a8b7ae15aa8c145 [ninjalog] add ninjalog.README.md (tikuta@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5908a334f68ae86d97b39d4db841f48d297d88e0
Reviewed-on: https://skia-review.googlesource.com/c/179258
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-12-19 23:08:37 +00:00
skia-autoroll
05338769af Roll third_party/externals/angle2 ffda3e2985f1..6f087e9e6020 (1 commits)
ffda3e2985..6f087e9e60


git log ffda3e2985f1..6f087e9e6020 --date=short --no-merges --format='%ad %ae %s'
2018-12-19 jmadill@chromium.org Modify end2end_tests main to not import ANGLETest.h.


Created with:
  gclient setdep -r third_party/externals/angle2@6f087e9e6020

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=halcanary@google.com

Change-Id: I0440f551a92cc031ed31640f1641ca166d73b03a
Reviewed-on: https://skia-review.googlesource.com/c/179301
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-12-19 22:53:15 +00:00
Hal Canary
748015840e SkPDF: SkPDFObject no longer reference-counted!
* sed 's/sk_sp<SkPDF\(Object\|Array\|Dict\)>/std::unique_ptr<SkPDF\1>/g'
  * Added SkPDFMakeDict()
  * Let SkPDFMakeArray() take zero arguments.

Bug: skia:8630

Change-Id: I08dc11e974f1d71e09a33af6bdbcb5f01b07d186
Reviewed-on: https://skia-review.googlesource.com/c/179063
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Auto-Submit: Hal Canary <halcanary@google.com>
2018-12-19 22:45:06 +00:00
recipe-roller
95be08426d Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/eba46fc12ea53534f0e68f92c3ffd7f7e5ff90f0 Improve error message when a toolchain can't be found (brucedawson@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6faed5bf0f327c5eee1f0492f5d0ecb482cd50ad
Reviewed-on: https://skia-review.googlesource.com/c/179256
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-12-19 22:38:06 +00:00
Brian Salomon
ce9a901a76 Remove checks for GL_CHROMIUM_unpack_flipy.
Chrome removed support for this extension in 2015:
https://codereview.chromium.org/1203793003

We still look for the extension, but make no use of it.

Change-Id: Id494b41839f4a22a4647d0c1b1581eabcc931ea1
Reviewed-on: https://skia-review.googlesource.com/c/179252
Commit-Queue: Brian Salomon <bsalomon@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Auto-Submit: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-12-19 21:34:33 +00:00
Brian Salomon
8d2abe9a6c Manual ANGLE roll to ffda3e2985f18f4ff6e3778af8b9715109b21ad0
720ca44976..ffda3e2985

Change-Id: I30d421c35f6e844166c69dfb837006f46281a23f
Reviewed-on: https://skia-review.googlesource.com/c/179246
Auto-Submit: Brian Salomon <bsalomon@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Hal Canary <halcanary@google.com>
2018-12-19 21:16:02 +00:00
Brian Salomon
614c1a838a Add idle texture callback mechanism.
A proc can be registered with a GrTexture. The proc will be called when
it is safe to delete the texture is "idle." Idle means it referred to
outside of GrResourceCache and that the I/O operations on the GPU are
completed (this latter part applieas to Vulkan only).

The intended use case for this is to call promise image texture release
procs once we start caching GrTextures for deinstantiated promise
images.

Bug= skia:8613

Change-Id: Idce9a4292fef7b15370a053060d8878a9d6828fa
Reviewed-on: https://skia-review.googlesource.com/c/178937
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-12-19 21:12:42 +00:00
Hal Canary
fde1875f50 SkPDF: debugging flag - SK_PDF_BASE85_BINARY
If this is defined at compile time, binary date embedded in PDFs are
encoded n base85 to make them more inspectable.  This is only useful to
anyone hacking on SkPDF.

If the flag is unset, there is no change from this CL.

Change-Id: Ib07dc7ef7cedbff17a5fde0ffbeccd24dbeb6a8e
Reviewed-on: https://skia-review.googlesource.com/c/179250
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2018-12-19 20:59:11 +00:00
Brian Salomon
bf3e486a5c Don't use client side buffers with WebGL
Change-Id: I00575f7ebbac89646d65cd6cefbf4715c9bd3914
Reviewed-on: https://skia-review.googlesource.com/c/179249
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-12-19 20:47:29 +00:00
Jim Van Verth
fdcbe206f5 Tweak Plot size to try to get better perf.
Large plots allow tighter packing of large glyphs, but smaller plots
take less time to update. Trying a size in between for the largest
A8 size.

Bug: skia:8642
Change-Id: Ib6d7651b70fe3a2101a3bfc5b367c433123cb914
Reviewed-on: https://skia-review.googlesource.com/c/179242
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-12-19 20:43:03 +00:00
Brian Salomon
88f1fa54fd Infer GL null buffer hint usage from whether on command buffer or WebGL.
Change-Id: I7d93fabf5d4cc427cef8130fd0a3e8765e4b3693
Reviewed-on: https://skia-review.googlesource.com/c/179248
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-12-19 20:28:05 +00:00
Mike Klein
8354c52cb3 unify lowp stage argument lists
This should be a harmless codegen no-op, and helps me with some ideas
I'm hacking around with.  I wouldn't mind keeping this landed even if
those experiments don't pan out.  Tested by diffing disassembly.

Change-Id: I13c6f83871c3adf7031f68cbc9ff92caf481034a
Reviewed-on: https://skia-review.googlesource.com/c/179221
Commit-Queue: Herb Derby <herb@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Herb Derby <herb@google.com>
2018-12-19 19:55:05 +00:00
Ethan Nicholas
92e01cfc82 added SPIR-V persistent cache support for Vulkan
Bug: skia:
Change-Id: Iec9053655f6ec2cc49a90c4b686995feaff6e488
Reviewed-on: https://skia-review.googlesource.com/c/178923
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-12-19 18:42:18 +00:00
Brian Salomon
fee3f9b799 Make GrSurfaceProxy::Copy take SkBackingFit.
Change-Id: I492a685459a8a2e2a8074d3e504304a6e33dbd92
Reviewed-on: https://skia-review.googlesource.com/c/178938
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Auto-Submit: Brian Salomon <bsalomon@google.com>
2018-12-19 18:00:44 +00:00
Brian Salomon
8d23a584fc In ddl2 via clear to transparent between runs.
Change-Id: I0cc904a76b30212a66b1cc00abdf2fff7686acc4
Reviewed-on: https://skia-review.googlesource.com/c/179240
Auto-Submit: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-12-19 17:46:44 +00:00
Brian Salomon
77e1ccf3cd Make requiring VBOs a runtime rather than compile time decision.
Change-Id: I764f8f342ae212df66f647e005ff237c41411b75
Reviewed-on: https://skia-review.googlesource.com/c/179202
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-12-19 15:54:35 +00:00
Ben Wagner
bb7d3813d3 [infra] Set GOCACHE in tasks that use go.
Bug: skia:8423
Change-Id: If079c958cb9d0d82fe13da44aaebd5913b40b9d1
Reviewed-on: https://skia-review.googlesource.com/c/179065
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-12-19 15:09:59 +00:00
Michael Ludwig
257a03dde2 Integrate clamp to border into FP optimization flags
Bug: skia:
Change-Id: I89bf20a06942e8d00168c5e8b50b336e99785b9a
Reviewed-on: https://skia-review.googlesource.com/c/177502
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-12-19 14:58:39 +00:00
Mike Reed
148b7fd3ad add saveBehind to canvas
Bug: skia:
Change-Id: I62e48b116b2d7efef585d4f465441f24ae4d2b29
Reviewed-on: https://skia-review.googlesource.com/c/177892
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-12-19 14:44:09 +00:00
Ben Wagner
435880277e [infra] Use go_deps asset for Bookmaker tasks
Fix PATH to point to go_deps/bin.

Bug: skia:8423
Change-Id: I853a0741238442e7fd5b3c23cacb3d2f9c6893fa
Reviewed-on: https://skia-review.googlesource.com/c/179064
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-12-19 14:41:32 +00:00
Brian Salomon
2cb3b9535b Remove GR_GL_USE_NEW_SHADER_SOURCE_SIGNATURE flag.
Enough's enough. It's been a long time since the standard was updated.

Change-Id: I49ae08ee49f06cb8403c9cb72a811edd35b25575
Reviewed-on: https://skia-review.googlesource.com/c/178930
Auto-Submit: Brian Salomon <bsalomon@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-12-19 14:15:01 +00:00
Ben Wagner
c59caa4060 Remove Go asset from tasks that don't need it.
Bug: skia:8423
Change-Id: I4827e0f261cb300a0699cbf590bac8786a5c36a1
Reviewed-on: https://skia-review.googlesource.com/c/179062
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-12-19 13:34:11 +00:00
Ben Wagner
1a237195b5 Omit SKP that might cause MacBook10.1 to die.
Bug: skia:8643
Change-Id: I491b67680eae4ee400cadb9afebaab4f9a9def9e
Reviewed-on: https://skia-review.googlesource.com/c/179061
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Auto-Submit: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2018-12-19 12:36:38 +00:00
skia-recreate-skps
192d664409 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I7bbcfef8ca526830a5222ef33dc4e63c5cfad073
Reviewed-on: https://skia-review.googlesource.com/c/179120
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-12-19 05:48:35 +00:00
Hal Canary
6d7f9d6f28 SkQP: experimental docker script cleanup, try 2
No-Try: true
Change-Id: Icc62d2d6b0f35de757022fc7fdde1f748658c060
Reviewed-on: https://skia-review.googlesource.com/c/178925
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2018-12-19 03:25:42 +00:00
Hal Canary
f34131ae9b SkPDF: even more PDFIndirectRefs
* SkPDFUnion.h hidden.
  * SkPDFObjectSerializer::serializeObject gone.
  * SkPDFDocument::serialize gone
  * SkPDFMetadata::MakeXMPObject return PDFIndirectRef
  * SkPDFTag rewritten from scratch.
  * SkPDFObject::addResources virtual gone.
  * SkPDFObject::drop virtual gone.
  * SkPDFArray::appendObjRef gone.
  * SkPDFDict::insertObjRef gone.
  * SkPDFDict::Record becomes std::pair
  * SkPDFObjNumMap gone;
  * SkPDFObject::fIndirectReference gone;

Bug: skia:8630
Change-Id: I7425eef30548b54f10fbfe96dd502800cb150caf
Reviewed-on: https://skia-review.googlesource.com/c/178935
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2018-12-19 03:20:42 +00:00
recipe-roller
b933285ebb Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/f18aaf4f57453ecd2ab9983bf47d3d4f85ab0d35 [cipd] Update CIPD client to v2.2.15. (vadimsh@chromium.org)
  https://crrev.com/da32affb47ce32ba301eba82e53530349d8e6db5 OWNERS: start a CrOS specific list for CrOS files in here (vapier@chromium.org)
  https://crrev.com/f9b112641ca37c28df20e80c3d03361b7a629f45 OWNERS: drop support/chromite_wrapper for now (vapier@chromium.org)
recipe_engine:
  https://crrev.com/3f3879c37865ac94e52e8d91a70399ca37ae4fb8 Make aggregated InfraFailures surface as exceptions. (joshuaseaton@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic3d05489c3629d8837277d640a4839ee7c33c267
Reviewed-on: https://skia-review.googlesource.com/c/178939
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-12-18 23:08:29 +00:00
Mike Klein
67761eb35f drop into raster pipeline at 32767
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Change-Id: I01843017f9c2674f4ab8b219d36ad8a2e5a7b400
Reviewed-on: https://skia-review.googlesource.com/c/178982
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-12-18 22:54:29 +00:00