msarett
16b15ddd4d
Blacklist incomplete pngs on CG
...
BUG=skia:5774
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2351083002
Review-Url: https://codereview.chromium.org/2351083002
2016-09-20 05:50:16 -07:00
rmistry
304e6745dc
Reland of Run SVGs through nanobench on all Perf bots (patchset #1 id:1 of https://codereview.chromium.org/2348563003/ )
...
Reason for revert:
skbug/5770 has been fixed.
Trying out trybots to see if this can be relanded.
Original issue's description:
> Revert of Run SVGs through nanobench on all Perf bots (patchset #5 id:120001 of https://codereview.chromium.org/2343903002/ )
>
> Reason for revert:
> Causing failures:
> https://uberchromegw.corp.google.com/i/client.skia/builders/Perf-Mac-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Debug-GN/builds/812
>
> Original issue's description:
> > Run SVGs through nanobench on all Perf bots.
> >
> > Tested with:
> > python infra/bots/recipes.py run --workdir=../ swarm_trigger path_config=kitchen buildername=Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot mastername=client.skia slavename=skiabot-linux-swarm-010 buildnumber=1 revision=d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c issue=2343903002 rietveld=https://codereview.chromium.org patchset=80001
> >
> > Example output is here:
> > https://luci-milo.appspot.com/swarming/task/3147c9789b2d0410
> > Nanobench did run on SVGs.
> >
> > BUG=skia:5757
> > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343903002
> >
> > Committed: https://skia.googlesource.com/skia/+/1c58dcb909642454d91ba36f71e55597511b5d52
>
> TBR=jcgregorio@google.com ,fmalita@chromium.org,mtklein@google.com
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:5757
>
> Committed: https://skia.googlesource.com/skia/+/be7e3c0db3caa7a86ae233a6bd26281817b83882
TBR=jcgregorio@google.com ,fmalita@chromium.org,mtklein@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=skia:5757
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2350233002
Review-Url: https://codereview.chromium.org/2350233002
2016-09-19 13:44:25 -07:00
hinoka
f15590f803
Skia recipe: Use [depot_tools]/gsutil.py instead of [depot_tools]/third_party/gsutil/gsutil
...
The latter is being removed in https://codereview.chromium.org/2280023003/
Is also pinned to 3.25, whereas the former is updated more often.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2298293002
Review-Url: https://codereview.chromium.org/2298293002
2016-09-19 12:18:55 -07:00
mtklein
122fac3061
GN: remove old Android recipe code.
...
All the Android builders, testers, and perfers are on gn_android_flavor now.
Not as scary as it looks... all the big line count changes are deletes.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2352653002
Review-Url: https://codereview.chromium.org/2352653002
2016-09-19 07:26:42 -07:00
mtklein
cfea18abe2
Delete unused coverage recipe code.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2353483003
Review-Url: https://codereview.chromium.org/2353483003
2016-09-19 07:04:37 -07:00
update-skps
5d1110ed46
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2349953002
Review-Url: https://codereview.chromium.org/2349953002
2016-09-18 02:34:52 -07:00
msarett
c6c81e1ff8
Fix filling of incomplete images in SkSampledCodec
...
The bug occurs when filling after an incomplete sampled/subset
incremental decode.
I'm also adding many truncated test pngs.
BUG=skia:5769
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343153003
Review-Url: https://codereview.chromium.org/2343153003
2016-09-16 14:52:07 -07:00
rmistry
be7e3c0db3
Revert of Run SVGs through nanobench on all Perf bots (patchset #5 id:120001 of https://codereview.chromium.org/2343903002/ )
...
Reason for revert:
Causing failures:
https://uberchromegw.corp.google.com/i/client.skia/builders/Perf-Mac-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Debug-GN/builds/812
Original issue's description:
> Run SVGs through nanobench on all Perf bots.
>
> Tested with:
> python infra/bots/recipes.py run --workdir=../ swarm_trigger path_config=kitchen buildername=Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot mastername=client.skia slavename=skiabot-linux-swarm-010 buildnumber=1 revision=d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c issue=2343903002 rietveld=https://codereview.chromium.org patchset=80001
>
> Example output is here:
> https://luci-milo.appspot.com/swarming/task/3147c9789b2d0410
> Nanobench did run on SVGs.
>
> BUG=skia:5757
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343903002
>
> Committed: https://skia.googlesource.com/skia/+/1c58dcb909642454d91ba36f71e55597511b5d52
TBR=jcgregorio@google.com ,fmalita@chromium.org,mtklein@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:5757
Review-Url: https://codereview.chromium.org/2348563003
2016-09-16 12:06:56 -07:00
mtklein
bfef32ff0a
Build with GN on CT bots.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347203002
Review-Url: https://codereview.chromium.org/2347203002
2016-09-16 11:39:14 -07:00
rmistry
1c58dcb909
Run SVGs through nanobench on all Perf bots.
...
Tested with:
python infra/bots/recipes.py run --workdir=../ swarm_trigger path_config=kitchen buildername=Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot mastername=client.skia slavename=skiabot-linux-swarm-010 buildnumber=1 revision=d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c issue=2343903002 rietveld=https://codereview.chromium.org patchset=80001
Example output is here:
https://luci-milo.appspot.com/swarming/task/3147c9789b2d0410
Nanobench did run on SVGs.
BUG=skia:5757
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343903002
Review-Url: https://codereview.chromium.org/2343903002
2016-09-16 11:32:34 -07:00
rmistry
3d5541dc3d
Fix Seal_of_Mississippi URL and update version of SVG asset.
...
BUG=skia:5757
BUG=skia:5767
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342323002
Review-Url: https://codereview.chromium.org/2342323002
2016-09-16 08:26:35 -07:00
mtklein
f29180e65a
GN: enable Vulkan on Android when API >= 24.
...
Android API >= 24 implies Vulkan support, so we can have a more useful default here than 'false'. If for some reason you wanted to turn it off, you can still override skia_use_vulkan.
The defined(ndk_api) guards other users of our GN files (Fuchsia) who may not have an ndk_api argument defined in their BUILDCONFIG.gn.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347843003
Review-Url: https://codereview.chromium.org/2347843003
2016-09-16 07:01:17 -07:00
mtklein
fe6ca0f798
GN: port Valgrind bots.
...
This was suspiciously easy...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342923002
Review-Url: https://codereview.chromium.org/2342923002
2016-09-15 13:50:43 -07:00
djsollen
615af784ab
Revert of Update version of SVG asset (patchset #1 id:1 of https://codereview.chromium.org/2341043003/ )
...
Reason for revert:
breaking the build
Original issue's description:
> Update version of SVG asset
>
> BUG=skia:5757
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2341043003
>
> Committed: https://skia.googlesource.com/skia/+/ab00f4222c9fff8c08873e1218e79f49845f95a1
TBR=borenet@google.com ,rmistry@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:5757
Review-Url: https://codereview.chromium.org/2337763007
2016-09-15 13:04:41 -07:00
mtklein
1fbdf98d0e
GN: support 32-bit x86 builds
...
Take over Ubuntu -x86- bots.
Note the change to Build-Win-MSVC-x86-Release-GN.json, which is not incidental.
We'll want target_cpu="x86" there too.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340463008
Committed: https://skia.googlesource.com/skia/+/1949386ae00485ae92dd5608a2614b9dee417542
CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-Clang-x86-Debug-GN_Android-Trybot,Build-Ubuntu-GCC-x86-Release-Trybot
Review-Url: https://codereview.chromium.org/2340463008
2016-09-15 12:07:48 -07:00
rmistry
ab00f4222c
Update version of SVG asset
...
BUG=skia:5757
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2341043003
Review-Url: https://codereview.chromium.org/2341043003
2016-09-15 11:31:25 -07:00
mtklein
56d5669095
Revert of GN: support 32-bit x86 builds (patchset #6 id:100001 of https://codereview.chromium.org/2340463008/ )
...
Reason for revert:
https://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86-Debug-GN_Android/builds/304
Original issue's description:
> GN: support 32-bit x86 builds
>
> Take over Ubuntu -x86- bots.
>
> Note the change to Build-Win-MSVC-x86-Release-GN.json, which is not incidental.
> We'll want target_cpu="x86" there too.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340463008
>
> Committed: https://skia.googlesource.com/skia/+/1949386ae00485ae92dd5608a2614b9dee417542
TBR=jcgregorio@google.com ,borenet@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2338173004
2016-09-15 11:18:56 -07:00
mtklein
1949386ae0
GN: support 32-bit x86 builds
...
Take over Ubuntu -x86- bots.
Note the change to Build-Win-MSVC-x86-Release-GN.json, which is not incidental.
We'll want target_cpu="x86" there too.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340463008
Review-Url: https://codereview.chromium.org/2340463008
2016-09-15 11:06:25 -07:00
mtklein
1bf8e6e16e
Blacklist slsrgb + image decoding.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2345723003
Review-Url: https://codereview.chromium.org/2345723003
2016-09-15 11:02:05 -07:00
rmistry
5caf398cac
Add ability to create and upload SVGs from a local dir
...
BUG=skia:5757
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2346663003
Review-Url: https://codereview.chromium.org/2346663003
2016-09-15 09:33:08 -07:00
borenet
e715d2daf7
Fix NoGPU bot, which is compiling in GPU support
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342683003
Review-Url: https://codereview.chromium.org/2342683003
2016-09-15 09:08:48 -07:00
mtklein
0973a371ec
Pass rietveld as the default patch_storage.
...
Passing around empty strings as command line arguments requires
us to be really careful about command line quoting, parsing, etc.
It seems easy enough here to just supply the implied value.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2323233003
Review-Url: https://codereview.chromium.org/2323233003
2016-09-15 08:27:33 -07:00
mtklein
09b352f75f
Tidy up DM blacklists.
...
No need to blacklist specific instances of configs that won't be run.
There's no bug or anything here... this is entirely about keeping the
command lines as noise-free as possible.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2341963003
Review-Url: https://codereview.chromium.org/2341963003
2016-09-15 06:24:03 -07:00
rmistry
90d0bfae4e
Roll recipe DEPS
...
BUG=skia:5749
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339443003
NOTREECHECKS=true
Review-Url: https://codereview.chromium.org/2339443003
2016-09-15 04:52:21 -07:00
mtklein
7de2d40dcc
merge run and check-rc steps
...
This'll make the 'dm' or 'nanobench' step go red like you'd hope.
The N5 should pass and the N10 and N7 should fail, showing us both sides.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339713003
Review-Url: https://codereview.chromium.org/2339713003
2016-09-14 11:15:54 -07:00
mtklein
896ddb706d
565 is not this important.
...
Reduce its testing and perfing to just the fast Linux bots,
and remove it from the default set of dm/nanobench configs.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344553002
Review-Url: https://codereview.chromium.org/2344553002
2016-09-14 10:33:13 -07:00
mtklein
4ff7871ed3
update derive_compile_bot_name() for GN_Android_Vulkan
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336233005
Review-Url: https://codereview.chromium.org/2336233005
2016-09-14 05:44:31 -07:00
mtklein
53c02e0156
Android GN scripts: distingush directories for data and binaries.
...
This enables data reuse, e.g. https://luci-milo.appspot.com/swarming/task/313eff129c753d10 or https://luci-milo.appspot.com/swarming/task/313f17a174c6c710
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335203004
Review-Url: https://codereview.chromium.org/2335203004
2016-09-14 05:33:11 -07:00
mtklein
357f9d2032
Update gn_android_flavor for Vulkan.
...
C.f. https://codereview.chromium.org/2336343002 for basic GN support.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333293004
Review-Url: https://codereview.chromium.org/2333293004
2016-09-13 13:50:10 -07:00
mtklein
ea8b2b076c
Android GN: don't reboot before running
...
We're already rebooting after running, so we should already be ready to go when the task starts.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2334223003
Review-Url: https://codereview.chromium.org/2334223003
2016-09-13 13:13:54 -07:00
mtklein
649985a530
Remove clear /data/local/tmp steps.
...
These were intended to prevent GN and GYP Android bots from stomping on
each other. Turns out, they don't, even without this... they're writing
most files to completely separate paths:
- GYP puts most data under $EXTERNAL_STORAGE, generally /sdcard
and its binaries (libdm.so, libnanobench.so, libskia.so, skia_launcher)
in /data/local/tmp;
- GN puts everything under /data/local/tmp, and its binaries (dm, nanobench)
don't overlap GYP's.
So clearing /data/local/tmp was essentially just removing GN's data; GYP's
data file caching was never affected and can't conflict with GN's.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340473002
Review-Url: https://codereview.chromium.org/2340473002
2016-09-13 11:17:58 -07:00
msarett
f7eb6fc71a
Implement Fill() for incomplete decodes to RGBA_F16
...
Before this patch, we would hit an SkASSERT(false).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335203002
Review-Url: https://codereview.chromium.org/2335203002
2016-09-13 09:04:11 -07:00
mtklein
5718b2df4c
I missed an infra_step, pushing directories.
...
NOTREECHECKS=true
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2337793003
Review-Url: https://codereview.chromium.org/2337793003
2016-09-13 07:20:47 -07:00
mtklein
41313595f9
Mark infra steps as infra_step in GN recipe flavors.
...
NOTREECHECKS=true
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2329943004
Review-Url: https://codereview.chromium.org/2329943004
2016-09-13 05:49:16 -07:00
borenet
ea5de1ff1d
Add back the GalaxyS3 and GalaxyS4 entries in recipes
...
S3 is needed for some recipe simulation stuff and in general having
these present does not hurt us.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336513003
Review-Url: https://codereview.chromium.org/2336513003
2016-09-12 14:02:14 -07:00
mtklein
df5df81084
GN: Android perf/tests
...
Just to take inventory of which old problems still linger and which are now moot, I've gone out of my way to have this stand alone. All of gn_android_flavor's logic is self contained, without any dependency on the platform_tools scripts.
The tricky bits turn out to be, copying directories containing symlinks---or really any copying involving more than one file---and getting the exit code back from adb shell. Luckily the ADB I've got on my desktop and my Nexus 5x seems to handle this all without the awkward workarounds you see here, so there's hope that One Day Soon the weird parts (basically, anything with inline python) can go away. Once we've got these bots landed green, I'll go see whether the fixes are due to ADB updates, Android updates, or perhaps something else like hardware.
The parts marked TEMPORARY are a nod to the fact that the devices are used by gn_android_flavor and android_flavor both today. It's mostly about not stepping on each other's toes or leaving anything laying around that might confuse each other. The marked parts can go away when bots are either gn_ or non-gn_ but not both.
I have omitted a few steps that may be important, but which are easy independent follow-ups:
- running as root
- locking clocks
- waiting on battery levels
- fancier wait-for-ready than adb wait-for-usb-device
It'd be nice to, e.g., reaffirm that locking clocks helps perf stability, and that we're locking to the best policy. I've tried to keep this CL as trim as possible, leaving any of these vaguely optional steps for later.
As of PS 41 or so, it looks like the trybots are all behaving as expected.
We should expect no new images in Gold. Can we see trybots in Perf yet?
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2320153002
CQ_INCLUDE_TRYBOTS=master.client.skia.android:Perf-Android-Clang-AndroidOne-CPU-MT6582-arm-Debug-GN_Android-Trybot,Perf-Android-Clang-AndroidOne-CPU-MT6582-arm-Release-GN_Android-Trybot,Perf-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Debug-GN_Android-Trybot,Perf-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Release-GN_Android-Trybot,Test-Android-Clang-AndroidOne-CPU-MT6582-arm-Debug-GN_Android-Trybot,Test-Android-Clang-AndroidOne-CPU-MT6582-arm-Release-GN_Android-Trybot,Test-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Debug-GN_Android-Trybot,Test-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Release-GN_Android-Trybot
Review-Url: https://codereview.chromium.org/2320153002
2016-09-12 12:24:38 -07:00
borenet
09524ae429
Fix device cfg for GalaxyS7
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2330093002
Review-Url: https://codereview.chromium.org/2330093002
2016-09-12 11:56:37 -07:00
borenet
f5b7a5490b
Run recipes.py with --timestamps
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2330123002
Review-Url: https://codereview.chromium.org/2330123002
2016-09-12 11:51:26 -07:00
update-skps
dddbbda3f3
Update SKP version
...
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2334483002
Review-Url: https://codereview.chromium.org/2334483002
2016-09-11 02:21:46 -07:00
borenet
a42405aa52
Fix issues in assets scripts
...
- Delete unconditionally uses 'gsutil'
- args.gsutil not plumbed properly
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2326663002
Review-Url: https://codereview.chromium.org/2326663002
2016-09-09 05:37:29 -07:00
kjlubick
b4403ee980
Fix strange failures on Android N
...
We were seeing problems where dm ended with exit code 0, but the step still failed.
It seems they changed what N returns when a thing completes.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319843003
TBR=bugsbunny
Review-Url: https://codereview.chromium.org/2319843003
2016-09-08 13:04:31 -07:00
mtklein
3b10b37a1c
most is fine for *SAN bots now
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2326553002
Review-Url: https://codereview.chromium.org/2326553002
2016-09-08 09:30:20 -07:00
mtklein
e19c179281
Clean up target_os=llvm now that it does nothing.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2317373004
Review-Url: https://codereview.chromium.org/2317373004
2016-09-08 09:19:00 -07:00
mtklein
2b3c2a3ff9
GN: add sanitize arg
...
Attempt to take over all *SAN builds.
MSAN has a lot of coordination required between gn/BUILD.gn and gn_flavor.py.
I'd like to follow up to move more of this into gn/BUILD.gn, to make it easier
to use locally.
The compile steps should be much faster now. We no longer build CMake
and Clang for every run, instead using the clang_linux CIPD package. This
removes the need for all the third_party/externals/llvm/... dependencies.
Similarly, since we're using the clang_linux package, we no longer depend
on Chrome's Clang, and thus no longer need to sync chromium on these bots.
Instead of packaging up MSAN libraries and llvm-symbolizer in the compile
output, I have the test / perf bots also depend on the clang_linux package.
These do not vary from build to build.
No more need for the xsan.blacklist -include hack: Clang, GN, and Ninja
all track changes to xsan.blacklist without our help.
This has the incidental effect of upgrading the compiler used by *SAN
bots from Clang 3.8 to Clang 3.9.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2289343002
Review-Url: https://codereview.chromium.org/2289343002
2016-09-08 08:39:34 -07:00
borenet
2172d55eb5
Asset management: Download from GS store instead of CIPD
...
This avoids strange CIPD symlink/permissions issues
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321623003
Review-Url: https://codereview.chromium.org/2321623003
2016-09-08 06:55:59 -07:00
mtklein
34ffb342f5
GN: do not set default GN args
...
It's just visual noise... this should make future gn_flavor.py
changes show fewer incidental diffs.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324573002
Review-Url: https://codereview.chromium.org/2324573002
2016-09-08 06:49:05 -07:00
msarett
e99883f33b
Add color xform support to SkWebpCodec
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294993002
Committed: https://skia.googlesource.com/skia/+/828ed1777da74692d0c8a5834017929f5aedcc6b
Review-Url: https://codereview.chromium.org/2294993002
2016-09-08 06:05:35 -07:00
msarett
2eb00e7b77
Revert of Add color xform support to SkWebpCodec (patchset #2 id:80001 of https://codereview.chromium.org/2294993002/ )
...
Reason for revert:
Windows bots hate it when I upload new images.
Original issue's description:
> Add color xform support to SkWebpCodec
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294993002
>
> Committed: https://skia.googlesource.com/skia/+/828ed1777da74692d0c8a5834017929f5aedcc6b
TBR=scroggo@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2318253004
2016-09-07 18:53:14 -07:00
msarett
828ed1777d
Add color xform support to SkWebpCodec
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294993002
Review-Url: https://codereview.chromium.org/2294993002
2016-09-07 18:05:24 -07:00
mtklein
1a9466799e
clang_linux: also build an MSAN libc++
...
This will be used by MSAN bots: build with -stdlib=libc++,
then run with LD_LIBRARY_PATH=/path/to/clang_linux/msan.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324503002
Review-Url: https://codereview.chromium.org/2324503002
2016-09-07 12:26:53 -07:00