Commit Graph

44260 Commits

Author SHA1 Message Date
Kevin Lubick
16d998f24b [canvaskit] fix null terminator on drawText
Bug: skia:9314
Change-Id: I09449276b687caf8397c901b391cb882537ef5d0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244498
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-09-26 17:26:03 +00:00
Brian Salomon
14c514d9f8 srgb texture format cleanup.
We now think of them as regular formats that happen to have a different
data encoding, orthogonal to color space, but we still have some
unnecessary special handling.

Remove sRGB support from GrCaps.

Move sRGB write control to GrGLCaps.

Detect texture and render support separately.

Support in WebGL.

Remove workaround in Vulkan for x86 PowerVR.

Remove SkSurface_Gpu::Valid().

Change-Id: I2aaf4bdd4cd1caeeee04bfe8ab539924cdb35bd1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244506
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-09-26 17:19:38 +00:00
Michael Ludwig
a76620658b Improve subpixel coverage calculation for thin quads
In the linked bug, the 1px stroked rectangles would either be treated as
a regular AA rectangle with full coverage interior, or as a subpixel
rectangle that would have to calculate reduced coverage for the interior.
The translations of the coordinates meant that floating point precision
caused the <1px test to go one way or the other since these rectangles
were exactly on the boundary.

However, the subpixel coverage calculator, as-originally-implemented,
suffered from being discontinuous right at 1px if the rectangle was
rotated, so there'd be a noticeable pop in intensity of the shape when
animating across the 1px boundary.

This CL changes the subpixel coverage calculation to no longer be
dependent on the orientation of the quadrilateral w/ respect to the pixel
grid, and still be accurate when the shape is a rectangle. When it is
an arbitrary quad, the approximation isn't geometrically correct but
exhibits qualitatively good behavior. It also has the benefit of being
much simpler code.

Bug: chromium:1007154
Change-Id: I1e001e5d5d4e4f7a5e566e10855fd03eac613d07
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244504
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2019-09-26 16:42:36 +00:00
Brian Salomon
614cdab25d Check support for each GL format independently.
Previous code tried to aggregate some checks, but therefore had several
subtle bugs. Make each format check independent. It's easier to check
whether it's correct by looking up the specs/extensions referenced and
tweak it if not.

Also removes some "workarounds" that were just working around our own
bugs in extension/version detection.

Also adds some more WebGL format functionality.

Also uses glTexStorage2D for formats that previously did not check for
support.

Use glTexStorage2D on Android/NVIDIA to work around N9 and Shield TV
issues with glTexImage2D.

Bug: chromium:1003481

Change-Id: Ie3295b1ca76a6068f1426e77783d9dc07698c56a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/243816
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2019-09-26 16:30:46 +00:00
Florin Malita
49c0732570 [skottie] Add null sink option for skottie_tool
Useful for excluding encoder/IO from scaling tests.

Change-Id: Ib76cc07a54d3cd3e00b4a3b3c9ea6f049440b7f8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244396
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-09-26 16:11:14 +00:00
Herb Derby
53eb1ec5d5 Restrict SkStrikeInterface to GPU and rename to SkStrikeForGPU
SkStrikeInterface has become more and more focused on support of the GPU
stack. Finishing this focus clears up some of the confusing parts of the
Bitmap code.

Remove use of SkStrikeInterface from the BitmapCode.

Change-Id: I18a50d3ec17d81fcbe55030a3a3ec7eeeba23497
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244297
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2019-09-26 16:06:48 +00:00
Ethan Nicholas
85705c1b3b Revert "remove 'in uniform' support from GrSkSLFP, make rules more clear"
This reverts commit ac18a5ca60.

Reason for revert: breaking Chrome roll

Original change's description:
> remove 'in uniform' support from GrSkSLFP, make rules more clear
> 
> Bug: skia:
> Change-Id: Iaa4d33c1bfb295d87343411ba6aacc8fae68ef9c
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244300
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>

TBR=brianosman@google.com,ethannicholas@google.com

Change-Id: I6e53f5197c751d961abfa21861b940d4168de213
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244508
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2019-09-26 16:04:26 +00:00
Florin Malita
fbe61189f6 [skottie] Minor MotionBlurEffect cleanup
Change-Id: I9d02ff9f6bcc86cdc10e01a4e3379014557172e9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244507
Commit-Queue: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-09-26 16:01:44 +00:00
Herb Derby
4e8f63a92a Blur both in x and y
Change-Id: Iea4ad298fe472182411a0246b8bae2972523c575
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244263
Auto-Submit: Herb Derby <herb@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2019-09-26 15:17:51 +00:00
Ethan Nicholas
ac18a5ca60 remove 'in uniform' support from GrSkSLFP, make rules more clear
Bug: skia:
Change-Id: Iaa4d33c1bfb295d87343411ba6aacc8fae68ef9c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244300
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2019-09-26 14:05:10 +00:00
recipe-roller
403f2955e7 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/d0b2d249e189cfec7a051393a095031d6427f193 Refactoring Context API (liviurau@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I102e5e701edf2f79c783e6bdf0fe4da8a95e2fff
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244484
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-09-26 11:41:00 +00:00
recipe-roller
32f3c95a32 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/1e7de3da0e9935baa8bd6ff46e410846728643a0 [luciexe] Use proper base log name for url. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I761e712d5b6420e54954cb8674cc7c5cae70048f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244480
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-09-26 11:10:00 +00:00
recipe-roller
96c490cf20 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/bdb99d9b9906a2abfdf8965e4889a63462fd049e Expose ability to explicitly close currently open step to userspace. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5f704c2410ace30952844f53728d7bc18c7091e5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244476
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-09-26 10:21:09 +00:00
recipe-roller
26f49b1689 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/bb7ba6bbd413d490ff7a74bcf1bbfcfa7247ae5c [luciexe] Protocol updates/fixes. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I604b908c3f1964ee07c69bce453fbf9d15765198
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244450
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-09-26 08:41:54 +00:00
recipe-roller
26e084ad9c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/53f8e3450bf14f7bad9c585a4b9d6cf49768e72f [protos] Generalize update script and update protos. (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id056cdb5791a3ffc54866f91e320215f1fcbd9ca
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244445
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-09-26 08:11:09 +00:00
skia-autoroll
e3ac69eb2f Roll third_party/externals/angle2 ba04be8c9ef9..f703443b1f67 (6 commits)
ba04be8c9e..f703443b1f

git log ba04be8c9ef9..f703443b1f67 --date=short --no-merges --format='%ad %ae %s'
2019-09-25 jmadill@chromium.org Use Resource IDs in RefCountObject.
2019-09-25 jmadill@chromium.org Vulkan: Store current Serial in RendererVk.
2019-09-25 ynovikov@chromium.org Temporarily disable SwiftShader everywhere.
2019-09-25 jonahr@google.com GLX: Forward XExposeEvents to parent window
2019-09-25 hckim.kim@samsung.com Vulkan: Enable GPU conversion from RGB16F to RGBA16F
2019-09-25 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 3a762d54f649..527a689307a4 (5 commits)

Created with:
  gclient setdep -r third_party/externals/angle2@f703443b1f67

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Bug: None
TBR=bungeman@google.com
Change-Id: Ifa9d74aa5159da5e7cca103804b27f2d359f6541
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244428
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-09-26 05:43:08 +00:00
skia-recreate-skps
649d1a1a9b Update Go deps
Change-Id: I3820a1b6ae1c636a0322aae04ce53d8cb959cce5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244436
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-09-26 05:24:27 +00:00
skia-autoroll
87f94cdc94 Roll third_party/externals/swiftshader cc3f09861685..30d3c8afe19c (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/cc3f09861685..30d3c8afe19c

git log cc3f09861685..30d3c8afe19c --date=short --no-merges --format='%ad %ae %s'
2019-09-25 chrisforbes@google.com Slim down ROP handling for various formats
2019-09-25 swiftshader.regress@gmail.com Regres: Update test lists @ cc3f0986

Created with:
  gclient setdep -r third_party/externals/swiftshader@30d3c8afe19c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
TBR=bungeman@google.com
Change-Id: I8ceb73204e50afc6927e6ec6b5a167721a29bda3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244427
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-09-26 04:32:37 +00:00
skia-autoroll
ffca47c8f0 Roll ../src fb8fbb18d6f2..fbc0a229ff3c (465 commits)
fb8fbb18d6..fbc0a229ff


Created with:
  gclient setdep -r ../src@fbc0a229ff

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Bug: None
TBR=bungeman@google.com
Change-Id: I83379bb048a23a85032b611cc454597cbeeb8e9f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244429
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-09-26 04:27:57 +00:00
recipe-roller
35c291905e Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/9a5bb612e62427fce53af10d2b72206f72d0ca40 git-cl: Make Ctrl+C work again. (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie180bc45c6f337bb40fdbb2f08c809dcfdc40817
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244416
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-09-26 02:32:35 +00:00
Joe Gregorio
710b5e616e Fix HOME directory in Docker containers built under cloudbuild.
The line:
    USER skia

also sets the $HOME environment variable to /home/skia unless
useradd is given another directory to use as the user's home
directory. So HOME was set to /home/skia, but that directory
doesn't exist in subsequent containers.

Bug: chromuim:993053
Change-Id: I3525d7cf11a1c1e5559cf9216c3bf6071a236949
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244116
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Robbie Iannucci <iannucci@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
2019-09-26 02:31:35 +00:00
Herb Derby
6bc3c09eec Move SkScalerContextEffects to SkScalerContext.h
Change-Id: Ibcbcc93d310e115bf5d8c683ac493100e3030988
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244304
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2019-09-25 21:24:55 +00:00
recipe-roller
e981fc2160 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/f0faf48ddb89cedf1d0b0c6642e214ddb3f535bf git-cl: Set legacy properties. (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I61071db4ff04251078ee9e605bddd92c8ed01701
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244358
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-09-25 21:11:25 +00:00
Chris Dalton
16a33c6244 Move the msaa dirty rect to GrRenderTargetProxy
Bug: skia:
Change-Id: I01d7932bce23dffafb86e4eb124c27420acefdd3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/239192
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2019-09-25 20:53:31 +00:00
Mike Klein
c3f6314e70 clean up for SSSE3 bilerp
This is mostly refactoring, moving functions to lambdas,
recommenting, that sort of thing.  Just how I relearn code...

I did pull the same trick as with SSE2 to turn one multiply
into a shift in interpolate_in_x_and_y().  Nothing interesting
beyond that.

Change-Id: I6645fa03264ec374950a5a936af05b480a69ff06
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244321
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-09-25 20:42:55 +00:00
recipe-roller
a7cb2b68e7 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/69b63c9f97d01ee38844ad078cb63799bde9c8ce Fix sys.platform mapping in download_from_google_storage.py. (pwnall@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I510c1b03b8b401685bbdffe9c8543f6224da5c70
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244329
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-09-25 20:21:25 +00:00
Nathaniel Nifong
7ee3f93196 Add a test that draws subpictures within an MSKP and make it pass.
It would have been passing, note that he changes to SkRecorder are needed only to obtain the
SkRecord used in asseting the correct commands were recorded.

Bug: skia: 9462
Change-Id: Ic43ab400b5954cc4f6eb465168179c0204a66040
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/243818
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Nathaniel Nifong <nifong@google.com>
2019-09-25 20:12:35 +00:00
recipe-roller
e6f2c738a3 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/92e5e4828b44e502f549181cfc9aeebbbaf0ba7a cipd: link directly to created package on chrome-infra-packages. (jbudorick@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia3b450f2ad081eecb415301f10ee68c531b3b7a6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244320
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-09-25 19:24:55 +00:00
Herb Derby
0965cddf42 Use constexpr version of min/max
Build-Debian9-Clang-arm-Debug-Chromebook_GLES is using c++11
version of the c++ standard libaray where min is not constexpr.

Change-Id: I631b80d373109ca845129f8f9cfd64ee0b9feff5
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244299
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
Auto-Submit: Herb Derby <herb@google.com>
2019-09-25 19:08:35 +00:00
Brian Osman
2caecd2a43 In AAConvexPathRenderer, don't assume that path direction can be computed
With a perspective view matrix, we transform the path, which can
collapse it down and cause CheapComputeFirstDirection to fail. In that
case, just skip drawing the path, rather than asserting.

Change-Id: I59ee3c74d02d41913136626a653c64f825a9d56a
Bug: https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=37330
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244298
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-09-25 18:36:45 +00:00
Nigel Tao
96c10a0a8f Fix calls to deprecated Wuffs API
In the latest Wuffs' terminology, "null_foo" refers to an unusable foo
and "empty_foo" refers to a usable but zero-sized foo.

Bug: skia:8235
Change-Id: I7ac7128a0b370b2d32b5d35f13643d49c519eaca
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/243597
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
2019-09-25 18:18:05 +00:00
Mike Klein
1cb574390e cut another multiply in SSE2 bilerp
I think that's as good as it gets now,
but it's still not as fast as the SSSE3 path.

Change-Id: I3bcfefeddfc2940eca66dfdeb8a0876d768e7d3d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244242
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2019-09-25 18:15:31 +00:00
Nathaniel Nifong
696933d8ba Add tests that loads mskp and changes frame.
Bug: skia:9462
Change-Id: I54141ffa4db7d5eb77e2e3d1b464ee540be3cd4d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244076
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Nathaniel Nifong <nifong@google.com>
2019-09-25 18:13:00 +00:00
Mike Klein
19ae4aa4da cut a multiply in SSE2 bilerp
The left two pixels and right two pixels are both multiplied
by allY weights today, then added together:

    (L * (16-wX) * allY) + (R * (wx) * allY)

We can trivially refactor that, delaying the allY multiply
until it only needs to be done once:

    allY * ( L*(16-wx) + R*(wx) )

This cuts a multiply off the per-pixel cost.

As I write this CL description, I think the obvious next thing to try is

    allY * ( (R-L)*wx + L*16 )

as that L*16 can become a super cheap shift.

Change-Id: Id683801105834468a04d05854d7d494867168ef2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244236
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-09-25 18:10:30 +00:00
Chris Dalton
e89ee6cfc3 Don't submit msaa resovle command buffers except for external IO
Bug: skia:9406
Change-Id: Ieed8d64fd001606f46eb8180e40900b6d3a82b79
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/243976
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2019-09-25 17:52:38 +00:00
Herb Derby
986ab2cf3d Add helper SkMakeZip
SkMakeZip uses function parameter deduction to build SkZips
the same way std::make_tuple does. It figures out the size
from one of the inputs that has a size. In debug, it makes
sure that all the size()s match if the input has a size.

Change-Id: I8f80d1137866ff595fff10cafa861e867441bedd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/242817
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2019-09-25 17:52:09 +00:00
Mike Klein
0ec56fc018 comment and TODO bilerp code
I'm starting my way towards AVX2 code here, first starting with the
relatively simple SSE2 code to make sure I understand what's going on.

Renames, updated comments, and one performance-related TODO.

Change-Id: I366ee67cf89c8c8d2ccc610d6d753531a131e7b9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/243815
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2019-09-25 17:43:48 +00:00
Herb Derby
2b92142b0e Add project declaration for CMake
Change-Id: I8a544fa91d2fba957dceb9e6b2a60ea824780e48
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244096
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2019-09-25 17:08:26 +00:00
Mike Klein
1585d7e108 opt skottie_tool into thread-local strike caches
I think this is largely free win if done once at process startup:

    $ time out/skottie_tool -i ~/Downloads/mb/data.json -w before
    166.59user 29.42system 0:06.13elapsed 3195%CPU (0avgtext+0avgdata 1994888maxresident)k

    $ time out/skottie_tool -i ~/Downloads/mb/data.json -w after
    93.36user 34.96system 0:04.76elapsed 2690%CPU (0avgtext+0avgdata 1968568maxresident)k

    $ idiff before after
    1333 files are identical.

Change-Id: I5454aed5e64bf78d61dfdc22ea1ce629714bd70c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244120
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2019-09-25 16:57:56 +00:00
Robert Phillips
0ee10347f9 Split out check_base_readbacks sub-test in BackendAllocation tests
We want to reuse this sub-portion of the tests for SkPixmap initialized backend textures

Note: this also changes the format read-back into to be RGBA8

Change-Id: I3708541cb4e60cf2ba7b587da6e21169ef890b04
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244056
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-09-25 16:22:49 +00:00
Mike Klein
5e6d36ac3e dump frame time stats in skottie_tool
$ time out/skottie_tool -i ~/Downloads/mb/data.json -w after

  Animation loaded with 2 errors, 0 warnings.
    !! Could not create typeface for Google Sans|Bold.
    !! Could not create typeface for Google Sans|Medium.
  frame time min 28ms, med 286ms, avg 441.18ms, max 1982ms, sum 264708ms
  93.74user 33.03system 0:04.70elapsed 2694%CPU (0avgtext+0avgdata 1976980maxresident)k

Things are looking pretty reasonable scaling-wise when we take ~5
seconds to run and some frames take up to ~2 seconds.

Change-Id: I0bfd955afcd9b8ac18e6614e1b5aa6889a06059a
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244121
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2019-09-25 16:13:29 +00:00
Brian Osman
559ffe4a23 Particles: Added particle flags for tracking state (one-time triggers, etc)
Also removed some older effects that weren't interesting, improved others,
cleaned up the unused functions in several, and renamed most of them to
reflect which feature they're demonstrating.

Change-Id: Ib44a00ec3d25e852a1d1661918137ba13d30c86b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244119
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-09-25 15:58:09 +00:00
Mike Klein
c712e962b6 poor man's contention profiler
When enabled this dumps a stack when an SkSpinlock is contended:

    out/skottie_tool(_ZN10SkSpinlock16contendedAcquireEv+0x1d)[0xa14d81]
    out/skottie_tool(_ZN13SkStrikeCache10attachNodeEPNS_4NodeE+0x21)[0x7274d3]
    out/skottie_tool(_ZN21SkGlyphRunListPainter19drawForBitmapDeviceERK14SkGlyphRunListRK8SkMatrixPKNS_19BitmapDevicePainterE+0x570)[0x9f83c2]
    out/skottie_tool(_ZN14SkBitmapDevice16drawGlyphRunListERK14SkGlyphRunList+0x47)[0x9d8f0d]
    out/skottie_tool(_ZN17SkGlyphRunBuilder12drawTextBlobERK7SkPaintRK10SkTextBlob7SkPointP12SkBaseDevice+0x1eb)[0x6d9c59]
    out/skottie_tool(_ZN8SkCanvas14onDrawTextBlobEPK10SkTextBlobffRK7SkPaint+0xf9)[0x6c9cff]
    out/skottie_tool(_ZN8SkCanvas12drawTextBlobEPK10SkTextBlobffRK7SkPaint+0xff)[0x6c9f3d]
    out/skottie_tool(_ZNK4sksg4Draw8onRenderEP8SkCanvasPKNS_10RenderNode13RenderContextE+0x74)[0xcdba5c]
    out/skottie_tool(_ZNK4sksg10RenderNode6renderEP8SkCanvasPKNS0_13RenderContextE+0x46)[0xce3e08]
    out/skottie_tool(_ZNK4sksg15TransformEffect8onRenderEP8SkCanvasPKNS_10RenderNode13RenderContextE+0x82)[0xce5e2e]
    out/skottie_tool(_ZNK4sksg10RenderNode6renderEP8SkCanvasPKNS0_13RenderContextE+0x46)[0xce3e08]
    out/skottie_tool(_ZNK4sksg5Group8onRenderEP8SkCanvasPKNS_10RenderNode13RenderContextE+0xf0)[0xcdd11c]
    out/skottie_tool(_ZNK4sksg10RenderNode6renderEP8SkCanvasPKNS0_13RenderContextE+0x46)[0xce3e08]
    out/skottie_tool(_ZNK4sksg15TransformEffect8onRenderEP8SkCanvasPKNS_10RenderNode13RenderContextE+0x82)[0xce5e2e]
    out/skottie_tool(_ZNK4sksg10RenderNode6renderEP8SkCanvasPKNS0_13RenderContextE+0x46)[0xce3e08]
    out/skottie_tool(_ZNK4sksg10ClipEffect8onRenderEP8SkCanvasPKNS_10RenderNode13RenderContextE+0x5d)[0xcda27f]
    out/skottie_tool(_ZNK4sksg10RenderNode6renderEP8SkCanvasPKNS0_13RenderContextE+0x46)[0xce3e08]
    out/skottie_tool(_ZNK4sksg11ColorFilter8onRenderEP8SkCanvasPKNS_10RenderNode13RenderContextE+0x86)[0xcda4b6]
    out/skottie_tool(_ZNK4sksg10RenderNode6renderEP8SkCanvasPKNS0_13RenderContextE+0x46)[0xce3e08]
    out/skottie_tool(_ZNK4sksg15TransformEffect8onRenderEP8SkCanvasPKNS_10RenderNode13RenderContextE+0x82)[0xce5e2e]
    out/skottie_tool(_ZNK4sksg10RenderNode6renderEP8SkCanvasPKNS0_13RenderContextE+0x46)[0xce3e08]
    out/skottie_tool(_ZNK7skottie8internal16MotionBlurEffect29renderToRaster8888Pow2SamplesEP8SkCanvasPKN4sksg10RenderNode13RenderContextE+0x18e)[0x6ab7d8]
    out/skottie_tool(_ZNK7skottie8internal16MotionBlurEffect8onRenderEP8SkCanvasPKN4sksg10RenderNode13RenderContextE+0xfe)[0x6abbba]
    out/skottie_tool(_ZNK4sksg10RenderNode6renderEP8SkCanvasPKNS0_13RenderContextE+0x46)[0xce3e08]
    out/skottie_tool(_ZNK4sksg5Group8onRenderEP8SkCanvasPKNS_10RenderNode13RenderContextE+0xf0)[0xcdd11c]
    out/skottie_tool(_ZNK4sksg10RenderNode6renderEP8SkCanvasPKNS0_13RenderContextE+0x46)[0xce3e08]
    out/skottie_tool(_ZNK7skottie9Animation6renderEP8SkCanvasPK6SkRectj+0x166)[0x691a78]
    out/skottie_tool[0x688aca]
    out/skottie_tool[0x6886fb]
    out/skottie_tool[0x72bc3e]
    out/skottie_tool(_ZN12SkThreadPoolI8SkTArrayISt8functionIFvvEELb0EEE7do_workEv+0xe5)[0x6d4d63]
    out/skottie_tool(_ZN12SkThreadPoolI8SkTArrayISt8functionIFvvEELb0EEE4LoopEPv+0x28)[0x6d4a94]
    /lib/x86_64-linux-gnu/libstdc++.so.6(+0xbbb2f)[0x7fbec2880b2f]
    /lib/x86_64-linux-gnu/libpthread.so.0(+0x7c73)[0x7fbec2547c73]
    /lib/x86_64-linux-gnu/libc.so.6(clone+0x3f)[0x7fbec1568def]

Change-Id: I32ce3b0d47a07b8b03a64539962a31a2bab89af9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244117
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2019-09-25 15:35:32 +00:00
skia-autoroll
6abaff3041 Roll third_party/externals/angle2 6d625bfe6e8a..ba04be8c9ef9 (9 commits)
6d625bfe6e..ba04be8c9e

git log 6d625bfe6e8a..ba04be8c9ef9 --date=short --no-merges --format='%ad %ae %s'
2019-09-25 jmadill@chromium.org GN: Refactor angle_test and remove angle_test_main.
2019-09-24 jmadill@chromium.org Fix Regex in DebugShaderPrecisionTest.
2019-09-24 jmadill@chromium.org Add SwiftShader to command line arguments.
2019-09-24 ianelliott@google.com Vulkan: Enable many GLES 3.1 Debug API tests to run/pass.
2019-09-24 jmadill@chromium.org Reduce logging in feature_support_util.
2019-09-24 jonahr@google.com Update GL state tracking on VertexArrayGL::streamAttributes
2019-09-24 jmadill@chromium.org Vulkan: Use ResourceUse to track object lifetime.
2019-09-24 jmadill@chromium.org Vulkan: Make SharedResourceUse a custom type.
2019-09-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 605c2e3c0ea7..3a762d54f649 (15 commits)

Created with:
  gclient setdep -r third_party/externals/angle2@ba04be8c9ef9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE
Bug: None
TBR=bungeman@google.com
Change-Id: I37b15a079530b75130cf1cc94d07771041d756bd
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/243961
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-09-25 05:38:44 +00:00
skia-recreate-skps
2da97da4b0 Update Go deps
Change-Id: Id304d58e5cb10dff76cdfdbd3d2750076ee52344
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/243964
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-09-25 05:27:14 +00:00
skia-autoroll
8368c74034 Roll ../src a76152f4e4ce..fb8fbb18d6f2 (434 commits)
a76152f4e4..fb8fbb18d6


Created with:
  gclient setdep -r ../src@fb8fbb18d6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Release-All-CommandBuffer;skia.primary:Test-Mac10.13-Clang-MacBookPro11.5-GPU-RadeonHD8870M-x86_64-Debug-All-CommandBuffer
Bug: None
TBR=bungeman@google.com
Change-Id: I1c385632c4068292b2282af0c7f171d634512ce7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/243720
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-09-25 04:47:14 +00:00
skia-autoroll
3731bd7ab0 Roll third_party/externals/swiftshader e3a5983705da..cc3f09861685 (5 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/e3a5983705da..cc3f09861685

git log e3a5983705da..cc3f09861685 --date=short --no-merges --format='%ad %ae %s'
2019-09-24 nicolascapens@google.com Merge changes Ic33110f9,I538566c6
2019-09-24 capn@google.com Fix WSI present on MacOS
2019-09-24 capn@google.com Claim Vulkan 1.1 conformance
2019-09-24 capn@google.com Implement VK_KHR_driver_properties
2019-09-24 sugoi@google.com Revert "Do not call Scheduler destructor in libVulkan."

Created with:
  gclient setdep -r third_party/externals/swiftshader@cc3f09861685

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
Bug: None
TBR=bungeman@google.com
Change-Id: I5f0cd9a49bf6d6b18453a716115d5a6f200cfc74
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/243960
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-09-25 04:34:34 +00:00
recipe-roller
2137f90b9d Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/7211cf64444c3cac9fba34d32ca35de31a96f545 Import gclient_utils for gclient_paths CheckCallAndFilter (robliao@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibe9bd91b9ca316ea47ac885f53b416de252c3204
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/243936
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-09-25 01:22:38 +00:00
recipe-roller
e78a5c860a Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/d48cbf93453624f7258052ab4e7140d0984ba0b5 Revert "depot_tools: Use vpython to execute fetch." (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I783136f772642b437d8ae839db966685e5962f3b
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/243838
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2019-09-24 23:11:30 +00:00
Florin Malita
01acb12110 [skottie] Disable skottie_tool on iOS
No thread_local support.

Change-Id: I8f22b237e099f36992da3483e06ae22ba3cd6de0
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/243625
Commit-Queue: Florin Malita <fmalita@chromium.org>
Auto-Submit: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Klein <mtklein@google.com>
2019-09-24 22:27:10 +00:00