Commit Graph

604 Commits

Author SHA1 Message Date
Eric Boren
1701ecea23 [recipes] Expand depot_tools DEPS hack for flutter and PDFium builds
Bug: skia:7609
Change-Id: Iaaaa2390d87656a4fa40e44fc31c35573abec7b5
Reviewed-on: https://skia-review.googlesource.com/108186
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-02-16 20:50:27 +00:00
Jim Van Verth
1b6c75c09c Add an actual config for GPU NativeFonts tests
Bug: skia:7562
Change-Id: I21eb1d9aa6717edcd89d958149e1ad250b4bf154
Reviewed-on: https://skia-review.googlesource.com/107944
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-02-16 15:54:06 +00:00
Jim Van Verth
240516f772 Add NativeFonts support to some GPU bots
Bug: skia:7562
Change-Id: I56e0991999644c02890008123b25f141aed0b70e
Reviewed-on: https://skia-review.googlesource.com/107520
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-02-15 15:44:29 +00:00
Ben Wagner
98c4231592 Increase ninja thread count for Android build on Linux.
Change-Id: Ib637360e2f09cd2851771595590203da6195a314
Reviewed-on: https://skia-review.googlesource.com/107600
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-02-15 14:29:39 +00:00
Ben Wagner
50a808a518 Increase ninja thread count for Windows builds.
Change-Id: Icc3f3cc144d6d3d2ee467822436df94559d6ff37
Reviewed-on: https://skia-review.googlesource.com/107580
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-02-15 14:16:49 +00:00
Kevin Lubick
43bd25983b Use libc++ for all XSAN builds
Docs-Preview: https://skia.org/?cl=107306
Bug: oss-fuzz:6347
Change-Id: I59c3b1b2e693fd97be0091ba2df406f51461fd10
Reviewed-on: https://skia-review.googlesource.com/107306
Reviewed-by: Mike Klein <mtklein@chromium.org>
2018-02-15 14:04:38 +00:00
Mike Klein
d5811b2d44 Revert "serialize NexusPlayer bots"
This reverts commit e1c2945b5f.

Reason for revert: no crashes since

Original change's description:
> serialize NexusPlayer bots
> 
> Temporarily serialize the NexusPlayer Test bots to help diagnose
> skia:7614.
> 
> Bug: skia:7614
> 
> Change-Id: I190327070f27e53d8344820f2215bad00f12e1ab
> Reviewed-on: https://skia-review.googlesource.com/106621
> Reviewed-by: Mike Klein <mtklein@chromium.org>
> Commit-Queue: Mike Klein <mtklein@chromium.org>

TBR=mtklein@chromium.org,caryclark@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: skia:7614
Change-Id: I1c7508c3f9a171d14cad1b77506d98772ef4ef60
Reviewed-on: https://skia-review.googlesource.com/107620
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-02-15 13:17:39 +00:00
Cary Clark
a7c569d111 PremulAlphaRoundTrip_Gpu on AndroidOne
blacklist PremulAlphaRoundTrip_Gpu on AndroidOne

R=kjlubick@google.com
Bug: skia:7501
Change-Id: Ib268789d6478b51f6c95ffbe7bb7008b56b8cba5
Reviewed-on: https://skia-review.googlesource.com/107360
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-02-14 17:45:17 +00:00
Ben Wagner
afe6cae2ba Do not copy vulkan-1.dll to Win bots.
Previously, we needed vulkan-1.dll from the Vulkan runtime because some
drivers did not include the Vulkan loader. Now, all drivers include this
DLL and using the version from assets causes problems for newer Intel
drivers.

Bug: skia:7490
Change-Id: I7bd37fb0d2c88a4753f354ab2bc88761562ced2f
Reviewed-on: https://skia-review.googlesource.com/107060
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-02-14 15:26:47 +00:00
Kevin Lubick
8684c71e66 Blacklist OOM test on Chromecast
Bug: skia:
Change-Id: I0e4eb5fcbb39dea771032908796a00b534ac3a4e
Reviewed-on: https://skia-review.googlesource.com/106806
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-02-12 21:17:14 +00:00
Eric Boren
25c1083e35 [recipes] Check out a separate depot_tools for syncing Chrome
This is a hack to get around the fact that we can't update the normal
version of depot_tools we receive through recipe deps, since we are not
yet using kitchen (See skia:7050).

Bug: skia:7609
Change-Id: I7d39e1e5db716960b2df2c8e3d4325c4b20c774e
Reviewed-on: https://skia-review.googlesource.com/106720
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2018-02-12 20:53:23 +00:00
Mike Klein
e1c2945b5f serialize NexusPlayer bots
Temporarily serialize the NexusPlayer Test bots to help diagnose
skia:7614.

Bug: skia:7614

Change-Id: I190327070f27e53d8344820f2215bad00f12e1ab
Reviewed-on: https://skia-review.googlesource.com/106621
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-02-12 18:59:13 +00:00
Ben Wagner
df430053e0 Add MacBook10,1 jobs.
No-Try: true
Change-Id: I2b976c29d7a267d3af9819c0565e3f88fe357fad
Reviewed-on: https://skia-review.googlesource.com/105760
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-02-09 15:19:01 +00:00
Brian Salomon
67f8584b6f Revert "Revert "Remove SkImage deferred texture image data APIs.""
This reverts commit aae533e418.

Change-Id: I0434892d8946490a75e17620c49c594eaa18158e
Reviewed-on: https://skia-review.googlesource.com/100603
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-02-09 14:19:51 +00:00
Ravi Mistry
042b5e901b [Bookmaker Nightly Bot] Output the stacktrace of failing fiddles
Bug: skia:7586
Change-Id: If52cefadc657fa93d90fe11b08e3efc5aeacb634
Reviewed-on: https://skia-review.googlesource.com/105767
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-02-08 21:35:30 +00:00
Greg Daniel
0c269d0c8e Blacklist GM that is crashing intel vulkan bot
Bug: skia:6398
Change-Id: I9c9cfc3ac7aac98c266f554f8034ef7df482252f
Reviewed-on: https://skia-review.googlesource.com/105820
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-02-08 21:04:40 +00:00
Robert Phillips
0b33cc42b4 Remove nvprdit* configs
Having removed the NVPR text renderer, the nvprdit* configs are no longer interesting/useful.

Change-Id: Ic4b9d6507d3e3595723a27636cb58b5e811fb3a3
Reviewed-on: https://skia-review.googlesource.com/105563
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-02-08 13:57:09 +00:00
Ravi Mistry
73e391db8a [Android Compile Bot] Look at the start_dir for trigger_wait_ac_task.py
Noticed this when trybots were not using changes to
trigger_wait_ac_task.py

NoTry: true
Bug: skia:7469
Change-Id: Ifac964e247bfd6862fa030fbf5176f179ef7f3c4
Reviewed-on: https://skia-review.googlesource.com/103521
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-02-05 18:34:46 +00:00
Ben Wagner
1d8726fbed Add MacBookAir jobs.
No-Try: true
Change-Id: I99f246687b8efc45068db18a3dc72162bdef178d
Reviewed-on: https://skia-review.googlesource.com/103080
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-02-02 20:59:19 +00:00
Ravi Mistry
5e967422e0 Add recipe and bots for android-compile.skia.org
Bug: skia:7469
Change-Id: I4a570a92d266d86fca20c9394c8d446df3c41e9b
Reviewed-on: https://skia-review.googlesource.com/102600
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-02-01 19:10:59 +00:00
Mike Klein
3a3fbf16c3 temporarily disable BadImage test on new ASAN bot
Here's the current error:

==6835==WARNING: AddressSanitizer failed to allocate 0xc0000028 bytes
==6835==AddressSanitizer's allocator is terminating the process instead of returning 0
==6835==If you don't like this behavior set allocator_may_return_null=1
==6835==AddressSanitizer CHECK failed: external/compiler-rt/lib/sanitizer_common/sanitizer_allocator.cc:221 "((0)) != (0)" (0x0, 0x0)

Looking at how sk_malloc and co all funnel into sk_malloc_flags(), and
how our local sk_malloc_flags() works, I think everything would be fine
to run this bot with allocator_may_return_null=1, but I'm not sure how
to do that.

Change-Id: I155439e17dd6353b82056de12f49de34e9538643
Reviewed-on: https://skia-review.googlesource.com/101660
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-01-30 14:44:55 +00:00
Greg Daniel
a6717ce9fe Blacklist additional perf skp on win Intel Vulkan
Bug: skia:6863
Change-Id: Iafdf7cd75d287f4d1f4a639e768b3d9418544959
Reviewed-on: https://skia-review.googlesource.com/101125
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-01-29 16:14:51 +00:00
Kevin Lubick
03bd9ee472 Disable flaky perf benchmark
Bug: skia:7551
Change-Id: Id1e4a345849f0e596d38278e5e9d88dfa476d678
Reviewed-on: https://skia-review.googlesource.com/101127
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-01-29 15:54:09 +00:00
Mike Klein
c8f740168f remove obsolete DM test configs
ViaSingletonPictures simulates a load pattern that Blink no longer produces.

I don't even remember what Via2ndPic and ViaTwice are meant to test,
but I imagine they're quite obsolete.

There was a lingering reference to ViaMojo, which otherwise doesn't exist.

Bug: skia:7544

Change-Id: I033fd344314054ad66c363e5dbd0a373be188069
Reviewed-on: https://skia-review.googlesource.com/88780
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-01-26 20:30:40 +00:00
Kevin Lubick
c2f3e8dc89 Update Chromecasts
I'm increasing capacity, might as well update them.

Bug: skia:
Change-Id: I4a535dbce1b3b586b5be82cb5b9bc0290ad7c6eb
Reviewed-on: https://skia-review.googlesource.com/99480
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-01-24 21:33:56 +00:00
Kevin Lubick
5d750edfdd Blacklist changed skp
Bug: skia:6687
Change-Id: I1562d7e9ded7f1be8a7ddc0c2341e54d5abbc0ae
Reviewed-on: https://skia-review.googlesource.com/97901
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-01-22 18:24:57 +00:00
Mike Klein
de161cb256 increase alignment of half-float pixels in F16Stages test
I think the Chorizo is now enforcing that our aligned loads are really
aligned.  If this sticks, I'll follow up with the rest of the tests
disabled on the bug.

Bug: skia:7497

Change-Id: Id392e20ead395474f716a2c32d2643c801e03a2e
Reviewed-on: https://skia-review.googlesource.com/97202
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-01-22 16:55:17 +00:00
Kevin Lubick
95379ebc0d Fix keys for Chromecast gold results
Bug: skia:
Change-Id: Id627a436fb9f2236d083aa5cd72128957dbfbaf9
Reviewed-on: https://skia-review.googlesource.com/95661
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
2018-01-17 16:41:16 +00:00
Kevin Lubick
8baaef9f54 No SRGB for Chromecasts
Bug: skia:
Change-Id: If1fc0854a42407fa6acd8d333ef49ae0b6302a81
Reviewed-on: https://skia-review.googlesource.com/95640
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-01-17 15:27:16 +00:00
Kevin Lubick
6ea9fdf70c Enable SRGB config on Chromecast
Also a few more blacklists to avoid shader compilation errors
in the Debug-GPU configuration.

Bug: skia:7166
Bug: skia:6687
Change-Id: I07b5adfc62e8029ece21406f0b79b32d9adf346f
Reviewed-on: https://skia-review.googlesource.com/95560
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-01-17 14:45:36 +00:00
Kevin Lubick
d452434d17 Upload multiple dm images at once
Use the -m file, as recommended in
https://luci-milo.appspot.com/swarming/task/3b197fbd667a1510/steps/upload_images/0/stdout

Bug: skia:
Change-Id: I58d101f58594bf221d11a787057ee7950b197f86
Reviewed-on: https://skia-review.googlesource.com/94965
Reviewed-by: Stephan Altmueller <stephana@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-01-17 12:29:26 +00:00
Kevin Lubick
608c35ae10 Fix Test-Chromecast from running out of memory on tests
Bug: skia:7166
Change-Id: Iefc8c6c1b72805dfe3ec8bd06d6ba6a878307582
Reviewed-on: https://skia-review.googlesource.com/93620
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
2018-01-16 21:35:48 +00:00
Kevin Lubick
4f0f933579 Add Android ASAN bot
It should work on 32 and 64 bit android running M or newer.

Bug: skia:
Change-Id: I7e6d4000f4fee8f2704b84b7174174dd0e68d21c
Reviewed-on: https://skia-review.googlesource.com/93700
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-01-12 19:57:33 +00:00
Chris Dalton
4ff1a6b0e0 Blacklist SkImage_makeNonTextureImage on Skylake vk
Bug: skia:
Change-Id: I7394d2f392d7179777b65e77194436271efea80d
Reviewed-on: https://skia-review.googlesource.com/93760
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-01-12 19:10:44 +00:00
Kevin Lubick
1c153c0fba Trying gpu scaling on Nexus 5 and 5x
We do some of this already in skpbench.

Bug: skia:
Change-Id: Ia698466e83f9b476644c126747a2f89346361d13
Reviewed-on: https://skia-review.googlesource.com/93561
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-01-11 19:22:36 +00:00
Mike Klein
515bda6811 support gray8 destinations on CPU
- fill in a couple switches to allow software to rasterize gray8
 - add a gray8 config to DM so we can test it
 - enable this config on some bots

Today we draw gray8 using SkRasterPipeline, loading it as {g,g,g,1}
and storing using the same fixed luma math as SkLumaColorFilter.
One day it'd be nice to use the color space's luma vector if present.

Can we support this on GPU?

Change-Id: I4ee661c8bd5f33f5db2433ffb6e1bc2483af8397
Reviewed-on: https://skia-review.googlesource.com/92681
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-01-09 22:19:58 +00:00
Ravi Mistry
7b7d9b374d Point ct_skps.py recipe to new SKP repository
Bug: skia:7463
Change-Id: I5dd17a5ba33f867346837f006f9dc4cb775cfa04
Reviewed-on: https://skia-review.googlesource.com/91960
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2018-01-08 17:39:21 +00:00
Yuqian Li
4a577af2d8 Separate compile task from calmbench task
Bug: skia:7344
Change-Id: I019fe5e3178d13ccf3a510bdcf1c81915149def5
Reviewed-on: https://skia-review.googlesource.com/89900
Commit-Queue: Yuqian Li <liyuqian@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-01-05 18:13:36 +00:00
Ben Wagner
f990ebc272 Only uninstall if install failed.
This is a followup to https://skia-review.googlesource.com/c/skia/+/90343,
which causes task durations to increase due to copying over images, skps,
etc. on every run.

Bug: skia:7408
Change-Id: I42e829e287b7343e969159ac19c587a87ebe99e8
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/90942
Reviewed-by: Stephan Altmueller <stephana@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-01-04 17:16:23 +00:00
Ben Wagner
e463d98558 Switch to updated Mac bots.
Bug: skia:7408
Change-Id: I26273df7871e3ee01e227636421962fcc6251e7d
Reviewed-on: https://skia-review.googlesource.com/88080
Reviewed-by: Stephan Altmueller <stephana@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-01-04 14:46:59 +00:00
Kevin Lubick
d12602aa1c Fix absolute path for recipes
Bug: skia:
Change-Id: I42c528d86f19d369609b26763334e055501a9b9b
Reviewed-on: https://skia-review.googlesource.com/90880
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-01-04 14:08:59 +00:00
Ben Wagner
5a59c26193 In iOS recipe, uninstall before install.
Bug: skia:7408
Change-Id: Iea55fe9199db7fc841ed0ba4a2451a84cd57213f
Reviewed-on: https://skia-review.googlesource.com/90343
Reviewed-by: Stephan Altmueller <stephana@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-01-03 23:21:30 +00:00
Ben Wagner
314d7c267f Add Win UBSAN jobs.
Bug: skia:2679
Change-Id: Ia462af01b9832da90206b9e9be2278cb48c6c502
Reviewed-on: https://skia-review.googlesource.com/86401
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-01-03 17:36:19 +00:00
Ravi Mistry
d4731e995c Housekeeper-PerCommit-Bookmaker bot to verify that docs match includes
Example failure- https://chromium-swarm.appspot.com/task?id=3a97e6c00ff78010
Example success- https://chromium-swarm.appspot.com/task?id=3a9814b474fcf910

Bug: skia:7432
Change-Id: I2459b7568ac2d12a0ed81b1eec9ddd61cff5b643
Reviewed-on: https://skia-review.googlesource.com/87767
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
2018-01-02 20:49:31 +00:00
Kevin Lubick
60bb2d52d9 Quarantine android bots instead of shutting off device
This should make it easier to diagnose and remotely fix
the devices/hosts.

Only works because of
https://chrome-internal-review.googlesource.com/c/infradata/config/+/535542

Bug: skia:
Change-Id: Idf11a09da6c7367212a0ac0b0b959cbf49fed85b
Reviewed-on: https://skia-review.googlesource.com/89181
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-12-22 16:12:35 +00:00
Ben Wagner
63457577c5 Remove Linux IntelIris540 jobs.
Replacing IntelIris540 with IntelIris640, added in
https://skia-review.googlesource.com/c/skia/+/87202. I verified that
Gold results are still identical (modulo flakes). See also
https://skia-review.googlesource.com/c/skia/+/87721 and
https://skia-review.googlesource.com/c/skia/+/78640.

No-Try: true
Change-Id: Ifc7e80e92d6203d922e00b59127b136632af7afc
Reviewed-on: https://skia-review.googlesource.com/88427
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-12-21 21:01:36 +00:00
Ben Wagner
ab10c8258d Re-add IntelIris640 Linux bots.
These were removed in
https://skia-review.googlesource.com/c/skia/+/78640
However, we've now decided on the 640 rather than the 540 due to
inventory.

No-Try: true
Change-Id: Icf6db636287e151d3dd3ac74cfddf8f6bd3bea6a
Reviewed-on: https://skia-review.googlesource.com/87202
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-12-19 20:52:16 +00:00
Brian Salomon
5c6ac64516 Revert "Revert "move homogenous with stride to matrixpriv""
This reverts commit de71572f65.

Revert "Revert "Transform vertices for distance field glyphs on CPU.""

This reverts commit f226e66d75.

Change-Id: I2545afae3beb1d6b14bba056853ed826ae7a4679
Reviewed-on: https://skia-review.googlesource.com/86603
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2017-12-19 20:23:06 +00:00
Kevin Lubick
031e7cf5ed Make sure we get the LITTLE cores out of powersave
Bug: skia:7420
NOTRY=true
Change-Id: I785135a3abc17f63d715d459668c768a6014d9b3
Reviewed-on: https://skia-review.googlesource.com/87001
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-12-19 15:32:46 +00:00
Kevin Lubick
e9188850ec Revert "Revert "Disable extra CPUs during Nanobench""
This reverts commit 43307c09b9.

Reason for revert: Fixed this time.  Echo 1 > already online cpu
returns exit code 1, which makes python over-react.

Original change's description:
> Revert "Disable extra CPUs during Nanobench"
>
> This reverts commit 32af335e7a.
>
> Reason for revert: many unhappy android bots
>
> Original change's description:
> > Disable extra CPUs during Nanobench
> >
> > The previous experiment revealed that nanobench can
> > run on any of the online CPUs, so rather than put
> > the ones we don't need/want into powersave mode, just
> > disable them.
> >
> > Maybe in the future we can run CPU tests on the big
> > or LITTLE cpus to get perf data on higher end or
> > lower end cpus, but only if we get very stable
> > results from this.
> >
> > Bug: skia:7378
> > Change-Id: I057513a691093e7f73c0f5790e17fab1a5ec0bc4
> > Reviewed-on: https://skia-review.googlesource.com/84820
> > Reviewed-by: Kevin Lubick <kjlubick@google.com>
> > Commit-Queue: Kevin Lubick <kjlubick@google.com>
>
> TBR=borenet@google.com,mtklein@google.com,kjlubick@google.com
>
> Change-Id: I23c37a6bde631e95f0b4ae7277ec8fcf325a00e9
> Bug: skia:7378
> Reviewed-on: https://skia-review.googlesource.com/84921
> Reviewed-by: Mike Klein <mtklein@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

No-Tree-Checks: true
Change-Id: Ie7f0a3dc6ba55c124c796aba16a0f0497f285f3a
Bug: skia:7378
Reviewed-on: https://skia-review.googlesource.com/84865
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2017-12-14 15:21:01 +00:00