Commit Graph

40105 Commits

Author SHA1 Message Date
Leon Scroggins III
194580dc60 Reland "Treat kWEBP encode with quality=100 as lossless"
This reverts commit 22170b3178.

It was reverted due to the test breaking Google3. This includes a
workaround.

    Original change's description:
    > Treat kWEBP encode with quality=100 as lossless
    >
    > In SkEncodeImage and friends, treat quality of 100 as a lossless encode
    > when using kWEBP. This seems a good fit for the intent - which is
    > presumably to save the highest quality image. This also matches
    > Chromium's blink::ImageEncoder::ComputeWebpOptions, which treats a
    > quality of 1 (on a float scale from 0 to 1) as a lossless encode.
    >
    > FWIW, Chromium has had this behavior since
    > https://codereview.chromium.org/1937433002, in response to
    > crbug.com/523098. The goal is to "maintain sharpness to
    > match the JPEG encoder behavior (use WEBP lossless encoding)".
    >
    > Add a test to verify the new behavior. This requires making tests
    > depend on libwebp to use WebPGetFeatures, since the Skia API does not
    > provide a way to determine whether an encoded webp file was encoded
    > lossless-ly or lossily.
    >
    > Bug: skia:8586
    > Change-Id: Ie9e09c2f7414ab701d696c4ad9edf405868a716f
    > Reviewed-on: https://skia-review.googlesource.com/c/175823
    > Commit-Queue: Leon Scroggins <scroggo@google.com>
    > Reviewed-by: Derek Sollenberger <djsollen@google.com>
    > Reviewed-by: Mike Reed <reed@google.com>

TBR=reed@google.com, based on prior approval

Bug: skia:8586
Change-Id: I09c73f71996422f797fd9456fef5dfad9af36839
Reviewed-on: https://skia-review.googlesource.com/c/194194
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
Auto-Submit: Leon Scroggins <scroggo@google.com>
2019-02-25 18:42:22 +00:00
Leon Scroggins III
06eaef8589 Add a wuffs Release bot
Bug: skia:8235

This way we can track performance in perf.

Change-Id: I0e1b6101d5642d3f22080abc1077215ca43b3aae
Reviewed-on: https://skia-review.googlesource.com/c/194421
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2019-02-25 18:00:38 +00:00
skia-autoroll
49fe0e9cf8 Roll third_party/externals/swiftshader 5efe61188243..1776af77065f (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/5efe61188243..1776af77065f


git log 5efe61188243..1776af77065f --date=short --no-merges --format='%ad %ae %s'
2019-02-25 chrisforbes@google.com Suppress warnings for more instructions that require no work


Created with:
  gclient setdep -r third_party/externals/swiftshader@1776af77065f

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: Ib79fd2fcd937469fbb149dba875f9220b7c55ae8
Reviewed-on: https://skia-review.googlesource.com/c/194991
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-25 17:57:38 +00:00
skia-autoroll
f6b0439fb6 Roll third_party/externals/swiftshader e2d8b1286ce3..5efe61188243 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/e2d8b1286ce3..5efe61188243


git log e2d8b1286ce3..5efe61188243 --date=short --no-merges --format='%ad %ae %s'
2019-02-25 sugoi@google.com Assert there are no unmatched eglBindTexImage/eglReleaseTexImage


Created with:
  gclient setdep -r third_party/externals/swiftshader@5efe61188243

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: I5bb95b44d1c1ffe3beffb7ac2dc4ac3a129da590
Reviewed-on: https://skia-review.googlesource.com/c/194984
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-25 17:03:56 +00:00
Ben Wagner
7465943b1e Remove fuzz samples.
We now have a real fuzzer, and these samples only run on local dev
machine anyway, so their current utility is quite low since they don't
demonstrate any specific behavior.

Bug: skia:8259
Change-Id: If44a0eaa161b1d7688dd3de6431414a84b7bd6c6
Reviewed-on: https://skia-review.googlesource.com/c/194862
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2019-02-25 16:55:26 +00:00
Ethan Nicholas
2f103f0d04 fixed SkSL float literals in Arabic locale
Bug: skia:
Change-Id: I52c9ec56be6afa44f6282ff40a152d56bdb5584a
Reviewed-on: https://skia-review.googlesource.com/c/194863
Auto-Submit: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2019-02-25 16:44:56 +00:00
Ben Wagner
5f50b75023 Remove defunct SkJSCanvas
Added disabled in 8ea69838a4 and appears
to never have been used. This seems now very superseded by CanvasKit.

Change-Id: I0fd3a8b2dc3a7207b8fa6ae9205842e4f5df450e
Reviewed-on: https://skia-review.googlesource.com/c/194604
Auto-Submit: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2019-02-25 16:29:06 +00:00
Jim Van Verth
2a330e689b Check for zero offsets for PolyUtils
Bug: oss-fuzz:13202
Change-Id: Iee0ec8bdfe6345c91a584607cc499d69d227a919
Reviewed-on: https://skia-review.googlesource.com/c/194422
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2019-02-25 16:11:06 +00:00
Eric Boren
b8960d0535 [infra] Make the presubmit bot use recipes from CIPD
Bug: skia:
Change-Id: I28f118521fc4f1f27c2601d70e855fb7f5623ba2
Reviewed-on: https://skia-review.googlesource.com/c/194861
Reviewed-by: Ravi Mistry <rmistry@google.com>
Reviewed-by: Robbie Iannucci <iannucci@google.com>
Commit-Queue: Eric Boren <borenet@google.com>
2019-02-25 16:04:59 +00:00
Florin Malita
bd64f18947 [skottie] Layer blend mode support
Introduce sksg::BlendModeEffect and use to wrap Skottie layers based on
their "bm" property.

Depending on the presence of non-trivial layer blend modes and the nature
of the destination buffer (fully transparent vs. unknown/pre-filled), we
may now need to render animation frames into a separate layer for correct
compositing.

Track the presence of non-trivial layer blend modes such that we only incur
this extra layer overhead when needed.  Also allow clients to pass a "drawing
to fully transparent buffer" hint such that we can avoid the extra layer even
when blend modes are present.

Change-Id: Iaf645878666da4349d0bef8890bbecad23a0aa9b
Reviewed-on: https://skia-review.googlesource.com/c/194840
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-02-25 15:48:07 +00:00
Mike Reed
5532c2a34f fill the layer if there is a backdrop filter
Bug: skia:8783
Change-Id: I92448382117b1bd05a0ad5cf7ecd72181631389b
Reviewed-on: https://skia-review.googlesource.com/c/194601
Auto-Submit: Mike Reed <reed@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-02-25 15:32:36 +00:00
Nigel Tao
e3b205b120 Update Wuffs version
Bug: skia:8764
Bug: skia:8767
Bug: skia:8764

This pulls in the Wuffs bug fix:
ab7d6de318
"Let Wuffs compile with MSVC (Microsoft Visual C++)".

This also pulls in fixes for
https://github.com/google/wuffs/issues/20
"Check for "not enough pixel data" and return an Error or Warning"

Change-Id: Ie75e57504f1ec872418e8851e10de9159f714bc5
Reviewed-on: https://skia-review.googlesource.com/c/193200
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2019-02-25 15:25:36 +00:00
skia-autoroll
507158f88d Roll third_party/externals/swiftshader b47c816ad7e6..e2d8b1286ce3 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/b47c816ad7e6..e2d8b1286ce3


git log b47c816ad7e6..e2d8b1286ce3 --date=short --no-merges --format='%ad %ae %s'
2019-02-25 bclayton@google.com Fix CMake build documentation


Created with:
  gclient setdep -r third_party/externals/swiftshader@e2d8b1286ce3

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: I8a7ec3b88174c0e62857268589e62b6eb8b3bfa5
Reviewed-on: https://skia-review.googlesource.com/c/194805
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-25 12:43:56 +00:00
recipe-roller
478d7d46f8 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/79f79017de52c70f04314d85e2ed4d8b89546a17 cq: don't emit property when no new builds have been triggered. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic33db1e14fd9028d6143fd36aa6e3a442f82133c
Reviewed-on: https://skia-review.googlesource.com/c/194605
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2019-02-25 09:11:36 +00:00
skia-recreate-skps
5bbd02d6bb Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I6347b8949c194ee39ee8ab77f0f2c9c8381136c7
Reviewed-on: https://skia-review.googlesource.com/c/194504
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-02-25 05:37:25 +00:00
skia-autoroll
e1636a4b56 Roll third_party/externals/swiftshader 7c33e88eebb5..b47c816ad7e6 (3 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/7c33e88eebb5..b47c816ad7e6


git log 7c33e88eebb5..b47c816ad7e6 --date=short --no-merges --format='%ad %ae %s'
2019-02-25 chrisforbes@google.com Remove remnants of non-descriptor UBO support
2019-02-25 chrisforbes@google.com Remove remnants of GL-style user clip planes
2019-02-25 chrisforbes@google.com Remove transform feedback remnants


Created with:
  gclient setdep -r third_party/externals/swiftshader@b47c816ad7e6

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=scroggo@google.com

Change-Id: I7ce7224709fc75fbb50bf8ca1122fcc8bace9bf1
Reviewed-on: https://skia-review.googlesource.com/c/194735
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-25 02:37:35 +00:00
skia-recreate-skps
52d8a5976a Update SKP version
Automatic commit by the RecreateSKPs bot.

TBR=rmistry@google.com
NO_MERGE_BUILDS

Change-Id: I87597e667aaa7901d20f028de4db4a9fd4e17db5
Reviewed-on: https://skia-review.googlesource.com/c/194503
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-02-24 08:39:34 +00:00
skia-recreate-skps
33c1b31526 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I4110ccf509e87ecbf91ed21694cbc6c114bb0ee6
Reviewed-on: https://skia-review.googlesource.com/c/194502
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-02-24 05:34:54 +00:00
recipe-roller
2ed90e152d Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/2a09b5794c3305f9ec315ac948ee097095d17d90 [doc] Change default to "gen". (iannucci@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I52c0396a28ea203d696014fd0c025ca4207702c3
Reviewed-on: https://skia-review.googlesource.com/c/194603
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2019-02-23 18:39:30 +00:00
Kevin Lubick
867da4b96e Allow system harfbuzz.
This should allow shaper to run on the no-deps bot.

Change-Id: I2515875d4e9b428681c20877630b904c3229ecc5
Reviewed-on: https://skia-review.googlesource.com/c/194420
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2019-02-23 12:14:30 +00:00
skia-autoroll
12f1fecea9 Roll third_party/externals/angle2 f78131dac076..c63d95525cde (1 commits)
f78131dac0..c63d95525c


git log f78131dac076..c63d95525cde --date=short --no-merges --format='%ad %ae %s'
2019-02-23 syoussefi@chromium.org Add system util to execute app and retrieve its output


Created with:
  gclient setdep -r third_party/externals/angle2@c63d95525cde

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=jvanverth@google.com

Change-Id: Iac92f16635e91ef39a5bef3a8ef7e1f8de37123a
Reviewed-on: https://skia-review.googlesource.com/c/194684
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-23 11:36:29 +00:00
skia-recreate-skps
72f6f044cc Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: Ief708528717ab9e156ade7fce2daca6761ab0e25
Reviewed-on: https://skia-review.googlesource.com/c/194501
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2019-02-23 05:55:30 +00:00
skia-autoroll
5b99086fcf Roll third_party/externals/swiftshader d2452555986f..7c33e88eebb5 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/d2452555986f..7c33e88eebb5


git log d2452555986f..7c33e88eebb5 --date=short --no-merges --format='%ad %ae %s'
2019-02-23 chrisforbes@google.com Set render targets correctly when drawing


Created with:
  gclient setdep -r third_party/externals/swiftshader@7c33e88eebb5

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=jvanverth@google.com

Change-Id: Ifb335cd0d7ac196b97c1bb321eb67c0b8126321a
Reviewed-on: https://skia-review.googlesource.com/c/194645
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-23 03:43:30 +00:00
skia-autoroll
2a5511307d Roll third_party/externals/angle2 cf9b2853a7e7..f78131dac076 (3 commits)
cf9b2853a7..f78131dac0


git log cf9b2853a7e7..f78131dac076 --date=short --no-merges --format='%ad %ae %s'
2019-02-22 syoussefi@chromium.org Suppress WebGL CopyTexSubImage2D on D3D9.3 everywhere
2019-02-22 timvp@google.com Vulkan: Free semaphores with other in flight resources
2019-02-22 jmadill@chromium.org D3D: Fall back to old compiler DLL.


Created with:
  gclient setdep -r third_party/externals/angle2@f78131dac076

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=jvanverth@google.com

Change-Id: I125569093b806659c4a303d32106f50d27cc5c60
Reviewed-on: https://skia-review.googlesource.com/c/194555
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-23 02:35:20 +00:00
recipe-roller
24f380e7ef Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/245337d62e22e410b8c3f7a037e9c34252a72aef Pass target branch from tryserver in bot_update module (whesse@google.com)
  https://crrev.com/151c3484da58fa02f7d2c69454be3cb4e3395d05 Replace post-process checks with ones that are not deprecated (sergiyb@chromium.org)
  https://crrev.com/4809957b795006ffa9fd1b43e402a3b9e2cb7fe4 [cpplint] Ignore fn_size check for macros with digits (qyearsley@chromium.org)
  https://crrev.com/91a32c5e39d2c1e789e7fe63355bc2ec399f68db CppLint changes for VSCode cpplint plugin (jophba@chromium.org)
  https://crrev.com/298f2cf820dfe45dff53b0e41b11441dbf72b48c git cl: Print a clear error message when we fail to find the remote url. (ehmaldonado@chromium.org)
  https://crrev.com/d7f7a3eb92a43b9135bfb8672c9af0fa1c9bce9a [lucicfg] Bump lucicfg version 1.2.0 -> 1.3.2. (vadimsh@chromium.org)
  https://crrev.com/5585c87a78b77d4bdab2a58f636ced7918b6b021 Revert "Pass target branch from tryserver in bot_update module" (tandrii@chromium.org)
recipe_engine:
  https://crrev.com/6605f1b0db4ddee8e7f40b73fe60cf5f8cbe794f Make StatusFailure work for non-exceptional failures only (sergiyb@chromium.org)
  https://crrev.com/16dfe87b81be9acfd9e1763b20bd028f81d28e13 cq: add API to track triggered_build_ids. (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1ec397cca16894be07bfc8f0fe91a5a057a49038
Reviewed-on: https://skia-review.googlesource.com/c/194600
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2019-02-23 01:36:20 +00:00
Florin Malita
ef22907020 [sksg] Use luminance coefficients from SkColorData.h
TBR=
Change-Id: I2dc48f3d4e1ee1b873bd41ede5168191f69bde30
Reviewed-on: https://skia-review.googlesource.com/c/194427
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-02-22 23:31:50 +00:00
Florin Malita
a753d1a347 Reland "[skottie] Add tritone layer effect support"
This reverts commit 42ee4028a9.

Original change's description:
> Revert "[skottie] Add tritone layer effect support"
> 
> This reverts commit 71c70ea13e.
> 
> Reason for revert: broke WASM builds
> 
> Original change's description:
> > [skottie] Add tritone layer effect support
> > 
> > Generalize sksg::TintColorFilter into GradientColorfilter, to support
> > multiple color interpolation ranges.
> > 
> > Keep the two-color/single-matrix (tint) specialization, and use a table
> > color filter for the general case.
> > 
> > Change-Id: Idf42833462127c29fb69fe94337a1d1478b77dd9
> > Reviewed-on: https://skia-review.googlesource.com/c/194024
> > Reviewed-by: Mike Reed <reed@google.com>
> > Commit-Queue: Florin Malita <fmalita@chromium.org>
> 
> TBR=fmalita@chromium.org,reed@google.com
> 
> Change-Id: Id5bd99701f74fbd4f54d0aca74e753b7ab88bdb3
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/c/194429
> Reviewed-by: Florin Malita <fmalita@chromium.org>
> Commit-Queue: Florin Malita <fmalita@chromium.org>

TBR=fmalita@chromium.org,reed@google.com

Change-Id: Ie7fc28ff784b91f01108415e50677e8982ccf858
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/194430
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-02-22 23:11:02 +00:00
Jim Van Verth
8fc1eb2893 Disable fontscaler GM on Intel Vulkan
Bug: skia:
Change-Id: Iec4eb15a070aa26a5ccb741bbf80eb49b594d340
Reviewed-on: https://skia-review.googlesource.com/c/194426
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Auto-Submit: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-02-22 23:02:29 +00:00
skia-autoroll
86e0a0fc4d Roll third_party/externals/swiftshader e53533d6fdf9..d2452555986f (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/e53533d6fdf9..d2452555986f


git log e53533d6fdf9..d2452555986f --date=short --no-merges --format='%ad %ae %s'
2019-02-22 chrisforbes@google.com Wire up cull mode handling to Vulkan pipeline
2019-02-22 bclayton@google.com Kokoro: Run unit tests.


Created with:
  gclient setdep -r third_party/externals/swiftshader@d2452555986f

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=jvanverth@google.com

Change-Id: Idedfb11987e0ef19b93c88a7a86dad650123c000
Reviewed-on: https://skia-review.googlesource.com/c/194406
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-22 22:54:41 +00:00
Mike Reed
e36d408b26 add gm to test backdrop blurs and clipping/hintrects
Bug: skia:8783
Change-Id: I27907673d4a5e1f8c5c0b26c704da367e0437a79
Reviewed-on: https://skia-review.googlesource.com/c/194190
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2019-02-22 22:28:50 +00:00
Herb Derby
90ec9fbbf2 Change SDFT to use a bulk api for the callback
Change-Id: I280b11d134c1b1b03f979cc80a087fe176f659e5
Reviewed-on: https://skia-review.googlesource.com/c/194425
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2019-02-22 22:17:29 +00:00
Florin Malita
42ee4028a9 Revert "[skottie] Add tritone layer effect support"
This reverts commit 71c70ea13e.

Reason for revert: broke WASM builds

Original change's description:
> [skottie] Add tritone layer effect support
> 
> Generalize sksg::TintColorFilter into GradientColorfilter, to support
> multiple color interpolation ranges.
> 
> Keep the two-color/single-matrix (tint) specialization, and use a table
> color filter for the general case.
> 
> Change-Id: Idf42833462127c29fb69fe94337a1d1478b77dd9
> Reviewed-on: https://skia-review.googlesource.com/c/194024
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Florin Malita <fmalita@chromium.org>

TBR=fmalita@chromium.org,reed@google.com

Change-Id: Id5bd99701f74fbd4f54d0aca74e753b7ab88bdb3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/194429
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-02-22 21:51:13 +00:00
Florin Malita
71c70ea13e [skottie] Add tritone layer effect support
Generalize sksg::TintColorFilter into GradientColorfilter, to support
multiple color interpolation ranges.

Keep the two-color/single-matrix (tint) specialization, and use a table
color filter for the general case.

Change-Id: Idf42833462127c29fb69fe94337a1d1478b77dd9
Reviewed-on: https://skia-review.googlesource.com/c/194024
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2019-02-22 21:00:25 +00:00
Hal Canary
30c9eda01b SkShaper/public.bzl fix
Change-Id: Ie9a0b03cdc3e683689d8d8d078cf382adc101021
Reviewed-on: https://skia-review.googlesource.com/c/194423
Reviewed-by: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2019-02-22 20:57:07 +00:00
Ben Wagner
86c9c95b2e Compare to the correct hinting.
Without this change no-hinting subpixel-antialias requests on Mac 10.14
will not be gamma adjusted when they should be.

Bug: chromium:933137

Change-Id: I666f9f37ac849ed76a6b6aaab4966f4dd9fb5fb3
Reviewed-on: https://skia-review.googlesource.com/c/194188
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2019-02-22 20:11:25 +00:00
Hal Canary
8c2ccf4764 tools: bin/sync just alias for git-sync-deps now
No-Try: true
Change-Id: Id323d99c4ad0526980330daf41752452e6b09c95
Reviewed-on: https://skia-review.googlesource.com/c/194381
Auto-Submit: Hal Canary <halcanary@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
2019-02-22 20:05:05 +00:00
Jim Van Verth
3bc37fd63b Disable tests on more Vulkan bots
Bug: skia:8659, skia:7959
Change-Id: I952f7b3d91be4e1952045d291bcf97c217208da9
Reviewed-on: https://skia-review.googlesource.com/c/194380
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2019-02-22 19:54:36 +00:00
skia-autoroll
e2a9f99dba Roll third_party/externals/swiftshader 8a718cb58343..e53533d6fdf9 (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/8a718cb58343..e53533d6fdf9


git log 8a718cb58343..e53533d6fdf9 --date=short --no-merges --format='%ad %ae %s'
2019-02-22 chrisforbes@google.com Silence emit-time warnings for many instructions
2019-02-22 chrisforbes@google.com Remove alpha test plumbing


Created with:
  gclient setdep -r third_party/externals/swiftshader@e53533d6fdf9

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=jvanverth@google.com

Change-Id: I39efae7770df39415b92ab580f9b85a47a231a3f
Reviewed-on: https://skia-review.googlesource.com/c/194269
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-22 19:54:35 +00:00
Hal Canary
689334cacf ICU: fix windows: dll to dat
Change-Id: Id03174b5f93a16d91fc21cd0abfaeaa80b1f6163
Reviewed-on: https://skia-review.googlesource.com/c/194187
Auto-Submit: Hal Canary <halcanary@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2019-02-22 19:44:05 +00:00
Leon Scroggins III
8546335d2d Allow setting an SkColorSpace on SkAnimatedImage
Add a new constructor which merges the SkISize scaledSize with the
SkImageInfo. This allows passing an SkColorSpace to the decode.

Update the test to call the new API.

Bug: b/123301872
Change-Id: I9fd89198e97ac9b8e6dc9fcfe89ed38913a0fe69
Reviewed-on: https://skia-review.googlesource.com/c/189303
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2019-02-22 18:58:05 +00:00
skia-autoroll
9320d579e5 Roll third_party/externals/swiftshader 7aafb27453d3..8a718cb58343 (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/7aafb27453d3..8a718cb58343


git log 7aafb27453d3..8a718cb58343 --date=short --no-merges --format='%ad %ae %s'
2019-02-22 chrisforbes@google.com Restore vertex fetch state update from context -> state
2019-02-22 chrisforbes@google.com Implement proper handling of constants


Created with:
  gclient setdep -r third_party/externals/swiftshader@8a718cb58343

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=jvanverth@google.com

Change-Id: I16e51dca1ebefbe26a764bd095fbae9384f0f6f4
Reviewed-on: https://skia-review.googlesource.com/c/194266
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-22 18:47:55 +00:00
Ben Wagner
1d9f378ec3 [infra] Remove Ubuntu17 jobs
These have been replaced with Ubuntu18 or IntelIris640 jobs in various
earlier CLs.

Bug: chromium:837351
Change-Id: Id8ce54219e971c1645dc09c81b3031ee1d85c284
Reviewed-on: https://skia-review.googlesource.com/c/192682
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
Reviewed-by: Stephan Altmueller <stephana@google.com>
2019-02-22 18:43:25 +00:00
Ethan Nicholas
ee1c8a733e Revert "Revert "SkSL now supports null child processors""
This reverts commit bce7d86270.

Bug: skia:
Change-Id: I3ccaf47b3d4b9dcb9e049671117183a374526032
Reviewed-on: https://skia-review.googlesource.com/c/194185
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2019-02-22 17:50:30 +00:00
Brian Salomon
587e41938d Skip newly added TextureIdleProcFlushTest test on Mac/Metal. It crashes.
It does not crash on iOS.

https://logs.chromium.org/logs/skia/RmWNhdlMctRJ4z8e4v1h/+/steps/dm/0/stdout

    0   dm                                  0x00000001071eeb6d _ZL13crash_handleri + 509
    1   libsystem_platform.dylib            0x00007fff6343df5a _sigtramp + 26
    2   ???                                 0x00007fd549bb8a20 0x0 + 140554041788960
    3   IOAccelerator                       0x00007fff5550cfe9 ioAccelResourceGroupAddNewResource + 134
    4   IOAccelerator                       0x00007fff5550d0de ioAccelResourceListAddNewGroupAndResource + 201
    5   IOAccelerator                       0x00007fff5550cc21 IOAccelResourceListAddResource + 304
    6   AMDMTLBronzeDriver                  0x000000010a5c564d _Z28amdMtlBronzeCmdBufUpdateRsrcP19BronzeCmdBufInfoRecP18MTLIOAccelResourcejj + 65
    7   AMDMTLBronzeDriver                  0x000000010a5c83f6 _ZL22amdMtlBronzeSetTextureP32BronzeRenderCmdEncoderMembersRecjPU21objcproto10MTLTexture11objc_objectjjj + 88
    8   dm                                  0x0000000107d527cd _ZN39MVKGraphicsResourcesCommandEncoderState10encodeImplEv + 653
    9   dm                                  0x0000000107d34cef _ZN17MVKCommandEncoder17finalizeDrawStateEv + 63
    10  dm                                  0x0000000107d33309 _ZN10MVKCmdDraw6encodeEP17MVKCommandEncoder + 25
    11  dm                                  0x0000000107d3421c _ZN17MVKCommandEncoder15encodeSecondaryEP16MVKCommandBuffer + 44
    12  dm                                  0x0000000107d36f1b _ZN21MVKCmdExecuteCommands6encodeEP17MVKCommandEncoder + 43
    13  dm                                  0x0000000107d33f6b _ZN17MVKCommandEncoder6encodeEP31MVKQueueCommandBufferSubmission + 107
    14  dm                                  0x0000000107d33e9c _ZN16MVKCommandBuffer7executeEP31MVKQueueCommandBufferSubmissionRK29MVKCommandBufferBatchPosition + 124
    15  dm                                  0x0000000107d4666e _ZN31MVKQueueCommandBufferSubmission7executeEv + 94
    16  dm                                  0x0000000107d45b2c ___ZN8MVKQueue6submitEP18MVKQueueSubmission_block_invoke + 28
    17  libdispatch.dylib                   0x00007fff630fd5fa _dispatch_call_block_and_release + 12
    18  libdispatch.dylib                   0x00007fff630f5db8 _dispatch_client_callout + 8
    19  libdispatch.dylib                   0x00007fff6310a217 _dispatch_queue_serial_drain + 635
    20  libdispatch.dylib                   0x00007fff630fd166 _dispatch_queue_invoke + 373
    21  libdispatch.dylib                   0x00007fff6310af0d _dispatch_root_queue_drain_deferred_wlh + 332
    22  libdispatch.dylib                   0x00007fff6310ed21 _dispatch_workloop_worker_thread + 880
    23  libsystem_pthread.dylib             0x00007fff63446fd2 _pthread_wqthread + 980
    24  libsystem_pthread.dylib             0x00007fff63446be9 start_wqthread + 13

Bug: skia:8243
Change-Id: Iea6aecece9cfb8e8e8cb7a7232e441248172720b
Reviewed-on: https://skia-review.googlesource.com/c/194191
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2019-02-22 17:47:15 +00:00
Brian Osman
d5c57fe289 Add local vs world flag for particle velocity
Adjust reference frame for affector to be consistent (so angles are
counted clockwise from "up" in both local and world modes).

Bug: skia:
Change-Id: I643e1484bc0a58d1f1c0cfe35ac2ab37dc2ea409
Reviewed-on: https://skia-review.googlesource.com/c/194189
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2019-02-22 17:45:25 +00:00
Jim Van Verth
6674077f46 Blacklist fontregen on IntelIris655-Vulkan
Bug: skia:8659
Change-Id: I48645518b16a1e467832c192aebb97c9ba9762e8
Reviewed-on: https://skia-review.googlesource.com/c/194192
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
2019-02-22 17:35:35 +00:00
skia-autoroll
231d04fc27 Roll third_party/externals/swiftshader b607bc8800c1..7aafb27453d3 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/b607bc8800c1..7aafb27453d3


git log b607bc8800c1..7aafb27453d3 --date=short --no-merges --format='%ad %ae %s'
2019-02-22 headlessclayton@gmail.com Add CMake flag to treat warnings as errors


Created with:
  gclient setdep -r third_party/externals/swiftshader@7aafb27453d3

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=jvanverth@google.com

Change-Id: I67a7907c4559f4b7d2a6b604c127efad96e04192
Reviewed-on: https://skia-review.googlesource.com/c/194264
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-22 17:33:36 +00:00
Robert Phillips
6989370877 Move DrawingManager to RecordingContext
This CL does make use of a new GrRecordingContextPriv backdoor to break CL deadlocks. This occurs when this CL tries to create GrContext-dependent objects outside its scope.

Change-Id: I278fe9d321f8e0a4f5e9b489b1a5cc01b8974521
Reviewed-on: https://skia-review.googlesource.com/c/191287
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2019-02-22 17:25:00 +00:00
skia-autoroll
54b57e9bad Roll third_party/externals/angle2 b9039bf76bf3..cf9b2853a7e7 (1 commits)
b9039bf76b..cf9b2853a7


git log b9039bf76bf3..cf9b2853a7e7 --date=short --no-merges --format='%ad %ae %s'
2019-02-22 jmadill@chromium.org Roll Google Test.


Created with:
  gclient setdep -r third_party/externals/angle2@cf9b2853a7e7

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=jvanverth@google.com

Change-Id: I6a8556de619e8c0192f3aaa1f5415470fa5074aa
Reviewed-on: https://skia-review.googlesource.com/c/194263
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2019-02-22 17:19:40 +00:00
Greg Daniel
59dc1481a0 Track GrVkResources in command buffer associated with pipeline barriers.
This makes sure we don't call the release proc on an external image before
the transition to the external queue finishes on the gpu.

Bug: skia:
Change-Id: I35b0e3899fcd859cd5ccaa57df9427a47d434210
Reviewed-on: https://skia-review.googlesource.com/c/194004
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2019-02-22 16:56:37 +00:00