reed@google.com
1cc07d940f
Revert "Add SkCanvas::drawPosTextBounded."
...
This reverts commit e158aea941a6202a40b75fcee013d002089854bb.
This was an experimental API change. We will reintroduce this feature
with a different API approach, and support it w/ detailed testing
and performance measurements.
BUG=
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/22861002
git-svn-id: http://skia.googlecode.com/svn/trunk@10680 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-12 15:40:11 +00:00
djsollen@google.com
2cad2c04c3
fix malformed gypi file that was missing commas
...
R=torne@chromium.org
Review URL: https://codereview.chromium.org/22841003
git-svn-id: http://skia.googlecode.com/svn/trunk@10678 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-12 14:57:54 +00:00
mtklein@google.com
c9ab2b7dd8
SkTDynamicHash
...
- add validate()
- make add() and remove() strict
- fill in maybeShrink()
- make grow and shrink thresholds configurable.
- fix issue where we were getting filled with deleted items - we need to count them as occupied when determining if we should grow
BUG=
R=reed@google.com
Review URL: https://codereview.chromium.org/22571010
git-svn-id: http://skia.googlecode.com/svn/trunk@10677 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-12 14:51:25 +00:00
rmistry@google.com
fb4a68de43
If any change is made to the public API then make sure there is an LGTM from an owner.
...
This feature has been requested by reed@.
If no LGTM is found from an owner then the following msg is displayed:
** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of: ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org', 'bsalomon@google.com')
(SkipBuildbotRuns)
R=borenet@google.com
Review URL: https://codereview.chromium.org/22453004
git-svn-id: http://skia.googlecode.com/svn/trunk@10676 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-12 14:51:20 +00:00
djsollen@google.com
cc95b1aeb8
Update Skia Android tools.
...
This CL moves the skia_launcher out of the system/bin and into
/data/local/tmp; removes the need to package our shared libs in an
apk; and updates all the scripts to work in the new environment.
R=mtklein@google.com , scroggo@google.com
Review URL: https://codereview.chromium.org/22617002
git-svn-id: http://skia.googlecode.com/svn/trunk@10673 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-12 12:30:04 +00:00
robertphillips@google.com
36bb270c1e
Revert of r10671 (Experiments on calculating reciprocal of square root) due to bots failures:
...
Win7: http://108.170.217.252:10117/builders/Build-Win7-VS2010-x86-Debug/builds/715/steps/BuildMost/logs/stdio
Win8: http://108.170.217.252:10117/builders/Build-Win8-VS2012-x86-Debug/builds/383/steps/BuildMost/logs/stdio
Mac10.6: http://108.170.217.252:10117/builders/Build-Mac10.6-GCC-x86-Debug/builds/1259/steps/BuildMost/logs/stdio
git-svn-id: http://skia.googlecode.com/svn/trunk@10672 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-12 12:02:28 +00:00
commit-bot@chromium.org
b3ecdc464e
Experiments on calculating reciprocal of square root
...
BUG=
R=reed@google.com , rmistry@chromium.org , bsalomon@google.com , tomhudson@chromium.org , tomhudson@google.com
Author: yang.gu@intel.com
Review URL: https://chromiumcodereview.appspot.com/21755002
git-svn-id: http://skia.googlecode.com/svn/trunk@10671 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-12 08:37:51 +00:00
bensong@google.com
eac275932e
r10473 introduced a space between bench values; adjusting the corresponding regexp. (SkipBuildbotRuns).
...
Review URL: https://codereview.chromium.org/22447004
git-svn-id: http://skia.googlecode.com/svn/trunk@10670 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-11 21:59:01 +00:00
robertphillips@google.com
1c0ade7fc6
Reverted r10654 (Fix crash when querying a runtime config that is defined in environment) due to compilation failure on Chromium win_layout bot
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10669 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-11 13:20:18 +00:00
skia.committer@gmail.com
3de23b1aa1
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10668 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-10 07:01:19 +00:00
jvanverth@google.com
f6ad1e8a06
Revert r10659: Add a map homogenous points to SkMatrix
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10667 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-09 21:06:38 +00:00
commit-bot@chromium.org
9d54aeb8a1
All rSomethingTo() immediately following a close() are relative to the point we closed from, not the point we close to. Fix that.
...
Seems like this has been broken since the stone ages.
BUG=skia:1474, code.google.com/p/android/issues/detail?id=41216
R=bsalomon@google.com
Author: mtklein@google.com
Review URL: https://chromiumcodereview.appspot.com/22681006
git-svn-id: http://skia.googlecode.com/svn/trunk@10666 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-09 19:48:26 +00:00
scroggo@google.com
80e18c93bb
Reland "Make WebP decoding independent of stream length."
...
This reverts commit 1de924955b103c4f5dc9c46a06527d6a37e6cb70.
When reading the stream, only read as much as will fit in the
allocated buffer.
BUG=skia:1495
Review URL: https://codereview.chromium.org/22629010
git-svn-id: http://skia.googlecode.com/svn/trunk@10665 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-09 19:22:00 +00:00
djsollen@google.com
a8797b966f
remove include from the header paths
...
R=robertphillips@google.com , torne@chromium.org
Review URL: https://codereview.chromium.org/22450005
git-svn-id: http://skia.googlecode.com/svn/trunk@10664 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-09 16:11:36 +00:00
commit-bot@chromium.org
47fa13640b
allow NULL in writeString/readString
...
BUG=skia:1469, code.google.com/p/android/issues/detail?id=58257
R=scroggo@google.com
Author: mtklein@google.com
Review URL: https://chromiumcodereview.appspot.com/22359003
git-svn-id: http://skia.googlecode.com/svn/trunk@10662 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-09 16:03:05 +00:00
djsollen@google.com
ee05f759c8
Remove exported headers and add all public headers into dictionary for reference by clients.
...
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/22613003
git-svn-id: http://skia.googlecode.com/svn/trunk@10661 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-09 15:45:35 +00:00
jvanverth@google.com
65beb7513e
Temporarily disable pathinterior_gpu on Nexus-10.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10660 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-09 15:24:01 +00:00
egdaniel@google.com
2fae54d945
Add a map homogenous points to SkMatrix
...
BUG=
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/22330004
git-svn-id: http://skia.googlecode.com/svn/trunk@10659 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-09 15:07:10 +00:00
bsalomon@google.com
3f05c91690
Add initial baselines for new GM xfermodes3
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10658 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-09 14:32:46 +00:00
commit-bot@chromium.org
cb62224996
Removing deprecated constructors and setDevice from SkDeferredCanvas
...
R=senorblanco@google.com , senorblanco@chromium.org
BUR=crbug.com/270143
Author: junov@chromium.org
Review URL: https://chromiumcodereview.appspot.com/22385011
git-svn-id: http://skia.googlecode.com/svn/trunk@10657 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-09 14:24:59 +00:00
jvanverth@google.com
1904df0413
Reverting r10651: Make WebP decoding independent of stream length.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10656 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-09 14:24:30 +00:00
djsollen@google.com
9c1a967967
remove uneeded SK_API declaration.
...
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/22432005
git-svn-id: http://skia.googlecode.com/svn/trunk@10655 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-09 13:49:13 +00:00
commit-bot@chromium.org
a1007def7e
Fix crash when querying a runtime config that is defined in environment
...
Fix crash when querying a runtime config in case when there's no
skia.conf file and the config variable is still defined in the
environment.
Runs the added SkRTConf::UnitTest test as part of new "UnitTest" test.
BUG=skia:1494
R=bsalomon@google.com , humper@google.com
Author: kkinnunen@nvidia.com
Review URL: https://chromiumcodereview.appspot.com/22650007
git-svn-id: http://skia.googlecode.com/svn/trunk@10654 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-09 13:23:56 +00:00
robertphillips@google.com
cbdcbd0b88
Nexus 7 Performance trigger rebaseline
...
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@10653 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-09 12:43:02 +00:00
djsollen@google.com
a111e492b8
Cleanup the ARM blitrow optimizations
...
R=mtklein@google.com
Review URL: https://codereview.chromium.org/22229002
git-svn-id: http://skia.googlecode.com/svn/trunk@10652 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-09 12:35:08 +00:00
djsollen@google.com
1f617a765b
Make WebP decoding independent of stream length.
...
There's a case in Android, when the SkStream passed to WebP decoder may have
incorrect length (stream->getLength()). This is observed, if the App decodes
an image (size > 80KB) using: 'ParcelFileDescriptor --> BitmapFactory.decodeStream()'.
This CL updates the WebP incremental decoding loop to not rely on stream->getLength().
R=scroggo@google.com , vikasa@google.com
Review URL: https://codereview.chromium.org/22672003
git-svn-id: http://skia.googlecode.com/svn/trunk@10651 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-09 12:32:48 +00:00
skia.committer@gmail.com
17f1ae63d5
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10650 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-09 07:01:22 +00:00
commit-bot@chromium.org
c28f555f7f
This attempts to replicate some bad cache behavior Mozilla reported.
...
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://chromiumcodereview.appspot.com/22411005
git-svn-id: http://skia.googlecode.com/svn/trunk@10649 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-08 22:55:21 +00:00
jvanverth@google.com
482d5a229a
Revert rebaselines for r10640.
...
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@10648 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-08 22:44:13 +00:00
jvanverth@google.com
940c863283
Revert r10640: Fix hairline pathrenderer for Nexus-10.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10647 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-08 22:42:37 +00:00
jvanverth@google.com
6b8573d72d
Rebaseline Nexus-S and Nexus-4 GMs for r10640. Disabled complexclip_bw_layer_gpu
...
for Nexus-S due to glitch.
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@10646 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-08 21:24:41 +00:00
commit-bot@chromium.org
103f2d0f22
Add new GM to targeted at rect->clear optimization with different xfermodes.
...
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/22264010
git-svn-id: http://skia.googlecode.com/svn/trunk@10645 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-08 21:13:38 +00:00
jvanverth@google.com
f682241fd2
More rebaselines for r10640. Unreviewed.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10644 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-08 20:42:19 +00:00
jvanverth@google.com
6dbf2e5a13
Rebaseline images for r10640. Unreviewed.
...
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@10643 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-08 20:07:12 +00:00
commit-bot@chromium.org
34504ad924
Adding 2 functions to the Skia API
...
I need wrappers for both SkOrderedReadBuffer and SkOrderedWriteBuffer inside Chromium in order to do the IPC serialization of Skia SkImageFilter objects.
See https://codereview.chromium.org/21271002/
BUG=
R=djsollen@google.com , scroggo@google.com , reed@google.com
Author: sugoi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/22591002
git-svn-id: http://skia.googlecode.com/svn/trunk@10642 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-08 19:20:05 +00:00
jvanverth@google.com
274aeeff89
Rebaseline images for r10535. Reviewed by djsollen.
...
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@10641 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-08 18:54:12 +00:00
commit-bot@chromium.org
78b64aebef
Fix hairline pathrenderer for Nexus-10. Switches to using additional
...
geometry and passing in the coverage value instead.
BUG=
R=robertphillips@google.com , bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://chromiumcodereview.appspot.com/22486003
git-svn-id: http://skia.googlecode.com/svn/trunk@10640 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-08 18:22:07 +00:00
edisonn@google.com
53766103b5
pdfviewer: remove text save/restore (not needed) and verify that colorspace dictionary exists before using it
...
Review URL: https://codereview.chromium.org/22436003
git-svn-id: http://skia.googlecode.com/svn/trunk@10639 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-08 12:54:01 +00:00
edisonn@google.com
768bc6a920
pdfviewer: add ability to run on gpu
...
Review URL: https://codereview.chromium.org/22684002
git-svn-id: http://skia.googlecode.com/svn/trunk@10638 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-08 12:42:13 +00:00
djsollen@google.com
1efccd297e
Create a gypi that contains all the SK_API header files for use by clients (i.e. chromium).
...
R=robertphillips@google.com , torne@chromium.org
Review URL: https://codereview.chromium.org/22474010
git-svn-id: http://skia.googlecode.com/svn/trunk@10637 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-08 12:31:05 +00:00
edisonn@google.com
16291e51d5
pdfviewer: remove save/restore used with q/Q operators (we already do there save and restore)
...
Review URL: https://codereview.chromium.org/22678003
git-svn-id: http://skia.googlecode.com/svn/trunk@10636 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-08 11:40:26 +00:00
commit-bot@chromium.org
641a249196
ARM Skia NEON patches - 11 - Blitter_RGB16
...
Blitter_RGB16: fixes and improvements
- fix alpha calculation: it was still using the old version of
SkAlpha255To256. 11 more tests pass in gm.
- clean a lot the code: the existing code was "a bit" messy with
a lot of duplicated hardcoded constants, got rid of all this.
- improve speed a little: part of it as a side-effect of the change
in the way alpha is calculated but also by grouping loads and stores.
One "issue" was present and still remains: the NEON code doesn't give
the same result as the black blitter on black. It accounts for dozens
of mismatches in gm. Is this considered "not too bad"? Would you be
interested in a NEON version of the black blitter? The current
comments seem to indicate that the black blitter is here only to give
a performance boost when NEON is not presents so I didn't write a NEON
version.
BUG=
R=djsollen@google.com , tomhudson@google.com , reed@google.com
Author: kevin.petit.arm@gmail.com
Review URL: https://chromiumcodereview.appspot.com/18666005
git-svn-id: http://skia.googlecode.com/svn/trunk@10635 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-08 10:51:45 +00:00
skia.committer@gmail.com
d55e357a8e
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10634 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-08 07:01:20 +00:00
commit-bot@chromium.org
d2623a1a0b
Use Path Ops to generate PDF clips
...
R=vandebo@chromium.org , edisonn@google.com , caryclark@google.com
Author: richardlin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/21161003
git-svn-id: http://skia.googlecode.com/svn/trunk@10633 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-08 02:52:05 +00:00
robertphillips@google.com
b265741cc1
Revert r10603 (Remove operator== from SkPaint) due to Chrome failures
...
git-svn-id: http://skia.googlecode.com/svn/trunk@10632 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-07 22:36:29 +00:00
senorblanco@chromium.org
3484df6ff2
New baselines for imagefiltersbase, after r10626.
...
TBR=jvanverth@google.com
Review URL: https://codereview.chromium.org/22623004
git-svn-id: http://skia.googlecode.com/svn/trunk@10631 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-07 21:36:15 +00:00
edisonn@google.com
4f898b78bb
pdfviewer: absolute minimal; to al least render (even if poorly) ICC based color spaces, based on RGB
...
Review URL: https://codereview.chromium.org/22624002
git-svn-id: http://skia.googlecode.com/svn/trunk@10630 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-07 21:11:57 +00:00
scroggo@google.com
590a5af121
Beginning work to refactor jpeg tile decoding.
...
Keep common code together, so we can fix bugs in tile and normal decode
simultaneously.
Convert if-then chains to switch statements for readability.
Add getBitmapConfig, common to both normal and tile decode, which
ensures that they behave the same. getBitmapConfig uses the code
originally in onDecode, so subsetting grayscale into A8 now works.
In getBitmapConfig, handle JCS_YCCK properly.
Fix a bug where requesting A8 from a JCS_CMYK image would
result in a total failure to decode, since we would change
out_color_space to an invalid choice.
Factor common code for applying dither and changing the
out_color_space into apply_dither_mode (final name TBD). Skips
CMYK like normal decoding did before.
BUG=skia:1472
BUG=https://b.corp.google.com/issue?id=9466275
BUG=https://b.corp.google.com/issue?id=9189955
R=mtklein@google.com
Review URL: https://codereview.chromium.org/22290002
git-svn-id: http://skia.googlecode.com/svn/trunk@10629 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-07 21:09:13 +00:00
scroggo@google.com
a1a515474d
Fix failure exits from JPEG onBuildTileIndex.
...
The setjmp exited without deleting the SkJPEGImageIndex, and
another exit condition deleted the huffman index even though
it had not been created yet. Create member functions on
SkJPEGImageIndex to make the jpeg calls so it can keep track
of what has been created, and avoid destroying anything else.
Remove unnecessary lines to set values to their default values.
Move all SkJPEGImageIndex code entirely inside #ifdef ANDROID
blocks, since no piece of it is used except by ANDROID only
code.
BUG=skia:1471
R=djsollen@google.com , mtklein@google.com
Review URL: https://codereview.chromium.org/21891007
git-svn-id: http://skia.googlecode.com/svn/trunk@10628 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-07 21:02:32 +00:00
scroggo@google.com
2fe638ef06
Update GM baselines for 8888->4444 fix.
...
Review URL: https://codereview.chromium.org/22621002
git-svn-id: http://skia.googlecode.com/svn/trunk@10627 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-08-07 20:23:26 +00:00