Hal Canary
8a00144035
test,tools: whitespace changes for clang-format
...
Change-Id: I67529f6c0ac26da603f60af22c620f8f603d8a19
Reviewed-on: https://skia-review.googlesource.com/155564
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Auto-Submit: Hal Canary <halcanary@google.com>
2018-09-19 17:50:51 +00:00
Ben Wagner
a93a14a998
Convert NULL and 0 to nullptr.
...
This was created by looking at warnings produced by clang's
-Wzero-as-null-pointer-constant. This updates most issues in
Skia code. However, there are places where GL and Vulkan want
pointer values which are explicitly 0, external headers which
use NULL directly, and possibly more uses in un-compiled
sources (for other platforms).
Change-Id: Id22fbac04d5c53497a53d734f0896b4f06fe8345
Reviewed-on: https://skia-review.googlesource.com/39521
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2017-08-28 17:48:57 +00:00
Brian Salomon
144a5c518a
Rename batch->op in skiaserve
...
Change-Id: Ib831b9a6bcf4f37c0f077b26f68b1cefef81bb73
Reviewed-on: https://skia-review.googlesource.com/6351
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2016-12-20 22:35:23 +00:00
reed
a84d6606f5
remove experimental treat-skcolor-as-srgb flag
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2097003003
Review-Url: https://codereview.chromium.org/2097003003
2016-06-24 18:14:07 -07:00
jcgregorio
34604046cf
skiaserve: Add a flag to control hosted mode, i.e. when running on debugger.skia.org.
...
BUG=skia:
TBR=ethannicholas@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2036173002
Review-Url: https://codereview.chromium.org/2036173002
2016-06-03 07:26:22 -07:00
jcgregorio
ce8ea4c55b
skiaserve: Add /quitquitquit handler. Will be used in the hosted debugger.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2023023002
TBR=ethannicholas
Review-Url: https://codereview.chromium.org/2023023002
2016-05-31 12:51:31 -07:00
brianosman
82996b8200
Get skiaserve working on Windows.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1903203003
Review URL: https://codereview.chromium.org/1903203003
2016-04-20 10:52:54 -07:00
brianosman
312aa6a81e
Adding support for controlling the global sRGB SkColor switch.
...
Frontend change: https://codereview.chromium.org/1900233002/
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1902143002
Review URL: https://codereview.chromium.org/1902143002
2016-04-19 12:47:54 -07:00
mtklein
05db63b5fc
Remove static initializer for SkOpts::Init()
...
Static initializers run in a confusing unspecified order,
so it's best to have as few of them as possible.
Most tools and clients I can find already call SkGraphics::Init(),
(or equivalently create an SkAutoGraphics) which calls SkOpts::Init():
- Chrome
- Chrome renderer
- Android
- DM
- nanobench
- SampleApp
- VisualBench
- the old debugger
Seems like the only thing relying on this static initializer today is
the new debugger, fixed here.
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1903503002
Review URL: https://codereview.chromium.org/1903503002
2016-04-19 12:42:24 -07:00
brianosman
7831295c63
Adding support for playback to L32/S32/F16 canvas.
...
Playback of my test GM works correctly on both raster and GPU, in all three modes.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1893393002
Review URL: https://codereview.chromium.org/1893393002
2016-04-19 10:16:53 -07:00
halcanary
9d524f22bf
Style bikeshed - remove extraneous whitespace
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1842753002
Review URL: https://codereview.chromium.org/1842753002
2016-03-29 09:03:53 -07:00
joshualitt
b82f088a11
Fix skiaserve in debug mode
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1774263002
Review URL: https://codereview.chromium.org/1774263002
2016-03-08 13:24:33 -08:00
joshualitt
e43f7e67b6
Fix SkiaServe gpu JSON to work with any reordering algorithm
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1761003004
Review URL: https://codereview.chromium.org/1761003004
2016-03-04 10:45:05 -08:00
msarett
464d210875
Remove unused tools and unused includes of SkImageDecoder
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1760583003
Review URL: https://codereview.chromium.org/1760583003
2016-03-03 08:38:26 -08:00
jcgregorio
855bd4415c
debugger: Only bind to the localhost address by default.
...
Also add a flag to set the address.
Additionally print out the final address the user should visit in their browser.
R=joshualitt,ethannicholas
BUG=skia:
Review URL: https://codereview.chromium.org/1756903002
2016-03-02 09:03:01 -08:00
joshualitt
10d8fc29bc
Render batch bounds as stroke rects
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1745063002
Review URL: https://codereview.chromium.org/1745063002
2016-02-29 11:15:06 -08:00
joshualitt
ee5348b069
Get SkiaServe Request started off with a little privacy
...
This CL moves the surface stuff into the request object so it
can maintain its internal state consistently
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1741823002
Review URL: https://codereview.chromium.org/1741823002
2016-02-26 08:36:25 -08:00
joshualitt
1e5884b066
Wire up /batches in skiaserve
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1737323002
Review URL: https://codereview.chromium.org/1737323002
2016-02-26 08:22:49 -08:00
joshualitt
3854f11ce3
Move urlhandlers out of skiaserve.cpp
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1737643003
Review URL: https://codereview.chromium.org/1737643003
2016-02-25 11:28:18 -08:00
joshualitt
26cc3f5ad0
Create Response namespace for skiaserve response functions
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1739763002
Review URL: https://codereview.chromium.org/1739763002
2016-02-25 11:09:36 -08:00
joshualitt
4dcbe43124
Move some methods to SkiaServe's Request, this is still very leaky
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1733813004
Review URL: https://codereview.chromium.org/1733813004
2016-02-25 10:50:28 -08:00
joshualitt
24dd687ac5
Move Request to its own file in preparation for numerous cleanups
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1738483003
Review URL: https://codereview.chromium.org/1738483003
2016-02-25 08:37:54 -08:00
bsalomon
5ec26ae9bf
Move Budgeted enum out of SkSurface, use in GrTextureProvider
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1728093005
DOCS_PREVIEW= https://skia.org/?cl=1728093005
Committed: https://skia.googlesource.com/skia/+/57599fe6c0336feaeeeb9b1996e77b70219b483c
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
Review URL: https://codereview.chromium.org/1728093005
2016-02-25 08:33:02 -08:00
jcgregorio
50fe38e72a
use the favicon on debugger.skia.org
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1734913002
Review URL: https://codereview.chromium.org/1734913002
2016-02-25 07:02:13 -08:00
bsalomon
bd500f09ce
Revert of Move Budgeted enum out of SkSurface, use in GrTextureProvider (patchset #6 id:100001 of https://codereview.chromium.org/1728093005/ )
...
Reason for revert:
Need workaround for chrome to build
Original issue's description:
> Move Budgeted enum out of SkSurface, use in GrTextureProvider
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1728093005
> DOCS_PREVIEW= https://skia.org/?cl=1728093005
>
> Committed: https://skia.googlesource.com/skia/+/57599fe6c0336feaeeeb9b1996e77b70219b483c
TBR=reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1734043002
2016-02-25 06:52:12 -08:00
bsalomon
57599fe6c0
Move Budgeted enum out of SkSurface, use in GrTextureProvider
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1728093005
DOCS_PREVIEW= https://skia.org/?cl=1728093005
Review URL: https://codereview.chromium.org/1728093005
2016-02-25 06:33:27 -08:00
ethannicholas
3ff5d8c63d
added mode=cpu|gpu to skiaserve JSON
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1719973002
Review URL: https://codereview.chromium.org/1719973002
2016-02-22 08:59:57 -08:00
ethannicholas
85fca851e6
added /enableGPU command to skiaserve
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1715503004
Review URL: https://codereview.chromium.org/1715503004
2016-02-19 08:40:59 -08:00
ethannicholas
3ca1e1ae4f
added server-side breakpoint support to skiaserve
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1707863003
Review URL: https://codereview.chromium.org/1707863003
2016-02-18 10:22:34 -08:00
ethannicholas
cecbbe2fa9
converted skiaserve PNGs from RGBA to RGB
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1703893003
Review URL: https://codereview.chromium.org/1703893003
2016-02-17 11:49:43 -08:00
joshualitt
6b3cf73af5
Add batch information to json
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1705093002
Review URL: https://codereview.chromium.org/1705093002
2016-02-17 11:20:26 -08:00
ethannicholas
272af6ecd7
Revert of further skiaserve image performance improvements (patchset #1 id:1 of https://codereview.chromium.org/1707453003/ )
...
Reason for revert:
Broke skiaserve GPU rendering
Original issue's description:
> further skiaserve image performance improvements
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1707453003
>
> Committed: https://skia.googlesource.com/skia/+/68c063bf11c91b2b3b15cb93168cf2af9b2c642d
TBR=joshualitt@google.com ,jcgregorio@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1708683002
2016-02-17 10:30:27 -08:00
ethannicholas
68c063bf11
further skiaserve image performance improvements
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1707453003
Review URL: https://codereview.chromium.org/1707453003
2016-02-17 09:17:35 -08:00
ethannicholas
546d66544b
tuned skiaserve's png output for better performance
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1704573002
Review URL: https://codereview.chromium.org/1704573002
2016-02-16 11:03:04 -08:00
jcgregorio
3341d428d3
skiaserve: Change alpha setting from GET to POST.
...
GET shouldn't be used for things that change the state of the server.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1706443002
Review URL: https://codereview.chromium.org/1706443002
2016-02-16 10:31:07 -08:00
ethannicholas
0a0520afcc
added clip visualization to skiaserve
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1690023004
Review URL: https://codereview.chromium.org/1690023004
2016-02-12 12:06:53 -08:00
ethannicholas
de8e54ccfd
skiaserve now retains the graphics context rather than creating a new one each request
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1693893002
Review URL: https://codereview.chromium.org/1693893002
2016-02-12 10:09:34 -08:00
ethannicholas
f8289d9bd1
fixed off-by-one error in skiaserve /cmd
...
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1692683002
Review URL: https://codereview.chromium.org/1692683002
2016-02-11 13:10:37 -08:00
joshualitt
db6a254bdc
wire up new json code in skiaserve
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1691773002
Review URL: https://codereview.chromium.org/1691773002
2016-02-11 07:09:51 -08:00
jcgregorio
12d47ce49e
skiaserve: Fix /cmd/N and /cmd/N[0|1], the response was never queued.
...
BUG=skia:
R=joshualitt@google.com , ethannicholas@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1686553006
Review URL: https://codereview.chromium.org/1686553006
2016-02-10 14:10:37 -08:00
joshualitt
873d624b80
Skia serve now supports favicon correctly
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1676403002
Review URL: https://codereview.chromium.org/1676403002
2016-02-08 13:57:44 -08:00
joshualitt
cdad12f3b1
Create image cache for use by json canvas
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1670153005
Review URL: https://codereview.chromium.org/1670153005
2016-02-08 07:08:21 -08:00
joshualitt
29e5a8932d
Modify skia serve to return clip rect and view matrix
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1662003002
Review URL: https://codereview.chromium.org/1662003002
2016-02-04 06:08:33 -08:00
joshualitt
792345f540
Modify skiaserve to support downloads
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1657403002
Review URL: https://codereview.chromium.org/1657403002
2016-02-02 13:02:33 -08:00
joshualitt
136f517627
Modify skiaserve to support drawTo
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1651403003
Review URL: https://codereview.chromium.org/1651403003
2016-02-02 11:07:39 -08:00
joshualitt
a341b90c7f
fix skiaserve crash
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1659703004
Review URL: https://codereview.chromium.org/1659703004
2016-02-02 07:37:21 -08:00
joshualitt
483b90140a
cleanup of skia serve url handling
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1653203002
Review URL: https://codereview.chromium.org/1653203002
2016-02-02 07:16:24 -08:00
jcgregorio
21ab1209f5
skiaserve: Clean up flags.
...
Remove unused flags.
Add --port and --source.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1643963002
Review URL: https://codereview.chromium.org/1643963002
2016-01-28 06:24:19 -08:00
jcgregorio
6a2046ea34
skiaserve: Add CORS header, and debugger code is served over HTTPS.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1646683002
Review URL: https://codereview.chromium.org/1646683002
2016-01-28 05:31:31 -08:00
jcgregorio
9ce4110a29
skiaserve: Enable /cmd endpoint.
...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1639403002
Review URL: https://codereview.chromium.org/1639403002
2016-01-27 12:15:38 -08:00