Commit Graph

34342 Commits

Author SHA1 Message Date
Florin Malita
20880784fb [skottie] Json cleanup pass
Assorted Json tweaks:

  - more defensive internal object access
  - drop unneeded isObject checks
  - drop unneeded namespace
  - restrict the iterator to arrays

TBR=
Change-Id: I02f1c5d84c429cf5206bc2a0a7843097b92bac94
Reviewed-on: https://skia-review.googlesource.com/126930
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-05-09 16:11:45 +00:00
Ben Wagner
dea965c099 Remove SK_IGNORE_MASK_FILTER_GLYPH_FIX.
This removes the SK_IGNORE_MASK_FILTER_GLYPH_FIX flag check and the code
it guards. This flag existed for rebaselining and the rebaselines have
been done.

Change-Id: Ic2d6850051a7f4dcbf2e31c6174db1248ce9367a
Reviewed-on: https://skia-review.googlesource.com/126925
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-05-09 15:48:35 +00:00
Greg Daniel
97c1108607 Revert "SkAdvancedTypefaceMetrics: factor out GlyphToUnicode"
This reverts commit 1c2bcd8b14.

Reason for revert: breaking chrome roll

Original change's description:
> SkAdvancedTypefaceMetrics: factor out GlyphToUnicode
> 
> Change-Id: Iedce8c1ea2c405d5ab64ccac353970d5cd2b9d63
> Reviewed-on: https://skia-review.googlesource.com/126507
> Commit-Queue: Hal Canary <halcanary@google.com>
> Reviewed-by: Ben Wagner <bungeman@google.com>

TBR=halcanary@google.com,bungeman@google.com,reed@google.com

Change-Id: Ib1ff8484ffd09cdb88d461ac00745aa32c191124
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/127000
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-05-09 15:36:06 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
2ed5f69da6 Roll skia/third_party/skcms 289cedc..f771d23 (1 commits)
https://skia.googlesource.com/skcms.git/+log/289cedc..f771d23

2018-05-09 brianosman@google.com Ensure that the TFs from ApproximateCurve are invertible


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=egdaniel@google.com

Change-Id: I327db3e5e51694678c84606272de4791ac35c263
Reviewed-on: https://skia-review.googlesource.com/126982
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-09 15:28:05 +00:00
Mike Klein
6b2b6504c9 clean up some SkDebugf()
These annoy the crap out of me every time I run DM.

Change-Id: I76edf1d5a5c1931a93d208ba1d8db5220987e62d
Reviewed-on: https://skia-review.googlesource.com/126929
Commit-Queue: Mike Klein <mtklein@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Auto-Submit: Mike Klein <mtklein@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2018-05-09 15:24:05 +00:00
recipe-roller
8094749628 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/afec759dca62d9239f75ec5643592331a6aa18a2 Revert "bot_update: Fetch references to be synced." (agrieve@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6e64bc991f48cf6ba8c2cadf91949fb87a588c38
Reviewed-on: https://skia-review.googlesource.com/126927
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-05-09 15:19:45 +00:00
Chris Dalton
3917b1e9bc ccpr: Cleanup on-flush path stats
Adds a wrapper struct to limit the number of free variables. Fixes a
bug where we preallocated draw instances for clip paths. Counts conic
weights and preallocates their buffer as well.

Bug: skia:
Change-Id: I72779c9017322a0dc64461c8cb927f975406b9af
Reviewed-on: https://skia-review.googlesource.com/126844
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-05-09 15:12:45 +00:00
Robert Phillips
e8f9e913b6 Cleanup SK_IGNORE_BLUR_IMAGE_FILTER_FIX (since Chrome no longer uses it)
Change-Id: I3eebd6233d6f6a8b43ce0d865ffafd85d58f0c16
Reviewed-on: https://skia-review.googlesource.com/126926
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-05-09 15:12:15 +00:00
Florin Malita
9739d7cf2b [skottie] Null value crash in json::ValueRef::toString()
Bug: skia:7935
Change-Id: Ibe99ccbf5b8dcf889a71acf1fb52063001fd7612
Reviewed-on: https://skia-review.googlesource.com/126923
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-05-09 14:42:45 +00:00
swiftshader-skia-autoroll
1b6b4c5392 Roll third_party/externals/swiftshader/ d4e488eb6..0641aebe3 (1 commit)
https://swiftshader.googlesource.com/SwiftShader/+log/d4e488eb6dfb..0641aebe3155

$ git log d4e488eb6..0641aebe3 --date=short --no-merges --format='%ad %ae %s'
2018-05-08 sugoi Rectangle texture addressing fix

Created with:
  roll-dep third_party/externals/swiftshader


The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-All-SwiftShader
TBR=egdaniel@google.com

Change-Id: I762613f4c10f156bbf9ae9c508ae348258076547
Reviewed-on: https://skia-review.googlesource.com/126940
Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-09 14:37:15 +00:00
Brian Osman
01b2244e0f When validating transfer fns, allow D > 1
This matches behavior in skcms. Previously, we could get a profile with
a large D value, skcms would decide it was okay, but then we'd be unable
to create an SkColorSpace from it.

Bug: chromium:841110
Change-Id: I2418a0b770172bff62a14d2d4d0fc7ba70f33e0b
Reviewed-on: https://skia-review.googlesource.com/126920
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
2018-05-09 14:34:05 +00:00
Hal Canary
1c2bcd8b14 SkAdvancedTypefaceMetrics: factor out GlyphToUnicode
Change-Id: Iedce8c1ea2c405d5ab64ccac353970d5cd2b9d63
Reviewed-on: https://skia-review.googlesource.com/126507
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2018-05-09 14:24:45 +00:00
Khushal
a2595f9255 fonts: Fix a trace name in SkRemoteGlyphCache
TBR=herb@google.com

Change-Id: I5df4295a94d9af93e29ebf64b06f5259dc54ce90
Reviewed-on: https://skia-review.googlesource.com/126842
Reviewed-by: Khusal Sagar <khushalsagar@chromium.org>
Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
2018-05-09 02:41:05 +00:00
recipe-roller
499a9b2108 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/5ae86d2021277b545889959125e778820849cf15 Update canned PRESUBMIT checks to report that TBR does not apply to OWNERS. (jbroman@chromium.org)
  https://crrev.com/276da0b4d90aad69aa0adcf3e6a792b5e364c1ee git cl: Do not set WIP when using no_squash. (jmadill@chromium.org)
  https://crrev.com/3806b7fbd0ea6704d2c35d1eb64a2a505e29ca53 bot_update: Fetch references to be synced. (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I651e8c1af3cb363b403cb921c1945028d1ebef4c
Reviewed-on: https://skia-review.googlesource.com/126827
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-05-09 01:36:04 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
05033759a8 Roll third_party/externals/angle2/ c009255c7..e95a7f077 (3 commits)
c009255c79..e95a7f077e

$ git log c009255c7..e95a7f077 --date=short --no-merges --format='%ad %ae %s'
2018-05-08 jmadill Make EGLThreadTest cross-platform.
2018-05-08 fjhenigman Revert "ANGLETest: Reuse test windows per-renderer"
2018-05-08 jmadill Revert "Update cq.cfg with new builders."

Created with:
  roll-dep third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=egdaniel@google.com

Change-Id: I5a0d644e613f8fd7cc83fb06092c7a618537c933
Reviewed-on: https://skia-review.googlesource.com/126758
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-09 01:06:04 +00:00
Khushal
88b12e9a86 fonts: Fix subpixel position mismatch in font remoting
R=herb@google.com

Bug: skia:7786
Change-Id: Icb52be92d193eb17ac20734bfa7cb00370c6ea21
Reviewed-on: https://skia-review.googlesource.com/126664
Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
Reviewed-by: Herb Derby <herb@google.com>
2018-05-08 22:44:54 +00:00
Leon Scroggins III
8a8a144952 Treat SkFILEStream's fOriginalOffset as the start
Bug: b/78866720

::rewind() rewinds to fOriginalOffset
::seek(position) seeks to position + fOriginalOffset
::move(offset) will not move < fOriginalOffset
::getPosition() returns position relative to fOriginalOffset
::getLength() returns full size minus fOriginalOffset
::duplicate() and ::fork() pass on fOriginalOffset

Android may create an SkFILEStream using a file descriptor whose offset
is at the beginning of the data that Android cares about. Treat all
positions in SkFILEStream as relative to that original offset.

This allows AnimatedImageDrawable to read directly from the
SkFILEStream, rather than using an SkFrontBufferedStream and forcing
SkGifCodec to cache data for later use.

This fixes a TODO that was introduced in
https://skia-review.googlesource.com/c/skia/+/9498 and takes it a step
further. In that CL, bungeman@ and I discussed the change and decided to
"leave this alone for now to avoid changing behavior". Doing a code
search today, the only two callers want the new behavior.

Change-Id: I9211394d5b730adf528fac0df0af7a664b1295be
Reviewed-on: https://skia-review.googlesource.com/126511
Reviewed-by: Ben Wagner <bungeman@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
2018-05-08 20:41:04 +00:00
Brian Osman
71a6995084 Only enable noperspective with ES3 shading language
This will never happen in real usage - the extension
requires ES3 support. However, we're likely to be
testing/running with ES3 and ES2 shading language to
work around driver bugs on other devices. Across many
devices, this was the only issue I found when forcing
ES2 shading language, so it seemed worth fixing.

Change-Id: I8b75c6935827c1a24c712cec4b36515581aea353
Reviewed-on: https://skia-review.googlesource.com/126640
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-05-08 19:28:34 +00:00
Ben Wagner
2700779c53 SkBlurMask to blur all the things.
SkBlurMask used to handle only A8 as input, and was recently extended to
ARGB as input. This adds LCD16 and A1 as inputs as well, allowing
SkScalerContext to no longer force all requests with a mask filter to
A8. This also fixes the shadows for LCD16 and A1 glyphs, which at small
sigma were quite obviously wrong since they were generated from an A8
version.

Change-Id: I151cdbf5556d18c2938da990ecee5bcd8ee31be8
Reviewed-on: https://skia-review.googlesource.com/126615
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-05-08 19:15:34 +00:00
Hal Canary
efb84e6734 sk_sp: check for self-assignment
Change-Id: I02e6ab8945c79c14458b36bd13ce6f6e14979460
Reviewed-on: https://skia-review.googlesource.com/126683
Reviewed-by: Ben Wagner <bungeman@google.com>
Auto-Submit: Hal Canary <halcanary@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2018-05-08 18:47:14 +00:00
Herb Derby
e1f566f2fd Use device and key descriptors
Change-Id: I2ac13303376f3d1464dd1e259637374a9c5ef237
Reviewed-on: https://skia-review.googlesource.com/125823
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Khushal Sagar <khushalsagar@google.com>
2018-05-08 18:14:04 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
60c67490a1 Roll third_party/externals/angle2/ 3b9b027c5..c009255c7 (1 commit)
3b9b027c59..c009255c79

$ git log 3b9b027c5..c009255c7 --date=short --no-merges --format='%ad %ae %s'
2018-05-08 jmadill Update cq.cfg with new builders.

Created with:
  roll-dep third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=egdaniel@google.com

Change-Id: Ie949cf8124f31e2b07b0c69e73a1705a7e1abc34
Reviewed-on: https://skia-review.googlesource.com/126742
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-08 16:00:14 +00:00
Florin Malita
38792ce0f8 Add a single-file viewer option
Pass --file/-f to open a single file for viewing.

Change-Id: Ida168765ed6a5c7d76df1a8298bfe658d39d0196
Reviewed-on: https://skia-review.googlesource.com/126761
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-05-08 15:58:44 +00:00
Chris Dalton
d925f2d38d Add a drawPaths method to GrCCPathProcessor
Bug: skia:
Change-Id: I5d3762203cbe1d823ea3f3967240bcab76651f2c
Reviewed-on: https://skia-review.googlesource.com/126662
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-05-08 15:39:04 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
75ce242a46 Roll skia/third_party/skcms ba83c97..289cedc (1 commits)
https://skia.googlesource.com/skcms.git/+log/ba83c97..289cedc

2018-05-08 mtklein@chromium.org trim end of line whitespace


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=egdaniel@google.com

Change-Id: I162f76118448152b804d7129e52183a8ca6e1f89
Reviewed-on: https://skia-review.googlesource.com/126743
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-08 15:27:12 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
50256ccf14 Roll skia/third_party/skcms 215ecb4..ba83c97 (1 commits)
https://skia.googlesource.com/skcms.git/+log/215ecb4..ba83c97

2018-05-08 mtklein@chromium.org add README.chromium


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=egdaniel@google.com

Change-Id: Idad95d3a5151d980c687d2ce8889c101902f5c1a
Reviewed-on: https://skia-review.googlesource.com/126740
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-08 14:12:04 +00:00
Robert Phillips
8d85813556 Fix a bug in SkGpuBlurUtils::GaussianBlur (take 3)
This fixes the remaining imageblurclampmode bug and a preexisting un-reported error in the imageblurrepeatmode GM.

This relies on https://chromium-review.googlesource.com/c/chromium/src/+/1044113 (Add a flag to disable a blur imagefilter bug fix in Skia) landing in Chrome first.

Bug: skia:7765
Change-Id: I66e27384541002829b2bd4b42d9cbda837aa7c3d
Reviewed-on: https://skia-review.googlesource.com/125961
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-on: https://skia-review.googlesource.com/126220
2018-05-08 12:35:44 +00:00
Brian Salomon
e7df0bb900 Avoid rerunning path renderer chain when path known to require sw
Change-Id: If8bdeadf95543917a6e00570b5806a3ee23aa335
Reviewed-on: https://skia-review.googlesource.com/126508
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-05-08 11:52:34 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
6198f39adc Roll third_party/externals/angle2/ 9f394f8cd..3b9b027c5 (1 commit)
9f394f8cdf..3b9b027c59

$ git log 9f394f8cd..3b9b027c5 --date=short --no-merges --format='%ad %ae %s'
2018-04-30 geofflang Add basic tests of (unsafe) multithreaded contexts.

Created with:
  roll-dep third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=egdaniel@google.com

Change-Id: I56adb50a67c5a51cc444e365667a840a396d430a
Reviewed-on: https://skia-review.googlesource.com/126661
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-08 02:11:43 +00:00
Khushal
cea8e3d132 text-blob: Fix OOM issues during blob deserialization.
Limit the number of glyphs allowed during blob deserialization.
Allocating for an arbitrary number can lead to OOM issues.

Bug: 840096
Change-Id: I1673fd312438b99ff76dadcfdc9f9427acdca13b
R=bsalomon@chromium.org
Reviewed-on: https://skia-review.googlesource.com/126603
Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
2018-05-07 21:31:30 +00:00
Florin Malita
4e9e325725 [viewer] Avoid per-frame json UI updates
The reason we push Json updates for every frame is to support the
Android FPS meter - which happens to require the native FPS meter for
updates.

Instead of supporting two meters:

1) scale up the native FPS widget on Android (1.5x)

2) remove the Android widget

3) stop calling updateUIState() from onPaint()

Change-Id: Ica8109869035b2f885743a7e38b50688b69fa5e4
Reviewed-on: https://skia-review.googlesource.com/126621
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-05-07 21:30:27 +00:00
Brian Salomon
d3cee17add Visit the image proxy in GrLatticeOp
Bug:  b/77917978
Change-Id: Ib6b40ce891f576f4a1c7d624a2409f3bba36b344
Reviewed-on: https://skia-review.googlesource.com/126620
Commit-Queue: Brian Salomon <bsalomon@google.com>
Auto-Submit: Brian Salomon <bsalomon@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-05-07 21:12:27 +00:00
Brian Salomon
a8daee88d2 Add null proxy test to SkGpuDevice::drawProducerLattice
Bug: b/77917978

TBR=brianosman@google.com

Change-Id: Ib7ecb00dd0beac2444ca95106c2560c2b2940465
Reviewed-on: https://skia-review.googlesource.com/126509
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-05-07 20:15:07 +00:00
swiftshader-skia-autoroll
9a9c25b36c Roll third_party/externals/swiftshader/ 336cdd903..d4e488eb6 (1 commit)
https://swiftshader.googlesource.com/SwiftShader/+log/336cdd903180..d4e488eb6dfb

$ git log 336cdd903..d4e488eb6 --date=short --no-merges --format='%ad %ae %s'
2018-02-14 irogers Allocate executable memory backed by named mmaps on Linux.

Created with:
  roll-dep third_party/externals/swiftshader


The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-All-SwiftShader
TBR=egdaniel@google.com

Change-Id: I11f0a7a1978643fdce05c47de4de2bd20ee54bb1
Reviewed-on: https://skia-review.googlesource.com/126606
Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-07 20:11:08 +00:00
Hal Canary
5bdc4d590b SkAdvancedTypefaceMetrics: simplify more
Change-Id: I80c28c50aa96c28181d2fef13daad4a80ec91a12
Reviewed-on: https://skia-review.googlesource.com/120160
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2018-05-07 20:07:57 +00:00
Kevin Lubick
e0b7f5cb0c Trim down T8888 configs
Don't run them on non-GCE bots either.

Bug: skia:
Change-Id: I15f9a1b7e74eb89a5d580d4e5f82be6e27335600
Reviewed-on: https://skia-review.googlesource.com/126501
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-05-07 19:43:07 +00:00
Mike Klein
ecac36e6b9 make SkColorSpace::MakeICC strict as skcms
We do this somewhat trivially by calling skcms_Parse()
and failing if it fails.

This will help keep us sane while we work to remove
SkColorSpace::MakeICC().

Change-Id: Icb1bc1a088083e181f46465dbb3a530f0e004193
Reviewed-on: https://skia-review.googlesource.com/126510
Commit-Queue: Mike Klein <mtklein@chromium.org>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@chromium.org>
Reviewed-by: Brian Osman <brianosman@google.com>
2018-05-07 19:18:37 +00:00
Brian Osman
1f5cd6cc7f Handle failure to create SkColorSpaceXform in SkConvertPixels
For now, this will just fallback to the pipeline code. Eventually, we
may need to support more color spaces in skcms, (or put in a simpler
fallback that just does type conversion and ignores color space)?

Bug: chromium:838115
Change-Id: Id71eec6a72202683957c884620ee3fe90df6c776
Reviewed-on: https://skia-review.googlesource.com/126201
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-05-07 19:03:57 +00:00
Herb Derby
382caaecdf Make sure the ScalerContextRec is dense
Make sure that the Rec structure is dense because
the SkDescriptor code takes checksums of this
structure.

Change-Id: Id384ed49e17f4613647da538c810f09a066efd90
Reviewed-on: https://skia-review.googlesource.com/126503
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-05-07 18:37:30 +00:00
recipe-roller
a3fde20002 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/6f3c1c82d48ba8c9cee1d15d1406f47973aa88fa Update windows git to 2.17.0 (tandrii@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifbc1b41b9b4f0ddd86726c3094e439a5cf62b676
Reviewed-on: https://skia-review.googlesource.com/126504
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
2018-05-07 18:32:39 +00:00
Brian Salomon
2a943df011 Make GPU lattice/nine patch not bleed across cells.
Consolidate code for handling various image/bitmap and lattice/ninepatch flavors.

Makes refTextureForParams virtual on GrTextureProducer. Previously both subclasses had non-virtual flavors of this.

Bug: b/77917978

Change-Id: I14787faef33c4617ef359039e81453d683f33ff1
Reviewed-on: https://skia-review.googlesource.com/125520
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-05-07 18:08:40 +00:00
Brian Salomon
817847c0c6 Update canvas2D read/write pixels fast path to handle BGRA input/output
Change-Id: Ib77b45dc0ea2b00c728b080d6d847f97b1471bff
Reviewed-on: https://skia-review.googlesource.com/126482
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-05-07 18:05:29 +00:00
skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
a724ea55ae Roll skia/third_party/skcms bd90169..215ecb4 (1 commits)
https://skia.googlesource.com/skcms.git/+log/bd90169..215ecb4

2018-05-07 brianosman@google.com Remove make_signature, use enums for all ICC signatures


The AutoRoll server is located here: https://skcms-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=egdaniel@google.com

Change-Id: I4d4331fc3af2bcdb9e07725e7e04a63d253d4280
Reviewed-on: https://skia-review.googlesource.com/126523
Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-07 17:31:09 +00:00
Herb Derby
026286031d Remove android specific code - v2
Change-Id: I2010b168f1a1f3bc48b86a075b0398eaf46ea328
Reviewed-on: https://skia-review.googlesource.com/126480
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-05-07 17:24:29 +00:00
angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
33fc7fbfce Roll third_party/externals/angle2/ 983460e6c..9f394f8cd (4 commits)
983460e6cd..9f394f8cdf

$ git log 983460e6c..9f394f8cd --date=short --no-merges --format='%ad %ae %s'
2018-05-07 oetuaho Fix use-after-free in drawQuad with useVertexBuffer false
2018-05-07 cwallez ANGLETest: Reuse test windows per-renderer
2018-04-27 jiawei.shao Use ShaderMap in Caps - Part I
2018-05-03 geofflang Implement extensions exposing ETC2 compressed texture formats in ES2.

Created with:
  roll-dep third_party/externals/angle2


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=egdaniel@google.com

Change-Id: I46c60ea2b0c7559a2c01b85977bc9cf3fc76e23c
Reviewed-on: https://skia-review.googlesource.com/126446
Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
2018-05-07 16:59:09 +00:00
Robert Phillips
5575ffec63 Add Pixel2 DDL Vulkan bots
Change-Id: I396fef460cf2725993fad691c0187dcb724c0e23
Reviewed-on: https://skia-review.googlesource.com/126462
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-05-07 16:57:59 +00:00
Ben Wagner
01c304e476 Reland "Avoid drawing BW clipped color glyphs many times."
This reverts commit 8a95244f62.

Reason for revert: Didn't actually break anything.

Original change's description:
> Revert "Avoid drawing BW clipped color glyphs many times."
> 
> This reverts commit bba38ee80e.
> 
> Reason for revert: possibly breaking chrome text
> 
> Original change's description:
> > Avoid drawing BW clipped color glyphs many times.
> > 
> > Prior to this change if a color glyph is drawn through the raster device
> > with an aliased clip the glyph is drawn once for each rectangular region
> > in the aliased clip. In addition, even when the glyph was not a color
> > glyph in this situation, the mask was checked for being a color glyph
> > once for each rectangular region of the aliased clip. This change hoists
> > the test for the color format out of the loop to ensure that the mask
> > format is checked once and the mask is drawn once.
> > 
> > This issue was discovered by rotating the coloremoji_blendmodes gm.
> > 
> > Change-Id: I18b6b546356780e0b00948fff7b65783219f5c92
> > Reviewed-on: https://skia-review.googlesource.com/125868
> > Reviewed-by: Mike Reed <reed@google.com>
> > Commit-Queue: Ben Wagner <bungeman@google.com>
> 
> TBR=mtklein@google.com,bungeman@google.com,reed@google.com
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Change-Id: Ife6d7255f9cb88b6f9d7a3c5800e88cc065e475b
> Reviewed-on: https://skia-review.googlesource.com/126401
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Commit-Queue: Greg Daniel <egdaniel@google.com>

TBR=egdaniel@google.com,mtklein@google.com,bungeman@google.com,reed@google.com

Change-Id: I7fc4c1f901bcee482f6b118b192caee14c112e43
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/126540
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-05-07 16:53:50 +00:00
Kevin Lubick
a585f73bbe Remove T8888 from Windows CQ bot
This is a stop-gap measure.

Bug: skia:7838#c20
Change-Id: Ib9af9aefa4327d24f66f95d9a82ee53c19733524
Reviewed-on: https://skia-review.googlesource.com/126461
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
2018-05-07 16:43:28 +00:00
Yuqian Li
5c91fa4d84 Respect SkBitmapDeviceFilteredSurfaceProps in SkThreadedBMPDevice
Bug: skia:7909
Change-Id: I13ccfbdc883f764f60701383b90537d3175a8126
Reviewed-on: https://skia-review.googlesource.com/126100
Commit-Queue: Ben Wagner <bungeman@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Auto-Submit: Yuqian Li <liyuqian@google.com>
Reviewed-on: https://skia-review.googlesource.com/126463
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-05-07 16:40:29 +00:00
Mike Klein
ad67c66a58 track bounds of top-level control ops
We don't need an explicit save-restore block to determine the bounds of
top-level control operations... the implicit save-restore that all
picutres have should logically work the same way.

The commented test failed before this and passes now.

Bug: skia:7735
Change-Id: Ibd31a3a9b0b48042ab3869a6bb57bc8d8bb78c09
Reviewed-on: https://skia-review.googlesource.com/126460
Commit-Queue: Mike Klein <mtklein@chromium.org>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@chromium.org>
Reviewed-by: Brian Osman <brianosman@google.com>
2018-05-07 16:14:09 +00:00