commit-bot@chromium.org
21a0b10d7c
Remove deprecated setIsOpaque() API from SkBitmap.
...
Clients we care (Blink, Chromium) were updated, so we can remove this now.
BUG=None
R=bsalomon@google.com , reed@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/66723017
git-svn-id: http://skia.googlecode.com/svn/trunk@12251 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 18:16:34 +00:00
commit-bot@chromium.org
23a9121961
pdfviewer: compile pdfviewer in gm, only if the flag is set (currently we compile pdfviewer, even if it is not used)
...
R=scroggo@google.com , jvanverth@google.com
Author: edisonn@google.com
Review URL: https://codereview.chromium.org/68533003
git-svn-id: http://skia.googlecode.com/svn/trunk@12249 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 17:44:28 +00:00
robertphillips@google.com
5fa42d1621
"Fix" another crash on valgrind bot
...
https://codereview.chromium.org/70463002/
git-svn-id: http://skia.googlecode.com/svn/trunk@12248 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 17:33:02 +00:00
scroggo@google.com
cac8d01eab
Override drawRRect in fake SkBitmapDevices.
...
Recent changes to SkBitmapDevice modified ::drawRRect() to take
an optimized drawing case. Some subclasses of SkBitmapDevice were
depending on the old behavior of calling ::drawPath(). Since they
do not draw, attempting to take the drawing path can cause problems.
For these subclasses, call drawPath() in the subclass.
R=reed@google.com , robertphillips@google.com
Review URL: https://codereview.chromium.org/70443002
git-svn-id: http://skia.googlecode.com/svn/trunk@12247 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 17:10:02 +00:00
senorblanco@chromium.org
f14bcd25e5
Remove some now-unused #ifdefs.
...
R=mtklein@google.com , mtklein, reed@google.com
Review URL: https://codereview.chromium.org/68473003
git-svn-id: http://skia.googlecode.com/svn/trunk@12246 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 16:46:43 +00:00
reed@google.com
23be7a58d9
add colortable enum to SkImage to ease interop between it and SkBitmap::Config
...
BUG=
R=halcanary@google.com , scroggo@google.com
Review URL: https://codereview.chromium.org/68853003
git-svn-id: http://skia.googlecode.com/svn/trunk@12245 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 16:11:07 +00:00
scroggo@google.com
5401cd019b
Clean up after longjmp in SkImageDecoder_libpng.
...
In onDecodeInit, if longjmp sends us back to setjmp, destroy the
png_struct and info_ptr before returning false. Since the
PNGAutoClean has not been created yet, we were previously
leaking resources.
R=djsollen@google.com
Review URL: https://codereview.chromium.org/68453006
git-svn-id: http://skia.googlecode.com/svn/trunk@12244 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 15:30:06 +00:00
scroggo@google.com
f4dcea6020
Make bench_compare executable.
...
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/63153005
git-svn-id: http://skia.googlecode.com/svn/trunk@12243 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 15:25:31 +00:00
bungeman@google.com
9fc5c68823
Fix leak detected in FontMgrMatchGM::onDraw by Valgrind.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12242 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 15:25:29 +00:00
scroggo@google.com
940ccc819b
Add a script for running pdfviewer and comparing to existing results.
...
For quick, local checking to see how changes to pdfviewer have changed
PDF files.
Scripts were originally written by edisonn, and updated here for checkin.
R=epoger@google.com
Review URL: https://codereview.chromium.org/62103008
git-svn-id: http://skia.googlecode.com/svn/trunk@12241 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 14:52:47 +00:00
scroggo@google.com
5c7be9584c
Use SkPathJoin and SkBasename in Pdfviewer.
...
Remove redundant code.
R=edisonn@google.com
Review URL: https://codereview.chromium.org/68263003
git-svn-id: http://skia.googlecode.com/svn/trunk@12240 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 14:43:44 +00:00
scroggo@google.com
086364b8e6
Changes to make SkPDiff more robost.
...
bitmap_to_cielab now returns a boolean. Instead of asserting that the
config is 8888, copy to 8888 (and return false on failure). This allows
skpdiff to work on Index8 bitmaps (without changing the code that does
the real work). If it returns false, do not attempt to create a pmetric.
In pmetric, exit early if maxLevels is <= 2, since this would crash later
in the function (creation of an ImageL3D if maxLevels is 0, and then the
creation of an array of a negative number of entries). maxLevels is small
if the width or height of the image is small (i.e. a bitmap with width 1
has maxLevels of 0).
R=djsollen@google.com
Review URL: https://codereview.chromium.org/65253002
git-svn-id: http://skia.googlecode.com/svn/trunk@12239 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 14:41:20 +00:00
scroggo@google.com
feeca3c7c2
Create nonPOD before setjmp.
...
With PNGAutoClean created after setjmp, when longjmp is called its destructor
is never called. Create it before setjmp, ensuring that its destructor is
called.
R=mtklein@google.com
Review URL: https://codereview.chromium.org/65283002
git-svn-id: http://skia.googlecode.com/svn/trunk@12238 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 14:38:41 +00:00
scroggo@google.com
59c3ab637b
Fix a memory leak in SkGPipeCanvas.
...
In cross process mode (currently unused but tested on the bots),
SkGPipeCanvas has a tangle of circular references, which prevents
it from being deleted. Break the chain of references.
R=junov@chromium.org
Review URL: https://codereview.chromium.org/69633003
git-svn-id: http://skia.googlecode.com/svn/trunk@12237 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 14:32:38 +00:00
robertphillips@google.com
d6bea606c6
Silence another valgrind leak
...
https://codereview.chromium.org/68523006/
git-svn-id: http://skia.googlecode.com/svn/trunk@12236 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 14:05:15 +00:00
robertphillips@google.com
3bddb38e64
Fix crash in tests on valgrind bot
...
https://codereview.chromium.org/63543005/
git-svn-id: http://skia.googlecode.com/svn/trunk@12234 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 13:51:03 +00:00
rmistry@google.com
7bce8e2339
New SVG SKPs have been added to the buildbot repo. Triggering rebuilds.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12233 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 13:49:52 +00:00
skia.committer@gmail.com
11a253b686
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12232 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 07:02:05 +00:00
robertphillips@google.com
50a7600d05
Disable Blurred RR optimization in Chrome
...
https://codereview.chromium.org/68773005/
git-svn-id: http://skia.googlecode.com/svn/trunk@12231 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-12 01:16:56 +00:00
edisonn@google.com
73a7ea3ae0
Implement DPI for perspective bitmaps in PDF - we save the bitmap at the resolution requested.
...
R=reed@google.com , vandebo@chromium.org
Review URL: https://codereview.chromium.org/54913004
git-svn-id: http://skia.googlecode.com/svn/trunk@12230 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-11 20:55:15 +00:00
jvanverth@google.com
d830d13c27
Hook in rough distance field support for fonts
...
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/41213003
git-svn-id: http://skia.googlecode.com/svn/trunk@12229 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-11 20:54:09 +00:00
senorblanco@chromium.org
05edd02a7c
Implement a speedup for Y-only blurs by transposing.
...
R=mtklein@google.com , mtklein, reed@google.com
BUG=
Review URL: https://codereview.chromium.org/66413007
git-svn-id: http://skia.googlecode.com/svn/trunk@12227 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-11 20:12:34 +00:00
robertphillips@google.com
6acc8f473d
Add another FontConfig suppression to valgrind suppressions
...
https://codereview.chromium.org/69403002/
git-svn-id: http://skia.googlecode.com/svn/trunk@12226 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-11 20:04:28 +00:00
bungeman@google.com
d37a7dc814
The coloremoji GM should now look like it did before.
...
With r12224 we now check that a stream looks like a font
before trying to use it.
git-svn-id: http://skia.googlecode.com/svn/trunk@12225 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-11 19:59:40 +00:00
bungeman@google.com
0cd74ad38a
Make onCreateFromStream check that the stream looks like a font.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12224 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-11 19:52:29 +00:00
jvanverth@google.com
af35641762
Ignore coloremoji GM for now.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12223 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-11 19:48:14 +00:00
robertphillips@google.com
ad99358bdd
Fix memory leak in filterRRectToNine
...
https://codereview.chromium.org/65723005/
git-svn-id: http://skia.googlecode.com/svn/trunk@12222 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-11 18:45:18 +00:00
bungeman@google.com
451b5962c9
Android FontHost cannot use FontMgr yet.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12221 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-11 18:36:46 +00:00
bungeman@google.com
e0f04689c8
Give Android a SkFontMgr::Factory which was missing as of r12217.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12220 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-11 17:49:42 +00:00
senorblanco@chromium.org
f376f5de93
Implement a NEON version of morphology. This is good for ~2.2X speedup on Tegra3.
...
R=mtklein@google.com , mtklein, reed@google.com
Review URL: https://codereview.chromium.org/68123003
git-svn-id: http://skia.googlecode.com/svn/trunk@12219 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-11 16:48:51 +00:00
bungeman@google.com
13f9e0e4b2
Re-add NULL FontMgr::Factory hadnling code removed in r12217.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12218 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-11 16:26:55 +00:00
bungeman@google.com
b3d154de5e
Remove SK_FONTHOST_USES_FONTMGR.
...
Review URL: https://codereview.chromium.org/66783003
git-svn-id: http://skia.googlecode.com/svn/trunk@12217 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-11 15:53:29 +00:00
edisonn@google.com
247ac53c29
pdfviewer: fix build break in windows (wrong return type on function)
...
Review URL: https://codereview.chromium.org/68973002
git-svn-id: http://skia.googlecode.com/svn/trunk@12216 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-11 15:36:44 +00:00
commit-bot@chromium.org
ffd178c84d
Initial draft code to run pdfviewer withg gms
...
draft cl to run pdfviewer with gms modified: gm/gmmain.cpp modified: gyp/gm.gyp modified: src/utils/SkPDFRasterizer.cpp modified: src/utils/SkPDFRasterizer.h
R=scroggo@google.com , borenet@google.com
Author: edisonn@google.com
Review URL: https://codereview.chromium.org/26269002
git-svn-id: http://skia.googlecode.com/svn/trunk@12214 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-11 15:10:47 +00:00
jvanverth@google.com
62454a6603
Update bench expectations.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12213 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-11 14:36:54 +00:00
borenet@google.com
43a385240f
Specify --patchlevel 0 to trychange.py
...
For some reason, trychange.py creates patches with level 0, even from a git
repo. We were assuming that the patch level was 1 from a git repo, so patches
were failing to apply.
BUG=skia:1669
R=rmistry@google.com
Review URL: https://codereview.chromium.org/61733011
git-svn-id: http://skia.googlecode.com/svn/trunk@12212 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-11 13:43:22 +00:00
robertphillips@google.com
6c1e49af8d
Removed deprecated API calls that have crept in
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12210 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-10 15:08:45 +00:00
robertphillips@google.com
a3d0119859
Re-enable SK_ATTR_DEPRECATED (i.e., revert r12067)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12209 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-10 14:40:21 +00:00
skia.committer@gmail.com
ed000840d4
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12208 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-09 07:02:23 +00:00
senorblanco@chromium.org
771b537fec
More new baselines for stragglerbots.
...
TBR=epoger
BUG=
Review URL: https://codereview.chromium.org/63173014
git-svn-id: http://skia.googlecode.com/svn/trunk@12207 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-09 04:45:18 +00:00
commit-bot@chromium.org
5916705587
add GM case nonclosedpaths. The 2 bugs below showed some non-closed paths which are easy to get wrong rendering results. So add a GM case for this kind paths to avoid potential bugs to be introduced.
...
BUG=skia:1782
BUG=skia:1811
R=bsalomon@google.com , caryclark@google.com , reed@google.com , robertphillips@google.com
Author: yunchao.he@intel.com
Review URL: https://codereview.chromium.org/64173009
git-svn-id: http://skia.googlecode.com/svn/trunk@12206 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-09 01:37:30 +00:00
senorblanco@chromium.org
bafb01bf80
Blur rebaselines for some straggler bots that just caught up.
...
R=epoger
BUG=
Review URL: https://codereview.chromium.org/58853007
git-svn-id: http://skia.googlecode.com/svn/trunk@12205 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-08 21:24:40 +00:00
senorblanco@chromium.org
27eec46d69
SSE2 implementation of RGBA box blurs. This yields ~2X perf improvement on Xeon ES-2690.
...
R=mtklein@google.com
Review URL: https://codereview.chromium.org/61643011
git-svn-id: http://skia.googlecode.com/svn/trunk@12204 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-08 20:49:04 +00:00
commit-bot@chromium.org
11e5b972a9
Add sk_float_rsqrt with SSE + NEON fast paths.
...
Current numbers:
N4:
running bench [640 480] math_fastIsqrt NONRENDERING: cmsecs = 3.12
running bench [640 480] math_slowIsqrt NONRENDERING: cmsecs = 4.82
running bench [640 480] math_sk_float_rsqrt NONRENDERING: cmsecs = 1.99
Desktop:
running bench [640 480] math_fastIsqrt NONRENDERING: cmsecs = 0.89
running bench [640 480] math_slowIsqrt NONRENDERING: cmsecs = 0.94
running bench [640 480] math_sk_float_rsqrt NONRENDERING: cmsecs = 0.09
Haven't found any other benches where this is a significant effect yet.
BUG=
R=reed@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/60083014
git-svn-id: http://skia.googlecode.com/svn/trunk@12203 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-08 20:14:16 +00:00
commit-bot@chromium.org
8f457e3230
Adding error checks to SkRBuffer
...
BUG=
R=robertphillips@google.com , bsalomon@google.com , reed@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/61913002
git-svn-id: http://skia.googlecode.com/svn/trunk@12202 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-08 19:22:57 +00:00
commit-bot@chromium.org
9901727f21
Fix stale assert in GrDrawTarget::print
...
Fix stale assert in GrDrawTarget::print.
R=bsalomon@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/66333002
git-svn-id: http://skia.googlecode.com/svn/trunk@12201 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-08 18:45:27 +00:00
caryclark@google.com
c4a4f9db6b
fix compile error
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12200 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-08 18:11:08 +00:00
caryclark@google.com
2e1b99e61f
optimize floating pt, save a few instructions
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12199 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-08 18:05:02 +00:00
scroggo@google.com
a8e33a92e2
Add ability to ninepatch blurred rounded rectangle
...
Speed up drawing large blurry round rectangles by converting them to
nine patches.
SkDraw:
Add drawRRect.
SkBitmapDevice:
Call SkDraw::drawRRect instead of converting SkRRect to an SkPath.
SkMaskFilter/SkBlurMaskFilter:
Create a nine patch of a blurred round rect and draw it instead of
drawing the entire thing.
SkPDFDevice:
Override drawRRect to perform the old behavior in
SkBitmapDevice::drawRect.
Depends on https://codereview.chromium.org/52703003
Tests are in https://codereview.chromium.org/52793005
BUG=https://b.corp.google.com/issue?id=11174385
R=reed@google.com , robertphillips@google.com
Review URL: https://codereview.chromium.org/48623006
git-svn-id: http://skia.googlecode.com/svn/trunk@12198 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-08 18:02:53 +00:00
caryclark@google.com
1510726d60
fix line intersection
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12197 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-11-08 18:00:01 +00:00