Commit Graph

37389 Commits

Author SHA1 Message Date
Jim Van Verth
21bd60daa3 Connect up YUVA images for testing.
* Fixes isTextureBacked() for SkImage_GpuYUVA
* Hooks in SkImage_GpuYUVA::MakePromiseYUVATexture()
* Pass down plane texture sizes to MakePromiseYUVATexture()
* Move some other methods to SkImage_GpuBase.

Bug: skia:7901
Change-Id: I33d62c16b426abba5830f7168f9f8fd54a0cb093
Reviewed-on: https://skia-review.googlesource.com/c/161149
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-10-12 19:31:08 +00:00
skia-autoroll
8982a50fc7 Roll third_party/externals/swiftshader 49336beaa6cf..f417d9d7404f (6 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/49336beaa6cf..f417d9d7404f


git log 49336beaa6cf..f417d9d7404f --date=short --no-merges --format='%ad %ae %s'
2018-10-12 capn@google.com Rename SWIFTSHADER_LLVM_VERSION to REACTOR_LLVM_VERSION.
2018-10-12 nicolas.capens@gmail.com Rename Reactor/Memory.* to Reactor/ExecutableMemory.*
2018-10-12 capn@google.com Delete unused functionality.
2018-10-12 capn@google.com Make Reactor build stand-alone.
2018-10-12 capn@google.com Output intermediate build files to project independent directories.
2018-10-12 capn@google.com Rename Reactor namespace to rr.


Created with:
  gclient setdep -r third_party/externals/swiftshader@f417d9d7404f

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=stani@google.com

Change-Id: I2db9ff19d89d9ff907213518fc8d37cfdf6e0390
Reviewed-on: https://skia-review.googlesource.com/c/161897
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-10-12 19:10:08 +00:00
Brian Salomon
7d94bb5d1a Skip visiting for allocator gathering in GrTextureOp when all proxies
are not recyclable.

Change-Id: I5ff9c48b3d7b37531a3f052bd5188a8afcacf3cb
Reviewed-on: https://skia-review.googlesource.com/c/161860
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-10-12 19:08:31 +00:00
Mike Klein
f9f68ffa30 tiny extra optimization for SkColor4fXformer
When dst is null we can't hit the Equals() fast path,
as Equals() says only null == null.  Instead treat
null dst as src, i.e. skip the transform.

This should be an observable no-op... SkConvertPixels
will recognize null dst == src and do no color transform.
This CL just avoids the extra copy.

Change-Id: I7c1983d5db733a2dd036d84c2ff91add136e1c68
Reviewed-on: https://skia-review.googlesource.com/c/161587
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2018-10-12 18:58:54 +00:00
Ethan Nicholas
222e275b0a converted AARectEffect to new FP system
Bug: skia:
Change-Id: I0e4141c7f547bab92c65a6abff120ed04d5c2c66
Reviewed-on: https://skia-review.googlesource.com/c/153550
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2018-10-12 18:54:54 +00:00
Kevin Lubick
a60a1945eb Add Vulkan to BuildStats-Mini
Bug: skia:
Change-Id: I320b7945e5e2939404e039cb83831b2bb408aaac
Reviewed-on: https://skia-review.googlesource.com/c/161842
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-10-12 18:37:37 +00:00
skia-autoroll
d48a6facb5 Roll third_party/externals/swiftshader d6126aea667e..49336beaa6cf (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/d6126aea667e..49336beaa6cf


git log d6126aea667e..49336beaa6cf --date=short --no-merges --format='%ad %ae %s'
2018-10-12 capn@google.com Add LLVM 7.0 as git subtree
2018-10-12 capn@google.com Remove LLVM 7.0 git submodule


Created with:
  gclient setdep -r third_party/externals/swiftshader@49336beaa6cf

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=stani@google.com

Change-Id: I4da6f0a64af75b2ab83f23f2972230e67fccbddc
Reviewed-on: https://skia-review.googlesource.com/c/161890
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-10-12 17:49:08 +00:00
Florin Malita
21119ace66 [skottie] Add support for fill effect opacity
Also, it turns out layer effect properties are keyed by their
index in the property array, and not by "ty".  Update the
implementation to reflect this.


Change-Id: I72c6cf83f60ee1f8240222c7e2be2d567555a772
Reviewed-on: https://skia-review.googlesource.com/c/161840
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Reed <reed@google.com>
2018-10-12 17:38:28 +00:00
Brian Osman
b9c4978cd1 Remove dstColorSpace from SkSpecialImage::MakeFromImage
The argument is unused (and in future CLs will be removed entirely)

Bug: skia:
Change-Id: Iec6b757992f7e27d8f929b000227ec5bd3a8f8d5
Reviewed-on: https://skia-review.googlesource.com/c/161841
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-10-12 17:06:02 +00:00
skia-autoroll
8dc967f9e1 Roll third_party/externals/angle2 671809e62e80..c97e3f6684c7 (1 commits)
671809e62e..c97e3f6684


git log 671809e62e80..c97e3f6684c7 --date=short --no-merges --format='%ad %ae %s'
2018-10-12 jmadill@chromium.org Revert "ES31: Add vector and matrix support in SSBO for D3D"


Created with:
  gclient setdep -r third_party/externals/angle2@c97e3f6684c7

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stani@google.com

Change-Id: I23352e71a622e92bd6f4bada2f91e59b6b99d7d7
Reviewed-on: https://skia-review.googlesource.com/c/161882
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-10-12 16:59:42 +00:00
Mike Klein
36528e91c2 clean up SkPipe
One less SkCanvas subclass to deal with...

Change-Id: I21e81648026be5d732e8d9a28baed55015492a04
Reviewed-on: https://skia-review.googlesource.com/c/161584
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-10-12 16:50:21 +00:00
Mike Klein
419709dbb1 disable lowp raster pipeline stages in Flutter
Flutter barely needs the float stages, and
probably doesn't care at all about these.

Change-Id: I663e5496f4f9a6c689c1ef0137b2318177fb3760
Reviewed-on: https://skia-review.googlesource.com/c/161582
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Reed <reed@google.com>
2018-10-12 16:10:01 +00:00
Brian Salomon
d7065e72da Revert "Revert "Add experimental API to draw a set of SkImages in one SkCanvas call.""
This reverts commit 8d5b41b553.

Bug: skia:8444
Change-Id: I29b52c6fe9475c6113ec954b7918cf591111846c
Reviewed-on: https://skia-review.googlesource.com/c/161627
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-10-12 16:09:21 +00:00
Brian Osman
11422c63d3 Tie mip map cache purging to Images, not Bitmaps/PixelRefs
We were potentially using different keys for lookup vs. add, because we
were adding with a key based on the pixelRef, which may not have the
same uniqueID as the originating image.

Bug: skia:
Change-Id: Ib4d3d5ead9f5a574cf6d1920080bc9c4ae66c1d0
Reviewed-on: https://skia-review.googlesource.com/c/161625
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-10-12 16:04:21 +00:00
Hal Canary
298442989b SkPDF: treat alpha as color component.
Before this change, we converted the paint's alpha from a float to a
byte, then serialized it as a float in the range 0-1, with
full single-precision precision (~8 decimals).  This was stupid.

Now, we store a float, and then serialize it with 4 decimals of
precision, like other color components.

Change-Id: I05c6ecf7e6a156087c1964ee0c1ebdedcff0cda5
Reviewed-on: https://skia-review.googlesource.com/c/161142
Commit-Queue: Hal Canary <halcanary@google.com>
Auto-Submit: Hal Canary <halcanary@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2018-10-12 15:56:34 +00:00
Brian Osman
be686f0773 Remove legacy makeColorSpace implementation
Chrome has rebaselined against the new implementation

Bug: skia:8382
Change-Id: I6896cda4a970ba061cd26ba20358cd842f6bf83d
Reviewed-on: https://skia-review.googlesource.com/c/161820
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-10-12 15:45:01 +00:00
Hal Canary
bd68adfdcb SkDynamicMemoryWStream: optimize detachAsStream() for tiny streams
Empty streams: one heap alloc instead of two.

Single-block streams: realloc to used portion of block.

Change-Id: I3d7b3a465b28409a4bb93782ea1ddb21a97f70a1
Reviewed-on: https://skia-review.googlesource.com/c/161600
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2018-10-12 15:28:21 +00:00
Greg Daniel
6dd96080d5 Have old GrBackend name still available.
Bug: skia:
Change-Id: Ief77cb6df7b8762a45b30a4b9ca0e7644f830610
Reviewed-on: https://skia-review.googlesource.com/c/161623
Auto-Submit: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-10-12 15:19:39 +00:00
Kevin Lubick
3fc1c0dfaa Fix gold aggregator for pathkit
Bug: skia:
Change-Id: Ib54625fa54b0c07ee72b3bec9cf13a3e9556cdf8
Reviewed-on: https://skia-review.googlesource.com/c/161626
Reviewed-by: Stephan Altmueller <stephana@google.com>
2018-10-12 14:57:43 +00:00
Brian Osman
da286e5a45 Stop using color space xform canvas in picture image generator
Guarded for Chrome to deal with layout tests.

Bug: skia:
Change-Id: I17fa1449b61a46835a8026aeb37dc8b4ecf15c6f
Reviewed-on: https://skia-review.googlesource.com/c/161621
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-10-12 14:56:27 +00:00
Kevin Lubick
0a5152efd3 Exercise entire public PathOp API
Bug: skia:
Change-Id: Ic33496e33353f1ee5a29ee6140039a2ec8a5dc7d
Reviewed-on: https://skia-review.googlesource.com/c/161424
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-10-12 14:44:41 +00:00
Brian Salomon
5dfcf1300a Reland "transform gradient colors without skcms"
This reverts commit e66e6b6eb3.

Reason for revert: reverted the wrong CL!!

Original change's description:
> Revert "transform gradient colors without skcms"
> 
> This reverts commit b27a9cf2f4.
> 
> Reason for revert: <INSERT REASONING HERE>
> 
> Original change's description:
> > transform gradient colors without skcms
> > 
> > This use of skcms kind of sticks out as odd now.
> > We can do all this using plain old SkConvertPixels.
> > 
> > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> > Change-Id: Id416058717359a413fcae63d2ae5c91040440a87
> > Reviewed-on: https://skia-review.googlesource.com/c/161583
> > Auto-Submit: Mike Klein <mtklein@google.com>
> > Commit-Queue: Brian Osman <brianosman@google.com>
> > Reviewed-by: Brian Osman <brianosman@google.com>
> 
> TBR=mtklein@google.com,brianosman@google.com
> 
> Change-Id: Ic6f722fe07aabe67984ee2090c08076290a3cc67
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> Reviewed-on: https://skia-review.googlesource.com/c/161563
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Brian Salomon <bsalomon@google.com>

TBR=mtklein@google.com,bsalomon@google.com,brianosman@google.com

Change-Id: I36ece7a5d455f648778fb7532ce15941cf9144b2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://skia-review.googlesource.com/c/161624
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-10-12 14:39:37 +00:00
Brian Salomon
8d5b41b553 Revert "Add experimental API to draw a set of SkImages in one SkCanvas call."
This reverts commit 0a0304c426.

Reason for revert: Breaking metal

Original change's description:
> Add experimental API to draw a set of SkImages in one SkCanvas call.
> 
> The client provides a src and dst rect for each image as well as
> a bitfield that indicates whether each edge of the image should be
> antialiased. This per-edge AA is useful for tiled compositors.
> 
> Rather than take a full SkPaint this API only takes an alpha, a filter
> quality (which is pinned to kLow), and a blend mode. This is a likely
> point of future evolution.
> 
> Currently the API is only fully implemented for kSrcOver on the GPU
> backend. With other blend modes or on other backends AA will be ignored
> for images that do not have all four edge AA flags set.
> 
> BUG: skia:8444
> 
> Change-Id: I143998dda8ad6a25f64e18cd600392ba553030ac
> Reviewed-on: https://skia-review.googlesource.com/c/159062
> Commit-Queue: Brian Salomon <bsalomon@google.com>
> Reviewed-by: Mike Klein <mtklein@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>

TBR=mtklein@google.com,bsalomon@google.com,brianosman@google.com,reed@google.com

Change-Id: I815baaeee5de9c6722cf2b9d071a8e2f7c1b6a96
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/161622
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-10-12 14:25:06 +00:00
Brian Salomon
e66e6b6eb3 Revert "transform gradient colors without skcms"
This reverts commit b27a9cf2f4.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> transform gradient colors without skcms
> 
> This use of skcms kind of sticks out as odd now.
> We can do all this using plain old SkConvertPixels.
> 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: Id416058717359a413fcae63d2ae5c91040440a87
> Reviewed-on: https://skia-review.googlesource.com/c/161583
> Auto-Submit: Mike Klein <mtklein@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>

TBR=mtklein@google.com,brianosman@google.com

Change-Id: Ic6f722fe07aabe67984ee2090c08076290a3cc67
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://skia-review.googlesource.com/c/161563
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-10-12 14:21:47 +00:00
Leon Scroggins III
f05626bf96 Test a GIF with an out of range transparent index
Bug: skia:8461

According to skbug.com/7069, we should allow GIFs to use a transparent
index outside of the range of the color table. Add a test to verify
support for this.

The GIF is 2x2 with the following pixels:
-------------------------------------------------
|   black            |          white           |
-------------------------------------------------
|   transparent      |      transparent         |
-------------------------------------------------

The color table only has 2 entries (black and white), and the
transparent index is 2.

Change-Id: I16574a61e2982b6628c3eca96cb7b3e1f57d3b2a
Reviewed-on: https://skia-review.googlesource.com/c/161561
Reviewed-by: Nigel Tao <nigeltao@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
Auto-Submit: Leon Scroggins <scroggo@google.com>
2018-10-12 14:20:02 +00:00
Greg Daniel
bdf12ad8d5 Move GrBackend enum to enum class.
Bug: skia:
Change-Id: I8add2470313549723be6720b543091c444d2eb4f
Reviewed-on: https://skia-review.googlesource.com/c/161680
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
2018-10-12 14:01:58 +00:00
Brian Salomon
0a0304c426 Add experimental API to draw a set of SkImages in one SkCanvas call.
The client provides a src and dst rect for each image as well as
a bitfield that indicates whether each edge of the image should be
antialiased. This per-edge AA is useful for tiled compositors.

Rather than take a full SkPaint this API only takes an alpha, a filter
quality (which is pinned to kLow), and a blend mode. This is a likely
point of future evolution.

Currently the API is only fully implemented for kSrcOver on the GPU
backend. With other blend modes or on other backends AA will be ignored
for images that do not have all four edge AA flags set.

BUG: skia:8444

Change-Id: I143998dda8ad6a25f64e18cd600392ba553030ac
Reviewed-on: https://skia-review.googlesource.com/c/159062
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2018-10-12 13:14:24 +00:00
Mike Klein
b27a9cf2f4 transform gradient colors without skcms
This use of skcms kind of sticks out as odd now.
We can do all this using plain old SkConvertPixels.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id416058717359a413fcae63d2ae5c91040440a87
Reviewed-on: https://skia-review.googlesource.com/c/161583
Auto-Submit: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2018-10-12 12:56:35 +00:00
skia-autoroll
1b62fad4b1 Roll third_party/externals/angle2 f2ed299569c0..671809e62e80 (3 commits)
f2ed299569..671809e62e


git log f2ed299569c0..671809e62e80 --date=short --no-merges --format='%ad %ae %s'
2018-10-12 jiajia.qin@intel.com ES31: Add vector and matrix support in SSBO for D3D
2018-10-12 jiajia.qin@intel.com ES31: Collect shader storage blocks info for d3d.
2018-10-12 yizhou.jiang@intel.com Enable ANGLE_texture_multisample in glsl in es 3.0


Created with:
  gclient setdep -r third_party/externals/angle2@671809e62e80

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stani@google.com

Change-Id: Ib6fec177a29c1e15f9bbcacb83f82ec33d5ece72
Reviewed-on: https://skia-review.googlesource.com/c/161769
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-10-12 08:05:58 +00:00
skia-recreate-skps
75d36e5e28 Update go_deps asset
Automatic commit by the UpdateGoDEPS bot.

TBR=borenet@google.com

Change-Id: I027b6c6582527262111ed9ebbb3463bb3ebb9e82
Reviewed-on: https://skia-review.googlesource.com/c/161765
Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
2018-10-12 05:49:23 +00:00
Mike Klein
05caa69a3f Reland "disable DAA and AAA in flutter"
This is a reland of 1421120316

PS2 rescopes a variable tighter, and reindents to make the #if-#else
logic stand out a little more clearly.

Original change's description:
> disable DAA and AAA in flutter
>
> If we're looking to cut out unnecessary code in Flutter,
> SkScan_AAA always jumps out to me as a bunch of code that
> is not logically required for GPU rendering.
>
> Looking at a treemap[1], SkScan_AAA is the biggest chunk of
> code under src/core.  I don't see DAA... maybe it's small,
> or somehow already trimmed?  Anyway, I cut it out too.
>
> [1] https://storage.googleapis.com/flutter_infra/flutter/c8755d74c17e949ee7c19cd114f084b465dac632/android-arm-release/sizes/index.html
>
> Change-Id: I4acf4aec365504c90e6b66393fd265a399f0f525
> Reviewed-on: https://skia-review.googlesource.com/c/159760
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

Change-Id: I6770781c26a0a581ed0df33c404386415472bed5
Reviewed-on: https://skia-review.googlesource.com/c/161581
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-10-12 02:22:16 +00:00
recipe-roller
2a13854464 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/dffa0b83f071c910d625955d6bb61335696e3a08 Add UUID recipe module (smut@google.com)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia77ee9ecda0d4d44abb88e58cf8baca6096db850
Reviewed-on: https://skia-review.googlesource.com/c/161702
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-10-11 23:21:19 +00:00
skia-autoroll
e1507500bc Roll third_party/externals/angle2 956ab4d9fab3..f2ed299569c0 (1 commits)
956ab4d9fa..f2ed299569


git log 956ab4d9fab3..f2ed299569c0 --date=short --no-merges --format='%ad %ae %s'
2018-10-11 oetuaho@nvidia.com Add support for EXT_texture_compression_bptc


Created with:
  gclient setdep -r third_party/externals/angle2@f2ed299569c0

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=stani@google.com

Change-Id: Iaad64d389259698ff8fc79c3b3d346e440f7d9de
Reviewed-on: https://skia-review.googlesource.com/c/161760
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-10-11 23:15:09 +00:00
Mike Klein
e7588323d5 Revert "disable DAA and AAA in flutter"
This reverts commit 1421120316.

Reason for revert

Unused variable in Google3:

   constexpr SkScalar kSmallCubicThreshold = 16;

Huh.

Original change's description:
> disable DAA and AAA in flutter
> 
> If we're looking to cut out unnecessary code in Flutter,
> SkScan_AAA always jumps out to me as a bunch of code that
> is not logically required for GPU rendering.
> 
> Looking at a treemap[1], SkScan_AAA is the biggest chunk of
> code under src/core.  I don't see DAA... maybe it's small,
> or somehow already trimmed?  Anyway, I cut it out too.
> 
> [1] https://storage.googleapis.com/flutter_infra/flutter/c8755d74c17e949ee7c19cd114f084b465dac632/android-arm-release/sizes/index.html
> 
> Change-Id: I4acf4aec365504c90e6b66393fd265a399f0f525
> Reviewed-on: https://skia-review.googlesource.com/c/159760
> Reviewed-by: Mike Reed <reed@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

TBR=mtklein@google.com,csmartdalton@google.com,liyuqian@google.com,reed@google.com

Change-Id: I40c912aeed656d21455ca983b9001b1c1e1558a1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/161720
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-10-11 22:22:30 +00:00
Cary Clark
0a67198990 reduce pathops templated code
Pathops uses a template to intersect a pair of curves.
This generates six copies: quad/quad, quad/conic, quad/cubic,
conic/conic, conic/cubic, cubic/cubic.

This CL rewrites the template to generate a single copy,
and leverages a new abstract class, SkTCurve, to dispatch
to one of SkTQuad, SkTConic, or SkTCubic. These classes
are thin wrappers on the existing double curves classes
SkDQuad, SkDConic, and SkDCubic, which do work.

Kevin's BuildStats bot says this saves around 180K on the
release build. Running pathops_unittest shows no significant
performance difference, and the smaller version may be
slightly faster.

Bug: skia:
Change-Id: I17f94fd57a317035bc105cd43a06be6da9541cb6
Reviewed-on: https://skia-review.googlesource.com/c/161146
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
Commit-Queue: Cary Clark <caryclark@skia.org>
2018-10-11 20:54:55 +00:00
Florin Malita
4963a64bc1 [skottie] Fix image loading in Viewer
With the switch to ImageAsset, I forgot to update the default/local
resource loader.

TBR=
Change-Id: I1ab898a896162718df04094a31648bf8e876d91b
Reviewed-on: https://skia-review.googlesource.com/c/161546
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-10-11 20:47:32 +00:00
recipe-roller
a7b544cab5 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
  https://crrev.com/47faa068e8ff935d4cc2cef4a4b1fb74b5e90cde git-cl: Make request to upload logs more visible. (ehmaldonado@chromium.org)


TBR=borenet@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9220ef8ac5ae0ab74c52678b3511b39213841572
Reviewed-on: https://skia-review.googlesource.com/c/161681
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
2018-10-11 20:17:25 +00:00
Mike Klein
1421120316 disable DAA and AAA in flutter
If we're looking to cut out unnecessary code in Flutter,
SkScan_AAA always jumps out to me as a bunch of code that
is not logically required for GPU rendering.

Looking at a treemap[1], SkScan_AAA is the biggest chunk of
code under src/core.  I don't see DAA... maybe it's small,
or somehow already trimmed?  Anyway, I cut it out too.

[1] https://storage.googleapis.com/flutter_infra/flutter/c8755d74c17e949ee7c19cd114f084b465dac632/android-arm-release/sizes/index.html

Change-Id: I4acf4aec365504c90e6b66393fd265a399f0f525
Reviewed-on: https://skia-review.googlesource.com/c/159760
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-10-11 20:16:32 +00:00
Cary Clark
d18a95a7d1 fix hanging fuzz in AsWinding
R=kjlubick@google.com

Bug: skia:
Change-Id: Ib34e3d4716887b63fe465de3f20c27e74ec46467
Reviewed-on: https://skia-review.googlesource.com/c/161543
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Cary Clark <caryclark@skia.org>
2018-10-11 19:46:53 +00:00
Brian Osman
38a62bdf64 Remove obsolete checks about colorType and colorSpace
Also remove the unit tests that were enforcing those rules,
and the blacklist of that unit test.

Bug: skia:
Change-Id: I802c9e81a412fe0b19d02f9224b801f4fbd901f2
Reviewed-on: https://skia-review.googlesource.com/c/161562
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
2018-10-11 19:38:53 +00:00
Cary Clark
69261ba149 fix bookmaker files
TBR=reed@google.com
NOTRY=true
Docs-Preview: https://skia.org/?cl=161544
Bug: skia:
Change-Id: I80b83bb13d5af3f758c467f8822b7dffff172414
Reviewed-on: https://skia-review.googlesource.com/c/161544
Commit-Queue: Cary Clark <caryclark@skia.org>
Auto-Submit: Cary Clark <caryclark@skia.org>
Reviewed-by: Cary Clark <caryclark@skia.org>
2018-10-11 19:34:03 +00:00
Mike Reed
a631669e50 Revert "Revert "remove unneeded flag SK_SUPPORT_LEGACY_RECTMAKELARGEST""
No clients set this flag

This reverts commit c6471ebc67.

Docs-Preview: https://skia.org/?cl=161151
Bug: skia:
Change-Id: I6100b9f26c588c68cde2172c021f6f3ebe71164f
Reviewed-on: https://skia-review.googlesource.com/c/161151
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
2018-10-11 19:15:53 +00:00
Mike Klein
dc73559e59 add missing "static"
This allows us to link both MoltenVK
and the backend which must not be named.

Change-Id: I576aab1aab92a39a4da75d5cd53c6a2c4b5b79fb
Reviewed-on: https://skia-review.googlesource.com/c/161580
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
2018-10-11 19:11:23 +00:00
Greg Daniel
f421685918 Revert "Stop using color space xform canvas in picture image generator"
This reverts commit 031ca213e0.

Reason for revert: breaking angle surfacetest unit test

Original change's description:
> Stop using color space xform canvas in picture image generator
> 
> Direct rasterization should produce similar (or identical) results.
> See: https://chromium-review.googlesource.com/c/chromium/src/+/1273815
> 
> Bug: skia:
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I252ec5d5ecb19704f33c0f6cb65d12c2ec927c1d
> Reviewed-on: https://skia-review.googlesource.com/c/161140
> Commit-Queue: Brian Osman <brianosman@google.com>
> Reviewed-by: Mike Klein <mtklein@google.com>

TBR=mtklein@google.com,brianosman@google.com

Change-Id: Ib5667f0d315c4f2877c1f0c38e9c62d37335d511
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://skia-review.googlesource.com/c/161560
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
2018-10-11 17:47:21 +00:00
Hal Canary
bcb96e9fe7 SkPDF: Emit empty glyph advance.
The PDF standard requires that all Type3 glyphs specify a d0 or d1 with
advance and bounds followed by one or more graphic objects. Empty
glyphs (like space) previously had no entry, but will now provide the
advance, empty bounds, and an empty path.

Bug: skia:8460
Change-Id: I3428c056b6884c72177e5111aa494a888bfb76fb
Reviewed-on: https://skia-review.googlesource.com/c/161500
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
Auto-Submit: Hal Canary <halcanary@google.com>
2018-10-11 17:35:20 +00:00
Brian Salomon
309b053dbf Increase initial Interval allocation in GrResourceAllocator
Change-Id: I4d644e5fdef6d9fc2eafd7458b61ed47f0bb78cd
Reviewed-on: https://skia-review.googlesource.com/c/161152
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-10-11 16:55:57 +00:00
Brian Osman
031ca213e0 Stop using color space xform canvas in picture image generator
Direct rasterization should produce similar (or identical) results.
See: https://chromium-review.googlesource.com/c/chromium/src/+/1273815

Bug: skia:
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I252ec5d5ecb19704f33c0f6cb65d12c2ec927c1d
Reviewed-on: https://skia-review.googlesource.com/c/161140
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-10-11 16:47:27 +00:00
Robert Phillips
9945f76cd8 Add "--reduceOpListSplitting" to more bots
Change-Id: Id9e86327bf85f766fac67704078e00bac4af346d
Reviewed-on: https://skia-review.googlesource.com/c/161422
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
2018-10-11 16:42:21 +00:00
Brian Osman
2091fbb07c Fix some bugs around opaque color types and computeIsOpaque
Spun out from: https://skia-review.googlesource.com/c/skia/+/161423

Bug: skia:
Change-Id: I7f3a7e10faa844271235f3b064576d43bab8e554
Reviewed-on: https://skia-review.googlesource.com/c/161480
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-10-11 15:33:54 +00:00
Brian Osman
3ea317cb6f Remove checks that insist on kOpaque for some color types
For destinations, Premul vs. Unpremul is actually meaningful
for these color types - it determines whether or not we divide
through by alpha after blending. Opaqueness ought to just be
a performance hint, and only for sources.

Bug: skia:
Change-Id: I801a64316ec9c92642982cd2096f8bec9a7855f3
Reviewed-on: https://skia-review.googlesource.com/c/161423
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-10-11 15:30:55 +00:00