Commit Graph

37133 Commits

Author SHA1 Message Date
Mike Reed
66c505f6e8 expand imageinfo in C api, start on colorspace
After sk_imageinfo was initially created, we have added a colorspace to it,
and that object is a smart-pointer. In response to that, this CL upgrades
imageinfo to an "object" (like paint), so we can manage the ref-counting of
its colorspace, and to allow for future changes/expansion (like paint).

Bug: skia:
Change-Id: I629ff99c0820fdbe83f062d9fb768c15cda68e18
Reviewed-on: https://skia-review.googlesource.com/157156
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-09-28 17:52:59 +00:00
Hal Canary
813b5ac183 SkPDF: tiny fix to Porter-Duff modes; improves three GMs
coloremoji_blendmodes, colormatrix, xfermodes

Change-Id: I0ce37adb747aa5ccb1b31f779be9ef37e989db9b
Reviewed-on: https://skia-review.googlesource.com/157860
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2018-09-28 17:47:58 +00:00
Chris Dalton
184c37e61a Add a "bisect" mode to dm for debugging path drawing
Bug: skia:
Change-Id: Idc841545dfe3d33f43c1c8a3cf23199c322f7b11
Reviewed-on: https://skia-review.googlesource.com/156929
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-09-28 17:45:59 +00:00
skia-autoroll
af1eb6bc6c Roll third_party/externals/swiftshader 56eacf05131c..90c0c55edc97 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/56eacf05131c..90c0c55edc97


git log 56eacf05131c..90c0c55edc97 --date=short --no-merges --format='%ad %ae %s'
2018-09-28 merckhung@google.com Explicitly include Android.mk for only OpenGL


Created with:
  gclient setdep -r third_party/externals/swiftshader@90c0c55edc97

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=bsalomon@google.com

Change-Id: I5164d761e212e0b967f15336c81e50aea149282d
Reviewed-on: https://skia-review.googlesource.com/157880
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-09-28 17:37:27 +00:00
Hal Canary
d791a6f496 SkPDF: code cleanup - to_path(SkRect)
Change-Id: Id4668ab2eba2c1ff7253b382989ec93da8119948
Reviewed-on: https://skia-review.googlesource.com/157820
Commit-Queue: Ben Wagner <bungeman@google.com>
Auto-Submit: Hal Canary <halcanary@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2018-09-28 16:46:54 +00:00
Herb Derby
d9e732185e Have Renderer use combined path code - v2
Currently, the GPU code uses the unified code path
in painter to draw. Have the remote glyph cache use it too.

Moved a function out of the GPU flag.

Change-Id: I1d0bfc7edff0fd8731ea6cbf0b5b05aad537c3c6
Reviewed-on: https://skia-review.googlesource.com/157760
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-09-28 16:09:20 +00:00
Brian Osman
41576877bd Reland "Reland "Preserve colorType and alphaType in SkImage::makeColorSpace""
This reverts commit 11f4994b84.

Reason for revert: Codec change should fix the layout test failures?

Original change's description:
> Revert "Reland "Preserve colorType and alphaType in SkImage::makeColorSpace""
> 
> This reverts commit 893052ea51.
> 
> Reason for revert: Chrome roll layout failures.
> 
> Original change's description:
> > Reland "Preserve colorType and alphaType in SkImage::makeColorSpace"
> > 
> > This reverts commit 0d08b3e4b1.
> > 
> > Reason for revert: Fixed Chrome test.
> > 
> > Original change's description:
> > > Revert "Preserve colorType and alphaType in SkImage::makeColorSpace"
> > > 
> > > This reverts commit d842557c07.
> > > 
> > > Reason for revert: Chrome roll failing CanvasAsyncBlobCreatorTest.ColorManagedConvertToBlob test.
> > > 
> > > Original change's description:
> > > > Preserve colorType and alphaType in SkImage::makeColorSpace
> > > > 
> > > > Raster images were always converting to N32, and GPU images were
> > > > always converting to premul. These were unexpected and inconsistent.
> > > > 
> > > > Bug: skia:8382
> > > > Change-Id: I78fe6cff1208eef077a71d08e676cf8f8d5fed9a
> > > > Reviewed-on: https://skia-review.googlesource.com/156142
> > > > Commit-Queue: Brian Osman <brianosman@google.com>
> > > > Reviewed-by: Mike Klein <mtklein@google.com>
> > > 
> > > TBR=mtklein@google.com,brianosman@google.com
> > > 
> > > Change-Id: I366b097644ac1fa920fc9addcad3e09c2a0a63cc
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: skia:8382
> > > Reviewed-on: https://skia-review.googlesource.com/156184
> > > Reviewed-by: Brian Osman <brianosman@google.com>
> > > Commit-Queue: Brian Osman <brianosman@google.com>
> > 
> > TBR=mtklein@google.com,brianosman@google.com
> > 
> > Change-Id: I860f33a1d57e0e77ce63b78d66d49a1082d2b4dd
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: skia:8382
> > Reviewed-on: https://skia-review.googlesource.com/156188
> > Reviewed-by: Brian Osman <brianosman@google.com>
> > Commit-Queue: Brian Osman <brianosman@google.com>
> 
> TBR=mtklein@google.com,brianosman@google.com
> 
> Change-Id: Ib53912d014916374e5d0ee3d224ba69d41a5018c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:8382
> Reviewed-on: https://skia-review.googlesource.com/156360
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>

TBR=mtklein@google.com,brianosman@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: skia:8382
Change-Id: I3bd7109dd380b6ef213883074c3b07d19ba6ca37
Reviewed-on: https://skia-review.googlesource.com/157743
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-09-28 15:40:50 +00:00
Brian Osman
87311c6e56 Remove SkPM4fPriv.h includes, then IWYU
Bug: skia:
Change-Id: Ie59aace6ba7ca3685d481fcb3af508629c56f0c3
Reviewed-on: https://skia-review.googlesource.com/157742
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-09-28 15:17:04 +00:00
skia-autoroll
c84145e312 Roll third_party/externals/swiftshader 8c5ca8d1a7ea..56eacf05131c (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/8c5ca8d1a7ea..56eacf05131c


git log 8c5ca8d1a7ea..56eacf05131c --date=short --no-merges --format='%ad %ae %s'
2018-09-28 capn@google.com Silently ignore attempts to delete default VAO.


Created with:
  gclient setdep -r third_party/externals/swiftshader@56eacf05131c

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=bsalomon@google.com

Change-Id: I33f812f3a4cb98a163bfbcfa29dce0660eb3d007
Reviewed-on: https://skia-review.googlesource.com/157681
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-09-28 15:13:18 +00:00
Brian Osman
84f8a61e41 Support encoding/decoding F16 without a color space
Change encode-srgb-* to exercise this code. The encoders
handle this just fine, so just remove those checks. The
decoders still rely on having a color space, so detect
and fix this inside SkCodec. Eventually I'd like to get
rid of the swizzler, use skcms for all format conversion,
etc... but that's a really big change, and this will let
us land other changes without breaking layout tests.

Bug: skia:8382
Change-Id: I8d85bf44ee3a287ad295515a745ded2ff5051417
Reviewed-on: https://skia-review.googlesource.com/156627
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-09-28 15:05:59 +00:00
Hal Canary
805fe3b83d SkPDF: remove unused function
Change-Id: Ic5c23ec231acad43ee49eb7854373d7be090c101
Reviewed-on: https://skia-review.googlesource.com/157180
Commit-Queue: Ben Wagner <bungeman@google.com>
Auto-Submit: Hal Canary <halcanary@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2018-09-28 14:16:57 +00:00
Hal Canary
b5b7279349 SkPDF: no over-allocating stack that won't be used.
Change-Id: I27c0609a2be6ea18879cfc799f969b7a2a72cd06
Reviewed-on: https://skia-review.googlesource.com/157741
Auto-Submit: Hal Canary <halcanary@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-09-28 14:14:57 +00:00
Brian Salomon
23952e2694 Remove legacy GrGLFunction specialization
Requires https://chromium-review.googlesource.com/c/chromium/src/+/1224660
to land.
Bug: skia:8262
Change-Id: I278360315d408e54e04d2e8e331e0be0b76a0d77
Reviewed-on: https://skia-review.googlesource.com/154501
Commit-Queue: Brian Salomon <bsalomon@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2018-09-28 13:43:37 +00:00
Michael Ludwig
d3a357db87 Remove recursion from setData() in GrGLSLFragmentProcessor
Bug: skia:8417
Change-Id: Ida8517b959e7d521ae3ebd002ae84e4c55008ad2
Reviewed-on: https://skia-review.googlesource.com/157423
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2018-09-28 13:14:35 +00:00
Mike Klein
f88f49d2a5 Revert "Have Renderer use combined path code"
This reverts commit 5dee1802ae.

Reason for revert: breaking ios-simulator bot on Chrome roll.
Something to do with SK_SUPPORT_GPU?

https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8934155862192553888/+/steps/compile__with_patch_/0/stdout

Original change's description:
> Have Renderer use combined path code
> 
> Currently, the GPU code uses the unified code path
> in painter to draw. Have the remote glyph cache use it too.
> 
> Change-Id: Ibb1728a9602dbb3ace3a57781c5e7a20cdbe3cdf
> Reviewed-on: https://skia-review.googlesource.com/157521
> Reviewed-by: Mike Klein <mtklein@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

TBR=mtklein@google.com,herb@google.com

Change-Id: Ica31880f38a9d3a62a8616e64cbb84e6ae9827a4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/157740
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-09-28 12:07:02 +00:00
skia-autoroll
10d12834c8 Roll third_party/externals/angle2 e8dd07969872..af0f31d3a909 (2 commits)
e8dd079698..af0f31d3a9


git log e8dd07969872..af0f31d3a909 --date=short --no-merges --format='%ad %ae %s'
2018-09-28 jiawei.shao@intel.com Enable several end2end tests on Windows Intel drivers
2018-09-28 jgilbert@mozilla.com Polyfill BitCount for ARM/ARM64 on MSVC.


Created with:
  gclient setdep -r third_party/externals/angle2@af0f31d3a909

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=bsalomon@google.com

Change-Id: I25ac64e487e3eff0b3523696e7b3ca2c86d89dac
Reviewed-on: https://skia-review.googlesource.com/157680
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-09-28 08:42:36 +00:00
Chris Dalton
d004e0b55c Cleanup resource flags
Converts GrResourceProvider::Flags and GrResourceCache::ScratchFlags
to "enum class" and fixes a case where we were accidentally using the
wrong type of flag. Makes sure to allocate GrSWMaskHelper proxies with
kNoPendingIO.

Bug: skia:8351
Change-Id: Ibcaa26314a53d0cb31ae22915ab94ab0fc07e76d
Reviewed-on: https://skia-review.googlesource.com/157280
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
2018-09-27 23:40:23 +00:00
skia-autoroll
b726c89ff8 Roll third_party/externals/angle2 122919bddd98..e8dd07969872 (4 commits)
122919bddd..e8dd079698


git log 122919bddd98..e8dd07969872 --date=short --no-merges --format='%ad %ae %s'
2018-09-27 jmadill@chromium.org Vulkan: Make vk::FramebufferHelper the graph resource.
2018-09-27 jmadill@chromium.org Vulkan: Make Buffer/Image be CommandGraphResources.
2018-09-27 jmadill@chromium.org Vulkan: Move LineLoopHelper graph work into BufferVk.
2018-09-27 geofflang@chromium.org Vulkan: Make sure the default uniform info arrays match indices.


Created with:
  gclient setdep -r third_party/externals/angle2@e8dd07969872

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=bsalomon@google.com

Change-Id: Iae66204b9aac51ebad9fc585e68cf71ed5e49379
Reviewed-on: https://skia-review.googlesource.com/157483
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-09-27 23:37:27 +00:00
Ben Wagner
6112f0b068 Detect macOS font smoothing behavior.
In macOS 14 the font smoothing behavior was changed. On macOS 13 and lower
requesting smoothing would either do nothing or apply fake bolding and
subpixel coverage, depending on a user setting. On macOS 14 this same user
setting causes smoothing to either do nothing or apply fake bolding. Skia
had been checking for subpixel coverage to know whether to ask for
smoothing, but since subpixel coverage is no longer provided Skia won't
ask for smoothing. However, some still want to see the fake bolding.

This changes behavior in Skia to detect if requesting smoothing does not
change the rendering, if it changes the rendering, or if it changes the
rendering and applies subpixel coverage. The code which conflated the
changing of rendering and subpixel coverage is updated to check for the
appropriate conditions.

This has the odd effect of making the setLCDRenderText setting in Skia on
macOS 14 not actually turn on subpixel coverage but instead apply
fake-bolding to closest match the behavior of the request on previous
versions of macOS.

Bug: chromium:858861
Change-Id: Ic7ff22e171a15be20e0bcccb10b0c4798cba8b72
Reviewed-on: https://skia-review.googlesource.com/157566
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>
2018-09-27 21:54:03 +00:00
Greg Daniel
25ceb1c171 Remove assert about top left origin in lazy image generator unique key.
Bug: skia:8421
Change-Id: I0af5add66eb0209b1a523a79c7777a98793c97df
Reviewed-on: https://skia-review.googlesource.com/157571
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
2018-09-27 21:23:31 +00:00
Herb Derby
5dee1802ae Have Renderer use combined path code
Currently, the GPU code uses the unified code path
in painter to draw. Have the remote glyph cache use it too.

Change-Id: Ibb1728a9602dbb3ace3a57781c5e7a20cdbe3cdf
Reviewed-on: https://skia-review.googlesource.com/157521
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-09-27 20:44:18 +00:00
Nathan Rogers
815737cf7d Fix a typo in SkISize comments
Change-Id: I94597214ea3c7e3c0b5f88c42378061f0d217da2
Reviewed-on: https://skia-review.googlesource.com/157400
Reviewed-by: Brian Osman <brianosman@google.com>
Auto-Submit: Nathan Rogers <nathanrogers@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-09-27 20:27:18 +00:00
Brian Salomon
1620b87565 Reland "Change how GrTextureOp computes outset vertices."
This is a reland of 42e086cd2d

Original change's description:
> Change how GrTextureOp computes outset vertices.
> 
> Rather than intersecting outset edge equations we outset each vertex
> half a pixel along its two adjacent edges.
> 
> This approach will allow for water tight seams along shared edges
> when we allow a subset of the quad edges to be antialiased.
> 
> Bug: skia:
> Change-Id: I7f36ea658cc84dfcf364b138ec382bb709c278df
> Reviewed-on: https://skia-review.googlesource.com/156742
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Brian Salomon <bsalomon@google.com>

Bug: skia:
Change-Id: I518ddf1d1bd6d7b8234db9ccba3c495eb42f3f1d
Reviewed-on: https://skia-review.googlesource.com/157562
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-09-27 20:14:27 +00:00
Leon Scroggins III
5dd47e4f15 Make SkCodec truly default to sRGB
Remove SkEncodedInfo::ICCProfile::MakeSRGB. Instead of creating
this object whenever there is no encoded color profile, just
treat null as sRGB, like skcms does.

This may help with crbug.com/887372. Regardless it simplifies the
code.

Also fix a bug where SkCodec could have passed a null
skcms_ICCProfile to skcms_ApproximatelyEqualProfiles (related
to b/116608007).

Bug: chromium:887372
Change-Id: I2374e8d8a1aed261f1291b7f6fd6c7ea662f26fd
Reviewed-on: https://skia-review.googlesource.com/157561
Auto-Submit: Leon Scroggins <scroggo@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2018-09-27 20:08:06 +00:00
Eric Boren
84ae6410b9 [infra] Add nightly UpdateGoDEPS
The go_deps asset is almost two months old...

Bug: skia:
Change-Id: I3910d1812a3c8ec4b599e959b76f8d60202b877a
Reviewed-on: https://skia-review.googlesource.com/157425
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
2018-09-27 19:54:26 +00:00
Dominic Mazzoni
656cefe65d Add initial support for generating tagged PDFs.
Adds an interface for the document creator to pass in a tree
of tags indicating the structure of the document, each with a type
(from a predetermined enum of possible types) and a node ID.
It also adds a setNodeId function to SkCanvas so that page content
can be associated with a particular tag. If both the tag tree and
marked content are present, Skia can now output a properly tagged
PDF.

An example program is included. When used properly, the PDF generated
by this patch is valid and the tags are parsed properly by Adobe
Acrobat. It handles many corner cases like content that spans more
than one page, or tags that don't correspond to any marked content, or
marked content that doesn't correspond to any tags.

However, it doesn't implement all of the features of PDF accessibility
yet, there are some additional attributes that can be associated with
some tags that need to be supported, too, in order to properly tag
things like figures and tables.

Bug: skia:8148
Change-Id: I2e448eca8ded8e1b29ba685663b557ae7ad7e23e
Reviewed-on: https://skia-review.googlesource.com/141138
Reviewed-by: Hal Canary <halcanary@google.com>
2018-09-27 19:35:40 +00:00
Hal Canary
b400d4d7e0 SkPDF: Fix skia:8397, reduce RAM use, stop copying ClipStacks.
In particular:
  - GraphicStateEntry no longer holds copy of SkClipStack.
  - ContentEntries are now usually concatinated together and include
    serialized GraphicStateEntry deltas.
  - One GraphicStackState is kept on the pdfdevice, for the currently
    active ContentEntry.

16% reduction in RAM use for running all GMs through SkPDF.

97% reduction in RAM use for a particular test case:
    SkRandom rand;
    SkPaint paint;
    for (int i = 400000; i-- > 0;) {
        SkPoint p0 = {0,   (float)rand.nextRangeU(0, 792)};
        SkPoint p1 = {612, (float)rand.nextRangeU(0, 792)};
        canvas->drawLine(p0, p1, paint);
    }

Bug: skia:8397
Change-Id: Ieb86c0eabac45b120a97fe5c749fdb26d8a85267
Reviewed-on: https://skia-review.googlesource.com/157340
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Hal Canary <halcanary@google.com>
2018-09-27 19:25:21 +00:00
Herb Derby
93ba1e0041 Move ARGB fallback helper into Painter
Currently, the fallback helper is a static used by the GPU
code to handle fallback glyphs. This code must be common to
both GPU and Renderer so it needs to be in the Painter.

Change-Id: I367a87b1dc785d67996a13ee42d74f2162c1b765
Reviewed-on: https://skia-review.googlesource.com/157300
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Herb Derby <herb@google.com>
2018-09-27 19:23:02 +00:00
skia-autoroll@skia-public.iam.gserviceaccount.com
b6ef9e43d7 Roll skia/third_party/skcms 1c1d5560df11..dfd5b3a4a61f (1 commits)
https://skia.googlesource.com/skcms.git/+log/1c1d5560df11..dfd5b3a4a61f

2018-09-27 mtklein@google.com expose three more private routines


The AutoRoll server is located here: https://autoroll.skia.org/r/skcms-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=bsalomon@google.com

Change-Id: I0f3a97c445caaef856e031848d1908dcd36e8e99
Reviewed-on: https://skia-review.googlesource.com/157553
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-09-27 19:18:41 +00:00
skia-autoroll@skia-public.iam.gserviceaccount.com
7bfd7466d9 Roll skia/third_party/skcms 0eb21d4ecadd..1c1d5560df11 (1 commits)
https://skia.googlesource.com/skcms.git/+log/0eb21d4ecadd..1c1d5560df11

2018-09-27 mtklein@google.com make skcms_TransferFunction_invert public


The AutoRoll server is located here: https://autoroll.skia.org/r/skcms-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=bsalomon@google.com

Change-Id: Ibf5abe0a4bcaec4cf9e73d630e105408ebafa826
Reviewed-on: https://skia-review.googlesource.com/157552
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-09-27 18:41:30 +00:00
Brian Salomon
a17a6ab0dd Call XInitThreads in sk_app startup
Change-Id: Iea03196045272b04a8de4a21c72e060567fd92f5
Reviewed-on: https://skia-review.googlesource.com/157428
Auto-Submit: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>
2018-09-27 17:54:51 +00:00
skia-autoroll
e0b6296b51 Roll third_party/externals/swiftshader 40a6005e7a14..8c5ca8d1a7ea (5 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/40a6005e7a14..8c5ca8d1a7ea


git log 40a6005e7a14..8c5ca8d1a7ea --date=short --no-merges --format='%ad %ae %s'
2018-09-27 loganchien@google.com Reactor: Fix Trunc generic code generation
2018-09-27 loganchien@google.com Reactor: Fix Frac generic code generation
2018-09-27 loganchien@google.com Reactor: Fix RoundInt generic code generation
2018-09-27 loganchien@google.com Reactor: Fix Round (float) generic code generation
2018-09-27 loganchien@google.com Reactor: Add check to SSE-specifc code for UShort4


Created with:
  gclient setdep -r third_party/externals/swiftshader@8c5ca8d1a7ea

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=bsalomon@google.com

Change-Id: Idcfad52f3f4d995bf6b648a94c484b207be7ecf6
Reviewed-on: https://skia-review.googlesource.com/157482
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-09-27 17:49:57 +00:00
Ben Wagner
dbdd151b1c Revert "bump NDK packages to r18"
This reverts commit 9875bf5ef4.

Reason for revert: Killing ASAN bots.

Original change's description:
> bump NDK packages to r18
> 
> Newer Clang, GCC is gone.
> 
> Clang now supports half-float math on ARMv8, which is pretty neat.
> 
> They've dropped support for everything below NDK version 16,
> which happens to be what we target for 32-bit ARM.
> 
> Change-Id: Idd1b1b557c5ecaabec4040026fd2ad5adfee5ee7
> Reviewed-on: https://skia-review.googlesource.com/157260
> Reviewed-by: Derek Sollenberger <djsollen@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

TBR=djsollen@google.com,mtklein@google.com

Change-Id: Iea97d710ed9f17cb38bd08237e8da714ba42ce12
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/157430
Reviewed-by: Ben Wagner <benjaminwagner@google.com>
Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-09-27 17:24:38 +00:00
skia-autoroll
61d7ecd3dd Roll third_party/externals/swiftshader 4241ad731a8a..40a6005e7a14 (3 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/4241ad731a8a..40a6005e7a14


git log 4241ad731a8a..40a6005e7a14 --date=short --no-merges --format='%ad %ae %s'
2018-09-27 loganchien@google.com Reactor: Fix Floor generic code generation
2018-09-27 loganchien@google.com Reactor: Fix add/sub sat generic code generation
2018-09-27 loganchien@google.com Reactor: Cleanup indentations


Created with:
  gclient setdep -r third_party/externals/swiftshader@40a6005e7a14

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=bsalomon@google.com

Change-Id: Iea2b16817d57945a72616e900f2c4b15ffc4d6eb
Reviewed-on: https://skia-review.googlesource.com/157481
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-09-27 17:02:52 +00:00
Brian Osman
3a5ff10863 Remove redundant SkImage virtuals
Bug: skia:
Change-Id: Ie2c59b2363a8ac3dee2a835d94c4106f4692aa24
Reviewed-on: https://skia-review.googlesource.com/157426
Auto-Submit: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
2018-09-27 16:59:52 +00:00
Brian Osman
e2a801ddaa Revert "Reland "Implement an explicit binary search-based analytic gradient colorizer""
This reverts commit f065907ccc.

Reason for revert: Processor test failing (inconsistently) on several bots.

Original change's description:
> Reland "Implement an explicit binary search-based analytic gradient colorizer"
> 
> This reverts commit 9461dcf130.
> 
> Reason for revert: Fixes for ANGLE's incorrect shader behavior
> 
> Original change's description:
> > Revert "Implement an explicit binary search-based analytic gradient colorizer"
> >
> > This reverts commit dcc85fc610.
> >
> > Reason for revert: ANGLE is frequently corrupted, particularly radial_gradient4 and mixershader
> >
> > Original change's description:
> > > Implement an explicit binary search-based analytic gradient colorizer
> > >
> > > Provides a reasonably flexible fragment processor that defines another
> > > colorizer implementation for gradients. It can support up to 8
> > > interpolation intervals (which is 16 colors if every stop is a hard stop
> > > or 9 colors if every stop is a smooth transition). It
> > > supports mixtures of hard and smooth stops. It is conditionally compiled
> > > into versions specific to the interval count (so it can produce up to
> > > 8 shader variants).
> > >
> > > The GrGradientShader controller does not remove the single and dual
> > > interval colorizers, which are useful specializations of this explicit
> > > binary search colorizer. Similarly, since it can only handle up to 8
> > > intervals, the texture colorizer is still used as a fallback.
> > >
> > > Currently it does not employ capabilities detection to determine if the
> > > hardware can support the number of required uniforms, which can become
> > > substantial for the larger gradient configurations.
> > >
> > > Bug: chromium:796479, chromium:729727, chromium:696603, chromium:543625, chromium:414254
> > > Change-Id: Ia1f735a5019766ae4796cc22964b2913db34b95b
> > > Reviewed-on: https://skia-review.googlesource.com/155080
> > > Commit-Queue: Michael Ludwig <michaelludwig@google.com>
> > > Reviewed-by: Brian Osman <brianosman@google.com>
> >
> > TBR=bsalomon@google.com,brianosman@google.com,michaelludwig@google.com
> >
> > Change-Id: I351a387f0528e4c2db2d47ab2e5d6b336991fb98
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: chromium:796479, chromium:729727, chromium:696603, chromium:543625, chromium:414254
> > Reviewed-on: https://skia-review.googlesource.com/156541
> > Reviewed-by: Michael Ludwig <michaelludwig@google.com>
> > Commit-Queue: Michael Ludwig <michaelludwig@google.com>
> 
> TBR=bsalomon@google.com,brianosman@google.com,michaelludwig@google.com
> 
> Change-Id: I2aca36307d88c26905d860ec29417ec68c6037cc
> Bug: chromium:796479, chromium:729727, chromium:696603, chromium:543625, chromium:414254
> Reviewed-on: https://skia-review.googlesource.com/156542
> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
> Commit-Queue: Michael Ludwig <michaelludwig@google.com>

TBR=bsalomon@google.com,brianosman@google.com,michaelludwig@google.com

Change-Id: Icd925d568d8cdffdc3020c07a9c50a4aa9cf0bb9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:796479, chromium:729727, chromium:696603, chromium:543625, chromium:414254
Reviewed-on: https://skia-review.googlesource.com/157429
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
2018-09-27 16:50:52 +00:00
Brian Salomon
ab3144c3ab Revert "Change how GrTextureOp computes outset vertices."
This reverts commit 42e086cd2d.

Reason for revert: Breaking layout tests (just need rebaseline)

Original change's description:
> Change how GrTextureOp computes outset vertices.
> 
> Rather than intersecting outset edge equations we outset each vertex
> half a pixel along its two adjacent edges.
> 
> This approach will allow for water tight seams along shared edges
> when we allow a subset of the quad edges to be antialiased.
> 
> Bug: skia:
> Change-Id: I7f36ea658cc84dfcf364b138ec382bb709c278df
> Reviewed-on: https://skia-review.googlesource.com/156742
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Brian Salomon <bsalomon@google.com>

TBR=bsalomon@google.com,brianosman@google.com

Change-Id: I0f293dda19507a0af33cadf24b8b5f807d391d9a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:
Reviewed-on: https://skia-review.googlesource.com/157427
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-09-27 16:27:30 +00:00
Mike Klein
512a24450f only build stats bar chart when it'll be printed
I keep seeing it show up on the profile(usually under memmove) of tight
benchmarks and it's kind of distracting.  We don't even print it when
we pass --quiet, so that seems like a nice way to stifle it.

Change-Id: I3a67a7ca1758fd35e3b63cfeeddeac4ff1ffe38d
Reviewed-on: https://skia-review.googlesource.com/157520
Auto-Submit: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2018-09-27 16:22:54 +00:00
Florin Malita
97b150e73b [skottie] External font loader tweaks
More general ResourceProvider font loading API:

1) font name argument
2) invoked unconditionally (regardless of whether an URL is present)

This provides more font control to the embedder.

Change-Id: I95557c75c2e0fe41ff68ee1b6cec8929405a74fc
Reviewed-on: https://skia-review.googlesource.com/157424
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
2018-09-27 16:22:25 +00:00
Michael Ludwig
f065907ccc Reland "Implement an explicit binary search-based analytic gradient colorizer"
This reverts commit 9461dcf130.

Reason for revert: Fixes for ANGLE's incorrect shader behavior

Original change's description:
> Revert "Implement an explicit binary search-based analytic gradient colorizer"
>
> This reverts commit dcc85fc610.
>
> Reason for revert: ANGLE is frequently corrupted, particularly radial_gradient4 and mixershader
>
> Original change's description:
> > Implement an explicit binary search-based analytic gradient colorizer
> >
> > Provides a reasonably flexible fragment processor that defines another
> > colorizer implementation for gradients. It can support up to 8
> > interpolation intervals (which is 16 colors if every stop is a hard stop
> > or 9 colors if every stop is a smooth transition). It
> > supports mixtures of hard and smooth stops. It is conditionally compiled
> > into versions specific to the interval count (so it can produce up to
> > 8 shader variants).
> >
> > The GrGradientShader controller does not remove the single and dual
> > interval colorizers, which are useful specializations of this explicit
> > binary search colorizer. Similarly, since it can only handle up to 8
> > intervals, the texture colorizer is still used as a fallback.
> >
> > Currently it does not employ capabilities detection to determine if the
> > hardware can support the number of required uniforms, which can become
> > substantial for the larger gradient configurations.
> >
> > Bug: chromium:796479, chromium:729727, chromium:696603, chromium:543625, chromium:414254
> > Change-Id: Ia1f735a5019766ae4796cc22964b2913db34b95b
> > Reviewed-on: https://skia-review.googlesource.com/155080
> > Commit-Queue: Michael Ludwig <michaelludwig@google.com>
> > Reviewed-by: Brian Osman <brianosman@google.com>
>
> TBR=bsalomon@google.com,brianosman@google.com,michaelludwig@google.com
>
> Change-Id: I351a387f0528e4c2db2d47ab2e5d6b336991fb98
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:796479, chromium:729727, chromium:696603, chromium:543625, chromium:414254
> Reviewed-on: https://skia-review.googlesource.com/156541
> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
> Commit-Queue: Michael Ludwig <michaelludwig@google.com>

TBR=bsalomon@google.com,brianosman@google.com,michaelludwig@google.com

Change-Id: I2aca36307d88c26905d860ec29417ec68c6037cc
Bug: chromium:796479, chromium:729727, chromium:696603, chromium:543625, chromium:414254
Reviewed-on: https://skia-review.googlesource.com/156542
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2018-09-27 16:02:30 +00:00
Mike Klein
9875bf5ef4 bump NDK packages to r18
Newer Clang, GCC is gone.

Clang now supports half-float math on ARMv8, which is pretty neat.

They've dropped support for everything below NDK version 16,
which happens to be what we target for 32-bit ARM.

Change-Id: Idd1b1b557c5ecaabec4040026fd2ad5adfee5ee7
Reviewed-on: https://skia-review.googlesource.com/157260
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-09-27 14:56:24 +00:00
Mike Klein
9de721655c add test that setLastPt() invalidates path bounds
Spoiler alert... it doesn't.

Bug: oss-fuzz:10488
Change-Id: Ifafd92f40aed55ff14a5198ea7d79a20751e40aa
Reviewed-on: https://skia-review.googlesource.com/156661
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
2018-09-27 14:48:34 +00:00
skia-autoroll
822eecb2fb Roll third_party/externals/angle2 115e8a2625f5..122919bddd98 (1 commits)
115e8a2625..122919bddd


git log 115e8a2625f5..122919bddd98 --date=short --no-merges --format='%ad %ae %s'
2018-09-27 jmadill@chromium.org Update docs on building ANGLE inside Chromium.


Created with:
  gclient setdep -r third_party/externals/angle2@122919bddd98

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=bsalomon@google.com

Change-Id: I80b2f54ebd729fc5048750db52bef29377aa0786
Reviewed-on: https://skia-review.googlesource.com/157480
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-09-27 14:27:35 +00:00
Mike Klein
8d6b2b6f61 invalidate pathref bounds when we attach an editor
It's possible to change path bounds by changing path points using
SkPath::setLastPt(), but we don't invalidate the bounds when we do.

Seems like the best thing to do is to invalidate the bounds when
we attach an editor, the same way we invalidate the gen ID.

Bug: oss-fuzz:10488, oss-fuzz:10698
Change-Id: Idd04d37f9e39979aac135d675aa4e5949c55a453
Reviewed-on: https://skia-review.googlesource.com/156700
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
2018-09-27 14:24:50 +00:00
Mike Klein
c021e37864 update SkPathRef bounds validation
1) print out that there is a problem and
     what that problem is
  2) switch to %g so we can see very small points
  3) return false when the bounds aren't valid

Bug: oss-fuzz:10488
Change-Id: I2a8a5611ba6459f1bd45e29a1f20510401e86f76
Reviewed-on: https://skia-review.googlesource.com/156662
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
2018-09-27 14:22:30 +00:00
Ethan Nicholas
d23c819c2f fixed SPIR-V interface variable declarations
Bug: skia:
Change-Id: Ibdc975d8be672f00e30aab055358d8fe0e47e0c2
Reviewed-on: https://skia-review.googlesource.com/157222
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2018-09-27 13:34:55 +00:00
Brian Salomon
42e086cd2d Change how GrTextureOp computes outset vertices.
Rather than intersecting outset edge equations we outset each vertex
half a pixel along its two adjacent edges.

This approach will allow for water tight seams along shared edges
when we allow a subset of the quad edges to be antialiased.

Bug: skia:
Change-Id: I7f36ea658cc84dfcf364b138ec382bb709c278df
Reviewed-on: https://skia-review.googlesource.com/156742
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
2018-09-27 13:11:59 +00:00
Leon Scroggins III
227d4e1027 encodedProfile can be null, so check for that
Bug: b/116608007
Change-Id: I622165d5c63f3a8548e763899128b3eb4b8459a6
Reviewed-on: https://skia-review.googlesource.com/157420
Auto-Submit: Leon Scroggins <scroggo@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
2018-09-27 13:03:57 +00:00
skia-autoroll
b3e48afc93 Roll third_party/externals/angle2 af8b73c9e632..115e8a2625f5 (1 commits)
af8b73c9e6..115e8a2625


git log af8b73c9e632..115e8a2625f5 --date=short --no-merges --format='%ad %ae %s'
2018-09-27 jmadill@chromium.org Vulkan: Store "is packed" in buffer formats.


Created with:
  gclient setdep -r third_party/externals/angle2@115e8a2625f5

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE
TBR=bsalomon@google.com

Change-Id: I1bb88d4efbab7cf76744778d9de9f15330b1564f
Reviewed-on: https://skia-review.googlesource.com/157361
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-09-27 05:18:57 +00:00
skia-autoroll
88e4a9395a Roll third_party/externals/swiftshader 3d27f2e721ed..4241ad731a8a (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/3d27f2e721ed..4241ad731a8a


git log 3d27f2e721ed..4241ad731a8a --date=short --no-merges --format='%ad %ae %s'
2018-09-27 merckhung@google.com Include <string> for fixing undefined template on Mac.


Created with:
  gclient setdep -r third_party/externals/swiftshader@4241ad731a8a

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader
TBR=bsalomon@google.com

Change-Id: I022628dfab2cee3c42ec39992d5302b2daec86a0
Reviewed-on: https://skia-review.googlesource.com/157360
Reviewed-by: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
2018-09-27 03:34:23 +00:00